D10890: Prepare for KIO KRecentDocument fix (D10863)

[Anthony Fieroni]

anthonyfieroni added a comment.


  So why you called hack, why no just add conditional compilation against 5.44

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10588: No icons on the desktop by default

[Nathaniel Graham]

ngraham retitled this revision from "Summary: No icons on the desktop by 
default.  Dont add Home.desktop to links folder and dont add trash 
linkhttps://phabricator.kde.org/T7948; to "No icons on the desktop by default".
ngraham edited the summary of this revision.
ngraham added a task: T7948: remove default desktop icons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma, hein
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma, hein
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10896: Show config selection OSD when display button is pressed

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Hmm, I guess you can now kill `m_buttonTimer`, `m_iteration`,  
`resetDisplaySwitch()` and `applyGenericConfig()` as well, as those are used 
exclusively by the config iteration. You probably also want to check if the 
Selection OSD is already shown, otherwise pressing the Display Button multiple 
times would create multiple OSDs.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D10896

To: sebas, #plasma, dvratil
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=350684

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
 CC||n...@kde.org

--- Comment #6 from Nate Graham  ---
Thanks for the confirmation that the original issue has been fixed. In a bug
tracker, we can only track a single issue with a tingle Bugzilla ticket. Please
open a new bug (and mention it here) to track the remaining issue, and see
https://community.kde.org/Get_Involved/Bug_Reporting#One_issue_per_bug_report

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

[Lauris]

https://bugs.kde.org/show_bug.cgi?id=350684

Lauris  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REOPENED
 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Lauris  ---
In latest versions original issue I had has been fixed.

For me at least there is one more annoying thing in switching users is that if
you have logged into one user and from menu select switch user it goes to user
selection but you have no way to get back to cancel it if you have actually do
not wanted to switch or changed your mind. Only way to get back to original
session is to actually log in into same or other user and than do either logout
or switch to original session

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs updated this revision to Diff 28221.
Fuchs added a comment.


  Adapt code style.
  
  With regards to wording: even if we can't guarantee that audio is playing / 
being recorded, the wording is still correct. 
  Since if there will be audio played / recorded, it will be on the device the 
user chooses. So it makes sense.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10901?vs=28219=28221

REVISION DETAIL
  https://phabricator.kde.org/D10901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[David Rosca]

drosca added a comment.


  @ngraham This is not a new feature, only people didn't know about the 
drag functionality, which is understandable, but nevertheless the 
functionality is there for a long time already (since around Plasma 5.7/5.8).

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> ListItemBase.qml:340
> +var menuItem = newMenuItem();
> +if(type == "sink-input") {
> +menuItem.text = i18nc("Heading for a list of possible 
> output devices (speakers, headphones, ...) to choose", "Play audio using");

`if (`

> ListItemBase.qml:343
> +}
> +else {
> +menuItem.text = i18nc("Heading for a list of possible 
> input devices (built-in microphone, headset, ...) to choose", "Record audio 
> using");

`} else {` on the same line

> ListItemBase.qml:350
> +
> +
> +for (var i = 0; i < sModel.count; ++i) {

extra newline

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs marked an inline comment as done.
Fuchs added a comment.


  In D10901#215274 , @ngraham wrote:
  
  > You're definitely not the only one who wants this. See:
  >
  > - 
https://www.reddit.com/r/kde/comments/7yrkmt/my_one_and_only_wish_please_excuse_the_terrible/
  > - https://bugs.kde.org/show_bug.cgi?id=384292
  >
  >   In fact, because this implements that feature, would you mind adding 
"FEATURE: 384292" into the Summary section on its own line, below other text? 
That's a special keyword that will make that bug get closed once this lands. 
See also 
https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords
  
  
  Yeah, I read about these, I was simply too lazy to see if someone wanted 
that. Anyway, added in the summary plus commented on the bug report.
  
  The screenshot now is lost somehwere in phab backlog as it is no longer 
regarding the latest revision, but I assume you can find that :)

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs updated this revision to Diff 28219.
Fuchs added a comment.


  Move text back to if/else for at least a bit of readability, reverted the 
check to go for > 1 since that is what we are interested in. Final revision, 
hopefully.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10901?vs=28218=28219

REVISION DETAIL
  https://phabricator.kde.org/D10901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs added a comment.


  In D10901#215263 , @ngraham wrote:
  
  > At this point, let me also mention that screenshots are not only much 
appreciated, but vastly increase the chance of your patch (and name!) being 
featured in the next week's installment of 
https://pointieststick.wordpress.com/category/usability-productivity/, 
especially for a much-requested feature like this one! :)
  
  
  F5732869: hamburger.png 
  
  I'm not sure whether it is worth a mention and I think I'm the only one 
requesting it so far (might be wrong), but if you want to add me: sure. 
Screenshot above (assuming this worked, I am new to phab), the name is Fuchs. 
Thanks. And sorry for the misunderstanding.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[David Rosca]

drosca added a comment.


  +1. No more code comments.
  
  Just a note, we can't guarantee that audio is actually playing from that 
stream.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:338
> `sinkView.model.count > 1` -> `sinkView.count`

Sorry about this comment, it's nonsense. It was fine in your fist diff.

It must check `> 1` not just `> 0`.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Nathaniel Graham]

ngraham added a comment.


  At this point, let me also mention that screenshots are not only much 
appreciated, but vastly increase the chance of your patch (and name!) being 
featured in the next week's installment of 
https://pointieststick.wordpress.com/category/usability-productivity/, 
especially for a much-requested feature like this one! :)

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs updated this revision to Diff 28218.
Fuchs marked an inline comment as done.
Fuchs added a comment.


  According to discussion on IRC, sacrifice some more readability for brevity.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10901?vs=28214=28218

REVISION DETAIL
  https://phabricator.kde.org/D10901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10855: Emit clicked when double click expires

[Martin Flöser]

graesslin added a comment.


  In D10855#214923 , @broulik wrote:
  
  > > Given that I'm not sure whether the base assumption that this is not 
intuitive holds.
  >
  > Having to explain to a user what to do hardly qualifies as intuitive.
  
  
  No guarantee that users would find the new way intuitive.
  
  I kindly ask to look at the discussion ack in reviewboard when I implemented 
this feature. It was one of the most difficult changes to get in and this was 
the only solution we came up with which seemed to satisfy all concerns.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

To: broulik, #plasma, graesslin
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs updated this revision to Diff 28214.
Fuchs added a comment.


  Updated the text, tried to merge the code blocks. Due to most of it happening 
in a for loop depending on the type, this was not possible in a sane way 
without having a helper method created.
  
  Personally I think legibility goes a tad bit down. If made easier to read, 
performance would go suffer (e.g. executing parts of it despite it not going to 
be shown anyway). 
  I also think the .count variant is a bit easier to read, but take whichever 
you prefer.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10901?vs=28212=28214

REVISION DETAIL
  https://phabricator.kde.org/D10901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs added a comment.


  In D10901#215244 , @drosca wrote:
  
  >
  
  
  
  
  > Can you merge the code into one block?
  
  Technically yes, but due to some edge cases it will make it hacky and 
difficult to read.
  
  Example: you can have a second device connected which is only an output 
(bluetooth speakers), but no input. Therefore before adding the menu entries 
you have to check whether there are currently available output or input types, 
depending on the situation. 
  So there will be a lot of conditionals, not just for setting labels, but for 
actual logic.
  
  I'll see which is the least bad attempt at that and upload a second diff, but 
I am not conviced it will be nicer.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Nathaniel Graham]

ngraham added a comment.


  In D10901#215244 , @drosca wrote:
  
  > I'm not sure on the wording "Output on" "Record from", I would prefer 
simple "Move to" or "Move to device", but I am not native speaker so I leave 
others to decide.
  
  
  [puts on native English speaker hat]
  
  Here are my recommendations:
  
  - "Output on" -> "Play audio using:" (or maybe "Transfer audio to", if we can 
guarantee that something is always playing when the user will see this)
  - "Record on" -> "Record audio using:"

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  I'm not sure on the wording "Output on" "Record from", I would prefer simple 
"Move to" or "Move to device", but I am not native speaker so I leave others to 
decide.
  
  Can you merge the code into one block? As it is now, the code is duplicated 
and the only difference is that first block uses `sourceView` and second 
`sinkView`, but only one of those two blocks can ever be executed (can't be 
both sink-input and source-output).

INLINE COMMENTS

> ListItemBase.qml:338
> +// remove the second condition in the if to always show it.
> +if (type == "sink-input" && sinkView.model.count > 1) {
> +contextMenu.addMenuItem(newSeperator());

`sinkView.model.count > 1` -> `sinkView.count`

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

[Christian]

Fuchs created this revision.
Fuchs added reviewers: broulik, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Fuchs requested review of this revision.

REVISION SUMMARY
  This patch adds the possibility to choose a device for a playback / recording 
stream in the hamburger menu. 
  As per the discussion with the developers, the drag & drop functionality 
stays untouched and is still available.
  
  This is added to be a bit more consistent with the kcm and to make the 
functionality easier to discover.
  
  The menu is only shown when there are more than one possibilities to choose 
from in order to not confuse users.

TEST PLAN
  Apply patch.
  Have multiple output and input devices. 
  Move streams between devices and see if it works.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: Fuchs, broulik, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10896: Show config selection OSD when display button is pressed

[Nathaniel Graham]

ngraham retitled this revision from "show config selection osd when display 
button is pressed" to "Show config selection OSD when display button is 
pressed".
ngraham edited the summary of this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D10896

To: sebas, #plasma, dvratil
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10896: show config selection osd when display button is pressed

[Sebastian Kügler]

sebas created this revision.
sebas added reviewers: Plasma, dvratil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sebas requested review of this revision.

REVISION SUMMARY
  This makes the working of the display button much more intuitive.
  
  BUG:390096

TEST PLAN
  Tested with external display plugged in, system behaves as expected

REPOSITORY
  R104 KScreen

BRANCH
  sebas/displaybutton

REVISION DETAIL
  https://phabricator.kde.org/D10896

AFFECTED FILES
  kded/daemon.cpp

To: sebas, #plasma, dvratil
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10893: Use an action group for the sort options

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D10892: Make it possible to support exclusive 
action groups.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10893

To: apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10892: Make it possible to support exclusive action groups

[Nathaniel Graham]

ngraham added a dependent revision: D10893: Use an action group for the sort 
options.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10892

To: apol, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

D10892: Make it possible to support exclusive action groups

[Marco Martin]

mart added a comment.


  unfortunately this will need the cmake preprocessing hack it's used in 
qqc2-desktop style..
  or, you could even ship 2 candidate ActionsMenu.qml and install one or the 
other based on cmake version check

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10892

To: apol, #kirigami
Cc: mart, plasma-devel, apol, davidedmundson, hein

D10893: Use an action group for the sort options

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise we get ugly checkboxes.
  Requires Qt 5.10.
  
  BUG: 391144

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10893

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10892: Make it possible to support exclusive action groups

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We need to find away to import 2.3 if available otherwise 
modelData.Controls.ActionGroup returns null.
  
  CCBUG: 391144

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10892

AFFECTED FILES
  src/controls/private/ActionsMenu.qml
  tests/actionsMenu.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10791: Fixed the Wikimedia Commons Picture of the Day provider

[Manuel Caldeira]

manuelc planned changes to this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10791

To: manuelc, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10791: Fixed the Wikimedia Commons Picture of the Day provider

[Manuel Caldeira]

manuelc reclaimed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10791

To: manuelc, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10890: Prepare for KIO KRecentDocument fix (D10863)

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added reviewers: Plasma, broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  Revision D10863  introduced a fix which 
makes the application stored
  in recent documents data match the application's desktop file. This
  made all workarounds with cutting 'org.kde.' prefix out of storage
  IDs irrelevant.
  
  However, given that release schedules of Plasma Desktop and Frameworks
  are independent, we can't be sure that the Frameworks version we are
  running on does contain the mentioned fix, so we need to support both
  cases until we depend on the Frameworks version which does.
  
  This commit makes kicker and taskmanager query for both  (pre-
  D10863 ) and org.kde. (post-D10863) 
agents. As a bonus, this also
  fixes a bug when items opened from e.g. Dolphin don't show up in recent
  documents in kicker's and taskmanager's application context menus.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10887: Show a radiobutton when we are showing an exclusive control

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:55dbbdb9315c: Show a radiobutton when we are showing an 
exclusive control (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10887?vs=28183=28184

REVISION DETAIL
  https://phabricator.kde.org/D10887

AFFECTED FILES
  org.kde.desktop/CheckIndicator.qml

To: apol, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10887: Show a radiobutton when we are showing an exclusive control

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10887

To: apol, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10887: Show a radiobutton when we are showing an exclusive control

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  CCBUG: 391144

TEST PLAN
  MenuItem { autoExclusive: true } shows radio buttons instead of check boxes

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10887

AFFECTED FILES
  org.kde.desktop/CheckIndicator.qml

To: apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10885: Cleanup dbus interface, add dbus recipeskill method

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:2e8a1ec7cfbf: Cleanup dbus interface, add dbus 
recipeskill method (authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10885?vs=28179=28180

REVISION DETAIL
  https://phabricator.kde.org/D10885

AFFECTED FILES
  plasmoid/contents/ui/RecipeDelegate.qml
  plasmoid/contents/ui/RecipeType.qml
  plasmoid/contents/ui/main.qml
  plugin/mycroftplasmoid_dbus.cpp
  plugin/mycroftplasmoid_dbus.h

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10885: Cleanup dbus interface, add dbus recipeskill method

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Ref T7174  cleaned up dbus interface, 
added method and signal for food wizard skill

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10885

AFFECTED FILES
  plasmoid/contents/ui/RecipeDelegate.qml
  plasmoid/contents/ui/RecipeType.qml
  plasmoid/contents/ui/main.qml
  plugin/mycroftplasmoid_dbus.cpp
  plugin/mycroftplasmoid_dbus.h

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10878: Changed default context menu entries on the desktop

[Alex Nemeth]

anemeth abandoned this revision.
anemeth added a comment.


  This is not removing settings, just disabling them by default. These could be 
enabled in the standard right click menu settings again.
  
  F5732210: Képkivágás.PNG 
  
  I'll abandon this revision because the consensus is people don't like the 
simplified context menu.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: mart, rizzitello, zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10855: Emit clicked when double click expires

[Kai Uwe Broulik]

broulik added a comment.


  > Given that I'm not sure whether the base assumption that this is not 
intuitive holds.
  
  Having to explain to a user what to do hardly qualifies as intuitive.
  
  > The behavior by the way was inspired by other components such as toolbar 
buttons with dropdown list which also implement press and hold.
  
  Which doesn't make them less painful to use.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10855

To: broulik, #plasma, graesslin
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10878: Changed default context menu entries on the desktop

[Marco Martin]

mart added a comment.


  -1 as well, removing entries is a no go, especially I won't accept the 
removal of anything related to widget manipulation

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10878

To: anemeth, #plasma, #vdg
Cc: mart, rizzitello, zzag, jnoack, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Alex Barrero]

https://bugs.kde.org/show_bug.cgi?id=350365

Alex Barrero  changed:

   What|Removed |Added

 CC||alex.brrsc...@gmail.com

--- Comment #18 from Alex Barrero  ---
I confirm this error also on KDE Neon User Edition with KDE Plasma 5.12.2, KDE
Frameworks 5.43.0 on my Toshiba Satellite Pro A50-C

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10835: [kicker] Never execute recent documents

[Алексей Шилин]

aleksejshilin marked 3 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10835

To: aleksejshilin, #plasma
Cc: hein, anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10835: [kicker] Never execute recent documents

[Алексей Шилин]

aleksejshilin updated this revision to Diff 28171.
aleksejshilin added a comment.


  - Use proper coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10835?vs=28032=28171

BRANCH
  always_open_recent_documents

REVISION DETAIL
  https://phabricator.kde.org/D10835

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: aleksejshilin, #plasma
Cc: hein, anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart