D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:7b742db8ddfd: Save the dialog view settings when closing 
the dialog without hitting the… (authored by ngraham).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12240?vs=32361=32430

REVISION DETAIL
  https://phabricator.kde.org/D12240

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SettingsBase.cpp:82
> > qreal factor = qBound(1.0, 
> > QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);
> 
> I know you were told to change to this, but don't do that.
> 
> Qt will scale the size you give it here by the devicePixelRatio. This is 
> scaling it twice which we don't want to do.
> 
> We shouldn't need to be doing any custom high DPI code in window sizing.

So should I just run the "preferred size" (1024x760) through the `boundedTo` 
function for odd-sized screens? In other words, ditch the scale factor 
completely? As in:

  const QSize screenSize = 
(QGuiApplication::primaryScreen()->availableSize()*0.9);
  const QSize targetSize = QSize(1024, 700);
  return targetSize.boundedTo(screenSize);

I thought I'd ask before updating the diff for the 19th time.  :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey added a comment.


  In D12252#248478 , @cfeck wrote:
  
  > OMG, for whatever reason, I was assuming this is about the file dialog 
window size. You are working on too many things at once, Nathan :)
  
  
  And don't forget about poor, poor, pitiful me, who asked for a list of things 
to work on. :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Nathaniel Graham]

ngraham added a comment.


  In D12252#248478 , @cfeck wrote:
  
  > OMG, for whatever reason, I was assuming this is about the file dialog 
window size. You are working on too many things at once, Nathan :)
  
  
  Hehe, if you want to review some of those, they're right here, ready and 
waiting!
  
  - https://phabricator.kde.org/D12149
  - https://phabricator.kde.org/D12077
  - https://phabricator.kde.org/D12215
  - https://phabricator.kde.org/D12218
  - https://phabricator.kde.org/D12227
  - https://phabricator.kde.org/D12240

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Christoph Feck]

cfeck added a comment.


  OMG, for whatever reason, I was assuming this is about the file dialog window 
size. You are working on too many things at once, Nathan :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> zzag wrote in SettingsBase.cpp:82
> You forgot `const`.
> 
> Also, you could multiply whole QSize by `factor` so Qt will round width and 
> height. ;-)

> qreal factor = qBound(1.0, 
> QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);

I know you were told to change to this, but don't do that.

Qt will scale the size you give it here by the devicePixelRatio. This is 
scaling it twice which we don't want to do.

We shouldn't need to be doing any custom high DPI code in window sizing.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12137: Use consistent spacing and units for suffixes in spinboxes

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 32427.
kossebau added a comment.


  try other context pattern: spacing to number + unit

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12137?vs=31945=32427

BRANCH
  fixsecondssuffix

REVISION DETAIL
  https://phabricator.kde.org/D12137

AFFECTED FILES
  applets/comic/package/contents/ui/configAdvanced.qml
  applets/comic/package/contents/ui/configGeneral.qml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: kossebau, #plasma, #localization, davidedmundson
Cc: aacid, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, skadinna, 
huftis, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12137: Use consistent spacing and units for suffixes in spinboxes

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D12137#245104 , @aacid wrote:
  
  > is appendix something people would understand? because for me is "the 
things that kills you if you're unlucky", "the end chapter of a book".
  
  
  Good question. I run chance of creating garbage english given I have no real 
contact to native speakers and a fantasy-driven language brain ;)
  
  Update of patch coming with a new wording proposal.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixsecondssuffix

REVISION DETAIL
  https://phabricator.kde.org/D12137

To: kossebau, #plasma, #localization, davidedmundson
Cc: aacid, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, skadinna, 
huftis, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Nathaniel Graham]

ngraham added a comment.


  In D12252#248458 , @cfeck wrote:
  
  > I still object to enforce a minimum size. On my main system, I use a 4K 
screen, and having a file dialog span nearly the complete screen is irritating, 
and mostly unusable because I have to travel a lot to reach buttons.
  
  
  That's a separate bug that's irrelevant to this issue. We should fix that. If 
you can test (I don't have a 4K screen), I can submit a patch.
  
  > What is wrong with offering a good default size, and saving the size in 
case the user changes it? Why is there a need to enforce the default size as 
the minimum size?
  
  Can you outline the use case for having a large screen but wanting to resize 
the System Settings window to be so small that many KCMs become borderline 
unusable? We do save the user-specified size; this patch only prevents users 
with large screens from making the window so small that usability suffers.

REPOSITORY
  R124 System Settings

BRANCH
  enlarge-default-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Christoph Feck]

cfeck added a comment.


  I still object to enforce a minimum size. On my main system, I use a 4K 
screen, and having a file dialog span nearly the complete screen is irritating, 
and mostly unusable because I have to travel a lot to reach buttons.
  
  What is wrong with offering a good default size, and saving the size in case 
the user changes it? Why is there a need to enforce the default size as the 
minimum size?

REPOSITORY
  R124 System Settings

BRANCH
  enlarge-default-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12288: [mediaframe applet] Support creation of widget on file drop on containment

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:bf365c818e92: [mediaframe applet] Support creation of 
widget on file drop on containment (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12288?vs=32402=32407

REVISION DETAIL
  https://phabricator.kde.org/D12288

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml
  applets/mediaframe/package/metadata.desktop

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:7a0b14bf1313: [mediaframe applet] Fix defunct adding of 
new files/folder per DnD (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12287?vs=32400=32406

REVISION DETAIL
  https://phabricator.kde.org/D12287

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12288: [mediaframe applet] Support creation of widget on file drop on containment

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Depends: D12287 

TEST PLAN
  Dropping an image file (of listed MIME type) or a folder adds the Media
  Frame widget to list of widgets proposed to be added for that file/folder,
  selecting it then creates an instance with the given file/folder being set
  as source.

REPOSITORY
  R114 Plasma Addons

BRANCH
  supportcreatingmediaframeonfiledrop

REVISION DETAIL
  https://phabricator.kde.org/D12288

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml
  applets/mediaframe/package/metadata.desktop

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Target: 5.12 branch (drop not working is a regression compared to plasma4 
version, also does applet indicate it supports the drop on hover)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12287

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  It was broken for 2 reasons:
  
  - usage of since-renamed MediaFrame::has() method
  - calling push() directly on plasmoid.configuration.pathList was no-op due to 
QTBUG-67773

TEST PLAN
  Dropping files & folders onto an existing mediaframe widget results in the
  files & folders being added now.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixaddingbydropmediaframe

REVISION DETAIL
  https://phabricator.kde.org/D12287

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12134: [mediaframe applet] Fix broken selection of fill mode

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:faa26503b68f: [mediaframe applet] Fix broken selection of 
fill mode (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12134?vs=31941=32396

REVISION DETAIL
  https://phabricator.kde.org/D12134

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Andres Betts]

abetts added a comment.


  Could it be possible, just to agree with the team, to have a small preview of 
a sample window showing the colors? Something like this:
  
  https://macgui.com/downloads/?cat_id=10

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Vlad Zagorodniy]

zzag added a comment.


  In D12256#248144 , @broulik wrote:
  
  > This is master-only code, right?
  
  
  Yes, it's master-only.
  
  > The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.
  
  So, given that, should I bump version or leave this patch as is?

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  > Make the "apply to non Qt apps" checkbox work (no idea why anyone would 
want to uncheck this, though)
  
  Does this setting even still work? I believe support for it is spotty to 
nonexistent in today's GTK3 apps.
  
  I would be in favor of removing the control from this page and turning the 
setting either on  or off by default, and relocating it to somewhere more 
hidden if necessary.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  It would be really cool if the delegates would show a little preview of a 
window actually using these colors, instead of the current grid of colored 
squares.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Kai Uwe Broulik]

broulik added a comment.


  This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 
5.46 so this should be fine.

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[David Edmundson]

davidedmundson added a comment.


  > Not too fond of this "Current"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10112: watch the tabletMode from KWin

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ad404dd92962: watch the tabletMode from KWin (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10112?vs=32380=32381#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10112?vs=32380=32381

REVISION DETAIL
  https://phabricator.kde.org/D10112

AFFECTED FILES
  CMakeLists.txt
  examples/gallerydata/contents/ui/gallery/MiscGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  src/CMakeLists.txt
  src/controls/BasicListItem.qml
  src/controls/private/ActionButton.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/ScrollView.qml
  src/libkirigami/CMakeLists.txt
  src/libkirigami/org.kde.KWin.TabletModeManager.xml
  src/libkirigami/tabletmodewatcher.cpp
  src/libkirigami/tabletmodewatcher.h
  src/settings.cpp
  src/settings.h

To: mart, #plasma, #kirigami, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D10112: watch the tabletMode from KWin

[Marco Martin]

mart updated this revision to Diff 32380.
mart added a comment.


  - Merge branch 'master' into mart/tabletMode
  - separe isMobile and tabletmode concepts
  - Merge branch 'master' into mart/tabletMode
  - use tabletMode instead of isMobile where needed
  - new env var KDE_KIRIGAMI_TABLET_MODE
  - comments++
  - more comments
  - enable/disable the swipeitemeventfilter

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10112?vs=25986=32380

BRANCH
  mart/tabletMode

REVISION DETAIL
  https://phabricator.kde.org/D10112

AFFECTED FILES
  CMakeLists.txt
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  examples/gallerydata/contents/ui/gallery/MiscGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  src/CMakeLists.txt
  src/controls/BasicListItem.qml
  src/controls/private/ActionButton.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/ScrollView.qml
  src/libkirigami/CMakeLists.txt
  src/libkirigami/org.kde.KWin.TabletModeManager.xml
  src/libkirigami/tabletmodewatcher.cpp
  src/libkirigami/tabletmodewatcher.h
  src/settings.cpp
  src/settings.h

To: mart, #plasma, #kirigami, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Vlad Zagorodniy]

zzag added subscribers: ngraham, broulik, davidedmundson.
zzag added a comment.


  @davidedmundson 
  @broulik 
  @ngraham
  
  Do you have any objections to bumping minimum required version of 
KF5FrameworkIntegration?
  
  //We need at least KF 5.45 so KCapacityBar and co have 
QStyle::State_Horizontal set.//
  //One noticeable user of KCapacityBar, for example, is Dolphin. It uses 
KCapacityBar to display space information.//

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

[Jonathan Riddell]

jriddell added a comment.


  This is to stop the build failure we get on Neon 
  
https://build.neon.kde.org/job/xenial_unstable_kde_breeze_bin_amd64/209/console

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12277

To: fvogt, #breeze, davidedmundson
Cc: jriddell, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Pretty much WIP
  What works:
  
  - Grid layout with crappy thumbnail
- The screenshots just show a quick and dirty attempt to mimic the old tiny 
icons we used to have. Perhaps either it should show *all* available colors in 
the theme but that might turn into a pixel mudd? or instead show a live preview 
of some controls, maybe a "fake window" in there?
  - Downloading color themes through GHNS

TEST PLAN
  Implements T7243 
  
  Not too fond of this "Current" (carried over from the old code). Perhaps we 
could do some magic to only show it when the current theme is not in the list 
or is a modified version of a theme? That would make the dialog less confusing 
as to what "Current" means.
  
  F5810572: Screenshot_20180417_132441.png 

  TODO:
  
  - Make applying theme work (write config and signal applications)
  - Make restore defaults work
  - Make "Install from file" work
  - Make edit work (the edit dialog is quite entangled with the code, I thought 
it was completely standalone nowadays)
  - Make removing theme work
  - Make the "apply to non Qt apps" checkbox work (no idea why anyone would 
want to uncheck this, though)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.desktop
  kcms/colors/colors.h
  kcms/colors/colorscm.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/contents/ui/main.qml
  kcms/colors/package/metadata.desktop

To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12275: FunnelModel: fix invalid model API usage.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12275

To: dfaure, hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

[Vlad Zagorodniy]

zzag added a comment.


  OK, nvmd.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12277

To: fvogt, #breeze, davidedmundson
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

[Vlad Zagorodniy]

zzag added a comment.


  Oh, God, I forgot to check Q_CC_CLANG in Qt 4.
  
  Also, that's weird Q_CC_GNU has no value in Qt 4.. 
http://doc.qt.io/archives/qt-4.8/qtglobal.html#Q_CC_GNU

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12277

To: fvogt, #breeze, davidedmundson
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f4f7b599aff5: Fix build with Qt 4 (authored by fvogt).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12277?vs=32373=32374

REVISION DETAIL
  https://phabricator.kde.org/D12277

AFFECTED FILES
  kstyle/breezesplitterproxy.cpp

To: fvogt, #breeze, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Breeze.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  In Qt 4, the compiler detection macros have no value, so they can't be 
compared
  against. So just use the compiler-specific ones.
  It also makes use of the fact that undefined tokens evaluate to 0 in
  comparisons.

TEST PLAN
  jriddell built it with GCC 5 and 7 against Qt 4 and 5.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12277

AFFECTED FILES
  kstyle/breezesplitterproxy.cpp

To: fvogt, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Vlad Zagorodniy]

zzag added a comment.


  In D12256#247950 , @ltoscano wrote:
  
  > Don't you need to raise the requirement to a new Frameworks version, or 
#ifdefs if it's not possible (as it should probably be coordinated with the 
rest of the Plasma team)?
  
  
  Is it okay to bump minimum required version of KF to 5.45?

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12275: FunnelModel: fix invalid model API usage.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The new asserts added in qtbase in commit 00c09e752f (Qt 5.11) are triggered
  by this invalid code, which sets up the model before the begin* methods.
  So Qt already sees the new rowCount in that method, which is wrong.

TEST PLAN
  Opening the K menu

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D12275

AFFECTED FILES
  applets/kicker/plugin/funnelmodel.cpp

To: dfaure, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12274: Add pulleyitem for quick fav feature

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:8f804a11d0fc: Add pulleyitem for quick fav feature 
(authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12274?vs=32369=32370

REVISION DETAIL
  https://phabricator.kde.org/D12274

AFFECTED FILES
  plasmoid/contents/ui/PulleyItem.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12274: Add pulleyitem for quick fav feature

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Ref T7175 , T8175 
 Added PulleyItem for quick favorites menu 
to home tab
  
  - Additonal fixes to geolocation for news dashcard (never display empty)
  - Additional fix display of fallback disclaimer page when dashboard is 
disabled

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12274

AFFECTED FILES
  plasmoid/contents/ui/PulleyItem.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey updated this revision to Diff 32368.
sharvey added a comment.


  - Add checking & sizing calc for smaller or rotated screens
  
  `availableSize()` returns size minus any size reserved by the window manager 
for taskbars, etc. Multiply by 0.9 to prevent systemsettings from going "full 
screen" and overlapping all other windows.

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12252?vs=32351=32368

BRANCH
  enlarge-default-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12252

AFFECTED FILES
  app/SettingsBase.cpp

To: sharvey, ngraham, mart
Cc: cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Luigi Toscano]

ltoscano added a comment.


  Don't you need to raise the requirement to a new Frameworks version, or 
#ifdefs if it's not possible (as it should probably be coordinated with the 
rest of the Plasma team)?

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12263: [kstyle] don't suppress deprecation warnings

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Hopping I did not miss any dependent revisions. 
  Thanks for cleaning this up .

REPOSITORY
  R31 Breeze

BRANCH
  dont-suppress-deprecated-warnings

REVISION DETAIL
  https://phabricator.kde.org/D12263

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionFrameV3

REVISION DETAIL
  https://phabricator.kde.org/D12261

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionTabV3

REVISION DETAIL
  https://phabricator.kde.org/D12257

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionTabWidgetFrameV2

REVISION DETAIL
  https://phabricator.kde.org/D12258

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionViewItemV4

REVISION DETAIL
  https://phabricator.kde.org/D12259

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionDockWidgetV2

REVISION DETAIL
  https://phabricator.kde.org/D12262

To: zzag, #breeze, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12248: [Desktop Theme KCM] Port to new design

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ecb40efcd7e: [Desktop Theme KCM] Port to new design 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12248?vs=32299=32363

REVISION DETAIL
  https://phabricator.kde.org/D12248

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart