davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.


> zzag wrote in SettingsBase.cpp:82
> You forgot `const`.
> Also, you could multiply whole QSize by `factor` so Qt will round width and 
> height. ;-)

> qreal factor = qBound(1.0, 
> QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);

I know you were told to change to this, but don't do that.

Qt will scale the size you give it here by the devicePixelRatio. This is 
scaling it twice which we don't want to do.

We shouldn't need to be doing any custom high DPI code in window sizing.

  R124 System Settings


To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to