KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 - Build # 29 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.10/29/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 31 May 2018 04:48:42 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  [...truncated 35.82 KB...]Retrieving: Plasma-kauth-stable-kf5-qt5Retrieving: Plasma-kguiaddons-stable-kf5-qt5Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5Retrieving: Plasma-kitemviews-stable-kf5-qt5Retrieving: Plasma-kcompletion-stable-kf5-qt5Retrieving: Plasma-kiconthemes-stable-kf5-qt5Retrieving: Plasma-sonnet-stable-kf5-qt5Retrieving: Plasma-attica-stable-kf5-qt5Retrieving: Plasma-kglobalaccel-stable-kf5-qt5Retrieving: Plasma-ktextwidgets-stable-kf5-qt5Retrieving: Plasma-breeze-icons-stable-kf5-qt5Retrieving: Plasma-knotifications-stable-kf5-qt5Retrieving: Plasma-kxmlgui-stable-kf5-qt5Retrieving: Plasma-solid-stable-kf5-qt5Retrieving: Plasma-kjobwidgets-stable-kf5-qt5Retrieving: Plasma-kbookmarks-stable-kf5-qt5Retrieving: Plasma-kwallet-stable-kf5-qt5Retrieving: Plasma-kio-stable-kf5-qt5Retrieving: Plasma-kparts-stable-kf5-qt5Retrieving: Plasma-kplotting-stable-kf5-qt5Retrieving: Plasma-kdewebkit-stable-kf5-qt5Retrieving: Plasma-kinit-stable-kf5-qt5Retrieving: Plasma-kunitconversion-stable-kf5-qt5Retrieving: Plasma-kded-stable-kf5-qt5Retrieving: Plasma-kemoticons-stable-kf5-qt5Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5Retrieving: Plasma-kpackage-stable-kf5-qt5Retrieving: Plasma-kactivities-stable-kf5-qt5Retrieving: Plasma-kdnssd-stable-kf5-qt5Retrieving: Plasma-kdeclarative-stable-kf5-qt5Retrieving: Plasma-kidletime-stable-kf5-qt5Retrieving: Plasma-kitemmodels-stable-kf5-qt5Retrieving: Plasma-kjs-stable-kf5-qt5Retrieving: Plasma-kross-stable-kf5-qt5Retrieving: Plasma-threadweaver-stable-kf5-qt5Retrieving: Plasma-kwayland-stable-kf5-qt5Retrieving: Plasma-ktexteditor-stable-kf5-qt5Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5Retrieving: Plasma-kirigami-stable-kf5-qt5Retrieving: Plasma-plasma-framework-stable-kf5-qt5Retrieving: Plasma-krunner-stable-kf5-qt5Retrieving: Plasma-kfilemetadata-stable-kf5-qt5Retrieving: Plasma-kdelibs4support-stable-kf5-qt5Retrieving: Plasma-kpty-stable-kf5-qt5Retrieving: Plasma-knewstuff-stable-kf5-qt5Retrieving: Plasma-kactivities-stats-stable-kf5-qt5Retrieving: Plasma-kcmutils-stable-kf5-qt5Retrieving: Plasma-khtml-stable-kf5-qt5Retrieving: Plasma-kjsembed-stable-kf5-qt5Retrieving: Plasma-knotifyconfig-stable-kf5-qt5Retrieving: Plasma-frameworkintegration-stable-kf5-qt5Retrieving: Plasma-kdesu-stable-kf5-qt5Retrieving: Plasma-kxmlrpcclient-stable-kf5-qt5Retrieving: Plasma-qqc2-desktop-style-stable-kf5-qt5Retrieving: Plasma-prison-stable-kf5-qt5Retrieving: Plasma-kpeople-stable-kf5-qt5Retrieving: Plasma-kmediaplayer-stable-kf5-qt5Retrieving: Plasma-kimageformats-stable-kf5-qt5Retrieving: Plasma-bluez-qt-stable-kf5-qt5Retrieving: Plasma-baloo-stable-kf5-qt5Retrieving: Plasma-kdecoration-stable-kf5-qt5Retrieving: Plasma-kscreenlocker-stable-kf5-qt5Retrieving: Plasma-breeze-stable-kf5-qt5Retrieving: Plasma-kholidays-stable-kf5-qt5Retrieving: Plasma-khelpcenter-stable-kf5-qt5Retrieving: Plasma-kio-extras-stable-kf5-qt5Retrieving: Plasma-libksysguard-stable-kf5-qt5Retrieving: Plasma-kwin-stable-kf5-qt5Retrieving: Plasma-milou-stable-kf5-qt5Retrieving: Plasma-libkscreen-stable-kf5-qt5Retrieving: Plasma-kactivitymanagerd-stable-kf5-qt5Retrieving: Plasma-plasma-workspace-stable-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 70, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10/ci-tooling/helpers/helperslib/Packages.py", line 115, in retrievePackagelatestContent.write( response.read() )  File "/usr/local/lib/python3.5/http/client.py", line 461, in reads = self._safe_read(self.length)  File "/usr/local/lib/python3.5/http/client.py", line 607, in _safe_readchunk = self.fp.read(min(amt, MAXAMOUNT))  File "/usr/local/lib/python3.5/socket.py", line 576, in readintoreturn self._sock.recv_into(b)  File "/usr/local/lib/python3.5/ssl.py", line 937, in recv_intoreturn self.read(nbytes, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 799, in readreturn self._sslobj.read(len, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 583, in readv = self._sslobj.read(len, buffer)ConnectionResetError: [Errno 54] Connection reset by peer[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D12982: Make the new KCMs with QtQuick translatable

[Yuri Chornoivan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:738da689cbd2: Make the new KCMs with QtQuick translatable 
(authored by yurchor).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12982?vs=34932=35229#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12982?vs=34932=35229

REVISION DETAIL
  https://phabricator.kde.org/D12982

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/launch/CMakeLists.txt
  kcms/launch/Messages.sh
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13178: Compress calls to configuration slots upon new connections

[Jacopo De Simoi]

jacopods added a comment.


  In D13178#270671 , @mart wrote:
  
  > are configureKeyboard configureMouse etc doing an immediate write to disk? 
(like KConfig::sync()
  
  
  Hey notmart, long time no see!
  
  The configureKeyboard() method is calling xmodmap (should the user need 
special configuration), so who knows what happens in there.

REVISION DETAIL
  https://phabricator.kde.org/D13178

To: jacopods, PHID-PROJ-gqbvozptxawndyihp3hs, hein, broulik, drosca
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13225: Move methods to private class

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: drosca, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  private

REVISION DETAIL
  https://phabricator.kde.org/D13225

AFFECTED FILES
  src/card.cpp
  src/cardport.cpp
  src/client.cpp
  src/device_p.h
  src/module.cpp
  src/port.h
  src/port_p.h
  src/profile.h
  src/profile_p.h
  src/pulseobject.h
  src/pulseobject_p.h
  src/server.h
  src/sinkinput.cpp
  src/sourceoutput.cpp
  src/stream.h
  src/stream_p.h
  src/volumeobject.h
  src/volumeobject_p.h

To: nicolasfella, drosca, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Nathaniel Graham]

ngraham added a comment.


  Indeed, It's nice when we can make everyone happy instead of having someone 
come away upset. Now if only we could teach this to politicians...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Henrik Fehlauer]

rkflx added a comment.


  FWIW, testing with users affected by this change, they are happy now. 
Therefore +1 for how it works. Thanks for implementing this on such short 
notice.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12982: Make the new KCMs with QtQuick translatable

[David Edmundson]

davidedmundson added a comment.


  > That's different: I see KCMs are libraries,
  
  
  
  > I think it would be acceptable to use 
KLocalizedString::setApplicationDomain, even if introduces an exception, but at 
least not *another* way to set the translation domain.
  
  I don't think so for two reasons. Firstly it's a single domain and we are 
plugins within another shell.
  
  Secondly, from QML our i18n calls go to klocalizedcontext which if a domain 
is set will explicitly use it. So in order to use
  
  KLocalizedString::setApplicationDomain we have to completely remove our
  
  d->_qmlObject->setTranslationDomain(aboutData()->componentName()); in 
configmodule.cpp
  
  I don't think that's viable, especially with the staggered release cycles.
  
  -
  
  I'd be happy to introduce a ConfigModule::setTranslationDomain in 
kdeclarative. 
  Which would allow doing everything from code without having to make names 
match.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias added a comment.


  @alexeymin This is a working version but I plan on adding stuff in the coming 
weekends. Just wanted to make sure there's someone motivated to review and 
merge this.
  Thanks for looking at my diffs.

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias added a comment.


  1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed
  2. Services should be started by DBus-activation, if that doesn't happen by 
whatever reason, first start `$ pipewire`, then `$ 
/usr/lib(exec)/xdg-desktop-portal`, it should in turn start `$ 
/usr/lib(exec)/xdg-desktop-portal-kde` by itself
  3. Compile KRfb with this patch and install it, select "pw" in the list of 
KRfb plugins. If all is ok, XDP-KDE should show you the dialog with screen 
selection
  4. Try to connect to KRfb through KRDC or any other VNC client
  
  Pay attention to logs, in case of difficulties use pipewire-monitor, 
qdbusviewer and launch desktop portals with `-v` options

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Alexey Min]

alexeymin added a comment.


  How exactly I can test if something works? And what are the requirements? 
PipeWire? Something else?

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Eike Hein]

hein added a comment.


  I'll push after @davidedmundson gives his accept, as the code was reformatted 
a bit since he last spoke up.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13095: Scren brightness follow a quatratic progression

[Nathaniel Graham]

ngraham added a comment.


  My backlight turns on at 6. It's off at 5.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: zzag, ngraham, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

[Eike Hein]

hein updated this revision to Diff 35209.
hein removed a subscriber: zzag.
hein added a comment.


  Implement Vlad's code hygiene suggestions.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35208=35209

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, zzag

D13194: Use the new drag handle in the Language KCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> translations.cpp:97
>  
> -for (const QString& lang : m_translationsModel->missingLanguages()) {
> +for (const QString& lang : 
> m_selectedTranslationsModel->missingLanguages()) {
>  m_configuredLanguages.removeOne(lang);

Maybe,

  const auto missingLanguages = m_selectedTransationsModel->missingLanguages();
  for (const QString& lang : missingLanguages) {
 // ...
  }

(to avoid detach)

> translationsmodel.cpp:103
> +return QLocale(QStringLiteral("pt_PT")).nativeLanguageName();
> +} else {
> +qWarning() << "Language code morphed into another existing 
> language code, please report!" << languageCode << locale.name();

Coding style nitpick: don't use `else` after `return`.

References:

- https://releases.llvm.org/2.7/docs/CodingStandards.html#hl_else_after_return 
(Kdelibs coding style doesn't say anything about early returns)

> translationsmodel.cpp:197
>  
> -m_selectedLanguages.move(from, to);
> +int modelTo = to + (to > from ? 1 : 0);
>  

Can be const.

> translationsmodel.cpp:218
>  
> -emit selectedLanguagesChanged();
> +if (index != -1) {
> +beginRemoveRows(QModelIndex(), index, index);

How about early return? E.g.

  if (index < 0) {
  return;
  }
  
  // ...

> translationsmodel.cpp:254
> +
> +return TranslationsModel::data(index, role);
> +}

Dead code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

[Eike Hein]

hein added a comment.


  Screenshot:
  
  F5878558: Screenshot_20180531_030134.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

[Eike Hein]

hein added a comment.


  This is now ready for review.
  
  With the use of DelegateRecycler, I get many ReferenceErrors from particular 
the sheet list delegate during scroll:
  
kcmshell5(8088)/default unknown: 
file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:41:
 TypeError: Cannot read property 'display' of undefined
kcmshell5(8088)/default unknown: 
file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:37:
 TypeError: Cannot read property 'LanguageCode' of undefined
  
  I suspect this is some sort of race condition. @mart needs to have a look. 
The code in the diff itself should be unrelated to this I hope.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

[Eike Hein]

hein updated this revision to Diff 35208.
hein edited the summary of this revision.
hein added a comment.


  Mention the use of DelegateRecycler in the message.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35207=35208

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

[Eike Hein]

hein updated this revision to Diff 35207.
hein edited the summary of this revision.
hein added a reviewer: davidedmundson.
hein added a comment.


  - Rewrite model backend to make list drag handle happy.
  - Use QCollator for available languages.
  - Code cleanup.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35110=35207

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag added a comment.


  In D12055#270987 , @ngraham wrote:
  
  > In D12055#270986 , @zzag wrote:
  >
  > > @ngraham Also, who maintains Breeze GTK theme?
  >
  >
  > @jackg does, IIRC.
  
  
  Thanks.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg
Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Nathaniel Graham]

ngraham added a subscriber: jackg.
ngraham added a comment.


  In D12055#270986 , @zzag wrote:
  
  > @ngraham Also, who maintains Breeze GTK theme?
  
  
  @jackg does, IIRC.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag added a comment.


  @ngraham Also, who maintains Breeze GTK theme?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag updated this revision to Diff 35206.
zzag added a comment.


  Delete redundant `border: none;` rules

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12055?vs=31705=35206

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.18/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Nathaniel Graham]

ngraham added a comment.


  I wasn't planning to. :)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag added a comment.


  Please, don't land it yet.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13220: Add .arcconfig

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:c2ff497c6381: Add .arcconfig (authored by zzag, committed 
by ngraham).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13220?vs=35202=35205

REVISION DETAIL
  https://phabricator.kde.org/D13220

AFFECTED FILES
  .arcconfig

To: zzag, #breeze, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13220: Add .arcconfig

[Vlad Zagorodniy]

zzag added a comment.


  Nate, please land it on my behalf. (I don't have the Developer account right 
now)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  add-arcconfig

REVISION DETAIL
  https://phabricator.kde.org/D13220

To: zzag, #breeze, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13220: Add .arcconfig

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  add-arcconfig

REVISION DETAIL
  https://phabricator.kde.org/D13220

AFFECTED FILES
  .arcconfig

To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13202: Circular user avatar for Kickoff

[Scott Harvey]

sharvey marked 2 inline comments as done.
sharvey added a comment.


  I don't know if I need to edit `user-manager` to emit a signal of some kind, 
or if some trigger needs to go over the D-Bus... I'm wading into deep water 
here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13202: Circular user avatar for Kickoff

[Nathaniel Graham]

ngraham added a comment.


  Yes, we had a report of this: https://bugs.kde.org/show_bug.cgi?id=384107
  
  However the issue I've seen is a genuine regression from your patch: changing 
my avatar from a file on disk to an image from gallery works without your 
patch, but fails with it.
  
  It looks like the stuff in here may be interacting poorly the pre-existing 
bug. I can tell you from submitting some user-manager patches to fix avatars in 
the past that the code there is sadly pretty fragile.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13202: Circular user avatar for Kickoff

[Scott Harvey]

sharvey added a comment.


  F5878497: Screenshot_20180530_121625.png 

  It appears Kickoff had this problem prior to the circles. I changed my 
avatar, but un-patched Kickoff now shows the default avatar.
  
  I'm not clear why `user-manager` removes the previous avatar, but the new one 
isn't immediately available.
  
  I obviously need to force a refresh somewhere, somehow - but I don't know how.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12055: Remove border around menubars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Revisiting this, I think there's value in matching how Breeze does it at even 
if just for simple consistency's sake. If we ever change Breeze, we can change 
this back.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 for functionality. This makes Kickoff feel so much faster and more 
responsive now! It's amazing what a difference it makes. And the triangle 
filter works well to prevent unintentional tab switching when you clip a 
different tab while moving the mouse generally upwards.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Eike Hein]

hein updated this revision to Diff 35194.
hein added a comment.


  Remove some overly noisy stating-the-obvious comments.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13192?vs=35193=35194

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/KickoffButton.qml

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Eike Hein]

hein updated this revision to Diff 35193.
hein added a comment.


  - Reformat code as per Vlad's suggestions.
  - Fix Kai's issues.
  
  oldPos is indeed `var` because I prefer it over construction
  an unneded point instance.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13192?vs=35109=35193

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/KickoffButton.qml

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12982: Make the new KCMs with QtQuick translatable

[Luigi Toscano]

ltoscano added a comment.


  In D12982#270846 , @davidedmundson 
wrote:
  
  > > is this something that needs to be fixed in kdeclarative
  >
  > I don't think so.
  >  This patch seems fine, it's no different to our current state of how 
applet translations work following a fixed pot schema.
  
  
  That's different: I see KCMs are libraries, but they introduce an exception 
in the way the translation domain is defined for a library. And even for 
applets I would argue that the case may be needed, but let's move it.
  
  Applet won't need to co-exist, KCMs may need to do it.
  
  > 
  > 
  >>   would a patch to fix this (define the translation domain in the same way 
as the other libraries, not related to component name) accepted?
  > 
  > Accepted, sure. But the QtQuick loading is quite separate from the library 
here, so I'm not sure it's easy.
  
  I think it would be acceptable to use KLocalizedString::setApplicationDomain, 
even if introduces an exception, but at least not *another* way to set the 
translation domain.
  
  Would that work/be easier to implement for this dynamic setting?
  
  > If we want to have QtQuick only KCMs (something I think probably isn't 
useful, but I know Marco wants) we would still need to load pots based on 
plugin metadata names like it is currently.
  
  I still think that there is a use case for translation domain unrelated to 
metadata (if you mean static KAboutData settings).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12982: Make the new KCMs with QtQuick translatable

[Marco Martin]

mart added a comment.


  In D12982#270846 , @davidedmundson 
wrote:
  
  > Accepted, sure. But the QtQuick loading is quite separate from the library 
here, so I'm not sure it's easy.
  >
  > If we want to have QtQuick only KCMs (something I think probably isn't 
useful, but I know Marco wants) we would still need to load pots based on 
plugin metadata names like it is currently.
  
  
  qtquick only kcms are actually supported by plasma-settings the one used in 
plasma mobile, but i don't think they are necessarly a good idea
  on the other hand, one thing that i was looking into, was to use the metadata 
to generate a default kaboutdata and not be forced to have it manually in every 
kcm as now.. tough it would cause a problem regarding to this

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12982: Make the new KCMs with QtQuick translatable

[David Edmundson]

davidedmundson added a comment.


  > is this something that needs to be fixed in kdeclarative
  
  I don't think so.
  This patch seems fine, it's no different to our current state of how applet 
translations work following a fixed pot schema.
  
  >   would a patch to fix this (define the translation domain in the same way 
as the other libraries, not related to component name) accepted?
  
  Accepted, sure. But the QtQuick loading is quite separate from the library 
here, so I'm not sure it's easy.
  
  If we want to have QtQuick only KCMs (something I think probably isn't 
useful, but I know Marco wants) we would still need to load pots based on 
plugin metadata names like it is currently.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13193: Rename kcm_input to kcm_mouse

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13193

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Kai Uwe Broulik]

broulik added a comment.


  Minor code nitpicks.
  
  Tab instant switch makes it feel a lot more responsive but I occasionally 
managed to accidentally activate the "Apps" tab when opening and moving, not 
sure how much that could happen in "normal use", though. +1 anyway

INLINE COMMENTS

> FullRepresentation.qml:402
> +
> +property var oldPos: null
> +

`property point` or is that on purpose so you can set it to `null` instead to 
avoid ambiguity with e.g. `-1,-1`?

> FullRepresentation.qml:434
> +
> +var dx  = (mouse.x - oldPos.x);
> +var dy  = (mouse.y - oldPos.y);

Coding style, one space before `=`

> FullRepresentation.qml:493
> +return;
> +} else {
> +clickTimer.pendingButton = button;

No `else` since you `return` in the `if` branch

  if (...) {
  ...
  return;
  }
  
  ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[David Edmundson]

davidedmundson added a comment.


  From a code POV, +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Eike Hein]

hein added a comment.


  > Could a different approach work here? No change on hover, but just on 
click? The user controls the entire action.
  
  Can you explain what you dislike about my patch enough that makes you think 
an entirely different approach is in order, or why you think it fails to solve 
the problem? It's a bit weird to react to a patch with "lol ... ok, maybe 
something else entirely" in review without that buildup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Vlad Zagorodniy]

zzag added a comment.


  KF 5.47 will be released soon enough 
 so I guess that's OK to ship 
the code as is. Am I right?

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13199: Move updateDevice to private class

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R994:65bad933c12c: Move updateDevice to private class 
(authored by nicolasfella).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13199?vs=35126=35181

REVISION DETAIL
  https://phabricator.kde.org/D13199

AFFECTED FILES
  src/device.cpp
  src/device.h
  src/device_p.h
  src/port.h
  src/sink.cpp
  src/source.cpp
  src/volumeobject.h

To: nicolasfella, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11909: properly use kpackage_install_package

[Vlad Zagorodniy]

zzag added a comment.


  Ping.
  
  Also, could someone please explain what's wrong with 
`kpackage_install_bundled_package`?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11198: [libbreezecommon] Add box shadow helper

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

[Roman Gilg]

romangg planned changes to this revision.
romangg added a comment.


  In D13207#270731 , @davidedmundson 
wrote:
  
  > In the multiscreen case you have two LockScreenUi files altering the same 
single property, does it work?
  
  
  You are right, there is the problem that it hides the cursor if the second 
screen hides the ui while the cursor is on the first one with visible ui.
  
  But the overall mechanism doesn't seem to work well for multi-screen. The ui 
fades sometimes without fade out timer grace period. I can't type my password 
in the second screen.
  
  Also imo the ui should show and fade out on all screens synchronized.
  
  Will look into this when I find time.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13207

To: romangg, #plasma
Cc: davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13183: Use Control.palette

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:b176593771c2: Use Control.palette (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13183?vs=35154=35179

REVISION DETAIL
  https://phabricator.kde.org/D13183

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Container.qml
  org.kde.desktop/Control.qml
  org.kde.desktop/DelayButton.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/ProgressBar.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/RoundButton.qml
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/ScrollView.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/SwitchIndicator.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  plugin/kquickstyleitem.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

[David Edmundson]

davidedmundson added a comment.


  In the multiscreen case you have two LockScreenUi files altering the same 
single property, does it work?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13207

To: romangg, #plasma
Cc: davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13210: [Installation Reminder] Watch for service registration and hide

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> browserintegrationreminder.cpp:129
>  
> +m_watcher = new QDBusServiceWatcher(s_dbusServiceName, bus, 
> QDBusServiceWatcher::WatchForRegistration, this);
> +connect(m_watcher, ::serviceRegistered, this, 
> [this](const QString ) {

technically best to move this above the check for isServiceRegistered and you 
avoid the slim race possibility.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13210

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> mart wrote in LockScreenUi.qml:72
> shouldn't that mousearea cover the whole area? if cursorshape doesn't work 
> for a thing that appears under the cursor that's definitely a mousearea bug

You are right, that it should cover the whole area, if it could be used. I 
added a comment to D13206  with a link to 
the Qt bug why it can't be used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13207

To: romangg, #plasma
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13206: Add context property to hide cursor

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  with a comment on why the workaround, is ok for me

REPOSITORY
  R133 KScreenLocker

BRANCH
  hideCursorProperty

REVISION DETAIL
  https://phabricator.kde.org/D13206

To: romangg, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13206: Add context property to hide cursor

[Roman Gilg]

romangg updated this revision to Diff 35178.
romangg added a comment.


  - Add comment

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13206?vs=35141=35178

BRANCH
  hideCursorProperty

REVISION DETAIL
  https://phabricator.kde.org/D13206

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13202: Circular user avatar for Kickoff

[Scott Harvey]

sharvey added a comment.


  In D13202#270585 , @ngraham wrote:
  
  > Looks great now! Quite pleasing to the eye.
  >
  > I've got a few blockers though:
  >
  > - When I change the icon in the user-manager KCM and re-open Kickoff, the 
new icon isn't displayed; instead I just see a blank circle with no image in it 
until I quit and restart plasmashell.
  
  
  That’s odd. It shows us something *is* updating, just not correctly or 
completely. What’s strange is that it seems to be removing the old avatar but 
not yet updating with the new one.

INLINE COMMENTS

> ngraham wrote in Header.qml:19
> This version bump makes Kickoff require Qt 5.11. I wasn't are that we were 
> going to make Plasma 5.14 depend on Qt 5.11. At the minimum, it makes this 
> hard to test without compiling your own Qt. Is there anything we're actually 
> depending on with this patch that was added with 2.11, or can we reduce the 
> minimum version? I manually changed it to 2.10 and didn't notice any issues...

No, that version bump was likely from an earlier attempt using a different 
technique  I’ll get it dialed back to the correct minimum and will repost.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13210: [Installation Reminder] Watch for service registration and hide

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In case the browser takes forever to start or user installs the extension 
manually without clicking the SNI.
  
  CCBUG: 394673

TEST PLAN
  Started Firefox, waited for the SNI to show up, installed extension manually, 
SNI disappeared and module unloaded

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13210

AFFECTED FILES
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13183: Use Control.palette

[Marco Martin]

mart accepted this revision.
mart added a comment.


  awesome! thanks :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13183

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13178: Compress calls to configuration slots upon new connections

[Marco Martin]

mart added a comment.


  are configureKeyboard configureMouse etc doing an immediate write to disk? 
(like KConfig::sync()
  where using timers to compress really saves a lot of time, is to compress the 
actual disk writes. just writing to kconfiggroup is fast, because it doesn't 
actually immediately write to disk, but only on application (clean) exit or at 
a sync() call

REVISION DETAIL
  https://phabricator.kde.org/D13178

To: jacopods, PHID-PROJ-gqbvozptxawndyihp3hs, hein, broulik, drosca
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi updated this revision to Diff 35172.
gregormi added a comment.


  > The text should use title case: "Kill a Window"
  
  DONE
  
  > The parentheses look a bit ugly, in normal menus the shortcuts are simply 
aligned to the right (not sure how that's done, though).
  
  DONE: align the shortcut strings to the right using \t
  
  > At least for Run Command the shortcut should be shown (just like in the 
desktop context menu)
  
  DONE: Add shortcut to 'Run Command' item
  
  > The shortcut does not get localized. (In the global shortcuts KCM, it is 
localized correctly for me.)
  
  DONE: using QKeySequence::NativeText; tested with "export LANGUAGE=de_DE"
  
  Remove seemingly useless 'class KGlobalAccel'

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10297?vs=34204=35172

BRANCH
  arcpatch-D10297_2

REVISION DETAIL
  https://phabricator.kde.org/D10297

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/ProcessWidgetUI.ui
  processui/ksysguardprocesslist.cpp

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Marco Martin]

mart added a comment.


  In D13192#270466 , @abetts wrote:
  
  > Could a different approach work here? No change on hover, but just on 
click? The user controls the entire action.
  
  
  i think the whole point of a start menu is to be fast, to require as little 
as possible mouse move and as little as possible of number of clicks, otherwise 
it fails at its only job of allowing quickly to start the things you need.
  I already don't like much the fact that for $technicalreasons we can't have a 
menu trigger with less than two clicks (like is possible to trigger a menubar 
item with a single mouse click in total, with the mouse press being the opening 
of the first menu)
  
  please let's not add another click to the process, that can totally be 
avoided.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> romangg wrote in LockScreenUi.qml:72
> The problem was that I first had to move the mouse to enter the MouseArea. 
> I.e. when the Screenlocker is activated by timer the cursor is visible until 
> first time the mouse is moved and then the fade out timer triggers afterwards.

shouldn't that mousearea cover the whole area? if cursorshape doesn't work for 
a thing that appears under the cursor that's definitely a mousearea bug

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13207

To: romangg, #plasma
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12982: Make the new KCMs with QtQuick translatable

[Luigi Toscano]

ltoscano added a comment.


  I'd really like to have a clear answer to some questions:
  
  - is this something that needs to be fixed in kdeclarative, which makes it 
impossible to have a proper fix it in 5.13?
  - would a patch to fix this (define the translation domain in the same way as 
the other libraries, not related to component name) accepted?
  
  The answer to the first question will make the next move. If the only fix is 
in kdeclarative, then Yuri please revert to the initial version. In that case 
it would be the only possible short-term fix even I don't like it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 35167.
gregormi added a comment.


  - use auto, add comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=35165=35167

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 35165.
gregormi marked 4 inline comments as done.
gregormi added a comment.


  - Handle colon (:) problem for translating and fix one label bug

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=35163=35165

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi marked an inline comment as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.ui:333-338
> Do you need this? Pressing the Reset button for that property in Qt Designer 
> removes this for me.

If I remove that part, the button gets wider; I would prefer to keep it as 
small as possible.

> rkflx wrote in Module.ui:349-351
> For me the shortcut actually works, but ideally this should use the standard 
> shortcut for copying, which the user might have set to something different 
> than [Ctrl] + [C].
> 
> You could try to look at how it works in Spectacle. I suspect you'd need to 
> add the appropriate action or standard shortcut for that, e.g. 
> `KStandardAction::Copy` or `QKeySequence::Copy`, instead of setting shortcut 
> and icon manually.

The KStandardAction method seems only easily applicable with QToolButtons but 
not with QPushButton. Furthermore, I got the "ambiguous key binding" when I 
tried it. I now settled for QKeySequence::Copy which does not work for me but 
at least results in no error message.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 35163.
gregormi marked 3 inline comments as done.
gregormi added a comment.


  - Fix comment
  - Clean ui file
  - Shortcut handling

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=35158=35163

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi marked 5 inline comments as done.
gregormi added inline comments.

INLINE COMMENTS

> gregormi wrote in Module.cpp:246
> Yes, I also had the list idea in an earlier stage of the patch< but without 
> reusing the translated label text. I don't expect the information labels to 
> change often, so I think such a refactoring can be done at a later point in 
> time.

I changed my mind. With all the i18nc comments, I decided it is better to do 
the refactoring now.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 35158.
gregormi marked 2 inline comments as done.
gregormi added a comment.


  - Translate the Distro string
  - Rename button to 'Copy to Clipboard' for more clarity; and consistency with 
other applications
  - Use a QList of QPairs to collect labels and then use a loop

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=34111=35158

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi marked an inline comment as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:246
> Probably not strictly required for this patch, but it would be nicer to 
> refactor this in such a way that adding another string to the UI does not 
> require adding it here too.
> 
> Perhaps this can be achieved by creating a list of label/version pairs, and 
> then iterating through that list both when creating the UI and when 
> generating the text to copy.

Yes, I also had the list idea in an earlier stage of the patch< but without 
reusing the translated label text. I don't expect the information labels to 
change often, so I think such a refactoring can be done at a later point in 
time.

> ltoscano wrote in Module.cpp:253
> Please don't write (just) "do this in this case", but explain what the 
> placeholders are meant to be. Leave it to the speakers of the language the 
> decision about the order.

I will do it like this:

i18nc("one line in the information that goes to the clipboard", "%1 %2", ...

I see one problem: %1 contains a trailing colon (:). So just reversing to "%2 
%1" would result in "openSUSE Tumbleweed Distro:". One solution would be to 
strip the colon from the %1 string and put it here: "%1: %2".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart