gregormi marked an inline comment as done. gregormi added inline comments. INLINE COMMENTS
> rkflx wrote in Module.ui:333-338 > Do you need this? Pressing the Reset button for that property in Qt Designer > removes this for me. If I remove that part, the button gets wider; I would prefer to keep it as small as possible. > rkflx wrote in Module.ui:349-351 > For me the shortcut actually works, but ideally this should use the standard > shortcut for copying, which the user might have set to something different > than [Ctrl] + [C]. > > You could try to look at how it works in Spectacle. I suspect you'd need to > add the appropriate action or standard shortcut for that, e.g. > `KStandardAction::Copy` or `QKeySequence::Copy`, instead of setting shortcut > and icon manually. The KStandardAction method seems only easily applicable with QToolButtons but not with QPushButton. Furthermore, I got the "ambiguous key binding" when I tried it. I now settled for QKeySequence::Copy which does not work for me but at least results in no error message. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
