D17217: Implement free memory notifier

[David Edmundson]

davidedmundson added a comment.


  Given there is some negativity in the feedback I do want to point out that 
it's cool to still upload whatever to the KDE store/wider ecosystem. Not 
everything run in plasma needs to be from plasma; we go to great lengths to 
make sure that's the case.
  
  There's also an alternative that I'd like to suggest:
  According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt 
there's a system called "memory pressure" you can watch for events on a 
specific FD with various levels of out-of-memory-ness. A lot cheaper than 
polling, far more reliable, and following the system's OOM configuration. 
Getting that in at a frameworks level so it can be hooked up to notifications 
in this case, but also garbage collections in UI code could be pretty cool.

INLINE COMMENTS

> freememorynotifier.cpp:55
> +connect(, ::timeout, this, 
> ::checkFreeMemory);
> +timer.start(1000 * 5 /* 1 minute */);
> +}

how is that 1 minute?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Plasma 5.14.4

[Christoph Feck]

On 27.11.2018 18:17, Jonathan Riddell wrote:

Plasma 5.14.4 is now released
https://www.kde.org/announcements/plasma-5.14.4.php


It was suggested to do a 5.14.4.1 respin of 'plasma-desktop' to include 
a patch for regression bug 401508 (the bug ticket does not mention that 
it can even crash the shell on clicking a grouped task bar entry).

Until that is decided, distributions are asked to apply the linked patch.

https://bugs.kde.org/show_bug.cgi?id=401508

Merge commit in branch 'Plasma/5.14':
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.14=9b1f3e7ee80af3c3c09e2752d6c736d56690d53c

Actual commit from LTS branch 'Plasma/5.12':
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.14=ed34cc5f181e61d1fc98872866c5d7300a90af86

Re: Conceptual changes to KScreen

[Nate Graham]

  On Sun, 25 Nov 2018 04:47:39 -0700 Roman Gilg  wrote 
 
 > From a user-facing standpoint there is not much change. Certain 
 > display property a user manipulates manually via the KCM are now per 
 > default persistent over all possible configurations of displays (i.e. 
 > which displays are connected) he might change to in the future. 
 >  
 > It is assumed this is what most users want for following (per-)display 
 > properties: 
 > * resolution 
 > * scale factor 
 > * rotation 
 > * refresh rate. 

Thanks Roman. For those properties, I can see quite a few cases where a user 
would want per-display configuration, most of them relating to laptops plugged 
into external screens or projectors. Those external screens will typically 
differ in their resolution, optimal scale factor, and refresh rate from both 
the laptop screen as well as other external screens that the laptops could use. 
How would this proposal handle those cases, or are they unaffected or even 
improved? Or am I misunderstanding the proposal?

 > In certain rare scenarios user might be interested in saving 
 > properties for one specific configuration only though. Changing the 
 > retention value from the KCM allows that. Also this can be used as a 
 > fallback to current behavior. It is assumed though that only very few 
 > users if at all choose to do that.

So this new feature would require users to manually mark their display 
configurations as needing to be remembered?

Nate

D17207: Use KPasswordLineEdit

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great and the code looks sane, thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D17207

To: broulik, jriddell, davidedmundson, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

[Burkhard Lück]

lueck updated this revision to Diff 46432.
lueck added a comment.


  fix typo spotted by Yuri, thanks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17226?vs=46431=46432

REVISION DETAIL
  https://phabricator.kde.org/D17226

AFFECTED FILES
  doc/kcontrol/kcmsmserver/index.docbook

To: lueck, #plasma, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
yurchor added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> index.docbook:110
>  Finally, you can enter a colon (:) or comma 
> (,)
> -separated list of applications that should not be saved in sessions,
> +separated list of applications that should be exluded from sessions,
>  and therefore will not be started when restoring a session.  For example

Typo: exluded -> excluded

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17226

To: lueck, #plasma, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17226: Update kcmsmserver (Desktop Session) docbook to Plasma 5.14

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  bump date + releaseinfo
  proofread
  fix wrong item name in application meu

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17226

AFFECTED FILES
  doc/kcontrol/kcmsmserver/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17225: Update translation kcm docbook to plasma 5.14

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  update according port of KCM to Qt Quick with 
https://phabricator.kde.org/D12102

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17225

AFFECTED FILES
  doc/kcontrol/translations/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Nathaniel Graham]

ngraham added a comment.


  In D17217#367643 , @graesslin 
wrote:
  
  > I don't think that this is useful - sorry. I run out of memory about once 
every five years, so polling every five seconds is way too often and a waste of 
resources. On the other hand the time when it happens polling 5 sec is way too 
low as then we are already dead. This can only happen if an application eats 
memory and then it's going fast.
  
  
  Agreed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Martin Flöser]

graesslin added a comment.


  I don't think that this is useful - sorry. I run out of memory about once 
every five years, so polling every five seconds is way too often and a waste of 
resources. On the other hand the time when it happens polling 5 sec is way too 
low as then we are already dead. This can only happen if an application eats 
memory and then it's going fast.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Wolfgang Bauer]

wbauer added a comment.


  Btw, It seems the gtk-cursor-theme-name option actually has no influence on 
GTK2 applications, so it probably wouldn't need to be written to the GTK2 
config here.
  But then, the KCM does save it to the GTK2 config as well...

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Nathaniel Graham]

ngraham added a comment.


  I agree with @abetts. The alignment changes are great, but I think it's a 
semantic error to use the title size and style for text that's essentially a 
glorified back button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Wolfgang Bauer]

wbauer added a comment.


  In D17187#367366 , @fvogt wrote:
  
  > > The same happens already if one uses the GTK KCM though, as it will 
always write a cursor theme entry too.
  >
  > Yes, that can be unexpected - even by not changing the cursor theme 
explicitly, it can make a difference. In that way this patch makes it more 
predictable.
  
  
  Regarding this, I'd probably add a "Default" entry that is pre-selected when 
no cursor theme is set in the config, and would not write a 
gtk-cursor-theme-name line when saving.
  Although the latter part may still cause surprises if a cursor theme is 
specified in the system-wide gtk config... :-/

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Wolfgang Bauer]

wbauer added a comment.


  In D17187#367565 , @ngraham wrote:
  
  > That's a pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=401507
  
  
  That's not the full truth though.
  The cursor theme KCM will affect the default theme of the whole session.
  I.e. it actually will affect non-KDE applications too, unless they explicitly 
use a different one.
  
  startkde (or startplasmacompositor on Wayland) reads the setting and sets the 
corresponding environment variable (XCURSOR_THEME)
  
  > Ideally we wouldn't need a GTK KCM at all because the other KCMs would 
change the appropriate GTK settings at the same time as the KDE settings.
  
  I'm not sure that's a good idea in every case though.
  E.g. there likely won't be the same widget styles installed for Qt5, GTK2, 
and GTK3... Especially since GTK3 dropped support for theme engines like Oxygen 
or QtCurve.
  
  Anyway, I mainly wanted to point out where the wrong cursor theme in GTK3 
applications actually comes from. Explicitly setting it in the default GTK 
configs should normally not be necessary at all, unless there's a system-wide 
config that sets it already. As we cannot influence the latter, it's probably 
better to do it anyway though.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Andres Betts]

abetts added a comment.


  I don't really have an issue with the font alignment. I think where I am 
conflicted is the part where we want this text to have too many purposes. The 
label is big so as to mean that it is a page title. However, when we place this 
on a phone, the header text is huge. So the label is trying to be a page title 
and a breadcrumb. I think that we should rethink the size, at least. The 
alignment is great.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

[Nathaniel Graham]

ngraham added a comment.


  Looking good code-wise!
  
  Could we take the opportunity to improve the layout too? This huge list of 
checkboxes is entirely left-aligned, with a huge gaping chasm of whitespace on 
the right. Seems like we could benefit from centering it as per the typical 
Kirigami FormLayout appearance.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Marco Martin]

mart added a comment.


  @abetts , @ngraham discuss :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17216: Move the about page from Discover to Kirigami

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46417.
apol added a comment.


  ADd since

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17216?vs=46416=46417

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17216

AFFECTED FILES
  kirigami.qrc
  src/controls/AboutPage.qml
  src/controls/LinkButton.qml
  src/controls/UrlButton.qml
  src/kirigamiplugin.cpp
  src/qmldir
  src/settings.cpp
  src/settings.h

To: apol, #kirigami, mart, broulik
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17216: Move the about page from Discover to Kirigami

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in AboutPage.qml:102
> Not a huge fan of this, privacy-wise, also QtQuick doesn't do any caching on 
> its own

I do agree it can read a bit weird.
It's generally done on public emails though, I'm not sure why it's bad.

If we feel better about it, I can drop it and we port it to something else 
we're happy with some day.

> broulik wrote in LinkButton.qml:35
> This thing is missing `Accessible` and keyboard handling, can you make this 
> style `AbstractButton` or something instead?

It used to be an AbstractButton, I remember it having weird behaviors in 
layouts, and in general we actually want it to behave as a Label.
I'll add Accessible.

> broulik wrote in UrlButton.qml:51
> Add `edit-copy` icon

I don't think we can have icons in menus yet in Qt 5.9.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17216

To: apol, #kirigami, mart, broulik
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17216: Move the about page from Discover to Kirigami

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46416.
apol marked 5 inline comments as done.
apol added a comment.


  Address Kai's comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17216?vs=46406=46416

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17216

AFFECTED FILES
  kirigami.qrc
  src/controls/AboutPage.qml
  src/controls/LinkButton.qml
  src/controls/UrlButton.qml
  src/kirigamiplugin.cpp
  src/qmldir
  src/settings.cpp
  src/settings.h

To: apol, #kirigami, mart, broulik
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17219: Fix group popup dialog

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ed34cc5f181e: Fix group popup dialog (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17219?vs=46414=46415

REVISION DETAIL
  https://phabricator.kde.org/D17219

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

To: hein, davidedmundson, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17219: Fix group popup dialog

[Eike Hein]

hein created this revision.
hein added a reviewer: davidedmundson.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Fixes regression introduced with ab26ebb18b74 
: 
That diff contained
  a change unrelated to the original submission, swapping a || out for
  && in response to a review note. This turns out to have broken things.
  
  BUG:401508

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17219

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The Layout and Wallpaper Type comboboxes should open on press, not on 
click-and-release.
  
  The Positioning combobox shouldn't be so much much wider than the other 
comboboxes; the text of the longest item doesn't seem long enough to cause such 
a long width.
  
  Is changing the wallpaper plugins button even necessary for this patch? If 
you think it is, instead of making the wallpaper plugin button icons-only, can 
we move it to the bottom row with the other GHNS button?
  
  Either way, this patch now fixes https://bugs.kde.org/show_bug.cgi?id=401472 
so please add:
  
BUG: 401472
FIXED-IN: 5.15.0

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17004: Always scroll views up when the fullrepr is collapsed.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:74ff6586944f: Always scroll views up when the fullrepr is 
collapsed. (authored by hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17004?vs=45778=46413#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17004?vs=45778=46413

REVISION DETAIL
  https://phabricator.kde.org/D17004

AFFECTED FILES
  applets/kickoff/package/contents/ui/ApplicationsView.qml
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: hein, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Nathaniel Graham]

ngraham added a comment.


  In D17217#367544 , @McPain wrote:
  
  > Sometimes I see what happens if you're running out of memory and oom can't 
do anything - the whole system halts and only solution for this is hard reset 
with all unsaved data lost.
  >  25% is not hardcoded value, **you can reduce threshold down to 1%** and 
also **you can include your swap space in settings.**
  
  
  The problem is that none of this is appropriate to expose regular users to. 
If this feature goes in, it needs //perfect// defaults, because 99.99% of users 
will never change the defaults even if they are annoyed by them.
  
  I would recommend changing the default threshold from 25% to 10%, and 
automatically detect swap space rather than making the user configure it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367545 , @abetts wrote:
  
  > Is having this feature an optional feature? Can it be turned off?
  
  
  I'll make the notification "disableable" tomorrow

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Nathaniel Graham]

ngraham added a comment.


  In D17187#367348 , @wbauer wrote:
  
  > OTOH, this patch actually causes a mismatch if one changes the cursor theme 
in Plasma's cursor theme KCM. (it won't affect GTK applications, they will 
continue to use breeze...)
  
  
  That's a pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=401507
  
  (See also https://bugs.kde.org/show_bug.cgi?id=138866 and 
https://bugs.kde.org/show_bug.cgi?id=400101)
  
  Ideally we wouldn't need a GTK KCM at all because the other KCMs would change 
the appropriate GTK settings at the same time as the KDE settings.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17218: Fix removing first item in languages list

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Instead, we want to disallow removing when the count drops to 1.
  
  BUG:401473

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17218

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translationsmodel.cpp

To: hein, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Kai Uwe Broulik]

broulik added a comment.


  I think that's because we're iterating `m_cookieToBusService` in that method 
and at the same time have `ReleaseInhibition` tamper with it. Perhaps taking a 
copy should fix that already:
  
void PolicyAgent::onServiceUnregistered(const QString& serviceName)
{
// Ouch - the application quit or crashed without releasing its 
inhibitions. Let's fix that.
const auto cookieToBusService = m_cookieToBusService;
for (auto it = cookieToBusService.constBegin(); it != 
cookieToBusService.constEnd(); ++it) {
if (it.value() == serviceName) {
ReleaseInhibition(it.key());
}
}
m_cookieToBusService.clear();
}

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik
Cc: graesslin, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Andres Betts]

abetts added a comment.


  Is having this feature an optional feature? Can it be turned off?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367525 , @ngraham wrote:
  
  > Thanks for all the work!
  >
  > ...But is this actually useful or actionable for the majority of users? 
Free space is a fairly understandable concept: if you run out, you need to 
delete things to make more room before you can add more stuff. It won't fix 
itself unless the user does something. But memory pressure requires a much 
greater technical understanding and isn't subject to the same conditions. When 
the system is using up 75% of the available memory, there isn't necessarily a 
problem at all. Apps will move to swap automatically. Even if there is a 
problem, it's only temporary, and it may fix itself if the user does nothing as 
the system shuffles things around.
  >
  > I worry that this notifier would just be yet another annoying pop-up that 
people dismiss because they don't understand it.
  
  
  Sometimes I see what happens if you're running out of memory and oom can't do 
anything - the whole system halts and only solution for this is hard reset with 
all unsaved data lost.
  25% is not hardcoded value, you can reduce threshold down to 1% and also you 
can include your swap space in settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17216: Move the about page from Discover to Kirigami

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> AboutPage.qml:102
> +Layout.maximumWidth: Units.iconSizes.medium
> +source: "https://www.gravatar.com/avatar/; + 
> Qt.md5(modelData.emailAddress) + "?d=404=" + Units.iconSizes.medium
> +fallback: "user"

Not a huge fan of this, privacy-wise, also QtQuick doesn't do any caching on 
its own

> LinkButton.qml:35
> + */
> +QQC2.Label {
> +id: control

This thing is missing `Accessible` and keyboard handling, can you make this 
style `AbstractButton` or something instead?

> LinkButton.qml:44
> +
> +font: control.font
> +color: enabled ? Theme.linkColor : Theme.textColor

That binds to itself?

> LinkButton.qml:57
> +
> +onContainsMouseChanged: {
> +control.font.underline = containsMouse && control.enabled

Can this be done using a binding?

> UrlButton.qml:38
> +text: url
> +visible: text.length>0
> +

Coding style, spaces

> UrlButton.qml:41
> +acceptedButtons: Qt.LeftButton | Qt.RightButton
> +onClicked: {
> +if (mouse.button === Qt.RightButton)

Context menus open on //press//, not click

> UrlButton.qml:42
> +onClicked: {
> +if (mouse.button === Qt.RightButton)
> +menu.popup()

Coding style, braces

> UrlButton.qml:51
> +QQC2.MenuItem {
> +text: i18n("Copy link address")
> +onClicked: app.copyTextToClipboard(button.url)

Add `edit-copy` icon

> settings.cpp:136
> +{
> +return tr("KDE Frameworks %1Qt %2 (built against 
> %3)The %4 windowing system").arg(
> + QStringLiteral(KIRIGAMI2_VERSION_STRING),

Can we have this return a `QStringList` instead instead of assuming this will 
be rendered as html list? Or is that "not public api"?

> settings.h:66
>  
> +Q_PROPERTY(QString information READ information CONSTANT)
> +

Add some docs, also `information` isn't very descriptive name, also `@since`

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17216

To: apol, #kirigami, mart, broulik
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16890: [systemtray] Keep config entries after modifying

[Nathaniel Graham]

ngraham added a comment.


  If it's a Qt bug, our options are to fix it upstream, or work around it here 
with a comment in the code indicating the workaround and the Qt bug report. Can 
you add that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17217: Implement free memory notifier

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Thanks for all the work!
  
  ...But is this actually useful or actionable for the majority of users? Free 
space is a fairly understandable concept: if you run out, you need to delete 
things to make more room before you can add more stuff. It won't fix itself 
unless the user does something. But memory pressure requires a much greater 
technical understanding and isn't subject to the same conditions. When the 
system is using up 75% of the available memory, there isn't necessarily a 
problem at all. Apps will move to swap automatically. Even if there is a 
problem, it's only temporary, and it may fix itself if the user does nothing as 
the system shuffles things around.
  
  I worry that this notifier would just be yet another annoying pop-up that 
people dismiss because they don't understand it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE Privacy Sprint - Find a date

[Sandro Knauß]

Hey,

We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen 
in March. We think at a sprint of five days. The main goal for the sprint is 
to locate privacy issues and after locating them hopefully fix them. Let's 
take the advantage to speak in person with multiple people of different part 
in KDE to find solutions. Currently the date is not fixed, so we doodle for 
one:

https://bitpoll.mafiasi.de/poll/8BYKJA5B/

Please add yourself to the doodle fast, so that we can have a fixed date 
within the next weeks.

Explicitly we would like to invite people from following teams:
Plasma
Plasma mobile
Vault
Falkon
Choqok
KDE Pim
Frameworks

Please feel also invited, if you are not in such a team an be simply 
interested in that topic!

The sprint will either be located in Leipzig(Germany) or Les Magnas (France) 
http://auxsaisons.free.fr/. At the moment both options are still open, but 
soon we need to decide. What is your preference of place?

Some issues that came into my mind:

*  currently when clicking on a link in an email the url is accessed within 
Plasma and than forward this to Firefox. If the user wants to use TorBrowser 
as default browser it is a Privacy Breach.
 *  having an interface to torify/vpn applications

Wifi:

* detect wiki login pages - do not access internet before, e.g. you are 
using inet of a hotel
*  have a way to allow/dissallow applications interact with inet for specific 
wifis, e.g. you are using inet of a hotel

TLS:

* detecting bad SSL standards aka only TLS 1.0...
* more helpful SSL problem dialog (properly if you have a wifi login page)

Mails:

* Encrypting headers of mails to give less metadata to surveillance T742.
* Make it possible to search in encrypted mails, as until now, the encrypted 
data are a binary blob for the search. The search important to find mails 
again T8447.
* Add GnuPG TOFU (Trust On First Use) trust model support for KMail. With 
TOFU you will get more security without exchanging the gpg fingerprints. To 
make it clear, exchanging fingerprints gives better security, but is 
exhausting.
* Make Akregator webviewer protect against ad trackers T7528.

For more information look at https://phabricator.kde.org/T8622.

Share your thoughts and see you!

louise and hefee

signature.asc
Description: This is a digitally signed message part.

Re: Plasma 5.14.4

[Luna Jernberg]

Updating

On 11/27/18, Jonathan Riddell  wrote:
> Plasma 5.14.4 is now released
> https://www.kde.org/announcements/plasma-5.14.4.php
>

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  FreeMemoryNotifier will warn when free RAM is running out.
  By default, it is 25% without swap space.
  
  Like freespacenotifier, it will check every 5 seconds for amount of free 
memory and
  warn every time when it drops below limit and when free space amount drops 
more than half of previous value
  
  User can either kill most greedy process immediately or open a task manager 
to kill unneeded processes manually.
  Task manager was patched to ignore global config and show only user own 
processes, sorted by memory used in descending order.
  
  The settings are available at new KCM located in Desktop Behavior category.
  KCM and KDED modules are linked through DBus - committed settings are applied 
immediately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

AFFECTED FILES
  plasma-workspace/CMakeLists.txt
  plasma-workspace/freememorynotifier/CMakeLists.txt
  plasma-workspace/freememorynotifier/COPYING
  plasma-workspace/freememorynotifier/Messages.sh
  plasma-workspace/freememorynotifier/README
  plasma-workspace/freememorynotifier/freememorynotifier.cpp
  plasma-workspace/freememorynotifier/freememorynotifier.desktop
  plasma-workspace/freememorynotifier/freememorynotifier.h
  plasma-workspace/freememorynotifier/freememorynotifier.kcfg
  plasma-workspace/freememorynotifier/freememorynotifier.notifyrc
  plasma-workspace/freememorynotifier/freememorynotifier_prefs_base.ui
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.cpp
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.desktop
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.h
  plasma-workspace/freememorynotifier/module.cpp
  plasma-workspace/freememorynotifier/module.h
  plasma-workspace/freememorynotifier/org.kde.FreeMemoryNotifier.xml
  plasma-workspace/freememorynotifier/settings.kcfgc
  plasma-workspace/systemmonitor/ksystemactivitydialog.cpp
  plasma-workspace/systemmonitor/ksystemactivitydialog.h
  plasma-workspace/systemmonitor/main.cpp

To: McPain, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17216: Move the about page from Discover to Kirigami

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart, broulik.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Includes the AboutPage we're using in Discover for other Kirigami
  projects to use.
  It also includes UrlButton and LinkButton components that I had in Discover 
for
  longtime and can also be useful here.

TEST PLAN
  Used the AboutPage from Discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17216

AFFECTED FILES
  kirigami.qrc
  src/controls/AboutPage.qml
  src/controls/LinkButton.qml
  src/controls/UrlButton.qml
  src/kirigamiplugin.cpp
  src/qmldir
  src/settings.cpp
  src/settings.h

To: apol, #kirigami, mart, broulik
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16890: [systemtray] Keep config entries after modifying

[Anthony Fieroni]

anthonyfieroni added a comment.


  Yep, it's Qt bug.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17211: Port applet/containment configs to qqc2

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D16890: [systemtray] Keep config entries after modifying

[trmdi]

trmdi added a comment.


  In D16890#366015 , @anthonyfieroni 
wrote:
  
  > To commit it @mart @broulik ?
  
  
  I think that is not the root cause. You should fix the root cause instead of 
just a part of it.
  See my comment on https://bugs.kde.org/show_bug.cgi?id=393630#c25

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:111
> can you put this in the commit description as well?

How to get commit access?

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: mart, davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17213: Add support for settings portal

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Sandboxed applications usually don't have access to read kdeglobals 
configuration. For this
  reason we introduced Settings portal, to be able to obtain most necessary 
configuration without
  allowing applications access to hosts configuration. The Settings portal 
implementation in
  xdg-desktop-portals-kde was develop mostly for plasma-integration needs so it 
allows to get
  colors, fonts, widget theme and some other configuration from kdeglobals.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  jgrulich/portal-support

REVISION DETAIL
  https://phabricator.kde.org/D17213

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp
  src/platformtheme/kfontsettingsdata.h
  src/platformtheme/khintssettings.cpp
  src/platformtheme/khintssettings.h

To: jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

[Anthony Fieroni]

anthonyfieroni added a comment.


  It looks like the problem is in dimming.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart updated this revision to Diff 46398.
mart added a comment.


  - initialize a proper size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17211?vs=46397=46398

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart added a comment.


  oddly seems not all the pages to not animate... i fear they are trying to set 
anchors?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart added a comment.


  F6444604: Screenshot_20181128_130459.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart updated this revision to Diff 46397.
mart added a comment.


  move text in tooltip

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17211?vs=46394=46397

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol added a comment.


  Yes, yes, on it...

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

[Kai Uwe Broulik]

broulik added a comment.


  Quirks I have found:
  
  - The "Filters" page in Folder View configuration doesn't get a size 
initially and only does when I resize the window
  - The transition animation is buggy, the "enterItem" isn't properly animated 
from what I can tell, just pops up right away with the old KCM moving away
  - The "Positioning" combobox for the wallpaper disappears when FormLayout is 
narrow and starts laying out items below eath other
  
  Otherwise pretty good

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

[Aleix Pol Gonzalez]

apol added a comment.


  +1 cool!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17212: Port to QQC2 and FormLayout

[Marco Martin]

mart added a comment.


  F6444563: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  No big visible changes, but simplifies and modernizes the code

TEST PLAN
  used all functionality of the systray config dialog

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Kai Uwe Broulik]

broulik added a comment.


  Wouldn't it make sense to provide an `AboutPage` in Kirigami 
(KF5::kirigami-whatever-that-can-be-tier-2 :D) like kxmlgui has it, for use in 
e.g. Itinerary and what not?

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart added a comment.


  before:
  F6444531: Screenshot_20181128_113703.png 

  after:
  F6444535: Screenshot_20181128_113712.png 

  F6444538: Screenshot_20181128_113718.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  port the applet config dialogs and containments to
  QtQuickControls2 and Kirigami modernizing it,
  using form layouts, Headings and inline messages.
  look is almost the same modulo fixing some misalignments and following
  the hig more closely

TEST PLAN
  looked at every wallpaper plugin and
  loaded the config dialog of many applets

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Lovin' it - i also like how sort of... well, how little code there really is 
here, QML done absolutely the right way, only the presentation and that's it, 
nifty :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17177: Drop tab-based UI for the about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46390.
apol added a comment.


  Move report action back to the contextual actions

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17177?vs=46328=46390

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17177

AFFECTED FILES
  discover/qml/AboutPage.qml

To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Fabian Vogt]

fvogt added a comment.


  > OTOH, this patch actually causes a mismatch if one changes the cursor theme 
in Plasma's cursor theme KCM. (it won't affect GTK applications, they will 
continue to use breeze...)
  
  There is no sync in any direction of icon themes, cursor themes and 
application themes, which makes it all a bit cumbersome.
  
  > The same happens already if one uses the GTK KCM though, as it will always 
write a cursor theme entry too.
  
  Yes, that can be unexpected - even by not changing the cursor theme 
explicitly, it can make a difference. In that way this patch makes it more 
predictable.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17187: Set the default cursor theme to breeze_cursors

[Wolfgang Bauer]

wbauer added a comment.


  In D17187#367118 , @fvogt wrote:
  
  > In D17187#367110 , @wbauer wrote:
  >
  > > Actually, if the cursor theme is not set to anything, GTK would just use 
the session's default. I.e. this patch should not be necessary in the first 
place.
  >
  >
  > If it is set though, the default is different for GTK and Qt in a Plasma 
session, which can be surprising and this patch explicitly avoids that.
  
  
  OTOH, this patch actually causes a mismatch if one changes the cursor theme 
in Plasma's cursor theme KCM. (it won't affect GTK applications, they will 
continue to use breeze...)
  The same happens already if one uses the GTK theme though, as it will always 
write a cursor theme entry too.
  
  > Plasma can unfortunately not rely on sane GTK configs/packaging :-/
  
  Agreed.
  TBH, I don't see a point at all to configure the mouse cursor theme in the 
toolkit's settings, but that's not our decision anyway.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17187

To: fvogt, #plasma, ngraham
Cc: wbauer, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Marco Martin]

mart added a comment.


  anyways, this can wait/can be discussed, the ones instead i would like to get 
in soonish are D17190  and D17191 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17207: Use KPasswordLineEdit

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: jriddell, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - I now get the eye button to show the password I typed
  - Typing wrong password still leads to auth failure
  - Typing correct password works

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D17207

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: broulik, jriddell, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart