D22316: Avoid garbling the sound if the volume slider is moved fast

[Nathaniel Graham]

ngraham added a comment.


  In D22316#492059 , @kezik wrote:
  
  > I don't know why it is not showing the context of the patch 路‍♂️
  >  I selected the plasma-pa project
  
  
  Because you didn't use `arc` to submit the patch and Phabricator is kinda 
dumb about this. This should get much better with GitLab.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #vdg, #plasma, drosca
Cc: ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61379.
apol added a comment.


  Call setFuture after connecting to finished

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22333?vs=61372=61379

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22333

AFFECTED FILES
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/hotplug/hotplugengine.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick marked 2 inline comments as done.
croick added a comment.


  In D11234#492200 , @sitter wrote:
  
  > Could you explain your thinking behind the adjustSize call please? The way 
I see it the window should scale up as necessary if the size hints are properly 
set (which they should be on master).
  
  
  That's true, but only since your latest commits. Before, the text of the 
report button was cut off (in german for example) once the debug button got 
activated. I removed the call again.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick updated this revision to Diff 61377.
croick added a comment.


  - more style fixes
  - do not adjustSize after adding the button, since that is redundant now

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11234?vs=59627=61377

BRANCH
  nicebutton

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp
  src/drkonqidialog.h

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  They block the startup notably but the API doesn't require it to be blocking.

TEST PLAN
  Ran plasmashell several times

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22333

AFFECTED FILES
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/hotplug/hotplugengine.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61371.
tcanabrava added a comment.


  - Add pid information to the log files
  - rebase

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61360=61371

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 54 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/54/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 08 Jul 2019 19:02:02 +
 Build duration:
2 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-08T19:04:06.006Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-08T19:04:06.006Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-08T19:04:06.006Z] PROCESSOR_LEVEL   = '6'[2019-07-08T19:04:06.006Z] PROCESSOR_REVISION= '5e03'[2019-07-08T19:04:06.006Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-08T19:04:06.006Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-08T19:04:06.006Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-08T19:04:06.006Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-08T19:04:06.006Z] PROMPT= '$P$G'[2019-07-08T19:04:06.006Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-08T19:04:06.006Z] PUBLIC= 'C:\Users\Public'[2019-07-08T19:04:06.006Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/54/display/redirect?page=changes'[2019-07-08T19:04:06.006Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/54/display/redirect'[2019-07-08T19:04:06.006Z] STAGE_NAME= 'Configuring Build'[2019-07-08T19:04:06.006Z] SYSTEMDRIVE   = 'C:'[2019-07-08T19:04:06.006Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-08T19:04:06.006Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T19:04:06.006Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T19:04:06.006Z] UCRTVERSION   = '10.0.17763.0'[2019-07-08T19:04:06.006Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T19:04:06.006Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-08T19:04:06.006Z] USERNAME  = 'Jenkins'[2019-07-08T19:04:06.006Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-08T19:04:06.006Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-08T19:04:06.006Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-08T19:04:06.006Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-08T19:04:06.006Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-08T19:04:06.006Z] VCTOOLSVERSION= '14.16.27023'[2019-07-08T19:04:06.006Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-08T19:04:06.006Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-08T19:04:06.006Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-08T19:04:06.006Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-08T19:04:06.006Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-08T19:04:06.006Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-08T19:04:06.006Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-08T19:04:06.006Z] VSCMD_VER = '16.0.3'[2019-07-08T19:04:06.006Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-08T19:04:06.006Z] WINDIR= 'C:\WINDOWS'[2019-07-08T19:04:06.006Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-08T19:04:06.007Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-08T19:04:06.007Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T19:04:06.007Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-08T19:04:06.007Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-08T19:04:06.007Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-08T19:04:06.007Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-08T19:04:06.007Z] __DOTNET_ADD_64BIT= '1'[2019-07-08T19:04:06.007Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-08T19:04:06.007Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-08T19:04:06.007Z] 

D22242: Fix some tests in release mode

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:2f828efa74b3: Fix some tests in release mode (authored by 
tcanabrava).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22242?vs=61086=61369

REVISION DETAIL
  https://phabricator.kde.org/D22242

AFFECTED FILES
  src/bugzillaintegration/libbugzilla/autotests/attachmenttest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/commenttest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp

To: tcanabrava, sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in logout.cpp:399-400
> Make job autodelete if not.

This is no KJob

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, sitter, apol, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[Kai Uwe Broulik]

broulik added a comment.


  PowerDevil checks `if (KWorkSpace::isShuttingDown()) {` before suspending, so 
I think the ksmserver stuff is obsolete

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, sitter, apol, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[David Edmundson]

davidedmundson added a comment.


  Given it's already broken, I would say just kill it.
  
  I've not had any related bug reports.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, sitter, apol, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61360.
tcanabrava added a comment.


  - Add pid information to the log files

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61338=61360

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> logout.cpp:399-400
>  } else {
> -Solid::PowerManagement::stopSuppressingSleep(inhibitCookie);
> +delete inhibitionJob;
> +inhibitionJob = nullptr;
>  qCDebug(KSMSERVER) << "Client " << c->program() << " (" << 
> c->clientId() << ") canceled shutdown.";

Make job autodelete if not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, sitter, apol, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[Stefan Brüns]

bruns added a comment.


  In D22296#492147 , @sitter wrote:
  
  >
  
  
  
  
  > So, in order to port to the API, it'd first need finishing up really.
  
  The question is - do we really want this call here, or not. As is, it is just 
an expensive noop.
  
  **Iff** we want the inhibition, I see 3 possibilities:
  
  1. Teach powerdevil to behave correctly:
- do the inhibition immediately
- keep running until all proxied inhibitions are released (maybe this is 
inversed - do not kill powerdevil from ksmserver).
- somehow interact with powerdevil from ksmserver
  2. Take an inhibitor lock via DBus (i.e. call 
`org.freedesktop.login1.Inhibit`) directly
  3. Take an inhibitor lock using `Solid::Power::inhibit`
  
  (3.) is nothing more than a thin wrapper around (2.) see 
https://github.com/KDE/solid/blob/master/src/solid/power/backends/freedesktop/fdinhibition.cpp
  Although Solid::Power would give some abstraction, the reality is:
  
  - only blocking inhibitions are supported
  - only implementation is `org.freedesktop.login1`
  - Solid::Power is very incomplete, e.g. the `statesJob` is just a stub.
  
  My preference is (0.) or (2.).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

sitter added a comment.


  That is rather disgusting snark there. Thanks for that

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22326

To: sitter, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  
  
  > And perhaps more ideally, albeit not blocking this diff, we should look at 
reshuffling the architecture so on next login drkonqi auto starts with a list 
of crashes and the ability to file reports for them.
  
  That second part is in the works. I had a working version but I did not like 
the outcome. Still, they can be separate reviews.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22326: fix API availability/version detection to not be terribly racey

[Kai Uwe Broulik]

broulik added a comment.


  I wasn't serious when I said you should use a QML view with a 
`BusyIndicator`. I don't think that's appropriate. You don't want DrKonqi 
crashing when you want to report a crash caused by the nvidia driver. Or maybe 
that's the plan. Clever.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22326

To: sitter, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

sitter added a comment.


  Looks comme ca when the page actually is necessary:
  
  F6991301: Screenshot_20190708_171225.png 

  
  F6991303: Screenshot_20190708_171054.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22326

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/53/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 08 Jul 2019 15:07:02 +
 Build duration:
1 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-08T15:08:39.754Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-08T15:08:39.754Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-08T15:08:39.754Z] PROCESSOR_LEVEL   = '6'[2019-07-08T15:08:39.754Z] PROCESSOR_REVISION= '5e03'[2019-07-08T15:08:39.754Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-08T15:08:39.754Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-08T15:08:39.754Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-08T15:08:39.754Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-08T15:08:39.754Z] PROMPT= '$P$G'[2019-07-08T15:08:39.754Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-08T15:08:39.754Z] PUBLIC= 'C:\Users\Public'[2019-07-08T15:08:39.754Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/53/display/redirect?page=changes'[2019-07-08T15:08:39.754Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/53/display/redirect'[2019-07-08T15:08:39.754Z] STAGE_NAME= 'Configuring Build'[2019-07-08T15:08:39.755Z] SYSTEMDRIVE   = 'C:'[2019-07-08T15:08:39.755Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-08T15:08:39.755Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T15:08:39.755Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T15:08:39.755Z] UCRTVERSION   = '10.0.17763.0'[2019-07-08T15:08:39.755Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T15:08:39.755Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-08T15:08:39.755Z] USERNAME  = 'Jenkins'[2019-07-08T15:08:39.755Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-08T15:08:39.755Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-08T15:08:39.755Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-08T15:08:39.755Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-08T15:08:39.755Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-08T15:08:39.755Z] VCTOOLSVERSION= '14.16.27023'[2019-07-08T15:08:39.755Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-08T15:08:39.755Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-08T15:08:39.755Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-08T15:08:39.755Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-08T15:08:39.755Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-08T15:08:39.755Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-08T15:08:39.755Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-08T15:08:39.755Z] VSCMD_VER = '16.0.3'[2019-07-08T15:08:39.755Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-08T15:08:39.755Z] WINDIR= 'C:\WINDOWS'[2019-07-08T15:08:39.755Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-08T15:08:39.755Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-08T15:08:39.755Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T15:08:39.755Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-08T15:08:39.755Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-08T15:08:39.755Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-08T15:08:39.755Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-08T15:08:39.755Z] __DOTNET_ADD_64BIT= '1'[2019-07-08T15:08:39.755Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-08T15:08:39.755Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-08T15:08:39.755Z] 

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/15/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 08 Jul 2019 15:07:02 +
 Build duration:
1 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 221 lines...][2019-07-08T15:08:38.106Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-08T15:08:38.106Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-08T15:08:38.106Z] PROCESSOR_LEVEL   = '6'[2019-07-08T15:08:38.106Z] PROCESSOR_REVISION= '5e03'[2019-07-08T15:08:38.106Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-08T15:08:38.106Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-08T15:08:38.106Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-08T15:08:38.106Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-08T15:08:38.106Z] PROMPT= '$P$G'[2019-07-08T15:08:38.106Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-08T15:08:38.106Z] PUBLIC= 'C:\Users\Public'[2019-07-08T15:08:38.106Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/15/display/redirect?page=changes'[2019-07-08T15:08:38.106Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/15/display/redirect'[2019-07-08T15:08:38.106Z] STAGE_NAME= 'Configuring Build'[2019-07-08T15:08:38.106Z] SYSTEMDRIVE   = 'C:'[2019-07-08T15:08:38.106Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-08T15:08:38.106Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T15:08:38.106Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T15:08:38.106Z] UCRTVERSION   = '10.0.17763.0'[2019-07-08T15:08:38.106Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T15:08:38.106Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-07-08T15:08:38.106Z] USERNAME  = 'Jenkins'[2019-07-08T15:08:38.106Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-08T15:08:38.106Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-08T15:08:38.106Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-08T15:08:38.106Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-08T15:08:38.106Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-08T15:08:38.106Z] VCTOOLSVERSION= '14.16.27023'[2019-07-08T15:08:38.106Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-08T15:08:38.106Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-08T15:08:38.106Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-08T15:08:38.106Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-08T15:08:38.106Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-08T15:08:38.106Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-08T15:08:38.106Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-08T15:08:38.106Z] VSCMD_VER = '16.0.3'[2019-07-08T15:08:38.106Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-08T15:08:38.106Z] WINDIR= 'C:\WINDOWS'[2019-07-08T15:08:38.106Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-08T15:08:38.106Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-08T15:08:38.106Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T15:08:38.106Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-08T15:08:38.106Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-08T15:08:38.106Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-08T15:08:38.106Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-07-08T15:08:38.106Z] __DOTNET_ADD_64BIT= '1'[2019-07-08T15:08:38.106Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-08T15:08:38.106Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program 

D22328: refactor basic OS info to be set via config and fixate it for testing

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:a2adbe4a0e0b: refactor basic OS info to be set via config 
and fixate it for testing (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22328?vs=61346=61350

REVISION DETAIL
  https://phabricator.kde.org/D22328

AFFECTED FILES
  src/systeminformation.cpp
  src/systeminformation.h
  src/tests/systeminformationtest.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22329: hide save-login-info checkbox when kwallet is disabled

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:46a72cdc5e9d: hide save-login-info checkbox when kwallet 
is disabled (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22329?vs=61347=61349

REVISION DETAIL
  https://phabricator.kde.org/D22329

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre planned changes to this revision.
davidre added a comment.


  I may have introduced a similar crash or  made it easier to trigger Nate's 
crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22329: hide save-login-info checkbox when kwallet is disabled

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  we can't save the info if kwalletd is disabled so let's hide the checkbox
  
  BUG: 363570
  FIXED-IN: 5.16.3
  CHANGELOG: Login information saving is only offered when supported

TEST PLAN
  - disable kwalletd in kcm
  - checkbox not shown

REPOSITORY
  R871 DrKonqi

BRANCH
  sitter/kwalletenabled

REVISION DETAIL
  https://phabricator.kde.org/D22329

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22328: refactor basic OS info to be set via config and fixate it for testing

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the basic OS info is decided at compile time, on top of that
  influences whether lsbrelease and osrelease are even run, and also
  acts as seed value for some other members.
  this resulted in tests failing on freebsd because it would detect freebsd
  as build platform and then skip all the advanced lookup tech and having
  unexpected values.
  
  fetchOSBasicInformation is now a dangling static and used to determine
  the default constructed config value of the operating system.
  this is now also forced to read Linux for the tests.
  
  I've also changed all the QLatin1Strings in the function to QStringLiteral.
  as I recall QL1S is only faster when not turning the object into a
  full QString, so these values shouldn't be QL1S.

TEST PLAN
  tests pass on linux still (and hopefully freebsd CI too)

REPOSITORY
  R871 DrKonqi

BRANCH
  sitter/fetchosbasic

REVISION DETAIL
  https://phabricator.kde.org/D22328

AFFECTED FILES
  src/systeminformation.cpp
  src/systeminformation.h
  src/tests/systeminformationtest.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22327: [libnotificationmanager] Port to lighter KProcessList

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  This now returns the entire command line, not just the process name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22327

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22327: [libnotificationmanager] Port to lighter KProcessList

[David Edmundson]

davidedmundson updated this revision to Diff 61345.
davidedmundson added a comment.


  remove from cmake

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22327?vs=61344=61345

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22327

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/utils.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22327: [libnotificationmanager] Port to lighter KProcessList

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KSysGuard fetches everything you could possibly need from a process.
  
  If we just need a name of a process, we can use the new KProcessList API
  in KCoreAddons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22327

AFFECTED FILES
  libnotificationmanager/utils.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously at a random point in time there'd be a call to get the bugzilla
  version, that call would (hopefully) reach the login page and cause it
  allow login. this is essentially a blocking safe guard to not talk to
  unsupported or unreachable bugzillas. because this was entirely
  synchronized there was great potential for signal and state racing
  where the login page could randomly end up with a disabled login
  button when the api communication failed for whatever reason.
  
  this was further complicated by the fact that there was zero UI backing
  for the entire check resulting in the login button getting disabled but
  the user not having any indication as to why or any means to retry.
  
  to resolve this problem a bunch of changes are necessary:
  
  - bugzillalib now has an error signal when the version check fails 
(previously not having received a finished signal meant error, when in fact 
that may also mean not-yet-done)
  - buzillalib also no longer automatically issues a version lookup as it 
itself has no use of knowing the version right now
  - the login page logic has had all awareness of bugzilla availability 
stripped. the assumption now is that when login is reached bugzilla could be 
contacted.
  - there is a new 'version' page now sorted before the login page. the version 
page's only use is to provide a UI for the version check or more generally if 
bugzilla is reachable. it has a busy state and an error stage, once the version 
check completed once the page is marked inappropriate and would automatically 
skip ahead as necessary. the `appropriate` value specifically allows 
kassistantdialog to ignore the page when skipping forward/backward effectively 
hiding the page from the user.
  - for purposes of controlling its own appropriateness the KPageWidgetItem of 
this new page is controlled by the page itself, a design which IMO should be 
also adopted for the other pages
  - for visual consistency with plasma a qml busyindicator is used on the page. 
also looks nicer than the ksquencepixmap thingy
  
  The result of this is that upon startup of the dialog, the version page
  is created (albeit not visible) and issues a version check. When that
  returns the page turns itself inappropriate (and skips ahead if necessary).
  Ideally this means the user never sees the page, unless there is an error
  in which case the page will block progressing to actually submit the
  error to bugzilla. At the same time the user can choose to go back to the
  backtrace page to manually grab it and file a bug in the event that
  drkonqi cannot get beyond the version page.
  
  BUG: 373099
  BUG: 354292
  FIXED-IN: 5.17.0
  CHANGELOG: Contact to drkonqi is now more reliably verified and the login 
button enabled when possible

TEST PLAN
  - slow internet results in page to show up
  - errors result in page to go into error state
  - fast internet lets the page not show up
  - retry button retries when there was an error on first try
  - page switches between states correctly

REPOSITORY
  R871 DrKonqi

BRANCH
  versioncheck

REVISION DETAIL
  https://phabricator.kde.org/D22326

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/assistantpage_bugzilla_version.cpp
  src/bugzillaintegration/assistantpage_bugzilla_version.h
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/qml.qrc
  src/bugzillaintegration/qml/BusyIndicator.qml
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_version.ui
  src/drkonqi_globals.h

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22322: Store crash report automatically if shutting down

[Harald Sitter]

sitter added a comment.


  In D22322#492240 , @davidedmundson 
wrote:
  
  > > What's the rationale behind this change? Isn't this use case covered by 
coredumpd and the like?
  >
  > Well, by that logic we wouldn't have any drkonqi...
  
  
  I don't see how.
  
  Drkonqi is and interactive crash reporter, coredumpd is a non-interactive 
crash catcher. What the diff is doing is taking away the interactivity of 
drkonqi in certain cases, and that looks to me like we are simply replicating 
coredumpd at this point. Specifically the diff adds nothing on top of what 
coredumpd already does, in fact it's worse because we currently don't capture 
cores, so you couldn't retrace our saved trace with possibly missing debug 
symbols.
  
  The interactive way of handling a crash on logout would be to show drkonqi 
and let the user file a bug report. Now I understand this isn't all that 
reliable, so I would discard the crash and just exit under the assumption that 
a kernel core pattern (e.g. coredumpd) will deal with the crash.
  
  If you are adamant about this diff I think we need at least a cleanup system 
to enforce a hard limit on how many traces we keep around, and/or traces of how 
many logins ago, and/or how many MiB they may consume. Otherwise people are 
going to get annoyed when there disk is full in a year because the 
ffmpegthumbnailer crashed a gazillion times ^^
  
  And perhaps more ideally, albeit not blocking this diff, we should look at 
reshuffling the architecture so on next login drkonqi auto starts with a list 
of crashes and the ability to file reports for them.

INLINE COMMENTS

> drkonqi.cpp:226
> +
> +const QString defname = dirname
> ++ QLatin1Char('/') 

Needs to include pid. I can have multiple kwrites running and they could all be 
crashing.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik updated this revision to Diff 61337.
kezik added a comment.


  Thanks @davidedmundson for the feedback, 
  I fixed what you suggested, but thinking about this again, the 50ms timer 
fixed the audio garbling but the sounds felt "too frequent", increasing the 
timer gave the same exact result as disabling the function altogether, so 
here's that.
  It wasn't worth the extra complexity of the timer

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22316?vs=61302=61337

REVISION DETAIL
  https://phabricator.kde.org/D22316

AFFECTED FILES
  src/qml/volumefeedback.cpp

To: kezik, #vdg
Cc: davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61338.
tcanabrava added a comment.


  Store in the cache folder

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61324=61338

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61335.
davidre added a comment.


  - Remember current slide between starts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61318=61335

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> volumefeedback.cpp:33
> +
> +timer = new QTime();
> +timer->start();

This object leaks.

You're better off just making it a member var directly.

Also, see QElapsedTimer

> volumefeedback.cpp:34
> +timer = new QTime();
> +timer->start();
>  }

Why? This will block the first noise?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #vdg
Cc: davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/52/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 08 Jul 2019 11:19:26 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-08T11:41:53.553Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-08T11:41:53.553Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-08T11:41:53.553Z] PROCESSOR_LEVEL   = '6'[2019-07-08T11:41:53.553Z] PROCESSOR_REVISION= '5e03'[2019-07-08T11:41:53.553Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-08T11:41:53.553Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-08T11:41:53.553Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-08T11:41:53.553Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-08T11:41:53.553Z] PROMPT= '$P$G'[2019-07-08T11:41:53.553Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-08T11:41:53.553Z] PUBLIC= 'C:\Users\Public'[2019-07-08T11:41:53.553Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/52/display/redirect?page=changes'[2019-07-08T11:41:53.553Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/52/display/redirect'[2019-07-08T11:41:53.553Z] STAGE_NAME= 'Configuring Build'[2019-07-08T11:41:53.553Z] SYSTEMDRIVE   = 'C:'[2019-07-08T11:41:53.553Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-08T11:41:53.553Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T11:41:53.553Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-08T11:41:53.553Z] UCRTVERSION   = '10.0.17763.0'[2019-07-08T11:41:53.553Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T11:41:53.553Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-08T11:41:53.553Z] USERNAME  = 'Jenkins'[2019-07-08T11:41:53.553Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-08T11:41:53.553Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-08T11:41:53.553Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-08T11:41:53.553Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-08T11:41:53.553Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-08T11:41:53.553Z] VCTOOLSVERSION= '14.16.27023'[2019-07-08T11:41:53.553Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-08T11:41:53.553Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-08T11:41:53.553Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-08T11:41:53.553Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-08T11:41:53.553Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-08T11:41:53.553Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-08T11:41:53.553Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-08T11:41:53.553Z] VSCMD_VER = '16.0.3'[2019-07-08T11:41:53.553Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-08T11:41:53.553Z] WINDIR= 'C:\WINDOWS'[2019-07-08T11:41:53.553Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-08T11:41:53.553Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-08T11:41:53.553Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-08T11:41:53.553Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-08T11:41:53.553Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-08T11:41:53.553Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-08T11:41:53.553Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-08T11:41:53.553Z] __DOTNET_ADD_64BIT= '1'[2019-07-08T11:41:53.553Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-08T11:41:53.553Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-08T11:41:53.553Z] CMAKE_PREFIX_PATH 

D22323: Code cleanups

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:1af8e1cc37e9: Const-correctness (authored by tcanabrava).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22323?vs=61325=61330#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22323?vs=61325=61330

REVISION DETAIL
  https://phabricator.kde.org/D22323

AFFECTED FILES
  src/main.cpp

To: tcanabrava, sitter
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22323: Code cleanups

[Tomaz Canabrava]

tcanabrava added a comment.


  In D22323#492220 , @sitter wrote:
  
  > I do wonder if it wouldn't make sense to make the two helpers into a new 
class DrKonqiLauncher or some such and then delegate this entire decision to 
the class. The way this was before the diff is weird, and the way it is after 
the diff is still weird IMHO. Also the two objects that are allocated in the 
two methods aren't properly deleted anywhere it seems.
  
  
  I'll try to rework them in classes in a followup change.

REPOSITORY
  R871 DrKonqi

BRANCH
  codeCleanups

REVISION DETAIL
  https://phabricator.kde.org/D22323

To: tcanabrava, sitter
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22322: Store crash report automatically if shutting down

[David Edmundson]

davidedmundson added a comment.


  > What's the rationale behind this change? Isn't this use case covered by 
coredumpd and the like?
  
  Well, by that logic we wouldn't have any drkonqi...
  
  1. crashes on shutdown are currently weird.
  
  A dialog appears and blocks on logout, on shutdown it's a random race. The 
crash dialog sometimes appears as an SNI which will get missed, sometimes a 
window on a different VD or different activity.
  
  2. with a tiny bit of work kwin_wayland crashes will get a bug reporter, 
which would be an amazing leap forward.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

notes for meeting of 8/07/2019

[Marco Martin]

Roman:
* I am at the moment refactoring the Compositor class:
https://phabricator.kde.org/T11071 Already multiple patches landed
last week. Thx zzag for reviews. Two more are currently in review
including the split of the class into X11 and Wayland subclasses. I
want to merge these today. I could think of some more clean-up patches
and then look into the actual timing code for compositing.
* Besides I have some patches for fullscreen control. They need a
rebase and I need to test them again to check if they haven't
regressed. But I assume not and want to merge them today as well.
* Further more I want to fix remaining small issues in the KScreen
code this week: T11095 "Further KScreen / multi-display improvements"
[Open,Normal] {Plasma} https://phabricator.kde.org/T11095

Kai Uwe:
 * Went to Tübingen with romangg to attend Tübix (tuebix.org):
 * https://twitter.com/kdecommunity/status/1147458598567632898
 * Gave a brief talk about our offerings for education, e.g. Kile,
Umbrello, LabPlot
 * People quite oblivious to the fact we do stuff "other than
desktops", so was quite good I raised awareness for it there :)
 * Feedback was very positive, people love Plasma <3
 * Fixed various regressions caused by performance optimizations and
refactorings
reira (~jfmcar...@bl6-7-246.dsl.telepac.pt) has left this server
(Changing host).
reira (~jfmcarrei@unaffiliated/jfmcarreira) has joined this channel.
 * Reverted System Tray UX rewrite owing to lack of care by the author
for regressions caused

Nicolas Fella:
* I mostly did Plasma Mobile stuff
* Random UI/QML fixes in KCMs
* Improvements to plasma-phonebook
* Started writing a list of all the little things that need fixing
* Started rewriting plasma-settings since the current code is
needlessly complex IMO
** Goal is to get rid of org.kde.plasma.active.settings QML import
** My main assumption is that if all KCMs are based on KQuickaddons::
configmodule and Kirigami Page we can just push the mainview onto the
pagestack instead of doing the current stuff in plasma-settings

David Redondo:
* I did some custom widget painting
https://matrix.org/_matrix/media/v1/download/kde.org/ziVsKAkudnsWYKtvHoDXSXEC
prograssbar animation on spectacle button
* and today continuuing to look into slideshow stuff for wallpaper config

Tomaz Canabrava:
* drkonqi improvements
* work on konsole.

Leinir:
* Themes downloaded through GHNS are now filtered by plasma version
compatibility (5.16 and master), but of course this needs to be set on
the server by someone. So if you come across a theme that doesn't work
right, please tell the theme author, or one of the store admin team
members :) https://phabricator.kde.org/D21510
Diff 21510 "Filter KNewStuff Plasma Themes by Download Tag"
[Closed] https://phabricator.kde.org/D21510
(nb: we do lack some kind of reporting mechanism for incorrect or
missing tags and whatnot, already on the store workboard)
* wip of my knewstuffquick work here: https://phabricator.kde.org/D21721 :)

Marco:
Kirigami:
* breadcrumb mouseover effect on desktop
* text mode for the action bar component (beside icon, under icon,
icon only, text only)

Plasma:
* some work on new desktop layout manager

D22322: Store crash report automatically if shutting down

[Harald Sitter]

sitter added a comment.


  As mentioned in D22323  the stuff in 
main.cpp needs putting in a class.
  
  What's the rationale behind this change? Isn't this use case covered by 
coredumpd and the like?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22322: Store crash report automatically if shutting down

[David Edmundson]

davidedmundson added a comment.


  Concept: +1
  
  One question, when do we create a DBusInterfaceLauncher  instance.  Is it in 
time here?
  
  Without this startkde won't know there's a drkonqi it should be waiting for 
and then whether you finish saving or not becomes racey.

INLINE COMMENTS

> drkonqi.cpp:216
> +{
> +QString defname = QDir::homePath() + QDir::separator() + 
> getSuggestedKCrashFilename(DrKonqi::crashedApplication());
> +

Can we avoid littering the home directory. Somewhere in .cache might make 
sense, as if it gets lost it's not too important.

I've also been told it's more correct to use "/" instead of QDir::separator.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22323: Code cleanups

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I do wonder if it wouldn't make sense to make the two helpers into a new 
class DrKonqiLauncher or some such and then delegate this entire decision to 
the class. The way this was before the diff is weird, and the way it is after 
the diff is still weird IMHO. Also the two objects that are allocated in the 
two methods aren't properly deleted anywhere it seems.

INLINE COMMENTS

> main.cpp:56
> +namespace {
> +void openDrKonqiDialog () {
> +DrKonqiDialog *w = new DrKonqiDialog();

excess space before `(`

REPOSITORY
  R871 DrKonqi

BRANCH
  codeCleanups

REVISION DETAIL
  https://phabricator.kde.org/D22323

To: tcanabrava, sitter
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22323: Code cleanups

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Send options as an Array
  
  *should* be faster as potentially there will be just one allocation
  
  Rename variable: QApplication qa to app.
  
  qa means nothing and the default for Qt apps is to have the
  QApplication var named app.
  
  Return directly without creating temporaries
  
  Extract logic from main function

REPOSITORY
  R871 DrKonqi

BRANCH
  codeCleanups

REVISION DETAIL
  https://phabricator.kde.org/D22323

AFFECTED FILES
  src/main.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Still need to program the shutdown detection

REPOSITORY
  R871 DrKonqi

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22320: Hide "Dummy Output" from output list and improve user-visible labels

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:86d3fb911f0c: Hide Dummy Output from output 
list and improve user-visible labels (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22320?vs=61317=61323

REVISION DETAIL
  https://phabricator.kde.org/D22320

AFFECTED FILES
  applet/contents/ui/main.qml

To: broulik, #plasma, #vdg, drosca, nicolasfella, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Harald Sitter]

sitter added a comment.


  Could you explain your thinking behind the adjustSize call please? The way I 
see it the window should scale up as necessary if the size hints are properly 
set (which they should be on master).

INLINE COMMENTS

> drkonqidialog.cpp:203
> +//Report bug button: User1
> +QPushButton* reportButton = new QPushButton(m_buttonBox);
> +KGuiItem2 reportItem(i18nc("@action:button", "Report "),

- goes to the right of the space.

> drkonqidialog.cpp:210
> +
> +bool enableReportAssistant = !crashedApp->bugReportAddress().isEmpty() &&
> + crashedApp->fakeExecutableBaseName() != 
> QLatin1String("drkonqi") &&

could probably just do away with this and merge the condition into the 
setEnabled call below. the variable doesn't seem to do much in the way of 
readability.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  In D22121#492179 , @msdobrescu 
wrote:
  
  > Thanks, selecting from any image is useful, to avoid starting always from 
the top one. But should not enable the button until a check is done.
  
  
  Ideally if you want a specific image you should use a  static wallpaper. But 
I see what you mean, I think it would be useful to remember the current slide 
between restarts.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  Thanks, selecting from any image is useful, to avoid starting always from the 
top one. But should not enable the button until a check is done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  In D22121#492173 , @msdobrescu 
wrote:
  
  > I'd say it is some half-implemented feature, probably. Could it be useful 
to navigate by keyboard and check/uncheck images, by using space, for example?
  
  
  You can still navigate by Keyboard. But selecting an image will not enable 
the apply button anymore and then when clicked set the current image to the one 
selected. 
  I like your idea that you can uncheck/check when the whole delegate is 
selected.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  I'd say it is some half-implemented feature, probably. Could it be useful to 
navigate by keyboard and check/uncheck images, by using space, for example?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61318.
davidre added a comment.


  Don't start if we are in config mode
  
  I had another crash here via reload -> processPaths -> endInsertRows.
  Triggered by repeatetly checking and unchecking a checkbox. My guess is that 
because of multiple
  calls to reload and beginInsertRows, endInsertRows there were some 
inconsistencies. With this
  I can't crash it anymore by checking and unchecking a checkbox.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61314=61318

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22320: Hide "Dummy Output" from output list and improve user-visible labels

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, drosca, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We already show a "muted" icon and disallow adjusting the "Dummy Output" 
volume through mouse wheeling the icon and global shortcuts. This patch also 
hides it from the applet as effectively the user has "no output devices". Also, 
the user-visible label for output switching is changed to be more friendly.
  The KCM still shows the "Dummy Output" as it is a more advanced settings menu 
as it is.

TEST PLAN
  Disabling all outputs / unplugging the last output device
  OSD
  F6990067: Screenshot_20190708_110535.png 

  in applet
  F6990069: Screenshot_20190708_110509.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22320

AFFECTED FILES
  applet/contents/ui/main.qml

To: broulik, #plasma, #vdg, drosca, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61314.
davidre marked 2 inline comments as done.
davidre added a comment.


  Disable selecting the wallpaper in  slideshow configuration
  
  This was introduced when the gridview from the single image dialog was added 
to the 
  slideshow one. In my mind it makes no sense to have it, by clicking on a 
image the user
  doesn't change any visible setting and needlesly changes changes the state of 
the configuration
  dialog.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61116=61314

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

[Harald Sitter]

sitter added a comment.


  FTR: The async solid power API is not built by default as it is unfinished, 
it's also not API stable. I recently poked Alex Fiestas about it and he said 
that the parts of the new async API that actually were implemented when he 
handed over maintainer ship of solid were more or less done, there were some 
open concerns over the job class itself as supposedly that duplicates kjob a 
bit. I haven't had a closer look beyond that though.
  So, in order to port to the API, it'd first need finishing up really.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  In D22256#492127 , @davidre wrote:
  
  > I guess one drawback is that you have to reindex all the files when the 
sort mode is changed.
  
  
  I expect to simply reload the list, from the filesystem. That should be done 
when the folder list is changed too.
  But this should be done in your case too, the sorting proxy class needs a 
remap too, if I understand it correctly. Otherwise it would search in the list 
each time the next wallpaper is needed, right?
  Regardless the solution, I would expect to have the filesystem sorting 
methods too, for this implementation, generally speaking, yours or mine, 
meaning, be able to serve according to the file system hierarchy point of view 
too.
  For me it's not some contest, I just need to achieve something and I think 
your approach is more elegant, but needs more methods and I'd optimize it a 
bit, as I have commented already, because remapping the collection would be 
better to avoid the switch for each comparison somehow.
  Maybe using templates or lambdas, if possible?

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[David Redondo]

davidre added a comment.


  I guess one drawback is that you have to reindex all the files when the sort 
mode is changed.

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22283: Change validator for Endpoint Address entry field

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:12a7ea055197: Change validator for Endpoint Address entry 
field (authored by andersonbruce, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22283?vs=61189=61307

REVISION DETAIL
  https://phabricator.kde.org/D22283

AFFECTED FILES
  libs/editor/settings/wireguardpeerwidget.cpp

To: andersonbruce, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart