D24749: Fix build with older glibc: link there to librt for clock_gettime

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Only since glibc version 2.17 -lrt is no longer needed
  
  See same fix done for processui in bb556d8cea2fb77e66970ebc02303becd1c8e8e3 


REPOSITORY
  R111 KSysguard Library

BRANCH
  linkrt

REVISION DETAIL
  https://phabricator.kde.org/D24749

AFFECTED FILES
  processcore/CMakeLists.txt

To: kossebau, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  In D24732#549249 , @ngraham wrote:
  
  > Give the scrollview a frame and a white background or else apps look cut 
off and weird and there's a mysteriously hovering scroller: F7616694: 
Screenshot_20191017_111833.png 
  >
  > Also why are there duplicates in here?
  
  
  From the screenshot I can see you use the current version of the dialog. Make 
sure you installed it to the correct location, on my system (Fedora) it's 
installed to /usr/libexec/xdg-desktop-portal-kde.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D24744#549450 , @GB_2 wrote
  
  > Well, it'll be gone completely soon and the GTK theme comboboxes will be in 
the Application Style KCM.
  
  
  Where would gtk theme installation buttons go?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, crozbo, 
ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise we block containment actions on the left button
  
  BUG: 413104

TEST PLAN
  Click and held applet
  Set up action on left click, clicked

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24748

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol added a comment.


  Oh, I see what you mean, this text is entirely coming from KUserFeedback.
  Maybe it's something we can tackle there:
  
https://phabricator.kde.org/source/kuserfeedback/browse/master/src/provider/core/feedbackconfiguicontroller.cpp$187

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Björn Feber]

GB_2 added a comment.


  In D24744#549444 , @filipf wrote:
  
  > So much nicer, awesome work. +1 for the visuals of the rehauled kcm.
  
  
  Well, it'll be gone completely soon and the GTK theme comboboxes are going to 
be in the Application Style KCM.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, crozbo, 
ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D24744: Remove unneeded options in GTK KCM

[Filip Fila]

filipf added a comment.


  So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, crozbo, 
ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added a comment.


  In D24720#549292 , @ngraham wrote:
  
  > Nice, this feels indistinguishible from the current one, which is a good 
sign. I see what you mean about the Headings in RTL. Does the Kirigami version 
work properly? If so, I wonder if it might be worth it to just use that instead 
given that the future of PlasmaComponents is on shaky ground (T11558: kill 
plasma components in favour of QtQuickControls2 + kirigami 
)
  
  
  It was unfortunately all the same as with Plasma imports.
  
  By adding checks for orientation and using a spacer in the headings row 
layout I was able to get RTL working right though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf updated this revision to Diff 68201.
filipf added a comment.


  make all this work right with RTL layouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24720?vs=68182=68201

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24744: Remove unneeded options in GTK KCM

[Björn Feber]

GB_2 added a comment.


  Wow, it's so empty now! Great job!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22005: Ensure url from KActivity resources are properly built

[Méven Car]

meven updated this revision to Diff 68193.
meven added a comment.


  Avoid an unnecessary dereference

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22005?vs=68132=68193

BRANCH
  arcpatch-D22005

REVISION DETAIL
  https://phabricator.kde.org/D22005

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Nathaniel Graham]

ngraham added a comment.


  I don't know what to tell you; it's still broken for me. It looks like the 
first part of the URL isn't getting added onto the second, maybe.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  Abandoned in favor of D24743 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson, cfeck
Cc: cfeck, davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra, mart

D24543: Set an icon theme for gtk applications in the icons kcm

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  Abandoned in favor of D24743 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24543

To: gikari, ngraham, meven
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  Abandoned in favor of D24744 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24737: Correctly highlight the icon in the system tray

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:7ad4b59b7047: Correctly highlight the icon in the system 
tray (authored by kmaterka).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24737?vs=68147=68190

REVISION DETAIL
  https://phabricator.kde.org/D24737

AFFECTED FILES
  applets/keyboardindicator/contents/ui/main.qml

To: kmaterka, #plasma, davidedmundson, apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since font, icons, cursor theme, toolbar style, icons in menus and buttons 
settings are now in sync with corresponding plasma settings, they shouldn't be 
in GTK KCM anymore.

TEST PLAN
  Check if nothing breaks in GTK KCM functionality, that is left.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  gtk-kcm-remove-unneeded-options

REVISION DETAIL
  https://phabricator.kde.org/D24744

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/cursorthemesmodel.cpp
  src/cursorthemesmodel.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/iconthemesmodel.cpp
  src/iconthemesmodel.h
  src/installer.cpp
  src/installer.h
  src/thread.cpp
  src/ui/dialog_installer.ui
  src/ui/dialog_uninstaller.ui
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Yunhe Guo]

guoyunhe added a comment.


  In D24727#549327 , @ngraham wrote:
  
  > Still broken, I'm afraid. Among the console output is the following, which 
may be helpful:
  >
  >   kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
  >
  
  
  The url in my patch is `QStringLiteral("https://www.nesdis.noaa.gov;) + 
result.captured(1);`. So it must begin with `https://`.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Nathaniel Graham]

ngraham added a comment.


  Still broken, I'm afraid. Among the console output is the following, which 
may be helpful:
  
kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  To increase usability,
  
  - fonts
  - icon theme
  - cursor theme
  - toolbar style (icons-only, text below buttons etc)
  - icons visibility in menus
  - icons visibility on buttons
  
  settings for gtk applications are now set in respective kcms, instead of 
separate gtk kcm.
  
  Various kcms are sending signals (dbus or Qt ones) about the configuration 
change. Then the gtkconfig kded daemon connects to these signals and changes 
gtk config files to match new settings, that were set in those kcms.
  
  D24701  is needed to notify about cursor 
change on Wayland.
  
  Live reloading (on a fly) is not going to work for some settings on X11. This 
applies to cursor theme, it's changed by partially. To illustrate that open 
Nautilus File Manager, change cursor theme and try to double click folders. You 
will see, that "loading" cursor changed its theme, but "idle" one did not.
  
  What is not tested:
  
  - Toolbar style for gtk3 apps other that Geany (absence of live reloading may 
be a Geany bug)
  - Toolbar style and icons visibility on Wayland
  
  Depends on D24701 
  
  BUG: 401507
  BUG: 401507

TEST PLAN
  1. To test gtk3 applications live reloading on X11, install xsettingsd.
  2. Restart kded5.
  3. Open gtk2 app, gtk3 app
  4. Change above mentioned settings in respective KCMs
  5. Check if gtk applications are changing their settings before (sometimes) 
and after their restart.
  
  Rare cases:
  
  - To test icons on buttons use Inkscape about window.
  - To test toolbar style use Geany (gtk3, live reloading does not work) and 
BleachBit (gtk2)

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  The introductory "We make plasma for you..." text is still inappropriately 
shown in the explanatory text for the Disabled state rather than on 
top:F7617232: demo-2019-10-17_12.31.04.webm 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Yunhe Guo]

guoyunhe updated this revision to Diff 68185.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Change back to the original page URL

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68126=68185

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Yunhe Guo]

guoyunhe added a comment.


  In D24727#549199 , @ngraham wrote:
  
  > This doesn't fix the problem for me. :(
  
  
  Can you run `plasmashell --replace` in terminal and check the error output?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 68184.
apol added a comment.


  update the description with the applicationName change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24733?vs=68181=68184

BRANCH
  nokillswitch

REVISION DETAIL
  https://phabricator.kde.org/D24733

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:bbc88da3f93c: [Updates page] use fancier logic for 
handling elided Old+New version strings (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24713?vs=68180=68183

REVISION DETAIL
  https://phabricator.kde.org/D24713

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, broulik, #discover_software_store
Cc: mart, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Nathaniel Graham]

ngraham added a comment.


  Nice, this feels indistinguishible from the current one, which is a good 
sign. I see what you mean about the Headings in RTL. Does the Kirigami version 
work properly? If so, I wonder if it might be worth it to just use that instead 
given that the future of PlasmaComponents is on shaky ground (T11558: kill 
plasma components in favour of QtQuickControls2 + kirigami 
)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added a comment.


  Agreed, let's not change the padding.
  
  One issue that remains is that headings don't work well with RTL layouts but 
I can't quite figure out a solution yet.

INLINE COMMENTS

> ExpandedRepresentation.qml:55
>  } else if (activeApplet && hiddenItemsView.visible) {
> -return hiddenItemsView.iconColumnWidth + 
> units.largeSpacing;
> +return hiddenItemsView.width + separator.width + 
> units.smallSpacing / 2;
>  

maybe this could be somehow more precise

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  Yay, that update fixed the issue, phew!
  
  However the strings are still a little garbled: F7616876: 
Screenshot_20191017_115423.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf updated this revision to Diff 68182.
filipf added a comment.


  don't alter padding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24720?vs=68103=68182

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D22005: Ensure url from KActivity resources are properly built

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> backend.cpp:322
>  while (actionCount < 5 && resultIt != results.end()) {
> -const QString resource = (*resultIt).resource();
> +QString resource = (*resultIt).resource();
> +if (QDir::isAbsolutePath(resource)) {

`resultIt->resource()` (when you are at it :) )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 68181.
apol added a comment.


  Ehm...

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24733?vs=68153=68181

BRANCH
  nokillswitch

REVISION DETAIL
  https://phabricator.kde.org/D24733

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

[Nathaniel Graham]

ngraham updated this revision to Diff 68180.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fix binding loop

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24713?vs=68098=68180

BRANCH
  fancier-long-version-string-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24713

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, broulik, #discover_software_store
Cc: mart, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24719: Fix laptop screen being off when opening the lid

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:e47dc21a7b78: Fix laptop screen being off when opening 
the lid (authored by nicolasfella).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24719?vs=68110=68179

REVISION DETAIL
  https://phabricator.kde.org/D24719

AFFECTED FILES
  kded/config.cpp

To: nicolasfella, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> lesf0 wrote in main.qml:61
> That would make much more sence, but (at least for now) `QStringList` is 
> array-like object and not an actual `Array` instance, and I don't really feel 
> like I want to mess with all those "is-arrayish 
> " javascript stuff. Strings are 
> way easier to check.

That's odd, I thought a `QStringList` would just turn into a plain JS `Array` 
on QML side. Fair enough. Will land this for you tomorrow, thanks.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham added a comment.


  Give the scrollview a frame and a white background or else apps look cut off 
and weird and there's a mysteriously hovering scroller: F7616694: 
Screenshot_20191017_111833.png 
  
  Also why are there duplicates in here?
  
  Finally, I would consider adding the "Other applications are available in 
Discover" text to the bottom, so it doesn't interrupt the dialog's flow.

INLINE COMMENTS

> AppChooserDialog.qml:122
> +
> +MouseArea {
> +id: mouseArea

Change the cursor to the pointing hand cursor when hovering over something that 
will immediately perform an action when clicked

> AppChooserDialog.qml:140
> +
> +Label {
> +anchors {

Allow this label to become a multi-line string for apps that have long-ish 
names:
F7616689: Screenshot_20191017_111655.png 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> slidefiltermodel.cpp:51
> +if(sourceModel) {
> +connect(sourceModel, ::rowsInserted, this, 
> ::invalidate);
> +connect(sourceModel, ::rowsRemoved, this, 
> ::invalidate);

Good point. No need to invalidate in the other cases.

Maybe. It depends where images are added in the model? Maybe we would end up 
showing pictures again because the indexes have shifted? Or the new images are 
always shown at the end because they get appended? Either way I think that*'s 
not to bad if the order is set to Random. The result could also be the result 
of a random permutation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24723

To: davidre, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> AppChooserDialog.qml:47
> +horizontalAlignment: Text.AlignHCenter
> +text: i18n("Select application to open %1. Other applications 
> are available in Discover.", fileName)
> +textFormat: Text.RichText

"Select an application to open %1. More applications are available in Discover."

> AppChooserDialog.qml:85
> +icon.name: "view-more-symbolic"
> +text: i18n("Show more")
> +

"Show More"

> AppChooserDialog.qml:118
> +color: highlightColor
> +radius: 5
> +visible: ApplicationDesktopFile == defaultApp

We don't really use rounded rectangles for highlights anywhere (except in the 
Plasma theme).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  Use Dolphin from Flathub to open some file.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Kai Uwe Broulik]

broulik added a comment.


  I don't think the complaints are about the dots, it's a complaint that 
they're the only means of accessing disabled outputs (discount swiping), which 
is rectified by the combo box.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Denis Sheremet]

lesf0 added a comment.


  > Do you have commit access? If not, I need an E-Mail address so I can land 
this for you.
  
  I don't, you can add my email: me@lxlz.space
  
  > Bonus points if you also look at media controls in task manager (the ones 
when you hover a window): 
https://cgit.kde.org/plasma-desktop.git/tree/applets/taskmanager/package/contents/ui/ToolTipInstance.qml#n70
  >  and the lock screen 
https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MediaControls.qml#n73
 :)
  
  I can add the same path, but I don't really use those components so I'm not 
sure if I can test those properly.

INLINE COMMENTS

> broulik wrote in main.qml:61
> Perhaps this should be turned around to check `Array.isArray(xesamArtist)` 
> and in doubt have it cast to string?

That would make much more sence, but (at least for now) `QStringList` is 
array-like object and not an actual `Array` instance, and I don't really feel 
like I want to mess with all those "is-arrayish 
" javascript stuff. Strings are way 
easier to check.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> slidefiltermodel.cpp:51
> +if(sourceModel) {
> +connect(sourceModel, ::rowsInserted, this, 
> ::invalidate);
> +connect(sourceModel, ::rowsRemoved, this, 
> ::invalidate);

Perhaps only `invalidate` if order is actually set to random?

I am actually not sure we need to invalidate at all when inserting items, 
unless you want to shuffle every time that happens? Perhaps all we need to do 
is shrink/grow the random vector when new items are added?

> slidefiltermodel.cpp:121
> +{
> +m_randomOrder.resize(sourceModel()->rowCount());
> +std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0);

Can `sourceModel()` be null here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24723

To: davidre, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks for your patch!
  I am not sure if the property should be perhaps changed to a `property var` 
and always contain an `Array`. But that would mean changing the tooltip, full 
representation, among other things.
  I think this is fine.
  Do you have commit access? If not, I need an E-Mail address so I can land 
this for you

INLINE COMMENTS

> main.qml:61
> +
> +if (typeof xesamArtist == "string") {
> +return xesamArtist

Perhaps this should be turned around to check `Array.isArray(xesamArtist)` and 
in doubt have it cast to string?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:8339cba19e9a: [KWindowSystem] in icon() return realistic 
icon size (authored by meven).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24683?vs=68022=68166

REVISION DETAIL
  https://phabricator.kde.org/D24683

AFFECTED FILES
  src/windowsystem/windowsystem.cpp

To: meven, #kwin, davidedmundson, zzag
Cc: anthonyfieroni, mart, zzag, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24727: Fix NOAA picture of the day provider

[Nathaniel Graham]

ngraham added a comment.


  This doesn't fix the problem for me. :(

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24737: Correctly highlight the icon in the system tray

[David Edmundson]

davidedmundson added a comment.


  Interestingly the very original code was
  
  +active: parent.containsMouse || root.capsLock
  
  The rationale, I assume was because number lock takes precedent over caps 
lock in the icon, so this gives you a way of seeing when you have both. Albeit 
not a very intuitive one.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24737

To: kmaterka, #plasma, davidedmundson, apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Nathaniel Graham]

ngraham added a comment.


  Yeah I kind of think this should be a master-only re-think of Breeze's button 
focus indication in general rather than a targeted 5.17.1 patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  It already is: F7616320: Screenshot_20191017_101011.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol added a comment.


  In D24733#549186 , @ngraham wrote:
  
  > In D24733#549185 , @apol wrote:
  >
  > > It's changed in the last iteration of the patch. You probably enabled the 
kill switch on the present version of the kcm.
  >
  >
  > Yeah, I did. So now how do I turn it off?  Is there a CLI tool we can 
mention in the message, maybe?
  
  
  you need to change ~/.config/KDE/UserFeedback.conf to Enabled=true

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24721: Show backend name and version in app delegates

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I like the idea behind this but I'm not sure this is the right way to do it. 
Instead of changing the strings in the backend, we should add the new text 
(plus icons, preferably) on the UI side, in the QML files. See 
`discover/qml/ApplicationDelegate.qml`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24721

To: brunogoncalves, #discover_software_store, ngraham
Cc: plasma-devel, #discover_software_store, LeGast00n, The-Feren-OS-Dev, 
semareit, jraleigh, bam, fbampaloukas, GB_2, ragreen, ixoos, ZrenBot, James, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  In D24733#549185 , @apol wrote:
  
  > It's changed in the last iteration of the patch. You probably enabled the 
kill switch on the present version of the kcm.
  
  
  Yeah, I did. So now how do I turn it off?  Is there a CLI tool we can 
mention in the message, maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol added a comment.


  It's changed in the last iteration of the patch. You probably enabled the 
kill switch on the present version of the kcm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven marked 2 inline comments as done.
meven added a comment.


  Anyone to care to review and accept this small code change ?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24683

To: meven, #kwin, davidedmundson
Cc: anthonyfieroni, mart, zzag, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  Ok, now I see this: F7616194: Screenshot_20191017_095308.png 

  
  Is that caused by a change here, or did something truly change on my system 
in the last hour?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Denis Sheremet]

lesf0 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lesf0 requested review of this revision.

REVISION SUMMARY
  According to the spec, xesam:artist should be a string array, but 
  majority of players uses string instead. This patch adds support for 
  both string array and string options to allow new software development 
  according to the spec but also maintain compatibility with existing 
  solutions.
  BUG: 405762

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-applet-multiartist-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24740

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: lesf0
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham added a comment.


  What's the best way to test this out?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Nathaniel Graham]

ngraham added a comment.


  In D24720#549139 , @kmaterka wrote:
  
  > In D24720#549097 , @kmaterka 
wrote:
  >
  > > Pin button is no longer working,which is surprising :)
  >
  >
  > In fact it is working, but there is no background change. Old version had 
blue background when pinned.
  
  
  Make sure that you have plasma-framework from git master. That should fix it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24734: [KCM] remove the page indicator dots

[Nathaniel Graham]

ngraham added a comment.


  I guess we actually have three ways to switch the settings view:
  
  - Click on screen in the visualization (currently broken for some use cases)
  - Use the combobox
  - Click on one of the page indicator dots
  
  Of these three, I think the dots are by far the least user-friendly. They're 
tiny click targets, don't look like interactive UI elements, and are 
information-poor. In the days since Plasma 5.17's release, we've already gotten 
multiple complaints about the dots. If we need to remove any of these three 
methods of switching views later, my preference would be to remove the dots, 
not the combobox.
  
  #VDG  feedback may be useful here.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24738: Highlight the icon in the system tray on mouse over

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:532d4da7bfb5: Highlight the icon in the system tray on 
mouse over (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24738?vs=68150=68158

REVISION DETAIL
  https://phabricator.kde.org/D24738

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: kmaterka, #plasma, davidedmundson, #plasma_workspaces, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Aleix Pol Gonzalez]

apol added a comment.


  +1 looks much better

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Konrad Materka]

kmaterka added a comment.


  In D24720#549097 , @kmaterka wrote:
  
  > Pin button is no longer working,which is surprising :)
  
  
  In fact it is working, but there is no background change. Old version had 
blue background when pinned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24734: [KCM] remove the page indicator dots

[Roman Gilg]

romangg added a comment.


  I didn't change mine. And I have mentioned it multiple times before and 
explicitly in the review request to add the combobox: I see the combobox only 
as an intermediate solution. By that we have now two different ways of 
selecting outputs, one through the graphical view and one with the combobox 
instead of only one.
  
  Longterm the combobox should go away and all outputs disabled and enabled, 
replicas or not, should be selectable in some way through the graphical view. 
In this case the dots are valuable for giving an indication on how many outputs 
there are, which one is selected and you can switch through all of them one by 
one without searching them in the graphical view.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Nathaniel Graham]

ngraham added a comment.


  But Kai changed his mind after reading 
https://phabricator.kde.org/D24734#549029 :-)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Roman Gilg]

romangg added a comment.


  I agree with Kai that the dots should stay.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven marked 5 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in windowsystem.cpp:173
> That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you 
> got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2 
> = 64, so 128 + 64 = 192, when request is smaller than 192 and bigger than 96 
> (which is same calculated for previous values) it returns 128. If you want 
> write an algorithm for that.

Thank you @anthonyfieroni for the explanation
So in fact the comment stated already this simply:

> take the nearest value for best results

I don't think more comment is necessary.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24683

To: meven, #kwin, davidedmundson
Cc: anthonyfieroni, mart, zzag, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Nathaniel Graham]

ngraham added a comment.


  +1, let;s not change the paddings here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24691: Add support for WPA3

[Jan Grulich]

jgrulich updated this revision to Diff 68155.
jgrulich added a comment.


  Simplify code

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24691?vs=68036=68155

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24691

AFFECTED FILES
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h

To: jgrulich, #plasma
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Nathaniel Graham]

ngraham added a comment.


  D24735  just landed; can you and or 
@romangg approve this if you're okay with it?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Konrad Materka]

kmaterka added a comment.


  Pin button is no longer working,which is surprising :)
  
  About padding: I would vote for **not** changing padding nor margins, at 
least not in this change. It will be easier to review and test it you split 
this into two changes. This popup size is pretty small, if you add paddings or 
margins space left for applet is even smaller.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24733: feedback kcm: Make it about Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 68153.
apol marked an inline comment as done.
apol added a comment.


  Remove duplicated text, disable when the kill switch is on

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24733?vs=68135=68153

BRANCH
  nokillswitch

REVISION DETAIL
  https://phabricator.kde.org/D24733

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24715: Show a message indicating that no TB devices are connected when the list is empty

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1044:cf47147b3c2b: Show a message indicating that no TB 
devices are connected when the list is… (authored by ngraham).

REPOSITORY
  R1044 Plasma Thunderbolt Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24715?vs=68090=68152

REVISION DETAIL
  https://phabricator.kde.org/D24715

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceList.qml

To: ngraham, #vdg, #plasma, dvratil, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24738: Highlight the icon in the system tray on mouse over

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24738

To: kmaterka, #plasma, davidedmundson, #plasma_workspaces, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24738: Highlight the icon in the system tray on mouse over

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Icon should be highlighted hover, as any other icons in the system tray.
  
  CCBUG: 400295

TEST PLAN
  Hover mouse over icon over icon - it should highligh.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24738

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: kmaterka, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:2ab4c2f136c5: Gracefully replace outputModel (authored by 
broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24735?vs=68145=68149#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24735?vs=68145=68149

REVISION DETAIL
  https://phabricator.kde.org/D24735

AFFECTED FILES
  kcm/kcm.cpp

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Roman Gilg]

romangg added a comment.


  5.17

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  In D24735#549048 , @broulik wrote:
  
  > I call `release()` instead of `get()` so I reset the pointer to null so 
that when I signal `outputModelChanged` it returns `null` and QtQuick resets 
everything and only then I delete it.
  
  
  Ok, this comment explains why you do it this way. An important detail for 
understanding what's happening is the early return of 
`KCMKScreen::outputModel()`, where null is returned in case there is no 
`m_config`. Please reformulate the comment in the code so it's more easy to 
understand what's going on. Thanks for the fix!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24737: Correctly highlight the icon in the system tray

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Icon is highlighted when CapsLock or NumLock are locked. It should not
  be used this way, icon should be highlithed on mouse hover, as any other
  icon in system tray.
  
  CCBUG: 400295

TEST PLAN
  Hover mouse over icon over icon - highligh only when mouse is over the icon. 
It should not highlight when CapsLock or NumLock are used.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24737

AFFECTED FILES
  applets/keyboardindicator/contents/ui/main.qml

To: kmaterka, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik added a comment.


  I call `release()` instead of `get()` so I reset the pointer to null so that 
when I signal `outputModelChanged` it returns `null` and QtQuick resets 
everything and only then I delete it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik updated this revision to Diff 68145.
broulik added a comment.


  - Delete the old model

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24735?vs=68141=68145

REVISION DETAIL
  https://phabricator.kde.org/D24735

AFFECTED FILES
  kcm/kcm.cpp

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Nathaniel Graham]

ngraham added a comment.


  For me this fixes the crash when unplugging a screen with the KCM open, FWIW.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik added a comment.


  Oh I'm an idiot, I forgot to delete the model.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[David Edmundson]

davidedmundson added a comment.


  Urgh, so the order of events is:
  
  KCMKScreen::~KCMKScreen() <-- deletes the config and exposed properties
  KCModuleQML::~KCModuleQML() <-- tears down the UI, which now references 
dangling things.
  
  I think thats's a sign of a more generic that it would be good if we could 
solve, maybe an explicit method in KCModuleQML we could call from our 
destructor. It sounds similar to that language translation crash.
  
  For 5.17, change to .get() to address Roman's comment and then +1 from me.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik added a comment.


  > But just destroying and recreating is much simpler. ;)
  
  And causes crashes by leaving things on the QML side in an inconsistent state.
  
  Not sure `deleteLater` will help you since `GetConfigOperation()` could take 
longer than that. We could perhaps delete the old model when the config 
operation finishes, but that might get ugly. I'll give it a shot.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Roman Gilg]

romangg added a comment.


  But just destroying and recreating is much simpler. ;)
  
  Regarding the change: if we release without delete afterwards we leak memory. 
Maybe deleteLater?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Kai Uwe Broulik]

broulik added a comment.


  Alright, convinced. See D24735 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Nathaniel Graham]

ngraham added a comment.


  Ok.
  
  However once you deem the combobox perfectly reliably I would like to remove 
these. They're redundant; their function is to give you a clickable method to 
change a swipe view's pages, but you've added a combobox which already provides 
that. We don't need two such methods.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24735: Gracefully replace outputModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, romangg, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This patch has it signal the disappearance of the `outputModel` and only then 
deletes it.
  This gives the QML side of things a chance to clean up, specifically 
`QQuickComboBox` stores the model in a `QVariant` and crashes if you just 
delete its backing model.

TEST PLAN
  QQC2 ComboBox should probably be fixed to store it in a `QPointer` or 
something but this at least fixes the crash.
  Opened KScreen KCM, changed something, hit "Reset", no crash

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24735

AFFECTED FILES
  kcm/kcm.cpp

To: broulik, #plasma, romangg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  Is this better?
  
  F7615448: Screenshot_20191017_155608.png 


REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68140.
jgrulich added a comment.


  Add text to the button rather then using tooltip

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68137=68140

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  In D24732#548992 , @ognarb wrote:
  
  > I would add text on the button e.g "Show more", otherwise it's quite 
difficult to know how to show more apps
  
  
  There is a tooltip, but maybe showing text next to it might be better.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Kai Uwe Broulik]

broulik added a comment.


  I would prefer they stay in. It's a swiping sliding view, they do no harm.
  Also I'm having trouble with the `ComboBox` right now, please hold this for 
now.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24734

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Carl Schwan]

ognarb added a comment.


  I would add text on the button e.g "Show more", otherwise it's quite 
difficult to know how to show more apps

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24734: [KCM] remove the page indicator dots

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: romangg, broulik, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now that D24687  has landed, settings 
pages are switched between using the combobox,
  making the page indicator dots redundant. We can remove them to save some 
space and
  improve the appearance a bit.
  
  5.17

TEST PLAN
  F7615386: No more dots.png 

REPOSITORY
  R104 KScreen

BRANCH
  no-more-dots (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24734

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml

To: ngraham, romangg, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  This is the initial state of the dialog, which presents only apps associated 
with given mimetype. Then if you click at the button below, it will show all 
the apps and provide a search bar.
  F7615342: Screenshot_20191017_154506.png 


REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24688: [KCM] Disallow dropping screen outside of reachable area

[Nathaniel Graham]

ngraham added a comment.


  +1 for auto-zoom and making the screens bigger. Then we can remove the 
buttons that centers the view too.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24719: Fix laptop screen being off when opening the lid

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  
  
  5.17

REPOSITORY
  R104 KScreen

BRANCH
  fixit

REVISION DETAIL
  https://phabricator.kde.org/D24719

To: nicolasfella, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68137.
jgrulich added a comment.


  Do not duplicate desktop files

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68134=68137

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[Nathaniel Graham]

ngraham added a comment.


  Indeed, this is much nicer.
  
  The explanatory text for "Disabled" appears to duplicate some of the text 
above it though: F7615296: Screenshot_20191017_074048.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24733: feedback kcm: Make it about Plasma

[David Edmundson]

davidedmundson added a comment.


  +++

INLINE COMMENTS

> feedback.h:31
>  
> -Q_PROPERTY(bool feedbackEnabled READ feedbackEnabled WRITE 
> setFeedbackEnabled NOTIFY feedbackEnabledChanged)
>  Q_PROPERTY(int plasmaFeedbackLevel READ plasmaFeedbackLevel WRITE 
> setPlasmaFeedbackLevel NOTIFY plasmaFeedbackLevelChanged)

Should we keep this readonly and grey out the whole UI if unset?

Or better yet, is it possible to disable the entire KCM through some .desktop 
file trick?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24733

To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24687: [KCM] Add output selector ComboBox

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:7811411c6425: [KCM] Add output selector ComboBox 
(authored by broulik).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24687?vs=68024=68136

REVISION DETAIL
  https://phabricator.kde.org/D24687

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra