D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77334.
cblack marked 10 inline comments as done.
cblack added a comment.


  Address feedback and compiler warnings

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77333=77334

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:367
> Just for my understanding: why is it necessary ? 
> Here at least, nothing changes if I take this out.

This causes Qt to request a background be drawn on these widgets, which is used 
for painting the border when there would normally be no widgets to paint on. 
Check systemsettings5 and spectacle.

> hpereiradacosta wrote in breezetoolsareamanager.cpp:108
> That's still needs fixing though. You cannot have things floating around 
> depending on which color scheme is used. right ? 
> There are many color schemes of all types in the wild. The widget style must 
> work for all.

This is intentional—if a window's titlebar and content colours are the same, 
the window is drawn as a homogeneous window instead of a window with a tools 
area.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Some more comments, mostly code related. 
  Thanks for addressing all the comments so far !

INLINE COMMENTS

> breezehelper.cpp:33
> +#include 
> +#include 
>  

This include is not needed any more as far as  I can tell

> breezehelper.cpp:1723
> +
> +painter->setPen(QPen(toolsAreaBorderColor(widget), 1));
> +painter->setRenderHints(QPainter::Antialiasing, false);

remove the unnecessary QPen

> breezestyle.cpp:59
>  #include 
> +#include 
>  #include 

Not needed

> breezestyle.cpp:174
>  , _tabBarData( new BreezePrivate::TabBarData( this ) )
> +, _toolsAreaManager ( new ToolsAreaManager( this, _helper ) )
>  #if BREEZE_HAVE_KSTYLE

Compiler complains about variable being initialized in incorrect order. Member 
initialization must be in the same order as the declaration. (here toolsarea 
befor tabbardata)
In general try compile with a recent gcc (I have gcc 9.2.1) and fix all 
warnings.

> breezestyle.cpp:367
> +} else if ( qobject_cast (widget) || 
> qobject_cast (widget) ) {
> +widget->setAttribute(Qt::WA_StyledBackground);
>  }

Just for my understanding: why is it necessary ? 
Here at least, nothing changes if I take this out.

> breezestyle.cpp:879
>  
> +bool Style::drawWidgetPrimitive( const QStyleOption* option, QPainter* 
> painter, const QWidget* widget ) const {
> +if (qobject_cast(widget) || qobject_cast QDialog*> (widget)) {

"option" is unused (and compiler complains about it)
Either add Q_UNUSED(option) just put "QStyleOption*," (anonymous variable)

> breezestyle.cpp:882
> +if (!_helper->toolsAreaHasContents(widget) && 
> _helper->shouldDrawToolsArea(widget)) {
> +painter->setPen(QPen(_helper->toolsAreaBorderColor(widget), 
> 1));
> +painter->setRenderHints(QPainter::Antialiasing, false);

Just "setPen( _helper-> ...) 
you don't need the temporary QPen if it has a width 1.

> cblack wrote in breezetoolsareamanager.cpp:108
> I believe this is due to how it determines "should draw tools area" 
> conflicting with your colourscheme.
> When active, the window and the titlebar colours are different, thus causing 
> the tools are to be drawn. When inactive, the window and the titlebar colours 
> are the same, causing the tools area to not be drawn.

That's still needs fixing though. You cannot have things floating around 
depending on which color scheme is used. right ? 
There are many color schemes of all types in the wild. The widget style must 
work for all.

> breezetoolsareamanager.h:9
> +namespace Breeze {
> +typedef struct ToolsAreaAnimation {
> +QPointer foregroundColorAnimation;

Please remove the typedef. Not needed

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  The toolbar background seems to be broken when there are multiple toolbars in 
the same row.
  See, e.g. ktorrent:
  F8168244: Screenshot_20200309_213717.png 

  Does not happen for applications that have a single toolbar (most 
applications these days)
  Or multiple toolbars but one per row.
  Also happens with kdevelop, or konqueror.
  Then also there are problems with colors (for all color schemes that have 
strong contrast between window decoration and window). But should be discussed 
once the above is fixed.

INLINE COMMENTS

> breezestyle.h:505
> +//* signal manager for the tools area
> +ToolsAreaManager* _toolsAreaManager;
> +

Should initialize there to null ptr (like the other members). This ensures that 
you don't have a dangling pointer if for some reason someone deletes the 
initialization with new in the styles constructor.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77333.
cblack added a comment.


  Draw border on QDialogs

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77332=77333

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77332.
cblack added a comment.


  Render consistent tools area border colour

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77326=77332

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  This is looking pretty polished. There are just a few visual issues left:
  
  #1:  The titlebar and toolbar/menubar change color at slightly different 
rates, rather than all together. I guess the titlebar should animate its 
transition too: F8168180: vokoscreenNG-2020-03-09_19-54-25.webm 

  
  #2: The line drawn under the tools area isn't consistent. When there's a 
toolbar or a menubar, it's one color: F8168181: Screenshot_20200309_195545.png 

  ...When there's just a titlebar, sometimes it's this color: F8168182: 
Screenshot_20200309_195625.png 
  ... While other times it's missing: F8168183: Screenshot_20200309_195713.png 
 F8168184: Screenshot_20200309_195800.png 

  
  Really great work though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Fascinating. I've been testing different color schemes to find one that I 
like best and the current one happens to have the same color for the window bg 
and inactive toolbar bg, yes. Fixed, now, thanks!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77326.
cblack added a comment.


  Always compare active titlebar against active window for determining if tools 
area should be drawn

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77316=77326

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> cblack wrote in breezetoolsareamanager.cpp:108
> That's odd—the margin shouldn't be shifting based off of window status. Will 
> investigate.

I believe this is due to how it determines "should draw tools area" conflicting 
with your colourscheme.
When active, the window and the titlebar colours are different, thus causing 
the tools are to be drawn. When inactive, the window and the titlebar colours 
are the same, causing the tools area to not be drawn.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in breezetoolsareamanager.cpp:108
> F8168127: vokoscreenNG-2020-03-09_18-36-02.webm 
> 

That's odd—the margin shouldn't be shifting based off of window status. Will 
investigate.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in breezetoolsareamanager.cpp:108
> All of them with anything besides a titlebar in their Tools area: Dolphin, 
> Gwenview, Okular, Kate, Konsole...

F8168127: vokoscreenNG-2020-03-09_18-36-02.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Don't land before D27913 .

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27345: Don't emit palette changes if the palette didn't change

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cad71c6f968f: Dont emit palette changes if the 
palette didnt change (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27345?vs=77324=77325

REVISION DETAIL
  https://phabricator.kde.org/D27345

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27345: Don't emit palette changes if the palette didn't change

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77324.
apol added a comment.


  Simplify the process

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27345?vs=76036=77324

BRANCH
  arcpatch-D27345_1

REVISION DETAIL
  https://phabricator.kde.org/D27345

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> cblack wrote in breezetoolsareamanager.cpp:108
> Eh? What application do you see this behaviour in?

All of them with anything besides a titlebar in their Tools area: Dolphin, 
Gwenview, Okular, Kate, Konsole...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27960: Make it possible to scroll through the padding

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Forwards wheel events happening on the padding to the WheelHandler that 
manages
  the Flickable.
  
  BUG: 418624

TEST PLAN
  See test included, also on Discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27960

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml
  src/wheelhandler.cpp
  src/wheelhandler.h
  tests/ScrollPaddingScrollable.qml

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D27808#625052 , @meven wrote:
  
  > Porting with such feature regression is hard to justify.
  
  
  I honestly don't know how many users actually use that feature; if it's still 
widely used, then yeah, that would definitely be a feature regression.
  
  > Perhaps we should port KFontDialog (it is ~150 lines of cpp) to 
kwidgetsaddons instead, `KFontChooser` is already there.
  >  Or better perhaps implement here a simple QDialog embedding `KFontChooser` 
and providing equivalent features needed here that KFontDialog has.
  >  This is a typical work we did for KF5 
https://community.kde.org/Frameworks/Porting_Notes
  
  Since, AFAICS, only the fonts KCM uses that functionality, it might be better 
to move/copy KFontDialog to the KCM, and maybe rename it; it'd be a helper 
class of sorts.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir planned changes to this revision.
ahmadsamir added a comment.


  It seems I messed up the branches stuff (or phabricator works in a way I 
don't understand), so I think it's best to work at one diff at a time, instead 
of wasting time trying to make sense of this situation :/ (I will address 
all comments regardless).
  
  It all starts with D27785 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack added a comment.


  In D27959#625053 , @broulik wrote:
  
  > Can we make the dbus service role name more generic? GTK has a generic DBus 
prop on the window, too.
  
  
  Both the `org.gtk.Actions` and the `org.gtk.Menus` dbus interfaces exposed by 
GIO's GApplication class are primarily used for application menus.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack added a comment.


  In D27959#625055 , @broulik wrote:
  
  > For X check out the appmenu applet: 
https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164
  >
  > I was wondering if we should maybe add that to `NETWM` or `KWindowInfo` 
instead of doing lowlevel X calls in libTM, which I don't think it does at this 
point
  
  
  I suppose you missed the FIXME comment where I literally say to check that 
file out?
  
  But yeah, the low level X calls are pretty ugly and the reason why I left it 
a FIXME.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added a comment.


  For X check out the appmenu applet: 
https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added a comment.


  Can we make the dbus service role name more generic? GTK has a generic DBus 
prop on the window, too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Méven Car]

meven added a comment.


  Porting with such feature regression is hard to justify.
  
  Perhaps we should port KFontDialog (it is ~150 lines of cpp) to 
kwidgetsaddons instead, `KFontChooser` is already there.
  Or better perhaps implement here a simple QDialog embedding `KFontChooser` 
and providing equivalent features needed here that KFontDialog has.
  This is a typical work we did for KF5 
https://community.kde.org/Frameworks/Porting_Notes

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The tasks model now exposes a window's application menu object path and 
service name.
  Model only implemented for Wayland; as I don't have a clue what to do on XOrg.

TEST PLAN
  See that the model has more roles and see that they're wired to the 
application
  menu obiect path and service name on Wayland.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> fonts.cpp:678
>  
> -QFont KFonts::applyFontDiff(const QFont , const QFont , int 
> fontDiffFlags)
> -{
> -QFont font(fnt);
> -
> -if (fontDiffFlags & KFontChooser::FontDiffSize) {
> -font.setPointSizeF(newFont.pointSizeF());
> -}
> -if ((fontDiffFlags & KFontChooser::FontDiffFamily)) {
> -font.setFamily(newFont.family());
> -}
> -if (fontDiffFlags & KFontChooser::FontDiffStyle) {
> -font.setWeight(newFont.weight());
> -font.setStyle(newFont.style());
> -font.setUnderline(newFont.underline());
> -font.setStyleName(newFont.styleName());
> +// Try to find a fixed-width/monspace font from the font family the 
> user selected, e.g.:
> +// "Noto Sans" -> "Noto Sans Mono", "Ubuntu" -> "Ubuntu Mono"

s/monspace/monospace

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  Fix for narrow panel in D27958 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka added a comment.


  I don't like how icon size and item size (container = icon + padding) are 
calculated and used... Firstly best icons size is calculated, but then padding 
are added. This combined size is used as item size (container size):
  
  - SNI icons are rounded to nearest icon size (implicitly, because  
PlasmaCore.IconItem is used)
  - Plasmoids are scaled to the size of the container, I don't know exactly how 
it work, probably because default compact representation is just an icon.
  
  By happy coincident it is (?) working correctly for all sizes.
  
  There is also a lot of anchoring involved, all items are aligned to left 
(which looks bad with expander arrow, gap is bigger) etc. But all of this can 
be fixed in separate patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in breezetoolsareamanager.cpp:108
> This seems to make the window content move vertically when the window loses 
> focus

Eh? What application do you see this behaviour in?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  For very narrow panel item size is too big (item + paddings exceed panel 
size). This adds a check to not exceed poanel size.

TEST PLAN
  - Make panel very narrow - icons should fit into panel
  - Repeat for vertical/horizontal

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27958

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.cpp:108
> +} else {
> +window->setContentsMargins(0,1,0,0);
> +}

This seems to make the window content move vertically when the window loses 
focus

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.cpp:102
> +{
> +if (QApplication::desktopFileName() == 
> QStringLiteral("telegram-desktop.desktop")) return;
> +auto window = qobject_cast (widget);

This needs at least a comment why we have this hack for telegram

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77320.
gikari added a comment.


  - Add forgotten toolbar style

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27957?vs=77317=77320

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: [GTK Config] Remove redundant reparse configuration call

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  In favor of D27957 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Also remove redundant reparse configuration calls and change
  the ways of reading some settings accordingly.
  
  Depend on: D27956 

TEST PLAN
  1. Apply D27956 
  2. Restart kded5
  3. Apply all the settings possible:
- Fonts
- Icons
- Color Scheme (for dark theme preference setting)
- Icons on buttons
- Icons in menus
- Toolbar style
- Scrollbar behaviour (what happens if you click on scrollbar)
- Animations speed (though I haven't touch it in this diff)
- Decorations button order
  4. Check if all the settings are correctly applied to GTK applications

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77316.
cblack added a comment.


  Remove chunk that wasn't staged

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77315=77316

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77315.
cblack added a comment.


  Remove extraneous comma

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77314=77315

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77314.
cblack added a comment.


  Address more feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77312=77314

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27956: [Various KCMs] Notify about changes in GTK related settings

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Also save colors before saving colorScheme name, so that we can
  correctly use heuristic in GTK Config, after the moment we know, that
  color scheme has changed.

TEST PLAN
  Check if the order of saving colors and saving color scheme name does not 
break anything.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-about-changes-in-gtk-related-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27956

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colorssettings.kcfgc
  kcms/fonts/fontssettings.kcfgc
  kcms/icons/iconssettingsbase.kcfgc
  kcms/style/stylesettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77312.
cblack added a comment.


  Address some feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77057=77312

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

[David Edmundson]

davidedmundson added a comment.


  Please see D27724 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

To: crossi, #plasma, ervin, bport, meven, broulik
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo added a comment.


  Generally FormLayout is unfit for this, If I understand it correctly they 
cannot get `theme.smallestFont` height. Which will introduce big height, and 
big margins between lines.
  
  > IIRC the labels were reduced opacity before, and this was not a change 
introduced with the 5.19 visual refresh.
  
  I'm not sure what you reffering to.
  What I meant before, was the update of network manager for 5.19.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[Nathaniel Graham]

ngraham added a subscriber: manueljlin.
ngraham added a comment.


  FormLayouts are used all over the place. But typically, we don't reduce the 
opacity of the labels. I'm not categorically against it, I'm just wondering. 
IIRC the labels were reduced opacity before, and this was not a change 
introduced with the 5.19 visual refresh.
  
  @manueljlin and other #VDG  people, 
what do you think?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo added a comment.


  > Do we need to reduce the opacity for the labels?
  
  Is this a visual design argument or a coding one? The opacity was reduced in 
the layout update. Are you saying that should not had be changed.
  IMO this is vital part of the new layout.
  
  > We don't really do this anywhere else.
  
  I don't get this argument. This kind of layout is not used anywhere else too. 
Should it be reverted back, too?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  no prob, take your time...

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b7291760dce1: Use consistent highlight (authored by 
niccolove).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77254=77310

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt added a comment.


  Okay. I just tested with other themes. 
  Was so used to Materia that I forgot about them.
  Yeah an option would make sense then. 
  I'd like to look into this but that will probably take some time.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27954: appstreamrunner: Port to KApplicationTrader

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Port away from the query language to lambda using the new KApplicationTrader 
API.
  
  Depends on D27953 .

TEST PLAN
  Tested by hand with several applications, still works as expected.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27954

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: apol, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Looks sexy as hell. I think the icon inside the notification needs to be 
moved or resized though. Right now it has no top padding, so it touches the 
header.

INLINE COMMENTS

> NotificationItem.qml:114
>  
> -NotificationHeader {
> -id: notificationHeading
> -Layout.fillWidth: true
> +PlasmaComponents.TopArea{
> +bottomInset: Math.round(thumbnailTopPadding / 2)

needs to be `PlasmaExtras.PlasmoidHeading` now, since it was renamed and moved 
to `PlasmaExtras`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port cursor theme sync to KConfigWatcher

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:715e497d94b9: [Gtk Config] Port cursor theme sync to 
KConfigWatcher (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27943?vs=77293=77304

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27942: [Cursors KCM] Notify about cursor change

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1fb3c36496cf: [Cursors KCM] Notify about cursor change 
(authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27942?vs=77275=77303

REVISION DETAIL
  https://phabricator.kde.org/D27942

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc

To: gikari, #plasma, ngraham, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  The gap you see comes from the specific plasma theme, so this is plasma theme 
responsibility. That specific theme probably has that gap in its tasks svg.
  
  Having an option means that the user can always disable/enable that specific 
functionality if a plasma theme breaks the experience.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt added a comment.


  In D27939#624440 , @mvourlakos 
wrote:
  
  > I think it is better to have an option for this in order to not be applied 
always when the user reverses the indicator..
  >
  > And also are you sure that this way the growing circle animation of the 
indicator is still working correctly?
  
  
  I am not sure if an option makes sense here as the group triangle looks kind 
of broken when reversed
  F8167640: 2020-03-09_17-24.png 
  
  Circle animation still works
  F8167643: circle.flv 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77293.
gikari marked an inline comment as done.
gikari added a comment.


  Update function name

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27943?vs=77276=77293

BRANCH
  cursors-to-config-watcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> ngraham wrote in gtkconfig.h:89
> `onKcmInputSettingsChange` (capitalize the I in Input)
> 
> Maybe also capitalize KCM?
> 
> Or maybe call it `onCursorSettingsChange`

This name comes from configuration file name and this function (theoretically) 
triggers on every change of the config, not necessary on cursor theme change, 
so I think that naming it `onCursorSettingsChange` is not very fair.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27943

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> gtkconfig.h:89
>  void onKWinSettingsChange(const KConfigGroup , const 
> QByteArrayList ) const;
> +void onKcminputSettingsChange(const KConfigGroup , const 
> QByteArrayList ) const;
>  

`onKcmInputSettingsChange` (capitalize the I in Input)

Maybe also capitalize KCM?

Or maybe call it `onCursorSettingsChange`

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27943

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Thanks, everything works now. :)
  
  I don't see that extra line in mine. But yeah, if it's reproducible, it's a 
bug that should be fixed.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I have to agree with Hugo and David. "Styles within styles" screams "this 
should just be another window decoration theme" to me as well. Especially since 
the proposed new window decoration button appearance is not even the default 
setting, it should be a 3rd-party addon, probably an Aurorae window decoration 
theme that can be downloaded from GHNS.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis, ngraham
Cc: davidre, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D27711: [Applet]Use gridLayout for details

[Nathaniel Graham]

ngraham added a comment.


  Do we need to reduce the opacity for the labels? We don't really do this 
anywhere else.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  In D27466#624639 , @kmaterka wrote:
  
  > I guess it needs to be reworked... I can do that, just need few days for 
investigation.
  
  
  Thanks, much appreciated!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27944: KCM Colors fix apply button always disabled

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG: 418604

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27944

AFFECTED FILES
  kcms/colors/colors.cpp

To: crossi, #plasma, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  This will utterly break with every third party theme.
  If we were to do this we would need to introduce a dedicated "applet is open" 
highlight item or some property to tell it to use tasks for that purpose.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham, ndavis, broulik
Cc: broulik, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  Actually, after some use, I don't think this is the best effect to use. I 
will investigate more.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Port from deprecated dbus signal to KConfigWatcher.
  
  Depends on: D27942 

TEST PLAN
  1. Apply D27942 
  2. Restart kded5
  3. Apply any cursor theme from KCM
  4. Check if GTK applications heve the changed cursor

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  cursors-to-config-watcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27942: [Cursors KCM] Notify about cursor change

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Notify all users of `KConfigWatcher` about cursor theme change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-about-cursor-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27942

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  In D27466#624574 , @broulik wrote:
  
  > > I believe that D26992 , moves the 
icons down.
  >
  > It looks like with that patch the icon sizes differ between plasmoids and 
SNIs
  
  
  That was my work, definitely that should not be the outcome. :) I will check 
it.
  
  The main problem here is that itemSize (regardless if it is plasmoid or SNI) 
is calculated in a very complicated and tricky way. If I remember correctly, 
firstly icon size is calculated, then margin is added but it is not a real 
margin - simply SNI icons are rounded to closes icon size and then by happy 
coincident we get margin. I guess it needs to be reworked... I can do that, 
just need few days for investigation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28337b6d379: KCM Fonts port anti aliasing part to 
KPropertySkeletonItem (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75890=77274

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77268.
ahmadsamir retitled this revision from "[Fonts KCM] Change how 
nearestExistingFonts() finds a matching font" to "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a subscriber: bport.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77265=77268

BRANCH
  arcpatch-D27808 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 77267.
bport added a comment.


  fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=76516=77267

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77265.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77264=77265

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77264.
ahmadsamir marked 3 inline comments as done.
ahmadsamir retitled this revision from "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] 
Change how nearestExistingFonts() finds a matching font".
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77258=77264

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  > I believe that D26992 , moves the icons 
down.
  
  It looks like with that patch the icon sizes differ between plasmoids and SNIs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[George Vogiatzis]

gvgeo added a comment.


  I believe that D26992 , moves the icons 
down. And this patch, by adding an extra smallSpacing/2 makes it more 
noticeable.
  
  Baking magic numbers is always questionable. Either the 1 smallspacing 
before, or the current 3/2, or 2 for tablet. IMO icons size should never be 
bigger than available space.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Monday meeting notes for 9/3/2020

[Marco Martin]

Kai Uwe:
* not much from me, been on vacation last week. other than
* PSA: Plasma Sprint in Augsburg next month has been cancelled
(delayed due covid precautions)

Arjen:
* So I started last week by making my own implementation of a
screenshot capture tool:
Diff 27805 Add a screenshot capture item and use it to test
rendering" [Needs Review] https://phabricator.kde.org/D27805
* It works quite well for checking if nothing changed rendering wise,
there's some bits that need addressing, mainly how to share this thing
between projects
* but I'd at least consider this a useful proof of concept
* After that, we've started doing some more upstreaming work on
internal ksysguard stuff
* I'm working on library parts, for which
https://phabricator.kde.org/D27869 is a first step
Diff 27869 "Separate processcore/{formatter,unit} into its own
library" [Needs Review] https://phabricator.kde.org/D27869

Bhushan:
* Okay, so one single item from me,
https://www.plasma-mobile.org/2020/03/09/Plasma-Mobile-Sprint-2020.html
* I have some more mobile stuff, but partly not relevent to this meeting

Marco:
# Plasma
* Api in the kiconff model to display recent documents to show hide
apps and documents at runtime D27782
* landed D27628
# Kirigami
* started a refactor of OverlaySheet

D27166: Refactor converter runner

[Harald Sitter]

sitter added a comment.


  Neat. I am Mostly just waiting for a test at this point.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27096: Refactoring, improve validation in kcm, optimize

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM. Does anyone have final comments?

REPOSITORY
  R114 Plasma Addons

BRANCH
  charrunner_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27096

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: davidre, dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> meven wrote in autostart.cpp:87
> The current default size was not very appropriate.
> I took the liberty of changing this as well.
> Before:
>  F8133214: Screenshot_20200226_140516.png 
> 

I reversed this change : the default size is ok for a couple of entries in the 
kcm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven updated this revision to Diff 77261.
meven added a comment.


  Reversed resizing the window

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=76470=77261

BRANCH
  arcpatch-D26934

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Ahmad Samir]

ahmadsamir marked 3 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> bport wrote in fonts.cpp:115
> You can use && to have only one if there

OK.

> bport wrote in fonts.cpp:552
> Those change will compare font twice, here and on setters so I will keep old 
> code there

Indeed; looking at the code generated by kconfig compiler in 
/kcms/fonts/fontsettings.h:

  /**
Set General font
  */
  void setFont( const QFont & v )
  {
if (v != mFont && !isFontImmutable()) {
  mFont = v;
  Q_EMIT fontChanged();
}
  }

I will revert. And another point is that the code in fonts.cpp doesn't need to 
check for immutability since it's checked by the setters.

> bport wrote in fonts.cpp:576
> I will keep that until we have a proper tested fix for 
> https://phabricator.kde.org/D27452
> can prevent bug and ensure apply button is on the good state on all case

OK, fair point, I will revert that bit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  In D27466#624447 , @broulik wrote:
  
  > This causes layouting issues in narrow panels:
  >  F8167100: Screenshot_20200309_085328.PNG 

  >  The icons are also too far apart
  
  
  For small icons this does not look nice. BaseSize is increased by the same 
`units.smallSpacing /2` regardless of the icon size, which is a great 
proportion for small icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77258.
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a reviewer: bport.
ahmadsamir added a comment.


  More detailed commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=76868=77258

BRANCH
  l-qfontdlg-track-nearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D27808#624506 , @bport wrote:
  
  > With your change, we are not allowed anymore to change for example only 
font and keeping different size, style for each kind of font (window, menu, 
toolbar...), right ?
  
  
  IIUC, that is a feature of KFontDialog (from KDELibs4Support), not available 
in QFontDialog.
  
  I probably should mention that in the commit message.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fonts.cpp:115
> +if (!sameFont) {
> +if (font.weight() == QFont::Normal && font.styleName().isEmpty()
> +&& result.weight() == QFont::Normal

You can use && to have only one if there

> fonts.cpp:552
>  {
> -m_settings->setFont(nearestExistingFont(m_settings->font()));
> -m_settings->setFixed(nearestExistingFont(m_settings->fixed()));

Those change will compare font twice, here and on setters so I will keep old 
code there

> fonts.cpp:576
> -// KCM expect save state to be false at this point (can be true because 
> of setNearestExistingFonts
> -setNeedsSave(false);
>  }

I will keep that until we have a proper tested fix for 
https://phabricator.kde.org/D27452
can prevent bug and ensure apply button is on the good state on all case

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Benjamin Port]

bport added a comment.


  With your change, we are not allowed anymore to change for example only font 
and keeping different size, style for each kind of font (window, menu, 
toolbar...), right ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Sorry, I had different files with different versions. Now it shows correctly 
for me, with all files up to date. That said, is it normal that:
  F8167163: image.png 
  
  - the top elements has a top separator
  - icon size of the second element is smaller
  
  ? seems wrong to me, but not because of this patch

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77254.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77253=77254

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77253.
niccolove added a comment.


  fixed name of list

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77219=77253

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[David Redondo]

davidre added a comment.


  I want to echo the sentiment that Breeze should not gain more options and 
this instead be a new decoration. I see the issue with mdi windows having 
different titlebars because they are drawn by the QStyle but you add these 
options here you are only solving this problem for this particular instance if 
Breeze decorations and Breeze style is selected. This is no difference as 
before, there are many popular decorations and we can't add an option for every 
one of them so that the decorations are consistent.
  
  This is a fundamental limitation because mdi decorations are drawn by the 
QStyle. Maybe this is a problem to be solved somewhere else like in Qt. In 
Wayland there is a protocol t ask the server decorations so Qt could use that 
if available and only than fallback to the style. Or maybe we could do 
something in KStyle.
  
  > With regards to why not a separate theme, that was actually my original 
plan, but I wanted to use Breeze as the base. When I asked 3 years ago if there 
was an Aurorae theme for Breeze that I could edit I was told there was not and 
that it was just C++; is this still the case today? Can the Breeze theme be 
easily forked and redistributed in the GetHotNewStuff dialogue box? If so, how, 
and where to share? I also wanted to change the Application Style as well as 
the Window Decorations (i.e. the style of buttons to dock/undock and close etc. 
within applications with dockable panes). Can you easily fork, redistribute and 
download new Application Styles in the GetHotNewStuff dialogue box as well?
  
  If your goal is to have breeze with different button style I think sadly not. 
I am not that knowledgable what is possible or not with ghns but I think right 
now it is limited to aurorae. But you could always make a simple auorae theme 
that looks like breeze (I don't know how hard that is). But there are also 
popular 3rdparty decorations that are not distributed though GHNS. I keep 
seeing for example https://github.com/kupiqu/SierraBreezeEnhanced being a 
popular theme that is a fork of breeze from looking at the code.
  
  Sadly there is also no GHNS for QStyles as it suffers from the same problem 
that as far as I understand it doesn't support stuff that needs to be compiled 
and binary compatible to the users system.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: davidre, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D27886: Demote jump list actions to PossibleMatches

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:18422ededcc9: Demote jump list actions to PossibleMatches 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27886?vs=77079=77247

REVISION DETAIL
  https://phabricator.kde.org/D27886

AFFECTED FILES
  runners/services/servicerunner.cpp

To: broulik, #plasma, davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:503bf4f3a542: [gmenu-dbusmenu-proxy] Pass action 
target in invocation (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27884?vs=77073=77249

REVISION DETAIL
  https://phabricator.kde.org/D27884

AFFECTED FILES
  gmenu-dbusmenu-proxy/actions.cpp
  gmenu-dbusmenu-proxy/actions.h
  gmenu-dbusmenu-proxy/window.cpp
  gmenu-dbusmenu-proxy/window.h

To: broulik, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27879: Degrade qCInfo to qCDebug

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9a4f259c4820: Degrade qCInfo to qCDebug (authored by 
broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27879?vs=77063=77248

REVISION DETAIL
  https://phabricator.kde.org/D27879

AFFECTED FILES
  gmenu-dbusmenu-proxy/menuproxy.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea358c896668: [gmenu-dbusmenu-proxy] Fix radio button 
state detection (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27885?vs=77074=77250

REVISION DETAIL
  https://phabricator.kde.org/D27885

AFFECTED FILES
  gmenu-dbusmenu-proxy/window.cpp

To: broulik, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma Sprint in Augsburg cancelled

[Kai Uwe Broulik]

Hi everyone,

I regret to inform you that with Covid-19 spreading, large events and 
flights increasingly being cancelled on short notice, the situation in 
Italy worsening etc, we decided to call off the Plasma Sprint in 
Augsburg next month.


If you have made travel arrangements, please see if you can cancel them. 
Note that airlines may have special cancellation policies in this 
situation and regardless of that may be obliged to refund taxes and 
airport handling fees, even if the ticket price itself is 
non-refundable. I've contacted the eV board on what refund policy 
applies in this novel scenario.


Let's see how this develops in the coming months and perhaps retry in 
summer, or some later time.


I apologize for the inconvenience but I do not apologize for taking 
yours and TUXEDO's safety and well-being seriously.


Kai Uwe

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  This causes layouting issues in narrow panels:
  F8167100: Screenshot_20200309_085328.PNG 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Michail Vourlakos]

mvourlakos added a comment.


  I think it is better to have an option for this in order to not be applied 
always when the user reverses the indicator..
  
  And also are you sure that this way the growing circle animation of the 
indicator is still working correctly?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo added a comment.


  @ngraham If FormLayout does not support opacity/enabled for labels, then 
maybe, this patch is good enough.

INLINE COMMENTS

> DetailsText.qml:67
>  font.pointSize: theme.smallestFont.pointSize
> -text: details[(index*2)+1]
> +horizontalAlignment: Text.AlignLeft
> +text: details[index] + (label ? ": " : "")

Remove this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart