D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  In D25961#676900 , @nicolasfella 
wrote:
  
  > @leinir it seems like this was merged so I guess this should be closed?
  
  
  Probably make sense, yeah - it basically got moved to invent and worked on 
there, so it would really want closing anyway :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: nicolasfella, apol, zachus, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Wednesday, 21 October 2020 11:39:32 BST Dan Leinir Turthra Jensen wrote:
>   Just under a month since that reminder above went out, so i thought i'd
> give a quick poke and say that unless i hear opinions otherwise, i'll
> consider this an agreement that things are in decent order, and i will move
> Peruse to its new home in extragear/graphics/peruse on Friday the 23rd of
> October (that is, in two days). Thanks for the comments people have already
> made, too, while of course they were not super numerous, they were
> constructive and encouraging!

  As forewarned, the move has now been completed. Thank you again to those who 
commented, highly useful and helpful stuff from everybody :)

https://invent.kde.org/sysadmin/repo-metadata/commit/
e71a98b28f0f73c208c29086617b335b722f8190
-- 
..dan / leinir..
http://leinir.dk/

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Friday, 25 September 2020 14:22:22 BST Dan Leinir Turthra Jensen wrote:
> On Tuesday, 15 September 2020 14:11:42 BST Dan Leinir Turthra Jensen wrote:
> 
> 
>   Hey again, this is your friendly neighbourhood leinir, welcoming further
> comments (and thinking that a Friday afternoon would be a sensible time to
> do this, to catch the people who weren't caught on the Tuesday of the
> original email to which this is a reply ;) )
>   If you've nothing to comment, that's absolutely fine as well, obviously,
> just wanted to make sure that you don't forget if you /do/ have something to
> add :D

  Just under a month since that reminder above went out, so i thought i'd give 
a quick poke and say that unless i hear opinions otherwise, i'll consider this 
an agreement that things are in decent order, and i will move Peruse to its 
new home in extragear/graphics/peruse on Friday the 23rd of October (that is, 
in two days). Thanks for the comments people have already made, too, while of 
course they were not super numerous, they were constructive and encouraging!

-- 
..dan / leinir..
http://leinir.dk/

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Tuesday, 15 September 2020 14:11:42 BST Dan Leinir Turthra Jensen wrote:


  Hey again, this is your friendly neighbourhood leinir, welcoming further 
comments (and thinking that a Friday afternoon would be a sensible time to do 
this, to catch the people who weren't caught on the Tuesday of the original 
email to which this is a reply ;) )
  If you've nothing to comment, that's absolutely fine as well, obviously, 
just wanted to make sure that you don't forget if you /do/ have something to 
add :D

-- 
..dan / leinir..
http://leinir.dk/

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Wednesday, 16 September 2020 21:00:00 BST Albert Astals Cid wrote:
> Missing i18n?

  Indeed, and sorted! Thanks for spotting those :)

-- 
..dan / leinir..
http://leinir.dk/

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Tuesday, 15 September 2020 19:34:23 BST Albert Astals Cid wrote:
> Which seems to point that there's something broken somewhere.

  There we go... a mutex and a few mutex lockers later, and i... think it's 
happy? Give it a proper shove and see if it still falls over for you ;)

-- 
..dan / leinir..
http://leinir.dk/

Re: Peruse in KDEReview

[Dan Leinir Turthra Jensen]

On Tuesday, 15 September 2020 19:34:23 BST Albert Astals Cid wrote:
> El dimarts, 15 de setembre de 2020, a les 15:11:42 CEST, Dan Leinir Turthra 
Jensen va escriure:
> > where you might grab in particular Pepper & Carrot Volume 1, which also
> > will show you some of the fancier features of the reader (such as
> > frame-by-frame navigation, originally implemented by Wolthera).
> 
> I did that and it's failing quite a bit, half of the times i open it, it
> crashes the one third of the times, i get https://i.imgur.com/ehey654.png
> and the other third works.
> 
> Which seems to point that there's something broken somewhere.
> 
> Cheers,
>   Albert
> 
> Backtrace:


  First of all: thank you for that backtrace :D So here's the reason that's 
happening, and it is... silly more than anything else. I've never been able to 
provoke an actual crash out of this (somehow? not sure how that's not 
happened, though i'm sure it would start immediately now someone else has 
managed, thanks for collapsing that wave function ;) ).
  In short: The archive is held by a model, which then passes archive entries 
off to the runnable you see in the backtrace up there. It then attempts to 
load the data out of that, which will fail if more than one attempts to do so 
at the same time, because of course it will.
  In even shorter: Threads are "fun", and i'm working on the fix for that one 
right now ;)

-- 
..dan / leinir..
http://leinir.dk/

Peruse in KDEReview

[Dan Leinir Turthra Jensen]

Hello there :)

  i've just moved Peruse to KDEReview. It is a comic book reader app and an 
accompanying creation tool, both based on Kirigami, and targeted both for 
desktops and mobile (hence the many email lists you may find this email on).

  The current website is at https://peruse.kde.org/ and as you can see, there 
have in fact been releases made of this, though they are some time ago and 
based on Kirigami 1, which also has been causing some headaches for Neon, 
whose maintainers have been requesting that i get a new release out (which of 
course then requires that we actually sort out the current playground nature 
of the project).

  It should be noted that Peruse, when used as a generic viewer, uses the 
Okular qtquick components, which we discovered recently are not packaged by 
some distributions. It should be detected at runtime and Peruse ought to tell 
you as much.

  If you haven't got any comics to hand, do check out the store integration, 
where you might grab in particular Pepper & Carrot Volume 1, which also will 
show you some of the fancier features of the reader (such as frame-by-frame 
navigation, originally implemented by Wolthera).

  Look forward to seeing what people have to say about all this, and thank you 
to Wolthera and Carl who already made huge strides in improving the project 
over the years!

-- 
..dan / leinir..
http://leinir.dk/

Re: Unannounced new dependency in plasma-desktop

[Dan Leinir Turthra Jensen]

On Saturday, 8 August 2020 13:22:05 BST Ben Cooksley wrote:
> On Sat, Aug 8, 2020 at 11:22 PM Dan Leinir Turthra Jensen
> 
>  wrote:
> > On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote:
> > > Hi Plasma Developers,
> > > 
> > > It appears that in the past 24 hours you have introduced new
> > > dependencies in the plasma-desktop repository without announcing them
> > > 2 weeks in advance beforehand.
> > > 
> > > This can be seen in the CI system failures at
> > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/
> > > 
> > > Could we please get an explanation as to why this was not requested in
> > > advance as is supposed to happen?
> > > 
> > > Thanks,
> > > Ben
> > > 
> >   This one is on me, i guess? The reason for this is that this new
> >   dependency
> > 
> > was on a framework rather than an external dependency, and i was led to
> > believe that adding such a dependency to the repo metadata would be
> > sufficient.
> 
> You are correct that adding dependencies on projects within KDE as a
> general rule does not require announcement.
> 
> It appears in this case however that this had the effect (somehow) of
> causing external dependencies to also be added, as can be seen in the
> Dependency Build job logs. See
> https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20k
> f5-qt5%20FreeBSDQt5.15/lastFailedBuild/console for an example of this.
> 
> 06:47:31  -- Checking for module 'signon-oauth2plugin'
> 06:47:31  --   Package 'signon-oauth2plugin', required by
> 'virtual:world', not found
> 06:47:31  CMake Error at
> /usr/local/share/cmake/Modules/FindPkgConfig.cmake:497 (message):
> 06:47:31A required package was not found
> 06:47:31  Call Stack (most recent call first):
> 06:47:31/usr/local/share/cmake/Modules/FindPkgConfig.cmake:681
> (_pkg_check_modules_internal)
> 06:47:31CMakeLists.txt:72 (pkg_check_modules)
> 
> I suspect this may be a bug in kaccounts-integration, which is
> checking for additional dependencies when other projects try to use
> it, that it does not require when it is built. These find calls are
> either for runtime purposes, or outdated and need removing.

  That specific check should be runtime only, as well, but i must have missed 
that (as did the reviewers), but i've done an mr for getting this to build 
without adding new requirements over at:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/99

> Any ideas?

  i'll do the long-form thing for now, by turning it into an optional 
requirement and we can go through the longer process for the new 
dependencies... In the slightly longer term, though, it seems like kaccounts-
integration wants to be made a proper Framework as well.

-- 
..dan / leinir..
http://leinir.dk/

Re: Unannounced new dependency in plasma-desktop

[Dan Leinir Turthra Jensen]

On Saturday, 8 August 2020 12:43:49 BST Rik Mills wrote:
> On 08/08/2020 12:22, Dan Leinir Turthra Jensen wrote:
> > On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote:
> >> Hi Plasma Developers,
> >> 
> >> It appears that in the past 24 hours you have introduced new
> >> dependencies in the plasma-desktop repository without announcing them
> >> 2 weeks in advance beforehand.
> >> 
> >> This can be seen in the CI system failures at
> >> https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/
> >> 
> >> Could we please get an explanation as to why this was not requested in
> >> advance as is supposed to happen?
> >> 
> >> Thanks,
> >> Ben
> >> 
> >   This one is on me, i guess? The reason for this is that this new
> >   dependency
> > 
> > was on a framework rather than an external dependency, and i was led to
> > believe that adding such a dependency to the repo metadata would be
> > sufficient.
> 
> kaccounts (build dep) is part of the release service (formally KDE
> Applications), not a framework.
> 
> libaccounts-qt (build dep) and signon-plugin-oauth2 (runtime) are not
> frameworks, or a KDE project.
> 
> There is also no information in cmake as to minimum required versions of
> these.

i've done a merge request[1] with a build fix (by making it all optional), and 
the metadata will need reverting as well and the full bureaucracy will need 
implementing for this dependency. It seems really silly to me, and i have no 
idea how kaccounts-integration makes sense as an application, but this is 
where we are, i guess. Not blaming anybody other than myself here, just 
flailing my arms in confusion in what is usually a much more reasonably laid 
out sort of thing ;)

[1] https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/99

-- 
..dan / leinir..
http://leinir.dk/

Re: Unannounced new dependency in plasma-desktop

[Dan Leinir Turthra Jensen]

On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote:
> Hi Plasma Developers,
> 
> It appears that in the past 24 hours you have introduced new
> dependencies in the plasma-desktop repository without announcing them
> 2 weeks in advance beforehand.
> 
> This can be seen in the CI system failures at
> https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/
> 
> Could we please get an explanation as to why this was not requested in
> advance as is supposed to happen?
> 
> Thanks,
> Ben

  This one is on me, i guess? The reason for this is that this new dependency 
was on a framework rather than an external dependency, and i was led to 
believe that adding such a dependency to the repo metadata would be 
sufficient.

-- 
..dan / leinir..
http://leinir.dk/

D29709: Give all OverlaySheets consistent headers

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  Yay consistency! Good idea (and timely ;) )

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg, leinir
Cc: leinir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Nice! Got a few places where this could be very handy :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> nicolasfella wrote in kdeplatformdependent.cpp:165
> This sounds like a use case for KCMultiDialog, like e.g. in 
> https://invent.kde.org/kde/kdeconnect-kde/-/blob/master/settings/main.cpp

That certainly could be! i'll take a look, thanks for the hint :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: nicolasfella, apol, zachus, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D25961#617057 , @apol wrote:
  
  > +1 cool stuff, much better than using kwallet for it.
  
  
  Thanks! :)
  
  > Have you checked how well it works regarding startup? In Discover we do a 
bunch of queries at start for every KNSEngine and we need to make sure we don't 
block the whole thing (more than QNAM does, at least)
  
  Not yet, no; the intention is to postpone the qnam creation in there (which 
is currently a touch on the ugly side, and also not acceptable given the whole 
redirection situation), and then also a mix of caching and delayed creation for 
the accounts stuff, so... yeah, bit of work to be done in that bit, for thought 
i'd delay that until it actually works :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: apol, zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 76309.
leinir added a comment.


  - Switch to using the kaccounts cmake commands

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=76049=76309

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service.in
  attica-kde/kdeplugin/opendesktop.provider.in

To: leinir
Cc: zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 76049.
leinir added a comment.


  Fair bit of work gone on here, but in short, given a patch which handles the
  OpenID ID token in the OAuth2 requests in signon-plugin-oauth2, we are now
  able to construct a bearer-authenticated request and whatnot. There is more
  work to be done, but it seems like things are happening now! Progress.
  
  The merge request for the signon-plugin-oauth2 patch can be found at:
  https://gitlab.com/accounts-sso/signon-plugin-oauth2/-/merge_requests/25
  
  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files
  - Add functionality to open the accounts kcm on saveCredentials calls
  - Actually make the service locator work (need to query for the right thing)
  - Add the SignOn OAuth plugin as a runtime dependency
  - Minor cleanup for attica_kde cmakelists
  - The opendesktop provider file is... not google
  - Fetch the access token (actually ID token) from AccountsManager via 
KAccounts

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=74208=76049

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27194: Remove human avatars

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D27194#606877 , @ngraham wrote:
  
  > Wouldn't it be better to get better ones? We already removed a ton last 
year. If we keep on removing stuff, we'll eventually end up with nothing but 
Konqis.
  
  
  As a counterpoint to that, though, if we keep removing avatars, we'll end up 
only with Konqis... ;) (seriously, though, i'm not really sure why that would 
inherently be a bad thing, except i guess for those who will feel terribly hurt 
in their professionalism... which could perhaps be solved by offering a 
separate selection of super-boring avatars for those situations that require 
such a thing?)

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27021: Port plasma-workspace to autoconfig.kde.org

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  As D27020 , might want to backport this 
to any branches still being released.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27021

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27020: Port plasma-desktop to autoconfig.kde.org

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Goodness me, yes please. Land in 5.18 for sure (also perhaps backport to 
anywhere that's still being released)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27020

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec387280ad9d: Switch to the old-style button text for the 
KNSQuick buttons (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26892?vs=74301=74480

REVISION DETAIL
  https://phabricator.kde.org/D26892

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, davidedmundson
Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26665#601713 , @IlyaBizyaev 
wrote:
  
  > What about the "Get New Plugins" button in the same dialog? It still uses 
the old style.
  >  Probably unrelated, but for me, both of these buttons fail to actually 
load anything, stuck connecting forever. I would blame all of my internet 
connections that I tried it with, but it does not happen in System Settings, so 
maybe there's some bug here.
  
  
  
  
The reason that wasn't changed in this step is simple - because it isn't 
simple ;) You'll notice that the change here was very much a trivial swap. 
Changing the other KNS integration points out for the new one will be 
considerably more effort, hence it isn't happening just yet.
  
  > And also, looking at @victorr's screenshot, I see that the "Close" button 
has no label on it. I got same problem here as well.
  
  That really is a very strange error. Not sure why such a thing would fail. 
The code in question can be seen here: 
https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98
 - However, the whole thing is also being discussed elsewhere, making this the 
wrong place. Would be good to get more eyes on the situation :) 
https://bugs.kde.org/show_bug.cgi?id=413434

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26892#600510 , @aacid wrote:
  
  > stable branch please :)
  
  
  Ah! Missed this somehow - landing on the 5.18 branch momentarily! :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This fixes a series of localization issues as reported in
  https://bugs.kde.org/show_bug.cgi?id=415541 based on the
  minimum-impact method (hopefully these strings should even
  still be in the pot files...)
  
  BUG:415541

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74208.
leinir added a comment.


  - Actually make the service locator work (need to query for the right thing)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=73756=74208

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26837: Remove a no longer needed optional margin

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  Already done elsewhere :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26837

To: leinir, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26837: Remove a no longer needed optional margin

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This further removes a warning which would happen a fair bit if using
  any context actions

REPOSITORY
  R169 Kirigami

BRANCH
  no-longer-needed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26837

AFFECTED FILES
  src/controls/private/ContextDrawerActionItem.qml

To: leinir
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26833: Get rid of a couple of warnings

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d789ef75de5b: Get rid of a couple of warnings (authored 
by leinir).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26833?vs=74095=74101

REVISION DETAIL
  https://phabricator.kde.org/D26833

AFFECTED FILES
  src/controls/FormLayout.qml
  src/controls/templates/OverlaySheet.qml

To: leinir, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26833: Get rid of a couple of warnings

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Without this patch, applications will complain about things not
  being acceptable for assigning to certain properties, or not
  being able to find a property on some objects.

REPOSITORY
  R169 Kirigami

BRANCH
  remove-some-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26833

AFFECTED FILES
  src/controls/FormLayout.qml
  src/controls/templates/OverlaySheet.qml

To: leinir
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73756.
leinir added a comment.


  Rebase on master
  
  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files
  - Add functionality to open the accounts kcm on saveCredentials calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=71607=73756

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#595312 , @meven wrote:
  
  > In D26544#595269 , @leinir wrote:
  >
  > > In D26544#595246 , @bcooksley 
wrote:
  > >
  > > > Cancel that, it fails to build on Linux as well - i'm guessing that the 
KNetstuff changes have not been landed?
  > >
  > >
  > > The KNS changes have indeed not been landed yet
  >
  >
  > Please revert this temporally, it breaks all build of master plasma-desktop
  
  
  The problem is that a small part of it depends on functionality to exist 
master which doesn't currently exist - specifically D26543 
. I've pushed a thing that works around 
this, which can be reverted once said code has become available in the CI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: meven, bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#595246 , @bcooksley 
wrote:
  
  > Cancel that, it fails to build on Linux as well - i'm guessing that the 
KNetstuff changes have not been landed?
  
  
  The KNS changes have indeed not been landed yet

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:442c43b3ca98: Switch the Plasma Desktop KCMs to using 
KNewStuffQuick (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73598=73638

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73598.
leinir added a comment.


  - Unbreak the merge

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73597=73598

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73597.
leinir added a comment.


  - Unbreak the merge

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73595=73597

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  CMakeLists.txt
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73595.
leinir added a comment.


  Let's try and unbreak this diff, shall we...
  
  - Only try and work on newly installed themes
  - Port the cursortheme kcm to KNSQuick
  - Port the plasma theme kcm's ghns support to KNSQuick
  - Port the Icons kcm to KNSQuick
  - Port the Splash kcm to KNSQuick
  - Wrap the new requirements up in some handy checks, for older Frameworks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73544=73595

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Right, everything blew up i guess. Nice.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73544.
leinir added a comment.


  - Merge remote-tracking branch 'origin/master' into switch-kcms-to-knsquick
  - Fix build (by removing stuff that was removed in master it seems)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73409=73544

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/kicker/package/contents/ui/ActionMenu.qml
  applets/kicker/package/contents/ui/CompactRepresentation.qml
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/package/contents/ui/DashboardTabButton.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListDialog.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kicker/package/contents/ui/SideBarSection.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/package/metadata.desktop
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/org.kde.plasma.emojier.desktop
  applets/kimpanel/backend/ibus/emojier/resources.qrc
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml
  applets/kimpanel/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/windowmodel.cpp
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/code/layout.js
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/panel/contents/ui/ConfigOverlay.qml
  design/plasmoids
  imports/activitymanager/CMakeLists.txt
  kcms/access/kcmaccess.desktop
  kcms/activities/BlacklistedApplicationsModel.cpp
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/utils/dbusfuture_p.cpp
  kcms/activities/utils/dbusfuture_p.h
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.desktop
  kcms/baloo/CMakeLists.txt
  kcms/baloo/Messages.sh
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsmodel.cpp
  kcms/colors/editor/org.kde.kcolorschemeeditor.desktop
  kcms/colors/filterproxymodel.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/contents/ui/main.qml
  kcms/colors/package/metadata.desktop
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.desktop
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#594194 , @ngraham wrote:
  
  > Thanks for the explanation!
  
  
  Not a problem, it's not necessarily easy to spot at a glance - and thanks! :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:47a1091be9f5: Switch to KNSQuick for getting new 
wallpapers (authored by leinir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26665?vs=73526=73531

REVISION DETAIL
  https://phabricator.kde.org/D26665

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml

To: leinir, mart, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This switches the image plugin to using KNewStuffQuick instead of
  launching the widget dialog through that ol' widget dialog hack.
  It further uses the big preview mode by default, which just seems
  to make a lot of sense for wallpapers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-knsquick-for-wallpapers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26665

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in colors.cpp:128
> This wraps a lot of existing functionality into that conditional as well. Was 
> all of that stuff broken and useless without D26543 
> ?
> 
> Everything seems to work anyway, but I'm curious to know if everything here 
> needs to be wrapped up in this.

All the code inside this conditional is for setting the most recent newly 
installed theme as the currently selected - perhaps a slightly long winded way 
of doing so, but yup, that's really all it does :) (and if it can't use the 
data being pulled out of the changedEntries, there doesn't seem any good reason 
to run the rest of the code which arguably would build and run, as it just 
wouldn't do anything)

> ngraham wrote in kcmcursortheme.cpp:433
> ditto

Also ditto - all the code here depends on having an entry to work with, and if 
that can't be pulled out of changedEntries (which doesn't work until 5.67) then 
there's no particularly good reason to run the other bits of the code :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73409.
leinir added a comment.


  As discussed above, we need to be able to build against an older version of
  Frameworks than 5.67. As such, wrap up the bits that aren't available before
  then in some compile-time checks.
  
  - Wrap the new requirements up in some handy checks, for older Frameworks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73190=73409

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:254
> FWIW, there is an alternative approach that we do in plasma-workspace 
> (shell/containmentconfigview.cpp) for reloading wallpapers types.
> 
> kpackage emits a DBus signal when it performs an action, models can listen 
> for this.
> 
> We had to do that there because the model was quite separated from the UI. 
> But it has the advantage that we pick up external changes (i.e through 
> discover or whatever)

That does sound like something that would be good to look at at a later point 
in time (it'd make this whole thing vastly more involved, and i'm trying to 
keep it a bit more simple for now)

> davidedmundson wrote in main.cpp:275
> Does this code still exist? I can't see an equivalent in knewstuff.
> 
> It's especially important on wayland

The new dialog is entirely QtQuick (clicking the NewStuff.Button essentially 
just calls open() on a QtQuick.Dialogs Dialog, so if doing show on a QtQuick 
Dialog does the trick, then yes. Otherwise i am... severely uncertain of how 
that might be solved (though it would be central at least, since the code would 
be in KNSQuick).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#592286 , @ngraham wrote:
  
  > I notice that this also has the effect of changing the button texts to not 
have ellipses on the end. I guess `NewStuff.Button` needs to do that itself?
  
  
  There's a bug report for it (and that is indeed something that wants fixing 
in NewStuff.Button)
  
  > Works great BTW. A big improvement!
  
  Thanks! :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir planned changes to this revision.
leinir added a comment.


  In D26544#592285 , @ngraham wrote:
  
  > This patch makes plasma-desktop fail to build without the dependent KNS 
framework change. That means that the KNS change is in fact a hard dependency 
and therefore this functionality can't make it into 5.18 with the patch's 
current state. If you want it for 5.18 (as I assume you do, and I do too!), 
you'll need to make D26543  not a 
dependency by only conditionally using the `KNSCore::EntryWrapper` 
functionality, or by finding a way to implement the fix in way that doesn't add 
new classes that have to be used here.
  
  
  ah, d'oh, yes, you're quite right... it /is/ a hard dependency, i entirely 
forgot about that one... not entirely sure how i forgot about it, perhaps 
repression from having to write it at all, but yes. Right, let's see what we 
can do about that, then :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#591591 , @bcooksley 
wrote:
  
  > In the case of three Frameworks (namely plasma-framework, kwayland and 
kwindowsystem) I have on file requests from the Plasma and KWin developers 
informing me that their software does indeed require latest HEAD (with no 
delay) of those particular frameworks, hence the convoluted setup on the CI 
system for those three. They do date back to May 2017 though.
  
  
  Right, thanks for the clarification! :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#591398 , @ngraham wrote:
  
  > Since D26543  is listed as a dependent, 
but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, 
but 5.66 has already been tagged, that means that this can't land in 5.18, so 
we'll ship 5.18 with only the Global Themes KCM using the new dialog, and all 
the other dialogs using the old one. :/
  
  
  Gah, i was under the impression the awkwardness with frameworks dependencies 
on the CI was due to Plasma requiring head...
  
  > Is D26543  a hard blocker, or just a 
nice-to-have bugfix?
  
  Right, the functionality would all still exist (that is, 
install/uninstall/update/whatnot would function just fine), what would happen 
without the dependent patch is that the views will be out of sync with the 
system state (basically the onChangedEntriesChanged will just fail to call the 
function it's pointed at due to incompatible types, in all but the desktoptheme 
kcm (which just calls load anyway, which doesn't expect anything weird).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir requested review of this revision.
leinir added a comment.


  Right, that's the lot of the qtquick kcms in plasma-desktop!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73190.
leinir added a comment.
This revision is now accepted and ready to land.


  - Only try and work on newly installed themes
  - Port the cursortheme kcm to KNSQuick
  - Port the plasma theme kcm's ghns support to KNSQuick
  - Port the Icons kcm to KNSQuick
  - Port the Splash kcm to KNSQuick

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73127=73190

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir planned changes to this revision.
leinir added a comment.


  i'm working on more of this (main reason for the status change, but thank 
you!), and there's a patch for KNS that wants to go in first (of course) - it's 
runtime, so it won't break the CI for this to go in first, but... still :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Change the colors KCM code to take data from a Qt Quick based GHNS dlg
  
  Switch the Colors KCM UI to using KNSQuick
  
  Only link against the bit of KNS that's needed for the colors KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D25961#578727 , @zachus wrote:
  
  > is there a server out there to run it against?
  
  
  The provider file points it at the opendesktop.org server (that is to say, 
the KDE Store), so testing can be done against the live servers that already 
provide all our content :)
  
  Note also that the current client id and secret means you will be told that 
Bhushan Shah is asking for access to your things during sign-in - this is 
because that's who asked for test access in order to build this, so don't 
worry, that's currently expected. Before merging, it'll want to be swapped out 
for a more proper id, though we'll probably want to give this some thought - do 
we want one default for all of KDE's software, do we want one that can be 
replaced by distributions, or do we want distributions to have to do this? i'm 
currently unsure, but leaning towards option two (meaning, ship with a default 
id and secret set, but offer the ability for distributions and app developers 
to swap this out with one of their own).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: zachus, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 71607.
leinir added a comment.


  - Add functionality to open the accounts kcm on saveCredentials calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=71495=71607

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 71495.
leinir added a comment.


  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=71463=71495

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Don't require KWallet, and require KAccounts and libaccounts-Qt5
  
  Link and use includes from new requirements
  
  Remove KWallet bits, and use KAccounts/libaccounts-qt instead
  
  This removes the custom KWallet integration in favour of an approach
  based on the more generic KAccounts framework. It is a work in progress
  which currently does not allow for creating new accounts (which would
  be done through saveCredentials), but which does load and use the data
  from any accounts which already exist.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25886: Add support for sub-comments to the Reviews backend

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:a4b6d2d5c25e: Add support for sub-comments to the Reviews 
backend (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25886?vs=71277=71286

REVISION DETAIL
  https://phabricator.kde.org/D25886

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir, #discover_software_store, #plasma, apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25886: Add support for sub-comments to the Reviews backend

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Using a similar style to the comments delegate in KNewStuffQuick, this
  adds the functionality for having subcomments in the Reviews model.
  The end result is that we no longer have incorrect numbers showing in
  Discover, as it now shows all the items returned by the server.
  
  - Adds a role for the depth of reviews (used for comments on reviews)
  - Adds sub-comments (and set their depth) in the KNS backend's reviews
  - Adapts the ReviewDelegate to have indentation marks (styled like KNSQuick)

REPOSITORY
  R134 Discover Software Store

BRANCH
  add-support-for-subcomments (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25886

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25282: Ensure comments fetch for KNS starts on the right page

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:11bfabfcbee9: Ensure comments fetch for KNS starts on the 
right page (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25282?vs=69669=69685

REVISION DETAIL
  https://phabricator.kde.org/D25282

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir, #discover_software_store, #plasma, ngraham, apol, starbuck
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25282: Ensure comments fetch for KNS starts on the right page

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  For a while, we've not had reviews/comments showing up for KNS content,
  and ensures we initiate fetching from the correct page. It does not,
  however, ensure that the number of reviews is quite correct, as
  we will need to add support for replies in some way (even if it's
  only done as an indication that they exist)

TEST PLAN
  Without patch: Notice no reviews show up, except on very-reviewed items
  With patch: Notice reviews show up on all content that says it has some

REPOSITORY
  R134 Discover Software Store

BRANCH
  start-fetching-kns-comments-from-the-right-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25282

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25176: Add a displayHint property to Action

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> broulik wrote in Action.qml:124
> Isn't it more like a "no preference" value?
> Also, please document the default value

You're right, NoPreference would probably be more linguistically correct... i 
was more thinking along the lines of, if the default means there is no 
preferred hint, then NoHint would be it... either would be fine for me, though 
:)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25176

To: ahiemstra, #kirigami
Cc: broulik, leinir, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25176: Add a displayHint property to Action

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> Action.qml:124
> + */
> +property int displayHint: 0
> +

Might be nice to have a DisplayHint.NoHint value, to make it more explicit what 
that 0 means

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25176

To: ahiemstra, #kirigami
Cc: leinir, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25141: Use a RowLayout for laying out ToolBarPageHeader

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  These changes make the KNSQuick components all happy :)
  
  F7735334: image.png 
  and
  F7735337: image.png 
  now both looks as intended :)

REPOSITORY
  R169 Kirigami

BRANCH
  headerLayout

REVISION DETAIL
  https://phabricator.kde.org/D25141

To: ahiemstra, #kirigami, leinir
Cc: leinir, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c21a8bd82ec2: Require and use the new NewStuffQuick 
Button component (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24942?vs=68958=69032

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D24942#556062 , @ngraham wrote:
  
  > Thanks, that fixes the issue. This works quite well now.
  >
  > Would be nice to address the bugs I filed before 5.18 is released so it 
really gets polished up all nice and shiny. :)
  
  
  Thanks for the confirmation! :)
  
  Definitely would, i'm endeavouring to run through the issues quick as 
possible :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 68958.
leinir added a comment.


  Together with the change in D25041  this 
makes the model reloading work
  (without that patch, it simply fails quietly as the signal forwarding
  fails). If wanted, we could also use the count property in the same
  diff to reintroduce the previous logic (which of course would then
  require that patch having been merged first)
  
  - Simplify the model reload logic a touch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24942?vs=68742=68958

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, #knewstuff, #vdg, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This removes the need for the custom hack for spawning a dialog,
  and is intended to function as a sample for how to implement this
  in other KCMs.
  
  Also use the big, pretty Preview mode (because super-visual content)
  
  This could be done wholesale for the entire bunch of KCMs, but i post
  this on its own in an attempt to gain feedback on a self contained
  example of how to do this porting step.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24156: Don't require QtGui for the PaginateModel test

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:120ee5cbb571: Dont require QtGui for the 
PaginateModel test (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24156?vs=66659=67115

REVISION DETAIL
  https://phabricator.kde.org/D24156

AFFECTED FILES
  discover/autotests/CMakeLists.txt
  discover/autotests/PaginateModelTest.cpp

To: leinir, #discover_software_store, bshah, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24156: Don't require QtGui for the PaginateModel test

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D24156#540238 , @apol wrote:
  
  > I'm not sure what we're winning, but sure.
  
  
  It allows the tests to be run on e.g. postmarketOS' CI - 
https://gitlab.com/postmarketOS/pmaports/merge_requests/639#note_220402081 
shows the specific problem :) (there's other issues, as seen in the comments 
further down from there, but yeah, it's really just a "why require gui when we 
don't need it" sort of situation... especially when the fix is as simple as 
this :) )

REPOSITORY
  R134 Discover Software Store

BRANCH
  dont-require-qtgui-for-paginatemodel-test (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24156

To: leinir, #discover_software_store, bshah, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24156: Don't require QtGui for the PaginateModel test

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This is done by switching from the QStandardItemModel, which requires
  QtGui, to QStringListModel, which is in QtCore. The result is a much
  leaner test, and it's all done by adding a couple of helper functions
  which add the simplistic data addition functions from QSIM, except
  locked to QStrings (the way it was being used anyway).

TEST PLAN
  Run the tests, which still pass

REPOSITORY
  R134 Discover Software Store

BRANCH
  dont-require-qtgui-for-paginatemodel-test (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24156

AFFECTED FILES
  discover/autotests/CMakeLists.txt
  discover/autotests/PaginateModelTest.cpp

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23109: Rework the visibleActions logic in SwipeListItem

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:56d3ccd95753: Rework the visibleActions logic in 
SwipeListItem (authored by leinir).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23109?vs=63658=63730

REVISION DETAIL
  https://phabricator.kde.org/D23109

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: leinir, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23109: Rework the visibleActions logic in SwipeListItem

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 63658.
leinir added a comment.


  - Only check for other visible actions if this one is not visible

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23109?vs=63598=63658

BRANCH
  rework-swipelistitem-visible-actions-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23109

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: leinir, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23109: Rework the visibleActions logic in SwipeListItem

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  visibleActions is really only used to check whether there are
  any actions visible at all, the number is irrelevant. For some
  unknown reason the old logic would occasionally get caught in
  some out of order silliness (so we'd end up with a negative
  number of visible actions), but with this logic we only check
  whether there is any visible actions at all, so the whole thing
  is less stateful.

TEST PLAN
  Using Peruse on mobile, load up the Store and see that with the
  old logic there are no handles on the items. With the new
  logic there is.

REPOSITORY
  R169 Kirigami

BRANCH
  rework-swipelistitem-visible-actions-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23109

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: leinir
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D18180: Fix layout issues in the AboutPage personDelegate component

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  Irrelevantisified by D22868  :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18180

To: leinir, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D22868: Revamp Kirigami.AboutPage

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  While swapping out the card for straight up a rowlayout might[1] effectively 
look like a workaround for the weirdness in that bit... this really just looks 
better anyway ;) Go for it :D
  
  [1] to someone who's tried to fix that bit before - D18180 
 - not in general :) once this is landed, 
i'll abandon that diff

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and 
Sources globaldrawer entries (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22716?vs=62471=62521

REVISION DETAIL
  https://phabricator.kde.org/D22716

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  libdiscover/Category/CategoriesReader.cpp
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, #vdg, ngraham, apol
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  At some point, icons were removed from a number of entries in the global
  drawer, but with the many other changes which have happened since then
  this now leaves the sidebar looking somewhere between overly vacant and
  broken (with some overweight toward the latter). This patch adds these
  icons back in, as well as a couple of others, which results in a global
  drawer which looks considerably more completely loaded.
  
  This is furthermore based on feedback from the Plasma Mobile Todo[1] notes
  entry, which at time of writing contains the following (amongst others):
  
  Discover:
  Global toolbar:
  
  - Installed and Sources should have icons
  - Categories should either have icons or be less indented
  
  [1] https://notes.kde.org/p/plasma-mobile-todo
  
  Parent Categories created by the category reader

TEST PLAN
  See before without icons looks empty and just a tiny bit broken, and after
  with icons included looks fully populated (screenshots incoming)

REPOSITORY
  R134 Discover Software Store

BRANCH
  more-globaldrawer-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22716

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  libdiscover/Category/CategoriesReader.cpp
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download 
Tag (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21510?vs=61120=61196#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=61120=61196

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490851 , @ngraham wrote:
  
  > In D21510#488800 , @leinir wrote:
  >
  > > In D21510#488646 , @ngraham 
wrote:
  > >
  > > > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  > >
  > >
  > > Aaaawesomesauce :) Land on master, or 5.16, or?
  >
  >
  > If the requisite support is entirely server-side, I'd even say the 
`Plasma/5.12` branch and merge forward. Otherwise `Plasma/5.16` and merge 
forward.
  
  
  Right, Plasma/5.16 it is :) Technically it /could/ go into 5.12... It has no 
effect unless someone runs it against Attica/KNewStuff 5.51, but i don't expect 
there'll be many using that particular combination ;)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490850 , @ngraham wrote:
  
  > In D21510#490635 , @leinir wrote:
  >
  > > - Also filter on the ghns_excluded tag, otherwise they'll be shown...
  >
  >
  > I thought that was taken care of on the server side?
  
  
  No, all filtering happens client-side

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 61120.
leinir added a comment.


  - Also filter on the ghns_excluded tag, otherwise they'll be shown...

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58937=61120

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#488646 , @ngraham wrote:
  
  > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  
  
  Aaaawesomesauce :) Land on master, or 5.16, or?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#472572 , @ngraham wrote:
  
  > Can you update the test plan to provide examples of themes that are 
correctly tagged so we can test this?
  >
  > - Plasma 5 only theme
  > - Plasma 4 only theme
  > - Theme that works on both Plasma 4 and 5
  
  
  When i first looked, for some reason i couldn't find any that matched the 
last option (i feel fairly certain that it was there when i originally 
checked), and then got sidetracked. Here is a list of three themes which match 
the three conditions:
  
  Plasma 5 only theme: "OxyLight 5 Plasma theme" (id: 998609)
  Plasma 4 only theme: "A Pimp Named Slickback (for the contest)" (id: 998596)
  Theme which says it works on both: "OxygenDymAero7" (id: 1305103)
  
  (and, of course, any theme which has no version set will be accepted, or we'd 
be filtering out the vast majority of themes on there...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#472514 , @ngraham wrote:
  
  > Is the content actually tagged appropriately yet? When I test this out I 
see no effect, i.e. old Plasma 4 themes like OLED Orange 
(https://store.kde.org/p/998790/) are still visible.
  
  
  Not all of it, no - we do have a bit of a chicken/egg situation going on 
here, but at least the one you linked to isn't tagged with appropriate 
versioning information (https://api.kde-look.org/ocs/v1/content/data/998790 is 
the full xml data for that item). Fair bunch of them are, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 58937.
leinir added a comment.


  - Add TagFilter (for top level tags), and don't explicitly reject 4

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58935=58937

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Following a lengthy discussion on the topic[1], the first step
  towards getting themes cleaned up and hidden when they don't
  work is to get the ones hidden which are only for Plasma 4.
  We do this by filtering out any theme which is tagged as
  being for the major version 4 of plasma. We also allow themes
  through which have been tested to work on both, by accepting
  themes which are tagged as both 4 and 5.
  
  [1] https://phabricator.kde.org/T8126#184198 and down a few pages

TEST PLAN
  See themes tagged as plasma##majorversion=4 being hidden, except when they
  are also tagged as plasma##majorversion=5. This can most easily be done
  by launching the plasma theme dialog and opening Get New Themes from there
  and turning on debugging for KNewStuff(Core) like so:
  
  `QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_desktoptheme`
  
  and then watching the output, and seeing that content is being rejected
  by the InequalityFilter for plasma##majorversion when appropriate.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21246#466158 , @arojas wrote:
  
  > OK I see in https://phabricator.kde.org/D19340 this is intentional
  
  
  Yes, i'm afraid it's one of those unfortunate side effects of having to fix a 
pretty hefty sort of bug which caused a fair few people a lot of anguish. Well 
spotted otherwise, and it would certainly seem to be a good time to (now 
Frameworks has had a release with the code) get this updated in the various 
applications which use KNS. We'd need to do this either by using the new 
install location from KNewStuffCore's cmake module, or by hand picking that 
install location manually (if, for some reason, there is a desire in the 
application to not depend on such a new Frameworks release, which i guess i can 
understand in some cases).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20378: Make KNS applications act more like applications

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:727d8e55e46c: Make KNS applications act more like 
applications (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20378?vs=55802=55883

REVISION DETAIL
  https://phabricator.kde.org/D20378

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20406: Adapt an x option for app-carrying knsrc files

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:6589e22f08e7: Adapt an x option for app-carrying knsrc 
files (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20406?vs=55816=55882

REVISION DETAIL
  https://phabricator.kde.org/D20406

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: #discover_software_store, plasma-devel, apol, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D19925: Split up subcategories for KNS categories

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:29be60b13647: Split up subcategories for KNS categories 
(authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19925?vs=55813=55881#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19925?vs=55813=55881

REVISION DETAIL
  https://phabricator.kde.org/D19925

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20406: Adapt an x option for app-carrying knsrc files

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This adds in an extended option in KNSRC files, which allows them to tell us 
whether or not they carry applications. It would also be possible to make this 
change in knewstuff itself, but as this would be somewhat invasive for, 
frankly, not a great deal of gain, i propose we do it here. @apol and i 
discussed this (very) briefly in person a couple of weeks ago, and it still 
seems like it would be reasonable to do it here rather than in the framework.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20406

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: #discover_software_store, plasma-devel, apol, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D19925: Split up subcategories for KNS categories

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 55813.
leinir marked an inline comment as done.
leinir added a comment.


  Remove unnecessary (very noisy) debug messages

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19925?vs=54446=55813

REVISION DETAIL
  https://phabricator.kde.org/D19925

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19925: Split up subcategories for KNS categories

[Dan Leinir Turthra Jensen]

leinir planned changes to this revision.
leinir added inline comments.

INLINE COMMENTS

> KNSBackend.cpp:149
> +const QString catName = cat->name().append(QLatin1Char('/'));
> +qDebug() << "Checking" << catName;
> +for (auto& potentialSubCat: categories) {

Just realised how spammy these bits of debug are. Gone momentarily.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19925

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19925: Split up subcategories for KNS categories

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Ping? :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19925

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20378: Make KNS applications act more like applications

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 55802.
leinir marked an inline comment as done.
leinir added a comment.


  We now assume that an AdoptionCommand is set. This reduces the code overhead, 
which is always nice.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20378?vs=55737=55802

REVISION DETAIL
  https://phabricator.kde.org/D20378

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20378: Make KNS applications act more like applications

[Dan Leinir Turthra Jensen]

leinir planned changes to this revision.
leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in KNSResource.cpp:213
> Can't we do this in the adoption command? This way we won't have another 
> special case.

Hmm... I guess we could... It requires making a choice in the knsrc file on 
which tool to use for using the app, which i guess might be e.g. 
AppImageLauncher... but i guess that isn't really that much of a problem 
anyway. Sure, i'll just do that instead. And yes, less special cases are 
certainly nice :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20378

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20378: Make KNS applications act more like applications

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This patch adds functionality to allow the KNS backend to report applications 
in a more familiar fashion: If the specific backend has applications, the run 
button will read Launch (rather than Use), and only be shown if there are 
downloaded (installed) executables to run, and then run that when activated.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20378

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20198: Don't lose list position after installing KNS cursor themes

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20198#443779 , @ngraham wrote:
  
  > FYI the patch gets closed automatically only if the commit message has 
`Differential Revision: https://phabricator.kde.org/D20198` somewhere in it. If 
you use `arc land` or cherry-pick the commit hash of the arc-created patch, 
that happens automatically.
  
  
  That is indeed what i usually do, which is why i said i forgot to do so ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

To: leinir, #plasma, ngraham, broulik, apol
Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20198: Don't lose list position after installing KNS cursor themes

[Dan Leinir Turthra Jensen]

leinir closed this revision.
leinir added a comment.


  Forgot to close the revision in R119:4545601adec0 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

To: leinir, #plasma, ngraham, broulik, apol
Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20198: Don't lose list position after installing KNS cursor themes

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 55455.
leinir marked an inline comment as done.
leinir added a comment.


  Address @apol's comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20198?vs=55403=55455

REVISION DETAIL
  https://phabricator.kde.org/D20198

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp

To: leinir, #plasma, ngraham, broulik
Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart