D23257: Allow for easier syncing of Plasma font

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidre wrote in sddmkcm.cpp:243
> Should I remove this then?

Unfortunately not yet because we still need the `kdeglobals` file for color 
schemes. From my previous testing it's not enough to just copy some line 
`colorScheme=Adwaita`, we actually need to copy all of the color scheme values 
written in `kdeglobals`. IIRC that was also a bit tricky just like recreating 
the `fonts.conf` XML file, but it may be possible to reuse existing KDE color 
scheme functions instead of copy-pasting from config files.

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[Filip Fila]

filipf added a comment.


  In D23257#677396 , @davidre wrote:
  
  > I rebased it because of the rewrite that happened, can you check if 
everything is still ok @filipf
  
  
  LGTM. Instead of copying the user's entire `kdeglobals` file (which could 
also be security risk), the sync function now only reads the font value from 
`kdeglobals` and writes it to the `kde_settings.conf` file. Thanks!

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[Filip Fila]

filipf added a comment.


  I think it should work same as when I submitted the patch. It would be good 
to add a comment though that this feature is only supported for for SDDM 0.19 
and above.
  
  In D23257#514708 , @filipf wrote:
  
  > In D23257#514619 , @ngraham 
wrote:
  >
  > > Does anything bad happen if the users uses this with a version of SDDM 
that doesn't support it yet, or does the new item in the config file just get 
ignored?
  >
  >
  > Still runs for me and I'm not getting any errors when running the greeter 
in test mode, but I can't be 100% sure it's not causing any issues.
  
  
  And per this comment nothing bad will happen for versions before 0.19, in 
case there is some conservative distro out there.
  
  ///
  
  @davidre, seeing as this was one of the goals, could you also help me finish 
T12710 ? D27461 
 should likewise just work as is, I just 
didn't get any +1 on it back then.
  Task no.2 was something I couldn't accomplish though. If you have the time 
and some insight on how to do it, let me know in the task.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  easier-font-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29741: [Logout] Port to QQC2 and PC3

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  
https://invent.kde.org/plasma/plasma-workspace/commit/21bdc2a89d123932af2a1b04bd8e98ff868bf3eb

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29741

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Sprint notes: how to improve getting new contributors

[Filip Fila]

One thing I think is worth mentioning is that the KDE Store is not utilized
at all as a hub for recruiting new contributors.

There's some talented and competent people there but I haven't really
seen the community reach out to them.

On Mon, Jun 15, 2020 at 10:02 AM Bhushan Shah  wrote:

> Note that I attended only half of the session due to dinner break, so if
> you have more to add in notes, please add it
>
> Notes:
>
> - TODO Better READMEs, linking to wikis + information/description specific
> about the repo
> - Write more blog posts (even if short posts do it!)
> - too many different ways to do things
> - documentation is fragmented
> - investigate kdesrc-build env driver vs thing in plasma-workspace
> - improve dependency list in kdesrc-build --initial-setup
>
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>

D28154: Add users KCM

[Filip Fila]

filipf added a comment.


  In D28154#672453 , @ngraham wrote:
  
  > Now that D29394  has landed, you can 
add those images here!
  
  
  .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29765: Add a blurless SDDM theme

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI 
sheet that exposes theme.conf and then blur would be one option.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29765

To: filipf, #vdg, #plasma
Cc: ngraham, mart, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29765: Add a blurless SDDM theme

[Filip Fila]

filipf added a comment.


  In D29765#671401 , @broulik wrote:
  
  > Can we perhaps add infrastructure so that a theme can provide options?
  >  For instance, the look and feel package can add options to the lock screen 
KCM which we use for e.g. "always show clock" and "show media controls".
  >  I'm not keen on duplicating the entire theme for a single option.
  
  
  I would also prefer to just have it as an option, but turning off blur 
requires several workarounds to ensure legibility. That means there would be a 
bunch of conditionals in the theme. It's unfortunate there's no context here 
comparing the changes, but there's too many of them IMO. I'll add comments 
instead.

INLINE COMMENTS

> Main.qml:39
> +
> +colorGroup: PlasmaCore.Theme.NormalColorGroup
> +

Changed from Complementary because with complementary you get a white password 
box and dark action button and footer backgrounds.

> Main.qml:114
> +WallpaperFader {
> +visible: false
> +anchors.fill: parent

Disabled now, visually.

> Main.qml:120
> +footer: footer
> +footerBackground: footerBackground
> +}

Dont mess with the clock do mess with the new footer bg.

> Main.qml:456
> +//Footer
> +Rectangle {
> +id: footerBackground

New stuff

> ActionButton.qml:45
> +
> +opacity: activeFocus || containsMouse ? 1 : 0.85
> +Behavior on opacity {

Changed to ensure legibility.

> ActionButton.qml:60
> +color: PlasmaCore.ColorScope.backgroundColor
> +opacity: activeFocus || containsMouse ? 1 : 0.8
> +Behavior on opacity {

Changef to ensure legibility.

> ActionButton.qml:98
> +
> +DropShadow {
> +anchors.fill: label

Added.

> ActionButton.qml:118
> +}
> +color: "white"
> +style: softwareRendering ? Text.Outline : Text.Normal

Cant use black shadows with dark text

> Clock.qml:30
> +text: Qt.formatTime(timeSource.data["Local"]["DateTime"])
> +color: "white"
> +style: softwareRendering ? Text.Outline : Text.Normal

We cannot use black shadows with dark text.

> UserDelegate.qml:47
> +
> +opacity: isCurrent ? 1.0 : 0.6
> +

Increased to ensure legibility

> UserDelegate.qml:63
> +color: PlasmaCore.ColorScope.backgroundColor
> +opacity: 0.8
> +}

Increased to ensure legibilty.

> UserDelegate.qml:120
> +
> +property var colorBorder: PlasmaCore.ColorScope.backgroundColor
> +

Changed from textColor to better fit in.

> UserDelegate.qml:163
> +
> +DropShadow {
> +anchors.fill: usernameDelegate

Didn't exist before.

> UserDelegate.qml:184
> +width: constrainText ? parent.width : implicitWidth
> +color: "white"
> +text: wrapper.name

We cannot use black shadows with dark text.

> WallpaperFader.qml:35
> +property Item footer
> +property Item footerBackground
> +property alias source: wallpaperBlur.source

WallpaperFader no longer deals with the clock since it always needs a shadow. 
It does now have to deal with footer bg.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29765

To: filipf, #vdg, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29765: Add a blurless SDDM theme

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds a blurless SDDM Breeze theme.
  
  The non-default theme is added in order to accomodate users who wish to have 
their wallpaper.
  
  Most of the default theme is just symlinked, while the changes include 
everything necessary to ensure legibility.
  
  As a another feat, dropping blur also enables this theme to drop using 
complementary color schemes, which means it can be fully light or dark as 
opposed to mixing light and dark elements.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-blurless-sddm-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29765

AFFECTED FILES
  CMakeLists.txt
  sddm-theme-blurless/Background.qml
  sddm-theme-blurless/BreezeMenuStyle.qml
  sddm-theme-blurless/KeyboardButton.qml
  sddm-theme-blurless/Login.qml
  sddm-theme-blurless/Main.qml
  sddm-theme-blurless/SessionButton.qml
  sddm-theme-blurless/components/ActionButton.qml
  sddm-theme-blurless/components/Battery.qml
  sddm-theme-blurless/components/Clock.qml
  sddm-theme-blurless/components/KeyboardLayoutButton.qml
  sddm-theme-blurless/components/SessionManagementScreen.qml
  sddm-theme-blurless/components/UserDelegate.qml
  sddm-theme-blurless/components/UserList.qml
  sddm-theme-blurless/components/VirtualKeyboard.qml
  sddm-theme-blurless/components/WallpaperFader.qml
  sddm-theme-blurless/components/artwork
  sddm-theme-blurless/default-logo.svg
  sddm-theme-blurless/dummydata
  sddm-theme-blurless/faces
  sddm-theme-blurless/metadata.desktop
  sddm-theme-blurless/preview.png
  sddm-theme-blurless/preview_dark.png
  sddm-theme-blurless/theme.conf.cmake

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29741: [Logout] Port to QQC2 and PC3

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The logout screen is ported to QtQuick Controls 2 and Plasma Components 3.
  
  See D29740  for a prerequisite patch that 
fixes a bug with PC3 button.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-logout-screen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29741

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:68601675d13b: [sddm-theme] Prevent the logo from leaking 
in after a fadeout (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29351?vs=81910=82765

REVISION DETAIL
  https://phabricator.kde.org/D29351

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29394: Add photographic user avatars

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:13e73011b1ac: Add photographic user avatars (authored by 
filipf).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82748=82762

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  LICENSES/CC0-1.0.txt
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png
  src/pics_sources/Air Balloon.png.license
  src/pics_sources/Astronaut.png.license
  src/pics_sources/Books.png.license
  src/pics_sources/Brushes.png.license
  src/pics_sources/Bulb.png.license
  src/pics_sources/Car.png.license
  src/pics_sources/Cat.png.license
  src/pics_sources/Chamelon.png.license
  src/pics_sources/Cocktail.png.license
  src/pics_sources/Dog.png.license
  src/pics_sources/Fish.png.license
  src/pics_sources/Gamepad.png.license
  src/pics_sources/Owl.png.license
  src/pics_sources/Pancakes.png.license
  src/pics_sources/Parrot.png.license
  src/pics_sources/Pencils.png.license
  src/pics_sources/Shuttle.png.license
  src/pics_sources/Soccer.png.license
  src/pics_sources/Sunflower.png.license
  src/pics_sources/Sushi.png.license

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82748.
filipf added a comment.


  don't delete user_manager.kdev4

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82746=82748

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  LICENSES/CC0-1.0.txt
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png
  src/pics_sources/Air Balloon.png.license
  src/pics_sources/Astronaut.png.license
  src/pics_sources/Books.png.license
  src/pics_sources/Brushes.png.license
  src/pics_sources/Bulb.png.license
  src/pics_sources/Car.png.license
  src/pics_sources/Cat.png.license
  src/pics_sources/Chamelon.png.license
  src/pics_sources/Cocktail.png.license
  src/pics_sources/Dog.png.license
  src/pics_sources/Fish.png.license
  src/pics_sources/Gamepad.png.license
  src/pics_sources/Owl.png.license
  src/pics_sources/Pancakes.png.license
  src/pics_sources/Parrot.png.license
  src/pics_sources/Pencils.png.license
  src/pics_sources/Shuttle.png.license
  src/pics_sources/Soccer.png.license
  src/pics_sources/Sunflower.png.license
  src/pics_sources/Sushi.png.license

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82746.
filipf added a comment.


  Make as REUSE compliant as possible

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82732=82746

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  LICENSES/CC0-1.0.txt
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png
  src/pics_sources/Air Balloon.png.license
  src/pics_sources/Astronaut.png.license
  src/pics_sources/Books.png.license
  src/pics_sources/Brushes.png.license
  src/pics_sources/Bulb.png.license
  src/pics_sources/Car.png.license
  src/pics_sources/Cat.png.license
  src/pics_sources/Chamelon.png.license
  src/pics_sources/Cocktail.png.license
  src/pics_sources/Dog.png.license
  src/pics_sources/Fish.png.license
  src/pics_sources/Gamepad.png.license
  src/pics_sources/Owl.png.license
  src/pics_sources/Pancakes.png.license
  src/pics_sources/Parrot.png.license
  src/pics_sources/Pencils.png.license
  src/pics_sources/Shuttle.png.license
  src/pics_sources/Soccer.png.license
  src/pics_sources/Sunflower.png.license
  src/pics_sources/Sushi.png.license
  user-manager.kdev4

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#670076 , @ngraham wrote:
  
  > The .license files could live in another folder. Maybe `src/pics_sources`?
  
  
  Yeah I can do that as well

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#670030 , @jriddell wrote:
  
  > Looks good for licence freedom
  >
  > Could you make the licence info in format specified at 
https://reuse.software/tutorial/ ?  It's what we want to use from now on in KDE.
  >
  > So add cat.jpg.license files with SPDX header lines saying CC0 and add 
/LICENSES/CC0-1.0.txt
  
  
  I want to go for that format and have tried it but unfortunately the avatar 
gallery has issues with .license files being present
  
  F8316605: IMG_20200513_154909_826.jpg 
  
  It tries to show them even if they're not images.
  
  We should have a new and improved users kcm for 5.20 so I was thinking of 
reworking the licensing structure then.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82732.
filipf added a comment.


  rework licensing stucture due to a flaw in user_manager (it shows every 
single file in the avatar gallery and the .license files break it)

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82697=82732

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png
  src/pics_sources/AUTHORS
  src/pics_sources/COPYING.CC0-1.0.txt

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82697.
filipf added a comment.


  Use this format https://reuse.software/tutorial/ making a LICENCE/ directory 
with the licence text in it and cat.jpg.license with the SPDX header

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82694=82697

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  LICENSES/CC0-1.0.txt
  src/pics/photos/Air Balloon.png
  src/pics/photos/Air Balloon.png.license
  src/pics/photos/Astronaut.png
  src/pics/photos/Astronaut.png.license
  src/pics/photos/Books.png
  src/pics/photos/Books.png.license
  src/pics/photos/Brushes.png
  src/pics/photos/Brushes.png.license
  src/pics/photos/Bulb.png
  src/pics/photos/Bulb.png.license
  src/pics/photos/Car.png
  src/pics/photos/Car.png.license
  src/pics/photos/Cat.png
  src/pics/photos/Cat.png.license
  src/pics/photos/Chameleon.png
  src/pics/photos/Chamelon.png.license
  src/pics/photos/Cocktail.png
  src/pics/photos/Cocktail.png.license
  src/pics/photos/Dog.png
  src/pics/photos/Dog.png.license
  src/pics/photos/Fish.png
  src/pics/photos/Fish.png.license
  src/pics/photos/Gamepad.png
  src/pics/photos/Gamepad.png.license
  src/pics/photos/Owl.png
  src/pics/photos/Owl.png.license
  src/pics/photos/Pancakes.png
  src/pics/photos/Pancakes.png.license
  src/pics/photos/Parrot.png
  src/pics/photos/Parrot.png.license
  src/pics/photos/Pencils.png
  src/pics/photos/Pencils.png.license
  src/pics/photos/Shuttle.png
  src/pics/photos/Shuttle.png.license
  src/pics/photos/Soccer.png
  src/pics/photos/Soccer.png.license
  src/pics/photos/Sunflower.png
  src/pics/photos/Sunflower.png.license
  src/pics/photos/Sushi.png
  src/pics/photos/Sushi.png.license

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82694.
filipf added a comment.


  actually remove Chip and Gecko(due to rename)

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82693=82694

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82693.
filipf added a comment.


  - rename Gecko to Chameleon because that wasn't a gecko
  - remove Chip
  - add Air Balloon, Dog, Fish, Owl, Pencils, Sushi
  - WIP: licence files

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=82662=82693

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Air Balloon.png
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chameleon.png
  src/pics/photos/Chip.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Dog.png
  src/pics/photos/Fish.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Gecko.png
  src/pics/photos/Owl.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Pencils.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png
  src/pics/photos/Sushi.png

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Works well and looks good.

REPOSITORY
  R134 Discover Software Store

BRANCH
  port-to-placeholdermessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29689

To: ngraham, apol, #discover_software_store, #vdg, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

[Filip Fila]

filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ApplicationsListPage.qml:152
> +
> +visible: opacity != 0
> +opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0

Should work without this, no?

> ApplicationsListPage.qml:154
> +opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0
>  Behavior on opacity { PropertyAnimation { duration: 
> Kirigami.Units.longDuration; easing.type: Easing.InOutQuad } }
> +

Probably worth it to port this to NumberAnimation at a different time since 
Marco said it's more efficient.

REPOSITORY
  R134 Discover Software Store

BRANCH
  port-to-placeholdermessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29689

To: ngraham, apol, #discover_software_store, #vdg, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  Some pictures I didn't include in case people like them:
  F8313250: image.png 
  F8313256: image.png 
  
  (yes the Leopard is nice but the circular cropping eats too much into it)
  
  With these licensing issues no longer being a problem, we can now finalize 
this today and tomorrow to avoid doing it during the feature freeze.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 82662.
filipf added a comment.


  - Remove all Unsplash and Pexels licensed photos to avoid complications.
  - Use CC0 pictures from Pexels instead
  - Licence files to be added

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=81955=82662

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Astronaut.png
  src/pics/photos/Books.png
  src/pics/photos/Brushes.png
  src/pics/photos/Bulb.png
  src/pics/photos/Car.png
  src/pics/photos/Cat.png
  src/pics/photos/Chip.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Gecko.png
  src/pics/photos/Pancakes.png
  src/pics/photos/Parrot.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Soccer.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf added a comment.


  Is this okay now @mart and okay to land on 5.18?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  IANAL but the Pexels and Unsplash licence look the same to me: free to 
distribute, free to modify, no attribution needed, but don't use it to make a 
Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS 
licence database. I'll just ask everyone to do CC0 but we'll still credit them. 
Thanks @ognarb and @jriddell.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf added a comment.


  If user data would show low vertical panel usage, what are we really fixing 
and for who? Extrapolating from that and presuming that a fair share of them 
are content with the current default, why do we go against that? And if it's 
just a matter of not touching defaults, can you guarantee users are going to be 
equally content with a left panel as a default?
  
  It seems to me this would boil down to touch usage. (My hunch is most people 
don't care too much about saving some vertical pixels). We're still only 
talking about a smaller subset of users, who we could equally benefit by 
finishing D27845 , which is less risky.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: davidedmundson, ahiemstra, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  After additional consideration, I'm not too happy with the car avatar but I 
did find this:
  
  F8292121: Screenshot_20200507_090804.png 

  
  Speaking of licences, I assume I can leave the CC0 ones at CC0, while the 
rest should be CC-BY-SA 4.0 as per KDE licencing policy for images?

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf added a comment.


  I'd also be interested if #kde_promo 
 has any insights here. It doesn't 
seem (?) like we advertise it too much, but I know reviews often praise Plasma 
for its familiarity for Windows users. Given our major competitor does the 
opposite and that the majority of our new users are going to be Windows 
converts (and keeping in mind that the less technologically able people tend to 
not like unfamiliarity), it seems like a good market share to grab. Changing 
the layout could mean a boost for other competitors such as Zorin. Thoughts?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: broulik, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  This is a major identity change better suited for Plasma 6. We've never had a 
vertical panel and are moreover defined by offering a layout familiar to 
Windows users.
  
  Switching to it would also require user data. How many users use a vertical 
panel? Anecdotal evidence isn't enough, and we shouldn't be using developers as 
a sample for the whole userbase.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29448: Add "Volna" wallpaper

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  We only use the biggest size in this repo.

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D29448

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Reword inline message concerning widget locking

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:52d3389f7495: [Wallpaper Configuration] Reword inline 
message concerning widget locking (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29366?vs=81911=81958

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma, ngraham
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf added a comment.


  Should I also land this for 5.18 (do I have to create a bug report first)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 81955.
filipf added a comment.


  Drop:
  
  - Air Balloon
  - Gamepad
  
  Add:
  
  - Architecture
  - Food
  - Chalk
  
  Change:
  
  - Embiggen the leopard

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=81839=81955

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Architecture.png
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Chalk.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Food.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/Rubik's Cube.png
  src/pics/photos/Snail.png
  src/pics/photos/Space Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#663012 , @ngraham wrote:
  
  > Great, that works. I suppose there's no point in fixing that bug since this 
KCM is being re-done anyway in D28154 . 
Once this lands, @cblack can grab these and add them to that patch.
  
  
  Yeah I would agree. The user gallery in the current KCM is also something 
that should be improved (bigger previews, two lines of text) but no point in 
fiddling with it.
  
  > However I see duplicates for the space shuttle, hot air balloon, and 
Rubik's cube.
  
  Yeah I renamed those after the first revision so they're leftovers.
  
  > This is an improvement, for sure. But what happened to the noodle bowl? I 
loved that one!
  
  Which one in T9910 ? We can still add some 
more avatars IMO.
  
  > I can't help but notice that a lot of these images are sort of de-saturated 
or sepia-toned. I feel like a bit more saturation would make them pop better.
  
  I definitely have to replace the air baloon pic, it's the worst one 
saturation-wise.
  
  > The gamepad image is quite dark and low contrast. It's kind of hard to see 
the gamepad itself: F8283812: Screenshot_20200504_081738.png 

  
  Indeed, the problem with gamepads was finding a pic that doesn't have a logo. 
It's possible the Rubik's cube and the keyboard suffice for nerds, but I'll try 
to find something else related to gaming.
  
  > The Leopard image is great, but maybe it could be zoomed in a bit so the 
leopard takes up more of the frame? It's kinda tiny: F8283809: 
Screenshot_20200504_081717.png 
  
  Will do in the next revision.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf updated this revision to Diff 81911.
filipf added a comment.


  restore the inline message but change its text to note that layout changes 
have been restricted by the sysadmin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29366?vs=81756=81911

BRANCH
  remove-obsolete-inline-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf updated this revision to Diff 81910.
filipf marked an inline comment as done.
filipf added a comment.


  Replace PropertyAnimation with NumberAnimation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29351?vs=81709=81910

BRANCH
  no-logo-leak (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29351

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#662776 , @ognarb wrote:
  
  > Photo using the Unsplash license can't be included in our repositories. The 
license is not considered open-source :( We should contact the artists if they 
are willing to license their photographies under a creative commons license 
(not the noncommercial and the no edit one)
  
  
  T9910#229073 

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 81839.
filipf added a comment.


  probably don't want to include the .directory file

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=81838=81839

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Balloon.png
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/Rubik's Cube.png
  src/pics/photos/Space Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 81838.
filipf added a comment.


  Better file naming

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=81829=81838

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  .directory
  src/pics/photos/Balloon.png
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Gamepad.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/Rubik's Cube.png
  src/pics/photos/Space Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  Alright, I believe the issue is with the fact that the avatar gallery is 
coded to always look for avatars in the system `/usr/share` dir as opposed to 
adjusting to testing conditions and using the local `/usr/share` dir.
  
  `sudo cp -r kde/usr/share/user-manager/avatars/photos/ 
/usr/share/user-manager/avatars/`
  
  And now they show up, despite using the locally installed user-manager. If we 
used the workflow where kdesrc-build installs directly to system the patch 
//should// work and consequently IRL as well.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  The permissions are wrong if we do `sudo make install` (the photos folder 
ends up being root owned). But it doesn't show up with `make install` either. 
Will investigate more in the morning.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf created this revision.
filipf added reviewers: VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds 12 photographic avatars in order to finish work on T9910 
.
  
  Sylistically they are simple and with only a single topic in focus.
  
  Sizes are 512x512, the formats .png. They've tested with our circular avatar 
template and cropped to fit it well.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Cocktail.png
  src/pics/photos/HotAirBalloon.png
  src/pics/photos/Joystick.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/RubixCube.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  Sources:
  
  Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels 
licence)
  Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ 
(CC0 licence)
  Car: 
https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974 (CC0 
licence)
  Cocktail: https://www.pexels.com/photo/sea-sky-beach-holiday-68672/ (CC0)
  HotAirBalloon: 
https://www.pexels.com/photo/hot-air-balloon-on-mid-air-above-rock-formation-2893960/
 (Pexels licence)
  Joystick: https://www.pexels.com/photo/game-controller-159204/ (CC0 licence)
  Keyboard: https://unsplash.com/photos/WzKPT0IuUrU (Unsplash licence)
  Leopard: https://unsplash.com/photos/wYy3rvvgjAU (Unsplash licence)
  Parrot: https://unsplash.com/photos/V9VDd-2s3aE (Unsplash licence)
  RubikCube: https://unsplash.com/photos/liMvhbUq4Xg (Unsplash licence)
  Sunflower: https://unsplash.com/photos/XtXdHH-Ib7c (Unsplash licence)
  Shuttle: https://www.pexels.com/photo/flight-sky-earth-space-2159/ (CC0 
licence)

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

[Filip Fila]

filipf added a comment.


  In D22700#662134 , @guoyunhe wrote:
  
  > When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  >
  > F8280985: IMG_20200503_152810.jpg 
  
  
  -dpi 144 works the same for me in Plasma and SDDM, but do file a bug under 
systemsettings->kcm_sddm and copy paste what you have in 
`/etc/sddm.conf.d/kde_settings.conf`. I'll investigate.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight 
behind the icon (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81796=81809

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf updated this revision to Diff 81796.
filipf added a comment.


  move the code change to CurrentItemHighlight.qml

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81785=81796

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  There was a slight issue introduced with D28109 
: the systray highlight can now cover up 
the icons it's highlighting.
  
  This isn't really an issue with Breeze because it uses a line for a 
highlight, but it is for themes that use a filled-style highlight.
  
  I set a z value for the highlight that should ensure it's now drawn only 
behind the icon.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf added a comment.


  Ok, so the message can indeed still be turned on.
  
  Setting:
  `~/.config/plasmarc [General] immutability=2 (or 4)`
  
  ... does not work, however the following does:
  
  `~/.config/kdeglobals [KDE Action Restrictions][$i] 
plasma/plasmashell/unlockedDesktop=false`
  
  Which means that if widget locking now only exists as a restriction... 
perhaps it would make more sense to change the text of this inline message to 
say "Layout changes have been restricted by the system administrator"?
  Otherwise telling a restricted user that widgets are locked isn't helpful 
since they can't (and shouldn't) unlock their widgets?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf added a comment.


  In D29366#661834 , @ngraham wrote:
  
  > Technically it still does exist, it's just hidden. If a person does enable 
this, perhaps the message is still nice to have? Or maybe we should not show it 
because the expectation would be that your admin/technically competent grandson 
has enabled it for your own good and this shouldn't be highlighted?
  
  
  Hmm if it still exists then we probably want to leave it because it doesn't 
make not being able to change the desktop layout look like a bug. How to enable 
widget locking currently though?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf created this revision.
filipf added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Widget locking no longer exists so we can remove the inline message that 
warned of locked widgets.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-obsolete-inline-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Filip Fila]

filipf added a comment.


  Yeah we shouldn't be mixing Kirigami with Plasma.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf updated this revision to Diff 81709.
filipf added a comment.


  Ditch OpacityAnimator and use PropertyAnimation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29351?vs=81707=81709

BRANCH
  no-logo-leak (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29351

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf added a comment.


  This kills the animation though... I found this comment in other code:
  "//OpacityAnimator when starting from 0 is buggy (it shows one frame with 
opacity 1)"
  
  I'm able to get this opacity fading effect though without the bug if I switch 
from using OpacityAnimator to PropertyAnimator.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Even when the vendor logo is turned off it can be briefly seen when the login 
screen changes from the fadeout state back into normal.
  
  The cause it probably that opacity animator doesn't like it when the 'from' 
and 'to' opacity values are set outside it.
  
  This patch removes the opacity properties, which makes the logo no longer 
show up.
  
  There's also a minor fix included - placing the drop shadow sooner in the 
hierarchy because it should be drawn underneath an object, not in front of it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no-logo-leak (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29351

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Filip Fila]

filipf added a comment.


  Yeah, this is also an issue when clicking cancel on a password prompt in 
sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling 
theme deletion an empty inline message pops up :/
  
  We could work around all four though. I'm of the opinion that it's better to 
have a workaround if waiting for a proper fix will take time. I also agree with 
@ngraham that no notification is needed when an auth dialog is canceled.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29307: Implement smallFont in Kirigami plugin

[Filip Fila]

filipf added a comment.


  How does this relate to D14562 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D29307

To: cblack, #kirigami
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26636: [Widget Explorer] Work around bad kerning

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26636

To: filipf, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29264: New tabs for Breeze

[Filip Fila]

filipf added a comment.


  I think we still want to have the edges rounded if it's possible?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: filipf, ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Filip Fila]

filipf updated this revision to Diff 80582.
filipf added a comment.


  remove the separator instead of just shortening it

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25728?vs=70873=80582

BRANCH
  no-unwanted-titlebar-separator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25728

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #plasma, #vdg
Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Filip Fila]

filipf added a comment.


  I guess the top separator should be removed altogether then? (As opposed to 
just shortening it)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: RFC: Use more compact OSD

[Filip Fila]

filipf added a comment.


  I still like osds as notifications but I agree with @alexde, a vertical osd 
in the corner opposite (?) to where notifications spawn would be visually more 
pleasing than what is proposed in this patch and should even get in the way 
less.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Filip Fila]

filipf added a comment.


  In D25728#576703 , @ngraham wrote:
  
  > Maybe what we should do is change the titlebar separator color in Breeze to 
be a pleasant dark gray like in the screenshot in @flipwise's latest comment 
instead of a garish blue, turn it on by default, and remove this here. Then for 
Plasma 6 (or whenever we do the proposed Breeze evolution) we can revisit that 
implementation and come up with something smarter.
  
  
  
  
  In D25728#640374 , @Codezela wrote:
  
  > In D25728#572044 , @filipf wrote:
  >
  > > In D25728#572043 , 
@anthonyfieroni wrote:
  > >
  > > > So with the patch is it drawn when it is ticked in window decoration?
  > >
  > >
  > > Yes. With the patch there is only a top separator on the sidebar, not 
between the titlebar and window.
  > >
  > > Then you can turn on KWin's separator and get this:
  > >
  > > F7798893: image.png 
  > >
  > > TBH the top sidebar separator should ideally be disabled when KWin's 
separator is on.
  >
  >
  > Iam sry to ask this
  >  I know it's not the right place to ask this
  >  What is this icon themes you use
  >  I will delete this comment soon
  >  Sry again
  
  
  Don't use Phabricator for these purposes in the future. There is 
#kde-chat@freenode or https://t.me/kdechat
  
  The icon theme is: https://github.com/Nitrux/luv-icon-theme

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: Codezela, manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Filip Fila]

filipf added a comment.


  Can you explain why we want this? It's going to be visually prominent so we 
need a good reason.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28154: Add users KCM

[Filip Fila]

filipf added a comment.


  I'm strongly in favor of removing the autologin option from this KCM. The 
option only applies to SDDM so it should be in SDDM's settings.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28054: Made window backgroun color lighter

[Filip Fila]

filipf added a comment.


  I already prepared this sort of a patch while ago because I believe the 
Breeze color schemes should have more contrast in order to look more modern.
  
  I chose 243, 244, 245 as the new color though since I still wanted to keep it 
different from the view color.
  
  This (249, 249, 249) looks fine but I'd suggest to tone the new color down 
just a little bit to avoid complaints.
  
  I'd also suggest to see where else the old color is used and replace it. This 
means more changes in this particular file and then all over KDE.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28054

To: niccolove, #vdg
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> layout.js:28
> +// For an Icons-Only Task Manager on the bottom, *3 is too much, *2 is too 
> little
> +panel.height = Math.round(gridUnit * 2.5)
>  

can we do `Math.round(gridUnit * 2.25)` or at least `Math.round(gridUnit * 
2.33)` ?

That's about 41px and 42px respectively, and shouldn't stand out us a huge 
change from what we had or look awfully big on PCs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: filipf, kmaterka, gvgeo, davidedmundson, ndavis, KonqiDragon, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27870: [applets/systemtray] Right align popup heading when in RTL mode

[Filip Fila]

filipf added a comment.


  In D27870#622843 , @ngraham wrote:
  
  > Feels like this should be set by default in the `Heading` item, or else 
we'll be doing this everywhere, no?
  
  
  Sounds like a better solution. I'm not sure if it would interfere with some 
weird use case though?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27870

To: filipf, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27870: [applets/systemtray] Right align popup heading when in RTL mode

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  In RTL modes headings should be on the right, not on the left as is currently 
the case.
  
  Filling the layout's width is not enough so we'll set a left aligned 
horizontal policy for the headings, which gets mirrored into a right aligned 
one in RTL.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  heading-on-the-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27870

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Good stuff

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  In D27608#621705 , @gvgeo wrote:
  
  > Strange, I don't get the resizing problem as it is now, or in master. Only 
managed to get this space by changing the theme, and was immediately fixed with 
resize.
  >
  > Thanks Filip for double checking.
  
  
  No problem. It needs to be a specific kind of resize action I guess.
  
  F8149051: RTLresize 
  
  I'm using Kvantum but I can make it with happen Breeze as well. We probably 
also need to change heading so it's aligned to the right, but both of these 
things are material for a different patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Fixes the regression. It's still possible to get this when resizing, but it 
was actually already like that before this patch.
  
  F8149023: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  Seems to run pretty well, but there is a tiny padding regression introduced.
  
  Using `plasmashell --reverse --replace` to test a right to left layout we see 
that there is excessive padding between the content and the sidebar.
  
  F8148094: image.png 
  
  I.e. there is more padding than when using a left to right layout, and when 
resizing the window the padding actually increases some more (to level that's 
shown in the screenshot)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27679: [emojier] Set minimum window height and width

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0247bf56954: [emojier] Set minimum window height and 
width (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27679?vs=76468=76541

REVISION DETAIL
  https://phabricator.kde.org/D27679

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

To: filipf, apol, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27679: [emojier] Set minimum window height and width

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  There are two problems right now with the emojier's window:
  
  - when shrinking the window a scrollbar is drawn *over* the category drawer's 
icons
  - the whole window can be shrunk to be only 1px wide and only several pixels 
tall
  
  To solve both issues this patch sets a minimum height that is equal to the 
height of the category drawer's content, thereby removing the possibility of a 
scrollbar appearing. Minimum width is then set to be somewhat bigger than 
minimum height to account for monitor aspect ratios.
  
  In practice this amounts to about 465x370 on a 1080p screen.
  
  BUG: 418195
  FIXED-IN: 5.18.3

REPOSITORY
  R119 Plasma Desktop

BRANCH
  emojier-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27679

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27667: Align wallpaper dialog button to bottom

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:541d8adc5f14: Align wallpaper dialog button to bottom 
(authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27667?vs=76431=76443

REVISION DETAIL
  https://phabricator.kde.org/D27667

AFFECTED FILES
  src/ui/themeconfig.ui

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27667: Align wallpaper dialog to bottom

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Align wallpaper dialog to bottom instead of vertically centering it between 
the theme info and the bottom of the frame.
  
  BUG: 418173
  FIXED-IN: 5.19

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  anchor-thumbnail-to-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27667

AFFECTED FILES
  src/ui/themeconfig.ui

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  Looks good to me and solves 3 of the 4 binding loops, although this one still 
remains:
  
  
`file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/configuration/AppletConfiguration.qml:296:25:
 QML StackView: Binding loop detected for property "height"`

INLINE COMMENTS

> gvgeo wrote in AppletConfiguration.qml:117
> I can make this side to draw on top of the separator, as it was. Will be 
> incorrect again.
> 
> Maybe separator must leave. It looks nice for breeze dark, but if the theme 
> says no line, why force it? It is not forced in system settings. And despite 
> if it looks okay or not for most setups, it is wrong to display for all 
> themes.

> Maybe separator must leave

I agree. I already tried doing it in D25728 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:b2d0e463a490: Have user-manager write to SDDMs new 
config file (authored by filipf).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26813?vs=75007=75861

REVISION DETAIL
  https://phabricator.kde.org/D26813

AFFECTED FILES
  src/lib/accountmodel.cpp

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27461: Sync Plasma theme settings instead of copying the plasmarc file

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:138
> +QSharedPointer themeConfig = 
> openConfig(themeConfigLocation);
> +
> themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"),
>  args[QStringLiteral("plasmaTheme")].toString());
> +const char* themeConfigLocationConverted = 
> themeConfigLocation.toLocal8Bit().data();

do I need to do `themeConfig->sync`? It seems to work as intended without it, 
even when just updating the entry.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27461

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27461: Sync Plasma theme settings instead of copying the plasmarc file

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The first and the easiest part of finishing T12710 
.
  
  Instead of copying the user's plasmarc file in order to have SDDM use their 
Plasma theme, we read the user value and create the SDDM user's config 
ourselves.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  safer-plasmarc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27461

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

[Filip Fila]

filipf added a comment.


  For 5.18.1 though maybe we could just roll this version out?

REPOSITORY
  R128 User Manager

BRANCH
  write-autologin-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26813

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Filip Fila]

filipf added a comment.


  copy paste from Telegram
  
  > fwiw I like units.smallSpacing / 2 more but it's not that big of a 
difference

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: filipf, ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27388: Fix being unable to set the right permissions for kde_settings.conf

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:cc33ec575c5e: Fix being unable to set the right 
permissions for kde_settings.conf (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27388?vs=75653=75763

REVISION DETAIL
  https://phabricator.kde.org/D27388

AFFECTED FILES
  sddmauthhelper.cpp

To: filipf, davidedmundson
Cc: plasma-devel, ngraham, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27418: Don't let the Advanced tab's spacers expand all they want

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:26022caf9a2a: Dont let the Advanced tabs 
spacers expand all they want (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27418?vs=75728=75729

REVISION DETAIL
  https://phabricator.kde.org/D27418

AFFECTED FILES
  src/ui/advancedconfig.ui

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27418: Don't let the Advanced tab's spacers expand all they want

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We have 3 vertical spacers in the Advanced tab and their defined as Expanding.
  
  So that means they become quite the gaps if the window is expanded.
  
  This patch changes their size policy to Preffered to avoid such a feature.
  
  BUG: 417657

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  dont-stretch-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27418

AFFECTED FILES
  src/ui/advancedconfig.ui

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27388: Fix being unable to set the right permissions for kde_settings.conf

[Filip Fila]

filipf updated this revision to Diff 75653.
filipf added a comment.


  Fix the permissions for people who have already had the file created with the 
wrong permissions

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27388?vs=75651=75653

BRANCH
  fix-config-file-permissions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27388

AFFECTED FILES
  sddmauthhelper.cpp

To: filipf, davidedmundson
Cc: plasma-devel, ngraham, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27360: Go back to saving to sddm.conf

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Thanks to @davidedmundson's input we found out the cause, so fixed in: D27388 


REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27360

To: filipf, davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27388: Fix being unable to set the right permissions for kde_settings.conf

[Filip Fila]

filipf created this revision.
filipf added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  If we are creating a config file and its directory doesn't exist, we fail to 
set the right permissions for the file.
  
  This affects kde_settings.conf and results in the KCM not being able to read 
stored settings.
  
  BUG: 414396
  CC-BUG: 342722
  FIXED-IN: 5.18.1

TEST PLAN
  rm-rf sddm.conf.d 
  save settings in the kcm in various ways
  kde_settings.conf is now world readable agian

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  fix-config-file-permissions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27388

AFFECTED FILES
  sddmauthhelper.cpp

To: filipf, davidedmundson
Cc: plasma-devel, ngraham, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27360: Go back to saving to sddm.conf

[Filip Fila]

filipf added a comment.


  In D27360#611155 , @davidedmundson 
wrote:
  
  > > The SDDM KCM is broken right now because the kde_settings.conf file is 
never created with the right permissions. This means that the KCM can't read 
the settings file.
  >
  > that doesn't match the bug report.
  >
  > The bug report shows it does have the right permissions. I'm not quite sure 
what he is trying to say the bug is.
  
  
  The bug report is a  bit all over the place, and it started out as something 
different so disregard most of the posts there.
  
  I've been at this for some time and the core issue is that 
`kde_settings.conf` is not world-readable like `sddm.conf` is. The settings are 
being written but only SDDM can read them, no one else.
  
  By all accounts the `openConfig` variable in `sddmauthelper.cpp` should set 
`kde_settings.conf`'s permissions like it does for `sddm.conf`.
  
  I can get it to make `kde_settings.conf` world-readable if I remove the 
`!file.exists` check but what's mind-boggling is this still doesn't work when 
`advancedconfig.cpp` i.e. the Advanced tab is in charge of generating 
`kde_settings.conf` so even adding some code that would set the correct 
permissions if it detects wrong one wouldn't solve the issue 100%.
  
  I've also tried defining `kde_settings.conf` in `config.h` and CMake but that 
didn't help.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27360

To: filipf, davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27360: Go back to saving to sddm.conf

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The SDDM KCM is broken right now because the kde_settings.conf file is never 
created with the right permissions. This means that the KCM can't read the 
settings file.
  
  I've tried several things to fix it but have unfortunately failed. So that 
leaves me with reverting the change to save to kde_settings.conf and with going 
back to saving to sddm.conf.
  
  This is also revelant to user-manager since it can't read SDDM's file either.
  
  BUG: 414396
  CC-BUG: 342722
  FIXED-IN: 5.18.1

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  revert-new-save-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27360

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp
  src/themeconfig.cpp

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Filip Fila]

filipf added a comment.


  In D27329#609851 , @ngraham wrote:
  
  > That's better, though I dunno, I can't shake the feeling that the album art 
is still too compressed.
  
  
  Me too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

[Filip Fila]

filipf added a comment.


  The added vertical padding looks good to me, but I don't like how the 
horizontal paddding now makes these labels no longer aligned with the tooltip 
heading.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27303

To: ngraham, #vdg, manueljlin
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Filip Fila]

filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ToolTipInstance.qml:123
>  opacity: 0.75
> -visible: !hasPlayer && text.length !== 0
> +visible: !hasPlayer && text.length !== 0 && text != 
> appNameHeading.text
>  }

I think they want us using !== now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on 
its own (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27142?vs=75005=75309

REVISION DETAIL
  https://phabricator.kde.org/D27142

AFFECTED FILES
  sddmauthhelper.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

filipf added a comment.


  5.18 then, right?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  decoupled-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in accountmodel.cpp:45
> ideally we want the exact same code as the other place
> 
> load /etc/sddm.conf
> loop through /etc/sddm.conf.d
> add all those files as config sources

Seems doable, just not sure what to have this config line here open. I copied 
the old code but it won't let me open the 'mSddmConfig' config.

REPOSITORY
  R128 User Manager

BRANCH
  write-autologin-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26813

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27144: Moved toggles to the bottom according to T10470

[Filip Fila]

filipf added a comment.


  In D27144#605649 , @ngraham wrote:
  
  > Now when Bluetooth is on but there are no devices, the applet looks like 
this:
  >
  > F8083748: Screenshot_20200203_150046.png 

  >
  > This popup should really be written with layouts instead of anchors; then 
it would be trivial to just add an item in the middle with `Layout.fillWidth: 
true` in it. As-is, you'll need to approximate that with anchors.
  >
  > Or you could rewrite it with Layouts first, and then do this afterwards.
  >
  > Your call.
  
  
  That's what I see as well.

INLINE COMMENTS

> Toolbar.qml:34
> +PlasmaCore.SvgItem {
> +id: headerSeparator
> +anchors {

don't need the id

> Toolbar.qml:35
> +id: headerSeparator
> +anchors {
> +top: parent.top

you can just do `anchors.top: ` since it's only 1 anchor

> Toolbar.qml:42
> +svg: PlasmaCore.Svg {
> +id: headerSeparatorLine
> +imagePath: "widgets/line"

probably better to call it toolbarSeparator or footerSeparator here

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27144

To: niccolove, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27143: moved do not disturb to the bottom

[Filip Fila]

filipf added a comment.


  just a minor thing I noticed, rest looks good

INLINE COMMENTS

> FullRepresentation.qml:422
>  }
> +
> +PlasmaCore.SvgItem {

added row is fine but there are 4 spaces added here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bottom_notification_options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27143

To: niccolove, ngraham, broulik, #plasma
Cc: filipf, gvgeo, plasma-devel, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart