Re: Review Request 105779: plasma calendar - order events and todos by start date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/ --- (Updated Aug. 31, 2015, 11:02 a.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 291422 http://bugs.kde.org/show_bug.cgi?id=291422 Repository: kde-workspace Description --- QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time. Diffs - libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105779/diff/ Testing --- works for me Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105924: plasma calendar - event system config option
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105924/ --- (Updated July 29, 2014, 9:32 a.m.) Status -- This change has been discarded. Review request for Plasma and Anne-Marie Mahfouf. Bugs: 281464 http://bugs.kde.org/show_bug.cgi?id=281464 Repository: kde-workspace Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 106448: replace old kickoff with kickoff-qml
/simpleapplet/simpleapplet.cpp 28fba18a1cddbd9be58991b35dba69fb60e4416c plasma/desktop/applets/kickoff/ui/brandingbutton.h 698b34e50372dddc3db9425ab2ac639cf90d49b7 plasma/desktop/applets/kickoff/ui/brandingbutton.cpp 5cd8829b8a6cae1e07cbf9bffd3abe77b7f9104e plasma/desktop/applets/kickoff/ui/contentareacap.h 58b37ec74834eefd969786ec99a5cf25b27baf5c plasma/desktop/applets/kickoff/ui/contentareacap.cpp 45e0e2052720402451ae00bed05f6bb0598ec0b3 plasma/desktop/applets/kickoff/ui/contextmenufactory.h a4c3017b537aa12369b08f7fffb28addcca6bce4 plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp afa666ac8dfaf6c746d165d7d662fab185af4442 plasma/desktop/applets/kickoff/ui/flipscrollview.h e7eba0939237c686ff1ca6c0d4c5a6c924ff26d6 plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 1d48f5b4562c230db7d8b6d8d578e5a09cd9e2c4 plasma/desktop/applets/kickoff/ui/itemdelegate.h bf79e2cc1f501e7136decfa7cd05ea651b109cf6 plasma/desktop/applets/kickoff/ui/itemdelegate.cpp 3b15dd2e7a6ceaba66e1e7da27a811ea8ec31c2f plasma/desktop/applets/kickoff/ui/launcher.h 2a234c36d6fe320cc8021d074156ba2299158e4f plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc79daff81f2448d19a75f3feb69dd57543 plasma/desktop/applets/kickoff/ui/searchbar.h 60aa9b4b3faaafd5484a36a819b8ac0ed5683a9a plasma/desktop/applets/kickoff/ui/searchbar.cpp 1af8fa95e3497e50cba629c2086a9fb381a166ff plasma/desktop/applets/kickoff/ui/tabbar.h c9281059d35255902fd6d3ed91c5171a44421a51 plasma/desktop/applets/kickoff/ui/tabbar.cpp 43fe16b723ab2010bd02864a911d2d2c8d106821 plasma/desktop/applets/kickoff/ui/urlitemview.h 285227a40b71065a0219c33293c955df3c5c518b plasma/desktop/applets/kickoff/ui/urlitemview.cpp 892b85be96695d7d71d4494af92dae794cb86d66 plasma/generic/dataengines/packagekit/CMakeLists.txt PRE-CREATION plasma/generic/dataengines/packagekit/packagekit.operations PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 111087: widget-taskbar: vertical text layout
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111087/ --- Review request for Plasma. Description --- welcome to the taskbar bug marathon ;) this change corrects the issue reported in the report. the diff is trivial (though I think the tasklabel code is silly and too complex) but I'm not sure if I can approve the aesthetic consequences (see screenshot): the text moves slightly to the top of the label area, but imho relative to the vertically centered icon widget it looks misplaced. What do you think? This addresses bug 314879. http://bugs.kde.org/show_bug.cgi?id=314879 Diffs - plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d621c2917665fb963c0087f3a59c9e86e9 Diff: http://git.reviewboard.kde.org/r/111087/diff/ Testing --- File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109124: qml port currentappcontrol
On Feb. 26, 2013, 1:36 p.m., Aaron J. Seigo wrote:
- If you click on the title on the task bar, it doesn't show the kwin
present windows effect, how to implement that? Is there interest in a 'kwin
dataengine' or should I go for a mixed C++/QML applet?
a WindowSystem qml import would probably be the trick here, and it should
be designed with the kwin team.
- there is an annoyance in the task list(present windows fallback): I can
set a minimum height, but if I close a task and re-set the minimum height,
the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
as other users of this do shrink, my guess without looking would be that it
is a QML issue and the item is not actually getting resized.
- the close/restore buttons don't glow on hover. I couldn't load a theme
svg using the IconItem. Is that possible?
you can load an icon file from the svg theme and specify the element to
use, e.g.: source: svgname-elementname
- do you know how to read the size of the containment the widget is
contained?
no, and this should never be required.
- - there is an annoyance in the task list(present windows fallback): I can set
a minimum height, but if I close a task and re-set the minimum height, the
popup won't shrink again, leaving an unpleasant empty space; plasma bug?
- as other users of this do shrink, my guess without looking would be that it
is a QML issue and the item is not actually getting resized.
I've checked my qml code with a onMinimumHeightChanged handler and the size is
set correctly. Well, now I've set maximumHeight to minimumHeight. That does the
trick!
- you can load an icon file from the svg theme and specify the element to use,
e.g.: source: svgname-elementname
After checking IconItem source, I don't even begin to understand how that can
work. First of all it splits for '-' and would try to load
'widgets/configuration' which doesn't even exist
i.e.: source: widgets/configuration-icons-maximize
- - do you know how to read the size of the containment the widget is contained?
- no, and this should never be required.
sorry for providing insufficient data, but how would you implement this:
const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 +
fm.width('M')*30), containment()-size().width()/4);
on small screens the compactRepresentation of currentappcontrol shouldn't take
the whole panel width
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/#review28133
---
On Feb. 25, 2013, 6:20 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/
---
(Updated Feb. 25, 2013, 6:20 p.m.)
Review request for Plasma.
Description
---
Heya folks,
This is a qml port of the netbook applet currentappcontrol. It's ready to
use, but not fully complete.
Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present
windows effect, how to implement that? Is there interest in a 'kwin
dataengine' or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set
a minimum height, but if I close a task and re-set the minimum height, the
popup won't shrink again, leaving an unpleasant empty space; plasma bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg
using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?
Diffs
-
CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857
plasma/netbook/applets/currentappcontrol/CMakeLists.txt
46178ce3a9351845855e9fccfbc13a9d3946fc95
plasma/netbook/applets/currentappcontrol/Messages.sh
45d44681ae1be43b2d71ca48ab3e77af37ad8861
plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml
PRE-CREATION
plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml
PRE-CREATION
plasma/netbook/applets/currentappcontrol/package/metadata.desktop
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109124/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109124: qml port currentappcontrol
On Feb. 26, 2013, 1:36 p.m., Aaron J. Seigo wrote:
- If you click on the title on the task bar, it doesn't show the kwin
present windows effect, how to implement that? Is there interest in a 'kwin
dataengine' or should I go for a mixed C++/QML applet?
a WindowSystem qml import would probably be the trick here, and it should
be designed with the kwin team.
- there is an annoyance in the task list(present windows fallback): I can
set a minimum height, but if I close a task and re-set the minimum height,
the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
as other users of this do shrink, my guess without looking would be that it
is a QML issue and the item is not actually getting resized.
- the close/restore buttons don't glow on hover. I couldn't load a theme
svg using the IconItem. Is that possible?
you can load an icon file from the svg theme and specify the element to
use, e.g.: source: svgname-elementname
- do you know how to read the size of the containment the widget is
contained?
no, and this should never be required.
Greg T wrote:
- - there is an annoyance in the task list(present windows fallback): I
can set a minimum height, but if I close a task and re-set the minimum
height, the popup won't shrink again, leaving an unpleasant empty space;
plasma bug?
- as other users of this do shrink, my guess without looking would be
that it is a QML issue and the item is not actually getting resized.
I've checked my qml code with a onMinimumHeightChanged handler and the
size is set correctly. Well, now I've set maximumHeight to minimumHeight.
That does the trick!
- you can load an icon file from the svg theme and specify the element to
use, e.g.: source: svgname-elementname
After checking IconItem source, I don't even begin to understand how that
can work. First of all it splits for '-' and would try to load
'widgets/configuration' which doesn't even exist
i.e.: source: widgets/configuration-icons-maximize
- - do you know how to read the size of the containment the widget is
contained?
- no, and this should never be required.
sorry for providing insufficient data, but how would you implement this:
const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 +
fm.width('M')*30), containment()-size().width()/4);
on small screens the compactRepresentation of currentappcontrol shouldn't
take the whole panel width
Kai Uwe Broulik wrote:
Concerning the svg stuff, load the SVG like so:
PlasmaCore.Svg {
id: configurationIconsSvg
imagePath: widgets/configuration-icons
}
and then you can use
svg: configurationIconsSvg
elementId: maximize
to access it
that's right, I'm doing this right now. You can even write it more compact:
PlasmaCore.SvgItem {
anchors.fill: parent
elementId: maximize
svg: PlasmaCore.Svg {
imagePath: widgets/configuration-icons
}
}
What's your point?
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/#review28133
---
On Feb. 25, 2013, 6:20 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/
---
(Updated Feb. 25, 2013, 6:20 p.m.)
Review request for Plasma.
Description
---
Heya folks,
This is a qml port of the netbook applet currentappcontrol. It's ready to
use, but not fully complete.
Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present
windows effect, how to implement that? Is there interest in a 'kwin
dataengine' or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set
a minimum height, but if I close a task and re-set the minimum height, the
popup won't shrink again, leaving an unpleasant empty space; plasma bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg
using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?
Diffs
-
CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857
plasma/netbook/applets/currentappcontrol/CMakeLists.txt
46178ce3a9351845855e9fccfbc13a9d3946fc95
plasma/netbook/applets/currentappcontrol/Messages.sh
45d44681ae1be43b2d71ca48ab3e77af37ad8861
plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml
PRE-CREATION
plasma/netbook/applets
Re: Review Request 109124: qml port currentappcontrol
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/ --- (Updated Feb. 25, 2013, 6:20 p.m.) Review request for Plasma. Changes --- boo-boos fixed. the main issues are still present, see top. help appreciated! Description --- Heya folks, This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete. Missing features/bugs: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? - do you know how to read the size of the containment the widget is contained? Diffs (updated) - CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 plasma/netbook/applets/currentappcontrol/Messages.sh 45d44681ae1be43b2d71ca48ab3e77af37ad8861 plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109124: qml port currentappcontrol
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/ --- Review request for Plasma. Description --- Heya folks, This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete. Missing features/bugs: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? - do you know how to read the size of the containment the widget is contained? Diffs - plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109124: qml port currentappcontrol
On Feb. 24, 2013, 12:27 p.m., Kai Uwe Broulik wrote: - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? Quoting from Marco Martin's blog: You should not use it when your icon is actually meant to be a standalone clickable button. in this case you should either Button or ToolButton from org.kde.plasma.components. This should also make the glow work automgaically The definition of Button/ToolButton doesn't really apply here. The task buttons right to the title are not 'standalone', so the border around the image looks silly. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/#review27958 --- On Feb. 24, 2013, 11:10 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/ --- (Updated Feb. 24, 2013, 11:10 a.m.) Review request for Plasma. Description --- Heya folks, This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete. Missing features/bugs: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? - do you know how to read the size of the containment the widget is contained? Diffs - plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 106448: replace old kickoff with kickoff-qml
On Feb. 8, 2013, 10:16 p.m., Albert Astals Cid wrote: What is the status of this? Are you guys still working on it? Needs improvements? Can be commited? Should be discarded? It's been 3 months without activity! nope, there has been made some progress in the last months. Just see the ml or the repository. kickoff-qml still needs some ui polish (tab bar, branding area). help is always welcome ;) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review27017 --- On Oct. 21, 2012, 10:23 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 21, 2012, 10:23 a.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068143d84f9e25dedc8 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f492eb94bf489d87314e1 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415d64204c795075e16c23e883c plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f42ed57c7c9a6668d5d53b plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2 plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff84bfff65d48bec336afbd plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml
Re: Review Request 106448: replace old kickoff with kickoff-qml
On Feb. 8, 2013, 10:16 p.m., Albert Astals Cid wrote: What is the status of this? Are you guys still working on it? Needs improvements? Can be commited? Should be discarded? It's been 3 months without activity! Greg T wrote: nope, there has been made some progress in the last months. Just see the ml or the repository. kickoff-qml still needs some ui polish (tab bar, branding area). help is always welcome ;) Albert Astals Cid wrote: Not sure what the answer means regarding this Review Request. Should we: a) Keep Open as is b) Discard it c) Mark it as Submitted I'm only trying to keep reviewboard clean now I understand your question ;) - keep it - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review27017 --- On Oct. 21, 2012, 10:23 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 21, 2012, 10:23 a.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068143d84f9e25dedc8 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f492eb94bf489d87314e1 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415d64204c795075e16c23e883c plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f42ed57c7c9a6668d5d53b plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2 plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff84bfff65d48bec336afbd plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core
Review Request: plasmoid currentappconrol - max width of dropdown
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107433/ --- Review request for Plasma. Description --- the drop down list gets too wide (see screenshot), when the window titles are too long or the horizontal space is very small. In the patch I've elided the text width to ~80% of the screen width. Or is there a more natural solution? Diffs - plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp 5c2e73f9d6b8207efd3a3de6464278d1bdbc9263 Diff: http://git.reviewboard.kde.org/r/107433/diff/ Testing --- Screenshots --- dropdown http://git.reviewboard.kde.org/r/107433/s/850/ Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid currentappconrol - max width of dropdown
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107433/ --- (Updated Nov. 23, 2012, 10:27 a.m.) Review request for Plasma. Description --- the drop down list gets too wide (see screenshot), when the window titles are too long or the horizontal space is very small. In the patch I've elided the text width to ~80% of the screen width. Or is there a more natural solution? Diffs - plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp 5c2e73f9d6b8207efd3a3de6464278d1bdbc9263 Diff: http://git.reviewboard.kde.org/r/107433/diff/ Testing --- Screenshots --- dropdown http://git.reviewboard.kde.org/r/107433/s/850/ Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- Review request for Plasma. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:21 p.m.) Review request for Plasma and Dario Freddi. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:43 p.m.) Review request for Plasma, Dario Freddi and Lukáš Tinkl. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal
On Nov. 21, 2012, 7:07 p.m., Kai Uwe Broulik wrote: But why does the battery plasmoid always set the old brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid? the brightness property in the plasmoid is fed by 2 sources: the slider value in the popup and the dataengine. the qml code is a bit special because it watches both sources for changes and sets the new brightness accordingly. I've never figured out when and why the widget took the wrong/not updated value from the dataengine. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22339 --- On Nov. 21, 2012, 5:43 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:43 p.m.) Review request for Plasma, Dario Freddi and Lukáš Tinkl. Description --- the upower powerdevilbackend doesnt emit a screenBrightnessChanged signal when you change the brightness without the brightnessKeys. I've just moved the signal to the setBrightness function. Now the powermanagement/PowerDevil dataengine gets also updated properly with the current brightness (this fixes the bugs). This addresses bugs 302111 and 302160. http://bugs.kde.org/show_bug.cgi?id=302111 http://bugs.kde.org/show_bug.cgi?id=302160 Diffs - powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21387 --- Ship it! If kickoff doesn't fade, kickoff-qml shouldn't fade too - Greg T On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
28fba18a1cddbd9be58991b35dba69fb60e4416c plasma/desktop/applets/kickoff/ui/brandingbutton.h 698b34e50372dddc3db9425ab2ac639cf90d49b7 plasma/desktop/applets/kickoff/ui/brandingbutton.cpp 5cd8829b8a6cae1e07cbf9bffd3abe77b7f9104e plasma/desktop/applets/kickoff/ui/contentareacap.h 58b37ec74834eefd969786ec99a5cf25b27baf5c plasma/desktop/applets/kickoff/ui/contentareacap.cpp 45e0e2052720402451ae00bed05f6bb0598ec0b3 plasma/desktop/applets/kickoff/ui/contextmenufactory.h a4c3017b537aa12369b08f7fffb28addcca6bce4 plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp afa666ac8dfaf6c746d165d7d662fab185af4442 plasma/desktop/applets/kickoff/ui/flipscrollview.h e7eba0939237c686ff1ca6c0d4c5a6c924ff26d6 plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 1d48f5b4562c230db7d8b6d8d578e5a09cd9e2c4 plasma/desktop/applets/kickoff/ui/itemdelegate.h bf79e2cc1f501e7136decfa7cd05ea651b109cf6 plasma/desktop/applets/kickoff/ui/itemdelegate.cpp 3b15dd2e7a6ceaba66e1e7da27a811ea8ec31c2f plasma/desktop/applets/kickoff/ui/launcher.h 2a234c36d6fe320cc8021d074156ba2299158e4f plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc79daff81f2448d19a75f3feb69dd57543 plasma/desktop/applets/kickoff/ui/searchbar.h 60aa9b4b3faaafd5484a36a819b8ac0ed5683a9a plasma/desktop/applets/kickoff/ui/searchbar.cpp 1af8fa95e3497e50cba629c2086a9fb381a166ff plasma/desktop/applets/kickoff/ui/tabbar.h c9281059d35255902fd6d3ed91c5171a44421a51 plasma/desktop/applets/kickoff/ui/tabbar.cpp 43fe16b723ab2010bd02864a911d2d2c8d106821 plasma/desktop/applets/kickoff/ui/urlitemview.h 285227a40b71065a0219c33293c955df3c5c518b plasma/desktop/applets/kickoff/ui/urlitemview.cpp 892b85be96695d7d71d4494af92dae794cb86d66 plasma/generic/dataengines/packagekit/CMakeLists.txt PRE-CREATION plasma/generic/dataengines/packagekit/packagekit.operations PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
On Oct. 19, 2012, 7:47 p.m., Richard Stockton wrote: One tiny nit about the appearance of the search bar and trademark area: It is like it was in 4.9, very transparent. Upon first resize, however, the background of this area changes into a soft gray -- which IMO, is much easier on the eyes and more professional. (I vote to initialize it in the same way it is painted AFTER a resize). that's odd. the background shouldn't change in any way on resize - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20586 --- On Oct. 21, 2012, 10:23 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 21, 2012, 10:23 a.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068143d84f9e25dedc8 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f492eb94bf489d87314e1 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415d64204c795075e16c23e883c plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f42ed57c7c9a6668d5d53b plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2 plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff84bfff65d48bec336afbd plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop
Re: Review Request: replace old kickoff with kickoff-qml
/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106947/#review20575 --- looks good, just a couple of notes: why are you installing 2 desktop files for the kickoff launcher: - metadata.desktop and the old plasma-applet-launcher.desktop - we don't need CMakeLists.txt in core/ anymore? - also it conflicts with my last commit in kickoff-qml (just a minor in kickoff.qml) - Greg T On Oct. 19, 2012, 1:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106947/ --- (Updated Oct. 19, 2012, 1:04 p.m.) Review request for Plasma. Description --- this makes the simple laucher work again, and since kickoff is in part c++, the menu editor option as well as the switch from kickoff to classic works again. main reason of this tough is to eliminate the org.kde.kickoff import, that shouldn't be public api Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt 4f61700 plasma/desktop/applets/kickoff/applet/applet.h f3afe73 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 4d0e218 plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml f953565 plasma/desktop/applets/kickoff/package/metadata.desktop 9cb997d plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 963c18b plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 Diff: http://git.reviewboard.kde.org/r/106947/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: any updates on this? what are the major blocker still remaining for a merge? well, to summarize it: - classic menu broken - some minor functionality missing - martin didn't tested it? I think we can address those points also post-review. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review19954 --- On Sept. 20, 2012, 4:10 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Sept. 20, 2012, 4:10 p.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - ksplash/ksplashqml/SplashWindow.cpp 94e6dedfddcac20516686a7a3b30651d48bc26e7 plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 14e35cdced82384f0cdf86caec9a4045bfaf2912 plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 31467acc6654decb2800cf9a5acc398ccaaeccc7 plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h b04a7871883edd5ea7281d9853ec9203ce019894 plasma/desktop/applets/kickoff/core/systemmodel.cpp cb9bf650bab36c6415d37db795e766b743d5e25d plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/config/main.xml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml PRE-CREATION plasma/desktop/applets/kickoff/package
Review Request: plasma-desktop: restore toolbox position
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106743/ --- Review request for Plasma. Description --- this patch looks trivial, but I get the bad feeling that this change could cause regressions. What was the purpose of that early exit in the first place? This addresses bug 263947. http://bugs.kde.org/show_bug.cgi?id=263947 Diffs - plasma/desktop/toolboxes/internaltoolbox.cpp b62370e8a428087bb7671b60632e8fe458d1ee67 Diff: http://git.reviewboard.kde.org/r/106743/diff/ Testing --- no issues noted Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: any updates on this? what are the major blocker still remaining for a merge? Greg T wrote: well, to summarize it: - classic menu broken - some minor functionality missing - martin didn't tested it? I think we can address those points also post-review. Martin Gräßlin wrote: How badly is the classic menu broken? I assume it does not compile any more, right? My personal opinion would be to pass it to the community, kind of The KDE Classic Menu Needs You! (Uncle Sam image) Marco Martin wrote: and is perfectly fine for the classic menu to stay c++ btw, since there is (almost) no qgraphicsview involved yeah, it doesn't compile. Though I didn't try it really hard. But great idea! Can you post it on your famous blog? I'm sure there will be a lot of resonance. I also think we can flag that as a junior job. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review19954 --- On Sept. 20, 2012, 4:10 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Sept. 20, 2012, 4:10 p.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - ksplash/ksplashqml/SplashWindow.cpp 94e6dedfddcac20516686a7a3b30651d48bc26e7 plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 14e35cdced82384f0cdf86caec9a4045bfaf2912 plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 31467acc6654decb2800cf9a5acc398ccaaeccc7 plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h b04a7871883edd5ea7281d9853ec9203ce019894 plasma/desktop/applets/kickoff/core/systemmodel.cpp cb9bf650bab36c6415d37db795e766b743d5e25d plasma/desktop/applets/kickoff/core
Review Request: plasma-netbook: add a settings action to the panel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106723/ --- Review request for Plasma. Description --- This context menu option does the same thing like the cashew in the bottom corner: it opens the shell settings. My initial plan was to just open the panel toolbox...but the current implementation doesn't really seem to allow that. Diffs - plasma/netbook/containments/netpanel/panel.h 970bf3c0e60915f49dc7318a9789bf9cd0830b59 plasma/netbook/containments/netpanel/panel.cpp a53eb5f642b5102719bf11329b1a5c5be1c13c99 plasma/netbook/shell/plasmaapp.cpp 22c54b2ba9e746e85eb7c581ebee26e3ba63b459 Diff: http://git.reviewboard.kde.org/r/106723/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Use Product instead of description for device names
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19614 --- What will happen if the device name is invalid i.e. empty. Do we handle this case somewhere in the model? - Greg T On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/ --- (Updated Sept. 29, 2012, 8:21 p.m.) Review request for Plasma and Viranch Mehta. Description --- The description is useful for when the device is not hotpluggable/removeable, for example to show: 96.3 GiB Hard Drive 15.1 GiB Hard Drive instead of two identical labels. But when it comes to removable/hotpluggable we want to show the Product to be able to show: Nokia N9 Nexus 7 Instead of Portable Media Player Portable Media Player The difference can be shown also in the attached screenshots. Diffs - plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml b23df45 Diff: http://git.reviewboard.kde.org/r/106637/diff/ Testing --- Screenshots --- before http://git.reviewboard.kde.org/r/106637/s/743/ after http://git.reviewboard.kde.org/r/106637/s/744/ Thanks, Alex Fiestas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: replace old kickoff with kickoff-qml
On Sept. 15, 2012, midnight, Daniel Nicoletti wrote: Hi, I took a quick look over the diffs and using search I could not find what I was looking so let me question you :) Kickoff-C++ has context menus, used to add applications to favorites, clean history, and the feature I added Uninstall applications using PackageKit. From what I know about QML (not recent plasma API changed) there's no way to create top level windows to be used as a context menu, so I'm curious since you said it has feature parity how did you created this feature or that's still a missing thing? Best good point, the 'uninstall app' function is missing, too. You can find the context menu stuff in plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml I'm just using contextMenu from plasmacomponents. The trick is to call menu.open(x, y) with the right coordinates. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review18978 --- On Sept. 14, 2012, 7:04 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Sept. 14, 2012, 7:04 p.m.) Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - ksplash/ksplashqml/SplashWindow.cpp 94e6dedfddcac20516686a7a3b30651d48bc26e7 plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 14e35cdced82384f0cdf86caec9a4045bfaf2912 plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 31467acc6654decb2800cf9a5acc398ccaaeccc7 plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h b04a7871883edd5ea7281d9853ec9203ce019894 plasma/desktop/applets/kickoff/core/systemmodel.cpp cb9bf650bab36c6415d37db795e766b743d5e25d plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp
Re: Review Request: replace old kickoff with kickoff-qml
/packagekit/packagekitengine.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: replace old kickoff with kickoff-qml
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- Review request for Plasma and Martin Gräßlin. Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - ksplash/ksplashqml/SplashWindow.cpp 94e6dedfddcac20516686a7a3b30651d48bc26e7 plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 14e35cdced82384f0cdf86caec9a4045bfaf2912 plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 31467acc6654decb2800cf9a5acc398ccaaeccc7 plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h b04a7871883edd5ea7281d9853ec9203ce019894 plasma/desktop/applets/kickoff/core/systemmodel.cpp cb9bf650bab36c6415d37db795e766b743d5e25d plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/config/main.xml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/config.ui PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml PRE-CREATION plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 9:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 9:20 a.m.) Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Changes --- add mgrasselin Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Greg T wrote: Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... Marco Martin wrote: idea: 1) create a dataengine called org.kde.appshortcuts or something like that every source would represent a shortcut (even if just the desktop file name) 2) it has a service to add or remove shortcuts 3) the taskbar is connected to that engine and uses it for its own shortcuts would mean that: * would add shortcuts in the taskbar (and any other plasmoid connected to that) rather than directly the panel, so would need at least one connected to work * add to desktop is not supported anymore and i think is good, too many assumption on what desktop it is and where it is ;) interesting, but for clarification: the idea is to add those app shortcuts as launchers to the task manager? But lets get kickoff into master before working on this topic :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 10:58 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)
On Aug. 31, 2012, 7:49 a.m., Albert Astals Cid wrote: This has been commited late for 4.9.1 tagging (6 hours late) and without a shipit from anyone in the reviewboard, so I'm not that eager to redo the tarballs. Can anyone convince me otherwise? (You have 6 hours for that) whoops, too late. So I have to adjust the fixed-in field in bugzilla to 4.9.2 Thanks for pointing this out anyway. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18309 --- On Aug. 26, 2012, 3:52 p.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 26, 2012, 3:52 p.m.) Review request for Plasma, Lamarque Vieira Souza and Ivan Čukić. Description --- Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/104422/ and https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when the feature (RFE bug 276932) is added to 4.9 and Trunk. This addresses bugs 276932 and 297842. http://bugs.kde.org/show_bug.cgi?id=276932 http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106125/diff/ Testing --- #1 Arrow key movement among programs in the flipscrollview (Right, back to Left, and Up/Down). Activbation of highlighted/selected programs. #2 Search bar entry, movement into View of matches using the Tab key. Move among multiple matching prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the search to be modified; and it is highlighted, allowing the search text to be deleted. #3 an empty search text field re-shows the tab bar and flipscrollview; tab selection is again enabled via left/right arrow keys. NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient knowledge of where you came from, and often tries to send your keystroke to an invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) IS appropriate. But it works sort of. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)
On Aug. 26, 2012, 7:50 a.m., Greg T wrote: besides the points mentioned in review 106125, you have to remember that KDE 4.8 is already EOL and there will be no more bugfix release (i.e. 4.8.6). Richard Stockton wrote: Yes, but I was asked to put it on the 4.8 tree in case a packager wants to pick it up for a Distro patch, e.g. 4.8.5-19. Lamarque Vieira Souza wrote: Well, I do not use 4.8x anymore, this patch does not apply to 4.9 so I cannot test it. Would you provide a patch for 4.9 branch? He already did. See review 106125 - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/#review18015 --- On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/ --- (Updated Aug. 22, 2012, 9:06 p.m.) Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Description --- Fix for Kickoff-Widget Keyboard Navigation enhancement (review request 104422): Following enhancement, when a 'search' is performed, the UI became unable to move among the views. This patch enables Qt::Key_Tab to (a) enter into the search Results View, where a program may be selected; (b) move back into the search bar TextEdit widget, by pressing Key_Tab twice; and (c) re-expose the other views, by pressing Key_Tab once (highlighting all text within the seearch bar TextEdit widget), and then pressing Key_Delete to empty the TextEdit field. When the textEdit is empty, the flipscrollview (e.g., Applications) replaces the Search Results View, and the User is back to the Initial State of the Kickoff-Widget GUI. This addresses bug 297842. http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 902e121 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106123/diff/ Testing --- 1: search with multiple search results: Tab enters the results view, and arrow keys can choose from multiple results. Key_Enter does run the selected Application. Per above, Key_Tab returns to the search TextEdit, with existing contents pre-selected/Highlighted. 2. search with empty results: arrow keys do nothing. Tab key returns to the search TextEdit, as in Test #1. 3. When search TextEdit contains no text (via Key_Delete when highlighted, or pressing Key_Delete multiple times) the Initial State of the views is restored: (Tab Bar, Serch Bar, and the selected Tab content present and executable. 4. Key_Escape closes the Kickoff UI, without executing a program. 5. Inability to use Up/Down arrows to go between Views is unfortunate, but remains unchanged from before. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18014 --- Review: This doesn't really fix 297842, or does it? If I understand the reporter correctly, he wants to move with Up/Down keys in the search view as soon as he enters a search query. With your patch applied I still have to hit the tab key first. Can you set the focus automatically on the view? - Greg T On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 23, 2012, 12:28 a.m.) Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Description --- Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/104422/ and https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when the feature (RFE bug 276932) is added to 4.9 and Trunk. This addresses bugs 276932 and 297842. http://bugs.kde.org/show_bug.cgi?id=276932 http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106125/diff/ Testing --- #1 Arrow key movement among programs in the flipscrollview (Right, back to Left, and Up/Down). Activbation of highlighted/selected programs. #2 Search bar entry, movement into View of matches using the Tab key. Move among multiple matching prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the search to be modified; and it is highlighted, allowing the search text to be deleted. #3 an empty search text field re-shows the tab bar and flipscrollview; tab selection is again enabled via left/right arrow keys. NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient knowledge of where you came from, and often tries to send your keystroke to an invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) IS appropriate. But it works sort of. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)
On Aug. 23, 2012, 2:53 p.m., Greg T wrote: I think this time we can get kickoff-qml into kde 4.10. But this is no reason to push this fix not into master :) Richard Stockton wrote: Thanks, Greg! I think we both plan this method for managing the two modules, please advise if I am no correct: First, right now, this Update goes to Trunk AND 4.9 because kickoff-widget has not yet been removed from Trunk. (Trunk shold contain our best code, with all fixes.) When kickoff-qml is done, and completely replaces kickoff-widget: then it's maintainer should Update 4.10 branch (if already branched off) AND master, removing kickoff-widget entirely. That will avoid a 4.10 or later occurence of the bug which I allowed to re-appear in 4.9, by assuming that kickoff-qml would replace kickoff-widget within 4.9. Removal of Kickoff-widget will be a happy day for everyone - and me, especially. :) sounds like a plan :) And your welcome to hack on kickoff-qml as well - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review17903 --- On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 23, 2012, 12:28 a.m.) Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Description --- Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/104422/ and https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when the feature (RFE bug 276932) is added to 4.9 and Trunk. This addresses bugs 276932 and 297842. http://bugs.kde.org/show_bug.cgi?id=276932 http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106125/diff/ Testing --- #1 Arrow key movement among programs in the flipscrollview (Right, back to Left, and Up/Down). Activbation of highlighted/selected programs. #2 Search bar entry, movement into View of matches using the Tab key. Move among multiple matching prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the search to be modified; and it is highlighted, allowing the search text to be deleted. #3 an empty search text field re-shows the tab bar and flipscrollview; tab selection is again enabled via left/right arrow keys. NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient knowledge of where you came from, and often tries to send your keystroke to an invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) IS appropriate. But it works sort of. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/#review18015 --- besides the points mentioned in review 106125, you have to remember that KDE 4.8 is already EOL and there will be no more bugfix release (i.e. 4.8.6). - Greg T On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/ --- (Updated Aug. 22, 2012, 9:06 p.m.) Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Description --- Fix for Kickoff-Widget Keyboard Navigation enhancement (review request 104422): Following enhancement, when a 'search' is performed, the UI became unable to move among the views. This patch enables Qt::Key_Tab to (a) enter into the search Results View, where a program may be selected; (b) move back into the search bar TextEdit widget, by pressing Key_Tab twice; and (c) re-expose the other views, by pressing Key_Tab once (highlighting all text within the seearch bar TextEdit widget), and then pressing Key_Delete to empty the TextEdit field. When the textEdit is empty, the flipscrollview (e.g., Applications) replaces the Search Results View, and the User is back to the Initial State of the Kickoff-Widget GUI. This addresses bug 297842. http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 902e121 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106123/diff/ Testing --- 1: search with multiple search results: Tab enters the results view, and arrow keys can choose from multiple results. Key_Enter does run the selected Application. Per above, Key_Tab returns to the search TextEdit, with existing contents pre-selected/Highlighted. 2. search with empty results: arrow keys do nothing. Tab key returns to the search TextEdit, as in Test #1. 3. When search TextEdit contains no text (via Key_Delete when highlighted, or pressing Key_Delete multiple times) the Initial State of the views is restored: (Tab Bar, Serch Bar, and the selected Tab content present and executable. 4. Key_Escape closes the Kickoff UI, without executing a program. 5. Inability to use Up/Down arrows to go between Views is unfortunate, but remains unchanged from before. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasmoid digital-clock - layout bug in small vertical panels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106223/ --- Review request for Plasma. Description --- Fix this little bug they said, it will be fun they said... Well, practically this code is unreviewable but it would be great if you would test this patch against regressions in the layout. For me it's not working worse than before in a vertical/horziontal panel and on the desktop. This addresses bug 252291. http://bugs.kde.org/show_bug.cgi?id=252291 Diffs - plasma/generic/applets/digital-clock/clock.h f4822ec plasma/generic/applets/digital-clock/clock.cpp 1331776 Diff: http://git.reviewboard.kde.org/r/106223/diff/ Testing --- issue fixed, using long date. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review17903 --- I think this time we can get kickoff-qml into kde 4.10. But this is no reason to push this fix not into master :) - Greg T On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 23, 2012, 12:28 a.m.) Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Description --- Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/104422/ and https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when the feature (RFE bug 276932) is added to 4.9 and Trunk. This addresses bugs 276932 and 297842. http://bugs.kde.org/show_bug.cgi?id=276932 http://bugs.kde.org/show_bug.cgi?id=297842 Diffs - plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 Diff: http://git.reviewboard.kde.org/r/106125/diff/ Testing --- #1 Arrow key movement among programs in the flipscrollview (Right, back to Left, and Up/Down). Activbation of highlighted/selected programs. #2 Search bar entry, movement into View of matches using the Tab key. Move among multiple matching prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the search to be modified; and it is highlighted, allowing the search text to be deleted. #3 an empty search text field re-shows the tab bar and flipscrollview; tab selection is again enabled via left/right arrow keys. NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient knowledge of where you came from, and often tries to send your keystroke to an invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) IS appropriate. But it works sort of. Thanks, Richard Stockton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: digital clock widget - popup focus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105933/ --- (Updated Aug. 20, 2012, 6:07 p.m.) Review request for Plasma and John Layt. Description --- For some reason for this widgt the option setPassivePopup is enabled (probably because you can't control it with keyboard anyways). Interestingly, the result is that the popup doesn't hide if you, for example, open the settings dialog. This behaviour is a bug and not consistent with all other popup widgets. I suppose this fixes also https://bugs.kde.org/show_bug.cgi?id=221301 On the other hand, we could also try to fix that passive popup feature, if it's broken...I don't know. This addresses bug 221301. http://bugs.kde.org/show_bug.cgi?id=221301 Diffs - plasma/generic/applets/digital-clock/clock.cpp 1331776 Diff: http://git.reviewboard.kde.org/r/105933/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasma calendar - disable event system config
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- Review request for Plasma and Anne-Marie Mahfouf. Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma calendar - event system config option
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- (Updated Aug. 8, 2012, 7:35 a.m.) Review request for Plasma and Anne-Marie Mahfouf. Summary (updated) - plasma calendar - event system config option Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma calendar - event system config option
On Aug. 8, 2012, 8:30 a.m., John Layt wrote: Sorry, but I disagree. The separate config settings are for specific technical reasons, due to previous user feedback, and for backwards compatibility purposes. We have two config settings for Events and Holidays due to Events turning on Akonadi which many people don't want to use but still want to have Holidays displayed. Until we have a proper solution to the Akonadi problem we have to retain the separate config options. In any case, the solution would be in modifying the behaviour of the GUI, not in changing the backend config. We used to have separate tick-boxes in the GUI directly mapped to the config options, but I changed the Holidays tick-box to the multiple holidays selection widget and had to retain the backwards compatible behaviour of respecting any existing config setting. You also have the usability issue of people ticking the Holiday options but not the Event box and wondering why the Holidays don't show, you would need to change the GUI to make this obvious. Also, you seem to have other unrelated code fixes included in the review? Well, of course we could grey out the holiday selection, if display events is unticked. In the current implementation I think it's awkward that you have to scroll through the entire list and disable every region to hide all events. Maybe a extra tick-box for that really would be better. In this case we could also split up the pim event box into options for every kind of event (todos, events, journals). Actually I don't understand why there is this holiday setting in the widget at all. This holiday calender needs to be merged into akonadi, so the widget show exactly the same events like i.e. korganizer. We have already a Birthday akonadi ressource. Why not simply create a holiday ressource? I could do that, I suppose. What dou you think? That unrelated code is from https://git.reviewboard.kde.org/r/105779/ feel free to review it :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/#review17095 --- On Aug. 8, 2012, 7:35 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- (Updated Aug. 8, 2012, 7:35 a.m.) Review request for Plasma and Anne-Marie Mahfouf. Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasma calendar - order events and todos by start date
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105779/ --- Review request for Plasma. Description --- QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time. This addresses bug 291422. http://bugs.kde.org/show_bug.cgi?id=291422 Diffs - libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105779/diff/ Testing --- works for me Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: add keyboard nav to konsoleprofiles widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make sure kmenuedit use predictable order for showing Name and Description between various invocations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/#review16574 --- Ship it! Ship It! - Greg T On July 28, 2012, 1:11 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/ --- (Updated July 28, 2012, 1:11 p.m.) Review request for Plasma. Description --- The cause is simple: two flags m_detailedMenuEntries and m_detailedEntriesNamesFirst are never explicitly initialized. So their values are random, and the final results are unpredictable. The patch simply initializes both as true, since that seems to be the default behavior of kickoff. The git history shows those two flags seem to be something left over from the KDE3 era. Maybe they should just be removed from the code. However, I'm not familiar with the code and the history, so this simple patch should be safe choice. This addresses bug 304177. http://bugs.kde.org/show_bug.cgi?id=304177 Diffs - kmenuedit/treeview.cpp 54feff7 Diff: http://git.reviewboard.kde.org/r/105769/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
On July 28, 2012, 4:06 p.m., Shaun Reich wrote: Ship It! Shaun Reich wrote: Looks good. Think you could also propagate this to the Kate and Konsole widgets? I can also add this to konqprofiles. I don't know what konsole widgets you are referring to. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff-qml: TabBar button width
On July 19, 2012, 9:04 a.m., Marco Martin wrote: thanks, wouldn;t have remembered ;) the changes seems good, but i'm not sure about giving kickoff a copy of the tabbar. any reason this is not proposed as a patch for the tabbar component itself? Greg T wrote: Of course I could do that. But I didn't know if such a general change would be welcome. Maybe people love equally sized blocks? Marco Martin wrote: i really think we shouldn't start to customize the components in a single applet like that. what could be done is: as implicit width of the tabbar should be a width such that all tabs have the same width that is the one of the largest tab, so by default it would attempt to never elide (probably some work in the bindings is needed to export this as preferred width of the applet). if it's forced to be smaller it starts to elide the text. I'm not sure if I can follow you, but basically you describe the current behavior. Every TabButton got a 'implicitHeight: label.paintedHeight' and the layout calculates a minimum implicitWidth that doesn't elide text. The export is missing, though. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 --- On July 1, 2012, 8:42 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/ --- (Updated July 1, 2012, 8:42 p.m.) Review request for Plasma, Marco Martin and Martin Gräßlin. Description --- Heda, This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width. I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml? Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 Diff: http://git.reviewboard.kde.org/r/105405/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff-qml: TabBar button width
On July 3, 2012, 8:34 a.m., Martin Gräßlin wrote: please push it again after Akademy - I doubt that I find the time to properly read through it in this week well *push* :) any ideas? - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review15332 --- On July 1, 2012, 8:42 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/ --- (Updated July 1, 2012, 8:42 p.m.) Review request for Plasma, Marco Martin and Martin Gräßlin. Description --- Heda, This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width. I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml? Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 Diff: http://git.reviewboard.kde.org/r/105405/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff-qml: TabBar button width
On July 19, 2012, 9:04 a.m., Marco Martin wrote: thanks, wouldn;t have remembered ;) the changes seems good, but i'm not sure about giving kickoff a copy of the tabbar. any reason this is not proposed as a patch for the tabbar component itself? Of course I could do that. But I didn't know if such a general change would be welcome. Maybe people love equally sized blocks? - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 --- On July 1, 2012, 8:42 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/ --- (Updated July 1, 2012, 8:42 p.m.) Review request for Plasma, Marco Martin and Martin Gräßlin. Description --- Heda, This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width. I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml? Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 Diff: http://git.reviewboard.kde.org/r/105405/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix the wrong usage of Keywords in one .dekstop file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review15869 --- Ship it! Ship It! - Greg T On July 13, 2012, 2:49 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated July 13, 2012, 2:49 p.m.) Review request for Plasma. Description --- It is similar to review 105553. According to the FDO specification[1][2], the type of Keywords is localestring(s), where multiple values are separated by a semicolon. The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for X-KDE-Keywords, but not for Keywords. The patch simply uses semicolon and adds the trailing semicolon. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html Diffs - applets/microblog/plasma-applet-microblog.desktop b8d3864 Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fixed duplication of timezone displayed at tooltip
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105550/#review15874 --- Ship it! Ship It! - Greg T On July 13, 2012, 11:52 a.m., Reza Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105550/ --- (Updated July 13, 2012, 11:52 a.m.) Review request for Plasma. Description --- fixed duplication of timezone displayed at tooltip as described in: https://bugs.kde.org/show_bug.cgi?id=303325 This addresses bug 303325. http://bugs.kde.org/show_bug.cgi?id=303325 Diffs - libs/plasmaclock/clockapplet.cpp d47bbfd Diff: http://git.reviewboard.kde.org/r/105550/diff/ Testing --- testing against master Thanks, Reza Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix the wrong usage of Keywords in one .dekstop file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review15859 --- Why didn't you replace the commas in the localized keyword entrys? - Greg T On July 13, 2012, 2:49 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated July 13, 2012, 2:49 p.m.) Review request for Plasma. Description --- It is similar to review 105553. According to the FDO specification[1][2], the type of Keywords is localestring(s), where multiple values are separated by a semicolon. The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for X-KDE-Keywords, but not for Keywords. The patch simply uses semicolon and adds the trailing semicolon. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html Diffs - applets/microblog/plasma-applet-microblog.desktop b8d3864 Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote: Items= is no longer used. individual entries are. so this review is not correct. the prefered items are also indeed removable. that was fixed a while back. are you using kde-workspace from master or some older branch or...? Greg T wrote: ah, I see. Nope, I'm using plain master and that bug is definitely *not* fixed. The preferred filemanager and browser icons keep reappaering on login. The function GroupManagerPrivate::unsaveLauncher can't remove that config entrys because the name of the launcher is i.e. 'firefox' but never 'browser' well, I have updated the patch 1 week ago, +1/-1? :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/#review15230 --- On June 28, 2012, 7:03 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/ --- (Updated June 28, 2012, 7:03 p.m.) Review request for Plasma. Description --- libtaskmanager can't remove those (browser, preferred://browser, , , ) entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request. This addresses bug 278724. http://bugs.kde.org/show_bug.cgi?id=278724 Diffs - libs/taskmanager/groupmanager.cpp 5ca0159 Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing --- no regressions noted. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: added minimum size to 'show activities' plasmoid at desktop
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105473/#review15533 --- Ship it! Ship It! - Greg T On July 7, 2012, 2:11 p.m., Reza Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105473/ --- (Updated July 7, 2012, 2:11 p.m.) Review request for Plasma and Greg T. Description --- Trying to fix https://bugs.kde.org/show_bug.cgi?id=301527, by adding minimum size for 'show activities' plasmoid. i will commit the diff to KDE/4.9 and master. This addresses bug 301527. http://bugs.kde.org/show_bug.cgi?id=301527 Diffs - plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml 4dba01a Diff: http://git.reviewboard.kde.org/r/105473/diff/ Testing --- tested against master Thanks, Reza Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105340/#review15316 --- Ship it! Ship It! - Greg T On June 29, 2012, 11:38 a.m., Reza Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105340/ --- (Updated June 29, 2012, 11:38 a.m.) Review request for Plasma and Marco Martin. Description --- There is a bug which prevent widget explorer or activity manager not closed when clicking desktop area above panel. Steps to reproduce: - after login and with no window appear (we can see desktop area clearly). - open widget explorer from panel - then click at desktop area somewhere above the panel. The expected result is widget explorer or activity manager will be closed. Diffs - plasma/desktop/shell/controllerwindow.cpp 306a152 Diff: http://git.reviewboard.kde.org/r/105340/diff/ Testing --- test against master branch. Thanks, Reza Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: kickoff-qml: TabBar button width
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/ --- Review request for Plasma, Marco Martin and Martin Gräßlin. Description --- Heda, This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width. I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml? Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 Diff: http://git.reviewboard.kde.org/r/105405/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: change default config of taskmanager
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/ --- Review request for Plasma. Description --- libtaskmanager can't remove those (browser, preferred://browser, , , ) entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request. This addresses bug 278724. http://bugs.kde.org/show_bug.cgi?id=278724 Diffs - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js afd1f2c Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing --- no regressions noted. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote: Items= is no longer used. individual entries are. so this review is not correct. the prefered items are also indeed removable. that was fixed a while back. are you using kde-workspace from master or some older branch or...? ah, I see. Nope, I'm using plain master and that bug is definitely *not* fixed. The preferred filemanager and browser icons keep reappaering on login. The function GroupManagerPrivate::unsaveLauncher can't remove that config entrys because the name of the launcher is i.e. 'firefox' but never 'browser' - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/#review15230 --- On June 28, 2012, 3:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/ --- (Updated June 28, 2012, 3:48 p.m.) Review request for Plasma. Description --- libtaskmanager can't remove those (browser, preferred://browser, , , ) entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request. This addresses bug 278724. http://bugs.kde.org/show_bug.cgi?id=278724 Diffs - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js afd1f2c Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing --- no regressions noted. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/ --- (Updated June 28, 2012, 7:03 p.m.) Review request for Plasma. Changes --- Entirely new patch...that preferred application stuff feels like a hack. Description --- libtaskmanager can't remove those (browser, preferred://browser, , , ) entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request. This addresses bug 278724. http://bugs.kde.org/show_bug.cgi?id=278724 Diffs (updated) - libs/taskmanager/groupmanager.cpp 5ca0159 Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing --- no regressions noted. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently
On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote: Ship It! Johannes Tröscher wrote: i'm not that experienced with git.. i've pushed it to master, could you backport it to 4.9? i don't know how to push single commits I suggest you to use 'git cherry-pick' for that task. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105375/#review15231 --- On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105375/ --- (Updated June 28, 2012, 3:40 p.m.) Review request for Plasma and Aaron J. Seigo. Description --- this is mostly visible with dark-themes only. as of now the text color got only changed when the hover-element was fully visible. this looked a bit weird. this patch adds a ColorAnimation with the same duration as the opacity-animation on the hover-element as Behavior for the Label. now the color changes fluently on hovering the ToolButton Diffs - plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 Diff: http://git.reviewboard.kde.org/r/105375/diff/ Testing --- tested, works Thanks, Johannes Tröscher ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)
On June 10, 2012, 7:56 a.m., Martin Gräßlin wrote: cool, thanks for taking up where I left the work. I appreciate that very much. I have no idea about the key handling issue. I will try to test out the branch next week and play with it. As everything is in a branch, I'm fine if you develop in it without review requests, though if you want to get the feedback you are of course welcome to open a request. Alright, I have figured it out for myself. :) With my latest commit keyboard navigation should be fine. You are welcome to test and review it. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/#review14571 --- On June 9, 2012, 12:32 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/ --- (Updated June 9, 2012, 12:32 p.m.) Review request for Plasma and Martin Gräßlin. Description --- since qml is my new hobby I'm trying to work on some little projects ;). Well, this is a first step towards adding usable keyboard navigation to kickoff. Big problem: Somehow the Key_Left keypress event gets swallowed. You are supposed to control the tabbar by hitting left and right arrow key, just as with c++ kickoff. atm you can just go to the right. any help on debugging this issue is really appreciated. Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 919e6f7 plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml 7fc9d2b plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6 Diff: http://git.reviewboard.kde.org/r/105196/diff/ Testing --- kinda works Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/ --- Review request for Plasma and Martin Gräßlin. Description --- since qml is my new hobby I'm trying to work on some little projects ;). Well, this is a first step towards adding usable keyboard navigation to kickoff. Big problem: Somehow the Key_Left keypress event gets swallowed. You are supposed to control the tabbar by hitting left and right arrow key, just as with c++ kickoff. atm you can just go to the right. any help on debugging this issue is really appreciated. Diffs - plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 919e6f7 plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml 7fc9d2b plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6 Diff: http://git.reviewboard.kde.org/r/105196/diff/ Testing --- kinda works Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Bug Marble globe wallpaper, reversed spin direction
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105118/ --- Review request for Marble and Plasma. Description --- I had to delete a bunch of code to fix the issue. But what was the purpose of this code? Am I missing some cornercase? This addresses bug 264755. http://bugs.kde.org/show_bug.cgi?id=264755 Diffs - wallpapers/marble/marble.cpp 988a8b6 Diff: http://git.reviewboard.kde.org/r/105118/diff/ Testing --- bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Bug Marble globe wallpaper, reversed spin direction
On May 31, 2012, 1:08 p.m., Dennis Nienhüser wrote: Polarity determines whether north is visible top or bottom, so I don't know why the original code was there. I think you can even strip it down further to a simple qreal const direction = polarity 0 ? -1 : 1; i.e. ignore the projection -- in non-spherical case polarity is 1. Note that your patch also fixes bug 216156. You could use zoomIn()/zoomOut() though instead of the hard-coded +/- 40. Thanks for clarification. I could not find zoomIn/Out in MarbleMap. Unfortunately this plasma wallpaper doesn't use MarbleWidget. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105118/#review14296 --- On May 31, 2012, 12:52 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105118/ --- (Updated May 31, 2012, 12:52 p.m.) Review request for Marble and Plasma. Description --- I had to delete a bunch of code to fix the issue. But what was the purpose of this code? Am I missing some cornercase? This addresses bug 264755. http://bugs.kde.org/show_bug.cgi?id=264755 Diffs - wallpapers/marble/marble.cpp 988a8b6 Diff: http://git.reviewboard.kde.org/r/105118/diff/ Testing --- bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: qml port of showActivityManager (it's just an icon)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/ --- (Updated May 21, 2012, 6:46 p.m.) Review request for Plasma. Changes --- updated version with glow effect, replaces original sam added messages.sh Description --- Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that? Diffs (updated) - plasma/desktop/applets/CMakeLists.txt 731c70c plasma/desktop/applets/showActivityManager/CMakeLists.txt 592f38f plasma/desktop/applets/showActivityManager/Messages.sh 0f07ff5 plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml PRE-CREATION plasma/desktop/applets/showActivityManager/package/metadata.desktop PRE-CREATION plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop 98e9bd6 plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb7 plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d plasma/generic/dataengines/activities/activities.operations f9ce034 plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 Diff: http://git.reviewboard.kde.org/r/104959/diff/ Testing --- click: activity manager comes up click again: manager vanishes! Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: qml port of showActivityManager (it's just an icon)
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote:
Ehm, sorry for nitpicking but why is shipping allowed?
It (probably) can't be closed by pressing CTRL+Q and the glow hover is
missing...
There is an import to import org.kde.plasma.graphicswidgets 0.1 as
PlasmaWidgets which seems useless.
As a side note, i think we need a Icon component to mimic
Plasma::IconWidget --
http://api.kde.org/4.x-api/kdelibs-apidocs/plasma/html/classPlasma_1_1IconWidget.html.
David Edmundson wrote:
We sort of do:
org.kde.qtextracomponents 0.1
QIconItem
Mark Gaiser wrote:
No, we just do.
http://quickgit.kde.org/index.php?p=kde-runtime.gita=blobh=6cc3011319d750cb70c4cb98eb5290bf042c4d78hb=51170ba2615cb695647b07b2b26c9345be318dd6f=plasma%2Fdeclarativeimports%2Fgraphicswidgets%2Fgraphicswidgetsbindingsplugin.cpp
PlasmaWidgets.IconWidget should be the one required. Though it seems to
be working a bit differently then PlasmaCore.Svg. Judging from the properties
(http://quickgit.kde.org/index.php?p=kdelibs.gita=blobh=78f392ee91fc44b218bb1e2fe059628b6dfcd4e4hb=b91488ff46f0798511447b0b98ffaf81db2b0efbf=plasma%2Fwidgets%2Ficonwidget.h)
it should work somewhat like this:
PlasmaWidgets.IconWidget
{
svg: widgets/activities
}
Note: it uses svg rather then imagePath.. long live consistency ^_-
That widget also has the clicked (and double clicked) signal so i think
that should be used. No need to put a mousearea on top of it i guess.
My guess for this components (without testing! just writing it down here):
import QtQuick 1.1
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
Item
{
id: iconContainer
property string activeSource: Status
PlasmaCore.DataSource
{
id: dataSource
engine: org.kde.activities
connectedSources: [activeSource]
}
PlasmaCore.ToolTip
{
id: tooltip
mainText: i18n(Show Activity Manager)
subText: i18n(Click to show the activity manager)
target: iconContainer
image: preferences-activities
}
PlasmaWidgets.IconWidget
{
svg: widgets/activities
onClicked:
{
var service = dataSource.serviceForSource(activeSource)
var operation =
service.operationDescription(toggleActivityManager)
service.startOperationCall(operation)
}
}
}
Just my 5 cents.. or 1 euro in this case ;)
Thanks for your input, guys!
It (probably) can't be closed by pressing CTRL+Q
I'am able to close the activity manager by pressing alt+f4, or what are you
talking about? ctrl+q doesn't even work with the old version.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review14005
---
On May 21, 2012, 6:46 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/
---
(Updated May 21, 2012, 6:46 p.m.)
Review request for Plasma.
Description
---
Hello, I've played around a bit with the new qml stuff. Basically this port
works the same way as the c++ version. Though the icon doesn't glow on mouse
hover. How can I fix that?
Diffs
-
plasma/desktop/applets/CMakeLists.txt 731c70c
plasma/desktop/applets/showActivityManager/CMakeLists.txt 592f38f
plasma/desktop/applets/showActivityManager/Messages.sh 0f07ff5
plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml
PRE-CREATION
plasma/desktop/applets/showActivityManager/package/metadata.desktop
PRE-CREATION
plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop
98e9bd6
plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb7
plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d
plasma/generic/dataengines/activities/activities.operations f9ce034
plasma/generic/dataengines/activities/activityjob.cpp 7fe8823
Diff: http://git.reviewboard.kde.org/r/104959/diff/
Testing
---
click: activity manager comes up
click again: manager vanishes!
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: qml port of showActivityManager (it's just an icon)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/ --- Review request for Plasma. Description --- Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that? Diffs - plasma/desktop/applets/CMakeLists.txt 731c70c plasma/desktop/applets/showActivityManagerQml/CMakeLists.txt PRE-CREATION plasma/desktop/applets/showActivityManagerQml/activities.svgz PRE-CREATION plasma/desktop/applets/showActivityManagerQml/package/contents/ui/main.qml PRE-CREATION plasma/desktop/applets/showActivityManagerQml/package/metadata.desktop PRE-CREATION plasma/generic/dataengines/activities/activities.operations f9ce034 plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 Diff: http://git.reviewboard.kde.org/r/104959/diff/ Testing --- click: activity manager comes up click again: manager vanishes! Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Icon applet - Recognition of desktop files without .desktop extension
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104764/ --- Review request for Plasma. Description --- isDesktopFile() of KDesktopFile only looks at the file extension. This is not sufficient in a lot of cases, i.e. if you create a 'Link to Location' with dolphin it creates a desktop file without the .desktop extension. isDesktopFile check of KFileItem seems to working better and doesn't just look at the file suffix. This addresses bug 266870. http://bugs.kde.org/show_bug.cgi?id=266870 Diffs - plasma/generic/applets/icon/icon.cpp 4bdbae4 Diff: http://git.reviewboard.kde.org/r/104764/diff/ Testing --- bug fixed Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated March 6, 2012, 8:54 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- (Updated Jan. 10, 2012, 1:41 p.m.) Review request for Plasma. Changes --- bump Description (updated) --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) I'm allowed to commit it? This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasmoid web slice - disable geometryEdit if not needed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103468/ --- Review request for Plasma. Description --- title says it all. this patch is related to https://bugs.kde.org/show_bug.cgi?id=284459#c2 but does not fix that bug. Diffs - applets/webslice/plasma/webslice.h fbe1242 applets/webslice/plasma/webslice.cpp a1740bf Diff: http://git.reviewboard.kde.org/r/103468/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- Review request for Plasma. Description --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 14, 2011, 6:25 p.m.) Review request for Plasma. Changes --- Well, I fulfilled all three wishes. Please express your frustration in a friendly manner :) Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs (updated) - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 9, 2011, 2:53 p.m., Aaron J. Seigo wrote: we tried the plasmoid with a couple of people here at the house and comments included: * the history should be remembered between restarts (e.g.: save to config) * instead of showing the result in a tooltip, it should be shown in the plasmoid itself (as if you had typed in the equation; would also make it easy to go back to an older equation and re-edit it) * the history button should be enabled only when there are items in the history * the answer should be selectable for copy/past purposes (that's not the fault of your patch, of course :) very nice improvement already though .. due to feature freeze this can't go in until 4.9 devel opens up (in january), so there remains time to improve this further. thanks for the patch, i look forward to seeing further improvements! :) great feedback! I'll see what I can do! - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8821 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs (updated) - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 6, 2011, 2:16 p.m., Aaron J. Seigo wrote: applets/qalculate/qalculate_applet.cpp, line 143 http://git.reviewboard.kde.org/r/103052/diff/1/?file=40280#file40280line143 this looks wrong. it should be put into a layout somewhere and managed that way. in particular, this will break with larger fonts. I removed that line and changed the sizePolicy - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 6, 2011, 2:16 p.m., Aaron J. Seigo wrote: applets/qalculate/qalculate_applet.cpp, lines 235-237 http://git.reviewboard.kde.org/r/103052/diff/1/?file=40280#file40280line235 if this is to make m_output appear before m_historyButton in the layout, use insertItem instead of addItem :) yeah good catch :) I suppose that I should mark these things fixed or is that your job? Oh and thanks for reviewing - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid folderview - context menu empty trash bin
On Dec. 3, 2011, 5:49 p.m., Commit Hook wrote: This review has been submitted with commit fed2ad991153672deecfc2df7c51bb34a58761c5 by Gregor Tätzner to branch master. yes, I've got it! - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103282/#review8689 --- On Nov. 28, 2011, 3:52 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103282/ --- (Updated Nov. 28, 2011, 3:52 p.m.) Review request for Plasma. Description --- I incorporated the proposal in the last comment. What do you think? This addresses bug 259356. http://bugs.kde.org/show_bug.cgi?id=259356 Diffs - plasma/applets/folderview/folderview.cpp 01b71d1 Diff: http://git.reviewboard.kde.org/r/103282/diff/diff Testing --- empty trash gets enabled Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: kickoff breadcrumb cursor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103159/ --- Review request for Plasma. Description --- aseigo told me to do it. So what would be the right implementation? ;) Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a plasma/desktop/applets/kickoff/ui/breadcrumb.h PRE-CREATION plasma/desktop/applets/kickoff/ui/breadcrumb.cpp PRE-CREATION plasma/desktop/applets/kickoff/ui/launcher.cpp a2acb35 Diff: http://git.reviewboard.kde.org/r/103159/diff/diff Testing --- works very nice Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: kickoff breadcrumb cursor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103159/ --- (Updated Nov. 16, 2011, 11:28 p.m.) Review request for Plasma. Changes --- ok here is the noobie way :) Description --- aseigo told me to do it. So what would be the right implementation? ;) Diffs (updated) - plasma/desktop/applets/kickoff/ui/launcher.cpp a2acb35 Diff: http://git.reviewboard.kde.org/r/103159/diff/diff Testing --- works very nice Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasma widget qalculate - PluginInfo-Website
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103037/ --- Review request for Plasma. Summary (updated) - plasma widget qalculate - PluginInfo-Website Description (updated) --- The old link was inaccurate. Diffs (updated) - applets/qalculate/plasma-applet-qalculate.desktop 580c898 Diff: http://git.reviewboard.kde.org/r/103037/diff/diff Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma widget qalculate - PluginInfo-Website
On Nov. 3, 2011, 12:31 p.m., Aaron J. Seigo wrote: these kinds of changes don't need to go through review-board: just the more complex, non-obvious and/or when the developer just wants feedback :) ok, understood. Can I have something like a mentor? Someone who commits my changes and answers my noob-questions? - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103037/#review7904 --- On Nov. 3, 2011, 12:24 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103037/ --- (Updated Nov. 3, 2011, 12:24 p.m.) Review request for Plasma. Description --- The old link was inaccurate. Diffs - applets/qalculate/plasma-applet-qalculate.desktop 580c898 Diff: http://git.reviewboard.kde.org/r/103037/diff/diff Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: picture frame widget - move to next picture on delete
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103001/ --- Review request for Plasma. Description --- Now when you delete in slideshow mode a picture (right click, open picture, delete), the frame widget moves on to the next picture without complaining. Possibly my implementation is stupid. This addresses bug 177212. http://bugs.kde.org/show_bug.cgi?id=177212 Diffs - applets/frame/picture.h 7fc33b4 applets/frame/picture.cpp 57d82ed applets/frame/slideshow.cpp a461244 Diff: http://git.reviewboard.kde.org/r/103001/diff/diff Testing --- it compiles Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: picture frame widget - open potd picture
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- (Updated Oct. 28, 2011, 10:20 a.m.) Review request for Plasma. Changes --- improved version? Description --- Hi, This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview). This addresses bug 280406. http://bugs.kde.org/show_bug.cgi?id=280406 Diffs (updated) - applets/frame/slideshow.cpp 116c514 dataengines/potd/potd.cpp f1b9933 Diff: http://git.reviewboard.kde.org/r/102817/diff/diff Testing --- Bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: picture frame widget - open potd picture
On Oct. 28, 2011, 11:05 a.m., Aaron J. Seigo wrote: Ship It! cool, but I have no write access...your turn ;) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7711 --- On Oct. 28, 2011, 10:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- (Updated Oct. 28, 2011, 10:20 a.m.) Review request for Plasma. Description --- Hi, This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview). This addresses bug 280406. http://bugs.kde.org/show_bug.cgi?id=280406 Diffs - applets/frame/slideshow.cpp 116c514 dataengines/potd/potd.cpp f1b9933 Diff: http://git.reviewboard.kde.org/r/102817/diff/diff Testing --- Bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: picture frame widget - open potd picture
On Oct. 25, 2011, 11:35 a.m., Aaron J. Seigo wrote: applets/frame/slideshow.cpp, lines 221-222 http://git.reviewboard.kde.org/r/102817/diff/1/?file=38475#file38475line221 much cleaner than this, which introduces an assumption on where potd stores things into the widget, would be add a URL item in the potd DataEngine that is included with the source. this could be either a remote or a local URL and wouldn't require the applet to be changed if/when the DataEngine changes. Greg T wrote: Well, I get the basic idea but can you try to explain it a little bit more in detail? I suppose I should make a change in kdeplasma-addons/dataengines/potd/potd.cpp? Aaron J. Seigo wrote: yes, a change in the dataengine .. so that when it doest setData( provider-identifier(), provider-image() ) it will also do a setData(provider-identifier(), URL, someUrlToTheImage) in fact, i'd even change that first setData to be setData(rovider-identifier(), Image, provider-image()) and then change the plasmoid to work with that. if there were other potential users of this dataengine, it could also be moved into kde-workspace (i could imagine a wallpaper using it, for instance :) Thank you, mastermind ;) I chose option 1 but the KStandardDirs::locate stuff is still there. I assume this isn't right? - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7597 --- On Oct. 28, 2011, 10:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- (Updated Oct. 28, 2011, 10:20 a.m.) Review request for Plasma. Description --- Hi, This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview). This addresses bug 280406. http://bugs.kde.org/show_bug.cgi?id=280406 Diffs - applets/frame/slideshow.cpp 116c514 dataengines/potd/potd.cpp f1b9933 Diff: http://git.reviewboard.kde.org/r/102817/diff/diff Testing --- Bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: picture frame widget - open potd picture
On Oct. 25, 2011, 11:35 a.m., Aaron J. Seigo wrote: applets/frame/slideshow.cpp, lines 221-222 http://git.reviewboard.kde.org/r/102817/diff/1/?file=38475#file38475line221 much cleaner than this, which introduces an assumption on where potd stores things into the widget, would be add a URL item in the potd DataEngine that is included with the source. this could be either a remote or a local URL and wouldn't require the applet to be changed if/when the DataEngine changes. Well, I get the basic idea but can you try to explain it a little bit more in detail? I suppose I should make a change in kdeplasma-addons/dataengines/potd/potd.cpp? - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7597 --- On Oct. 10, 2011, 10:41 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- (Updated Oct. 10, 2011, 10:41 a.m.) Review request for Plasma. Description --- Hi, This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview). This addresses bug 280406. http://bugs.kde.org/show_bug.cgi?id=280406 Diffs - applets/frame/slideshow.cpp 116c514 Diff: http://git.reviewboard.kde.org/r/102817/diff/diff Testing --- Bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: picture frame widget - open potd picture
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/ --- Review request for Plasma. Description --- Hi, This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview). This addresses bug 280406. http://bugs.kde.org/show_bug.cgi?id=280406 Diffs - applets/frame/slideshow.cpp 116c514 Diff: http://git.reviewboard.kde.org/r/102817/diff/diff Testing --- Bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma_applet_folderview - folder previews on mouse hover
On Sept. 2, 2011, 7:05 a.m., Aaron J. Seigo wrote: just remove the context menu integration and the rest seems to work just fine. nice :) do you have a commit account, or do you need one of us to push it to master for you? yeah, the actionCollection is not necessary. Didn't know it was about context menu, though. No, I don't have a commit account here. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/#review6230 --- On Sept. 1, 2011, 10:56 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/ --- (Updated Sept. 1, 2011, 10:56 a.m.) Review request for KDE Base Apps and Plasma. Summary --- Hello, this is my attempt to resolve Bug 250703. The diff adds a gui option in the settings dialog which configures the click to view option. It was quite fun because most of the time I didn't know what I'm doing :) This addresses bug 250703. http://bugs.kde.org/show_bug.cgi?id=250703 Diffs - plasma/applets/folderview/folderview.h 35a0625 plasma/applets/folderview/folderview.cpp 6e95c40 plasma/applets/folderview/folderviewDisplayConfig.ui 961296d plasma/applets/folderview/iconview.h 4d736c5 Diff: http://git.reviewboard.kde.org/r/102300/diff Testing --- it compiles fine on kde 4.6.5 and does also work. Thanks, Greg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma_applet_folderview - folder previews on mouse hover
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/ --- (Updated Sept. 1, 2011, 10:56 a.m.) Review request for KDE Base Apps and Plasma. Summary --- Hello, this is my attempt to resolve Bug 250703. The diff adds a gui option in the settings dialog which configures the click to view option. It was quite fun because most of the time I didn't know what I'm doing :) This addresses bug 250703. http://bugs.kde.org/show_bug.cgi?id=250703 Diffs - plasma/applets/folderview/folderview.h 35a0625 plasma/applets/folderview/folderview.cpp 6e95c40 plasma/applets/folderview/folderviewDisplayConfig.ui 961296d plasma/applets/folderview/iconview.h 4d736c5 Diff: http://git.reviewboard.kde.org/r/102300/diff Testing --- it compiles fine on kde 4.6.5 and does also work. Thanks, Greg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma_applet_folderview - folder previews on mouse hover
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/ --- (Updated Sept. 5, 2011, 9:33 a.m.) Review request for KDE Base Apps and Plasma. Changes --- removed actionCollection Summary --- Hello, this is my attempt to resolve Bug 250703. The diff adds a gui option in the settings dialog which configures the click to view option. It was quite fun because most of the time I didn't know what I'm doing :) This addresses bug 250703. http://bugs.kde.org/show_bug.cgi?id=250703 Diffs (updated) - plasma/applets/folderview/folderview.h 35a0625 plasma/applets/folderview/folderview.cpp 6e95c40 plasma/applets/folderview/folderviewDisplayConfig.ui 961296d plasma/applets/folderview/iconview.h 4d736c5 Diff: http://git.reviewboard.kde.org/r/102300/diff Testing --- it compiles fine on kde 4.6.5 and does also work. Thanks, Greg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
