D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Martin Kostolný]

martinkostolny added a comment.


  Hello after some time. I finally manage to more or less finish the layout 
rework I was planning. I tried to work in most of what we discussed here.
  
  @Pitel Radek, if You have some time, can You please check out `layout-rework` 
branch and try if You manage to set up your desired configuration? And of 
course if you see any issues, please let me know of them and I'll do my best to 
fix them.
  
  In Layout configuration section there is also a facility to upload/download 
custom configuration JSON to ease up config exchanges between users (and devs 
for bug-reports:) ). Known issue/feature of this facility is that the JSON does 
not cover all possible config properties. Just the ones related to layout 
(although some of the supported properties are from config sections different 
from layout section).
  
  I'm also open to tuning up existing hard-coded config profiles, and adding 
new if it makes sense.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11551: use the new install_package form

[Martin Kostolný]

martinkostolny added a comment.


  Last info: on my side everything seems to compile and work just fine now. 
Thanks for your work! :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11551

To: mart, #plasma
Cc: martinkostolny, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Martin Kostolný]

martinkostolny added a comment.


  Sorry for being dark for so long, Radek. I was busy and I hope it will get 
better. Thanks a lot for your ideas.
  
  > Is floating really floating or just another layer of occupying?
  
  You are right, it should be another level of occupying. I haven't thought 
that one through enough.
  
  > show on: mouse out | mouse in | always (and possibly never show unless it 
is covered by other options, show on mouse out not available for buttons and 
appmenu)
  
  This one I don't fully understand. Why show on: mouse_out|mouse_in for all 
items is not enough to satisfy all scenarios?
  
  > checkbox to restrict mouse area used by "show on" option only to rect 
occupied by given item
  
  Good idea!
  
  > Some predefined presents are a great idea -- do you intent to support 
saving current setup as a present?
  
  Ideally yes along with export/import presets.
  
  > I think this is an important feature, I tried implementing it in D11073 
.
  
  I can see you put a lot of work into it and I still have it in mind. Thanks! 
I intend to review and accept it soon.
  
  > Also why is the backend plugin private?
  
  The backend plugin was basically copied from existing Global Menu plasmoid - 
that was also a private plugin. I think the Global Menu one should one day be 
public so it can be used by other widgets.
  
  > active window control is a 3rd party plasmoid, right?
  
  @mart: yes, it is. I intended to request addition of this widget to 
kdeplasma-addons once these usability issues are resolved.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11551: use the new install_package form

[Martin Kostolný]

martinkostolny added a comment.


  > Is there something I may be doing wrong?
  
  I can see now that this change was applied and then reverted all over the 
plasma repositories so these are probably 2 leftovers. Sorry for the fuzz.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11551

To: mart, #plasma
Cc: martinkostolny, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11551: use the new install_package form

[Martin Kostolný]

martinkostolny added a comment.


  Sorry to be late on this. I cannot compile plasma-pa anymore after this 
change with error:
  
Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc
make[2]: *** No rule to make target 
'applet/org.kde.plasma.volume-contents.rcc', needed by 
'applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:191: 
applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
  
  Same goes for plasma-nm after similar change. I'm using kdesrc-build 
environment. Is there something I may be doing wrong?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11551

To: mart, #plasma
Cc: martinkostolny, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Martin Kostolný]

martinkostolny added a comment.


  If you have write access, you can push it to git directly. Otherwise let me 
know, I can push it for you with your name as the original author :).

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Perfect, thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

BRANCH
  realign

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Good idea, thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Martin Kostolný]

martinkostolny added a comment.


  Thanks for taking the time to think about this.
  
  The number of settings (and their inconsistencies) are actually a big pain of 
this project. I'd like to rework it from the ground up. So if I may, I'd like 
to postpone your patch. When I'm finished with the planned rework I'll 
definitely add your use-case into account.
  
  I'd actually like to present my point of view here so we can discuss if it is 
a good idea or not:
  
  I'm proposing to have a bunch of standalone items with some common placement 
settings. The items are:
  
  - icon
  - text
  - window buttons
  - appmenu
  
  Mentioned items would be placeable by drag-drop in settings like window 
buttons are already.
  
  Each item would have following settings in common:
  
  - occupying | floating
  - horizontal alignment: left | right
  
  Window text and appmenu would additionally have:
  
  - fill width
  - fill height (default: true)
  
  Appmenu and buttons would additionaly have:
  
  - height
  - vertical alignment: top | bottom | center
  - hide on mouse out
  
  Of course there will still be specific settings for the items like window 
title eliding etc.
  
  I also plan to create some presets like:
  
  1. Unity (Ubuntu style)
  2. Thick (thick panel with floating and disappearing menu and buttons over 
icon and title)
  3. One Liner (from the left: buttons, icon, window text, appmenu)
  
  Any opinions are appreciated :).

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Martin Kostolný]

martinkostolny requested changes to this revision.
martinkostolny added a comment.
This revision now requires changes to proceed.


  Firstly, thanks for your effort!
  
  I prefer the latter variant. The first proposed one proves Kai's warning 
because it broke multi-line title wrapping (e.g. if you have thicker panel).

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.


  thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Thanks for fixing my code! :)
  
  I'm sure I can also provide a flag for menu availability (the code for 
appmenu is copied for now anyway). But I think in AWC it does not make sense to 
set status to active when menu is available because it has other use then 
showing menu. I can be wrong of course.
  
  Anyway I definitely agree with your proposed patch.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: New widgets to plasma

[Martin Kostolný]

Thanks, David, for quick answer.

I agree basically with everything you said.

My aim is to keep up with Plasma versioning and it would be really helpful for 
me not to support multiple versions of Plasma with latest version of widget. 
That is why I find perfect to join kdeplasma-addons. Actually I thought that 
this is already being in core Plasma since kdeplasma-addons carries Plasma 
version.

Being official just for the sake of it was not my intention. It is true that it 
would just add more burden for Plasma devs. Of course I intend to maintain 
added widgets.

I'm still not very familiar with developing Plasma datasources, but I try to 
investigate ways of integrating libdbusmenu as a datasource.

Thanks for inviting me to being Plasma dev. I'd like to join, but I don't know 
what that actually means. I like to help with various stuff but I have (for 
now) non-regular limited time - some evenings, some weekends etc.

Best Regards,
Martin

New widgets to plasma

[Martin Kostolný]

Hi,

I'd like to add some of my widgets to official widget bundle in plasma. Namely:
- redshift-control (https://github.com/kotelnik/plasma-applet-redshift-control)
- active-window-control 
(https://github.com/kotelnik/plasma-applet-active-window-control)
(maybe other if it makes sense)

I realize that they have issues:
- redshift-control is Xorg only and I know that we don't want to add new 
xorg-only stuff
- awc has awfully complicated settings (I'll improve that eventually, but it 
will still be very configurable)

There were some requests from users of various distributions to add these 
widgets as official projects. This would allow them to reach more distros -> 
users.

So my question is - is it a good idea to add them to standard plasma widgets? 
Or does it make more sense to just make them official KDE but completely 
separate single projects? The latter was my initial intention but I was asked 
in incubation request if I queried you guys first, so here I am :-). I will 
also be ok with "no-adding-at-all" answer.

Anyway, thanks for all the great work you do!
Martin

[Differential] [Request, 2 lines] D4775: Suggestion - newline ending after password to output

[Martin Kostolný]

martinkostolny created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is meant more as a question rather then actual code fix intention:
  
  I have a problem with `sudoedit` cmd line tool only accepting password from 
`ksshaskpass` if it is provided with newline in the end. Specifically in 
current state - calling:
  
EDITOR=kate SUDO_ASKPASS=/usr/bin/ksshaskpass sudoedit -A /etc/hosts
  
  ...will result in a Ksshaskpass dialog and after entering the password the 
command just ends. But after applying this patch it starts working and kate is 
opened.
  
  I tried other graphical askpass programs, namely ssh-askpass, 
qt4-ssh-askpass, lxqt-ssh-askpass and gnome-ssh-askpass2 (gtk2). They all work 
nicely with sudoedit.
  
  My question is: Is it intentional that the password is not returned with 
newline? Should I ask sudoedit guys instead? Or is the problem elswhere, e.g. 
in KPasswordDialog (KF5 kwidgetaddons)? Thanks!
  
  PS: Please add reviewers as needed, I don't know the proper flow here, sorry 
:).

TEST PLAN
  Tested on sudoedit as well as git connecting to github with username and 
password.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4775

AFFECTED FILES
  src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: martinkostolny, cfeck
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[kio-extras] [Bug 359636] SMB and SFTP (probably others) cannot be configured to not append ".part" extension from GUI

[Martin Kostolný via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359636

--- Comment #1 from Martin Kostolný <clearmar...@zoho.com> ---
Created attachment 97341
  --> https://bugs.kde.org/attachment.cgi?id=97341=edit
proposed patch

This patch adds the config option to settings. Tested on sftp protocol.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 359636] New: SMB and SFTP (probably others) cannot be configured to not append ".part" extension from GUI

[Martin Kostolný via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359636

Bug ID: 359636
   Summary: SMB and SFTP (probably others) cannot be configured to
not append ".part" extension from GUI
   Product: kio-extras
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: clearmar...@zoho.com

When copying files to the remote location over SMB, SFTP and others it is
always used ".part" extension for the newly created currently copied file. I
can see from kio-extras source code that "MarkPartial" property is actually
loaded from ~.config/kioslaverc config file. I've also tested that when adding
MarkPartial=false to this file it actually affect the transfer as needed.

But this configuration is not changeable through GUI. FTP has it's own
MarkPartial property in ~/.config/kio_ftprc and it is configurable through
System Settings -> Network: Settings -> Connection Preferences.

I think there should be a GUI option for the global MarkPartial property used
for the rest of kio slaves e.g. in the same Connection Preferences in a new
"Global Options" section.

Reproducible: Always




I have KF 5.19, Plasma 5.5.4, Qt 5.5.1, KDE Apps 15.12.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel