No plasmaengineexplorer in KDE 4.10?
Hi, I was playing around with the new KDE and suddenly realised that there is no plasmaengineexplorer installed. Have we not shipped it this time? If yes, do we have an alternative? Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fix batterymonitor layout to scale with high resolution screens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106962/#review20591 --- Ship it! looks good - Viranch Mehta On Oct. 20, 2012, 12:31 a.m., Michael Zanetti wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106962/ --- (Updated Oct. 20, 2012, 12:31 a.m.) Review request for Plasma. Description --- Ensures that the battery icon is always next to the text, no matter how long it gets. Screenshots: current version: http://notyetthere.org/data/kde/battery-fixed-sizes.png patched version: http://notyetthere.org/data/kde/battery-dynamic-sizes.png Diffs - plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 78d5927 Diff: http://git.reviewboard.kde.org/r/106962/diff/ Testing --- Thanks, Michael Zanetti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Poll - Rethinking battery remaining time option
Hi, Apparently, there has been a rage among users[1] regarding whether to have remaining time be shown in battery monitor. Note that this bug has considerable amount of upvotes, so I'm not reopening this for the heck of it, I'm doing it because of the upvotes. Plus, we've never really had a poll for this AFAIK, only discussions. I've created a poll[2] so that we can collectively come on a most mutually agreed decision, you can see the poll results here[3]. Please vote even if you're neutral to the whole issue in question. I hope everyone will calmly respect this instead of re-igniting the discussion. Cheers, Viranch PS: Can someone please cross post this to relevant MLs? Thanks. [1] https://bugs.kde.org/show_bug.cgi?id=304510 [2] http://goo.gl/csMkI (Google doc) [3] http://goo.gl/nhBPV (Google doc) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Poll - Rethinking battery remaining time option
On Wed, Sep 12, 2012 at 6:00 PM, Marco Martin notm...@gmail.com wrote: I'm for keeping the config option as least possible damage, i think it has been discussed to death (including why user polls for features don't work) this is only a developers' poll Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Poll - Rethinking battery remaining time option
On Wed, Sep 12, 2012 at 5:53 PM, Djuro Drljaca djurodrlj...@gmail.comwrote: what about adding the option to hide or show this information? My bad, the poll is about having the option to show the information, not showing the information itself. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Support for multiple batteries in battery monitor applet
On 02-Aug-2012, at 7:05 PM, Sebastian Kügler wrote: On Sunday, July 29, 2012 12:45:00 Viranch Mehta wrote: On Sun, Jun 17, 2012 at 2:45 PM, David Edmundson k...@davidedmundson.co.ukwrote: Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that the feature is missing, can I suggest we submit a version with this patch to kde-look.org, so that it is available in get new stuff. Should the patched applet replace the original applet or be installed with a different plugin name? If its installed as a different applet, it can't be put in the system tray, so what do we want here? We should replace it with the same name, otherwise we'll just have stale applets lying around. Then what about the applet that will be shipped in the next release? will it replace this downloaded one again? I think the applets downloaded from get new stuff go into ~/.kde/ which precede the ones that are installed system-wide. so the one downloaded by user might precede the one installed by the next release also. i'm not sure about this though. And once tested, ship the updated version, maybe in 4.9.1 already? the master is open again, i suppose? Thanks, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Support for multiple batteries in battery monitor applet
On Sun, Jun 17, 2012 at 2:45 PM, David Edmundson k...@davidedmundson.co.ukwrote: Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that the feature is missing, can I suggest we submit a version with this patch to kde-look.org, so that it is available in get new stuff. Should the patched applet replace the original applet or be installed with a different plugin name? If its installed as a different applet, it can't be put in the system tray, so what do we want here? Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
master pushed to KDE/4.9
Hi, While I was trying to push my commit to KDE/4.9 after pushing to master, I landed pushing all of master to KDE/4.9 branch. I was asked to give a request for reverting this to the project's git maintainers. So can someone please look into this? My apologies for the inconvenience. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: fixing little issues on my QML/Python program
On Tue, Jun 26, 2012 at 8:31 AM, Eric Mesa ericsbinarywo...@gmail.comwrote: Thanks to everyone who's helped me over the last year or so with my program. I have one more thing to fix on my engine and then it will be perfect. The recent help I got helped me finally perfect the GUI. So my data engine's running a function over and over with different arguments to populate the sources. Here's what it looks like: Please always use pastebin.com or paste.kde.org to show your codes instead of putting them in emails. Viranch from PyQt4.QtCore import * from PyKDE4.kdecore import * from PyKDE4 import plasmascript #for flickr import views class PyFlickrEngine(plasmascript.DataEngine): def __init__(self,parent,args=None): plasmascript.DataEngine.__init__(self,parent) def init(self): self.setMinimumPollingInterval(333) #for flickr views.initialize() #adding this back in 24 jan to see if it helps def sources(self): sources = [25, 50, 75, 100, 200, 300, 400, 500, 600, 700, 800, 900, 1000, 1250, 1500, 1750, 2000,3000, 4000, 5000, 1] return sources def sourceRequestEvent(self, name): #print source request event #debugging return self.updateSourceEvent(name) def updateSourceEvent(self,group): print updateSourceEvent #grouplist = [] if group == 25: grouplist = views.analyzeviews(views.views25, views.views50) self.setData(25, Group 25, grouplist) elif group == 50: grouplist = views.analyzeviews(views.views50, views.views75) self.setData(50,Group 50, grouplist) elif group == 75: grouplist = views.analyzeviews(views.views75,views.views100) self.setData(75,Group 75, grouplist) elif group == 100: print i'm @ 100 #debug grouplist = views.analyzeviews(views.views100,views.views200) self.setData(100,Group 100, grouplist) elif group == 200: print i'm @ 200 #debug grouplist = views.analyzeviews(views.views200, views.views300) self.setData(200,Group 200, grouplist) *... (cut a snippet out - I think you get the point)* elif group == 1: print i'm @ 1 #debug grouplist = views.analyzeviews(views.views1, views.views1) self.setData(1,Group 1, grouplist) return True def CreateDataEngine(parent): return PyFlickrEngine(parent) So that function it's calling, views.analyzeviews(arg, arg) is calling a web API and sometimes that API fails. The cool thing about data engines vs when I used to do this on the commandline is that if it fails at 25, it doesn't crash the whole program. It just moves on to 50. So I can end up in the end where when I click on 25 it tells me that there's nothing in the source and then I click on 50 and I can use the data from that source. So, right now if I want the data from 25, the only way I know how to do that is by re-running the program and hoping the API doesn't fail that time around. Is there a way for me to tell the data engine to update group 25 again from within the QML gui? Thanks! -- Eric Mesa http://about.me/ericmesa http://www.ericsbinaryworld.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML, Python, Signals, and Slots Part 2
On Mon, Jun 25, 2012 at 12:52 AM, Eric Mesa ericsbinarywo...@gmail.comwrote: OK, I did a bunch of googling and I think I can better word what I want to do. I want to emit a signal in QML and catch it in a python slot. That way it can be the arguments to a function within python. Can I please get some help with this? The syntax is just indirect enough (like the signal and slot have different names and all kinds of weirdness) that it's just slightly out of reach for my brain to wrap itself around. say you have mySignal(string foo) in QML. this is roughly what you'd do in python: view = QDeclarativeView() view.setSource(...) connect(view.rootObject(), SIGNAL(mySignal(QString)), receiver, SLOT(...)) I'm assuming the mySignal is in QML's root object. Hope this helps. Viranch Thanks, -- Eric Mesa http://about.me/ericmesa http://www.ericsbinaryworld.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Use common plasma components Tooltip in battery monitor
On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: The button size and the hover appearance is different from the original one. The IconButton component was made to keep the look of the buttons consistent with the original version of the applet. Do we want to change this? David Edmundson wrote: Valid argument for now, won't be valid when everything moves to QML/Plasma Components. You're maintainer, you have final say. If you want me to wait till 4.10 when more applets are QML based I will do. Viranch Mehta wrote: Well after a second thought, I think its a better idea to use plasma components for consistency over plasma rather than maintaining consistency with previous versions. but the original button for some reason looks *really* better in visual terms to me (in fact, the button is also used in some other plasmoids including the network manager). so... to plasma components dev: can we have an option in the button of what background svg is used? may be a switch between the current one and the one in this plasmoid (widgets/viewitem)? if that may take time to come up, or is not desired, we can have this patch shipped right in! david, please ship this patch for now. thanks! - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- On June 17, 2012, 7:52 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/ --- (Updated June 17, 2012, 7:52 p.m.) Review request for Plasma. Description --- Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such. It's bad for applets to implement their own version of common classes as it prevents consistency. (will fix the whitespace addition before commit) Diffs - plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a Diff: http://git.reviewboard.kde.org/r/105283/diff/ Testing --- Checked applet looked ok. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Use common plasma components Tooltip in battery monitor
On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: The button size and the hover appearance is different from the original one. The IconButton component was made to keep the look of the buttons consistent with the original version of the applet. Do we want to change this? David Edmundson wrote: Valid argument for now, won't be valid when everything moves to QML/Plasma Components. You're maintainer, you have final say. If you want me to wait till 4.10 when more applets are QML based I will do. Well after a second thought, I think its a better idea to use plasma components for consistency over plasma rather than maintaining consistency with previous versions. but the original button for some reason looks *really* better in visual terms to me (in fact, the button is also used in some other plasmoids including the network manager). so... to plasma components dev: can we have an option in the button of what background svg is used? may be a switch between the current one and the one in this plasmoid (widgets/viewitem)? if that may take time to come up, or is not desired, we can have this patch shipped right in! - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- On June 17, 2012, 7:52 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/ --- (Updated June 17, 2012, 7:52 p.m.) Review request for Plasma. Description --- Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such. It's bad for applets to implement their own version of common classes as it prevents consistency. (will fix the whitespace addition before commit) Diffs - plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a Diff: http://git.reviewboard.kde.org/r/105283/diff/ Testing --- Checked applet looked ok. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
Hi, I read through the thread provided by Marco and I'd like to give in my bit of suggestion: We clearly do not want to mislead the user by giving him a misleading number (the remaining time). I agree with Aaron that this will make the user trust his computer less. What I suggest is let the user know down right that the number might be inaccurate before he chooses to use the feature. So in the config ui, put a warning in the brackets beside the config check box: (Warning: the reported remaining time of the battery will be a predicted value, and hence may be inaccurate). Now when the user is aware that the remaining time might be misleading he will keep that in mind whenever he sees the information and whenever it is wrong, he won't blame his computer. I'd generally not give my suggestion in a burning discussion, but since we all agree this is a good feature to have and knowing that the only roadblock in shipping this feature is the inaccuracy of it, I thought the above suggestion might work out to kind of dissolve the road block, while relevant people can continue working on making the numbers more accurate. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Use common plasma components Tooltip in battery monitor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- The button size and the hover appearance is different from the original one. The IconButton component was made to keep the look of the buttons consistent with the original version of the applet. Do we want to change this? - Viranch Mehta On June 17, 2012, 7:52 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/ --- (Updated June 17, 2012, 7:52 p.m.) Review request for Plasma. Description --- Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such. It's bad for applets to implement their own version of common classes as it prevents consistency. (will fix the whitespace addition before commit) Diffs - plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a Diff: http://git.reviewboard.kde.org/r/105283/diff/ Testing --- Checked applet looked ok. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Support for multiple batteries in battery monitor applet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105277/ --- Review request for Plasma. Description --- This patch implements support for computers with multiple batteries in the battery monitor applet. I'm not sure if I should push it now or after the unfreeze. This review addresses the bug #301533 This addresses bug 301533. http://bugs.kde.org/show_bug.cgi?id=301533 Diffs - plasma/generic/applets/batterymonitor/contents/code/logic.js PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 08a46ec Diff: http://git.reviewboard.kde.org/r/105277/diff/ Testing --- Added dummy battery sources in power management engine and tested with it. Works fine, as expected with such sources. Can someone with multiple batteries please test the patch? since I don't have a computer with multiple batteries. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix sourceFilter to actually filter the sources in QML DataModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105267/ --- Review request for Plasma and Marco Martin. Description --- This fixes a bug in PlasmaCore.DataModel. The DataModel does not correctly filter the sources when sourceFilter is provided. The dataUpdated function does terminate when sourceName does not match the sourceFilter, but when it does match, all sources from the data engine are added to the said DataModel instead of checking for the sourceFilter again. This patch introduces that check. (the patch is clearer than the description) Diffs - plasma/declarativeimports/core/datamodel.cpp 9400dbe Diff: http://git.reviewboard.kde.org/r/105267/diff/ Testing --- Tested with Battery Monitor applet when there are multiple batteries and a model is required consisting of only the battery sources from powermanagement engine. Works as expected with the patch. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix sourceFilter to actually filter the sources in QML DataModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105267/ --- (Updated June 15, 2012, 10:20 p.m.) Review request for Plasma and Marco Martin. Description --- This fixes a bug in PlasmaCore.DataModel. The DataModel does not correctly filter the sources when sourceFilter is provided. The dataUpdated function does terminate when sourceName does not match the sourceFilter, but when it does match, all sources from the data engine are added to the said DataModel instead of checking for the sourceFilter again. This patch introduces that check. (the patch is clearer than the description) Diffs - plasma/declarativeimports/core/datamodel.cpp 9400dbe Diff: http://git.reviewboard.kde.org/r/105267/diff/ Testing --- Tested with Battery Monitor applet when there are multiple batteries and a model is required consisting of only the battery sources from powermanagement engine. Works as expected with the patch. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix sourceFilter to actually filter the sources in QML DataModel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105267/ --- (Updated June 15, 2012, 10:20 p.m.) Review request for Plasma and Marco Martin. Description --- This fixes a bug in PlasmaCore.DataModel. The DataModel does not correctly filter the sources when sourceFilter is provided. The dataUpdated function does terminate when sourceName does not match the sourceFilter, but when it does match, all sources from the data engine are added to the said DataModel instead of checking for the sourceFilter again. This patch introduces that check. (the patch is clearer than the description) Diffs - plasma/declarativeimports/core/datamodel.cpp 9400dbe Diff: http://git.reviewboard.kde.org/r/105267/diff/ Testing --- Tested with Battery Monitor applet when there are multiple batteries and a model is required consisting of only the battery sources from powermanagement engine. Works as expected with the patch. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
No remaining time option in battery monitor?
Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this in the qml version. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [KDE Bugtracking System] REMINDER: current Plasma regressions
On Sat, Jun 9, 2012 at 12:58 AM, bugzilla_nore...@kde.org wrote: ** 301424 https://bugs.kde.org/show_bug.cgi?id=301424 normal NOR openSUSE RPMs plasma-b...@kde.org NEW --- Cannot open battery monitor applet if set to hidden in systray @Marco: can you look into this please? seems like a bug with compact representation and plasmoid.togglePopup() Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Mouse wheel on Slider QML component
Hi, I wanted to know if the Slider (from QML components) can be moved using the mouse wheels. If not, is it possible to implement it atm? Thanks, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Applet Testing for 4.9
On Thu, May 17, 2012 at 3:58 AM, David Edmundson da...@davidedmundson.co.uk wrote: - a list of all the new QML-based applets (by the time of the first beta) (afaik, nowplaying, battery, locklogout, activitymanager.. but there are so many more random branches about, and I don't know the status of these) As for the status, device notifier was shipped in last release, battery and locklogout have been merged to master ready for full fledged testing. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Using Plasma's QML bindings in a custom KDE application
Hi, I'm writing a kde application from scratch, that has a QDeclarativeView, which loads the qml files. Now if I want to use plasma's core/other qml bindings in my qml files, what do I need to do? Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
On Tue, May 1, 2012 at 6:25 PM, Marco Martin notm...@gmail.com wrote: it should be merged asap because freeze is on 3rd. can you do it either today, or i can do it as well? I just added confirmation dialog for sleep as well, and now i'm merging the branch. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
On Wed, May 2, 2012 at 5:19 AM, Viranch Mehta viranch.me...@gmail.comwrote: On Tue, May 1, 2012 at 6:25 PM, Marco Martin notm...@gmail.com wrote: it should be merged asap because freeze is on 3rd. can you do it either today, or i can do it as well? I just added confirmation dialog for sleep as well, and now i'm merging the branch. Okay I just merged the branch plasma/viranch/powermanagement containing the battery and lock/logout QML applets to master. Marco could you please review it to check if the merge was correct. Also, should I delete the branch now? If yes, git -d plasma/viranch/powermanagement git push will do it, right? Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/#review13257
---
Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3
- Viranch Mehta
On April 13, 2012, 6:18 p.m., Viranch Mehta wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/
---
(Updated April 13, 2012, 6:18 p.m.)
Review request for Plasma and Marco Martin.
Description
---
This patch essentially contains the new QML lock logout applet, along with
required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data
engine) since the same branch has QML battery applet. So it'd be best to
checkout plasma/viranch/powermanagementservices branch and compile
plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current
C++ version
Comments welcome on this thread :)
Diffs
-
plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
plasma/generic/applets/lock_logout/lockout.h 94f33cf
plasma/generic/applets/lock_logout/lockout.cpp 830e64b
plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104592/diff/
Testing
---
- Tested inside horizontal/vertical panels and floating on desktop, sizing
works as expected.
- There may be some unexpected behavior if the panel containing the applet is
changed from being horizontal to vertical or vice-versa.
Screenshots
---
Screenshot of the applet on desktop
http://git.reviewboard.kde.org/r/104592/s/526/
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review13258 --- Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3 - Viranch Mehta On April 3, 2012, 5:12 a.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated April 3, 2012, 5:12 a.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- with top right graphic in the popup http://git.reviewboard.kde.org/r/104226/s/487/ applet on the workspace http://git.reviewboard.kde.org/r/104226/s/503/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Review Request: Merge the final and fixed QML battery monitor to master.
On Wed, May 2, 2012 at 5:47 AM, Sebastian Kügler se...@kde.org wrote: Congrats, Viranch! You've done some excellent work here and delivered high- quality replacements for those important components. Thanks a lot, and chapeau! I'm glad I could be a part of contributing to kde! Marco has helped me improve and polish my work to a great extent. Thanks, Marco :) Looking forward to seeing my work in next release and fixing some kickass bugs ;) Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
On Mon, Apr 30, 2012 at 8:16 PM, Marco Martin notm...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104592/ any update on this? Kai here suggested that we have a KSMServer dialog for sleep/hibernate confirmations. I'm not sure how to achieve this, and I've been busy last month. I'll look into it in the next week. Another still pending issue is the shine on the icons when hovered. I searched a bit about shines in QML, without luck. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On April 17, 2012, 11:18 a.m., Kai Uwe Broulik wrote:
I just applied it to latest master and found a few usability issues:
* The settings dialog that contains all the configs is way too small
* The slider grab is 10 pixels to the left, some QML component issue
And the showstopper issue is:
There is no easy way to see the battery percentage. The overlay number is
no longer available. And also there is no tooltip, i.e. hovering the
plasmoid also does nothing. You _always_ have to click the battery plasmoid
to see the exact percentage.
The tooltip thing seems to be a general QML plasmoid issue, the new devicec
notifier also lacks one.
The patch is not up-to-date. Please checkout the branch
plasma/viranch/powermanagementservices and compile
plasma/generic/{applets/batterymonitor,dataengines/powermanagement}. That's
where all my latest commits have gone.
- Viranch
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12560
---
On April 3, 2012, 5:12 a.m., Viranch Mehta wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---
(Updated April 3, 2012, 5:12 a.m.)
Review request for Plasma.
Description
---
I fixed the QML battery monitor to be fairly usable and this diff merges it
to master.
Diffs
-
plasma/generic/applets/CMakeLists.txt 2dedcb2
plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION
plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION
plasma/generic/applets/batterymonitor/README.txt PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz
PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION
plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104226/diff/
Testing
---
Applet and dataengine both tested and work fine.
Screenshots
---
with top right graphic in the popup
http://git.reviewboard.kde.org/r/104226/s/487/
applet on the workspace
http://git.reviewboard.kde.org/r/104226/s/503/
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
On April 14, 2012, 10:11 p.m., Kai Uwe Broulik wrote:
Couldn’t we add a Hibernate dialog, similar to the confirmation on
shutdown, i.e that dialog that counts down Shutting down in 30 seconds
with the ability to cancel it? You press Hibernate, and a KSMserver dialog
(that we don’t have yet?) pops up and after 30 seconds, it will hibernate
anway. This way, if you miss the dialog, e.g. you are in a hurry, it will
proceed after the countdown runs out.
That seems like a good idea. Comments?
- Viranch
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/#review12448
---
On April 13, 2012, 6:18 p.m., Viranch Mehta wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/
---
(Updated April 13, 2012, 6:18 p.m.)
Review request for Plasma and Marco Martin.
Description
---
This patch essentially contains the new QML lock logout applet, along with
required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data
engine) since the same branch has QML battery applet. So it'd be best to
checkout plasma/viranch/powermanagementservices branch and compile
plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current
C++ version
Comments welcome on this thread :)
Diffs
-
plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
plasma/generic/applets/lock_logout/lockout.h 94f33cf
plasma/generic/applets/lock_logout/lockout.cpp 830e64b
plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104592/diff/
Testing
---
- Tested inside horizontal/vertical panels and floating on desktop, sizing
works as expected.
- There may be some unexpected behavior if the panel containing the applet is
changed from being horizontal to vertical or vice-versa.
Screenshots
---
Screenshot of the applet on desktop
http://git.reviewboard.kde.org/r/104592/s/526/
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: QML Lock/logout applet
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/
---
Review request for Plasma and Marco Martin.
Description
---
This patch essentially contains the new QML lock logout applet, along with
required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data engine)
since the same branch has QML battery applet. So it'd be best to checkout
plasma/viranch/powermanagementservices branch and compile
plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current C++
version
Comments welcome on this thread :)
Diffs
-
plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
plasma/generic/applets/lock_logout/lockout.h 94f33cf
plasma/generic/applets/lock_logout/lockout.cpp 830e64b
plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104592/diff/
Testing
---
- Tested inside horizontal/vertical panels and floating on desktop, sizing
works as expected.
- There may be some unexpected behavior if the panel containing the applet is
changed from being horizontal to vertical or vice-versa.
Screenshots
---
Screenshot of the applet on desktop
http://git.reviewboard.kde.org/r/104592/s/526/
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Couple of fixes to QML ScrollBar component
On Wed, Apr 4, 2012 at 3:51 PM, Sebastian Kügler se...@kde.org wrote: On Sunday, March 25, 2012 02:59:35 Viranch Mehta wrote: I didn't know how to test these from Gallery.qml (what command?). Tested, however, by putting in a test plasmoid. Works well now. I'm using: KDE_PLASMA_COMPONENTS_PLATFORM=touch qmlviewer -I \ /home/sebas/kdesvn/install/lib/kde4/imports/ That did the job! Thanks :) Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin notm...@gmail.com wrote:
here the biggest challenge i guess is making all resize correctly in
horizontal/vertical panels.
Yes, just spent 5 hours on this. Finally resizing works almost fine inside
and outside panels, except:
* it does not resize/change when the orientation of a panel changes (eg, top
panel is moved to right). i tried addEventListener('FormFactorChanged',
formFactorChanged); but the callback is never called.
* if the applet is on the desktop, the last visible icon in the list
flickers _a lot_
when the applet is resized. this happens for more than one icons visible,
and
happens to only the last icon.
* the c++ applet shows a confirmation box for suspend hibernate,
how can this be done in QML? how about showing our regular applet-popup
like in the battery monitor? with this option, the user also wouldn't have
to
move the mouse too much around the screen.
Cheers,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On Tue, Apr 3, 2012 at 7:24 PM, Daniel Nicoletti dantt...@gmail.com wrote: doesn't the kworskspace API handle the confirmation already? (I know it does for Shutdown, logoff and restart) kworkspace API is only used for leave (a combined action for logout, turn off, restart). for suspend actions, dbus calls are made. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On Tue, Apr 3, 2012 at 7:25 PM, Marco Martin notm...@gmail.com wrote: * the c++ applet shows a confirmation box for suspend hibernate, how can this be done in QML? how about showing our regular applet-popup like in the battery monitor? with this option, the user also wouldn't have to move the mouse too much around the screen. hmm, it should call just the ksmserver dialog, should be added to the service? (power? another one?) we have to simply show a KMessageBox as does the c++ applet. the qml applet uses power management engine for all the actions. putting it in power management services would also affect the suspend actions of battery monitor. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote: Looking good now, thanks a lot for your patience! I'm getting this TypeError still, haven't looked into the reason behind it: file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.qml:77: TypeError: Result of expression 'pmSource.data[PowerDevil]' [undefined] is not an object. I propose to merge it into master now. There's still a bit of polishing possible (margins, for example), but we can easily do those when it's in master. I'm not getting the TypeError here. About the merge, I have worked on QML lock/logout applet in the same branch. So should I just copy-paste QML battery monitor into master, or cherry-pick from the branch to preserve the history? - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review12114 --- On March 23, 2012, 6:20 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 23, 2012, 6:20 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- with top right graphic in the popup http://git.reviewboard.kde.org/r/104226/s/487/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin notm...@gmail.com wrote: hmm, not too happy about both, let's make lock/logout work as well then merge everything? That sounds fine. I'll soon open a review request. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated April 3, 2012, 5:12 a.m.) Review request for Plasma. Changes --- Add a screenshot of the applet when its in a panel. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots (updated) --- with top right graphic in the popup http://git.reviewboard.kde.org/r/104226/s/487/ applet on the workspace http://git.reviewboard.kde.org/r/104226/s/503/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Couple of fixes to QML ScrollBar component
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104402/ --- Review request for Plasma. Description --- This patch fixes following issues with QML Scrollbar component: - The hover and non-hover arrow images in vertical scrollbars are the same. - The down/right arrows are connected to events of mousearea of up/left arrows. - The mouseareas of the arrows do not have hoverEnabled property set to true. This is required to use their containsMouse property. Diffs - plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml 15ee7aa Diff: http://git.reviewboard.kde.org/r/104402/diff/ Testing --- I didn't know how to test these from Gallery.qml (what command?). Tested, however, by putting in a test plasmoid. Works well now. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 21, 2012, 9:20 a.m., Marco Martin wrote: let's merge then fix all the things that may remain ok? (if you are rady to quickly fix issues as they come in, because many will report ;) Viranch Mehta wrote: Yep, I'm ready. Sebastian Kügler wrote: I'd prefer if we wait with merging until all issues are fixed, there are still quite a few regressions here, from my testing: - discharge percentage isn't shown at all - the top right graphic in the popup is missing - information on the RHS doesn't match labels on the LHS - the Hibernate button is shown here, while the machine only supports sleep (works fine with old applet) - s/Powermanagement/Power Management - Lots of runtime warnings, especially about dereferencing missing datasources Sebastian Kügler wrote: I'm testing from the plasma/viranch/powermanagementservices branch, does that one contain the latest state of the art? Yes, the plasma/viranch/powermanagementservices branch contains the latest QML applet (including the following fixes): (I'm not updating the diff here anymore. Will do it when applet is ready.) - discharge percentage isn't shown at all - information on the RHS doesn't match labels on the LHS Fixed both. These were due to some serious mistakes in merge conflicts in last commit (my apologies) - the Hibernate button is shown here, while the machine only supports sleep (works fine with old applet) - Lots of runtime warnings, especially about dereferencing missing datasources Fixed both. Had forgotten to add Sleep States in connectedSources. - s/Powermanagement/Power Management Fixed this in the i18nc comment of the label Power management enabled:. Did I miss elsewhere? - the top right graphic in the popup is missing Added, and working. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11683 --- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 23, 2012, 6:20 p.m.) Review request for Plasma. Changes --- Screenshot update, showing the top right battery icon in the popup Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots (updated) --- with top right graphic in the popup http://git.reviewboard.kde.org/r/104226/s/487/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 21, 2012, 9:20 a.m., Marco Martin wrote: let's merge then fix all the things that may remain ok? (if you are rady to quickly fix issues as they come in, because many will report ;) Yep, I'm ready. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11683 --- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Changes --- Updated screenshot and the patch. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots (updated) --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 19, 2012, 7:23 p.m., Marco Martin wrote: as for comments on the screenshot, labels on the left should be right-aligned, the code seems fine now Labels now right-aligned. Screenshot updated. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11632 --- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 97 http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line97 horizontalAlignment: Text.AlignRight This doesn't work for some reason (the width of the Label item is same as that required by the painted text, not the width of the cell it is in). Instead of that, anchors.right: parent.right is used. On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line81 showRemainingTime? There is added condition: text!= showRemainingTime elsewhere. Hence here is simply connected to it. On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 130 http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line130 sleepButton and hibernateButton should be hidden when the system does not support it. Looks like this was forgotten here. Did you make sure it works? It's exposed in the dataengine, in Sleep States, keys: Suspend, Hibernate. Could be as simple as visible: powermanagmentEngine.data[Sleep States][Suspend] etc... Yes it was forgotten, thanks for pointing out. Added the visible condition. On March 20, 2012, 10:27 a.m., Viranch Mehta wrote: When installing from the plasma/viranch/powermanagementservices branch, I'm getting this error during installation: CMake Error at applets/batterymonitor/cmake_install.cmake:56 (FILE): file INSTALL cannot find /home/sebas/kdesvn/src/kde-workspace/plasma/generic/applets/batterymonitor/battery-oxygen.svgz. Can you have a look? Fixed. I'd recommend not to merge it from that branch though, because it also has lock_logout QML applet and few other things that might cause a lot of merge conflicts. Use the attached diff for merging. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11650 --- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 20, 2012, 10:02 p.m., Vishesh Handa wrote: Screenshot: http://git.reviewboard.kde.org This looks kind bad. There should be a certain amount of padding. There is already some default padding in the popup. It is stripped off while viewing in plasmoidviewer for some reason, notice the absence of top left and bottom left rounded corners. Should look fine when added to an actual workspace. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11667 --- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/482/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 5:48 p.m.) Review request for Plasma. Changes --- Properly translates all displayed text with comments to translators wherever necessary (all of the i18n/i18nc/i18np are taken from C++ version). Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 13, 2012, 5:32 p.m., David Edmundson wrote:
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66
http://git.reviewboard.kde.org/r/104226/diff/5/?file=53015#file53015line66
This i18n string doesn't really work.
1) This string doesn't really contain any words, so it's not really
suitable for translation. At least use i18nc() so translators have context
of what it is.
2) the state (i.e charging, charged, discharging) is never translated.
I have adopted the translation straight from the C++ applet now (except the
if-else logic):
if (pluggedIn) {
if (percent100) return i18n(%1 (charging), percent);
else return i18n(%1 (charged), percent);
} else {
return i18n(%1 (discharging), percent);
}
On March 13, 2012, 5:32 p.m., David Edmundson wrote:
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 101
http://git.reviewboard.kde.org/r/104226/diff/5/?file=53015#file53015line101
This isn't translated.
Also this is a word puzzle.
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles
You also can't do
if (hrs==1) {
hour
} else {
hours
}
for some languages plurals come after 1st, 11th 111th.. it's not as
simple as you just wrote.
use i18np.
We can achieve completely formatted and translated string only by
KLocale::prettyFormatDuration() as far as I know. But since we don't yet have
KLocale QML bindings, I have a temporary work around:
var time = new Date(remainingMsec);
var hrs = i18np(1 hour, %1 hours, time.getUTCHours());
var mins = i18np(1 minute, %1 minutes, time.getUTCMinutes());
return hrs+, +mins;
On March 13, 2012, 5:32 p.m., David Edmundson wrote:
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 108
http://git.reviewboard.kde.org/r/104226/diff/5/?file=53015#file53015line108
Don't do this to determine how wide something should be.
What if the japanese for power management enabled is only 3
characters long and the time remaining is larger?
Even if you could garauntee it's the longest string right now, what if
someone changes this in the future?
set the Grid to be
width:childRect.width.
and remove the call to width on all these labels, and that /should/
work. (I've not tested that and could be wrong.)
Discarded.
This was done to achieve right alignment to the labels (on the left side). For
now, they are all left-aligned due to this change.
- Viranch
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11360
---
On March 14, 2012, 5:48 p.m., Viranch Mehta wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
---
(Updated March 14, 2012, 5:48 p.m.)
Review request for Plasma.
Description
---
I fixed the QML battery monitor to be fairly usable and this diff merges it
to master.
Diffs
-
plasma/generic/applets/CMakeLists.txt 2dedcb2
plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION
plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION
plasma/generic/applets/batterymonitor/README.txt PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz
PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION
plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml
PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104226/diff/
Testing
---
Applet and dataengine both tested and work fine.
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 6:39 p.m.) Review request for Plasma. Changes --- Add screenshot. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots (updated) --- http://git.reviewboard.kde.org/r/104226/s/464/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 13, 2012, 5:32 p.m., David Edmundson wrote: Read up on i18n, ideally most of http://techbase.kde.org/Development/Tutorials/Localization/ and double check everything again. Also personally I like to submit a screenshot with any very visual change. Thanks for the link. Screenshot uploaded. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11360 --- On March 14, 2012, 6:39 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 6:39 p.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/464/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 6:46 p.m.) Review request for Plasma. Changes --- Fix the typo i18n(%1...) to i18n(%1%...) to show the '%' sign in Battery: field of the popup. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Screenshots --- http://git.reviewboard.kde.org/r/104226/s/464/ Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 9:51 a.m.) Review request for Plasma. Changes --- Temporarily remove i18n() for complex strings Alias plasmoid.rootItem.pmSource to pmSource Implement powermanagement enabled/disabled Make setScreenBrightness service job return void Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52425#file52425line81 This should not be in there, basically only if it has been enabled by config showRemainingTime (look at the C++ version when it's shown). We explicitely excluded this feature by default since the remaining time cannot be accurately computed. I don't see a showRemainingTime config in C++ version (I'm looking at master). Should I add this in the QML version? On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/dataengines/powermanagement/powermanagementjob.cpp, line 87 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52432#file52432line87 This line always sets result to false, no matter what happened earlier. I think the code you added here is correct, could you check why it worked earlier? The control reaches here only if there were no 'return's earlier. It works because there is a return inside each if case. So if the operation name was invalid, it would setResult(false), otherwise setResult(whatever the operation returns). On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52425#file52425line66 The word puzzle here is not translatable. You'll need to enclose a full string into i18n(), with the current code, translators can't figure out what the message is. Also, appending strings to each other doesn't work, as the word order might be different. So you have to identify the cases, and then return a completely translated string. For now, I'm dropping i18n() completely on such computed strings. On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 65 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52426#file52426line65 instead of plasmoid.rootItem.pmSource, try using just pmSource. If necessary, that means moving pmSource somewhere visible. Should make porting to QML2 easier. Just pmSource doesn't work because compactRepresentation is a Component, and hence pmSource cannot be moved to any visible location. This is the only way to do it AFAICT. Use of plasmoid.rootItem.pmSource can be reduced by assigning it to another variable inside the component. (Look at updated diff). On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 89 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52426#file52426line89 This guy is unnecessary, as the exact same info is already shown in the dialog. I'd prefer getting rid of this overlay altogether (including the config option). Getting this info from dialog requires two clicks (opening and closing the dialog). While this overlay simply displays it. We can still drop it if desired. On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 144 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52426#file52426line144 What's missing here? Either ditch // TODO, or add a note what's missing I figured out what should be done here, and implemented (see updated diff). - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11311 --- On March 13, 2012, 9:51 a.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 9:51 a.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52425#file52425line81 This should not be in there, basically only if it has been enabled by config showRemainingTime (look at the C++ version when it's shown). We explicitely excluded this feature by default since the remaining time cannot be accurately computed. Viranch Mehta wrote: I don't see a showRemainingTime config in C++ version (I'm looking at master). Should I add this in the QML version? Done. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11311 --- On March 13, 2012, 9:51 a.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 9:51 a.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 10:26 a.m.) Review request for Plasma. Changes --- Add a config option to show/hide remaining battery time. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:14 a.m.) Review request for Plasma. Changes --- Make the battery charge info string translatable as done in C++ version. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 http://git.reviewboard.kde.org/r/104226/diff/1/?file=52425#file52425line66 The word puzzle here is not translatable. You'll need to enclose a full string into i18n(), with the current code, translators can't figure out what the message is. Also, appending strings to each other doesn't work, as the word order might be different. So you have to identify the cases, and then return a completely translated string. Viranch Mehta wrote: For now, I'm dropping i18n() completely on such computed strings. Fixed it to work in a manner similar to the C++ one. - Viranch --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11311 --- On March 13, 2012, 11:14 a.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:14 a.m.) Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:59 a.m.) Review request for Plasma. Changes --- Take results from service operation calls (beginSuppressing...() and stopSuppressing...()) and store them in cookies. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs (updated) - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Merge the final and fixed QML battery monitor to master.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- Review request for Plasma. Description --- I fixed the QML battery monitor to be fairly usable and this diff merges it to master. Diffs - plasma/generic/applets/CMakeLists.txt 2dedcb2 plasma/generic/applets/battery/CMakeLists.txt 7794f88 plasma/generic/applets/battery/Messages.sh 8b06e2d plasma/generic/applets/battery/README.txt 5b352e8 plasma/generic/applets/battery/battery-oxygen-inkscape.svgz b68ba66 plasma/generic/applets/battery/battery-oxygen.svgz a037e60 plasma/generic/applets/battery/battery.h ebc1a3d plasma/generic/applets/battery/battery.cpp 3a5cda3 plasma/generic/applets/battery/batteryConfig.ui 5595ca2 plasma/generic/applets/battery/plasma-battery-default.desktop e254028 plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION plasma/generic/applets/batterymonitor/README.txt PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f Diff: http://git.reviewboard.kde.org/r/104226/diff/ Testing --- Applet and dataengine both tested and work fine. Thanks, Viranch Mehta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: A new way of QML PopupApplets
On Fri, Mar 2, 2012 at 2:47 PM, Marco Martin notm...@gmail.com wrote: On Friday 02 March 2012, Marco Martin wrote: yep, what i want to avoid is having to manage a dialog by hand more specifically what i want in palsma2 is every applet being able to specify that is collapsable and optionally specify a component for that representation. Cool! Is this stable enough now? If so, I'd like to update the battery monitor. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: A new way of QML PopupApplets
On Fri, Mar 2, 2012 at 3:35 AM, Marco Martin notm...@gmail.com wrote: right now it wasn't possible to write in qml those applets that are always collapsed to a tiny element, but *not* an icon, like the notifications or the digital clock. Aren't we already doing this thing in battery monitor? Its not collapsed to just an icon, and it has a popup. The tiny element (battery status svg) is in the main qml item of the plasmoid, and the popup component (power profiles, screen brightness, etc.) is inside a PlasmaCore.Dialog's mainItem. And this is without making it a PopupApplet. exporting a Component property compactRepresentation, will use that whatever widgets and fancy graphics contains as icon and will be always collapsed, just the same behavior of the c++ ones. This method does sound like a more convenient way of doing it though. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Access D-BUS through QML/JS
On Thu, Jan 12, 2012 at 12:20 PM, Shaun Reich shaun.re...@kdemail.netwrote: was wondering if and how I could call a remote method (org.freedesktop.screensaver) through a pure QML/JS applet. Do I need to use a dataengine? Should I make that dataengine C++ or JS? one obvious approach would be to implement a service that would make the dbus calls in a c++ dataengine; and call the service from the qml/js applet. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML plasmoid porting status needs updating?
On Fri, Dec 30, 2011 at 10:03 PM, Mark mark...@gmail.com wrote: Aren't the Digital Clock and Calendar one big element? Yes, Calendar is used in Digital Clock and Analog Clock and that's where I'm somewhat stuck now. It all depends on KLocale and KCalendarSystem. I still have to see how to get those into QML. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML plasmoid porting status needs updating?
On Fri, Dec 30, 2011 at 5:55 AM, Shaun Reich shaun.re...@kdemail.netwrote: This is woefully out of date, and I think it'd be a good idea for everyone to add what they're working on, where it is, etc, if everyone's okay with it. Because I want a good overview of what needs to be done and what is being worked on. http://community.kde.org/Plasma/PlasmoidScripting#Porting_Plasmoids_to_QML Thanks for pointing this out. I've updated what I'm working on. Additionally, is this pretty much the only QML plasma docs? http://techbase.kde.org/Development/Tutorials/Plasma/QML/API I have these bookmarked in addition to above: Development/Tutorials/Plasma/QML/GettingStarted - KDE TechBasehttp://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted Development/Tutorials/Plasma/JavaScript/API-PlasmoidObject - KDE TechBasehttp://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API-PlasmoidObject Development/Tutorials/Plasma/ThemeDetails - KDE TechBasehttp://techbase.kde.org/Projects/Plasma/Theme I don't really use the first one. The second one comes in handy when you want to play around with plasmoid object. The third is useful when you're using SVGs, it has the list of all available SVGs in 8th section. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Skrooge plasma dashboard: stuck with QML
On Wed, Dec 21, 2011 at 4:55 AM, Guillaume DE BURE guillaume.deb...@gmail.com wrote: I'm doing this in 4.7.90 (unstable archlinux packages) You should probably move to KDE compiled from git source. 1) widget size: --- even though I specified the widget size, if the dashboard contains only QML widgets, they appear with a very small width: http://wstaw.org/m/2011/12/20/plasma-desktopVB1577.png http://wstaw.org/m/2011/12/20/plasma-desktopav1577.png As soon as I add a C++ widget, the size is correctly computed: http://wstaw.org/m/2011/12/20/plasma-desktopbb1577.png Try adding X-Plasma-DefaultSize=600,600 in metadata.desktop and instead of width/height: 600 in main.qml, do the following: property int minimumWidth: 600 property int minimumHeight: 600 This might produce expected behavior. 2) PlasmaComponents.Label font size: -- For some reason, the font size there is significantly larger than in basic QML Text component. Any idea why ? You can simply use Text component wherever you just want to display text. 3) ListView highlight: --- With the aforementionned code, I can't seem to get the expected behaviour on highlighting items in the list. Any idea why ? The highlight follows the currentItem. So you need to add a MouseArea in your delegate with hoverEnabled: true and onEntered: list.currentIndex = index This will make the hovered item your list's current item and the highlight will follow it. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML Analog Clock
On Mon, Nov 14, 2011 at 4:41 PM, Viranch Mehta viranch.me...@gmail.comwrote: On Mon, Nov 14, 2011 at 1:35 PM, Marco Martin notm...@gmail.com wrote: On Friday 11 November 2011, Viranch Mehta wrote: On Fri, Nov 11, 2011 at 1:00 PM, todd rme toddrme2...@gmail.com wrote: Is there a QML version of the calendar widget yet? Nope. Viranch that can go for grades as well. replacing the internal clock leaving the calendar, then redoing the calendar for instance ok so i have been working on the qml calendar widget, and now there's another problem: the existing widget uses the complex KCalendarSystem to manage the various calendar systems (which have different no of months, days per month, names of months/weekdays, etc. also various logic like get weekday, week number from date, etc) so i was wondering if this would have to be taken care from c++ part (i have not yet plugged in any c++ part in the plasmoid). Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: bug killing
Hi, Could someone please post a log of the discussions as I couldn't make it. Cheers, Viranch On Dec 4, 2011 12:00 AM, Aaron J. Seigo ase...@kde.org wrote: On Saturday, December 3, 2011 17:37:01 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: On Saturday 03 December 2011 17:20:20 Aaron J. Seigo wrote: On Sunday, November 20, 2011 21:37:16 Aaron J. Seigo wrote: so .. 1700+ bugs. fun, huh? :) as an encouraging little update, thanks to everyone's combined efforts we are now down to ~1270 reports. that's ~500 fewer than when i sent the email 2 weeks ago. I want that, too. And it's only 410 bugs and kwin is down to 0. So please ehehe ;) seriously: we should do a bug days for kwin too.. maybe in january? assuming you need or could use the help for a good cleaning. Seriously: awesome job all of you. Keep that going. I'm pretty sure we can get plasma down to around 300 to 500 real bugs and that makes it managable. agreed... right now i'm looking at the 1000 mark as the next acheivable short-term goal. btw.. did a quick LOC count the other day and plasma is shipping nearly 300k LOC right now. that include Plasma Active, but not the applications, just the actual plasma bits. that doesn't include kwin, either, which itself is 92k+ LOC in kde-workspace. dr. konqi makes reporting bugs amazingly easy and pleasant now as well... given the feature-to-LOC ratio, it's quite evident why we have so many reports. but i'm quite enthused with how much progress was made in just 2 days (of admiteedly abnormal levels of effort ;) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML widget for the Skrooge plasma dashboard
Hi, On Mon, Dec 5, 2011 at 12:50 AM, Guillaume DE BURE guillaume.deb...@gmail.com wrote: file:///.../main.qml:36: Unable to assign [undefined] to QString text That would indicate that there is no source connected, right ? So what did I do wrong ? The DataSource has no property called count. Hence [undefined]. You can have a look at the API here: http://techbase.kde.org/Development/Tutorials/Plasma/QML/API#DataSource Also, since you've already declared connectedSources in the DataSource, you don't need to redo it inside Component.onCompleted ;) Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: bug killing
On Mon, Nov 21, 2011 at 2:07 AM, Aaron J. Seigo ase...@kde.org wrote: ** * hold a seminar on irc to help teach others effective bugs.kde.orgreport sqashing, plasma style I'm *very* interested in this! Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML Analog Clock
On Mon, Nov 14, 2011 at 12:50 PM, Aaron J. Seigo ase...@kde.org wrote: the point is so that we can eventually one day move off of QGraphicsView and onto the QML-only, OpenGL-accelerated QML SceneGraph :) Right! I totally missed the point about moving away from qgraphicsview ;) makes sense. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML Analog Clock
On Mon, Nov 14, 2011 at 1:35 PM, Marco Martin notm...@gmail.com wrote: On Friday 11 November 2011, Viranch Mehta wrote: On Fri, Nov 11, 2011 at 1:00 PM, todd rme toddrme2...@gmail.com wrote: Is there a QML version of the calendar widget yet? Nope. Viranch that can go for grades as well. replacing the internal clock leaving the calendar, then redoing the calendar for instance Yes, I actually thought of that too in the beginning. I think I'll start doing that now. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML Analog Clock
On Sat, Nov 12, 2011 at 8:10 PM, Marco Martin notm...@gmail.com wrote: how does this sound? That's helpful! But what about loading of the multiple custom config uis? If that part will also be taken care of by the c++ part, I don't see the point of doing this applet in qml at all. All that qml part does is to show few svgs and make them move around. Everything else is being done by c++. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML Analog Clock
On Fri, Nov 11, 2011 at 1:00 PM, todd rme toddrme2...@gmail.com wrote: Is there a QML version of the calendar widget yet? Nope. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
QML Analog Clock
Hi, I have recently started working on the QML analog clock plasmoid. I adapted basic code from declarative-plasmoids repo. I added and implemented the config dialog and options, and showing the timezone. What I'm stuck at: I saw the original analog clock uses clockapplet from libs/plasmaclock. This clock applet implements all the config dialog sections and the popup calendar widget UI and all kinds of other stuff. How can those be brought into this QML applet? I don't think its possible with only QML, so I think I'll have to plugin cpp code. But I'd like to listen to expert advice on how to do that or any other solution ;) Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML device notifier
On Sun, Oct 30, 2011 at 10:03 PM, Marco Martin notm...@gmail.com wrote: the system kcms is the only detail still missing :p after this is in, i'll merge it's in! commit: http://commits.kde.org/kdelibs/f53ef3872b3755350ca5eb99eea8ef3b96dd8c74 pushed to kdelibs KDE/4.7 branch -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Some help for recreating the Plasma Tool Box in QML
On Thu, Oct 20, 2011 at 7:57 PM, Mark mark...@gmail.com wrote: * What is the current way to get the basic KDE SC running from Git? Build kdelibs, kde-runtime, libkactivities and kde-workspace. * What environment variables do i need to set to use KDE from Git (libdir, bindir...)? I use the same old bashrc from techbase. * Which branches do i need for QML + KDE? Master on all of the above repos will do. * Where do i need to be for recreating the plasma tool box in QML? kdebase-workspace? I guess, but I'm not sure. * How do i get a QML file running without the window decorations (the current plasma tool box doesn't have decorations so i guess i don't want them in QML either) Well, I'm not sure if it is possible to just change a part of the panel (the tool box). You'd need to re-do the panel in qml, afaik. But again, not sure. * Target: KDE 4.8? I prefer to use KDE from git since (as far as i understand it) the new KDE QML components made during this GSoC are in either a special git branch or in the branch that becomes KDE 4.8. And i'm kinda fearing odd problems if i use git for that but KDE 4.7 for the rest. Please do correct me if i'm wrong. I think that covers about all my questions. Last but not least. Above is just my idea of what i'd like to do. I've not spend any time yet on making anything and don't know if anyone else is already working on this. I also don't know if this is a change people want.. So some more information here would be nice. Kind regards and thanx in favor for any responses, Mark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Junior job] Re: translations of qml plasmoids
Hey, On Wed, Oct 19, 2011 at 5:39 PM, Marco Martin notm...@gmail.com wrote: so, the translation of the activity screen plasmoid worked, http://websvn.kde.org/trunk/l10n-kde4/templates/messages/playground- base/org.kde.active.activityscreen.pot?revision=1259592view=markup that means, a proper adapted Messages.sh file has to be added in every plasmoid file. that's a quite easy and boring job, also a quite easy junior job... anybody interested? :p I have never worked with translations. Could you summarize the steps for this? Thanks, Viranch Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
QML DataSource
Hi all,
I am facing a very annoying problem in QML plasmoids with the dataengines.
The following does not seem to work ever for almost all dataengines:
PlasmaCore.DataSource {
id: dataSource
engine: someEngine
onSourceAdded: print (data[source][some_valid_key];
}
The print statement always throws data[source] is [undefined]. This happens
with
most engines, esp with those engines where sources are added/removed
dynamically
by the engine. This has been very annoying, any help will be awesome!
Thanks,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Some simple ideas for desktop 4.8
About borders.. The blue window glow around the windows is also quite oldish, of course, personally :) I have turned it off, since windows look much better without the glow, also dragging windows is much faster when compositing is on, without the glow (at least on my 3-year old laptop). So it would be a good thought to have it disabled by default (of course, let there be the option to enable it) Just a thought :) Cheers, Viranch On Sun, Sep 25, 2011 at 9:11 PM, Alex Fiestas afies...@kde.org wrote: On Sunday, September 25, 2011 05:28:12 PM Martin Gräßlin wrote: On Sunday 25 September 2011 16:24:25 Alex Fiestas wrote: Hi there ! I've been using the default settings for a while now (like 1month) and I'd like to propose a couple changes for 4.8, let's see what are your opinions: 1-Show the same windows in Window switcher and Taskbar: Right now by default, Window Switcher is showing only the windows in the current desktop while the taskbar is showing the windows in all desktop. This has been very confusing for me since I'm not able to access to a window I'm seeing in the taskbar via Window Switcher. I don't care wether we switch both to Show only windows in this workspace or the other way, but both should show the same. With window switcher you mean Alt+Tab, right? Yes, the default Box one Having those two synced sounds reasonable and I would suggest to go for only current desktop as by default it's only one desktop and means less clutter. Well activating this we have the problem that libtaskmanager is quite broken right now, so we must fix it if we turn this option on by deafult. without borders you cannot resize the window. Yes you can, a small grabber? appears on the bottom-right, but I can see how that is less usable if you don't know it, though in the other hand that solution quite common these days, for example web-textareas. Nuno has been begging me to improve the situation and maybe I get to do something about it. Anyway this is something Nuno has to decide and IIRC he wants to have it on per app basis, e.g. Konsole without borders, others with borders. Apart from that we can hardly change anything in a general way for window decorations. This would have to be completely inside the Oxygen decoration. Oki, then I will wait to see what Nuno thinks about this :p ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Order QML plasmoid context menu
On Sun, Sep 18, 2011 at 5:21 AM, Francesco Nwokeka francesco.nwok...@gmail.com wrote: Hi guys, wanted to notify about an issue. Currently it's possible to add actions to a QML plasmoid's context menu. But this menu is not ordered in any way. Nor by insertion and nor alphabetically. So I wanted to know, is there some hidden function to do this (order the list of actions) or does it still have to be implemented? Actions are added in the order of plasmoid.setAction function calls, followed by the standard entries. Eg: plasmoid.setAction(act1, myAction1, icon1); plasmoid.setAction(act2, myAction2, icon2); would look like: myAction1 myAction2 Plasmoid's settings Desktop settings -- Remove this plasmoid As far as re-ordering is concerned, I don't think there is any way to do such a thing, but I might be missing something too. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
Hi, I have incorporated the device notifications in the device notifier applet now (though not fully functional). I have also worked on fixing sizing issues in lock/logout applet, without significant luck. I guess they can be merged now and further fixes can be done after the merge. Cheers, Viranch On Thu, Sep 15, 2011 at 3:45 PM, Viranch Mehta viranch.me...@gmail.comwrote: On Wed, Sep 14, 2011 at 2:43 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 14 September 2011, Aaron J. Seigo wrote: On Tuesday, September 13, 2011 20:39:20 Viranch Mehta wrote: Also, I would like to make a note here that battery monitor and lock/logout speaking of lock/logout and applets which are essentially rows of icons ... has someone worked out the issues around QML widgets not have size hints and appropriate sizing of applets like lock/logout in panels in plasma-desktop? yep, the slc applet should have correct sizing now. unfortunately it requires some manual calculation from the qml side since is not something offered stock, but if the root element offers minimumWidth and minimumHeight the applet will use them as minimum size hints. How about using plasmoid.resize(w,h)? in plasma2, in the case of a scene that doesn't have qgraphicswidgets in the middle, sizing of things should be a bit easier and a tad more automatic (just remains pretty hard do to expanding things like the taskbar) Viranch, that should be done for the lock/logout applet as well Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
On Wed, Sep 14, 2011 at 2:43 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 14 September 2011, Aaron J. Seigo wrote: On Tuesday, September 13, 2011 20:39:20 Viranch Mehta wrote: Also, I would like to make a note here that battery monitor and lock/logout speaking of lock/logout and applets which are essentially rows of icons ... has someone worked out the issues around QML widgets not have size hints and appropriate sizing of applets like lock/logout in panels in plasma-desktop? yep, the slc applet should have correct sizing now. unfortunately it requires some manual calculation from the qml side since is not something offered stock, but if the root element offers minimumWidth and minimumHeight the applet will use them as minimum size hints. How about using plasmoid.resize(w,h)? in plasma2, in the case of a scene that doesn't have qgraphicswidgets in the middle, sizing of things should be a bit easier and a tad more automatic (just remains pretty hard do to expanding things like the taskbar) Viranch, that should be done for the lock/logout applet as well Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: merging declarative plasmoids
Hi, First of all, I apologize for my prolonged absence. But I'd like to give some relevant updates from my side. I'm currently working on the device notifier implementing the mount/unmount messages (safe to remove now, mount failed, unmount failed, etc). It will be mostly done in a day or two. I think that is the main thing missing with the applet, so it can be merged after I'm done with this (i would merge it myself but I'm a little inexperienced with it). I'll post here after this is got over with. Also, I would like to make a note here that battery monitor and lock/logout BOTH are in plasma/viranch/powermanagementservices branch. So if it is merged, both the applets will come into the master (Sorry for this as I was unfamiliar with git branching earlier). The device notifier is in plasma/viranch/devicenotifier and task manager in plasma/viranch/tasks as would be expected. Cheers, Viranch On Tue, Sep 13, 2011 at 6:12 PM, Marco Martin notm...@gmail.com wrote: On Tue, Sep 13, 2011 at 2:23 PM, Giorgos Tsiapaliwkas terie...@gmail.com wrote: On 13 September 2011 02:19, Aaron J. Seigo ase...@kde.org wrote: On Sunday, September 11, 2011 13:54:07 Marco Martin wrote: the device notifier and the battery one. if, and only if, there are no functional regressions. Does someone has an answer for this one?Otherwise i will start testing the QMLified applets. modulo che config dialogs, the battery applet should be a 100% functional copy, has to be tested if the combobox was finally fixed and if all options even the hidden ones are available. the devicenotifier should also be near completition, not sure about the last item open by default, has to be tested in any case, in order to have 100% functional match, should be less than a day of work. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Opinion on config dialog for QML plasmoids
On Thu, Aug 18, 2011 at 2:09 AM, Marco Martin notm...@gmail.com wrote:
i tought i explained it: a QMapQString, QString will never work.
you need to change it to QMapQString, QVariant, as easy as that
That doesn't work either (I had tried it when it was made QVariantMap in the
engine). It works if I access in the following manner:
Text {
text: dataSource.data[PowerDevil][Available profiles][Performance]
}
But not in the case:
Component.onCompleted: {
var profiles = dataSource.data[PowerDevil][Available profiles];
// do stuff with the map, eg iterate
}
The latter simply stops at the first line inside the onCompleted saying,
dataSource.data[PowerDevil] [undefined] is not an object, and just
wouldn't go any further. The former cannot be used because we wouldn't know
names of all the profiles beforehand. Hence we need to iterate over the keys
and get the values from the map, which, as I said, is not working even with
QVariantMap.
Viranch
--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Opinion on config dialog for QML plasmoids
On Thu, Aug 18, 2011 at 5:13 PM, Viranch Mehta viranch.me...@gmail.comwrote:
Component.onCompleted: {
var profiles = dataSource.data[PowerDevil][Available profiles];
// do stuff with the map, eg iterate
}
Fixed. The above code (for getting the map and iterating) had to be put
inside MouseArea.onClicked (which is for showing the popup dialog of battery
applet). For some reason, it worked there, but wouldn't work inside any
Component.onCompleted. So everytime it is clicked, the map gets populated,
clear the combo box first and then add each item in the combo box. This
seems kind of a dirty work around, but works for now.
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Opinion on config dialog for QML plasmoids
On Wed, Aug 17, 2011 at 3:30 PM, Marco Martin notm...@gmail.com wrote: at the moment the only thing stopping the battery and the device notifier to me merged in master is the system kcms missing. Let me point out here that the battery still somehow lacks the ability to recognize the QStringStringMap power profiles returned by the dataengine. I'm not sure how this can be fixed with the JS bindings, otherwise I would have done it. Aaron did commit some patch for this, but did not seem to work in the plasmoid. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Switching to different widgets on each desktop resets the plasma-desktop
On Thu, Aug 11, 2011 at 1:13 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, August 11, 2011 06:37:54 Viranch Mehta wrote: I go to system settings and change the relevant setting. This suddenly scraps away all my current plasmoids and gives me empty desktops. This is the widgets should still be there, but likely put into a different activity. what you describe is a one-time issue at configuration, and while not the perfect experience it's not something i plan to put any more effort into improving as we have far too many other things on our plate. Do we have any page on techbase (or somewhere else?) where such minor issues are listed? That would be helpful so that we can tackle these as and when possible. Cheers, Viranch patches are welcome, however. i will not accept patches that just add a warning dialog, however. any patches made should be real fixes (e.g. making sure the existing containment gets used in the set of desktop containments) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Switching to different widgets on each desktop resets the plasma-desktop
Hi, This is an issue I just came across. Here's the scenario: I have a set of plasmoids on my plasma desktop that is shown on every virtual desktop. Now I decide I want to use different set of plasmoids on each virtual desktop. So I go to system settings and change the relevant setting. This suddenly scraps away all my current plasmoids and gives me empty desktops. This is probably irritating to a user, he might have useful todo's and notes on his desktop, which he loses on changing this setting without any warning. This can be taken care of: ask the user on which desktop he wants the current set of plasmoids to be (or he wants to throw them away) before changing this setting. Until this is done, we can have a dialog, warning the user of losing all his current plasmoids. Comments? Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Opinion on config dialog for QML plasmoids
Hi, Currently the only way QML applets can have customized config dialog is to put the config.ui file in the main.qml directory which is loaded when settings are opened. We have reached a use case where we need a number of settings that are categorized into tabs on left side of the config dialog (like the one in device notifier, which loads the KCM module from the system settings). This would have to be implemented in the bindings, but not too sure if it should be done due to the uncertainty of this particular kind of use case. It would be nice to have people's opinion on whether it is a desired use case to implement it. Also whether to support the KCM modules too inside the config dialog. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML model with image and text per element
On Mon, Jun 27, 2011 at 12:16 AM, Shaun Reich predator...@gmail.com wrote:
Okay, so if the data is laid out as you said, in the last example..how
would I display that in the qml view? Since I need to display *both*
the icon and the user's name in the model. Give me something concrete,
please -- as you well know, the docs suck ;-)
With the method you prefer, you can have something like:
model: mainEngineSource.keysForSource(userList)
Component {
id: delegateItem
Item {
Image { source:
mainEngineSource.data[userList][modelData][image] }
Text { text: mainEngineSource.data[userList][modelData][name] }
}
and assign delegate: delegateItem in the view.
Hope this helps.
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Notify of hovering over icon widget
On Wed, Jun 22, 2011 at 1:00 PM, Aaron J. Seigo ase...@kde.org wrote: can you use the onEnter/onExit properties with a MouseArea? Well, I want the background of the IconWidget to be painted when hovered (by doing drawBackgournd: true). But the problem with putting MouseArea on the IconWidget is, the IconWidget does not detect hovers and doesn't paint the background. While if the MouseArea is below the IconWidget, I can't get to do other stuff on hover. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Notify of hovering over icon widget
On Wed, Jun 22, 2011 at 2:57 PM, Marco Martin notm...@gmail.com wrote: avoid to use IconWidgets, use a QIconItem from extracomponents or even an Image with an icon://iconname source. Does that let me do the drawBackground stuff? then all the mouse input you do is with a MouseArea, that has all the events you need. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Notify of hovering over icon widget
Hi, I've reached a use case where I need a signal to be generated in QML when an IconWidget is hovered. I don't see one implemented. I was thinking of doing the same in kdelibs and was looking for feedback. Also, whether I should do it in master or elsewhere. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: DataEngine compilation problems
Remove line 18 and add datarequest.cpp to line 17. So it would look like this: set(obsdataengine_engine_SRCS obsdataengine.cpp datarequest.cpp) Hope this helps. Cheers, Viranch On Fri, Jun 10, 2011 at 11:11 PM, Saurabh Sood saurabhsoo...@gmail.comwrote: Hi all, I am trying to write a dataengine, that makes API calls to the Open Build Service (OBS) and displays the results in plasmoids. I have written part of the dataengine, but am facing problems in compiling it. I am getting undefined reference errors when I try to create an object of the datarequest subclass. Link to Code: https://gitorious.org/build-service-plasma-widgets Error List: http://pastebin.com/hdChx9zz Have I missed something in my implementation? Please guide me on tackling these errors. Hoping to hear soon, Saurabh Sood ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Still cannot access QMap in QML
On Thu, Jun 9, 2011 at 2:58 PM, Aaron J. Seigo ase...@kde.org wrote: On Wednesday, June 8, 2011 23:20:02 Viranch Mehta wrote: I am still unable to access QMapQString,QString returned by dataengine in and you are using kde-runtime from master? Yes, I pulled and compiled it after you fixed this. Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Still cannot access QMap in QML
On Thu, Jun 9, 2011 at 3:40 PM, Aaron J. Seigo ase...@kde.org wrote:
On Wednesday, June 8, 2011 23:20:02 Viranch Mehta wrote:
print(dataEngine.data[PowerDevil][Available profiles]);
wait .. what is dataEngine? is it the actual dataEngine? or? it's
entirely
impossible to tell what this code is actually doing without a bit more
context.
Here's the dataEngine:
PlasmaCore.DataSource {
id: dataEngine
engine: powermanagement
connectedSources: [AC Adapter, Battery, Battery 0, PowerDevil]
interval: 0
}
Everything else works fine. I'm able to get the battery charge info, whether
its plugged in to AC source or not, etc.
Cheers,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Still cannot access QMap in QML
Here's the plasmoidviewer's output: http://paste.kde.org/80143/ (the
pmSource in the output=dataEngine)
http://paste.kde.org/80143/Though it says dataEngine.data[AC Adapter],
dataEngine.data[Battery0], dataEngine.data[PowerDevil] are [undefined],
I'm able to access the data associated with the sources.
On Thu, Jun 9, 2011 at 3:50 PM, Viranch Mehta viranch.me...@gmail.comwrote:
On Thu, Jun 9, 2011 at 3:40 PM, Aaron J. Seigo ase...@kde.org wrote:
On Wednesday, June 8, 2011 23:20:02 Viranch Mehta wrote:
print(dataEngine.data[PowerDevil][Available profiles]);
wait .. what is dataEngine? is it the actual dataEngine? or? it's
entirely
impossible to tell what this code is actually doing without a bit more
context.
Here's the dataEngine:
PlasmaCore.DataSource {
id: dataEngine
engine: powermanagement
connectedSources: [AC Adapter, Battery, Battery 0, PowerDevil]
interval: 0
}
Everything else works fine. I'm able to get the battery charge info,
whether its plugged in to AC source or not, etc.
Cheers,
Viranch
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Still cannot access QMap in QML
Hi, I am still unable to access QMapQString,QString returned by dataengine in QML. The piece of JS goes like: print(hello); print(dataEngine.data[PowerDevil][Available profiles]); print(world); And it prints only hello, nothing else. I went through the code of JS bindings in runtime, tried playing around with it without luck. I'm totally clueless on this now. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QMap in QML
On Sat, Jun 4, 2011 at 7:54 PM, Aaron J. Seigo ase...@kde.org wrote: this is a problem in the JS bindings. i've fixed it in master, which will become 4.7.0 ... i woul dlike to find a better fix, however.. Is it only StringStringMap specific? Because, we'll be seeing new dataengines coming up and present ones changing in future, and there may be other datatypes begin used as well, like QHash, QPair, etc. So wouldn't we need a generic fix? Unless, we restrict the dataengines to use only the basic datatypes. Also, I could not build kde-runtime after the StringStringMap fix, says: ‘qt_metatype_id’ is not a member of ‘QMetaTypeIdPlasma::Service*’ kde-runtime/plasma/scriptengines/javascript/simplebindings/dataengine.cpp:66:104: instantiated from here and kde-runtime/plasma/scriptengines/javascript/simplebindings/dataengine.cpp:68:113: instantiated from here Thanks, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
