D11069: [WIP] refine decoration shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29072.
zzag added a comment.


  fix previous update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29071=29072

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  CMakeLists.txt
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-09 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 29071.
zzag added a comment.


  move box shadow helper out to a separate library

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28893=29071

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-09 Thread Fabian Riethmayer 
fabianr added a comment.


  In D11069#221381 , @zzag wrote:
  
  > So, I'd spent last two hours trying to find good menu shadow params.. HIG 
guidelines don't say too much about shadows(also, navigating them is hard) so I 
don't know whether these shadows are good.
  
  
  As you noticed HIG has very few information on shadows, it would be great if 
the results of this review could also be added to the hig. 
  https://hig.kde.org/resources/contribute.html

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-08 Thread Vlad Zagorodniy 
zzag added a comment.


  In D11069#221385 , 
@hpereiradacosta wrote:
  
  > > - What's the best way to share code between KStyle and KDecoration 
plugin? (currently, I'm symlinking files)
  >
  > File links is not an option.  (it breaks when you make tarballs of when 
compiling on e.g. windows)
  >  You would need to move the files away in a separate folder, compile them 
in a library, link the library to both kstyle and kdecoration. Oxygen does that.
  
  
  Thanks, I'll take a look at oxygen.
  
  > I'd say yes, as soon as you provide different shadow sizes for the windows 
(that also answers the last question)
  
  Well, than I would like to get help with params. I believe computed params 
won't produce good looking results so they have to be hand picked, maybe I'm 
wrong. VDG folks, if you know CSS, you can help!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-08 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  > Some questions:
  > 
  > - Do we really need different shadow sizes for menus, etc? Can we use 
single shadow size in kstyle?
  
  I'd say yes, as soon as you provide different shadow sizes for the windows 
(that also answers the last question)
  
  > - Do menus have outlines? If you look at picture above, you can see grey 
"gap" between menu and submenu.
  
  yes menus have outlines. In fact, in the old shadows, windows also had an 
outline. (drawn with the shadow).
  We want to keep it as far as I know.
  
  > - What's the best way to share code between KStyle and KDecoration plugin? 
(currently, I'm symlinking files)
  
  File links is not an option.  (it breaks when you make tarballs of when 
compiling on e.g. windows)
  You would need to move the files away in a separate folder, compile them in a 
library, link the library to both kstyle and kdecoration. Oxygen does that.
  
  > In addition to the first question, it's a little bit weird that changing 
window decoration shadow size also changes shadows "in apps" (e.g. menu shadows 
would have different size, etc).
  
  Why weird ? if I want "large shadows" I want them large for everything that 
have shaodws (with possible hierarchy). And if I want small I want them all 
small. 
  That seems natural to me.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-08 Thread Vlad Zagorodniy 
zzag added a comment.


  So, I'd spent last two hours trying to find good menu shadow params.. HIG 
guidelines don't say too much about shadows(also, navigating them is hard).
  F5745942: menu-shadows.png 
  
  You can help by providing CSS shadows.
  
  Some questions:
  
  - Do we really need different shadow sizes for menus, etc? Can we use single 
shadow size in kstyle?
  - Do menus have outlines? If you look at picture above, you can see grey 
"gap" between menu and submenu.
  - What's the best way to share code between KStyle and KDecoration? 
(currently, I'm symlinking files)
  
  In addition to the first question, it's a little bit weird that changing 
window decoration shadow size also changes shadows "in apps" (e.g. menu shadows 
would have different size, etc).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-07 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28893.
zzag added a comment.


  take scaling factor into account

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28874=28893

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28874.
zzag added a comment.


  edit comments

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28868=28874

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28868.
zzag added a comment.


  bump default shadow strength to 80%

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28863=28868

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Nathaniel Graham 
ngraham added a comment.


  That looks pretty darn nice.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  Large shadows with 80% strength
  
  F5743746: Screenshot_20180306_215756.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  TODO:
  
  - handle HiDPI

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28863.
zzag added a comment.


  change box shadow api

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28847=28863

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  Because shadow strength isn't ignored anymore, kstyle shadows should be 
updated
  F5743558: ftw.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28847.
zzag added a comment.


  take shadow strength into account

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28833=28847

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Nathaniel Graham 
ngraham added a comment.


  So in general, I like the more rounded edges. But I still don't like the 
darker shadows and the big black line on the bottom.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  Left - old
  Right - new
  
  ---
  
  Small
  
  F5743502: small.png 
  
  Medium
  
  F5743505: medium.png 
  
  Large
  
  F5743510: large.png 
  
  Very Large
  
  F5743512: very-large.png 
  
  ---
  
  God, Phabricator is awful! Image upload sometimes works, sometimes not. Also, 
typing a comment is very CPU intensive.. :/

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  In D11069#219980 , 
@hpereiradacosta wrote:
  
  > - I agree with Nathan that the bottom part is likely too hard.
  
  
  I've added opacity prop so different shadows could be tweaked("darkess" at 
the bottom is coming from the contrast shadow). Also, shadow strength is 
ignored... And again, shadow params is an open question.
  
  > - I think the same shadows should be used for windows and menus
  
  Yep, that's why I rejected the idea to approximate deco shadows. I've been 
thinking about moving shadow creation logic out so it could be used by 
KDecoration and KStyle plugin. What's your opinion on this?
  
  I would like to get input from VDG folks how menu shadows should look like.
  
  > - Also, thanks for posting the pictures. Is there any chance you could also 
post new vs old shadows side by side for the different sizes ? I have the 
feeling that for a given shadow size the new shadows appear larger ...
  
  OK. I'll post later.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 28833.
zzag added a comment.


  control look of each separate shadow with the opacity prop

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28755=28833

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  Hello,
  
  - I agree with Nathan that the bottom part is likely too hard.
  - I think the same shadows should be used for windows and menus
  - Also, thanks for posting the pictures. Is there any chance you could also 
post new vs old shadows side by side for the different sizes ? I have the 
feeling that for a given shadow size the new shadows appear larger ...
  
  Tanks in advance !
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy 
zzag added a comment.


  In D11069#219853 , @ngraham wrote:
  
  > I don't like how black the shadow is on the bottom. Once the strength 
adjustment works, we might experiment with reducing it.
  
  
  Yeah.. Shadow strength should at most 90%.
  
  In D11069#219503 , @zzag wrote:
  
  > About KStyle: I suggest to use gradients in order to approximate decoration 
shadows. It doesn't have big shadows so we don't need big precision. Also, I 
suggest to make them lighter.
  
  
  Forget about it. Bad idea.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Nathaniel Graham 
ngraham added a comment.


  I don't like how black the shadow is on the bottom. Once the strength 
adjustment works, we might experiment with reducing it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag added a comment.


  None
  
  F5742456: none.png 
  
  Small
  
  F5742458: small.png 
  
  Medium
  
  F5742460: medium.png 
  
  Large
  
  F5742462: large.png 
  
  Very Large
  
  F5742465: very-large.png 
  
  but background also matters
  
  F5742471: with-bg.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag added a comment.


  About KStyle: I suggest to use gradients in order to approximate decoration 
shadows. It doesn't have big shadows so we don't need too much of precision. 
Also, I suggest to make them lighter.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag added a comment.


  In D11069#219426 , 
@hpereiradacosta wrote:
  
  > Hello, 
  >  Thanks for the patch.
  >
  > - As we discussed already in telegram, I am not convinced you absolutely 
need fast fourier transform nor blur, and could probably handled thing with 
"simple" QGradients. If you do not have time to try implement such a solution, 
I can give it a shot myself whenever there is time.
  
  
  It's a little bit hard(at least for me) to make good lookin shadows with 
gradients. For example, how would someone handle corners with gradients? Blur 
makes things much easier..
  
  So, yeah, could you please implement these softer shadows with gradients?
  
  > - I can also help with moving the loading and destroying of the shadow to 
the pluggin loading/unloading rather than to first and last window opening. 
(this could also go in with the current shadows in fact, and would rather be a 
separate patch).
  
  It would be great to get help with plugins. I'm not familiar with KPlugin 
shenanigans
  
  > - Also, these shadows look nice but are rather strong. To me they represent 
a shift of paradigm with respect to the original (subtle) breeze ideas. But 
that is not me to decide. Still: could you also post screenshots with the 
smaller sizes ? And then we can discuss what the default size should be.
  
  They're not final. Shadow params is an open question. Yes, I'll post them 
later.
  
  Also, could some of original Breeze authors review this too?
  
  > - finally, I really don't think we need too separate setting for the two 
shadow strength. These are just implementation details. IMHO. And will make the 
code very hard to maintain. (how do you test that all combinations of settings 
look good ?)
  
  These shadows are softer than shadows in kstyle. So, single shadow strength 
option doesn't fit for both of them, it either
  
  - makes decoration shadows very light, and kstyle shadows normal
  - makes decoration shadows normal, and kstyle shadows really dark
  
  I'm still thinking about it, having two different shadow styles is not OK.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  Hello, 
  Thanks for the patch.
  
  - As we discussed already in telegram, I am not convinced you absolutely need 
fast fourier transform nor blur, and could probably handled thing with "simple" 
QGradients.
  
  If you do not have time to try implement such a solution, I can give it a 
shot myself whenever there is time.
  
  - I can also help with moving the loading and destroying of the shadow to the 
pluggin loading/unloading rather than to first and last window opening. (this 
could also go in with the current shadows in fact, and would rather be a 
separate patch).
  - Also, these shadows look nice but are rather strong. To me they represent a 
shift of paradigm with respect to the original (subtle) breeze ideas. But that 
is not me to decide. Still: could you also post screenshots with the smaller 
sizes ? And then we can discuss what the default size should be.
  - finally, I really don't think we need too separate setting for the two 
shadow strength. These are just implementation details. IMHO. And will make the 
code very hard to maintain. (how do you test that all combinations of settings 
look good ?)
  
  Others opinion welcome, of course.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Hugo Pereira Da Costa 
hpereiradacosta added a reviewer: hpereiradacosta.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag added a comment.


  TODOs:
  
  - separate shadow strength settings
  - improve performance
- do not delete cached shadow when last decoration is destroyed?
- or, use a faster blur algorithm(i.e. approximate gaussian blur), like 
exponential blur?
- create shadow on startup(e.g. during splash screen) and delete shadow on 
shutdown?
  - revise shadow params

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag planned changes to this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-05 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added reviewers: Breeze, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  5.12 release introduced new decoration shadows. These new shadows are
  bigger, centered, and they try to solve a problem related to depth.
  Yet, there are still some problems:
  
  - new(5.12) shadows are hard.
  - lighting model is broken. Because 5.12 shadows have been centered and made 
bigger, they should be casted from north.
  
  This change refines how decoration shadows look:
  
  - shadows are casted from north(shadow under window is bigger and darker, 
side shadows are smaller, etc);
  - shadows are made up of several separate shadows(one for overall shape, 
another for contrast). The separate shadows are produced by using box shadow 
helper(something similar to CSS box-shadow property, except there are no inset 
and spread properties);
  - shadow sizes(e.g. Small, Medium, and so on) haven't changed.
  
  Because GPUs can't be used for blurring images(in our case), the box shadow
  helper is using CPU to blur images. More precisely, when blur radius is < 64,
  images are blurred with "separable convolutions", otherwise, images are 
blurred
  with a two-dimensional Fourier Transform.
  
  Depends on D10942 
  Depends on D10811 

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart