subject:"D28154\: Add users KCM"

D28154: Add users KCM

2020-05-22 Thread Filip Fila

filipf added a comment.


  In D28154#672453 , @ngraham wrote:
  
  > Now that D29394  has landed, you can 
add those images here!
  
  
  .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-21 Thread Carson Black

cblack closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-20 Thread Carson Black

cblack updated this revision to Diff 83095.
cblack added a comment.


  Rename to kcm_users

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=83079=83095

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/kcm_users.desktop
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-20 Thread Méven Car

meven added a comment.


  So next step would be to shadow user_manager ?
  
  A naive ripgrep gave :
  
$ rg user_manager ..
../kxmlgui/src/kbugreport.cpp
352:m_process->start(QStringLiteral("kcmshell5"), QStringList() << 
QStringLiteral("user_manager"));

../systemsettings/sidebar/SidebarMode.cpp
130:item->setData(QUrl(QStringLiteral("kcm:user_manager.desktop")), 
ResultModel::ResourceRole);

../plasma-desktop/applets/kickoff/package/contents/ui/Header.qml
128:KCMShell.open("user_manager")
130:visible: KCMShell.authorize("user_manager.desktop").length > 0

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-20 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in UserDetailsPage.qml:97
> Pfp?

profile picture

> broulik wrote in UserDetailsPage.qml:219
> Is this `RowLayout` needed?

it's a convenience for the default alignment of a layout (`Qt.AlignVCenter | 
Qt.AlignLeft`)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham

ngraham added a comment.


  Great, that works!
  
  BTW I think you can change the KCM name to `kcm_users` as you originally 
wanted. Sorry for saying otherwise.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-19 Thread Carson Black

cblack updated this revision to Diff 83079.
cblack added a comment.


  Focus the stackSwitcher when opening the sheet

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=83074=83079

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham

ngraham added a comment.


  The avatar sheet still does not close with Esc. :/

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-19 Thread Carson Black

cblack updated this revision to Diff 83074.
cblack marked 17 inline comments as done.
cblack added a comment.


  Address code concerns; add escape keyboard gesture

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82214=83074

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-17 Thread Nathaniel Graham

ngraham added a comment.


  Now that D29394  has landed, you can add 
those images here!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-13 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> ngraham wrote in UserDetailsPage.qml:217
> FWIW KCMs opened through KRunner are now opened in System Settings so 
> KCMShell is something we're going to have to deal with much less. :)

Yes, but it's still something to consider. Right now Esc does nothing at all, 
and neither do arrow keys. This thing needs some `FocusScope` treatment

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-13 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in UserDetailsPage.qml:217
> Can you add some way to make Escape close the sheet but not the entire KCM, 
> when run standalone through kcmshell? Hopefully the following is sufficient, 
> otherwise you'd have to mess with `FocusScope` and the like:
> 
>   Keys.onEscapePressed: {
>   close();
>   event.accepted = true;
>   }

FWIW KCMs opened through KRunner are now opened in System Settings so KCMShell 
is something we're going to have to deal with much less. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-13 Thread Kai Uwe Broulik

broulik added a comment.


  Pretty cool

INLINE COMMENTS

> UserDetailsPage.qml:36
> +
> +property variant user
> +property bool overrideImage: false

Use `property var`, or even `property QtObject` since `User` is a `QObject`

> UserDetailsPage.qml:82
> +id: fileDialog
> +title: "Choose a picture"
> +folder: shortcuts.pictures

`i18n`

> UserDetailsPage.qml:96
> +Layout.alignment: Qt.AlignHCenter
> +QQC2.RoundButton {
> +id: userPfp

Is this a `RoundButton` bug that it doesn't indicate keyboard focus when I tab 
to it?

> UserDetailsPage.qml:97
> +QQC2.RoundButton {
> +id: userPfp
> +

Pfp?

> UserDetailsPage.qml:99
> +
> +property int size: 6 * Kirigami.Units.gridUnit
> +

`readonly property`

> UserDetailsPage.qml:111
> +visible: usersDetailPage.user.faceValid || 
> usersDetailPage.overrideImage
> +sourceSize: Qt.size(parent.size, parent.size)
> +cache: false

I *think* one needs to multiple that with `Screen.devicePixelRatio`

> UserDetailsPage.qml:217
> +
> +Kirigami.OverlaySheet {
> +id: picturesSheet

Can you add some way to make Escape close the sheet but not the entire KCM, 
when run standalone through kcmshell? Hopefully the following is sufficient, 
otherwise you'd have to mess with `FocusScope` and the like:

  Keys.onEscapePressed: {
  close();
  event.accepted = true;
  }

> UserDetailsPage.qml:219
> +id: picturesSheet
> +header: RowLayout {
> +Kirigami.Heading {

Is this `RowLayout` needed?

> UserDetailsPage.qml:287
> +model: [
> +"Artist Konqi.png",
> +"Bookworm Konqi.png",

Can we not hardcode the list of avatars, please.
Also, you probably want to use a proper `GridView` for all of this, otherwise 
you end up creating every single delegate immediately on opening.

> UserDetailsPage.qml:342
> +
> +QQC2.Button {
> +Layout.preferredHeight: Kirigami.Units.gridUnit * 6

A tooltip and `Accessible.name` with the name of the avatar would be nice

> UserDetailsPage.qml:346
> +
> +ColumnLayout {
> +anchors.centerIn: parent

Is this `ColumnLayout` needed?

> UserDetailsPage.qml:361
> +
> +Repeater {
> +model: [

What's all of this? I don't see anything in the UI.
Anyway, we probably want to make all of this into a proper `QAbstractListModel`

> UserDetailsPage.qml:399
> +onClicked: {
> +colourRectangle.grabToImage(function(result) 
> {
> +picturesSheet.close()

Not sure if clever or mad :) Can we not just generate a colored rectangle on 
C++ side?

> usermodel.cpp:112
> +{
> +if (!checkIndex(index))
> +{

I just learned that you need to pass 
`QAbstractItemModel::CheckIndesOptions::IndexIsValid` otherwise it only checks 
for blatant out of bounds indices but not invalid "Null" ones :/

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-12 Thread Nathaniel Graham

ngraham added a comment.


  In D28154#668362 , @ltoscano wrote:
  
  > Technically kcm should be called kcm_. So far the 
Plasma_version part has been ignored, but at least kcm_ should be there.
  >
  > I'm not sure about the lack of the button.
  
  
  I objected to changing the name to avoid breaking compatibility with users 
and software that have the old name hardcoded, but maybe that was too 
inflexible. If everyone else is okay with changing the name to the more common 
style, I'll rescind my objection.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-11 Thread Luigi Toscano

ltoscano added a comment.


  Technically kcm should be called kcm_. So far the 
Plasma_version part has been ignored, but at least kcm_ should be there.
  
  I'm not sure about the lack of the button.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-11 Thread Yuri Chornoivan

yurchor added a subscriber: ltoscano.
yurchor added a comment.


  Please do not get me wrong (I'm fine with the new designs and updating the 
code and this new KCM is very good), but it would be good to hear some words 
from @ltoscano on the catalog (and KCM) naming.
  
  It is also evident that all the new KCMs do not have the "Help" button. Is it 
the new policy?
  
  Thanks in advance for your comments.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

2020-05-07 Thread Nathaniel Graham

ngraham added a comment.


  I would like to get this into 5.19, which would mean moving the code back 
into the user-manager repo, or removing it as a dependency for Plasma 5.19 by 
requesting an exception to the repo freeze.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread David Edmundson

davidedmundson added a comment.


  From my POV. +1
  
  I still need a reply on:
  
  "Which release?"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack updated this revision to Diff 82214.
cblack marked 4 inline comments as done.
cblack added a comment.


  Parent temporary file to the application

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82212=82214

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack updated this revision to Diff 82212.
cblack added a comment.


  realize you forgot to change the name of the argument in the body as well

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82211=82212

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> that looks like it could possibly run into race conditions, as the applyjob 
> is executed asynchronously and IIRC is able to still be running when 
> everything else, including this, has destructed and removed one of the files 
> it could be using

new QTemporaryFile(qApp) then

KJobs have an QEventLoopLocker that will stop qApp from quitting until they 
finish so you can be sure your applyjob is done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack updated this revision to Diff 82211.
cblack added a comment.


  Refine method signature and add a comment for less ambiguity

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82210=82211

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:121
> Normally the app creating a temp file would clean it up.
> 
> A quick fix would be
> file = new QTemporaryFile(this);
> 
> It's sort of leaking the object, but on exit it'll tidy everything up.

that looks like it could possibly run into race conditions, as the applyjob is 
executed asynchronously and IIRC is able to still be running when everything 
else, including this, has destructed and removed one of the files it could be 
using

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:97
> OH!
> 
> Initial-ise
> 
> not initialise as in "to prepare"
> 
> Makes sense :)

Then it should have a different name, like "getInitials", else the next person 
will be just as confused

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:121
> whoever is normally cleaning up tempfiles

Normally the app creating a temp file would clean it up.

A quick fix would be
file = new QTemporaryFile(this);

It's sort of leaking the object, but on exit it'll tidy everything up.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack updated this revision to Diff 82210.
cblack marked an inline comment as done.
cblack added a comment.


  Parent the dynamically created user to the model

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82209=82210

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:97
> taking the initials of a user's real name

OH!

Initial-ise

not initialise as in "to prepare"

Makes sense :)

> usermodel.cpp:37
> +connect(m_dbusInterface, ::UserAdded, 
> this, [this](const QDBusObjectPath ) {
> +User *user = new User();
> +user->setPath(path);

This one isn't parented to the model

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack updated this revision to Diff 82209.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address some of the code feedback from d_ed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82158=82209

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread Carson Black

cblack marked 5 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:94
> what's this for?

used as a hook for QML to know when the KCM needs to apply

> davidedmundson wrote in kcm.cpp:97
> This is an odd method name.
> 
> I don't really understand what it's doing, some sort of title casing?

taking the initials of a user's real name

> davidedmundson wrote in kcm.cpp:121
> so who cleans this up?

whoever is normally cleaning up tempfiles

> davidedmundson wrote in usermodel.cpp:72
> why are we resetting the whole model instead of just dataChanged() on the 
> relevant row

i couldn't figure out how to use those correctly. some help would be 
appreciated.

> davidedmundson wrote in usermodel.cpp:78
> The ones not logged in will be sorted randomly.
> 
> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

loggedIn compares the UID of the user to the UID of the currently running 
program, which means only one user can be logged in at a time by our metric.

> davidedmundson wrote in usermodel.cpp:96
> this is marked as done, yet I can't see where ?

users are parented to the model, which will use normal QObject destructor 
behaviour to clean them

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-07 Thread David Edmundson

davidedmundson added a comment.


  Which release?
  
  We need to remove user-manager. We're technically in a repo freeze, and this 
would involve changing (removing) a repo a breakage of that.
  
  
  
  Generally this looks quite neat and tidy. A big simplification +++

INLINE COMMENTS

> kcm.cpp:94
> +KQuickAddons::ConfigModule::save();
> +Q_EMIT apply();
> +}

what's this for?

> kcm.cpp:97
> +
> +QString KCMUser::initializeString(const QString& stringToInitial)
> +{

This is an odd method name.

I don't really understand what it's doing, some sort of title casing?

> kcm.cpp:121
> +QTemporaryFile file;
> +file.setAutoRemove(false);
> +if (file.open()) {

so who cleans this up?

> user.cpp:96
> +}
> +QString trueVal = value.toString();
> +if (value.toString().startsWith(QStringLiteral("file://"))) {

use url.path and url.protocol for this not string manipulation

> usermodel.cpp:72
> +connect(user, ::dataChanged, [=]() {
> +beginResetModel();
> +endResetModel();

why are we resetting the whole model instead of just dataChanged() on the 
relevant row

> usermodel.cpp:78
> +std::sort(m_userList.begin(), m_userList.end(), [](User *lhs, User *) {
> +return lhs->loggedIn();
> +});

The ones not logged in will be sorted randomly.

Also note that if the intention is to have your user at the top, this check 
won't suffice as you can have 2 things logged in.

> broulik wrote in usermodel.cpp:96
> You're leaking all the users.
> `qDeleteAll(m_userList)`

this is marked as done, yet I can't see where ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Great. From my perspective this is ready to go! I'd like a #plasma 
 person to review too, and for @mart 
or another #plasma  person to see if 
they can reproduce and help figure out the issue described in the first video 
at D28154#663205 . But that's not a 
hard blocker IMO.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-06 Thread Carson Black

cblack updated this revision to Diff 82158.
cblack marked 9 inline comments as done.
cblack added a comment.


  Address code and icon feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82150=82158

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham

ngraham added a subscriber: mart.
ngraham added a comment.


  Nice, that fixes the last of the avatar issues that I can find.
  
  After you add icons to the items in the keep/delete menu and make it close it 
with a click outside the menu, I think I'll be done reviewing the UI--other 
than the multi-column sizing bug that I'd like @mart to take a look at (video 
#1 in D28154#663205 ). Nice work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

2020-05-06 Thread Carson Black

cblack updated this revision to Diff 82150.
cblack added a comment.


  Fix faceValid checking

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82137=82150

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham

ngraham added a comment.


  Changing a user's avatar and clicking Reset instead of Apply makes the avatar 
display revert to the default avatar (which I remember you telling me isn't 
actually possible), not the previous one. This seems inaccurate because the 
avatar does in fact remain at the last one. It's just the display that's wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-06 Thread Carson Black

cblack updated this revision to Diff 82137.
cblack added a comment.


  begone, kule

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82135=82137

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-06 Thread Carson Black

cblack updated this revision to Diff 82135.
cblack added a comment.


  Make sure arc diff does what it should

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82048=82135

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> ChangePassword.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> CreateUser.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> UserDetailsPage.qml:25
> +import QtGraphicalEffects 1.12
> +import QtQuick.Controls 2.5
> +import QtQuick.Dialogs 1.3

...`as QQC2`

> UserDetailsPage.qml:188
> +
> +Menu {
> +id: deleteMenu

This menu doesn't close when you click outside of it; you need to hit the 
escape key.

> UserDetailsPage.qml:190
> +id: deleteMenu
> +MenuItem {
> +text: i18n("Delete files")

Give it an icon: `edit-delete`

> UserDetailsPage.qml:198
> +}
> +MenuItem {
> +text: i18n("Keep files")

Give it an icon: `document-multiple`

> UserDetailsPage.qml:208
> +text: i18n("Delete User...")
> +icon.name: "delete"
> +onClicked: deleteMenu.open()

`edit-delete`

> main.qml:135
> +QQC2.Button {
> +Layout.alignment: Qt.AlignLeft
> +

Because the layout has a fillWidth item to the right, this isn't needed

> ngraham wrote in main.qml:96
> "kule"?

That was not a request for explanation but rather a gentle way of saying 
"please change this to something descriptive to a person who does not speak 
Toki Pona" :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:54
> Could this be a BasicListItem with a title and subtitle, or is that not 
> possible because you can't render the avatar+circle into an image source to 
> feed it?

Not possible, AFAIK. At least not as long as grabbing to an image fails. Would 
also be inefficient compared to just having the items directly in the 
scenegraph.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82048.
cblack added a comment.


  Address code issue and add reset functionality

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82046=82048

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  Great. We're getting pretty close to the UI being finished IMO. I'll start on 
the QML code review soon. In the meantime I found a few more little behavioral 
issues:
  
  1. The Reset button correctly activates when the KCM is in a dirty state, but 
doesn't seem to actually reset anything when clicked.
  2. I haven't figured how to reproduce this 100% of the time, and I'm not sure 
if it's an issue with the OverlaySheet itself or the implementation here, but 
when I do a two-finger scroll over the avatar sheet, sometimes it scrolls 
mostly out of the view in a very weird way: F8288148: 
vokoscreenNG-2020-05-05_20-53-05.webm  I 
don't think there's anything weird with my touchpad as I don't see this in 
other scrollable views.

INLINE COMMENTS

> main.qml:54
> +
> +delegate: Kirigami.AbstractListItem {
> +width: userList.width

Could this be a BasicListItem with a title and subtitle, or is that not 
possible because you can't render the avatar+circle into an image source to 
feed it?

> main.qml:96
> +color: "transparent"
> +property color kule: Kirigami.Theme.textColor
> +border.color: Qt.rgba(kule.r, kule.g, kule.b, 0.4)

"kule"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82046.
cblack marked an inline comment as done.
cblack added a comment.


  Fix item alignment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82025=82046

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> main.qml:141
> +QQC2.Button {
> +Layout.alignment: Qt.AlignLeft
> +

This doesn't work because there's an item on the left of it that fills the 
width. Remove that item, or this alignment property (and whichever one you 
choose, please test to make sure that it works)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82025.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82020=82025

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> main.qml:141
> +QQC2.Button {
> +Layout.alignment: Qt.AlignRight
> +

Align left to match the emerging standard for other {nad Add new thing} buttons

> user_manager.desktop:9
> +X-KDE-Weight=40
> +X-KDE-System-Settings-Parent-Category=personalization
> +Name=Users

Should be `accountdetails`, or else the Account Details group will have only 
KWallet in it and no will longer need to exist, so then KWallet would also need 
to be moved up a level

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82020.
cblack added a comment.


  Fix permission denied bouncing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82016=82020

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  I found a few more little things:
  
  1. This is not a big deal, but could the grid of avatars be horizontally 
centered in its sheet? F8287538: Screenshot_20200505_132938.png 

  
  2. Text and icons in the Change Password sheet are clipped and pixellated for 
some reason: F8287541: Screenshot_20200505_133127.png 
 However if I click in one of the 
password fields, the issue resolves itself!

INLINE COMMENTS

> UserDetailsPage.qml:239
> +Label {
> +text: i18n("Open File")
> +

I think "Choose from File..." would be more appropriate (and don't forget the 
ellipses, since it opens a file dialog)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82016.
cblack added a comment.


  Add Messages.sh

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82015=82016

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82015.
cblack added a comment.


  Add Messages.sh

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82012=82015

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  Love the section headers!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Yuri Chornoivan

yurchor added a comment.


  Is it possible to add Messages.sh to make this KCM translatable?
  
#! /usr/bin/env bash
$XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o $podir/user_manager.pot
  
  Thanks in advance for your work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82012.
cblack added a comment.


  Use section headers instead of font weights

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82010=82012

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  The avatar image bug is not fixed for me. :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82010.
cblack added a comment.


  Improved dirty state handling

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82008=82010

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  Great, those are fixed now. Here's an interesting new one I just found: when 
you change another user's avatar for the first time after opening the KCM (this 
is important), the change doesn't take effect until you change your own avatar 
too: F8287316: vokoscreenNG-2020-05-05_11-37-05.webm 

  
  Also notice how the bold text for my user's list item becomes un-bold.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82008.
cblack added a comment.


  Address the page oddities

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82006=82008

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Nathaniel Graham

ngraham added a comment.


  When I create a second user, the users list highlights that other user, but 
the details view shows me: F8287247: Screenshot_20200505_26.png 

  
  Oh and here's a fun one for you: F8287249: 
vokoscreenNG-2020-05-05_11-12-54.webm 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-05 Thread Carson Black

cblack updated this revision to Diff 82006.
cblack added a comment.


  Take care of that feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=80942=82006

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-05-04 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Various bugs I've complained about are still not fixed.
  
  1. The KCM does not display the two-column view when opened in System 
Settings' default window size until you resize the window a bit: F8284091: 
vokoscreenNG-2020-05-04_09-52-36.webm 
  
  2. The KCM is in a dirty state without you having changed anything: F8284093: 
vokoscreenNG-2020-05-04_09-54-54.webm 
  
  3. You can still try to delete your own user: F8284095: 
Screenshot_20200504_095557.png 
  
  4. The avatar chooser sheet is super duper space inefficient: F8284104: 
vokoscreenNG-2020-05-04_09-59-37.webm  
Could its visual parent be  the whole KCM, rather than just one page of it?
  
  5. The auto-generated avatar style with the user's initials and a colored 
background does not apply: F8284120: vokoscreenNG-2020-05-04_10-01-44.webm 
 If this feature is blocked by a bug, 
then it should be disabled until it works.
  
  And one new one: When you create a new user, the first text field should be 
focused automatically so you can start typing immediately. The new user UI 
could even be in a sheet, maybe (as long as its visual parent is the whole KCM 
and not one of the columns in a multi-column/multi-page layout)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-22 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:88
> Not sure it's actually a bug in the multi-page KCM system as @iasensio was 
> able to make this work properly in D28152 
> . Maybe you can see what he did there?

Seems to work for me now.

> ngraham wrote in user_manager.desktop:9
> You've moved it out of the Account details group. If this is intentional, 
> then we also need to move the KWallet KCM out of that group, or else Account 
> details has only one item and shows the KWallet KCM when clicked on, which is 
> confusing because the second level of navigation is collapsed and the group 
> name doesn't match the KCM name.
> 
> F8249318: Screenshot_20200420_081303.png 
> 
> 
> So move it back into the Account Details group or submit another patch to 
> move KWallet out of the group too.

Will do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-22 Thread Carson Black

cblack updated this revision to Diff 80942.
cblack marked 11 inline comments as done.
cblack added a comment.


  Address feedback, needs fix for https://bugs.kde.org/show_bug.cgi?id=420439 
in order to function

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79605=80942

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-22 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> UserDetailsPage.qml:195
> +onClicked: {
> +if (kcm.deleteUser(usersDetailPage.user.uid)) {
> +kcm.pop()

This no longer asks if you want to delete that user's home directory, so it's 
always preserved.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-20 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> user_manager.desktop:9
> +X-KDE-Weight=40
> +X-KDE-System-Settings-Parent-Category=personalization
> +Name=Users

You've moved it out of the Account details group. If this is intentional, then 
we also need to move the KWallet KCM out of that group, or else Account details 
has only one item and shows the KWallet KCM when clicked on, which is confusing 
because the second level of navigation is collapsed and the group name doesn't 
match the KCM name.

F8249318: Screenshot_20200420_081303.png 

So move it back into the Account Details group or submit another patch to move 
KWallet out of the group too.

> user_manager.desktop:11
> +Name=Users
> +Comment=
> +X-KDE-Keywords=user,account

Needs a comment or else the sidebar tooltip is nonsensical

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-20 Thread Nathaniel Graham

ngraham added a subscriber: iasensio.
ngraham added a comment.


  @meven this is what it looks like now: F8249229: 
Screenshot_20200420_074955.png 
  
  @cblack Mostly okay now, just a few more broken things that need fixing.

INLINE COMMENTS

> UserDetailsPage.qml:190
> +
> +enabled: !usersDetailPage.user.loggedIn && 
> !kcm.userModel.rowCount() < 2
> +

this isn't working anymore for me

> UserDetailsPage.qml:223
> +
> +Button {
> +Layout.preferredHeight: Kirigami.Units.gridUnit * 8

This still doesn't work right. Selecting a custom image doesn't make it get 
applied when you click on the apply button, and I still can't clear avatars.

> ngraham wrote in UserDetailsPage.qml:267
> Despite this, they're still jaggy for me. Maybe play with the mipmapping 
> settings?

Still not fixed for me.

F8249187: Screenshot_20200420_073740.png 

> main.qml:104
> +
> +Column {
> +id: col

Since you're manufacturing this list item by hand, you need to manually make 
the text color of the labels use the selected text color when the item is 
selected.

> ngraham wrote in main.qml:88
> Then we'll need to fix that before this can ship. :)

Not sure it's actually a bug in the multi-page KCM system as @iasensio was able 
to make this work properly in D28152 . 
Maybe you can see what he did there?

> kcm.cpp:55
> +setAboutData(about);
> +setButtons(Apply);
> +auto font = QApplication::font("QLabel");

Navigating away from the KCM while it's in a dirty state doesn't show the 
"would you like to apply the unsaved changes" dialog like I would expect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-20 Thread Méven Car

meven added a comment.


  Is the screenshot current ?
  
  ping @ngraham

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Carson Black

cblack updated this revision to Diff 79605.
cblack marked 2 inline comments as done.
cblack added a comment.


  Improved avatar sheet

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79596=79605

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> UserDetailsPage.qml:267
> +id: imgDelegate
> +smooth: true
> +

Despite this, they're still jaggy for me. Maybe play with the mipmapping 
settings?

> cblack wrote in main.qml:88
> Seems to be a bug with syse/multi-page KCMs?

Then we'll need to fix that before this can ship. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Carson Black

cblack marked 2 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:88
> Not actually fixed. Just open System Settings with its default window size 
> and navigate to the new KCM and you'll see what I'm talking about.

Seems to be a bug with syse/multi-page KCMs?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Carson Black

cblack updated this revision to Diff 79596.
cblack added a comment.


  Move columWidth set to KCM constructor

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79593=79596

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Carson Black

cblack updated this revision to Diff 79593.
cblack added a comment.


  Add border to button on details page

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79592=79593

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-07 Thread Carson Black

cblack updated this revision to Diff 79592.
cblack added a comment.


  Add circle to accounts in the list

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79250=79592

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79250.
cblack marked 2 inline comments as done.
cblack added a comment.


  Address some more issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79248=79250

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Nathaniel Graham

ngraham added a comment.


  In D28154#640943 , @cblack wrote:
  
  > Add parent category
  
  
  Now it shows up on the base level of navigation, rather than within the 
Account Details group where it currently lives.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79248.
cblack added a comment.


  Trim file:// off of icon string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79245=79248

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79245.
cblack added a comment.


  Add parent category

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79242=79245

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> cblack wrote in ChangePassword.qml:65
> that's basically what this does

Well, it doesn't work for me. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> UserDetailsPage.qml:101
> +layer.enabled: user.faceValid
> +layer.effect: OpacityMask {
> +maskSource: Rectangle {

Nice! How about an outline around the circle like we do in Kickoff?

> main.qml:66
> +layer.enabled: true
> +layer.effect: OpacityMask {
> +maskSource: Rectangle {

ditto

> ngraham wrote in main.qml:88
> Systemsettings' default window width is like five pixels too narrow to make 
> both the users list and the details view appear by default. Can to make one 
> or both a tiny bit smaller or otherwise fix it so that both are visible by 
> default when you open the KCM in System Settings with its default window size?

Not actually fixed. Just open System Settings with its default window size and 
navigate to the new KCM and you'll see what I'm talking about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79242.
cblack marked 3 inline comments as done.
cblack added a comment.


  Address issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79241=79242

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79241.
cblack marked 3 inline comments as done.
cblack added a comment.


  Improve deletion and creation

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79240=79241

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79240.
cblack added a comment.


  Drop anchors

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79236=79240

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in ChangePassword.qml:65
> hitting the return key on this field should effectively click the Create 
> button

that's basically what this does

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Nathaniel Graham

ngraham added a comment.


  Now it's this:
  

"file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml"
 
 "Error loading QML file.\n257: Type ChangePassword unavailable\n31: Cannot 
assign to non-existent property \"anchors\"\n"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Carson Black

cblack updated this revision to Diff 79236.
cblack added a comment.


  Remove modal

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79184=79236

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-03 Thread Nathaniel Graham

ngraham added a comment.


  I think that broke the details page. Console spew says:
  
QQmlComponent: Component is not ready

"file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml"
 
 "Error loading QML file.\n257: Type ChangePassword unavailable\n31: Cannot 
assign to non-existent property \"modal\"\n"
QCoreApplication::postEvent: Unexpected null receiver

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79184.
cblack marked 3 inline comments as done.
cblack added a comment.


  Address some feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79181=79184

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> ChangePassword.qml:65
> +
> +onAccepted: !passwordWarning.visible && verifyField.text && 
> passwordField.text && passButton.apply()
> +

hitting the return key on this field should effectively click the Create button

> UserDetailsPage.qml:89
> +
> +Image {
> +source: user.face

This should be cropped into a circle, like we do in Kickoff and the 
login/lock/logout screens. You can probably just lift the code straight from 
Kickoff.

> UserDetailsPage.qml:172
> +
> +Button {
> +id: deleteUser

Does it make sense to be able to delete the currently-logged-in user, or the 
only user on the system?

> UserDetailsPage.qml:177
> +icon.name: "delete"
> +onClicked: kcm.deleteUser(usersDetailPage.user.uid)
> +}

Doesn't work for me; clicking the button has no effect.

> UserDetailsPage.qml:182
> +
> +Kirigami.OverlaySheet {
> +id: picturesSheet

Might be nice to give this sheet a title, so that there's something in its 
header area besides a close button.

> UserDetailsPage.qml:185
> +ColumnLayout {
> +Layout.preferredWidth: Kirigami.Units.gridUnit * 15
> +GridLayout {

This sheet ends up really narrow, so there are only ever two columns of icons 
visible, even with a very wide window. It doesn't look great IMO. Wider would 
be better.

> UserDetailsPage.qml:196
> +
> +Button {
> +Layout.preferredHeight: Kirigami.Units.gridUnit * 6

This button needs text so people can figure out what it does.

> UserDetailsPage.qml:239
> +kcm.needsSave = true
> +usersDetailPage.user.face = imgDelegate.source
> +}

This doesn't seem to work. When I change the avatar using the sheet, the image 
on the details page gets reset to the default, rather than reflecting my choice.

> main.qml:56
> +
> +Image {
> +source: model.decoration

Crop this into a circle too

> main.qml:88
> +userList.currentIndex = index
> +kcm.push("UserDetailsPage.qml", {user: User})
> +}

Systemsettings' default window width is like five pixels too narrow to make 
both the users list and the details view appear by default. Can to make one or 
both a tiny bit smaller or otherwise fix it so that both are visible by default 
when you open the KCM in System Settings with its default window size?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79181.
cblack marked 3 inline comments as done.
cblack added a comment.


  Use better model roles

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79180=79181

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79180.
cblack marked an inline comment as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79173=79180

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79173.
cblack added a comment.


  Use a KJob to apply user configuration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79167=79173

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> user.cpp:179
> +{
> +QtConcurrent::run([=]() {
> +m_dbusIface->SetUserName(mName).waitForFinished();

No, just no.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79167.
cblack added a comment.


  Run apply in a separate thread

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79165=79167

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79165.
cblack marked 2 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79138=79165

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack added a comment.


  In D28154#640206 , @davidedmundson 
wrote:
  
  > > Drop group stubs; there will be bad UX because two different polkit 
actions (and thus two dialogs backtoback) would be needed for apply with groups
  >
  > Don't rule out the obvious other option there - changing accountsservice. 
It already has all the code, just only exposes admin group. Adding more would 
be relatively doable and a lot tidier.
  >  Would need the use case expanding so we can approach with a ratioanle, but 
let's follow that up on the bug report.
  
  
  I looked into that, and it looks like the requirements for a groups API are 
more complex than they would appear at first glance 
. 
(e.g. handling groups managed by domains)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread David Edmundson

davidedmundson added a comment.


  > Drop group stubs; there will be bad UX because two different polkit actions 
(and thus two dialogs backtoback) would be needed for apply with groups
  
  Don't rule out the obvious other option there - changing accountsservice. It 
already has all the code, just only exposes admin group. Adding more would be 
relatively doable and a lot tidier.
  Would need the use case expanding so we can approach with a ratioanle, but 
let's follow that up on the bug report.
  
  For this patch I think you did the right thing, merge as-is, with a tidier 
base that's easier to expand upon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Nathaniel Graham

ngraham added a comment.


  So it does. My bad, sorry.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Kai Uwe Broulik

broulik added a comment.


  That gallery comes from user manager right now, doesnt it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Nathaniel Graham

ngraham added a comment.


  Wait, why are you adding the Konqis to this diff? You should use whatever 
framework provides the gallery instead of  re-implementing all of that and 
duplicating the assets.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Carson Black

cblack updated this revision to Diff 79138.
cblack marked 7 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79099=79138

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usercontroller.cpp
  kcms/users/src/usercontroller.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-02 Thread Cyril Rossi

crossi added inline comments.

INLINE COMMENTS

> kcm.cpp:73
> +
> +void KCMUser::defaults()
> +{

Not necessary to override if you don't add your specific implementatioin.

> kcm.cpp:78
> +
> +void KCMUser::load()
> +{

same here

> user.cpp:53
> +mName = value;
> +nameChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:66
> +mRealName = value;
> +realNameChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:79
> +mEmail = value;
> +emailChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

> user.cpp:110
> +mAdministrator = value;
> +administratorChanged(value);
> +}

Add `emit` or `Q_EMIT` before signal calls

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

2020-04-01 Thread Nathaniel Graham

ngraham added a comment.


  You should set `smooth: true` on those avatars in the new gallery so they 
aren't so jaggy. Also the button to add your own avatar from a file should 
probably have a label in it so people can figure out what it does. And the 
sheet that the new gallery is on should be wider; right now it's really narrow 
with the default System Settings window width. And the only avatars in the 
gallery are Konqis; what happened to the other ones? Finally I notice that 
selecting any of the avatars in the gallery resets the avatar display on the 
details page to the default one rather than reflecting the one you chose.
  
  Ooh and here's something I just remembered: we should mask the avatar into a 
circle like Kickoff and the lock/login/logout screens do. You can probably just 
lift the code straight from Kickoff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

1 2 >

1 - 100 of 121 matches

Mail list logo