D28949: Add titlebar colors to Kirigami::PlatformTheme

[Marco Martin]

mart added a comment.


  what's the "tools area"?
  are there other use cases than client side decorations? (which we don't want 
to support)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28949

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

[Marco Martin]

mart added a comment.


  In D28873#652747 , @ngraham wrote:
  
  > Like you mentioned, don't we want to use the tabbed sidebar view thingy for 
that?
  
  
  i think it probably depends from the app both from tab numbers and semantics 
of the app?
  mayeb is worth to have written down use cases/scenarios with personas and 
what not to decide?
  (btw, ubuntu touch/ubports has an item like that that when the device 
switches from mobile to desktop, indeed goes from bottom bar to sidebar)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre marked an inline comment as done.
davidre added a comment.


  In D28744#652703 , @ngraham wrote:
  
  > Clicking the Apply button makes System Settings crash for me:
  
  
  Fixed now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Nathaniel Graham]

ngraham added a subscriber: cblack.
ngraham added a comment.


  Works for me now. @hpereiradacosta, @ndavis, and @cblack, are you okay with 
this?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, 
#breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, trickyricky26, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80673.
davidre added a comment.


  - Fix scrollview and use level 3 heading
  - use better string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80672=80673

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella created this revision.
tfella added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REVISION SUMMARY
  Implements T12895 . Might include things 
like bluetooth and usb tethering in the future when implemented

TEST PLAN
  Edit SSID and password, start, connect

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella updated this revision to Diff 80689.
tfella added a comment.


  fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80688=80689

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Marco Martin]

mart added a comment.


  btw may be worth trying to have a stackview that switches between this view 
and the one before based on page with (wideMode property of pagerow)

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80672.
davidre added a comment.


  - Fix errors and leave error message disabled

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80631=80672

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  Yay. Almost there! I just see a few more things:
  
  1. If I delete a whole item from the left-most list, there's no obvious way 
to get it back (what if I delete a system entry by accident?)
  2. The Defaults button is present, but always disabled
  3. I see duplicate entries with different items inside them: F8249655: 
vokoscreenNG-2020-04-20_11-56-18.webm 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29022: Update the check for ActionToolbar by checking with less-"equal".

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  Otherwise some action, especially when there is only one action, it will be
  put in "more" menu even if there is enough space.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29022

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml

To: xuetianweng, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  "Lateral navigation" is basically a tabbed view. So to me this looks like a 
tabbed view with a different UI for the tabs. We've actually needed a tabbed 
view component for a while: https://bugs.kde.org/show_bug.cgi?id=394296
  
  Maybe this could be that. I think the swipe navigation is fine. However if 
this is going to have all the functionality of a tabbed view, it ought to 
//look// like a desktop-style tabbed view on the desktop platform. The 
different tab styling therefore has to go. On mobile, the tabs should look like 
desktop tabs, and on mobile, the tabs should look like mobile tabs.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[Björn Feber]

GB_2 added a comment.


  Nitpick: put the "Add Application..." button on the left (T10384 
).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella updated this revision to Diff 80688.
tfella marked 6 inline comments as done.
tfella added a comment.


  Fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80683=80688

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Marco Martin]

mart added a comment.


  In D28873#649459 , @niccolove 
wrote:
  
  > My opinion from the consistency side: I actually think this is a good 
possibility for the Consistency goal. After some digging around, my opinion is 
that
  >
  > > Tabs should only be used on application views that are user-editable (eg: 
when it's possible to open a new tab or close another).
  >
  > It's imo appropriate to have a different component for changing views, 
especially on Kiri. But of course, that component should be consistent. Right 
now we have big square sidebars, toolbars, etc etc etc etc etc
  >
  > F8241366: image.png 
  
  
  for those that are a sidebar, there is already a standard, agreed upon look, 
that is being slowly and painfully moved to be adopted, which is:
  F8249505: Screenshot_20200420_180317.png 


INLINE COMMENTS

> niccolove wrote in SwipeNavigator.qml:55
> I think the tabbar should not be at the bottom on mobile. It's not necessary 
> to touch the control as swiping from any point of the page should change the 
> page, it is more visible when put at top, it is more consistent with kde and 
> not-kde applications and introduces a position inconsistency between devices 
> (touchscreen laptops should also be taken into consideration).

to me on mobile this is basically (or at least, is the only use i would have 
for such a control):
https://material.io/components/bottom-navigation

which yeah, should be at the bottom (and kirigami always had as a central point 
to have as much as possible controls, actions and chrome at the bottom for 
single hand use)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

[Nathaniel Graham]

ngraham added a comment.


  Like you mentioned, don't we want to use the tabbed sidebar view thingy for 
that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella updated this revision to Diff 80683.
tfella added a comment.


  Whitespace fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80679=80683

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +project (kcm_mobile_hotspot)
> +

remove

> CMakeLists.txt:11
> +KF5::I18n
> +KF5::Plasma
> +KF5::QuickAddons

KF5::Plasma shouldn't be needed

> hotspotsettings.cpp:30
> +{
> +KAboutData* about = new KAboutData("kcm_mobile_hotspot", 
> i18n("Hotspots"),
> +   "0.1", QString(), 
> KAboutLicense::LGPL);

Hotspot singular

> hotspotsettings.h:32
> +HotspotSettings(QObject *parent, const QVariantList );
> +virtual ~HotspotSettings();
> +};

override

> main.qml:28
> +SimpleKCM {
> +id: main
> +

id is unused. check also for others

> main.qml:30
> +
> +title: i18n("Hotspot")
> +

I'm not 100% sure the title is actually getting used

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28949: Add titlebar colors to Kirigami::PlatformTheme

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  ok, thanks for the clarification

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/tools-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28949

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28627: Adaptive panel opacity

[Nathaniel Graham]

ngraham added a comment.


  In D28627#652538 , @niccolove 
wrote:
  
  > Actually -- this seems to no longer apply panel internal margins?
  
  
  Works for me.
  
  In terms of the UI and the scope, I have to agree with @apol though, and 
maybe go a bit further: I think this should be either a global setting that 
applies to all transparent Plasma stuff (dialogs, pop-ups, panels, widgets, 
etc) or a setting specific to the Breeze Plasma theme--which would first 
require that we create such a UI (Plasma Theme Explorer doesn't count).
  
  Having it only affect the panel feels a bit off TBH. If I'm the kind of 
person who hates transparency, I want it off for everything else too. If I'm in 
the target user group who doesn't change the defaults, I'll think it's weird 
that the panel itself becomes opaque for a maximized window, but not the 
pop-ups for widgets on that panel.
  
  Also I see an interesting visual glitch when a window is un-maximized: 
F8249600: vokoscreenNG-2020-04-20_11-10-47.webm 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  Here's how it looks with the old KCM: F8249724: 
Screenshot_20200420_125405.png 
  
  So my KDE Daemon category has one entry in French for some odd reason. And 
the two KRunner entries are indeed still there and different, not merged.
  
  And the Power Management entry is full of duplicates internally and it's very 
confusing: F8249731: Screenshot_20200420_130010.png 

  
  So yeah, it's not great in the existing KCM. In the new one it's nice that 
you can delete these duplicates, but I don't actually know what will happen 
when I do so, and the inability to get them back if I make a mistake makes me 
not want to try.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:39
> +Controls.Switch {
> +id: enabled
> +Kirigami.FormData.label: i18n("Enabled:")

Using adjective as an ID looks weird to me.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28971: Persist state between launches

[Carson Black]

cblack added a comment.


  In D28971#652708 , @mart wrote:
  
  > i always refrained from using any form of config read/write here, and i 
think we should continue to do so.
  
  
  Are you referring to the gallery (this patch) or to Kirigami?

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80675.
davidre added a comment.


  - Implement Kai's idea for importing
  - Fix importing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80673=80675

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella added a comment.


  Git/Arc decided to do weird things, I hope I didn't break it

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Marco Martin]

mart added a comment.


  This patch is about having the whole app navigation as a tabbed thing, so 
more like tabs in a webbrowser than a generic tabview (with frame and all which 
this shouldn't have)
  so they are 2 different things: i still think a drop in replacement for a 
tabview will be needed, but this is probably different beast
  
  so a final look like
   F8249539: Screenshot_20200420_182203.png 

  should be fine i think

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added a comment.


  In D28744#652854 , @ngraham wrote:
  
  > Yay. Almost there! I just see a few more things:
  >
  > 1. If I delete a whole item from the left-most list, there's no obvious way 
to get it back (what if I delete a system entry by accident?)
  
  
  I agree. Probably should do it like other kcms with pending deletion then.
  
  > 2. The Defaults button is present, but always disabled
  
  Hmm it works for me when changing shortcuts or changing defaults but the 
initial state is wrong probably because loading is now async. Will look into it.
  
  > 3. I see duplicate entries with different items inside them:
  
  These are not really duplicated but boil down to that the backend is 
represented correctly here. Some components have a different unique identifier  
and happen to have the same user visible name. The old kcm merged them but I 
don't as I think most of these should be seperate because they  are related to 
different things.
  
  - The kded ones are not really duplicate but rather seperate. I think most of 
them are part of plasma(?) so I will see if I can change them to something more 
sensible (for example "Touchpad" or "Keyboard").
  - The powerdevil duplication  shouldn't even exist, @davidedmundson messed up 
while migrating the shortcuts but also fixed that. See D10668 
.
  - The run command one I have not seen but they also have different user 
visible names? How does the old kcm handle that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Talking with kbroulik on irc confirms your POV, the format of those patterns 
aren't documented anywhere so changing the matching now would change the 
behaviour...
  
  I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns should be 
documented somewhere so that there's a defined format on which to base the 
contract of not breaking API :/).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28971: Persist state between launches

[Nathaniel Graham]

ngraham added a comment.


  In D28971#652708 , @mart wrote:
  
  > my concern here using qsettings in this place, is  that then it kinda 
clashes when an application uses its own config  like it should, from a 
framework (kconfiggroup, kconfigskeleton etc)
  >  i always refrained from using any form of config read/write here, and i 
think we should continue to do so.
  >  Kirigami is a tier1 framework that should do the kleast possible, is more 
like KGuiAddons/§KWidgetAddons, *not* a full feature kxmlgui, which if we want 
to have something along the lines, we should have a proper framework to do so, 
and not tier1
  
  
  If that's your vision for Kirigami, then we definitely need one, yeah. 
Otherwise our QML apps are going to need to endlessly reinvent this kind of 
wheel.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80663.
apol added a comment.


  Adadpt to changes in kwayland D28882 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80408=80663

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Marco Martin]

mart added a comment.


  if there can't be a super smooth transition between a listview and this thing 
(perhaps with a stackview, but i'm not sold) then there should always be just 
the cardlayout with the same cards look, just as a single column

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f9d31febf87e: Update the visiblity check for 
ActionToolbar by checking width with less… (authored by xuetianweng).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29022?vs=80690=80697

REVISION DETAIL
  https://phabricator.kde.org/D29022

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml

To: xuetianweng, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg updated this revision to Diff 80698.
romangg added a comment.


  Cleanup

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29024?vs=80695=80698

BRANCH
  wayland-plugins

REVISION DETAIL
  https://phabricator.kde.org/D29024

AFFECTED FILES
  CONTRIBUTING.md
  backends/kwayland/CMakeLists.txt
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/kwayland/CMakeLists.txt
  backends/kwayland/plugins/kwayland/kwayland.json
  backends/kwayland/plugins/kwayland/kwayland_interface.cpp
  backends/kwayland/plugins/kwayland/kwayland_interface.h
  backends/kwayland/plugins/kwayland/kwayland_output.cpp
  backends/kwayland/plugins/kwayland/kwayland_output.h
  backends/kwayland/wayland_interface.cpp
  backends/kwayland/wayland_interface.h
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/kwayland/waylandscreen.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Adds a plugin that uses the Wrapland library to interact with compositors
  supporting the kwinft_output_management_unstable_v1 protocol.
  
  If the backend plugin is available at runtime the interface is instantiated in
  parallel with the KWayland interface and whichever interface has success in
  retrieving a management global first is used while the other one is rejected
  for this execution.
  
  Building this plugin is optionally and depends on Wrapland being available or
  not.

TEST PLAN
  Tested in KWin and KWinFT sessions.

REPOSITORY
  R110 KScreen Library

BRANCH
  wrapland-plugin

REVISION DETAIL
  https://phabricator.kde.org/D29028

AFFECTED FILES
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/wrapland/CMakeLists.txt
  backends/kwayland/plugins/wrapland/wrapland.json
  backends/kwayland/plugins/wrapland/wrapland_interface.cpp
  backends/kwayland/plugins/wrapland/wrapland_interface.h
  backends/kwayland/plugins/wrapland/wrapland_output.cpp
  backends/kwayland/plugins/wrapland/wrapland_output.h

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29029: feat(wayland): add plugin for wlroots based compositors

[Roman Gilg]

romangg added a comment.


  Test on sway. 
  
  - I noticed one issue with that. KScreen is not at all styled in a sway 
session. Kai helped me out with that. I needed to set the env var 
XDG_CURRENT_DESKTOP=KDE. I find this rather a broken concept for people in 
other sessions to go through to have proper styling of our Plasma apps. Is 
there something which can be done in KScreen to have proper styling from the 
start? Just set the env var in case it is not already set?
  - One other question is how layouts can be automatically applied in other 
sessions. Do users in such sessions need to start kded such that the KScreen 
daemon runs through it? Is that even possible?

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29029

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice job! I was actually just about to submit this exact diff. :)

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29022

To: xuetianweng, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg updated this revision to Diff 80700.
romangg added a comment.


  Cleanup

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29024?vs=80698=80700

BRANCH
  wayland-plugins

REVISION DETAIL
  https://phabricator.kde.org/D29024

AFFECTED FILES
  CONTRIBUTING.md
  backends/kwayland/CMakeLists.txt
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/kwayland/CMakeLists.txt
  backends/kwayland/plugins/kwayland/kwayland.json
  backends/kwayland/plugins/kwayland/kwayland_interface.cpp
  backends/kwayland/plugins/kwayland/kwayland_interface.h
  backends/kwayland/plugins/kwayland/kwayland_output.cpp
  backends/kwayland/plugins/kwayland/kwayland_output.h
  backends/kwayland/wayland_interface.cpp
  backends/kwayland/wayland_interface.h
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/kwayland/waylandscreen.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[David Edmundson]

davidedmundson added a comment.


  KScreen already is a plugin system.
  
  We don't need to go all inception, and have a plugin load plugins. It doesn't 
look to bring anything other than complexity.
  
  If there is any duplication, we can just add some extra base classes in the 
lib using the split you've done above that the plugin can inherit from.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28666: Refactor for loops

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6a0535050b8c: Refactor for loops (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28666?vs=79642=80710

REVISION DETAIL
  https://phabricator.kde.org/D28666

AFFECTED FILES
  src/controls/Action.qml
  src/controls/CardsLayout.qml
  src/controls/ContextDrawer.qml
  src/controls/FormLayout.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/PassiveNotification.qml

To: cblack, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28688: Document Kirigami::Icon

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9dba4c8b1583: Document Kirigami::Icon (authored by 
cblack).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28688?vs=79787=80709#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28688?vs=79787=80709

REVISION DETAIL
  https://phabricator.kde.org/D28688

AFFECTED FILES
  Mainpage.dox
  docs/pics/icon/active.png
  docs/pics/icon/selected.png
  examples/icon/CustomSource.qml
  examples/icon/Fallback.qml
  examples/icon/FilesystemSource.qml
  examples/icon/IconThemeSource.qml
  examples/icon/InternetSource.qml
  examples/icon/ResourceSource.qml
  src/icon.h

To: cblack, #kirigami, mart
Cc: broulik, nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack added a comment.


  In D28873#652727 , @ngraham wrote:
  
  > "Lateral navigation" is basically a tabbed view. So to me this looks like a 
tabbed view with a different UI for the tabs. We've actually needed a tabbed 
view component for a while: https://bugs.kde.org/show_bug.cgi?id=394296
  >
  > Maybe this could be that. I think the swipe navigation is fine. However if 
this is going to have all the functionality of a tabbed view, it ought to 
//look// like a desktop-style tabbed view on the desktop platform. The 
different tab styling therefore has to go. On mobile, the tabs should look like 
desktop tabs, and on mobile, the tabs should look like mobile tabs.
  
  
  IMO, the affordances of a traditional tab style hint at tabs being editable. 
This is fairly established: Chrome uses the traditional tab style for its 
user-manipulatable tabs, while using a different style for non-manipulatable 
tabs. Firefox does the same, as well as Falkon. elementary on a platform level 
uses traditional tabs for manipulatable tabs and a different style for static 
tabs. macOS does the same thing. Using editable-style tabs when the tabs are 
non-editable is a misleading affordance, hence why this patch doesn't use them.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D29019: Create a hotspot KCM for Plasma Mobile

[Tobias Fella]

tfella updated this revision to Diff 80714.
tfella marked an inline comment as done.
tfella added a comment.


  Change id

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80689=80714

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.


  I don't really see why we'd want to support something that is not offering 
ABI stability and doesn't push Plasma in any direction.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: apol, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29029: feat(wayland): add plugin for wlroots based compositors

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Adds a plugin that uses the Wrapland library to interact with compositors
  supporting the wlr_output_management_unstable_v1 protocol.
  
  If the backend plugin is available at runtime the interface is instantiated in
  parallel with other interfaces and whichever interface has success in
  retrieving a management global first is used while the other ones are deleted.
  
  Building this plugin is optionally and requires upcoming Wrapland release
  version 0.519.0.

TEST PLAN
  Tested on sway and in Plasma session.

REPOSITORY
  R110 KScreen Library

BRANCH
  wlroots-plugin

REVISION DETAIL
  https://phabricator.kde.org/D29029

AFFECTED FILES
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/wrapland-wlr/CMakeLists.txt
  backends/kwayland/plugins/wrapland-wlr/wrapland-wlr.json
  backends/kwayland/plugins/wrapland-wlr/wrapland_interface.cpp
  backends/kwayland/plugins/wrapland-wlr/wrapland_interface.h
  backends/kwayland/plugins/wrapland-wlr/wrapland_output.cpp
  backends/kwayland/plugins/wrapland-wlr/wrapland_output.h

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Besides the KWayland output-management protocol there exist other protocol
  extensions for output-management, for example wlroot's
  wlr-output-management-unstable-v1 and kwinft_output_management_unstable_v1
  protocols.
  
  This patch refactors the Wayland backend such that alternative extensions can
  be added in the future in an encaplusated way and are instantiated through a
  plugin system.
  
  All available Wayland backend plugins are fired up in parallel and the first 
to
  return success will be used while all others are rejected instantly. In theory
  this is racy if a compositor supports more than one of the supported output-
  management protocols, but there is none out at the moment and it is unlikely 
to
  happen in the future.

TEST PLAN
  Tested with KWin's Wayland session.

REPOSITORY
  R110 KScreen Library

BRANCH
  wayland-plugins

REVISION DETAIL
  https://phabricator.kde.org/D29024

AFFECTED FILES
  CONTRIBUTING.md
  backends/kwayland/CMakeLists.txt
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/kwayland/CMakeLists.txt
  backends/kwayland/plugins/kwayland/kwayland.json
  backends/kwayland/plugins/kwayland/kwayland_interface.cpp
  backends/kwayland/plugins/kwayland/kwayland_interface.h
  backends/kwayland/plugins/kwayland/kwayland_output.cpp
  backends/kwayland/plugins/kwayland/kwayland_output.h
  backends/kwayland/wayland_interface.cpp
  backends/kwayland/wayland_interface.h
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/kwayland/waylandscreen.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28949: Add titlebar colors to Kirigami::PlatformTheme

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0d5d94ebe086: Add titlebar colors to 
Kirigami::PlatformTheme (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28949?vs=80476=80708

REVISION DETAIL
  https://phabricator.kde.org/D28949

AFFECTED FILES
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg added a comment.


  In D29024#653096 , @davidedmundson 
wrote:
  
  > KScreen already is a plugin system.
  
  
  You mean libkscreen? It has a plugin system for differentiating between 
windowing systems, yes.
  
  > We don't need to go all inception, and have a plugin load plugins. It 
doesn't look to bring anything other than complexity.
  > 
  > If there is any duplication, we can just add some extra base classes in the 
lib using the split you've done above that the plugin can inherit from.
  
  That's not a practical solution. The windowing system plugins are chosen on 
the basis of Qt platform name 
 without 
running any async requests. But we need to check in async communication with 
the Wayland compositor which protocol is supported, select that one and cleanup 
the other ones. For that at least one Wayland event loop has to be launched. 
Trying to implement that on the higher level of the previously available 
plugins not needing such a runtime setup would be ill-advised.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg added a comment.


  In D29028#653150 , @davidedmundson 
wrote:
  
  > I don't see why we should have that in KDE code.
  
  
  Come on man, do you really want to make this ugly? I thought  we would still 
treat each other with respect David. :(
  
  > As per manifesto
  > 
  >> The project stays true to established practices common to similar KDE 
projects
  
  What do you mean by that? Which "established practices" does this not 
fulfill? Wrapland is free software and it is not required for the build of 
libkscreen. The default is still KWayland.
  
  > As a compromise we can install the headers of the plugin interface.
  
  How would that look in detail?

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80719.
apol added a comment.


  Proper initialisation

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80663=80719

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:28
> +TARGETS LibkscreenWaylandPluginKWayland
> +DESTINATION ${PLUGIN_INSTALL_DIR}/org.kde.libkscreen.backends/wayland/
> +)

That directory fine or are there other suggestions? I would like to centralize 
over time all plugins libkscreen seems to install at random locations in a 
single one so that's why there is the wayland subdirectory.

> waylandconfig.cpp:155
>  
> -const auto features = Config::Feature::Writable | 
> Config::Feature::PerOutputScaling
> -| Config::Feature::AutoRotation | 
> Config::Feature::TabletMode;
> -m_kscreenConfig->setSupportedFeatures(features);
> -m_kscreenConfig->setValid(m_connection->display());
> -
> -KScreen::ScreenPtr screen = m_kscreenConfig->screen();
> -m_screen->updateKScreenScreen(screen);
> -
> -//Removing removed outputs
> -const KScreen::OutputList outputs = m_kscreenConfig->outputs();
> -for (const auto  : outputs) {
> -if (!m_outputMap.contains(output->id())) {
> -m_kscreenConfig->removeOutput(output->id());
> -}
> +// TODO: qobject_cast not working here. Why?
> +auto *factory = dynamic_cast(plugin->instantiate());

Someone having an idea about that? In general the plugin system is kinda funky. 
The thing returned is a singleton and gets returned whenever instantiate is 
called (that's why there is a factory to then generate objects on the heap).

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Nathaniel Graham]

ngraham added a comment.


  In D28873#653148 , @cblack wrote:
  
  > IMO, the affordances of a traditional tab style hint at tabs being 
editable. This is fairly established: Chrome uses the traditional tab style for 
its user-manipulatable tabs, while using a different style for 
non-manipulatable tabs. Firefox does the same, as well as Falkon. elementary on 
a platform level uses traditional tabs for manipulatable tabs and a different 
style for static tabs. macOS does the same thing. Using editable-style tabs 
when the tabs are non-editable is a misleading affordance, hence why this patch 
doesn't use them.
  
  
  I feel like this needs discussion rather than being presented as a truism. We 
use tabbed views for non-editable views all over the place throughout KDE 
software and to be honest I don't see a problem with it. If we're going to 
declare this to be a bad thing and move towards changing it, we need to first 
start that discussion, agree on it, and agree on a solution.
  
  Would you like to open the Phab patch for this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg, ngraham
Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D29028: feat(wayland): add Wrapland plugin

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't see why we should have that in KDE code.
  
  As per manifesto
  
  > The project stays true to established practices common to similar KDE 
projects
  
  As a compromise we can install the headers of the plugin interface.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg added a comment.


  In D29028#653192 , @apol wrote:
  
  > I don't really see why we'd want to support something that is not offering 
ABI stability and doesn't push Plasma in any direction.
  
  
  It is offering in the same way ABI stability as most other components of 
Plasma, i.e. until a new major Plasma release.
  
  Why is this even relevant? The build is optional. Distros not providing 
Wrapland won't be affected by it.
  
  If this rejection is for political reasons just say so directly. You have 
already hinted at that with "doesn't push Plasma in any direction". Please 
think about what you are doing here.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: apol, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Nathaniel Graham]

ngraham added a subscriber: bshah.
ngraham added a comment.


  @bshah I think you said you wanted to see how this worked for PlaMo before I 
landed it? Have you had a chance to do that yet?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack
Cc: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29012: Fix variable mixup

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused icons to be not longer recolored when changing the color scheme until 
an
  application is started again

TEST PLAN
  Change color scheme while having an application open, icons should change 
color correctly

REPOSITORY
  R31 Breeze

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29012

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28945: PageRouter autotests fixes

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:845f282d2d40: PageRouter autotests fixes (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28945?vs=80470=80660

REVISION DETAIL
  https://phabricator.kde.org/D28945

AFFECTED FILES
  autotests/tst_pagerouter.qml
  src/pagerouter.cpp

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28971: Persist state between launches

[Marco Martin]

mart added a comment.


  my concern here using qsettings in this place, is  that then it kinda clashes 
when an application uses its own config  like it should, from a framework 
(kconfiggroup, kconfigskeleton etc)
  i always refrained from using any form of config read/write here, and i think 
we should continue to do so.
  Kirigami is a tier1 framework that should do the kleast possible, is more 
like KGuiAddons/§KWidgetAddons, *not* a full feature kxmlgui, which if we want 
to have something along the lines, we should have a proper framework to do so, 
and not tier1

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  Clicking the Apply button makes System Settings crash for me: P591 System 
Setting scrash log 

INLINE COMMENTS

> main.qml:118
> +icon.width: Kirigami.Units.iconSizes.small
> +onClicked: kcm.removeComponent(index)
> +QQC2.ToolTip {

When I click on it, the KCM enters this state:

F8249469: Screenshot_20200420_094821.png 

> main.qml:120
> +QQC2.ToolTip {
> +text: i18n("Remove the selected 
> component")
> +}

How about "Remove all shortcuts for [model.name]"

> main.qml:167
> +Component.onCompleted: background.visible = true
> +QQC2.Label {
> +visible: components.currentIndex == -1

Make it a level 3 `Heading`

> main.qml:173
> +}
> +ListView {
> +clip:true

For some reason this list view doesn't get any sctollbars when it's scrollable. 
Also it implements kinetic scrolling while the other list view doesn't

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28965: Support Brave browser

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:257e4dd81f87: Support Brave browser (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28965?vs=80504=80613

REVISION DETAIL
  https://phabricator.kde.org/D28965

AFFECTED FILES
  host/settings.cpp
  host/settings.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ec8da2dd5db3: Dont offer sending non-http(s)/ftp 
links and sources via KDE Connect (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28939?vs=80461=80612

REVISION DETAIL
  https://phabricator.kde.org/D28939

AFFECTED FILES
  extension/extension-kdeconnect.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[David Edmundson]

davidedmundson added a comment.


  So the problem we're solving is that we want to go
  
  Qt5.12 - QQC2.5
  Qt5.13 - QQC2.6
  Qt5.14 - QQC2.7
  Qt5.15 - QQC2.15
  
  correct?
  
  We now know all Qt5 versions, and we know that Qt6 won't have versions.
  
  I don't see why need this complicated thing instead of an "if" statement on 
Qt5QuickControls2_VERSION_MINOR

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80620.
davidre added a comment.


  Make it build again

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80553=80620

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

meven updated this revision to Diff 80616.
meven added a comment.


  Fix for loop

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=80614=80616

BRANCH
  arcpatch-D28282

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[Kai Uwe Broulik]

broulik added a comment.


  > Does this really use KServiceAction anywhere?
  
  It doesn't but it should since it also supports jump list ations. Probably 
needs similar treatment like I did with task manager in D28286 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28990

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Benjamin Port]

bport added a comment.


  According to settings.h documentation
  When invalid or in the past, do not disturb mode should be considered 
disabled.
  
  So why not setting date to invalid date or one year in the past and do a test 
if date is in the future

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Kai Uwe Broulik]

broulik added a comment.


  This is for displaying whether do not disturb is on. The "until disabled" 
option just sets it to one year in the future. But it's odd to show "until 
2021", so we don't show the date when it's too far in the future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Benjamin Port]

bport added a comment.


  In D28740#652419 , @broulik wrote:
  
  > This is for displaying whether do not disturb is on. The "until disabled" 
option just sets it to one year in the future. But it's odd to show "until 
2021", so we don't show the date when it's too far in the future.
  
  
  Why not change what the option do ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

meven updated this revision to Diff 80614.
meven added a comment.


  Rebasing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78913=80614

BRANCH
  arcpatch-D28282

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80622.
davidre added a comment.


  - Add tooltip to remove toolbutton

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80620=80622

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Björn Feber]

GB_2 added a comment.


  In D28461#640439 , 
@The-Feren-OS-Dev wrote:
  
  > How about instead of a blue dot there's instead an option in the SySe 
hamburger button menu to use search to filter out any settings pages where 
settings haven't been changed, meaning that only settings with changes made to 
them are then listed in the search results?
  
  
  I personally would like this much more than having a blue dot, otherwise it 
could get very distracting or cluttered if you made changes in many different 
KCMs.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Kai Uwe Broulik]

broulik added a comment.


  > Why not change what the option do ?
  
  so how would you reflect a "forever" as a date?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex added a comment.


  Should this(and the following patches) go to a stable branch, because they 
fix a bug that has been reported (418526)?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> breezestyle.cpp:907
> +auto rect = _helper->toolsAreaToolbarsRect(widget);
> +qDebug() << rect;
> +

Stray qdebug

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28629: [WIP] Port KCM to SettingStateBinding

[Cyril Rossi]

crossi updated this revision to Diff 80611.
crossi added a comment.


  Work on fonts and style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28629?vs=79508=80611

REVISION DETAIL
  https://phabricator.kde.org/D28629

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml

To: crossi, ervin, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28625: Use ShadowedRectangle for Card backgrounds

[Marco Martin]

mart added a comment.


  In D28625#642954 , @cblack wrote:
  
  > Looks like a nice visual improvement.
  >
  > Are the changes to the scenegraph stuff related? They don't look like a 
related change to making the Kirigami.Card use the ShadowedRectangle to me.
  
  
  they should be, as far i know, a fix for the 1 pixel border that had some 
blurriness.
  @ahiemstra can you confirm?

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80629.
davidre added a comment.


  - Fix index reset when clicking reset button and use own property for 
shortcuts listview
  
  currentIndex was reset to 0 when resetting, now warnings are generated when 
switching components need to figure out why

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80622=80629

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Ben Cooksley]

On Mon, Apr 20, 2020 at 10:29 AM Friedrich W. H. Kossebau
 wrote:
>
> Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley:
> > Hi all,
> >
> > Another breakage in Qt?
>
> Should be fixed now (restarted build now completed), with similar traps also
> removed for the future, thanks to David Faure for the work done and Ade for
> the root detecting investigations.

Thanks all for taking a look into this and making the necessary fixes!

>
> Seems Qt changed for Qt 5.14.1 -> 5.14.2 some wrappers around QSet-related API
> from
> #if QT_VERSION < QT_VERSION_CHECK(6,0,0)
> to
> #if QT_DEPRECATED_SINCE(5, 14) && QT_VERSION < QT_VERSION_CHECK(6,0,0)
> and by that stronger rules some projects no longer saw code they saw before,
> thus had started to fail.
>
> Cheers
> Friedrich
>
>

Cheers,
Ben

D28627: Adaptive panel opacity

[Niccolò Venerandi]

niccolove added a comment.


  Actually -- this seems to no longer apply panel internal margins?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80631.
davidre added a comment.


  Use Nate's string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80629=80631

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Monday meeting notes for 20/4/2020

[Marco Martin]

Nico
* We had a virtual Plasma Mobile sprint
* Lots of $discussion
* Most interesting part was the "training day" which was aimed at new
contributors
* I gave two talks: "Introduction to Kirigami" and "Porting KDE apps to Android"
* some technical difficulties unfortunately
* The Plasma Mobile docs have a section about creating KCMs. I've
overhauled it a bit. Please give it a review
* Added a visual indication when unlocking fails to the mobile
lockscreen: 
https://invent.kde.org/kde/plasma-phone-components/-/merge_requests/71
* Started collecting requirements for a mobile audio KCM: T12993
Task 12993 "Mobile Audio/Sound settings" [Open,Needs Triage]
{Plasma: Mobile,VDG} https://phabricator.kde.org/T12993
* Finally pushed forward the image annotation in spectacle that I
started at the last Plasma sprint: https://phabricator.kde.org/D22074
Diff 22074 "Add image annotation via libKImageAnnotator"
[Accepted] https://phabricator.kde.org/D22074
Fixed changing the notification volume in plasma-pa:
https://phabricator.kde.org/R115:5bdd1368957955c900d5a17bf6c890bb0920d356
Some docs tweaking for QML KCM types: https://phabricator.kde.org/D28805
Diff 28805 "Tweak kcmcontrols docs" [Needs Review]
https://phabricator.kde.org/D28805
KDE Connect:
* Fixed desktop device ringing:
https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/243
* Ported device ringing to use libcanberra instead of relying on
oxygen sounds: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/244
* Implemented device type detection so PlaMo and Bigscreen don't show
up as desktop: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/245
KTrip:
* Some UI improvements
* Made mockups for more improvements, needs VDG discussion
* Tested KTrip on PureOS/phosh on the pinephone
 * Mostly works fine, but it thinks it's in desktop because
QT_QUICK_CONTROLS_MOBILE isn't set
 * Made a report: https://source.puri.sm/Librem5/OS-issues/issues/147

 Kai Uwe:
 plasma-browser-integration:
* Did a new release \o/
https://blog.broulik.de/2020/04/plasma-browser-integration-1-7-5/
* Did a proof of concept for activity support by showing/hiding tabs as needed
* Apparently that's not that the internetz™ want. Maybe I need to
make each activity an "identity" so you can have different cookies and
sessions per activity.
* Did a proof of concept by detecting phone numbers with libphonenumber
* don't want to mess with website contents (i.e. make them
clickable) but context menu could offer to "Call" when selecting text
with a phone number in it
* Did a tonne of fixes and improvements, also please review D28926 D28936
Diff 28926 "Signal player gone in "unload" not "beforeunload"" [Needs
Review] https://phabricator.kde.org/D28926
Diff 28936 "Use a Proxy object to detect changes within the
MediaMetadata" [Needs Review] https://phabricator.kde.org/D28936
qqc2-desktop-style:
* Fixed (worked around) ComboBox not closing on click outside in KCMs
Notifications:
* Fixed actions reversing, possibly fixes KDE Connect but I don't think so
Other:
* KAccess is now a regular startup application
* Used to be launched through kcminit
* Ported KSysGuard and Task Manager away from KRun
* Fixed drag and drop in KRunner... again
* Dropped kded's delayed "second phase", see D28919
Diff 28919 "Drop delayed second phase" [Closed]
https://phabricator.kde.org/D28919
* Noticed PowerDevil's dependencies were all over the place, please
review D28904
Diff 28904 "Cleanup dependencies" [Needs Review]
https://phabricator.kde.org/D28904

Bhushan:
Okay so, 3ish items on my list
 - I (almost) finished the notification watcher patchset
 - One bug remaining to fix, which I will do today
 - processing videos for the workshops taken at PlaMo mini sprint
 3/4 processed, just 1 is pain (Intro to Kirigami by nicofee)
 questions?
 or next

 Arjen:
 * so one thing I have is that I'd really like someone to take a look
at our KSysGuard work that's been on phab for a bit
 It's these patches:
* https://phabricator.kde.org/D28141
Diff 28141 "Add KSysGuard::Sensors library" [Needs Review]
https://phabricator.kde.org/D28141
* https://phabricator.kde.org/D28140
Diff 28140 "Add a declarative plugin to ProcessCore" [Needs
Review] https://phabricator.kde.org/D28140
* https://phabricator.kde.org/D28333
Diff 28333 "Add a new daemon for stats monitoring" [Needs Review]
https://phabricator.kde.org/D28333
* I also did a patch to use ShadowedRectangle for Kirigami's cards,
along with a new design
Diff 28625 "Use ShadowedRectangle for Card backgrounds" [Accepted]
https://phabricator.kde.org/D28625

David E:
* I have been doing Qt patches a lot
* Does anyone know eskil's IRC handle? I think I need to do some
prodding as I want to get some things in before 5.15.0 branches
* one is a critical fix for nvidia on wayland
* once that's applied, nvidia wayland works surprisingly flawlessly
* using it now
* Also this weekend I fixed Qt's layout margins with RTL:

D28710: Make accidental panel and panel widget deletion more difficult

[Marco Martin]

mart added a comment.


  I reverted this change in the 5.18 branch, as there shouldn't ever be ui 
changes in stable branches (unless very, very serious)
  
  this change is still valid for master/5.19

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28710

To: ngraham, #vdg, #plasma, ndavis
Cc: mart, davidedmundson, rikmills, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28627: Adaptive panel opacity

[Niccolò Venerandi]

niccolove accepted this revision.
niccolove added a comment.


  Works great!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28154: Add users KCM

[Méven Car]

meven added a comment.


  Is the screenshot current ?
  
  ping @ngraham

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28625: Use ShadowedRectangle for Card backgrounds

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> AbstractCard.qml:31
> +id: bg
> +readonly property color pressedColor: 
> Qt.tint(Kirigami.Theme.backgroundColor, Qt.rgba(
> +
> Kirigami.Theme.highlightColor.r,

as we have a ColorUtils class now, since i've seen this super long thing just 
to make a color translucent many things, is maybe worth to have a 
ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead?

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80646.
xuetianweng added a comment.


  Just fix the version by if-else check.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80227=80646

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28625: Use ShadowedRectangle for Card backgrounds

[Arjen Hiemstra]

ahiemstra added a comment.


  In D28625#652529 , @mart wrote:
  
  > In D28625#642954 , @cblack wrote:
  >
  > > Looks like a nice visual improvement.
  > >
  > > Are the changes to the scenegraph stuff related? They don't look like a 
related change to making the Kirigami.Card use the ShadowedRectangle to me.
  >
  >
  > they should be, as far i know, a fix for the 1 pixel border that had some 
blurriness.
  >  @ahiemstra can you confirm?
  
  
  They're both things I encountered while implementing this. One is a crash 
fix, the other is indeed a fix for pixel correctness.

INLINE COMMENTS

> mart wrote in AbstractCard.qml:31
> as we have a ColorUtils class now, since i've seen this super long thing just 
> to make a color translucent many things, is maybe worth to have a 
> ColorUtils.opacity(Kirigami.Theme.highlightColor, 0.3) instead?

This basically does the same thing as Kirigami.Separator. I think it'd be good 
to have this entire thing in ColorUtils yeah.

REPOSITORY
  R169 Kirigami

BRANCH
  card_shadowrect

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, apol, ahiemstra, davidedmundson

D27786: [notifications] Read appname from desktop file if no appname set

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fd67206ce554: [notifications] Read appname from desktop 
file if no appname set (authored by nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27786?vs=76783=80641

REVISION DETAIL
  https://phabricator.kde.org/D27786

AFFECTED FILES
  libnotificationmanager/notification.cpp

To: nicolasfella, #plasma, broulik, mart
Cc: crossi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28710: Make accidental panel and panel widget deletion more difficult

[Nathaniel Graham]

ngraham added a comment.


  Oh gosh, I'm sorry. I didn't mean to to that. :/ Thanks for correcting my 
mistake!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28710

To: ngraham, #vdg, #plasma, ndavis
Cc: mart, davidedmundson, rikmills, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs 
to SettingStateBinding (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27841?vs=76953=80655

REVISION DETAIL
  https://phabricator.kde.org/D27841

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28785: Don't request blur when panel is opaque

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> panelview.cpp:1015
>  
>  QQuickItem *rootObject = this->rootObject();
>  if (rootObject) {

You have it as `casted`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28785

To: cblack, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28842: Raise size of default fixed-width font from 9 to 10pt

[Björn Feber]

GB_2 added a comment.


  Thanks for this :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28842

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  In D28859#652379 , @davidedmundson 
wrote:
  
  > So the problem we're solving is that we want to go
  >
  > Qt5.12 - QQC2.5
  >  Qt5.13 - QQC2.6
  >  Qt5.14 - QQC2.7
  >  Qt5.15 - QQC2.15
  >
  > correct?
  >
  > We now know all Qt5 versions, and we know that Qt6 won't have versions.
  >
  > I don't see why need this complicated thing instead of an "if" statement on 
Qt5QuickControls2_VERSION_MINOR
  
  
  Just to correct it, the change is since 5.12.
  5.11 -> 5.4
  5.12 -> 5.12

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now all of my QtWidgets apps are crashing with a backtrace like this one:
  
Application: Spectacle (spectacle), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
29return SYSCALL_CANCEL (poll, fds, nfds, timeout);
[Current thread is 1 (Thread 0x7f4a76a76800 (LWP 22804))]

Thread 1 (Thread 0x7f4a76a76800 (LWP 22804)):
[KCrash Handler]
#6  QRasterPaintEngine::transformChanged (this=0x7f4a700076c0) at 
painting/qpaintengine_raster.cpp:941
#7  0x7f4a795f4e5a in QPainterPrivate::updateMatrix 
(this=0x7ffdb8f85530, this@entry=0x5628c5e23790) at painting/qpainter.cpp:664
#8  0x7f4a795f7e31 in QPainter::setWorldTransform 
(this=this@entry=0x7ffdb8f85660, matrix=..., combine=combine@entry=false) at 
painting/qpainter.cpp:8389
#9  0x7f4a79f6c7a6 in QGraphicsDropShadowEffect::draw (this=, painter=0x7ffdb8f85660) at effects/qgraphicseffect.cpp:1067
#10 0x7f4a79c09f8e in QWidgetPrivate::drawWidget (this=0x5628c5b48b60, 
pdev=0x5628c5cbb720, rgn=..., offset=..., flags=..., sharedPainter=0x0, 
repaintManager=0x5628c5c8dbb0) at kernel/qwidget.cpp:5301
#11 0x7f4a79c0a883 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=, 
rgn=..., offset=..., flags=..., sharedPainter=0x0, 
repaintManager=0x5628c5c8dbb0) at 
../../include/QtCore/../../src/corelib/tools/qpoint.h:124
#12 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=0, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#13 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=1, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#14 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=2, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#15 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=3, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#16 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=4, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#17 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=5, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#18 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=6, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#19 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=7, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#20 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=8, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#21 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=11, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#22 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5ae4910, pdev=0x5628c5cbb720, siblings=..., index=13, rgn=..., 
offset=..., flags=..., sharedPainter=0x0, repaintManager=0x5628c5c8dbb0) at 
kernel/qwidget.cpp:5589
#23 0x7f4a79c0a766 in QWidgetPrivate::paintSiblingsRecursive 
(this=this@entry=0x5628c5ae4910, pdev=pdev@entry=0x5628c5cbb720, siblings=..., 
index=14, rgn=..., offset=..., flags=..., sharedPainter=0x0, 
repaintManager=0x5628c5c8dbb0) at kernel/qwidget.cpp:5589
#24 0x7f4a79c0919c in QWidgetPrivate::drawWidget (this=0x5628c5ae4910, 
pdev=0x5628c5cbb720, rgn=..., offset=..., flags=..., sharedPainter=, repaintManager=) at 
../../include/QtCore/../../src/corelib/tools/qlist.h:176
#25 0x7f4a79c0a883 in QWidgetPrivate::paintSiblingsRecursive 
(this=0x5628c5b786d0, pdev=0x5628c5cbb720, siblings=..., index=, 
rgn=..., offset=..., flags=..., sharedPainter=0x0, 
repaintManager=0x5628c5c8dbb0) at 

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:aa57b34f75f0: Detect QQC2 version at build time with 
actual detection. (authored by xuetianweng).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80646=80647

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added a subscriber: iasensio.
ngraham added a comment.


  @meven this is what it looks like now: F8249229: 
Screenshot_20200420_074955.png 
  
  @cblack Mostly okay now, just a few more broken things that need fixing.

INLINE COMMENTS

> UserDetailsPage.qml:190
> +
> +enabled: !usersDetailPage.user.loggedIn && 
> !kcm.userModel.rowCount() < 2
> +

this isn't working anymore for me

> UserDetailsPage.qml:223
> +
> +Button {
> +Layout.preferredHeight: Kirigami.Units.gridUnit * 8

This still doesn't work right. Selecting a custom image doesn't make it get 
applied when you click on the apply button, and I still can't clear avatars.

> ngraham wrote in UserDetailsPage.qml:267
> Despite this, they're still jaggy for me. Maybe play with the mipmapping 
> settings?

Still not fixed for me.

F8249187: Screenshot_20200420_073740.png 

> main.qml:104
> +
> +Column {
> +id: col

Since you're manufacturing this list item by hand, you need to manually make 
the text color of the labels use the selected text color when the item is 
selected.

> ngraham wrote in main.qml:88
> Then we'll need to fix that before this can ship. :)

Not sure it's actually a bug in the multi-page KCM system as @iasensio was able 
to make this work properly in D28152 . 
Maybe you can see what he did there?

> kcm.cpp:55
> +setAboutData(about);
> +setButtons(Apply);
> +auto font = QApplication::font("QLabel");

Navigating away from the KCM while it's in a dirty state doesn't show the 
"would you like to apply the unsaved changes" dialog like I would expect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Tranter Madi]

trmdi added a comment.


  In D28985#652097 , @ngraham wrote:
  
  > Excellent!
  >
  > Please land on the `Plasma/5.18` branch and then merge to master. Let me 
know if you need a hand with that.
  
  
  Yes, please. I don't know how to do that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:020c67fc8ba3: [Kickoff] Disable tabBars mouseArea 
when searching (authored by trmdi, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28985?vs=80554=80650

REVISION DETAIL
  https://phabricator.kde.org/D28985

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> user_manager.desktop:9
> +X-KDE-Weight=40
> +X-KDE-System-Settings-Parent-Category=personalization
> +Name=Users

You've moved it out of the Account details group. If this is intentional, then 
we also need to move the KWallet KCM out of that group, or else Account details 
has only one item and shows the KWallet KCM when clicked on, which is confusing 
because the second level of navigation is collapsed and the group name doesn't 
match the KCM name.

F8249318: Screenshot_20200420_081303.png 

So move it back into the Account Details group or submit another patch to move 
KWallet out of the group too.

> user_manager.desktop:11
> +Name=Users
> +Comment=
> +X-KDE-Keywords=user,account

Needs a comment or else the sidebar tooltip is nonsensical

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Nathaniel Graham]

ngraham added a comment.


  Actually not that I think about it, I'd teach you how, but since we're moving 
to GitLab in a few weeks, it would be a useless skill so I'll just do it now. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart