Re: [UPDATE] multimedia/gaupol to 1.10.1
On Mon, Jan 03, 2022 at 10:02:57AM +0100, Omar Polo wrote: > Anindya Mukherjee writes: > > > Hi, > > > > The attached diff updates multimedia/gaupol to 1.10.1. > > > > Ok? > > committed with REVISION removed, thanks! Thanks for the commit and the update!
[UPDATE] multimedia/gaupol to 1.10.1
Hi,
The attached diff updates multimedia/gaupol to 1.10.1.
Ok?
Index: Makefile
===
RCS file: /cvs/ports/multimedia/gaupol/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- Makefile2 Nov 2021 00:01:38 - 1.2
+++ Makefile2 Jan 2022 00:26:27 -
@@ -1,8 +1,8 @@
-# $OpenBSD: Makefile,v 1.2 2021/11/02 00:01:38 sthen Exp $
+# $OpenBSD$
COMMENT = editor for text-based subtitle files
-MODPY_EGG_VERSION =1.9
+MODPY_EGG_VERSION =1.10.1
GH_ACCOUNT = otsaloma
GH_PROJECT = gaupol
GH_TAGNAME = ${MODPY_EGG_VERSION}
Index: distinfo
===
RCS file: /cvs/ports/multimedia/gaupol/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo6 Sep 2021 09:40:47 - 1.1.1.1
+++ distinfo2 Jan 2022 00:26:27 -
@@ -1,2 +1,2 @@
-SHA256 (gaupol-1.9.tar.gz) = IkVPEqDQ60+AlITtAV/n5Iz6iI+IYtR50htwO1Q0f4k=
-SIZE (gaupol-1.9.tar.gz) = 579382
+SHA256 (gaupol-1.10.1.tar.gz) = Uwy1Wp6KMBz/biPV5xLnFCo7Gn+B1h1w5Cc9NlXGJ38=
+SIZE (gaupol-1.10.1.tar.gz) = 580890
Re: New port: Gaupol subtitle editor
On Mon, Aug 16, 2021 at 12:15:23AM -0700, Anindya Mukherjee wrote: > On Sun, Aug 15, 2021 at 12:21:45AM +0200, Stefan Hagen wrote: > > Anindya Mukherjee wrote: > > > On Sat, Aug 14, 2021 at 06:27:05PM +0200, Stefan Hagen wrote: > > > > Anindya Mukherjee wrote: > > > > > Ping > > > > > > > > > > On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote: > > > > > > start COMMENT with lower-case please (unless it's a proper noun, > > > > > > but that doesn't apply here). > > > > > > > > > > > > we are a bit busy fixing hundreds of ports for a forthcoming > > > > > > clang update at the moment so it may take a while to get to it :) > > > > > > > > I reviewed this port. It works fine and it is a useful tool. > > > > > > > > Remarks: > > > > - NO_TEST=Yes should be set when there are no regression tests > > > > - pkg/DESCR mentions README.aeidon.md, which is nowhere to be found > > > > > > > > You can either install the file (to share/doc/), or link to the API > > > > docs directly: https://otsaloma.io/gaupol/doc/api/aeidon.html > > > > > > > > But actually, I think we can omit the paragraph about aeidon. If we want > > > > it to be used by other software, we should package it independently from > > > > the GTK UI. Right now, it's only used by gaupol and so I would not give > > > > it special treatment. > > > > > > Thanks a lot for reviewing the port. I have updated it following your > > > suggestions above. Please have a look. > > > > Looks good to me. > > > > Thanks, > > Stefan > > Thanks! Looking forward to getting it committed. > > Regards, > Anindya ping
Re: New port: Gaupol subtitle editor
On Sun, Aug 15, 2021 at 12:21:45AM +0200, Stefan Hagen wrote: > Anindya Mukherjee wrote: > > On Sat, Aug 14, 2021 at 06:27:05PM +0200, Stefan Hagen wrote: > > > Anindya Mukherjee wrote: > > > > Ping > > > > > > > > On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote: > > > > > start COMMENT with lower-case please (unless it's a proper noun, > > > > > but that doesn't apply here). > > > > > > > > > > we are a bit busy fixing hundreds of ports for a forthcoming > > > > > clang update at the moment so it may take a while to get to it :) > > > > > > I reviewed this port. It works fine and it is a useful tool. > > > > > > Remarks: > > > - NO_TEST=Yes should be set when there are no regression tests > > > - pkg/DESCR mentions README.aeidon.md, which is nowhere to be found > > > > > > You can either install the file (to share/doc/), or link to the API > > > docs directly: https://otsaloma.io/gaupol/doc/api/aeidon.html > > > > > > But actually, I think we can omit the paragraph about aeidon. If we want > > > it to be used by other software, we should package it independently from > > > the GTK UI. Right now, it's only used by gaupol and so I would not give > > > it special treatment. > > > > Thanks a lot for reviewing the port. I have updated it following your > > suggestions above. Please have a look. > > Looks good to me. > > Thanks, > Stefan Thanks! Looking forward to getting it committed. Regards, Anindya
Re: New port: Gaupol subtitle editor
On Sat, Aug 14, 2021 at 06:27:05PM +0200, Stefan Hagen wrote: > Anindya Mukherjee wrote: > > Ping > > > > On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote: > > > start COMMENT with lower-case please (unless it's a proper noun, > > > but that doesn't apply here). > > > > > > we are a bit busy fixing hundreds of ports for a forthcoming > > > clang update at the moment so it may take a while to get to it :) > > I reviewed this port. It works fine and it is a useful tool. > > Remarks: > - NO_TEST=Yes should be set when there are no regression tests > - pkg/DESCR mentions README.aeidon.md, which is nowhere to be found > > You can either install the file (to share/doc/), or link to the API > docs directly: https://otsaloma.io/gaupol/doc/api/aeidon.html > > But actually, I think we can omit the paragraph about aeidon. If we want > it to be used by other software, we should package it independently from > the GTK UI. Right now, it's only used by gaupol and so I would not give > it special treatment. > > Portcheck, make lib-depends-check are fine. > > Thanks for the work! > > Stefan Hi Stefan, Thanks a lot for reviewing the port. I have updated it following your suggestions above. Please have a look. Regards, Anindya gaupol.tar.gz Description: application/tar-gz
Re: New port: Gaupol subtitle editor
Ping
On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote:
> start COMMENT with lower-case please (unless it's a proper noun,
> but that doesn't apply here).
>
> we are a bit busy fixing hundreds of ports for a forthcoming
> clang update at the moment so it may take a while to get to it :)
>
>
> On 2021/02/02 06:41, Anindya Mukherjee wrote:
> > Attached tarball.
> >
> >
> > From: Anindya Mukherjee
> > Sent: February 1, 2021 10:31 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi, just to recap:
> >
> > This package provides Gaupol, an editor for
> > text-based subtitle files.
> >
> > Maintainer: Anindya Mukherjee
> >
> > Homepage: https://otsaloma.io/gaupol/
> >
> > Comments? OKs? I'm using it on my machine,
> > installed from pkg.
> >
> > Thanks!
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 7:18 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Updated tarball attached. I have added myself as
> > maintainer.
> >
> > Thanks,
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 12:04 AM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi,
> >
> > Many thanks for the comments and fixes. Sure, I can take
> > maintainer. So, it looks like I only need to add maintainer
> > to your version? Build and package looks ok and runs.
> > Any other suggestions?
> >
> > Thanks,
> > Anindya
> >
> > From: Dimitri Karamazov
> > Sent: January 28, 2021 9:14 PM
> > To: Anindya Mukherjee
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > > It supports multiple subtitle file formats and provides means of
> > > creating, editing and translating subtitles and timing subtitles to
> > > match video.
> > >
> > > This is my first port, so there might be things I missed. I have tried
> > > to follow the porting guide closely. Please have a look and comment.
> > >
> > > Thanks,
> > > Anindya
> >
> > I've reattached with some changes
> >
> > -py-* nomenclature is used for python modules not for standalone ports
> > like this, so I've removed it.
> > -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> > in this case.
> > -rearranged the dependencies in alpha order and added some missing
> > runtime depends.
> >
> > There are many tests available but most of those need xorg, access to which
> > _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> > if MODPY_PYTEST is of any use if the tests don't run on their own.
> >
> > Also I recommended you take maintainer since you're going to use it.
> >
> > regards,
> > Dimitri
>
>
gaupol.tar.gz
Description: application/tar-gz
Re: multimedia/mpv debug vo=gpu crash on exit
Hi, On Wed, May 05, 2021 at 07:03:44PM +0200, Hiltjo Posthuma wrote: > On Wed, May 05, 2021 at 01:38:06PM +0200, Sebastien Marie wrote: > > On Wed, May 05, 2021 at 12:52:54PM +0200, Hiltjo Posthuma wrote: > > > > > > Hi, > > > > > > I can (still) reproduce this issue. I don't use Iris though. > > > > > > Using LD_PRELOAD still crashes for me too. Did you make other changes to > > > the > > > mpv code? > > > > > > > the library to use in LD_PRELOAD will depend of the gpu. on mine > > system, it is radeonsi_dri.so for example. Yes, I was so focused on my system that I neglected to mention that the exact filename will depend on your GPU, thanks for mentioning that! > > > > you could try with LD_DEBUG=1 to see the ld.so activity: > > > > $ LD_DEBUG=1 mpv --vo=gpu file.mp4 > > [...] > > (+) Video --vid=1 (*) (h264 640x360 25.000fps) > > (+) Audio --aid=1 (*) (aac 2ch 48000Hz) > > tib new=0x790502c1000 > > dlopen: loading: /usr/X11R6/lib/modules/dri/radeonsi_dri.so > > flags /usr/X11R6/lib/modules/dri/radeonsi_dri.so = 0x0 > > [...] > > Exiting... (Quit) > > free tib=0x790685f6800 > > free tib=0x790502c1a00 > > free tib=0x790685f6400 > > free tib=0x7908242bc00 > > pthread_mutex_destroy on mutex with waiters! > > free tib=0x790502c1600 > > free tib=0x78fe0bb9800 > > free tib=0x790502c1400 > > free tib=0x790502c1200 > > doing dtors obj 0x79020c0cc00 @0x790ca41c700: > > [/usr/X11R6/lib/modules/dri/radeonsi_dri.so] > > doing dtors obj 0x7908242a400 @0x7907e37c3d0: [/usr/lib/libelf.so.3.0] > > doing dtors obj 0x79042c59000 @0x790cd9b4ad0: [/usr/lib/libLLVM.so.5.0] > > doing dtors obj 0x79017a94c00 @0x7908e87a520: > > [/usr/X11R6/lib/libdrm_radeon.so.4.0] > > doing dtors obj 0x79042c59400 @0x79026e63b70: > > [/usr/X11R6/lib/libdrm_amdgpu.so.1.10] > > unload_shlib called on /usr/X11R6/lib/modules/dri/radeonsi_dri.so > > unload_shlib called on /usr/X11R6/lib/libglapi.so.0.3 > > unload_shlib called on /usr/lib/libelf.so.3.0 > > unload_shlib unloading on /usr/lib/libelf.so.3.0 > > unload_shlib called on /usr/lib/libLLVM.so.5.0 > > unload_shlib unloading on /usr/lib/libLLVM.so.5.0 > > unload_shlib called on /usr/lib/libexpat.so.12.0 > > unload_shlib called on /usr/lib/libz.so.5.0 > > unload_shlib called on /usr/lib/libm.so.10.1 > > unload_shlib called on /usr/X11R6/lib/libdrm.so.7.9 > > unload_shlib called on /usr/X11R6/lib/libdrm_radeon.so.4.0 > > unload_shlib called on /usr/X11R6/lib/libdrm.so.7.9 > > unload_shlib unloading on /usr/X11R6/lib/libdrm_radeon.so.4.0 > > unload_shlib called on /usr/X11R6/lib/libdrm_amdgpu.so.1.10 > > unload_shlib called on /usr/X11R6/lib/libdrm.so.7.9 > > unload_shlib unloading on /usr/X11R6/lib/libdrm_amdgpu.so.1.10 > > unload_shlib called on /usr/lib/libc++.so.8.0 > > unload_shlib called on /usr/lib/libc++abi.so.5.0 > > unload_shlib called on /usr/lib/libpthread.so.26.1 > > unload_shlib unloading on /usr/X11R6/lib/modules/dri/radeonsi_dri.so > > Segmentation fault > > > > > > I wonder if /usr/X11R6/lib/modules/dri/*.so libraries should be linked > > with -znodelete to keep them after loading. Another possibility would > > be using RTLD_NODELETE on dlopen() call, but it needs to be > > implemented first (it should be simple to do as we support > > DF_1_NODELETE Elf flag). > > > > It would be interesting to know what Linux is doing here. Thanks for the suggestions. I have an Arch Linux test system where I plan to repeat this experiment. Will report back soon. > > > > Thanks. > > -- > > Sebastien Marie > > Thanks that worked! I used the wrong .so. Now it also doesn't crash anymore. > > For completeness I used: > > LD_PRELOAD=/usr/X11R6/lib/modules/dri/i965_dri.so LD_DEBUG=1 \ > mpv -vo=gpu 'https://www.youtube.com/embed/QTk688cXTsA' > > -- > Kind regards, > Hiltjo It's a dirty workaround but hopefully it will make mpv usable as a player from other programs e.g. qutebrowser which get confused by the crash and display error messages. Regards, Anindya
multimedia/mpv debug vo=gpu crash on exit
Hi,
I have been investigating the crash on exit problem with mpv in ports
with vo=gpu. I think I made a little bit of progress and thought I'd
share my findings.
The crash (SIGSEGV) happens when thread local destructors
are called from /usr/src/lib/libc/thread/rthread_tls.c:182 in
_rthread_tls_destructors after the gpu thread exits: vo_thread in
video/out/vo.c:1067. The crashing call stack looks like this:
#0 0x0176ffdc9680 in ?? ()
#1 0x017748d347b5 in _rthread_tls_destructors (thread=0x17798917840) at
/usr/src/lib/libc/thread/rthread_tls.c:182
#2 0x017748d98623 in _libc_pthread_exit (retval=) at
/usr/src/lib/libc/thread/rthread.c:150
#3 0x017795b22189 in _rthread_start (v=) at /usr/src/lib/librthread/rthread.c:97
#4 0x017748d0c5ba in __tfork_thread () at
/usr/src/lib/libc/arch/amd64/sys/tfork_thread.S:84
Note that some of the traces were taken from different runs so there
might be some mismatch between the handles/addresses.
It crashes because the destructor is dangling. This mystified me because
if I look at the mpv source, there is no thread local data for the gpu
thread. Indeed, right after the gpu thread starts running if we look
inside the thread structure, local_storage is null. However, if we look
at the same thread at the point of the crash, its local_storage is
populated:
(gdb) p *(*thread).local_storage
$3 = {
keyid = 7,
next = 0x177353442e0,
data = 0x1770c276000
}
The keys are indexed by the keyid in the rkeys array, from where the
destructor is fetched in _rthread_tls_destructors:
(gdb) p rkeys[7]
$6 = {
used = 1,
destructor = 0x43dd33e2680
}
This destructor now points to invalid memory. It turns out the thread
local storage is being initialised here:
#0 _libc_pthread_key_create (key=0x43dd380da08, destructor=0x43dd33e2680) at
/usr/src/lib/libc/thread/rthread_tls.c:42
#1 0x043dd33e2667 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#2 0x043e793f82f7 in pthread_once (once_control=0x43dd380d9f8,
init_routine=0x43e793db3c0 <_libc_pthread_key_create>) at
/usr/src/lib/libc/thread/rthread_once.c:26
#3 0x043dd33e24bd in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#4 0x043dd305475f in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#5 0x043dd3036c70 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#6 0x043dd30e3ca3 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#7 0x043dd30e4b96 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#8 0x043dd302d89a in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#9 0x043dd3031162 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#10 0x043dd3031ec6 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#11 0x043dd30f7a8b in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#12 0x043dd311a94e in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#13 0x043dd311addf in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#14 0x043dd33ae4a6 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#15 0x043dd33ad6a2 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#16 0x043dd276e1d3 in ?? () from /usr/X11R6/lib/modules/dri/iris_dri.so
#17 0x043b8f0816c6 in gl_clear (ra=0x43e50a61a50, dst=0x43e399aa950,
color=0x43e0e382370, scissor=0x43e0e382390) at
../mpv-0.33.1/video/out/opengl/ra_gl.c:684
#18 0x043b8f061db8 in gl_video_render_frame (p=0x43db938c050,
frame=0x43e399bb350, fbo=..., flags=3) at
../mpv-0.33.1/video/out/gpu/video.c:3251
#19 0x043b8f089a8f in draw_frame (vo=0x43e32b9f450, frame=0x43e399bb350) at
../mpv-0.33.1/video/out/vo_gpu.c:87
#20 0x043b8f0882a4 in render_frame (vo=0x43e32b9f450) at
../mpv-0.33.1/video/out/vo.c:957
#21 0x043b8f087735 in vo_thread (ptr=0x43e32b9f450) at
../mpv-0.33.1/video/out/vo.c:1095
#22 0x043da1682181 in _rthread_start (v=) at /usr/src/lib/librthread/rthread.c:96
#23 0x043e793b35ba in __tfork_thread () at
/usr/src/lib/libc/arch/amd64/sys/tfork_thread.S:84
So the mpv code is not directly aware of the TLS, and it is being
allocated in iris_dri.so. This trace was taken at the start of video
playback, and at this point iris_dri.so is loaded (using dlopen) and the
destructor is valid.
#0 dlopen (libname=0xbbddfb93320 "/usr/X11R6/lib/modules/dri/iris_dri.so",
flags=258) at /usr/src/libexec/ld.so/dlfcn.c:51
#1 0x0bbd76e126e6 in loader_open_driver (driver_name=0xbbd52b277e0 "iris",
out_driver_handle=0xbbd417eda28, search_path_vars=) at
/usr/xenocara/lib/mesa/mk/libloader/../../src/loader/loader.c:579
#2 0x0bbd76e0a7a8 in dri2_open_driver (disp=) at
/usr/xenocara/lib/mesa/mk/libEGL/../../src/egl/drivers/dri2/egl_dri2.c:771
#3 dri2_load_driver_common (disp=, driver_extensions=) at
/usr/xenocara/lib/mesa/mk/libEGL/../../src/egl/drivers/dri2/egl_dri2.c:783
#4 dri2_load_driver_dri3 (disp=) at
/usr/xenocara/lib/mesa/mk/libEGL/../../src/egl/drivers/dri2/egl_dri2.c:808
#5 0x0bbd76e0331c in dri2_initialize_x11_dri3 (drv=,
disp=0xbbd4180c000)
Re: New port: Gaupol subtitle editor
Ping
On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote:
> start COMMENT with lower-case please (unless it's a proper noun,
> but that doesn't apply here).
>
> we are a bit busy fixing hundreds of ports for a forthcoming
> clang update at the moment so it may take a while to get to it :)
>
>
> On 2021/02/02 06:41, Anindya Mukherjee wrote:
> > Attached tarball.
> >
> >
> > From: Anindya Mukherjee
> > Sent: February 1, 2021 10:31 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi, just to recap:
> >
> > This package provides Gaupol, an editor for
> > text-based subtitle files.
> >
> > Maintainer: Anindya Mukherjee
> >
> > Homepage: https://otsaloma.io/gaupol/
> >
> > Comments? OKs? I'm using it on my machine,
> > installed from pkg.
> >
> > Thanks!
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 7:18 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Updated tarball attached. I have added myself as
> > maintainer.
> >
> > Thanks,
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 12:04 AM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi,
> >
> > Many thanks for the comments and fixes. Sure, I can take
> > maintainer. So, it looks like I only need to add maintainer
> > to your version? Build and package looks ok and runs.
> > Any other suggestions?
> >
> > Thanks,
> > Anindya
> >
> > From: Dimitri Karamazov
> > Sent: January 28, 2021 9:14 PM
> > To: Anindya Mukherjee
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > > It supports multiple subtitle file formats and provides means of
> > > creating, editing and translating subtitles and timing subtitles to
> > > match video.
> > >
> > > This is my first port, so there might be things I missed. I have tried
> > > to follow the porting guide closely. Please have a look and comment.
> > >
> > > Thanks,
> > > Anindya
> >
> > I've reattached with some changes
> >
> > -py-* nomenclature is used for python modules not for standalone ports
> > like this, so I've removed it.
> > -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> > in this case.
> > -rearranged the dependencies in alpha order and added some missing
> > runtime depends.
> >
> > There are many tests available but most of those need xorg, access to which
> > _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> > if MODPY_PYTEST is of any use if the tests don't run on their own.
> >
> > Also I recommended you take maintainer since you're going to use it.
> >
> > regards,
> > Dimitri
>
>
gaupol.tar.gz
Description: application/tar-gz
Re: Qutebrowser bug with prefers-color-scheme
On Tue, Apr 06, 2021 at 02:06:46PM +, Dimitri Karamazov wrote:
> On Tue, Apr 06, 2021 at 11:41:11AM +0100, Stuart Henderson wrote:
> > On 2021/04/06 03:13, Anindya Mukherjee wrote:
> > > On Tue, Apr 06, 2021 at 10:26:49AM +0100, Stuart Henderson wrote:
> > > > O I see what it's doing. Yeuch.
> > > >
> > > > 'This is a "best effort" parser. If it errors out, we instead end up
> > > > relying
> > > > on the PyQtWebEngine version, which is the next best thing.'
> > > >
> > > > This suggests that the fallback is not working correctly. We aren't
> > > > doing
> > > > anything funny with the PyQtWebEngine version.
> > >
> > > For some reason the fallback reports Chromium version as 87.x instead of
> > > 83.x which we have. Debug output (just below the logo):
> > > http://ix.io/2V9a
> > >
> > > I haven't looked into this further to see exactly why PyQt reports the
> > > wrong version. QtWebEngine is reported as 5.15.4 instead of 5.15.2.
> >
> > Seems that it is picking up the version number of PyQtWebEngine, not
> > QtWebEngine.
> >
> > If the QtWebEngine version number isn't available from PyQtWebEngine then
> > I suppose it could look for the highest-numbered library version instead and
> > use that for the ELF parser..not ideal but at least that should stay working
> > when QtWebEngine is updated.
> >
> This patch does the job of finding library with the highest version quite
> well.
> I've tested with the plurality of some base library versions.
>
> regards,
> Dimitri
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/www/qutebrowser/Makefile,v
> retrieving revision 1.28
> diff -u -p -r1.28 Makefile
> --- Makefile 2 Apr 2021 14:24:40 - 1.28
> +++ Makefile 6 Apr 2021 13:54:37 -
> @@ -4,6 +4,7 @@ COMMENT = keyboard-focused browser with
>
> MODPY_EGG_VERSION = 2.1.1
> DISTNAME = qutebrowser-${MODPY_EGG_VERSION}
> +REVISION = 0
>
> HOMEPAGE = https://www.qutebrowser.org/
>
> Index: patches/patch-qutebrowser_misc_elf_py
> ===
> RCS file: patches/patch-qutebrowser_misc_elf_py
> diff -N patches/patch-qutebrowser_misc_elf_py
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ patches/patch-qutebrowser_misc_elf_py 6 Apr 2021 13:54:37 -
> @@ -0,0 +1,18 @@
> +$OpenBSD$
> +
> +Fix QtWebEngine version detection on OpenBSD
> +
> +Index: qutebrowser/misc/elf.py
> +--- qutebrowser/misc/elf.py.orig
> qutebrowser/misc/elf.py
> +@@ -316,8 +316,8 @@ def parse_webenginecore() -> Optional[Versions]:
> + else:
> + library_path =
> pathlib.Path(QLibraryInfo.location(QLibraryInfo.LibrariesPath))
> +
> +-# PyQt bundles those files with a .5 suffix
> +-lib_file = library_path / 'libQt5WebEngineCore.so.5'
> ++library_name =
> sorted(list(pathlib.Path(library_path).glob('libQt5WebEngineCore.so*')))
> ++lib_file = library_path / library_name[-1].as_posix()
> + if not lib_file.exists():
> + return None
> +
Thanks!, works for me as well.
Regards,
Anindya
Re: Qutebrowser bug with prefers-color-scheme
On Tue, Apr 06, 2021 at 10:26:49AM +0100, Stuart Henderson wrote: > O I see what it's doing. Yeuch. > > 'This is a "best effort" parser. If it errors out, we instead end up relying > on the PyQtWebEngine version, which is the next best thing.' > > This suggests that the fallback is not working correctly. We aren't doing > anything funny with the PyQtWebEngine version. For some reason the fallback reports Chromium version as 87.x instead of 83.x which we have. Debug output (just below the logo): http://ix.io/2V9a I haven't looked into this further to see exactly why PyQt reports the wrong version. QtWebEngine is reported as 5.15.4 instead of 5.15.2. > > > -- > Sent from a phone, apologies for poor formatting. > On 6 April 2021 09:41:02 Anindya Mukherjee wrote: > > > On Tue, Apr 06, 2021 at 09:16:29AM +0100, Stuart Henderson wrote: > > > On 2021/04/05 19:56, Anindya Mukherjee wrote: > > > > Hi, > > > > > > > > Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme > > > > setting to not work correctly (e.g., test sites show that it is not > > > > supported, etc.). The problem is a hard-coded library filename for > > > > libQt5WebEngineCore.so.5 in > > > > /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked > > > > with The-Compiler and a fix has been committed upstream: > > > > https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0 > > > > Would it be possible to backport this into the current port? I have > > > > tested the patch on my system and it fixes the issue. To test, simply > > > > set colors.webpage.preferred_color_scheme = dark and load > > > > https://www.openbsd.org/faq/. It will be displayed using the light > > > > scheme without this fix, regardless of the above setting. > > > > > > > > OTOH 2.2 is not too far off and updating to that won't need maintaining > > > > a patch. I'm not sure what is the best way to proceed. > > > > > > > > Regards, > > > > Anindya > > > > > > > > > > The fix is not correct, it should not check for existence of the file, > > > just > > > try to dlopen libQt5WebEngineCore.so (no version). > > > > > > See dlopen(3) "When a shared library is specified without a version ..." > > > > > > > Thanks, this makes sense. In fact in my own C code I do exactly what you > > suggested. I'll chat with upstream to see if this can be done in the > > python code and avoid looping through a file list. > > > > Regards, > > Anindya >
Re: Qutebrowser bug with prefers-color-scheme
On Tue, Apr 06, 2021 at 09:16:29AM +0100, Stuart Henderson wrote: > On 2021/04/05 19:56, Anindya Mukherjee wrote: > > Hi, > > > > Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme > > setting to not work correctly (e.g., test sites show that it is not > > supported, etc.). The problem is a hard-coded library filename for > > libQt5WebEngineCore.so.5 in > > /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked > > with The-Compiler and a fix has been committed upstream: > > https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0 > > Would it be possible to backport this into the current port? I have > > tested the patch on my system and it fixes the issue. To test, simply > > set colors.webpage.preferred_color_scheme = dark and load > > https://www.openbsd.org/faq/. It will be displayed using the light > > scheme without this fix, regardless of the above setting. > > > > OTOH 2.2 is not too far off and updating to that won't need maintaining > > a patch. I'm not sure what is the best way to proceed. > > > > Regards, > > Anindya > > > > The fix is not correct, it should not check for existence of the file, just > try to dlopen libQt5WebEngineCore.so (no version). > > See dlopen(3) "When a shared library is specified without a version ..." > Thanks, this makes sense. In fact in my own C code I do exactly what you suggested. I'll chat with upstream to see if this can be done in the python code and avoid looping through a file list. Regards, Anindya
Re: Qutebrowser bug with prefers-color-scheme
On Tue, Apr 06, 2021 at 04:51:30AM +, Dimitri Karamazov wrote:
> On Mon, Apr 06, 2021 at 03:08:45AM -0000, Anindya Mukherjee wrote:
> >On Mon, Apr 05, 2021 at 07:56:54PM -0700, Anindya Mukherjee wrote:
> >> Hi,
> >>
> >> Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme
> >> setting to not work correctly (e.g., test sites show that it is not
> >> supported, etc.). The problem is a hard-coded library filename for
> >> libQt5WebEngineCore.so.5 in
> >> /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked
> >> with The-Compiler and a fix has been committed upstream:
> >> https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0
> >> Would it be possible to backport this into the current port? I have
> >> tested the patch on my system and it fixes the issue. To test, simply
> >> set colors.webpage.preferred_color_scheme = dark and load
> >> https://www.openbsd.org/faq/. It will be displayed using the light
> >> scheme without this fix, regardless of the above setting.
> >>
> >> OTOH 2.2 is not too far off and updating to that won't need maintaining
> >> a patch. I'm not sure what is the best way to proceed.
> >>
> >> Regards,
> >> Anindya
> >
> >Incidentally, setting QUTE_DARKMODE_VARIANT=qt_515_2 also works around
> >the bug by forcing the library version to what we know is the correct
> >one for OpenBSD.
>
> Should've CC'd me. Do you've any idea about the release date for 2.2?
> Hopefully this will do in the meanwhile.
Sorry, I'll keep that in mind for the future. Not sure about the exact
date for 2.2 release but I was told by the developer that it is "soon".
I'll ask him.
>
> Build & Run tested on amd64.
>
> regards,
> Dimitri
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/www/qutebrowser/Makefile,v
> retrieving revision 1.28
> diff -u -p -r1.28 Makefile
> --- Makefile 2 Apr 2021 14:24:40 - 1.28
> +++ Makefile 6 Apr 2021 04:06:59 -
> @@ -4,6 +4,7 @@ COMMENT = keyboard-focused browser with
>
> MODPY_EGG_VERSION = 2.1.1
> DISTNAME = qutebrowser-${MODPY_EGG_VERSION}
> +REVISION = 0
>
> HOMEPAGE = https://www.qutebrowser.org/
>
> @@ -25,6 +26,9 @@ RUN_DEPENDS = devel/desktop-file-utils
> x11/py-qt5${MODPY_FLAVOR} \
> www/py-jinja2${MODPY_FLAVOR} \
> www/py-qtwebengine${MODPY_FLAVOR}
> +
> +post-patch:
> + sed -i s,so.5,so.1.0, ${WRKSRC}/qutebrowser/misc/elf.py
>
> post-install:
> ${INSTALL_DATA_DIR} ${PREFIX}/share/applications/
Thanks for the quick response and the patch! I tried it and it works as
expected.
Regards,
Anindya
Re: Qutebrowser bug with prefers-color-scheme
On Mon, Apr 05, 2021 at 07:56:54PM -0700, Anindya Mukherjee wrote: > Hi, > > Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme > setting to not work correctly (e.g., test sites show that it is not > supported, etc.). The problem is a hard-coded library filename for > libQt5WebEngineCore.so.5 in > /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked > with The-Compiler and a fix has been committed upstream: > https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0 > Would it be possible to backport this into the current port? I have > tested the patch on my system and it fixes the issue. To test, simply > set colors.webpage.preferred_color_scheme = dark and load > https://www.openbsd.org/faq/. It will be displayed using the light > scheme without this fix, regardless of the above setting. > > OTOH 2.2 is not too far off and updating to that won't need maintaining > a patch. I'm not sure what is the best way to proceed. > > Regards, > Anindya Incidentally, setting QUTE_DARKMODE_VARIANT=qt_515_2 also works around the bug by forcing the library version to what we know is the correct one for OpenBSD.
Qutebrowser bug with prefers-color-scheme
Hi, Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme setting to not work correctly (e.g., test sites show that it is not supported, etc.). The problem is a hard-coded library filename for libQt5WebEngineCore.so.5 in /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked with The-Compiler and a fix has been committed upstream: https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0 Would it be possible to backport this into the current port? I have tested the patch on my system and it fixes the issue. To test, simply set colors.webpage.preferred_color_scheme = dark and load https://www.openbsd.org/faq/. It will be displayed using the light scheme without this fix, regardless of the above setting. OTOH 2.2 is not too far off and updating to that won't need maintaining a patch. I'm not sure what is the best way to proceed. Regards, Anindya
Re: New port: Gaupol subtitle editor
Ping
On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote:
> start COMMENT with lower-case please (unless it's a proper noun,
> but that doesn't apply here).
>
> we are a bit busy fixing hundreds of ports for a forthcoming
> clang update at the moment so it may take a while to get to it :)
>
>
> On 2021/02/02 06:41, Anindya Mukherjee wrote:
> > Attached tarball.
> >
> >
> > From: Anindya Mukherjee
> > Sent: February 1, 2021 10:31 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi, just to recap:
> >
> > This package provides Gaupol, an editor for
> > text-based subtitle files.
> >
> > Maintainer: Anindya Mukherjee
> >
> > Homepage: https://otsaloma.io/gaupol/
> >
> > Comments? OKs? I'm using it on my machine,
> > installed from pkg.
> >
> > Thanks!
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 7:18 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Updated tarball attached. I have added myself as
> > maintainer.
> >
> > Thanks,
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 12:04 AM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi,
> >
> > Many thanks for the comments and fixes. Sure, I can take
> > maintainer. So, it looks like I only need to add maintainer
> > to your version? Build and package looks ok and runs.
> > Any other suggestions?
> >
> > Thanks,
> > Anindya
> >
> > From: Dimitri Karamazov
> > Sent: January 28, 2021 9:14 PM
> > To: Anindya Mukherjee
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > > It supports multiple subtitle file formats and provides means of
> > > creating, editing and translating subtitles and timing subtitles to
> > > match video.
> > >
> > > This is my first port, so there might be things I missed. I have tried
> > > to follow the porting guide closely. Please have a look and comment.
> > >
> > > Thanks,
> > > Anindya
> >
> > I've reattached with some changes
> >
> > -py-* nomenclature is used for python modules not for standalone ports
> > like this, so I've removed it.
> > -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> > in this case.
> > -rearranged the dependencies in alpha order and added some missing
> > runtime depends.
> >
> > There are many tests available but most of those need xorg, access to which
> > _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> > if MODPY_PYTEST is of any use if the tests don't run on their own.
> >
> > Also I recommended you take maintainer since you're going to use it.
> >
> > regards,
> > Dimitri
>
>
gaupol.tar.gz
Description: application/tar-gz
Re: New port: Gaupol subtitle editor
Ping
On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote:
> start COMMENT with lower-case please (unless it's a proper noun,
> but that doesn't apply here).
>
> we are a bit busy fixing hundreds of ports for a forthcoming
> clang update at the moment so it may take a while to get to it :)
>
>
> On 2021/02/02 06:41, Anindya Mukherjee wrote:
> > Attached tarball.
> >
> >
> > From: Anindya Mukherjee
> > Sent: February 1, 2021 10:31 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi, just to recap:
> >
> > This package provides Gaupol, an editor for
> > text-based subtitle files.
> >
> > Maintainer: Anindya Mukherjee
> >
> > Homepage: https://otsaloma.io/gaupol/
> >
> > Comments? OKs? I'm using it on my machine,
> > installed from pkg.
> >
> > Thanks!
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 7:18 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Updated tarball attached. I have added myself as
> > maintainer.
> >
> > Thanks,
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 12:04 AM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi,
> >
> > Many thanks for the comments and fixes. Sure, I can take
> > maintainer. So, it looks like I only need to add maintainer
> > to your version? Build and package looks ok and runs.
> > Any other suggestions?
> >
> > Thanks,
> > Anindya
> >
> > From: Dimitri Karamazov
> > Sent: January 28, 2021 9:14 PM
> > To: Anindya Mukherjee
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > > It supports multiple subtitle file formats and provides means of
> > > creating, editing and translating subtitles and timing subtitles to
> > > match video.
> > >
> > > This is my first port, so there might be things I missed. I have tried
> > > to follow the porting guide closely. Please have a look and comment.
> > >
> > > Thanks,
> > > Anindya
> >
> > I've reattached with some changes
> >
> > -py-* nomenclature is used for python modules not for standalone ports
> > like this, so I've removed it.
> > -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> > in this case.
> > -rearranged the dependencies in alpha order and added some missing
> > runtime depends.
> >
> > There are many tests available but most of those need xorg, access to which
> > _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> > if MODPY_PYTEST is of any use if the tests don't run on their own.
> >
> > Also I recommended you take maintainer since you're going to use it.
> >
> > regards,
> > Dimitri
>
>
gaupol.tar.gz
Description: application/tar-gz
Re: New port: Gaupol subtitle editor
Hi, reattaching the tarball for convenience, thanks!
Anindya
On Tue, Feb 02, 2021 at 11:50:40AM +, Stuart Henderson wrote:
> start COMMENT with lower-case please (unless it's a proper noun,
> but that doesn't apply here).
>
> we are a bit busy fixing hundreds of ports for a forthcoming
> clang update at the moment so it may take a while to get to it :)
>
>
> On 2021/02/02 06:41, Anindya Mukherjee wrote:
> > Attached tarball.
> >
> >
> > From: Anindya Mukherjee
> > Sent: February 1, 2021 10:31 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi, just to recap:
> >
> > This package provides Gaupol, an editor for
> > text-based subtitle files.
> >
> > Maintainer: Anindya Mukherjee
> >
> > Homepage: https://otsaloma.io/gaupol/
> >
> > Comments? OKs? I'm using it on my machine,
> > installed from pkg.
> >
> > Thanks!
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 7:18 PM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Updated tarball attached. I have added myself as
> > maintainer.
> >
> > Thanks,
> > Anindya
> >
> >
> > From: Anindya Mukherjee
> > Sent: January 29, 2021 12:04 AM
> > To: Dimitri Karamazov
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > Hi,
> >
> > Many thanks for the comments and fixes. Sure, I can take
> > maintainer. So, it looks like I only need to add maintainer
> > to your version? Build and package looks ok and runs.
> > Any other suggestions?
> >
> > Thanks,
> > Anindya
> >
> > From: Dimitri Karamazov
> > Sent: January 28, 2021 9:14 PM
> > To: Anindya Mukherjee
> > Cc: ports@openbsd.org
> > Subject: Re: New port: Gaupol subtitle editor
> >
> > On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > > It supports multiple subtitle file formats and provides means of
> > > creating, editing and translating subtitles and timing subtitles to
> > > match video.
> > >
> > > This is my first port, so there might be things I missed. I have tried
> > > to follow the porting guide closely. Please have a look and comment.
> > >
> > > Thanks,
> > > Anindya
> >
> > I've reattached with some changes
> >
> > -py-* nomenclature is used for python modules not for standalone ports
> > like this, so I've removed it.
> > -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> > in this case.
> > -rearranged the dependencies in alpha order and added some missing
> > runtime depends.
> >
> > There are many tests available but most of those need xorg, access to which
> > _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> > if MODPY_PYTEST is of any use if the tests don't run on their own.
> >
> > Also I recommended you take maintainer since you're going to use it.
> >
> > regards,
> > Dimitri
>
>
gaupol.tar.gz
Description: application/tar-gz
Re: New port: Gaupol subtitle editor
Hi,
Thanks! I've fixed the comment.
Regards,
Anindya
From: Stuart Henderson
Sent: February 2, 2021 3:50 AM
To: Anindya Mukherjee
Cc: Dimitri Karamazov ; ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
start COMMENT with lower-case please (unless it's a proper noun,
but that doesn't apply here).
we are a bit busy fixing hundreds of ports for a forthcoming
clang update at the moment so it may take a while to get to it :)
On 2021/02/02 06:41, Anindya Mukherjee wrote:
> Attached tarball.
>
>
> From: Anindya Mukherjee
> Sent: February 1, 2021 10:31 PM
> To: Dimitri Karamazov
> Cc: ports@openbsd.org
> Subject: Re: New port: Gaupol subtitle editor
>
> Hi, just to recap:
>
> This package provides Gaupol, an editor for
> text-based subtitle files.
>
> Maintainer: Anindya Mukherjee
>
> Homepage: https://otsaloma.io/gaupol/
>
> Comments? OKs? I'm using it on my machine,
> installed from pkg.
>
> Thanks!
> Anindya
>
>
> From: Anindya Mukherjee
> Sent: January 29, 2021 7:18 PM
> To: Dimitri Karamazov
> Cc: ports@openbsd.org
> Subject: Re: New port: Gaupol subtitle editor
>
> Updated tarball attached. I have added myself as
> maintainer.
>
> Thanks,
> Anindya
>
>
> From: Anindya Mukherjee
> Sent: January 29, 2021 12:04 AM
> To: Dimitri Karamazov
> Cc: ports@openbsd.org
> Subject: Re: New port: Gaupol subtitle editor
>
> Hi,
>
> Many thanks for the comments and fixes. Sure, I can take
> maintainer. So, it looks like I only need to add maintainer
> to your version? Build and package looks ok and runs.
> Any other suggestions?
>
> Thanks,
> Anindya
>
> From: Dimitri Karamazov
> Sent: January 28, 2021 9:14 PM
> To: Anindya Mukherjee
> Cc: ports@openbsd.org
> Subject: Re: New port: Gaupol subtitle editor
>
> On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > It supports multiple subtitle file formats and provides means of
> > creating, editing and translating subtitles and timing subtitles to
> > match video.
> >
> > This is my first port, so there might be things I missed. I have tried
> > to follow the porting guide closely. Please have a look and comment.
> >
> > Thanks,
> > Anindya
>
> I've reattached with some changes
>
> -py-* nomenclature is used for python modules not for standalone ports
> like this, so I've removed it.
> -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
> in this case.
> -rearranged the dependencies in alpha order and added some missing
> runtime depends.
>
> There are many tests available but most of those need xorg, access to which
> _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> if MODPY_PYTEST is of any use if the tests don't run on their own.
>
> Also I recommended you take maintainer since you're going to use it.
>
> regards,
> Dimitri
gaupol.tar.gz
Description: gaupol.tar.gz
Re: New port: Gaupol subtitle editor
Attached tarball.
From: Anindya Mukherjee
Sent: February 1, 2021 10:31 PM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Hi, just to recap:
This package provides Gaupol, an editor for
text-based subtitle files.
Maintainer: Anindya Mukherjee
Homepage: https://otsaloma.io/gaupol/
Comments? OKs? I'm using it on my machine,
installed from pkg.
Thanks!
Anindya
From: Anindya Mukherjee
Sent: January 29, 2021 7:18 PM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Updated tarball attached. I have added myself as
maintainer.
Thanks,
Anindya
From: Anindya Mukherjee
Sent: January 29, 2021 12:04 AM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Hi,
Many thanks for the comments and fixes. Sure, I can take
maintainer. So, it looks like I only need to add maintainer
to your version? Build and package looks ok and runs.
Any other suggestions?
Thanks,
Anindya
From: Dimitri Karamazov
Sent: January 28, 2021 9:14 PM
To: Anindya Mukherjee
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> Hi, this is a port of gaupol, an editor for text-based subtitle files.
> It supports multiple subtitle file formats and provides means of
> creating, editing and translating subtitles and timing subtitles to
> match video.
>
> This is my first port, so there might be things I missed. I have tried
> to follow the porting guide closely. Please have a look and comment.
>
> Thanks,
> Anindya
I've reattached with some changes
-py-* nomenclature is used for python modules not for standalone ports
like this, so I've removed it.
-FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
in this case.
-rearranged the dependencies in alpha order and added some missing
runtime depends.
There are many tests available but most of those need xorg, access to which
_pbuild doesn't have? One can run them as a normal user though. I'm not sure
if MODPY_PYTEST is of any use if the tests don't run on their own.
Also I recommended you take maintainer since you're going to use it.
regards,
Dimitri
gaupol.tar.gz
Description: gaupol.tar.gz
Re: New port: Gaupol subtitle editor
Hi, just to recap:
This package provides Gaupol, an editor for
text-based subtitle files.
Maintainer: Anindya Mukherjee
Homepage: https://otsaloma.io/gaupol/
Comments? OKs? I'm using it on my machine,
installed from pkg.
Thanks!
Anindya
From: Anindya Mukherjee
Sent: January 29, 2021 7:18 PM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Updated tarball attached. I have added myself as
maintainer.
Thanks,
Anindya
From: Anindya Mukherjee
Sent: January 29, 2021 12:04 AM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Hi,
Many thanks for the comments and fixes. Sure, I can take
maintainer. So, it looks like I only need to add maintainer
to your version? Build and package looks ok and runs.
Any other suggestions?
Thanks,
Anindya
From: Dimitri Karamazov
Sent: January 28, 2021 9:14 PM
To: Anindya Mukherjee
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> Hi, this is a port of gaupol, an editor for text-based subtitle files.
> It supports multiple subtitle file formats and provides means of
> creating, editing and translating subtitles and timing subtitles to
> match video.
>
> This is my first port, so there might be things I missed. I have tried
> to follow the porting guide closely. Please have a look and comment.
>
> Thanks,
> Anindya
I've reattached with some changes
-py-* nomenclature is used for python modules not for standalone ports
like this, so I've removed it.
-FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
in this case.
-rearranged the dependencies in alpha order and added some missing
runtime depends.
There are many tests available but most of those need xorg, access to which
_pbuild doesn't have? One can run them as a normal user though. I'm not sure
if MODPY_PYTEST is of any use if the tests don't run on their own.
Also I recommended you take maintainer since you're going to use it.
regards,
Dimitri
Re: New port: Gaupol subtitle editor
Updated tarball attached. I have added myself as
maintainer.
Thanks,
Anindya
From: Anindya Mukherjee
Sent: January 29, 2021 12:04 AM
To: Dimitri Karamazov
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
Hi,
Many thanks for the comments and fixes. Sure, I can take
maintainer. So, it looks like I only need to add maintainer
to your version? Build and package looks ok and runs.
Any other suggestions?
Thanks,
Anindya
From: Dimitri Karamazov
Sent: January 28, 2021 9:14 PM
To: Anindya Mukherjee
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> Hi, this is a port of gaupol, an editor for text-based subtitle files.
> It supports multiple subtitle file formats and provides means of
> creating, editing and translating subtitles and timing subtitles to
> match video.
>
> This is my first port, so there might be things I missed. I have tried
> to follow the porting guide closely. Please have a look and comment.
>
> Thanks,
> Anindya
I've reattached with some changes
-py-* nomenclature is used for python modules not for standalone ports
like this, so I've removed it.
-FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
in this case.
-rearranged the dependencies in alpha order and added some missing
runtime depends.
There are many tests available but most of those need xorg, access to which
_pbuild doesn't have? One can run them as a normal user though. I'm not sure
if MODPY_PYTEST is of any use if the tests don't run on their own.
Also I recommended you take maintainer since you're going to use it.
regards,
Dimitri
gaupol.tar.gz
Description: gaupol.tar.gz
Re: New port: Gaupol subtitle editor
Hi,
Many thanks for the comments and fixes. Sure, I can take
maintainer. So, it looks like I only need to add maintainer
to your version? Build and package looks ok and runs.
Any other suggestions?
Thanks,
Anindya
From: Dimitri Karamazov
Sent: January 28, 2021 9:14 PM
To: Anindya Mukherjee
Cc: ports@openbsd.org
Subject: Re: New port: Gaupol subtitle editor
On Fri, Jan 29, 2021 at 04:28:50AM +, Dimitri Karamazov wrote:
> Hi, this is a port of gaupol, an editor for text-based subtitle files.
> It supports multiple subtitle file formats and provides means of
> creating, editing and translating subtitles and timing subtitles to
> match video.
>
> This is my first port, so there might be things I missed. I have tried
> to follow the porting guide closely. Please have a look and comment.
>
> Thanks,
> Anindya
I've reattached with some changes
-py-* nomenclature is used for python modules not for standalone ports
like this, so I've removed it.
-FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
in this case.
-rearranged the dependencies in alpha order and added some missing
runtime depends.
There are many tests available but most of those need xorg, access to which
_pbuild doesn't have? One can run them as a normal user though. I'm not sure
if MODPY_PYTEST is of any use if the tests don't run on their own.
Also I recommended you take maintainer since you're going to use it.
regards,
Dimitri
New port: Gaupol subtitle editor
Hi, this is a port of gaupol, an editor for text-based subtitle files. It supports multiple subtitle file formats and provides means of creating, editing and translating subtitles and timing subtitles to match video. This is my first port, so there might be things I missed. I have tried to follow the porting guide closely. Please have a look and comment. Thanks, Anindya multimedia-py-gaupol.tar.gz Description: multimedia-py-gaupol.tar.gz
Re: Gaupol subtitle editor
Thanks for the tips! Much appreciated. Anindya From: Dimitri Karamazov Sent: January 18, 2021 6:47 PM To: Anindya Mukherjee Cc: ports@openbsd.org Subject: Re: Gaupol subtitle editor On Tue, Jan 18, 2021 at 08:55:22PM +, Anindya Mukherjee wrote: > Hi, > > I use Gaupol to edit/sync subtitles on Linux, and would like to port it > to OpenBSD. As far as I can tell it is not currently being worked on > by anyone. Just wondering if there is any interest from other users. It's > really easy to use and would save me from having to reboot into Arch :) > > This would be my first port, so I'm looking forward to it as a learning > experience. Comments/suggestions welcome, thank you. > > Anindya I'm looking forward to it. Take a look at py-* ports your port will be similar. Consider reading through - https://www.openbsd.org/faq/ports/index.html as a start this will save you much trouble. bsd.port.mk(5) will explain most of the variables you will need and since this requires python for building skim through the port-modules(5) particularly the section for lang/python. regards, Dimitri
Gaupol subtitle editor
Hi, I use Gaupol to edit/sync subtitles on Linux, and would like to port it to OpenBSD. As far as I can tell it is not currently being worked on by anyone. Just wondering if there is any interest from other users. It's really easy to use and would save me from having to reboot into Arch :) This would be my first port, so I'm looking forward to it as a learning experience. Comments/suggestions welcome, thank you. Anindya
