Re: [NEW] devel/premake

[Jeremie Courreges-Anglas]

Adam Wolk  writes:

[...]


> WANTLIB is missing 'm' - with that change OK awolk@ to import
> tested against a local download of t-engine.

Thanks, committed.  I have also added Solène as maintainer per her
request.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: [NEW] devel/premake

[Adam Wolk]

On Fri, Dec 02, 2016 at 03:03:07PM +0100, Jeremie Courreges-Anglas wrote:
> Jeremie Courreges-Anglas  writes:
> 
> > Sol??ne Rapenne  writes:
> >
> >> Le 2016-12-01 16:38, Sol??ne Rapenne a ??crit??:
> >>> Le 2016-11-30 21:28, Jeremie Courreges-Anglas a ??crit??:
> 
>  Note that the build is silent which is bad.  Adding verbose=1 to
>  MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
>  there.  The link step shouldn't use -s since it makes DEBUG=-g 
>  useless.
> 
>  This seems to embed lua-5.1, using lua from ports could be nice - if
>  possible of course.
> 
>  Back to the purpose of the port, it would be nice to check whether the
>  generated Makefiles would be usable within the OpenBSD ports tree.
>  But
>  are you just looking for feedback or are you actually submitting it
>  for
>  inclusion?
> >>>
> >>> New version here
> >>>
> >>> I would like to submit it for inclusion in the ports tree because it's
> >>> a
> >>> dependency of another submission of mine (games/t-engine)
> >>
> >> New version :
> >>
> >> - removing -Os compilation flag
> >> - DOC link changed in DESCR
> >> - licence in Makefile
> >
> > Updated tarball that:
> > - renames the port directory to premake4
> > - fixes the offending tests: use ldconfig -r to find libraries available
> >   on the system.
> >
> > Patching a lua source file is a bit of a pain here since we have to
> > regenerate the C files that embed the lua source, hence the XXX comment.
> 
> I think that this is good for an import, it is needed for Solene's
> t-engine/tome port.  Could I please get reviews?
> 

WANTLIB is missing 'm' - with that change OK awolk@ to import
tested against a local download of t-engine.

Regards
Adam

Re: [NEW] devel/premake

[Jeremie Courreges-Anglas]

Jeremie Courreges-Anglas  writes:

> Solène Rapenne  writes:
>
>> Le 2016-12-01 16:38, Solène Rapenne a écrit :
>>> Le 2016-11-30 21:28, Jeremie Courreges-Anglas a écrit :

 Note that the build is silent which is bad.  Adding verbose=1 to
 MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
 there.  The link step shouldn't use -s since it makes DEBUG=-g 
 useless.

 This seems to embed lua-5.1, using lua from ports could be nice - if
 possible of course.

 Back to the purpose of the port, it would be nice to check whether the
 generated Makefiles would be usable within the OpenBSD ports tree.
 But
 are you just looking for feedback or are you actually submitting it
 for
 inclusion?
>>>
>>> New version here
>>>
>>> I would like to submit it for inclusion in the ports tree because it's
>>> a
>>> dependency of another submission of mine (games/t-engine)
>>
>> New version :
>>
>> - removing -Os compilation flag
>> - DOC link changed in DESCR
>> - licence in Makefile
>
> Updated tarball that:
> - renames the port directory to premake4
> - fixes the offending tests: use ldconfig -r to find libraries available
>   on the system.
>
> Patching a lua source file is a bit of a pain here since we have to
> regenerate the C files that embed the lua source, hence the XXX comment.

I think that this is good for an import, it is needed for Solene's
t-engine/tome port.  Could I please get reviews?

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: [NEW] devel/premake

[Jeremie Courreges-Anglas]

Solène Rapenne  writes:

> Le 2016-12-01 16:38, Solène Rapenne a écrit :
>> Le 2016-11-30 21:28, Jeremie Courreges-Anglas a écrit :
>>>
>>> Note that the build is silent which is bad.  Adding verbose=1 to
>>> MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
>>> there.  The link step shouldn't use -s since it makes DEBUG=-g 
>>> useless.
>>>
>>> This seems to embed lua-5.1, using lua from ports could be nice - if
>>> possible of course.
>>>
>>> Back to the purpose of the port, it would be nice to check whether the
>>> generated Makefiles would be usable within the OpenBSD ports tree.
>>> But
>>> are you just looking for feedback or are you actually submitting it
>>> for
>>> inclusion?
>>
>> New version here
>>
>> I would like to submit it for inclusion in the ports tree because it's
>> a
>> dependency of another submission of mine (games/t-engine)
>
> New version :
>
> - removing -Os compilation flag
> - DOC link changed in DESCR
> - licence in Makefile

Updated tarball that:
- renames the port directory to premake4
- fixes the offending tests: use ldconfig -r to find libraries available
  on the system.

Patching a lua source file is a bit of a pain here since we have to
regenerate the C files that embed the lua source, hence the XXX comment.



premake4.tgz
Description: Binary data
-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: [NEW] devel/premake

[Solène Rapenne]

Le 2016-12-01 16:38, Solène Rapenne a écrit :

Le 2016-11-30 21:28, Jeremie Courreges-Anglas a écrit :


Note that the build is silent which is bad.  Adding verbose=1 to
MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
there.  The link step shouldn't use -s since it makes DEBUG=-g 
useless.


This seems to embed lua-5.1, using lua from ports could be nice - if
possible of course.

Back to the purpose of the port, it would be nice to check whether the
generated Makefiles would be usable within the OpenBSD ports tree.  
But
are you just looking for feedback or are you actually submitting it 
for

inclusion?


New version here

I would like to submit it for inclusion in the ports tree because it's 
a

dependency of another submission of mine (games/t-engine)


New version :

- removing -Os compilation flag
- DOC link changed in DESCR
- licence in Makefile


premake.tar.gz
Description: GNU Zip compressed data

Re: [NEW] devel/premake

[Solène Rapenne]

Le 2016-11-30 21:28, Jeremie Courreges-Anglas a écrit :


Note that the build is silent which is bad.  Adding verbose=1 to
MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
there.  The link step shouldn't use -s since it makes DEBUG=-g useless.

This seems to embed lua-5.1, using lua from ports could be nice - if
possible of course.

Back to the purpose of the port, it would be nice to check whether the
generated Makefiles would be usable within the OpenBSD ports tree.  But
are you just looking for feedback or are you actually submitting it for
inclusion?


New version here

I would like to submit it for inclusion in the ports tree because it's a
dependency of another submission of mine (games/t-engine)

premake.tar.gz
Description: GNU Zip compressed data

Re: [NEW] devel/premake

[Adam Wolk]

On Wed, Nov 30, 2016 at 09:28:34PM +0100, Jeremie Courreges-Anglas wrote:
> Sol??ne Rapenne  writes:
> 
> > Hello,
> 
> Hi,
> 
> > I would like feedback about my port, it's a tool which generate
> > makefile.
> >
> It's a shame that there isn't any documentation in the tarball... that's
> not something you can fix of course, but adding a link to
> https://github.com/premake/premake-core/wiki in DESCR could be helpful.
> 
> BTW the content of DESCR is dubious, IMO.
> https://github.com/premake/premake-core/wiki/What-Is-Premake has
> a more neutral and informative description:
> 
> "Premake is a command line utility which reads a scripted definition of
> a software project and, most commonly, uses it to generate project files
> for toolsets like Visual Studio, Xcode, or GNU Make."
> 
> > .include 
> 
> Note that the build is silent which is bad.  Adding verbose=1 to
> MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
> there.  The link step shouldn't use -s since it makes DEBUG=-g useless.
> 
> This seems to embed lua-5.1, using lua from ports could be nice - if
> possible of course.
> 

I did a port of devel/premake4 some time ago
 https://marc.info/?l=openbsd-ports=147272474916111=2

this included a change to use our ports lua instead of the bundled one.

When I researched the premake stuff before they have a big jump in premake5
and by the nature of the software it's possible that some ports will stick to 
premake4
and some will move to premake5 hence I believe the major version should be in 
the
port name.

When I ported this initially I had games/tome4 in mind but was put off by the
amount of bundled libraries that game shipped.

Regards,
Adam

Re: [NEW] devel/premake

[Jeremie Courreges-Anglas]

Solène Rapenne  writes:

> Hello,

Hi,

> I would like feedback about my port, it's a tool which generate
> makefile.
>
> It's only one binary once compiled.

Comments below,

> # $OpenBSD$
> 
> COMMENT=  Premake is a build configuration tool

"build configuration tool" would be enough I think.  See what item 17 in
http://www.openbsd.org/faq/ports/guide.html says about COMMENT.

> V=4.4-beta5
> NAME= premake-${V}
> PKGNAME=  premake-${V:C/\-.*//}
> DISTNAME= ${NAME}-src

DISTNAME=   premake-4.4-beta5-src
PKGNAME=premake-4.4beta5

is more readable IMO.  "beta5" should be included in the version as per
packages-specs(7).

> 
> CATEGORIES=   devel
> 
> HOMEPAGE= https://premake.github.io
> 
> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=premake/}
> EXTRACT_SUFX= .zip
> 
> # 3-clause BSD

I think we settled on using just "BSD" for license markers.

> PERMIT_PACKAGE_CDROM= Yes
> WANTLIB=  c
> 
> NO_TEST=  Yes

But there is a tests/ directory.

> USE_GMAKE=Yes
> 
> WRKDIST=  ${WRKDIR}/${NAME}

Here you could just use

WRKDIST=${WRKDIR}/${DISTNAME:S/-src$//}

> WRKBUILD= ${WRKSRC}/build/gmake.unix
> 
> do-install:
>   ${INSTALL_PROGRAM} ${WRKSRC}/bin/release/premake4 ${PREFIX}/bin/premake

It's a shame that there isn't any documentation in the tarball... that's
not something you can fix of course, but adding a link to
https://github.com/premake/premake-core/wiki in DESCR could be helpful.

BTW the content of DESCR is dubious, IMO.
https://github.com/premake/premake-core/wiki/What-Is-Premake has
a more neutral and informative description:

"Premake is a command line utility which reads a scripted definition of
a software project and, most commonly, uses it to generate project files
for toolsets like Visual Studio, Xcode, or GNU Make."

> .include 

Note that the build is silent which is bad.  Adding verbose=1 to
MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be
there.  The link step shouldn't use -s since it makes DEBUG=-g useless.

This seems to embed lua-5.1, using lua from ports could be nice - if
possible of course.

Back to the purpose of the port, it would be nice to check whether the
generated Makefiles would be usable within the OpenBSD ports tree.  But
are you just looking for feedback or are you actually submitting it for
inclusion?

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

[NEW] devel/premake

[Solène Rapenne]

Hello,

I would like feedback about my port, it's a tool which generate 
makefile.


It's only one binary once compiled.

premake.tar.gz
Description: GNU Zip compressed data

Re: [NEW] devel/premake

[Pascal Schmid]

On 24/04/14 16:48, Brian Callahan wrote:
 
 Random bikeshedding:
 
 Why not use the lua on the system? Is the included lua somehow different?
 
 Something like:
 MAKE_FLAGS=INCLUDES=-I${MODLUA_INCL_DIR} LIB=-m -L${LOCALBASE}/lib
 ${MODLUA_LIB}
 would do the trick, remembering to add ${MODLUA_WANTLIB} to WANTLIB and
 MODULES=lang/lua.
 You'll have to patch ${WRKSRC}/Premake4.make to remove the building of
 its internal lua but it'll save you having to chase lua fixes in the
 future (Maybe you can even get upstream to support building with a
 system lua in future releases). Also lets you have fewer patches.
 
 Built with the system lua, make test passes all tests on amd64.
 
 ~Brian


Attached is the tweaked port. The devs response to using a
system-provided Lua version is:
Because there is no such thing as the one on the system.


premake.tgz
Description: application/compressed-tar

[NEW] devel/premake

[Pascal Schmid]

Hi ports,

premake is a build config tool.

Tested on amd64, i386 and macppc.

HOMEPAGE: http://industriousone.com/premake

- Pascal


premake.tar.gz
Description: application/tar-gz

Re: [NEW] devel/premake

[Brian Callahan]

On 04/24/14 06:23, Pascal Schmid wrote:

Hi ports,

premake is a build config tool.

Tested on amd64, i386 and macppc.

HOMEPAGE: http://industriousone.com/premake

- Pascal


Random bikeshedding:

Why not use the lua on the system? Is the included lua somehow different?

Something like:
MAKE_FLAGS=INCLUDES=-I${MODLUA_INCL_DIR} LIB=-m -L${LOCALBASE}/lib 
${MODLUA_LIB}
would do the trick, remembering to add ${MODLUA_WANTLIB} to WANTLIB and 
MODULES=lang/lua.
You'll have to patch ${WRKSRC}/Premake4.make to remove the building of 
its internal lua but it'll save you having to chase lua fixes in the 
future (Maybe you can even get upstream to support building with a 
system lua in future releases). Also lets you have fewer patches.


Built with the system lua, make test passes all tests on amd64.

~Brian