Re: [NEW] net/onionshare

[Grégoire Jadi]

Klemens Nanni  writes:

> On Tue, Apr 10, 2018 at 08:09:15AM +0200, Grégoire Jadi wrote:
>
>> Stuart Henderson  writes:
>> 
>> > On 2018/03/09 13:56, Grégoire Jadi wrote:
>> >
>> >> 
>> >> ping
>> >> 
>> >> I don't know what are the next steps. :)
>> >> Should I add the MAINTAINER to the loop?
>> >> 
>> >> Best,
>> >> 
>> >
>> > The do-test/TEST_DEPENDS bits aren't doing anything useful (not working,
>> > and hidden by NO_TEST anyway), so I think we should just zap those for now
>> > as I've done in the updated attached port.
>> >
>> > Otherwise looks good to me.  OK sthen@ if someone would like to import it..
>> 
>> ping, anyone to import this?
> I imported it on 09.03.2018.

Oh, my bad then. I didn't notice.

Thanks a lot!

Re: [NEW] net/onionshare

[Klemens Nanni]

On Tue, Apr 10, 2018 at 08:09:15AM +0200, Grégoire Jadi wrote:
> Stuart Henderson  writes:
> 
> > On 2018/03/09 13:56, Grégoire Jadi wrote:
> >
> >> 
> >> ping
> >> 
> >> I don't know what are the next steps. :)
> >> Should I add the MAINTAINER to the loop?
> >> 
> >> Best,
> >> 
> >
> > The do-test/TEST_DEPENDS bits aren't doing anything useful (not working,
> > and hidden by NO_TEST anyway), so I think we should just zap those for now
> > as I've done in the updated attached port.
> >
> > Otherwise looks good to me.  OK sthen@ if someone would like to import it..
> 
> ping, anyone to import this?
I imported it on 09.03.2018.

Re: [NEW] net/onionshare

[Grégoire Jadi]

Stuart Henderson  writes:

> On 2018/03/09 13:56, Grégoire Jadi wrote:
>
>> 
>> ping
>> 
>> I don't know what are the next steps. :)
>> Should I add the MAINTAINER to the loop?
>> 
>> Best,
>> 
>
> The do-test/TEST_DEPENDS bits aren't doing anything useful (not working,
> and hidden by NO_TEST anyway), so I think we should just zap those for now
> as I've done in the updated attached port.
>
> Otherwise looks good to me.  OK sthen@ if someone would like to import it..

ping, anyone to import this?

Best,

Re: [NEW] net/onionshare

[Grégoire Jadi]

Stuart Henderson  writes:

> On 2018/03/09 13:56, Grégoire Jadi wrote:
>
>> 
>> ping
>> 
>> I don't know what are the next steps. :)
>> Should I add the MAINTAINER to the loop?
>> 
>> Best,
>> 
>
> The do-test/TEST_DEPENDS bits aren't doing anything useful (not working,
> and hidden by NO_TEST anyway), so I think we should just zap those for now
> as I've done in the updated attached port.

Ok. I've tried the tests suite included in onionshare and 57 out of the
59 tests fail. So I think it's ok to skip those.

Thanks for your work.

> Otherwise looks good to me.  OK sthen@ if someone would like to import it..

Re: [NEW] net/onionshare

[Stuart Henderson]

On 2018/03/09 13:56, Grégoire Jadi wrote:
> 
> ping
> 
> I don't know what are the next steps. :)
> Should I add the MAINTAINER to the loop?
> 
> Best,
> 

The do-test/TEST_DEPENDS bits aren't doing anything useful (not working,
and hidden by NO_TEST anyway), so I think we should just zap those for now
as I've done in the updated attached port.

Otherwise looks good to me.  OK sthen@ if someone would like to import it..




onionshare.tgz
Description: application/tar-gz

Re: [NEW] net/onionshare

[Grégoire Jadi]

Grégoire Jadi  writes:

> Stuart Henderson  writes:
>
>> On 2018/03/01 21:06, Grégoire Jadi wrote:
>>
>>> Grégoire Jadi  writes:
>>> 
>>> > Stuart Henderson  writes:
>>> >
>>> >> On 2018/03/01 17:36, Grégoire Jadi wrote:
>>> >>
>>> >>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
>>> >>> includes the wrong stuff in for both SUBPACKAGE. -main had
>>> >>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
>>> >>
>>> >> That was better before, you have duplicates between the two
>>> >> subpackages now.
>>> >
>>> > Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
>>> > check the doc again.
>>> >
>>> >>> One caveat (that I know of, there is probably more :p): I hardcoded the
>>> >>> name of the package in PLIST-main and PLIST-gui and used only the
>>> >>> version to locate the .egg-info file.
>>> >>> 
>>> >>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>>> >>>  ^
>>> >>
>>> >> Standard is to put the version number in MODPY_EGG_VERSION.
>>> >
>>> > Ok, I'll look at this.
>>> >
>>> > Thanks for the feedbacks.
>>> 
>>> And here is another version in which I moved all the onionshare-gui/
>>> stuff from PLIST-main to PLIST-gui. I've tested both versions. Which one
>>> is prefered?
>>
>> So that looks more like attila's which is a good thing. You lost the
>> update-desktop-database lines which should be present at the bottom of
>> the plist though.
>>
>> @exec %D/bin/update-desktop-database
>> @unexec-delete %D/bin/update-desktop-database
>>
>> Bit of a mixture of " \" and " \" continuation
>> lines in the DEPENDS sections, stick to one of the other.
>>
>> "MODPY_SETUPTOOLS = No" is the default so that line can be removed.
>>
>> It would be simpler to change
>>
>> GH_TAGNAME =v1.3
>> MODPY_EGG_VERSION = ${GH_TAGNAME:C/^v//}
>>
>> to
>>
>> GH_TAGNAME =v${MODPY_EGG_VERSION}
>> MODPY_EGG_VERSION = 1.3
>
> Let's try again...
> Thanks a lot for the feedbacks and for your time.

ping

I don't know what are the next steps. :)
Should I add the MAINTAINER to the loop?

Best,

Re: [NEW] net/onionshare

[Grégoire Jadi]

Stuart Henderson  writes:

> On 2018/03/01 21:06, Grégoire Jadi wrote:
>
>> Grégoire Jadi  writes:
>> 
>> > Stuart Henderson  writes:
>> >
>> >> On 2018/03/01 17:36, Grégoire Jadi wrote:
>> >>
>> >>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
>> >>> includes the wrong stuff in for both SUBPACKAGE. -main had
>> >>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
>> >>
>> >> That was better before, you have duplicates between the two
>> >> subpackages now.
>> >
>> > Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
>> > check the doc again.
>> >
>> >>> One caveat (that I know of, there is probably more :p): I hardcoded the
>> >>> name of the package in PLIST-main and PLIST-gui and used only the
>> >>> version to locate the .egg-info file.
>> >>> 
>> >>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>> >>>  ^
>> >>
>> >> Standard is to put the version number in MODPY_EGG_VERSION.
>> >
>> > Ok, I'll look at this.
>> >
>> > Thanks for the feedbacks.
>> 
>> And here is another version in which I moved all the onionshare-gui/
>> stuff from PLIST-main to PLIST-gui. I've tested both versions. Which one
>> is prefered?
>
> So that looks more like attila's which is a good thing. You lost the
> update-desktop-database lines which should be present at the bottom of
> the plist though.
>
> @exec %D/bin/update-desktop-database
> @unexec-delete %D/bin/update-desktop-database
>
> Bit of a mixture of " \" and " \" continuation
> lines in the DEPENDS sections, stick to one of the other.
>
> "MODPY_SETUPTOOLS = No" is the default so that line can be removed.
>
> It would be simpler to change
>
> GH_TAGNAME =v1.3
> MODPY_EGG_VERSION = ${GH_TAGNAME:C/^v//}
>
> to
>
> GH_TAGNAME =v${MODPY_EGG_VERSION}
> MODPY_EGG_VERSION = 1.3

Let's try again...
Thanks a lot for the feedbacks and for your time.



onionshare-1.3-4.tgz
Description: Binary data

Re: [NEW] net/onionshare

[Stuart Henderson]

On 2018/03/01 21:06, Grégoire Jadi wrote:
> Grégoire Jadi  writes:
> 
> > Stuart Henderson  writes:
> >
> >> On 2018/03/01 17:36, Grégoire Jadi wrote:
> >>
> >>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
> >>> includes the wrong stuff in for both SUBPACKAGE. -main had
> >>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
> >>
> >> That was better before, you have duplicates between the two
> >> subpackages now.
> >
> > Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
> > check the doc again.
> >
> >>> One caveat (that I know of, there is probably more :p): I hardcoded the
> >>> name of the package in PLIST-main and PLIST-gui and used only the
> >>> version to locate the .egg-info file.
> >>> 
> >>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
> >>>  ^
> >>
> >> Standard is to put the version number in MODPY_EGG_VERSION.
> >
> > Ok, I'll look at this.
> >
> > Thanks for the feedbacks.
> 
> And here is another version in which I moved all the onionshare-gui/
> stuff from PLIST-main to PLIST-gui. I've tested both versions. Which one
> is prefered?

So that looks more like attila's which is a good thing. You lost the
update-desktop-database lines which should be present at the bottom of
the plist though.

@exec %D/bin/update-desktop-database
@unexec-delete %D/bin/update-desktop-database

Bit of a mixture of " \" and " \" continuation
lines in the DEPENDS sections, stick to one of the other.

"MODPY_SETUPTOOLS = No" is the default so that line can be removed.

It would be simpler to change

GH_TAGNAME =v1.3
MODPY_EGG_VERSION = ${GH_TAGNAME:C/^v//}

to

GH_TAGNAME =v${MODPY_EGG_VERSION}
MODPY_EGG_VERSION = 1.3

Re: [NEW] net/onionshare

[Grégoire Jadi]

Grégoire Jadi  writes:

> Stuart Henderson  writes:
>
>> On 2018/03/01 17:36, Grégoire Jadi wrote:
>>
>>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
>>> includes the wrong stuff in for both SUBPACKAGE. -main had
>>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
>>
>> That was better before, you have duplicates between the two
>> subpackages now.
>
> Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
> check the doc again.
>
>>> One caveat (that I know of, there is probably more :p): I hardcoded the
>>> name of the package in PLIST-main and PLIST-gui and used only the
>>> version to locate the .egg-info file.
>>> 
>>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>>>  ^
>>
>> Standard is to put the version number in MODPY_EGG_VERSION.
>
> Ok, I'll look at this.
>
> Thanks for the feedbacks.

And here is another version in which I moved all the onionshare-gui/
stuff from PLIST-main to PLIST-gui. I've tested both versions. Which one
is prefered?



onionshare-1.3-3.tgz
Description: Binary data

Re: [NEW] net/onionshare

[Grégoire Jadi]

Grégoire Jadi  writes:

> Stuart Henderson  writes:
>
>> On 2018/03/01 17:36, Grégoire Jadi wrote:
>>
>>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
>>> includes the wrong stuff in for both SUBPACKAGE. -main had
>>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
>>
>> That was better before, you have duplicates between the two
>> subpackages now.
>
> Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
> check the doc again.
>
>>> One caveat (that I know of, there is probably more :p): I hardcoded the
>>> name of the package in PLIST-main and PLIST-gui and used only the
>>> version to locate the .egg-info file.
>>> 
>>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>>>  ^
>>
>> Standard is to put the version number in MODPY_EGG_VERSION.
>
> Ok, I'll look at this.
>
> Thanks for the feedbacks.

Here is a new try at this.

For this version, I used "make update-plist" and only changed the path
to the .egg-info file.



onionshare-1.3-2.tgz
Description: Binary data

Re: [NEW] net/onionshare

[Grégoire Jadi]

Stuart Henderson  writes:

> On 2018/03/01 17:36, Grégoire Jadi wrote:
>
>> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
>> includes the wrong stuff in for both SUBPACKAGE. -main had
>> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.
>
> That was better before, you have duplicates between the two
> subpackages now.

Ok. I guess I don't understand how PLIST works with MULTI_PACKAGES. I'll
check the doc again.

>> One caveat (that I know of, there is probably more :p): I hardcoded the
>> name of the package in PLIST-main and PLIST-gui and used only the
>> version to locate the .egg-info file.
>> 
>> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>>  ^
>
> Standard is to put the version number in MODPY_EGG_VERSION.

Ok, I'll look at this.

Thanks for the feedbacks.

Re: [NEW] net/onionshare

[Stuart Henderson]

On 2018/03/01 17:36, Grégoire Jadi wrote:
> I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
> includes the wrong stuff in for both SUBPACKAGE. -main had
> onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.

That was better before, you have duplicates between the two
subpackages now.

> One caveat (that I know of, there is probably more :p): I hardcoded the
> name of the package in PLIST-main and PLIST-gui and used only the
> version to locate the .egg-info file.
> 
> lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
>  ^

Standard is to put the version number in MODPY_EGG_VERSION.

Re: [NEW] net/onionshare

[Grégoire Jadi]

attila  writes:

>> attila wrote:
>> > Klemens Nanni wrote:
>> > > On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
>> > > > Klemens Nanni  wrote:
>> > > > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
>> > > > > beneath COMMENT; see infrastructure/templates/Makefile.template.
>> > > > >
>> > > > > RUN_DEPENDS lacks net/tor.
>> > > > > onionshare-gui still starts but python will dump core when
>> > > > > /usr/local/bin/tor is missing. It also mentions our net/tor package 
>> > > > > as
>> > > > > "Tor that is bundled with OpenShare" which is misleading.
>> > > > >
>> > > > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
>> > > >
>> > > > Attached is an updated port that addresses all of these comments.
>> > > > Thanks a lot for the feedback!
>> > > Looks good to me except for the bundle bits. Optimally this should be
>> > > clarified upstream.
>> > 
>> > There has been a new release in the interim and my patches for the old
>> > release were discussed a bit on GH.  Attached is a new attempt that is
>> > for the latest release (1.2) and that takes into account some of the
>> > suggestions from other contributors.
>> 
>> After I sent this I modified my patches slightly to accomodate another
>> suggestion by upstream and the pull request has now been merged, so
>> all these patches can go in the next update:
>> https://github.com/micahflee/onionshare/pull/585
>> 
>> This is also in FreeBSD ports now (thanks to fellow torbsd.org member
>> Egypcio):
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225539
>> 
>> > I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
>> > have not had time to investigate, thus NO_TEST=Yes.  I'd like this to
>> > be critiqued regardless, I don't see this as fatal to getting in if it
>> > passes muster otherwise...
>> 
>> Still have not had time to suss this out.
>> 
>> Updated port attached with the actual patches that got upstream.
>
> Ping.

Hello,

I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
includes the wrong stuff in for both SUBPACKAGE. -main had
onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.

Here is a port of the v1.3 with SUBPACKAGE -main and -gui. The v1.3
includes your patches merged by upstream.

One caveat (that I know of, there is probably more :p): I hardcoded the
name of the package in PLIST-main and PLIST-gui and used only the
version to locate the .egg-info file.

lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
 ^

If there is a better way to handle this, I'd by happy to fix it.

WDYT?

Best,



onionshare-1.3-1.tgz
Description: Binary data


> Pax, -A
> --
> https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
> pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF

Re: [NEW] net/onionshare

[attila]

> attila wrote:
> > Klemens Nanni wrote:
> > > On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> > > > Klemens Nanni  wrote:
> > > > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > > > > beneath COMMENT; see infrastructure/templates/Makefile.template.
> > > > >
> > > > > RUN_DEPENDS lacks net/tor.
> > > > > onionshare-gui still starts but python will dump core when
> > > > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > > > > "Tor that is bundled with OpenShare" which is misleading.
> > > > >
> > > > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> > > >
> > > > Attached is an updated port that addresses all of these comments.
> > > > Thanks a lot for the feedback!
> > > Looks good to me except for the bundle bits. Optimally this should be
> > > clarified upstream.
> > 
> > There has been a new release in the interim and my patches for the old
> > release were discussed a bit on GH.  Attached is a new attempt that is
> > for the latest release (1.2) and that takes into account some of the
> > suggestions from other contributors.
> 
> After I sent this I modified my patches slightly to accomodate another
> suggestion by upstream and the pull request has now been merged, so
> all these patches can go in the next update:
> https://github.com/micahflee/onionshare/pull/585
> 
> This is also in FreeBSD ports now (thanks to fellow torbsd.org member
> Egypcio):
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225539
> 
> > I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
> > have not had time to investigate, thus NO_TEST=Yes.  I'd like this to
> > be critiqued regardless, I don't see this as fatal to getting in if it
> > passes muster otherwise...
> 
> Still have not had time to suss this out.
> 
> Updated port attached with the actual patches that got upstream.

Ping.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF

Re: [NEW] net/onionshare

[attila]

attila wrote:
> Klemens Nanni wrote:
> > On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> > > Klemens Nanni  wrote:
> > > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > > > beneath COMMENT; see infrastructure/templates/Makefile.template.
> > > >
> > > > RUN_DEPENDS lacks net/tor.
> > > > onionshare-gui still starts but python will dump core when
> > > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > > > "Tor that is bundled with OpenShare" which is misleading.
> > > >
> > > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> > >
> > > Attached is an updated port that addresses all of these comments.
> > > Thanks a lot for the feedback!
> > Looks good to me except for the bundle bits. Optimally this should be
> > clarified upstream.
> 
> There has been a new release in the interim and my patches for the old
> release were discussed a bit on GH.  Attached is a new attempt that is
> for the latest release (1.2) and that takes into account some of the
> suggestions from other contributors.

After I sent this I modified my patches slightly to accomodate another
suggestion by upstream and the pull request has now been merged, so
all these patches can go in the next update:
https://github.com/micahflee/onionshare/pull/585

This is also in FreeBSD ports now (thanks to fellow torbsd.org member
Egypcio):
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225539

> I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
> have not had time to investigate, thus NO_TEST=Yes.  I'd like this to
> be critiqued regardless, I don't see this as fatal to getting in if it
> passes muster otherwise...

Still have not had time to suss this out.

Updated port attached with the actual patches that got upstream.

> Feedback welcome.
> 
> Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare-1.2-3.tgz
Description: Binary data

Re: [NEW] net/onionshare

[attila]

Klemens Nanni wrote:
> On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> > Klemens Nanni  wrote:
> > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > > beneath COMMENT; see infrastructure/templates/Makefile.template.
> > >
> > > RUN_DEPENDS lacks net/tor.
> > > onionshare-gui still starts but python will dump core when
> > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > > "Tor that is bundled with OpenShare" which is misleading.
> > >
> > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> >
> > Attached is an updated port that addresses all of these comments.
> > Thanks a lot for the feedback!
> Looks good to me except for the bundle bits. Optimally this should be
> clarified upstream.

There has been a new release in the interim and my patches for the old
release were discussed a bit on GH.  Attached is a new attempt that is
for the latest release (1.2) and that takes into account some of the
suggestions from other contributors.

I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
have not had time to investigate, thus NO_TEST=Yes.  I'd like this to
be critiqued regardless, I don't see this as fatal to getting in if it
passes muster otherwise...

Feedback welcome.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare-1.2-2.tgz
Description: Binary data

Re: [NEW] net/onionshare

[attila]

Klemens Nanni  wrote:
> On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> > Klemens Nanni  wrote:
> > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > > beneath COMMENT; see infrastructure/templates/Makefile.template.
> > >
> > > RUN_DEPENDS lacks net/tor.
> > > onionshare-gui still starts but python will dump core when
> > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > > "Tor that is bundled with OpenShare" which is misleading.
> > > 
> > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> > 
> > Attached is an updated port that addresses all of these comments.
> > Thanks a lot for the feedback!
> Looks good to me except for the bundle bits. Optimally this should be
> clarified upstream.

Attached is an updated attempt that uses MULTI_PACKAGES, as you
suggested in another post.  I still have not figured out how to deal
with the "bundled" thing, sorry, will look at it next.

Pax, -A
-- 
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare-4.tgz
Description: Binary data

Re: [NEW] net/onionshare

[Klemens Nanni]

On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> Klemens Nanni  wrote:
> > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > beneath COMMENT; see infrastructure/templates/Makefile.template.
> >
> > RUN_DEPENDS lacks net/tor.
> > onionshare-gui still starts but python will dump core when
> > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > "Tor that is bundled with OpenShare" which is misleading.
> > 
> > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> 
> Attached is an updated port that addresses all of these comments.
> Thanks a lot for the feedback!
Looks good to me except for the bundle bits. Optimally this should be
clarified upstream.

Re: [NEW] net/onionshare

[attila]

Klemens Nanni  wrote:
> You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> beneath COMMENT; see infrastructure/templates/Makefile.template.
>
> RUN_DEPENDS lacks net/tor.
> onionshare-gui still starts but python will dump core when
> /usr/local/bin/tor is missing. It also mentions our net/tor package as
> "Tor that is bundled with OpenShare" which is misleading.
> 
> TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.

Attached is an updated port that addresses all of these comments.
Thanks a lot for the feedback!

> Otherwise at least the CLI version works for me. It would be nice imho
> to split CLI and GUI into separate FLAVORS if possible.

As sthen@ points out in a subsequent email, it seems like this should
be multi-packages and not flavors, but in any event I didn't have time
to address it.  Posting what I have in the hope that it is good enough
to go in and we can improve it later...

Pax, -A
-- 
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare-3.tgz
Description: Binary data

Re: [NEW] net/onionshare

[attila]

Jiri B  wrote:
> OMG, again these...
> 
> -if not gui_mode or common.get_platform() == 'Linux':
> +if not gui_mode or common.platform_is_unixy():

Yup, it is sometimes an uphill battle to get people with a Lin/Win/Mac
mindset to go beyond that, but engaging with them is better than not
IMHO.

> Is this piece of sw really good enough to be trusted by people who really
> depend on anonymity and bad quality of such sw could cause them serious
> personal consequences?

Onionshare is a much-used application in the PETs community, I suspect
because it is simple.  It is the simplest thing that a normal person
can do to make use of Tor: share a file.  It's included in TAILs and
is well-known.  I'd like it to be available under OpenBSD.

> Why are those diffs not pushed upstream?

Thanks for the nudge: https://github.com/micahflee/onionshare/pull/489

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF

Re: [NEW] net/onionshare

[Stuart Henderson]

On 2017/12/07 01:40, Klemens Nanni wrote:
> Otherwise at least the CLI version works for me. It would be nice imho
> to split CLI and GUI into separate FLAVORS if possible.

this would be multipackages rather than flavours.

Re: [NEW] net/onionshare

[Jiri B]

> > Attached is a port OnionShare (https://onionshare.org).  It requires
> > the net/stem python3 flavor patch I posted earlier.  Both GUI and CLI
> > have been lightly tested.
> > 
> > $ cat pkg/DESCR
> > Tool for sharing files of any size anonymously over the Tor public
> > anonymity network.
> > 
> > It works by starting a web server, making it accessible as a Tor onion
> > service, and generating an unguessable URL to access and download the
> > files. It doesn't require setting up a server on the internet somewhere
> > or using a third party file-sharing service. The file on your own
> > computer and use a Tor onion service to make it temporarily accessible
> > over the internet. The other user just needs to use Tor Browser to
> > download the file from you.
> 
> Ping w/updated port attached that depends on the newly renamed
> net/py-stem3.

OMG, again these...

-if not gui_mode or common.get_platform() == 'Linux':
+if not gui_mode or common.platform_is_unixy():

Is this piece of sw really good enough to be trusted by people who really
depend on anonymity and bad quality of such sw could cause them serious
personal consequences?

Why are those diffs not pushed upstream?

j.

Re: [NEW] net/onionshare

[Klemens Nanni]

On Wed, Dec 06, 2017 at 05:26:32PM -0600, attila wrote:
> > $ cat pkg/DESCR
> > Tool for sharing files of any size anonymously over the Tor public
> > anonymity network.
> > 
> > It works by starting a web server, making it accessible as a Tor onion
> > service, and generating an unguessable URL to access and download the
> > files. It doesn't require setting up a server on the internet somewhere
> > or using a third party file-sharing service. The file on your own
> > computer and use a Tor onion service to make it temporarily accessible
> > over the internet. The other user just needs to use Tor Browser to
This is not a proper sentence.
> > download the file from you.
> 
> Ping w/updated port attached that depends on the newly renamed
> net/py-stem3.

You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
beneath COMMENT; see infrastructure/templates/Makefile.template.

RUN_DEPENDS lacks net/tor.
onionshare-gui still starts but python will dump core when
/usr/local/bin/tor is missing. It also mentions our net/tor package as
"Tor that is bundled with OpenShare" which is misleading.

TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.

Otherwise at least the CLI version works for me. It would be nice imho
to split CLI and GUI into separate FLAVORS if possible.

Re: [NEW] net/onionshare

[attila]

attila  wrote:
> Hi ports@,

Rehi ports@,

> 
> Attached is a port OnionShare (https://onionshare.org).  It requires
> the net/stem python3 flavor patch I posted earlier.  Both GUI and CLI
> have been lightly tested.
> 
> $ cat pkg/DESCR
> Tool for sharing files of any size anonymously over the Tor public
> anonymity network.
> 
> It works by starting a web server, making it accessible as a Tor onion
> service, and generating an unguessable URL to access and download the
> files. It doesn't require setting up a server on the internet somewhere
> or using a third party file-sharing service. The file on your own
> computer and use a Tor onion service to make it temporarily accessible
> over the internet. The other user just needs to use Tor Browser to
> download the file from you.

Ping w/updated port attached that depends on the newly renamed
net/py-stem3.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare-2.tgz
Description: Binary data

[NEW] net/onionshare

[attila]

Hi ports@,

Attached is a port OnionShare (https://onionshare.org).  It requires
the net/stem python3 flavor patch I posted earlier.  Both GUI and CLI
have been lightly tested.

$ cat pkg/DESCR
Tool for sharing files of any size anonymously over the Tor public
anonymity network.

It works by starting a web server, making it accessible as a Tor onion
service, and generating an unguessable URL to access and download the
files. It doesn't require setting up a server on the internet somewhere
or using a third party file-sharing service. The file on your own
computer and use a Tor onion service to make it temporarily accessible
over the internet. The other user just needs to use Tor Browser to
download the file from you.



Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF



onionshare.tgz
Description: port of onionshare