Ping: Re: [New] sysutils/glances (Python)
Ping on this one.
Reviewer agreed version attached. Thanks.
glances.tgz
Description: Binary data
Ashton Fagg writes:
> Stuart Henderson writes:
>
>> OpenBSD uses ${SYSCONFDIR} (typically /etc) not /usr/local/etc for
>> config files, and they should be installed using @sample in PLIST so
>> that local edits don't break updates.
>>
>> The web interface (glances -w) requires py3-bottle, it's a small enough
>> dep so I think might as well just list in RUN_DEPENDS rather than write
>> a note in DESCR or a pkg-readme that people will ignore anyway.
>>
>> I also fixed whitespace nits (mix of "=" and " =") and put RUN_DEPENDS
>> in alpha order.
>>
>> It does do something odd with the naming of tmux processes though,
>> just shows them as "default)", not a show stopper for important but might
>> be worth poking at.
>>
>> This version is OK with me if someone wants to commit it..
>
> Thanks for the review, Stuart. I'll take a look at what's going on with
> the tmux processes.
>
> (also interest bump since I'm a few days late on replying - Stuart's
> fixed version attached)
Re: [New] sysutils/glances (Python)
Stuart Henderson writes:
> OpenBSD uses ${SYSCONFDIR} (typically /etc) not /usr/local/etc for
> config files, and they should be installed using @sample in PLIST so
> that local edits don't break updates.
>
> The web interface (glances -w) requires py3-bottle, it's a small enough
> dep so I think might as well just list in RUN_DEPENDS rather than write
> a note in DESCR or a pkg-readme that people will ignore anyway.
>
> I also fixed whitespace nits (mix of "=" and " =") and put RUN_DEPENDS
> in alpha order.
>
> It does do something odd with the naming of tmux processes though,
> just shows them as "default)", not a show stopper for important but might
> be worth poking at.
>
> This version is OK with me if someone wants to commit it..
Thanks for the review, Stuart. I'll take a look at what's going on with
the tmux processes.
(also interest bump since I'm a few days late on replying - Stuart's
fixed version attached)
glances.tgz
Description: Binary data
Re: [New] sysutils/glances (Python)
On 2020/11/13 13:34, Ashton Fagg wrote:
> "Dimitri Karamazov" writes:
>
> > I think this link is more fitting as a HOMEPAGE.
>
> Fixed.
>
> > Including the configuration will be better.
> >
> > This program doesn't pick up on the terminal background colors, the
> > conf file might help with it,
>
> Fixed.
>
> > only nitpick after having a few glances, hehe ;-)
>
> Heyo!
>
> Updated tarball attached. Thanks for the review.
>
OpenBSD uses ${SYSCONFDIR} (typically /etc) not /usr/local/etc for
config files, and they should be installed using @sample in PLIST so
that local edits don't break updates.
The web interface (glances -w) requires py3-bottle, it's a small enough
dep so I think might as well just list in RUN_DEPENDS rather than write
a note in DESCR or a pkg-readme that people will ignore anyway.
I also fixed whitespace nits (mix of "=" and " =") and put RUN_DEPENDS
in alpha order.
It does do something odd with the naming of tmux processes though,
just shows them as "default)", not a show stopper for important but might
be worth poking at.
This version is OK with me if someone wants to commit it..
glances.tgz
Description: application/tar-gz
Re: [New] sysutils/glances (Python)
"Dimitri Karamazov" writes: > I think this link is more fitting as a HOMEPAGE. Fixed. > Including the configuration will be better. > > This program doesn't pick up on the terminal background colors, the > conf file might help with it, Fixed. > only nitpick after having a few glances, hehe ;-) Heyo! Updated tarball attached. Thanks for the review. glances.tgz Description: Binary data
Re: [New] sysutils/glances (Python)
On Fri, November 13, 2020 05:03, Ashton Fagg wrote:
> Hello,
>
>
> I have a new port attached for Glances [1].
>
>
> It's a system monitoring tool (similar to top, htop etc), written in
> Python. It has built-in support for monitoring a remote system, nice web
> GUI etc. It does a bunch of other things beyond just what top/htop does
> - it also monitors network activity, disk I/O, temperature sensors and a
> couple other things (some of this is Linux only right now...).
>
> The attached port has been tested on amd64, and a patch included to make
> sure the man pages get put in the right place.
>
> make configure, make build, make test, make fake, make install, make
> deinstall all work. portcheck reports clean.
> Appears to function as
> expected.
>
> Question, comments, suggestions appreciated.
>
>
> Thanks,
>
>
> Ash
>
>
> [1] https://nicolargo.github.io/glances/
I think this link is more fitting as a HOMEPAGE.
>
>
>-('share/doc/glances', ['AUTHORS', 'COPYING', 'NEWS.rst', 'README.rst',
>- 'CONTRIBUTING.md', 'conf/glances.conf']),
Including the configuration will be better.
This program doesn't pick up on the terminal background colors, the conf file
might help with it, only nitpick after having a few glances, hehe ;-)
