Re: style rule: space around variables
On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix updates with spacing, and a simple update diff quickly becomes really long and harder to read. So I suggest we don't intermix this too much. I cannot agree more. Stop the madness please. Absolutely. I would suggest also that we don't do this port by port. If we have to do this I think the usual method of changing a category at a time is the only sane way, we really don't want hundreds of space conversion diffs for individual ports cluttering po...@. Also suggestions welcome for how to make the PERMIT_* variables not look totally awful.
Re: style rule: space around variables
On Wed, 3 Nov 2010, Stuart Henderson wrote: On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix updates with spacing, and a simple update diff quickly becomes really long and harder to read. So I suggest we don't intermix this too much. I cannot agree more. Stop the madness please. Absolutely. I would suggest also that we don't do this port by port. If we have to do this I think the usual method of changing a category at a time is the only sane way, we really don't want hundreds of space conversion diffs for individual ports cluttering po...@. I think it should be up to the people maintaining the port. This space thing is just unreadable to me. As right as it may be, it looks just wrong to my eyes and makes thel bleed... Also suggestions welcome for how to make the PERMIT_* variables not look totally awful. Oh yeah... -- Antoine
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 09:43:17AM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Stuart Henderson wrote: On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix updates with spacing, and a simple update diff quickly becomes really long and harder to read. So I suggest we don't intermix this too much. I cannot agree more. Stop the madness please. Absolutely. I would suggest also that we don't do this port by port. If we have to do this I think the usual method of changing a category at a time is the only sane way, we really don't want hundreds of space conversion diffs for individual ports cluttering po...@. I think it should be up to the people maintaining the port. This space thing is just unreadable to me. As right as it may be, it looks just wrong to my eyes and makes thel bleed... Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. If I do change your ports, I will add spaces.
Re: style rule: space around variables
On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. If I do change your ports, I will add spaces. Sure, while at it take maintainership. -- Antoine
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. -- Cheers, Jasper Stay Hungry. Stay Foolish.
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. FWIW, I like the spaces around '='. f.-
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. So, speaking of eye cancer, what's better: FUBAR= a ZOMG += d BAR ?= b ZOOOM= c or FUBAR = a ZOMG += d BAR ?= b ZOOOM = c to me, definitely the latter. space before sign, tab after, what's wrong with that ? Landry
Re: style rule: space around variables
On Wednesday 03 November 2010 09:50:59 Antoine Jacoutot wrote: Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. Far from it. The people who like this are the exception. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 06:28:47PM +, Federico G. Schwindt wrote: On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. FWIW, I like the spaces around '='. me too f.- -- jake...@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org
Re: style rule: space around variables
On Wed, Nov 3, 2010 at 4:38 PM, Brad b...@comstyle.com wrote: On Wednesday 03 November 2010 09:50:59 Antoine Jacoutot wrote: Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. Far from it. The people who like this are the exception. I'm shocked that this is such a big deal. At first I thought I didn't understand what you guys were bitc^Wcomplaining about until I saw Landry's example. srsly...
Re: style rule: space around variables
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. So then you have to think when you really need the space, or worse, wait until you run into trouble to add the space. Geezzz, what part of what I wrote did you not get ?
Re: style rule: space around variables
Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix updates with spacing, and a simple update diff quickly becomes really long and harder to read. So I suggest we don't intermix this too much.
Re: style rule: space around variables
On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix updates with spacing, and a simple update diff quickly becomes really long and harder to read. So I suggest we don't intermix this too much. I cannot agree more. Stop the madness please. -- Antoine
