git migration complete
Hi Everyone, The git migration is complete. The svn repo is now read only. You can find instructions for accessing the git repo here: https://git-wip-us.apache.org/ The repo name is qpid-proton: https://git-wip-us.apache.org/repos/asf/qpid-proton.git --Rafael
[jira] [Resolved] (PROTON-736) ruby: unable to send binary data?
[
https://issues.apache.org/jira/browse/PROTON-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darryl L. Pierce resolved PROTON-736.
-
Resolution: Fixed
Fix Version/s: 0.9
ruby: unable to send binary data?
-
Key: PROTON-736
URL: https://issues.apache.org/jira/browse/PROTON-736
Project: Qpid Proton
Issue Type: Bug
Components: ruby-binding
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Darryl L. Pierce
Fix For: 0.9
Attachments:
0001-PROTON-736-Ruby-Message-does-not-return-all-content.patch,
0002-PROTON-736-Only-encode-Ruby-strings-as-UTF-8-if-it-s.patch
As discussed on irc with [~mcpierce]
I've not been able to determine how I can correctly send binary data using
the ruby gem.
From proton-c I can do this by (e.g.,)
{{
char* msgdata = Buffer::Data(buffer);
size_t msglen = Buffer::Length(buffer);
pn_message_set_format(msg-message, PN_DATA);
pn_message_load_data(msg-message, msgdata, msglen);
}}
and I assumed I might be able to do similar from Ruby by (e.g.,)
{{
data = File.binread(filename)
msg.format = Qpid::Proton::MessageFormat::DATA
msg.content = data
}}
But Ruby is reading the data into a string and the SWIG binding is still
expecting a byte* array here.
After our discussions on IRC I also investigated doing:
{{
filedata = File.binread(filename)
data = Qpid::Proton::Data.new
data.binary = filedata
msg.body = data
}}
but didn't have any luck with this approach either.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
URGENT: Need to decide what the dev branch is now called [Was: git migration complete]
On Thu, 2014-11-06 at 11:41 -0500, Rafael Schloming wrote: Hi Everyone, The git migration is complete. The svn repo is now read only. You can find instructions for accessing the git repo here: https://git-wip-us.apache.org/ There appears to be a problem already with the migration! Previously when the git repo was a mirror or the svn repo we used the branch name trunk as the ongoing development branch. Since the migration there has been a bunch of work checked in the a new branch called master (which is the usual git default branch). This would be less of a problem if the new branch came from the tip of trunk. However the branches diverge at the 0.8 tag. As a matter of urgency we need to decide which is the real development branch name and merge the other branch onto it, then delete the branch we are not using. In keeping with our project history I suggest we use trunk, but I don't actually care, we just need to decide on one or the other. Andrew
[jira] [Updated] (PROTON-707) Valgrind 'invalid read' errors in proton_tests.message.LoadSaveTest tests
[ https://issues.apache.org/jira/browse/PROTON-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-707: --- Fix Version/s: (was: 0.8) 0.9 Valgrind 'invalid read' errors in proton_tests.message.LoadSaveTest tests - Key: PROTON-707 URL: https://issues.apache.org/jira/browse/PROTON-707 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.8 Reporter: Ken Giusti Fix For: 0.9 Valgrind detects an invalid memory reference during these tests. To reproduce: $ valgrind -q --trace-children=yes --suppressions=./proton_tests/valgrind.supp ./proton-test proton_tests.message.LoadSaveTest.* proton_tests.message.LoadSaveTest.testData .. ==18459== Invalid read of size 1 ==18459==at 0x4A0A534: memcpy@@GLIBC_2.14 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18459==by 0x30F0A8F1B7: PyString_FromStringAndSize (string3.h:51) ==18459==by 0xF24F5C7: _wrap_pn_message_save (cprotonPYTHON_wrap.c:3303) ==18459==by 0x30F0ADDC2D: PyEval_EvalFrameEx (ceval.c:4098) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADEBBC: PyEval_EvalCodeEx (ceval.c:3330) ==18459==by 0x30F0ADD6A8: PyEval_EvalFrameEx (ceval.c:4194) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADEBBC: PyEval_EvalCodeEx (ceval.c:3330) ==18459==by 0x30F0ADD6A8: PyEval_EvalFrameEx (ceval.c:4194) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459== Address 0x1055bb08 is 7 bytes after a block of size 17 alloc'd ==18459==at 0x4A06409: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18459==by 0xF24F500: _wrap_pn_message_save (cprotonPYTHON_wrap.c:4029) ==18459==by 0x30F0ADDC2D: PyEval_EvalFrameEx (ceval.c:4098) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADEBBC: PyEval_EvalCodeEx (ceval.c:3330) ==18459==by 0x30F0ADD6A8: PyEval_EvalFrameEx (ceval.c:4194) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADEBBC: PyEval_EvalCodeEx (ceval.c:3330) ==18459==by 0x30F0ADD6A8: PyEval_EvalFrameEx (ceval.c:4194) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459==by 0x30F0ADD74B: PyEval_EvalFrameEx (ceval.c:4184) ==18459== pass -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: URGENT: Need to decide what the dev branch is now called [Was: git migration complete]
On Thu, 2014-11-06 at 14:54 -0500, Andrew Stitcher wrote: On Thu, 2014-11-06 at 11:41 -0500, Rafael Schloming wrote: Hi Everyone, The git migration is complete. The svn repo is now read only. You can find instructions for accessing the git repo here: https://git-wip-us.apache.org/ There appears to be a problem already with the migration! Ah, no actual problem here! The dev branch is now called master (unless we want to change it back for nostalgia's sake!) Remember to run git remote prune origin if you are changing the url of an existing remote in an existing working repo. And then git checkout master Sorry for the fuss. Andrew
[jira] [Updated] (PROTON-635) PN_TRANSPORT events not generated in enough places
[ https://issues.apache.org/jira/browse/PROTON-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-635: --- Fix Version/s: (was: 0.8) 0.9 PN_TRANSPORT events not generated in enough places -- Key: PROTON-635 URL: https://issues.apache.org/jira/browse/PROTON-635 Project: Qpid Proton Issue Type: Bug Affects Versions: 0.8 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: 0.9 In writing a custom driver for Proton I noticed thatthe new events code does not raise a PN_TRANSPORT event after it receives the incoming AMQP protocol header. So a purely event driven driver is not going to send the outgoing protocol header immediately, but is going to wait until it replies to the next frame (open). Also in error scenarios no PN_TRANSPORT is generated after the open/close frames are generated. This is going to end badly if the peer is waiting for the protocol header before sending the open. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-462) Documentation: Add doxygen overview file for Proton C API
[ https://issues.apache.org/jira/browse/PROTON-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-462: --- Fix Version/s: (was: 0.8) 0.9 Documentation: Add doxygen overview file for Proton C API - Key: PROTON-462 URL: https://issues.apache.org/jira/browse/PROTON-462 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.5 Reporter: Ken Giusti Assignee: Rafael H. Schloming Fix For: 0.9 If possible, have the web page link to the *public header files* as the start page - that's were the meat of the API documentation exists. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-634) Packages are needed for Ubuntu Precise (12 LTS)
[ https://issues.apache.org/jira/browse/PROTON-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-634: --- Fix Version/s: (was: 0.8) 0.9 Packages are needed for Ubuntu Precise (12 LTS) --- Key: PROTON-634 URL: https://issues.apache.org/jira/browse/PROTON-634 Project: Qpid Proton Issue Type: Task Components: proton-c Affects Versions: 0.7 Reporter: Ken Giusti Priority: Minor Fix For: 0.9 Our PPA (ppa:qpid/released) only has proton packages for Ubuntu Trusty (14 LTS). Ubuntu Precise (12 LTS) is still supported by upstream - we should have packages for that also. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-287) Fix Qpid Proton-C build with MinGW on Fedora
[ https://issues.apache.org/jira/browse/PROTON-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-287: --- Fix Version/s: (was: 0.8) 0.9 Fix Qpid Proton-C build with MinGW on Fedora Key: PROTON-287 URL: https://issues.apache.org/jira/browse/PROTON-287 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: 0.4 Environment: mingw32-gcc-4.7.2-7.fc18.x86_64 Reporter: Robin Lee Assignee: Cliff Jansen Labels: build, patch Fix For: 0.9 This is my first submit on ASF JIRA. Fix Qpid Proton-C build with MinGW on Fedora. Patches are provided: Patch 1: http://cheeselee.fedorapeople.org/qpid-proton_trunk_MinGW_STDIO.diff Description: %z format specifier is not provided by MSVCRT, use MinGW version of *printf to get it. Otherwise build failed with: proton-c/src/codec/codec.c:1951:3: error: unknown conversion type character 'z' in format [-Werror=format] Patch 2: http://cheeselee.fedorapeople.org/qpid-proton_trunk_small_cases.diff Description: Libraries and header files should be written in small cases, otherwise build failed in cross build environment of Unix-like platforms: proton-c/src/windows/driver.c:44:22: fatal error: Ws2tcpip.h: No such file or directory Patch 3: http://cheeselee.fedorapeople.org/qpid-proton_trunk_pn_connector_t.diff Description: Change pn_connector_t::fd to type of pn_socket_t. Otherwise, since on Windows platform, pn_socket_t (typedef of SOCKET) is unsigned, build failed with: proton-c/src/windows/driver.c:785:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Patch 4: http://cheeselee.fedorapeople.org/qpid-proton_trunk_unimplemented_functions.diff Description: Commented unimplemented functions. Otherwise build failed with proton-c/src/windows/driver.c:416:13: error: 'pn_connector_write' declared 'static' but never defined [-Werror=unused-function] Patch 5: http://cheeselee.fedorapeople.org/qpid-proton_trunk_wincompat-getopt.diff Description: 1. ID is not used, build failed with ../wincompat/internal/getopt.c:43:20: error: 'ID' defined but not used [-Werror=unused-variable] 2. Corrected getopt signiture, otherwise build failed with proton-c/src/../wincompat/internal/getopt.c:97:5: note: expected 'char *' but argument is of type 'const char *' 3. wincompat/getopt.h #include wincompat/internal/getopt.c directly, so #include wincompat/getopt.h in .c files instead of .h, otherwise build failed with multiple definitions. Patch 6: http://cheeselee.fedorapeople.org/qpid-proton_trunk_WIN32_macro.diff Description: WIN32 macro is not defined with -std=c99 but defined with -std=gnu99. Use _WIN32 macro in all places. Built on Fedora and examples of recv and send are tested on Windows 7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: git migration complete
Few minor things I noticed: 1) the github.com/Apache/qpid-proton mirror has been deleted, but the git.apache.org mirror remains? Intentional? The GitHub mirror is still useful for tracking forks... 2) there doesn't appear to be any linkage between JIRAs and commits anymore? Does someone need to enable that to point at git? 3) no entry for the qpid-proton git repository on reviews.apache.org when you create a review request? Cheers Dom
Re: git migration complete
On Thu, 2014-11-06 at 20:53 +, Dominic Evans wrote: Few minor things I noticed: 1) the github.com/Apache/qpid-proton mirror has been deleted, but the git.apache.org mirror remains? Intentional? The GitHub mirror is still useful for tracking forks... Ouch, what will happen to existing forks? 2) there doesn't appear to be any linkage between JIRAs and commits anymore? Does someone need to enable that to point at git? I think that the existing information will just have gone as it was a simple url to the svn repo put in the jira comments by a process listening to the checkin stream. To migrate it would be a significant effort for someone. I think this is a substantial loss of project functionality - I would have voted against the migration if this loss had been pointed out.
[jira] [Commented] (PROTON-634) Packages are needed for Ubuntu Precise (12 LTS)
[ https://issues.apache.org/jira/browse/PROTON-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200916#comment-14200916 ] Dominic Evans commented on PROTON-634: -- [~kgiusti] it seems this has already been fixed, in that https://launchpad.net/~qpid/+archive/ubuntu/released contains .debs for both trusty and precise now /cc [~rhs] [~mcpierce] Although technically even Lucid (10.04) is still supported until April 2015 on the server kernel. I'll raise a separate JIRA to ask Darryl to push up a 0.8 deb Packages are needed for Ubuntu Precise (12 LTS) --- Key: PROTON-634 URL: https://issues.apache.org/jira/browse/PROTON-634 Project: Qpid Proton Issue Type: Task Components: proton-c Affects Versions: 0.7 Reporter: Ken Giusti Priority: Minor Fix For: 0.9 Our PPA (ppa:qpid/released) only has proton packages for Ubuntu Trusty (14 LTS). Ubuntu Precise (12 LTS) is still supported by upstream - we should have packages for that also. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-738) Debian + Ubuntu Packages need updating to 0.8
Dominic Evans created PROTON-738: Summary: Debian + Ubuntu Packages need updating to 0.8 Key: PROTON-738 URL: https://issues.apache.org/jira/browse/PROTON-738 Project: Qpid Proton Issue Type: Bug Affects Versions: 0.8 Reporter: Dominic Evans Priority: Minor It would be great if we could get 0.8 packages pushed to the development releases for debian and ubuntu https://tracker.debian.org/pkg/qpid-proton https://launchpad.net/ubuntu/+source/qpid-proton And debs for the LTS releases pushed to the PPA https://launchpad.net/~qpid/+archive/ubuntu/released -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: git migration complete
On Thu, 2014-11-06 at 16:00 -0500, Andrew Stitcher wrote: On Thu, 2014-11-06 at 20:53 +, Dominic Evans wrote: Few minor things I noticed: 1) the github.com/Apache/qpid-proton mirror has been deleted, but the git.apache.org mirror remains? Intentional? The GitHub mirror is still useful for tracking forks... Ouch, what will happen to existing forks? 2) there doesn't appear to be any linkage between JIRAs and commits anymore? Does someone need to enable that to point at git? I think that the existing information will just have gone as it was a simple url to the svn repo put in the jira comments by a process listening to the checkin stream. To migrate it would be a significant effort for someone. I think this is a substantial loss of project functionality - I would have voted against the migration if this loss had been pointed out. Justin pointed out that the existing links still point to the old svn repo (readonly now) so this isn't that bad, however we should get something similar set up for git ASAP. Andrew
Re: git migration complete
On Thu, Nov 6, 2014 at 4:09 PM, Andrew Stitcher astitc...@redhat.com wrote: On Thu, 2014-11-06 at 16:00 -0500, Andrew Stitcher wrote: On Thu, 2014-11-06 at 20:53 +, Dominic Evans wrote: Few minor things I noticed: 1) the github.com/Apache/qpid-proton mirror has been deleted, but the git.apache.org mirror remains? Intentional? The GitHub mirror is still useful for tracking forks... Ouch, what will happen to existing forks? 2) there doesn't appear to be any linkage between JIRAs and commits anymore? Does someone need to enable that to point at git? I think that the existing information will just have gone as it was a simple url to the svn repo put in the jira comments by a process listening to the checkin stream. To migrate it would be a significant effort for someone. I think this is a substantial loss of project functionality - I would have voted against the migration if this loss had been pointed out. Justin pointed out that the existing links still point to the old svn repo (readonly now) so this isn't that bad, however we should get something similar set up for git ASAP. The git to JIRA integration does exist and was supposed to have been set up with the initial migration. I believe it was simply overlooked. I posted a comment to https://issues.apache.org/jira/browse/INFRA-8580, and I believe the integration has been set up now, but I haven't tested it personally. The comment trail on the above mentioned JIRA also indicates that the github mirror will sync within 24 hours, so lets hope it will reappear. As for the reviews issue, I'm not sure what the procedure is to get that set up correctly. Does anyone else know? --Rafael
[ANNOUNCE] Qpid Proton 0.8 released
Hi Everyone, Qpid Proton 0.8 is now officially available. You can find it here: - http://qpid.apache.org/releases/qpid-proton-0.8/index.html The release includes numerous bug fixes and improvements. Full details can be found here: - https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720version=12326950 Many thanks to everyone who contributed! --Rafael
