Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Alan Conway
[+1] Yes, release Proton 0.9-rc-2 as 0.9 final

Ran the dispatch test suite, including SSL tests. No problems.


On Mon, 2015-03-16 at 18:04 +1300, Rafael Schloming wrote:
 Hi Everyone,
 
 I've posted 0.9 RC 2 in the usual places. The source artifacts are
 available here:
 
 https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
 
 Java binaries are available here:
 
 https://repository.apache.org/content/repositories/orgapacheqpid-1029
 
 The changes from RC 1 are very minor, I've appended the commit log if
 you're interested in the details. Please have a look and register your vote:
 

 [   ] No, because ...
 
 --Rafael
 
 
 
 commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
 Author: Rafael Schloming r...@alum.mit.edu
 Date:   Mon Mar 16 17:42:56 2015 +1300
 
 Release 0.9-rc-2
 
 commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
 Author: Bozo Dragojevic bo...@digiverse.si
 Date:   Fri Mar 13 14:01:35 2015 +0100
 
 PROTON-838: proton-hawtdispatch cannot connect with SSL
 
 Remove one of calls to transport.connecting() as this causes
 an assert with SslTransport
 
 (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
 
 commit ea01c014fedd8dff134131f93b7d957aabac70ec
 Author: Alan Conway acon...@redhat.com
 Date:   Wed Mar 11 11:17:23 2015 -0400
 
 PROTON-836: Missing import SSLUnavailable in reactor.py.
 
 commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
 Author: Gordon Sim g...@redhat.com
 Date:   Mon Mar 9 14:37:35 2015 +
 
 NO-JIRA: lack of ssl support should not prevent Container being used
 
 commit 27851a6d979342178817734423b83b37840a
 Author: Robert Gemmell rob...@apache.org
 Date:   Mon Mar 9 19:36:06 2015 +
 
 add missing NOTICE file
 
 cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
 
 commit 77403b3c091b2c6dfcc766d978130a34f765ee29
 Author: Kenneth Giusti kgiu...@apache.org
 Date:   Mon Mar 9 13:38:56 2015 -0400
 
 NO-JIRA: fix documentation build
 
 (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)




[jira] [Commented] (PROTON-839) Proton 0.9 RC 2 blocker - proton_tests.utils.SyncRequestResponseTest.test_request_response ........ fail

2015-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363214#comment-14363214
 ] 

ASF subversion and git services commented on PROTON-839:


Commit e31df015a79d791e62caf9bef3f29bdfd77042ef in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e31df01 ]

PROTON-839: Proton 0.9 RC 2 blocker - 
proton_tests.utils.SyncRequestResponseTest.test_request_response  fail

Fix to reactor.py, check for lack of SSL domain.


 Proton 0.9 RC 2 blocker - 
 proton_tests.utils.SyncRequestResponseTest.test_request_response  fail
 

 Key: PROTON-839
 URL: https://issues.apache.org/jira/browse/PROTON-839
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Blocker
 Fix For: 0.9


 Hate to be a party-pooper, but:
 1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
 fail
 1: Error during test:  Traceback (most recent call last):
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
 355, in run
 1:   phase()
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
  line 89, in test_request_response
 1:   connection = BlockingConnection(server.url, timeout=self.timeout)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
  line 198, in __init__
 1:   self.conn = self.container.connect(url=self.url, handler=self, 
 ssl_domain=ssl_domain, reconnect=False)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
  line 616, in connect
 1:   connector.ssl_domain = ssl_domain or self.ssl.client
 1:   AttributeError: 'NoneType' object has no attribute 'client'
 1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
 1/1 Test #1: python-test ..***Failed  Required regular 
 expression not found.Regex=[Totals: .* 0 failed
 When the openssl devel libraries are not installed.   Seems like a legit bug: 
 reactor is assuming a non-None SSL domain is stored in self.ssl.client in 
 that particular codepath.
 - Original Message -
  From: Rafael Schloming r...@alum.mit.edu
  To: proton@qpid.apache.org, us...@qpid.apache.org
  Sent: Monday, March 16, 2015 1:04:22 AM
  Subject: [VOTE] Proton 0.9 RC 2
  
  Hi Everyone,
  
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
  
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
  Java binaries are available here:
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your vote:
  
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
  
  --Rafael
  
  
  
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
  
  Release 0.9-rc-2
  
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
  
  PROTON-838: proton-hawtdispatch cannot connect with SSL
  
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
  
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
  
  PROTON-836: Missing import SSLUnavailable in reactor.py.
  
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
  
  NO-JIRA: lack of ssl support should not prevent Container being used
  
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
  
  add missing NOTICE file
  
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
  
  NO-JIRA: fix documentation build
  
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
  
 -- 
 -K



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (PROTON-839) Proton 0.9 RC 2 blocker - proton_tests.utils.SyncRequestResponseTest.test_request_response ........ fail

2015-03-16 Thread Alan Conway (JIRA)
Alan Conway created PROTON-839:
--

 Summary: Proton 0.9 RC 2 blocker - 
proton_tests.utils.SyncRequestResponseTest.test_request_response  fail
 Key: PROTON-839
 URL: https://issues.apache.org/jira/browse/PROTON-839
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Blocker
 Fix For: 0.9


Hate to be a party-pooper, but:

1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
fail
1: Error during test:  Traceback (most recent call last):
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
355, in run
1:   phase()
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
 line 89, in test_request_response
1:   connection = BlockingConnection(server.url, timeout=self.timeout)
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
 line 198, in __init__
1:   self.conn = self.container.connect(url=self.url, handler=self, 
ssl_domain=ssl_domain, reconnect=False)
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
 line 616, in connect
1:   connector.ssl_domain = ssl_domain or self.ssl.client
1:   AttributeError: 'NoneType' object has no attribute 'client'
1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
1/1 Test #1: python-test ..***Failed  Required regular 
expression not found.Regex=[Totals: .* 0 failed

When the openssl devel libraries are not installed.   Seems like a legit bug: 
reactor is assuming a non-None SSL domain is stored in self.ssl.client in that 
particular codepath.



- Original Message -
 From: Rafael Schloming r...@alum.mit.edu
 To: proton@qpid.apache.org, us...@qpid.apache.org
 Sent: Monday, March 16, 2015 1:04:22 AM
 Subject: [VOTE] Proton 0.9 RC 2
 
 Hi Everyone,
 
 I've posted 0.9 RC 2 in the usual places. The source artifacts are
 available here:
 
 https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
 
 Java binaries are available here:
 
 https://repository.apache.org/content/repositories/orgapacheqpid-1029
 
 The changes from RC 1 are very minor, I've appended the commit log if
 you're interested in the details. Please have a look and register your vote:
 
 [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
 [   ] No, because ...
 
 --Rafael
 
 
 
 commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
 Author: Rafael Schloming r...@alum.mit.edu
 Date:   Mon Mar 16 17:42:56 2015 +1300
 
 Release 0.9-rc-2
 
 commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
 Author: Bozo Dragojevic bo...@digiverse.si
 Date:   Fri Mar 13 14:01:35 2015 +0100
 
 PROTON-838: proton-hawtdispatch cannot connect with SSL
 
 Remove one of calls to transport.connecting() as this causes
 an assert with SslTransport
 
 (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
 
 commit ea01c014fedd8dff134131f93b7d957aabac70ec
 Author: Alan Conway acon...@redhat.com
 Date:   Wed Mar 11 11:17:23 2015 -0400
 
 PROTON-836: Missing import SSLUnavailable in reactor.py.
 
 commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
 Author: Gordon Sim g...@redhat.com
 Date:   Mon Mar 9 14:37:35 2015 +
 
 NO-JIRA: lack of ssl support should not prevent Container being used
 
 commit 27851a6d979342178817734423b83b37840a
 Author: Robert Gemmell rob...@apache.org
 Date:   Mon Mar 9 19:36:06 2015 +
 
 add missing NOTICE file
 
 cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
 
 commit 77403b3c091b2c6dfcc766d978130a34f765ee29
 Author: Kenneth Giusti kgiu...@apache.org
 Date:   Mon Mar 9 13:38:56 2015 -0400
 
 NO-JIRA: fix documentation build
 
 (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
 

-- 
-K



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-839) Proton 0.9 RC 2 blocker - proton_tests.utils.SyncRequestResponseTest.test_request_response ........ fail

2015-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363217#comment-14363217
 ] 

ASF subversion and git services commented on PROTON-839:


Commit c2042d7d26c4383047dac2709d1a2effe0b11419 in qpid-proton's branch 
refs/heads/0.9 from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c2042d7 ]

PROTON-839: Proton 0.9 RC 2 blocker - 
proton_tests.utils.SyncRequestResponseTest.test_request_response  fail

Fix to reactor.py, check for lack of SSL domain.

(cherry picked from commit e31df015a79d791e62caf9bef3f29bdfd77042ef)


 Proton 0.9 RC 2 blocker - 
 proton_tests.utils.SyncRequestResponseTest.test_request_response  fail
 

 Key: PROTON-839
 URL: https://issues.apache.org/jira/browse/PROTON-839
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Blocker
 Fix For: 0.9


 Hate to be a party-pooper, but:
 1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
 fail
 1: Error during test:  Traceback (most recent call last):
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
 355, in run
 1:   phase()
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
  line 89, in test_request_response
 1:   connection = BlockingConnection(server.url, timeout=self.timeout)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
  line 198, in __init__
 1:   self.conn = self.container.connect(url=self.url, handler=self, 
 ssl_domain=ssl_domain, reconnect=False)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
  line 616, in connect
 1:   connector.ssl_domain = ssl_domain or self.ssl.client
 1:   AttributeError: 'NoneType' object has no attribute 'client'
 1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
 1/1 Test #1: python-test ..***Failed  Required regular 
 expression not found.Regex=[Totals: .* 0 failed
 When the openssl devel libraries are not installed.   Seems like a legit bug: 
 reactor is assuming a non-None SSL domain is stored in self.ssl.client in 
 that particular codepath.
 - Original Message -
  From: Rafael Schloming r...@alum.mit.edu
  To: proton@qpid.apache.org, us...@qpid.apache.org
  Sent: Monday, March 16, 2015 1:04:22 AM
  Subject: [VOTE] Proton 0.9 RC 2
  
  Hi Everyone,
  
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
  
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
  Java binaries are available here:
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your vote:
  
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
  
  --Rafael
  
  
  
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
  
  Release 0.9-rc-2
  
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
  
  PROTON-838: proton-hawtdispatch cannot connect with SSL
  
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
  
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
  
  PROTON-836: Missing import SSLUnavailable in reactor.py.
  
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
  
  NO-JIRA: lack of ssl support should not prevent Container being used
  
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
  
  add missing NOTICE file
  
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
  
  NO-JIRA: fix documentation build
  
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
  
 -- 
 -K



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (PROTON-839) Proton 0.9 RC 2 blocker - proton_tests.utils.SyncRequestResponseTest.test_request_response ........ fail

2015-03-16 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-839.

Resolution: Fixed

 Proton 0.9 RC 2 blocker - 
 proton_tests.utils.SyncRequestResponseTest.test_request_response  fail
 

 Key: PROTON-839
 URL: https://issues.apache.org/jira/browse/PROTON-839
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Blocker
 Fix For: 0.9


 Hate to be a party-pooper, but:
 1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
 fail
 1: Error during test:  Traceback (most recent call last):
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
 355, in run
 1:   phase()
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
  line 89, in test_request_response
 1:   connection = BlockingConnection(server.url, timeout=self.timeout)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
  line 198, in __init__
 1:   self.conn = self.container.connect(url=self.url, handler=self, 
 ssl_domain=ssl_domain, reconnect=False)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
  line 616, in connect
 1:   connector.ssl_domain = ssl_domain or self.ssl.client
 1:   AttributeError: 'NoneType' object has no attribute 'client'
 1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
 1/1 Test #1: python-test ..***Failed  Required regular 
 expression not found.Regex=[Totals: .* 0 failed
 When the openssl devel libraries are not installed.   Seems like a legit bug: 
 reactor is assuming a non-None SSL domain is stored in self.ssl.client in 
 that particular codepath.
 - Original Message -
  From: Rafael Schloming r...@alum.mit.edu
  To: proton@qpid.apache.org, us...@qpid.apache.org
  Sent: Monday, March 16, 2015 1:04:22 AM
  Subject: [VOTE] Proton 0.9 RC 2
  
  Hi Everyone,
  
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
  
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
  Java binaries are available here:
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your vote:
  
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
  
  --Rafael
  
  
  
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
  
  Release 0.9-rc-2
  
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
  
  PROTON-838: proton-hawtdispatch cannot connect with SSL
  
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
  
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
  
  PROTON-836: Missing import SSLUnavailable in reactor.py.
  
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
  
  NO-JIRA: lack of ssl support should not prevent Container being used
  
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
  
  add missing NOTICE file
  
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
  
  NO-JIRA: fix documentation build
  
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
  
 -- 
 -K



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Alan Conway
Fixed https://issues.apache.org/jira/browse/PROTON-839

On Mon, 2015-03-16 at 09:00 -0400, Ken Giusti wrote:
 Hate to be a party-pooper, but:
 
 1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
 fail
 1: Error during test:  Traceback (most recent call last):
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
 355, in run
 1:   phase()
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
  line 89, in test_request_response
 1:   connection = BlockingConnection(server.url, timeout=self.timeout)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
  line 198, in __init__
 1:   self.conn = self.container.connect(url=self.url, handler=self, 
 ssl_domain=ssl_domain, reconnect=False)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
  line 616, in connect
 1:   connector.ssl_domain = ssl_domain or self.ssl.client
 1:   AttributeError: 'NoneType' object has no attribute 'client'
 1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
 1/1 Test #1: python-test ..***Failed  Required regular 
 expression not found.Regex=[Totals: .* 0 failed
 
 When the openssl devel libraries are not installed.   Seems like a legit bug: 
 reactor is assuming a non-None SSL domain is stored in self.ssl.client in 
 that particular codepath.
 
 
 
 - Original Message -
  From: Rafael Schloming r...@alum.mit.edu
  To: proton@qpid.apache.org, us...@qpid.apache.org
  Sent: Monday, March 16, 2015 1:04:22 AM
  Subject: [VOTE] Proton 0.9 RC 2
  
  Hi Everyone,
  
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
  
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
  Java binaries are available here:
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your vote:
  
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
  
  --Rafael
  
  
  
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
  
  Release 0.9-rc-2
  
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
  
  PROTON-838: proton-hawtdispatch cannot connect with SSL
  
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
  
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
  
  PROTON-836: Missing import SSLUnavailable in reactor.py.
  
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
  
  NO-JIRA: lack of ssl support should not prevent Container being used
  
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
  
  add missing NOTICE file
  
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
  
  NO-JIRA: fix documentation build
  
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
  
 




Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Alan Conway
On Mon, 2015-03-16 at 09:00 -0400, Ken Giusti wrote:
 Hate to be a party-pooper, but:
 
 1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
 fail
 1: Error during test:  Traceback (most recent call last):
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
 355, in run
 1:   phase()
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
  line 89, in test_request_response
 1:   connection = BlockingConnection(server.url, timeout=self.timeout)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
  line 198, in __init__
 1:   self.conn = self.container.connect(url=self.url, handler=self, 
 ssl_domain=ssl_domain, reconnect=False)
 1: File 
 /home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
  line 616, in connect
 1:   connector.ssl_domain = ssl_domain or self.ssl.client
 1:   AttributeError: 'NoneType' object has no attribute 'client'
 1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
 1/1 Test #1: python-test ..***Failed  Required regular 
 expression not found.Regex=[Totals: .* 0 failed
 
 When the openssl devel libraries are not installed.   Seems like a legit bug: 
 reactor is assuming a non-None SSL domain is stored in self.ssl.client in 
 that particular codepath.
 
 
That is truly bizzare, I would *swear* I fixed that last time around
but I can't find any checkin where I did :( Will check in the fix
momentarily...

 
 - Original Message -
  From: Rafael Schloming r...@alum.mit.edu
  To: proton@qpid.apache.org, us...@qpid.apache.org
  Sent: Monday, March 16, 2015 1:04:22 AM
  Subject: [VOTE] Proton 0.9 RC 2
  
  Hi Everyone,
  
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
  
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
  Java binaries are available here:
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your vote:
  
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
  
  --Rafael
  
  
  
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
  
  Release 0.9-rc-2
  
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
  
  PROTON-838: proton-hawtdispatch cannot connect with SSL
  
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
  
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
  
  PROTON-836: Missing import SSLUnavailable in reactor.py.
  
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
  
  NO-JIRA: lack of ssl support should not prevent Container being used
  
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
  
  add missing NOTICE file
  
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
  
  NO-JIRA: fix documentation build
  
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
  
 




[jira] [Reopened] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread Dominic Evans (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominic Evans reopened PROTON-834:
--
  Assignee: Dominic Evans

 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans
 Fix For: 0.9


 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Robbie Gemmell
[ +1 ] Yes, release Proton 0.9-rc-2 as 0.9 final

I tested out RC2 as follows:
- Checked license/notice files present.
- Verified sigs and checksums match.
- Built everything using cmake and ran the tests.
- Verified building/running the Qpid C++ broker against proton-c.
- Built proton-j and ran the tests using maven.
- Verified using proton-j in the build+tests for the new Qpid JMS client.

Robbie

On 16 March 2015 at 05:04, Rafael Schloming r...@alum.mit.edu wrote:
 Hi Everyone,

 I've posted 0.9 RC 2 in the usual places. The source artifacts are
 available here:

 https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/

 Java binaries are available here:

 https://repository.apache.org/content/repositories/orgapacheqpid-1029

 The changes from RC 1 are very minor, I've appended the commit log if
 you're interested in the details. Please have a look and register your vote:

 [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
 [   ] No, because ...

 --Rafael

 

 commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
 Author: Rafael Schloming r...@alum.mit.edu
 Date:   Mon Mar 16 17:42:56 2015 +1300

 Release 0.9-rc-2

 commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
 Author: Bozo Dragojevic bo...@digiverse.si
 Date:   Fri Mar 13 14:01:35 2015 +0100

 PROTON-838: proton-hawtdispatch cannot connect with SSL

 Remove one of calls to transport.connecting() as this causes
 an assert with SslTransport

 (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)

 commit ea01c014fedd8dff134131f93b7d957aabac70ec
 Author: Alan Conway acon...@redhat.com
 Date:   Wed Mar 11 11:17:23 2015 -0400

 PROTON-836: Missing import SSLUnavailable in reactor.py.

 commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
 Author: Gordon Sim g...@redhat.com
 Date:   Mon Mar 9 14:37:35 2015 +

 NO-JIRA: lack of ssl support should not prevent Container being used

 commit 27851a6d979342178817734423b83b37840a
 Author: Robert Gemmell rob...@apache.org
 Date:   Mon Mar 9 19:36:06 2015 +

 add missing NOTICE file

 cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69

 commit 77403b3c091b2c6dfcc766d978130a34f765ee29
 Author: Kenneth Giusti kgiu...@apache.org
 Date:   Mon Mar 9 13:38:56 2015 -0400

 NO-JIRA: fix documentation build

 (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)


Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Ken Giusti
Hate to be a party-pooper, but:

1: proton_tests.utils.SyncRequestResponseTest.test_request_response  
fail
1: Error during test:  Traceback (most recent call last):
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton-test, line 
355, in run
1:   phase()
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/tests/python/proton_tests/utils.py,
 line 89, in test_request_response
1:   connection = BlockingConnection(server.url, timeout=self.timeout)
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/utils.py,
 line 198, in __init__
1:   self.conn = self.container.connect(url=self.url, handler=self, 
ssl_domain=ssl_domain, reconnect=False)
1: File 
/home/kgiusti/Downloads/qpid-proton-0.9-rc-2/proton-c/bindings/python/proton/reactor.py,
 line 616, in connect
1:   connector.ssl_domain = ssl_domain or self.ssl.client
1:   AttributeError: 'NoneType' object has no attribute 'client'
1: Totals: 323 tests, 290 passed, 32 skipped, 0 ignored, 1 failed
1/1 Test #1: python-test ..***Failed  Required regular 
expression not found.Regex=[Totals: .* 0 failed

When the openssl devel libraries are not installed.   Seems like a legit bug: 
reactor is assuming a non-None SSL domain is stored in self.ssl.client in that 
particular codepath.



- Original Message -
 From: Rafael Schloming r...@alum.mit.edu
 To: proton@qpid.apache.org, us...@qpid.apache.org
 Sent: Monday, March 16, 2015 1:04:22 AM
 Subject: [VOTE] Proton 0.9 RC 2
 
 Hi Everyone,
 
 I've posted 0.9 RC 2 in the usual places. The source artifacts are
 available here:
 
 https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
 
 Java binaries are available here:
 
 https://repository.apache.org/content/repositories/orgapacheqpid-1029
 
 The changes from RC 1 are very minor, I've appended the commit log if
 you're interested in the details. Please have a look and register your vote:
 
 [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
 [   ] No, because ...
 
 --Rafael
 
 
 
 commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
 Author: Rafael Schloming r...@alum.mit.edu
 Date:   Mon Mar 16 17:42:56 2015 +1300
 
 Release 0.9-rc-2
 
 commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
 Author: Bozo Dragojevic bo...@digiverse.si
 Date:   Fri Mar 13 14:01:35 2015 +0100
 
 PROTON-838: proton-hawtdispatch cannot connect with SSL
 
 Remove one of calls to transport.connecting() as this causes
 an assert with SslTransport
 
 (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
 
 commit ea01c014fedd8dff134131f93b7d957aabac70ec
 Author: Alan Conway acon...@redhat.com
 Date:   Wed Mar 11 11:17:23 2015 -0400
 
 PROTON-836: Missing import SSLUnavailable in reactor.py.
 
 commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
 Author: Gordon Sim g...@redhat.com
 Date:   Mon Mar 9 14:37:35 2015 +
 
 NO-JIRA: lack of ssl support should not prevent Container being used
 
 commit 27851a6d979342178817734423b83b37840a
 Author: Robert Gemmell rob...@apache.org
 Date:   Mon Mar 9 19:36:06 2015 +
 
 add missing NOTICE file
 
 cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
 
 commit 77403b3c091b2c6dfcc766d978130a34f765ee29
 Author: Kenneth Giusti kgiu...@apache.org
 Date:   Mon Mar 9 13:38:56 2015 -0400
 
 NO-JIRA: fix documentation build
 
 (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)
 

-- 
-K


Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Robbie Gemmell
Dominic has posted a further change for PROTON-834 that fixes a corner
case not seen when making an earlier change in 0.9.

I think we should include it if doing an RC3 to pick up the change
Alan also made earlier.

Robbie

On 16 March 2015 at 12:20, Robbie Gemmell robbie.gemm...@gmail.com wrote:
 [ +1 ] Yes, release Proton 0.9-rc-2 as 0.9 final

 I tested out RC2 as follows:
 - Checked license/notice files present.
 - Verified sigs and checksums match.
 - Built everything using cmake and ran the tests.
 - Verified building/running the Qpid C++ broker against proton-c.
 - Built proton-j and ran the tests using maven.
 - Verified using proton-j in the build+tests for the new Qpid JMS client.

 Robbie

 On 16 March 2015 at 05:04, Rafael Schloming r...@alum.mit.edu wrote:
 Hi Everyone,

 I've posted 0.9 RC 2 in the usual places. The source artifacts are
 available here:

 https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/

 Java binaries are available here:

 https://repository.apache.org/content/repositories/orgapacheqpid-1029

 The changes from RC 1 are very minor, I've appended the commit log if
 you're interested in the details. Please have a look and register your vote:

 [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
 [   ] No, because ...

 --Rafael

 

 commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
 Author: Rafael Schloming r...@alum.mit.edu
 Date:   Mon Mar 16 17:42:56 2015 +1300

 Release 0.9-rc-2

 commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
 Author: Bozo Dragojevic bo...@digiverse.si
 Date:   Fri Mar 13 14:01:35 2015 +0100

 PROTON-838: proton-hawtdispatch cannot connect with SSL

 Remove one of calls to transport.connecting() as this causes
 an assert with SslTransport

 (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)

 commit ea01c014fedd8dff134131f93b7d957aabac70ec
 Author: Alan Conway acon...@redhat.com
 Date:   Wed Mar 11 11:17:23 2015 -0400

 PROTON-836: Missing import SSLUnavailable in reactor.py.

 commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
 Author: Gordon Sim g...@redhat.com
 Date:   Mon Mar 9 14:37:35 2015 +

 NO-JIRA: lack of ssl support should not prevent Container being used

 commit 27851a6d979342178817734423b83b37840a
 Author: Robert Gemmell rob...@apache.org
 Date:   Mon Mar 9 19:36:06 2015 +

 add missing NOTICE file

 cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69

 commit 77403b3c091b2c6dfcc766d978130a34f765ee29
 Author: Kenneth Giusti kgiu...@apache.org
 Date:   Mon Mar 9 13:38:56 2015 -0400

 NO-JIRA: fix documentation build

 (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)


[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-16 Thread alanconway
Github user alanconway commented on the pull request:

https://github.com/apache/qpid-proton/pull/11#issuecomment-81791421
  
Comitted the suggested API upstream. Doesn't do the suggested caching yet.

commit fac7c86c8bc818ea845d6426fd85095a189522d6
Author: Alan Conway acon...@redhat.com
Commit: Alan Conway acon...@redhat.com

NO-JIRA: Measure size of encoded data.

Introduce pn_data_size() to calculate the buffer space required to 
encode a data object.

- encoder.c measures full size of data.
- interop.py verifies computed size matches actual decode size.
- update java/jython compatilbility layer.

Code review at https://github.com/apache/qpid-proton/pull/11.

Did not (yet) implement size caching as suggested in the review as 
invalidating
the cache is a little involved. Leaving it for another day.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-16 Thread alanconway
Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363325#comment-14363325
 ] 

ASF GitHub Bot commented on PROTON-834:
---

GitHub user dnwe opened a pull request:

https://github.com/apache/qpid-proton/pull/13

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnwe/qpid-proton fix-proton-834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit dc52650e7de53ef5fe294b9066620b4698c30a94
Author: Dominic Evans dominic.ev...@uk.ibm.com
Date:   2015-03-16T12:18:20Z

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.




 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans

 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes

2015-03-16 Thread dnwe
GitHub user dnwe opened a pull request:

https://github.com/apache/qpid-proton/pull/13

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnwe/qpid-proton fix-proton-834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit dc52650e7de53ef5fe294b9066620b4698c30a94
Author: Dominic Evans dominic.ev...@uk.ibm.com
Date:   2015-03-16T12:18:20Z

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes

2015-03-16 Thread gemmellr
Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/13#issuecomment-81751109
  
Looks good to me. We should request for inclusion in 0.9 if there is an RC3 
to pick up aconways SSL change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363393#comment-14363393
 ] 

ASF subversion and git services commented on PROTON-834:


Commit 7b9b516d445ab9e86a0313709c77218d901435b1 in qpid-proton's branch 
refs/heads/master from [~dnwe]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7b9b516 ]

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.

Closes #13


 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans

 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363365#comment-14363365
 ] 

ASF GitHub Bot commented on PROTON-834:
---

Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/13#issuecomment-81751109
  
Looks good to me. We should request for inclusion in 0.9 if there is an RC3 
to pick up aconways SSL change.


 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans

 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363394#comment-14363394
 ] 

ASF GitHub Bot commented on PROTON-834:
---

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/13


 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans

 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-827) Reactive client binding for the go programming language.

2015-03-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363638#comment-14363638
 ] 

ASF subversion and git services commented on PROTON-827:


Commit 51ddf8a7cc8c0b93c6d6f0c19ffa49ba7c52c2a0 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=51ddf8a ]

PROTON-827: Removed go examples.

My evolving understanding of Go makes me feel these examples are not right.
Watch this space.


 Reactive client binding for the go programming language.
 --

 Key: PROTON-827
 URL: https://issues.apache.org/jira/browse/PROTON-827
 Project: Qpid Proton
  Issue Type: Improvement
  Components: proton-c
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway

 Develop a reactive API binding in go http://golang.org/, similar to the 
 existing reactive python API illustrated in examples/python. It should follow 
 the pattern of the existing python and C reactive APIs as far as possible 
 while respecting common conventions and idioms of the go langauge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE]: Proton 0.9-rc-3

2015-03-16 Thread Rafael Schloming
Hi Everyone,

Here's a quick respin of 0.9-rc-3. The only changes from rc-2 are exactly
those two mentioned on the rc-2 vote thread. I've included them at the end
for reference. You can find the source artifacts in the usual location:

https://people.apache.org/~rhs/qpid-proton-0.9-rc-3/

Java binaries are here:

https://repository.apache.org/content/repositories/orgapacheqpid-1031

Please check it out and register your vote:

[   ] Yes, release Proton 0.9-rc-3 as 0.9 final
[   ] No, because ...

--Rafael

==

commit 810088b14dedcd12a9474687ba9cd05fc8297188
Author: Dominic Evans dominic.ev...@uk.ibm.com
Date:   Mon Mar 16 12:18:20 2015 +

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.

Closes #13

(cherry picked from commit 7b9b516d445ab9e86a0313709c77218d901435b1)

commit c2042d7d26c4383047dac2709d1a2effe0b11419
Author: Alan Conway acon...@redhat.com
Date:   Mon Mar 16 09:51:28 2015 -0400

PROTON-839: Proton 0.9 RC 2 blocker -
proton_tests.utils.SyncRequestResponse

Fix to reactor.py, check for lack of SSL domain.

(cherry picked from commit e31df015a79d791e62caf9bef3f29bdfd77042ef)


Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Rafael Schloming
I'm happy to do a quick turnaround on RC 3 if you/he wants to pull the fix
onto the release branch.

--Rafael

On Tue, Mar 17, 2015 at 5:54 AM, Robbie Gemmell robbie.gemm...@gmail.com
wrote:

 Dominic has posted a further change for PROTON-834 that fixes a corner
 case not seen when making an earlier change in 0.9.

 I think we should include it if doing an RC3 to pick up the change
 Alan also made earlier.

 Robbie

 On 16 March 2015 at 12:20, Robbie Gemmell robbie.gemm...@gmail.com
 wrote:
  [ +1 ] Yes, release Proton 0.9-rc-2 as 0.9 final
 
  I tested out RC2 as follows:
  - Checked license/notice files present.
  - Verified sigs and checksums match.
  - Built everything using cmake and ran the tests.
  - Verified building/running the Qpid C++ broker against proton-c.
  - Built proton-j and ran the tests using maven.
  - Verified using proton-j in the build+tests for the new Qpid JMS client.
 
  Robbie
 
  On 16 March 2015 at 05:04, Rafael Schloming r...@alum.mit.edu wrote:
  Hi Everyone,
 
  I've posted 0.9 RC 2 in the usual places. The source artifacts are
  available here:
 
  https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
 
  Java binaries are available here:
 
 
 https://repository.apache.org/content/repositories/orgapacheqpid-1029
 
  The changes from RC 1 are very minor, I've appended the commit log if
  you're interested in the details. Please have a look and register your
 vote:
 
  [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
  [   ] No, because ...
 
  --Rafael
 
  
 
  commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
  Author: Rafael Schloming r...@alum.mit.edu
  Date:   Mon Mar 16 17:42:56 2015 +1300
 
  Release 0.9-rc-2
 
  commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
  Author: Bozo Dragojevic bo...@digiverse.si
  Date:   Fri Mar 13 14:01:35 2015 +0100
 
  PROTON-838: proton-hawtdispatch cannot connect with SSL
 
  Remove one of calls to transport.connecting() as this causes
  an assert with SslTransport
 
  (cherry picked from commit f8ca35f3e007b99e0a5365e154e067840adcefb0)
 
  commit ea01c014fedd8dff134131f93b7d957aabac70ec
  Author: Alan Conway acon...@redhat.com
  Date:   Wed Mar 11 11:17:23 2015 -0400
 
  PROTON-836: Missing import SSLUnavailable in reactor.py.
 
  commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
  Author: Gordon Sim g...@redhat.com
  Date:   Mon Mar 9 14:37:35 2015 +
 
  NO-JIRA: lack of ssl support should not prevent Container being used
 
  commit 27851a6d979342178817734423b83b37840a
  Author: Robert Gemmell rob...@apache.org
  Date:   Mon Mar 9 19:36:06 2015 +
 
  add missing NOTICE file
 
  cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
 
  commit 77403b3c091b2c6dfcc766d978130a34f765ee29
  Author: Kenneth Giusti kgiu...@apache.org
  Date:   Mon Mar 9 13:38:56 2015 -0400
 
  NO-JIRA: fix documentation build
 
  (cherry picked from commit bc2b630eb969710b04a861797567ab2dc368020a)

 -
 To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
 For additional commands, e-mail: users-h...@qpid.apache.org




Re: [VOTE] Proton 0.9 RC 2

2015-03-16 Thread Dominic Evans

Hey Rafa,

I did already cherry pick it into the release branch.

Cheers
Dom


 On 16 Mar 2015, at 18:54, Rafael Schloming r...@alum.mit.edu wrote:

 I'm happy to do a quick turnaround on RC 3 if you/he wants to pull the
fix
 onto the release branch.

 --Rafael

 On Tue, Mar 17, 2015 at 5:54 AM, Robbie Gemmell
robbie.gemm...@gmail.com
 wrote:

  Dominic has posted a further change for PROTON-834 that fixes a corner
  case not seen when making an earlier change in 0.9.
 
  I think we should include it if doing an RC3 to pick up the change
  Alan also made earlier.
 
  Robbie
 
  On 16 March 2015 at 12:20, Robbie Gemmell robbie.gemm...@gmail.com
  wrote:
   [ +1 ] Yes, release Proton 0.9-rc-2 as 0.9 final
  
   I tested out RC2 as follows:
   - Checked license/notice files present.
   - Verified sigs and checksums match.
   - Built everything using cmake and ran the tests.
   - Verified building/running the Qpid C++ broker against proton-c.
   - Built proton-j and ran the tests using maven.
   - Verified using proton-j in the build+tests for the new Qpid JMS
client.
  
   Robbie
  
   On 16 March 2015 at 05:04, Rafael Schloming r...@alum.mit.edu wrote:
   Hi Everyone,
  
   I've posted 0.9 RC 2 in the usual places. The source artifacts are
   available here:
  
   https://people.apache.org/~rhs/qpid-proton-0.9-rc-2/
  
   Java binaries are available here:
  
  
  https://repository.apache.org/content/repositories/orgapacheqpid-1029
  
   The changes from RC 1 are very minor, I've appended the commit log
if
   you're interested in the details. Please have a look and register
your
  vote:
  
   [   ] Yes, release Proton 0.9-rc-2 as 0.9 final
   [   ] No, because ...
  
   --Rafael
  
   
  
   commit b6506126afbc51bab4c97bf847f2f07f2cc4e6e2
   Author: Rafael Schloming r...@alum.mit.edu
   Date:   Mon Mar 16 17:42:56 2015 +1300
  
   Release 0.9-rc-2
  
   commit 0fbe80e2f81a1e8a2df55f6221b987391d5dc336
   Author: Bozo Dragojevic bo...@digiverse.si
   Date:   Fri Mar 13 14:01:35 2015 +0100
  
   PROTON-838: proton-hawtdispatch cannot connect with SSL
  
   Remove one of calls to transport.connecting() as this causes
   an assert with SslTransport
  
   (cherry picked from commit
f8ca35f3e007b99e0a5365e154e067840adcefb0)
  
   commit ea01c014fedd8dff134131f93b7d957aabac70ec
   Author: Alan Conway acon...@redhat.com
   Date:   Wed Mar 11 11:17:23 2015 -0400
  
   PROTON-836: Missing import SSLUnavailable in reactor.py.
  
   commit 59efe4f6b2ea597332a2191665c498dbf44b8bd8
   Author: Gordon Sim g...@redhat.com
   Date:   Mon Mar 9 14:37:35 2015 +
  
   NO-JIRA: lack of ssl support should not prevent Container being
used
  
   commit 27851a6d979342178817734423b83b37840a
   Author: Robert Gemmell rob...@apache.org
   Date:   Mon Mar 9 19:36:06 2015 +
  
   add missing NOTICE file
  
   cherry-picked from 36e32d2309bb0a96e63e9874758de8906a22ec69
  
   commit 77403b3c091b2c6dfcc766d978130a34f765ee29
   Author: Kenneth Giusti kgiu...@apache.org
   Date:   Mon Mar 9 13:38:56 2015 -0400
  
   NO-JIRA: fix documentation build
  
   (cherry picked from commit
bc2b630eb969710b04a861797567ab2dc368020a)
 
  -
  To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
  For additional commands, e-mail: users-h...@qpid.apache.org
 
 



[jira] [Updated] (PROTON-834) proton-j: UTF-8 encoder reporting some three byte characters as invalid surrogates

2015-03-16 Thread Dominic Evans (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominic Evans updated PROTON-834:
-
Fix Version/s: (was: 0.9)

 proton-j: UTF-8 encoder reporting some three byte characters as invalid 
 surrogates
 --

 Key: PROTON-834
 URL: https://issues.apache.org/jira/browse/PROTON-834
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.8
Reporter: Dominic Evans
Assignee: Dominic Evans

 Following on from the fixes made under PROTON-576, some UTF-8 characters were 
 getting incorrectly reported as invalid surrogates, when they were valid 
 3-byte encodings.
 e.g.,
 !!!
 (╯°□°)╯︵ ┻━┻
 etc.
 This is an issue when streaming variable content such as Twitter messages 
 which can often contain such characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-16 Thread astitcher
Github user astitcher commented on the pull request:

https://github.com/apache/qpid-proton/pull/11#issuecomment-81887757
  
I think you new pn_data_size() possibly has the wrong side effects - it 
seems to lose the pn_data cursor position, so that merely querying the size 
will be hard to intermix with appending to the pn_data. It is true that this is 
not something the current code ever does does, but I think making the query 
function have side effects (except caching the size itself perhaps) is 
unexpected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---