[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152336#comment-15152336
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user ganeshmurthy closed the pull request at:

https://github.com/apache/qpid-proton/pull/64


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134548#comment-15134548
 ] 

ASF subversion and git services commented on PROTON-1126:
-

Commit 0c8ba1df78fac9bebfda6b08f88105ff1b20d219 in qpid-proton's branch 
refs/heads/master from [~gsim]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0c8ba1d ]

PROTON-1126: allow setting of various connection fields. Patch from Ganesh 
Murthy.


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132449#comment-15132449
 ] 

ASF GitHub Bot commented on PROTON-1126:


GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-proton/pull/64

PROTON-1126 - Allowed setting connection properties, offered_capabili…

…ties and desired_capabilities on BlockingConnection

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-proton PROTON-1126

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit ba05b7a10f9941f4e16359ff4b49020545ab3a36
Author: Ganesh Murthy 
Date:   2016-02-04T15:12:28Z

PROTON-1126 - Allowed setting connection properties, offered_capabilities 
and desired_capabilities on BlockingConnection




> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132953#comment-15132953
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931527
  
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -671,7 +671,11 @@ def connect(self, url=None, urls=None, address=None, 
handler=None, reconnect=Non
 """
 conn = self.connection(handler)
 conn.container = self.container_id or str(generate_uuid())
-
+
+conn.offered_capabilities = kwargs.get('offered_capabilities')
+conn.desired_capabilities = kwargs.get('desired_capabilities')
+conn.properties = kwargs.get('properties')
--- End diff --

looks good


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132951#comment-15132951
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931488
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
 Wrapper.__init__(self, impl, pn_connection_attachments)
 
-  def _init(self):
+  def _init(self, **kwargs):
--- End diff --

don't need this


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132949#comment-15132949
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931427
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
--- End diff --

don't need this


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132956#comment-15132956
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931699
  
--- Diff: tests/python/proton_tests/utils.py ---
@@ -72,6 +76,24 @@ def wait(self):
 self.event.wait(self.timeout)
 
 
+class ConnPropertiesServer(EchoServer):
+ def __init__(self, url, timeout):
+EchoServer.__init__(self, url, timeout)
+self.properties_received = False
+self.offered_capabilities_received = False
+self.desired_capabilities_received = False
+
+ def on_link_opening(self, event):
--- End diff --

this is fine; could also be on_connection_opening which might be clearer in 
intent, but this works also


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

[Ganesh Murthy (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131013#comment-15131013
 ] 

Ganesh Murthy commented on PROTON-1126:
---

See if you can also allow setting the offered_capabilities and 
desired_capabilities

> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)