Re: Can we land heycam's WebIDL tests as-is and address review comments following?

[Simon Pieters]

On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang  
 wrote:



Hi,

2+ years ago, heycam submitted WebIDL tests at

https://github.com/w3c/web-platform-tests/pull/271

These tests have been reviewed by several guys but get no update ever  
since.


I wonder if we could land the tests as-is and address the review  
comments in further pull requests? Then we can make a test suite to  
advance the specification and for people to understand the specification.


Thoughts?

Thanks,
Zhiqiang


Personally I don't object to that plan, but an alternative is to create a  
new branch in w3c/web-platform-tests with these changes, and anyone with  
push access to w3c/web-platform-tests can make changes to that branch, and  
then we can merge to master when it's ready.


git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force
git checkout -b webidl-tests origin/pr/271
git push -u origin webidl-tests

--
Simon Pieters
Opera Software

RE: Can we land heycam's WebIDL tests as-is and address review comments following?

[Zhang, Zhiqiang]

Travis,

Great. Glad to hear that you are working on the tests.

Perhaps you can try Simon' method to make your update in a new branch in 
w3c/web-platform-tests, so that others can make updates together.

Thanks,
Zhiqiang

From: Travis Leithead [mailto:travis.leith...@microsoft.com]
Sent: Monday, December 21, 2015 11:44 PM
To: Simon Pieters ; public-webapps ; 
Zhang, Zhiqiang ; Yves Lafon 
Subject: RE: Can we land heycam's WebIDL tests as-is and address review 
comments following?


Yves and I have been reviewing these tests and revising them according to 
recent WebIDL changes and we think they may be ready to be integrated. The 
updates are in a PR on heycams page. Let's not integrate heycam's original PR 
until our update is done first please...







From: Simon Pieters
Sent: Monday, December 21, 2015 1:13 AM
To: public-webapps; Zhang, 
Zhiqiang
Subject: Re: Can we land heycam's WebIDL tests as-is and address review 
comments following?


On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang
> wrote:

> Hi,
>
> 2+ years ago, heycam submitted WebIDL tests at
>
> https://github.com/w3c/web-platform-tests/pull/271
>
> These tests have been reviewed by several guys but get no update ever
> since.
>
> I wonder if we could land the tests as-is and address the review
> comments in further pull requests? Then we can make a test suite to
> advance the specification and for people to understand the specification.
>
> Thoughts?
>
> Thanks,
> Zhiqiang

Personally I don't object to that plan, but an alternative is to create a
new branch in w3c/web-platform-tests with these changes, and anyone with
push access to w3c/web-platform-tests can make changes to that branch, and
then we can merge to master when it's ready.

 git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force
 git checkout -b webidl-tests origin/pr/271
 git push -u origin webidl-tests

--
Simon Pieters
Opera Software

Re: [WebIDL] T[] migration

[Simon Pieters]

On Fri, 18 Dec 2015 18:04:27 +0100, Olli Pettay  wrote:


On 12/18/2015 06:20 PM, Domenic Denicola wrote:

From: Simon Pieters [mailto:sim...@opera.com]


Note that it requires liveness. Does that work for a frozen array?


Frozen array instances are frozen and cannot change. However, you can  
have the property that returns them start returning a new frozen array.  
The spec needs to track when these new instances are created.



Changing the array object wouldn't be backwards compatible.
(The attribute used to be DOMStringList)

Maybe this particular API should be a method instead that returns a  
sequence?

Also not backwards compatible.

But I'd assume the first option (changing the array) would be less  
backwards incompatible, so I'd prefer that one.


OK, but... Document#styleSheetSets is not widely implemented, and appears  
to not be widely used. On github I see 80 code matches in javascript,  
where most are just listing stuff, some are browser sniffing, and some  
might be actual usage (maybe with a fallback for other browsers?).  
Although it has been implemented in Gecko for a long time, I think it is  
possible to make incompatible changes (or maybe drop altogether).


--
Simon Pieters
Opera Software

RE: Can we land heycam's WebIDL tests as-is and address review comments following?

[Travis Leithead]

Yves and I have been reviewing these tests and revising them according to 
recent WebIDL changes and we think they may be ready to be integrated. The 
updates are in a PR on heycams page. Let’s not integrate heycam’s original PR 
until our update is done first please…







From: Simon Pieters
Sent: Monday, December 21, 2015 1:13 AM
To: public-webapps; Zhang, 
Zhiqiang
Subject: Re: Can we land heycam's WebIDL tests as-is and address review 
comments following?



On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang
 wrote:

> Hi,
>
> 2+ years ago, heycam submitted WebIDL tests at
>
> https://github.com/w3c/web-platform-tests/pull/271
>
> These tests have been reviewed by several guys but get no update ever
> since.
>
> I wonder if we could land the tests as-is and address the review
> comments in further pull requests? Then we can make a test suite to
> advance the specification and for people to understand the specification.
>
> Thoughts?
>
> Thanks,
> Zhiqiang

Personally I don't object to that plan, but an alternative is to create a
new branch in w3c/web-platform-tests with these changes, and anyone with
push access to w3c/web-platform-tests can make changes to that branch, and
then we can merge to master when it's ready.

 git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force
 git checkout -b webidl-tests origin/pr/271
 git push -u origin webidl-tests

--
Simon Pieters
Opera Software