Jira (FACT-2944) During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname
Title: Message Title Glenn Sarti commented on FACT-2944 Re: During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname Ahh ok... works on Windows due to Puppet Gem bringing in FFI but this is on Debian. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.387583.1613309929000.178080.161715930%40Atlassian.JIRA.
Jira (FACT-2944) During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname
Title: Message Title Glenn Sarti commented on FACT-2944 Re: During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname Okay ... certname is a red herring. This is facter gem, so there's no certificate to get the name of But ... ``` root@b9b108b35f62:/workspaces/puppet-editor-services# bundle exec facter certname hostname fqdn --debug [2021-03-31 02:38:47.739512 ] INFO Facter - executed with command line: certname hostname fqdn --debug [2021-03-31 02:38:47.739580 ] DEBUG Facter - Facter version: 4.0.52 [2021-03-31 02:38:47.741917 ] DEBUG Facter::FactLoader - Loading internal facts [2021-03-31 02:38:47.742002 ] DEBUG Facter::FactLoader - Loading all internal facts [2021-03-31 02:38:47.742141 ] DEBUG Facter::FactLoader - Loading external facts [2021-03-31 02:38:47.742198 ] DEBUG Facter::FactLoader - Loading custom facts [2021-03-31 02:38:47.744542 ] DEBUG Facter::FactLoader - Loading external facts [2021-03-31 02:38:47.744661 ] DEBUG Facter::QueryParser - User query is: ["certname", "hostname", "fqdn"] [2021-03-31 02:38:47.744700 ] DEBUG Facter::QueryParser - Query is certname [2021-03-31 02:38:47.744724 ] DEBUG Facter::QueryParser - Checking query tokens certname [2021-03-31 02:38:47.745685 ] DEBUG Facter::QueryParser - List of resolvable facts: [] [2021-03-31 02:38:47.745742 ] DEBUG Facter::QueryParser - Query is hostname [2021-03-31 02:38:47.745767 ] DEBUG Facter::QueryParser - Checking query tokens hostname [2021-03-31 02:38:47.746930 ] DEBUG Facter::QueryParser - List of resolvable facts: [#] [2021-03-31 02:38:47.746985 ] DEBUG Facter::QueryParser - Query is fqdn [2021-03-31 02:38:47.747012 ] DEBUG Facter::QueryParser - Checking query tokens fqdn [2021-03-31 02:38:47.748081 ] DEBUG Facter::QueryParser - List of resolvable facts: [#] [2021-03-31 02:38:47.748173 ] DEBUG Facter::InternalFactManager - Resolving facts sequentially [2021-03-31 02:38:47.749962 ] DEBUG Facter::Resolvers::Linux::Hostname - resolving fact hostname, but cannot load such file – ffi [2021-03-31 02:38:47.751378 ] DEBUG Facter::Resolvers::Linux::Hostname - resolving fact fqdn, but cannot load such file – ffi [2021-03-31 02:38:47.751526 ] DEBUG Facter::LegacyFactFormatter - Formatting for multiple user queries [2021-03-31 02:38:47.751608 ] DEBUG Facter::LegacyFactFormatter - Converting hash to pretty json [2021-03-31 02:38:47.751671 ] DEBUG Facter::LegacyFactFormatter - Change key value delimiter from : to => [2021-03-31 02:38:47.751718 ] DEBUG Facter::LegacyFactFormatter - Remove quotes from parent nodes [2021-03-31 02:38:47.751820 ] DEBUG Facter::LegacyFactFormatter - Remove double backslashes from paths [2021-03-31 02:38:47.751897 ] DEBUG Facter::LegacyFactFormatter - Removing enclosing accolades [2021-03-31 02:38:47.751954 ] DEBUG Facter::LegacyFactFormatter - Remove empty lines [2021-03-31 02:38:47.752012 ] DEBUG Facter::LegacyFactFormatter - Fix indentation after removing enclosed accolades [2021-03-31 02:38:47.752064 ] DEBUG Facter::LegacyFactFormatter - remove comas from query results [2021-03-31 02:38:47.752115 ] DEBUG Facter::LegacyFactFormatter - Remove unnecessary comma and quotation marks on root facts [2021-03-31 02:38:47.752192 ] DEBUG Facter::LegacyFactFormatter - Convert newline characters to actual newlines [2021-03-31 02:38:47.752253 ] DEBUG Facter::LegacyFactFormatter - Remove quotes from value if value is a string certname => fqdn => hostname => root@b9b108b35f62:/workspaces/puppet-editor-services# bundle exec facter certname hostname fqdn --debug ``` It appears I don't have ffi available... But Facter has no dependency on FFI so.. how is this supposed to work?
Jira (FACT-2944) During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname
Title: Message Title Glenn Sarti commented on FACT-2944 Re: During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname Also missing certname ``` root@b9b108b35f62:/workspaces/puppet-editor-services# bundle exec facter certname hostname fqdn certname => fqdn => hostname => root@b9b108b35f62:/workspaces/puppet-editor-services# ``` Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.387583.1613309929000.178078.1617158280023%40Atlassian.JIRA.
Jira (FACT-2944) During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname
Title: Message Title
Glenn Sarti commented on FACT-2944
Re: During Puppet 7 upgrade from Puppet 6, Puppet Server create another certname
Josh Cooper I'm also seeing odd behaviour in Facter 4.0.52. (4.0.51 works just fine) I'm missing the fqdn and hostname legacy facts. ``` root@b9b108b35f62:/workspaces/puppet-editor-services# bundle exec facter --show-legacy architecture => amd64 blockdevice_sda_model => Virtual Disk blockdevice_sda_size => 274877906944 blockdevice_sda_vendor => Msft blockdevice_sdb_model => Virtual Disk blockdevice_sdb_size => 274877906944 blockdevice_sdb_vendor => Msft ... facterversion => 4.0.52 filesystems => btrfs,ext2,ext3,ext4,iso9660,msdos,squashfs,vfat,xfs fips_enabled => false gid => root hardwareisa => unknown hardwaremodel => x86_64 hypervisors => { docker => { id => "b9b108b35f6204f72f262d70a6e1967a89d5fd8802de0618d737161581433939" } } id => root identity => { gid => 0, group => "root", privileged => true, uid => 0, user => "root" } interfaces => eth0,lo,sit0 ipaddress => 172.17.0.2 ... ``` This is running on Debian 10.7. Running Puppet and Facter as a gem. Puppet agent NOT installed.
First seen as failing integration tests for https://github.com/puppetlabs/puppet-editor-services/runs/2228454033
Found that the output from Facter was missing hostname (which is what I'm testing for)
Reproduction steps
Requires Docker, VS Code and the VS Code Remote Containers extension
Clone https://github.com/puppetlabs/puppet-editor-services
Start VS Code and "Reopen in Container". This starts the editor inside inside a docker container. You could also shortcut this by running the Dockerfile directly (https://github.com/puppetlabs/puppet-editor-services/blob/main/.devcontainer/Dockerfile)
bundle install
bundle exec facter --show-legacy
Add Comment
Jira (FACT-2553) Backslashes are handled differently in facter-ng
Title: Message Title Glenn Sarti commented on FACT-2553 Re: Backslashes are handled differently in facter-ng Ah, just remember that UNC paths are double backslashed e.g. \\Server\Path So a double backslash isn't always wrong. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.355508.1586884614000.39938.1587041400025%40Atlassian.JIRA.
Jira (PUP-10356) Empty YAML files cause warnings in yaml_data and eyaml_lookup_key functions
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-10356 Empty YAML files cause warnings in yaml_data and eyaml_lookup_key functions Change By: Glenn Sarti *Puppet Version: 6.x* *Puppet Server Version: N/A* *OS Name/Version:* When using a valid but empty YAML file in the hiera hierarchy the logs spew out a lot of warnings about expecting a hash.While I can understand the warnings when there's a type mismatch (e.g. Got a String instead of a Hash), and but an empty file is deliberate act with no data (e . g. commenting everything out). Therefore Puppet should not raise a warning for empty YAML files. *Desired Behavior:*Empty YAML files do not raise warnings*Actual Behavior:* Warnings can be seen in puppet apply or puppet agent command Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-10356) Empty YAML files cause warnings in yaml_data and eyaml_lookup_key functions
Title: Message Title Glenn Sarti created an issue Puppet / PUP-10356 Empty YAML files cause warnings in yaml_data and eyaml_lookup_key functions Issue Type: Bug Assignee: Unassigned Created: 2020/03/04 6:17 PM Environment: N/A Priority: Normal Reporter: Glenn Sarti Puppet Version: 6.x Puppet Server Version: N/A OS Name/Version: When using a valid but empty YAML file in the hiera hierarchy the logs spew out a lot of warnings about expecting a hash. While I can understand the warnings when there's a type mismatch (e.g. Got a String instead of a Hash), and empty file is deliberate act with no data. Therefore Puppet should not raise a warning for empty YAML files. Desired Behavior: Empty YAML files do not raise warnings Actual Behavior: Warnings can be seen in puppet apply or puppet agent command Add Comment
Jira (BOLT-1535) Error with bolt when running Concat module against windows machines
Title: Message Title Glenn Sarti commented on BOLT-1535 Re: Error with bolt when running Concat module against windows machines Also David Swan I believe the bolt team now use GitHub Issues, not this Jira project. FYI - Lucy Wyman Lucy Wyman Lucy Wyman (Why are you here three times?) and Alex Dreyer Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344205.1580376983000.2077.1583207340271%40Atlassian.JIRA.
Jira (BOLT-1535) Error with bolt when running Concat module against windows machines
Title: Message Title Glenn Sarti commented on BOLT-1535 Re: Error with bolt when running Concat module against windows machines Have you got the raw manifest you're trying to apply? as point of reference Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344205.1580376983000.2069.1583206740024%40Atlassian.JIRA.
Jira (BOLT-1535) Error with bolt when running Concat module against windows machines
Title: Message Title Glenn Sarti commented on BOLT-1535 Re: Error with bolt when running Concat module against windows machines David Swan I'm curious what would happen if you ran that in a proper windows shell as opposed to running in Cygwin. Cygwin does some "weird" stuff sometimes. Although I see that raw Bolt has a similar problem which is not using cygwin (PowerShell remoting) so I suspect it's similar. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344205.1580376983000.2068.1583206200112%40Atlassian.JIRA.
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti commented on PUP-9090 Re: Puppet apply causes a Stack Level too deep on Windows (include function) Update - This also occurs when using the Shortpath name of the directory e.g. C:\PROGRA~1\PUPPET~1 Puppet 6.12.0 Puppet 6.10.0 Ruby 2.5.7 (Packaged under PDK) Josh Cooper Ethan Brown Not looking for a solution, but confirmation that running under a shortpath name should work? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.273288.1535532069000.34237.1579746060377%40Atlassian.JIRA.
Jira (PUP-10229) Puppet 6 (agent) is noticeably slower on Windows than Puppet 5
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-10229 Puppet 6 (agent) is noticeably slower on Windows than Puppet 5 Change By: Glenn Sarti Attachment: puppet6-slow1.gif Attachment: puppet6-slow2.gif Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341629.1578624899000.18983.1578625020093%40Atlassian.JIRA.
Jira (PUP-10229) Puppet 6 (agent) is noticeably slower on Windows than Puppet 5
Title: Message Title Glenn Sarti commented on PUP-10229 Re: Puppet 6 (agent) is noticeably slower on Windows than Puppet 5 Ruby versions used 2.4.3-2-x64 : ruby 2.4.3p205 (2017-12-14 revision 61247) [x64-mingw32] 2.5.1-2-x64 : ruby 2.5.1p57 (2018-03-29 revision 63029) [x64-mingw32] Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341629.1578624899000.18984.1578625020144%40Atlassian.JIRA.
Jira (PUP-10229) Puppet 6 is noticeably slower on Windows than Puppet 5
Title: Message Title Glenn Sarti created an issue Puppet / PUP-10229 Puppet 6 is noticeably slower on Windows than Puppet 5 Issue Type: Bug Assignee: Unassigned Created: 2020/01/09 6:54 PM Priority: Normal Reporter: Glenn Sarti Puppet Version: 6.11.1, 5.x Puppet Server Version: N/A OS Name/Version: Windows 10 1903 Describe your issue in as much detail as possible… Describe steps to reproduce… Desired Behavior: When running seemingly simple CLI tasks like --version Puppet 6 and Puppet 5 should be fast and have similar response times Actual Behavior: Puppet 6 is significantly slower I've attached screen casts Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-10229) Puppet 6 (agent) is noticeably slower on Windows than Puppet 5
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-10229 Puppet 6 (agent) is noticeably slower on Windows than Puppet 5 Change By: Glenn Sarti Summary: Puppet 6 (agent) is noticeably slower on Windows than Puppet 5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341629.1578624899000.18982.1578624960218%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces Looks good so far... what about the other puppet stack entries? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.11506.1578032580180%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces Ahh ok found it!! https://github.com/puppetlabs/puppet/blob/6.10.1/lib/puppet/pops/puppet_stack.rb#L21 PP_ENTRY_PATTERN = /^(.*\.pp)?:([0-9]+):in (`stack'|`block in call_function'|`')/ The regex wouldn't match it therefore in 6.10.1 it doesn't appear in the Puppet::Pops::PuppetStack.stacktrace call. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.42761.1574414820174%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces Ahh ok I think (Could be wrong here) is that line number 0s aren't output in the error message which is why I see C:/Source/puppet/lib/puppet/pops/evaluator/evaluator_impl.rb:81:in `evaluate' C:/Source/puppet/tmp/test.pp:in `stack' C:/Source/puppet/lib/puppet/pops/puppet_stack.rb:33:in `eval' Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces > Glenn Sarti Are you saying all reported lines are off by one? No. the stack had an extra entry in it, compared to Puppet 6.10. Using the example in the ticket description I'm seeing this in the Puppet::Pops::PuppetStack.stacktrace [ ['C:/Source/puppet/tmp/test.pp', 9], ['/C:/Source/puppet/tmp/test.pp', 6], ['C:/Source/puppet/tmp/test.pp', 2], ['C:/Source/puppet/tmp/test.pp', 0] ] In 6.10, the only stack entries that had line numbers were the 9,6 and 2 ones. This Line Number 0 stack entry is new and I believe it's coming from here: https://github.com/puppetlabs/puppet/blob/aaebc6cd3769c937f7da59320daadfa68ca8da23/lib/puppet/pops/evaluator/evaluator_impl.rb#L732-L744 def eval_Program(o, scope) begin file = o.locator.file line = 0 # Add stack frame for "top scope" logic. See Puppet::Pops::PuppetStack return Puppet::Pops::PuppetStack.stack(file, line, self, 'evaluate', [o.body, scope]) #evaluate(o.body, scope)
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces Something else I noticed is that the new Stack uses line number 0 for the entrypoint into a manifest which is a change of behaviour. This is important because Puppet uses Base 1 line numbers so a line number of 0 isn't valid. Perhaps nil? or even ignore it? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.42695.1574401680578%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces > Is that the value in a Puppet only stack or both interleaved? Puppet stack probably. Maybe more complicated but perhaps `-debug` shows puppet stack and `-trace` shows interleaved? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.42685.1574399400260%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces As for the questions in the puppet-dev email: > Is interleaving the Puppet stack trace into the Ruby stack trace valuable to most users (and should go back to being the default)? It's very useful as a Puppet developer, and for Customer Support escalating to engineering. But as a beginner/intermediate user, the stack trace from ruby is over-whelming. > Are there workflows where you'd like to see just one (the Puppet stack), the other (Ruby), or both (ie, do we need more trace options, and if so how important are they relative to each other)? Debugging Control Repos, seeing which manifests call others, is very useful. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.42671.1574395380298%40Atlassian.JIRA.
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title Glenn Sarti commented on PUP-10150 Re: Ruby stacktraces no longer interleave Puppet Code stacktraces I like the idea of extending ExternalFileError class I did a quick proof of concept for it C:\Source\puppet [master ≡ +0 ~4 -0 !]> be puppet apply tmp\test.pp Warning: Facter: Fact resolution fact='puppet_classes', resolution='' resolved to an invalid value: Expected all to be one of [Integer, Float, TrueClass, FalseClass, NilClass, String, Array, Hash], but was Symbol STACK PUSH STACK CALLING #>.evaluate Puppet::Pops::Evaluator::EvaluatorImpl STACK PUSH STACK CALLING #<#:0x076a4d00 @closure_scope=nil, @loader=(ModuleLoader::FileBased 'puppet_system' '')>.call include STACK PUSH STACK CALLING #<#:0x076a4d00 @closure_scope=nil, @loader=(ModuleLoader::FileBased 'puppet_system' '')>.call include STACK PUSH STACK CALLING #<#:0x076874a8 @closure_scope=nil, @loader=(ModuleLoader::FileBased 'puppet_system' '')>.call fail CALLING function 3x function_fail
Jira (PUP-10150) Ruby stacktraces no longer interleave Puppet Code stacktraces
Title: Message Title
Glenn Sarti commented on PUP-10150
Re: Ruby stacktraces no longer interleave Puppet Code stacktraces
I'll add some more context as to how I found this. The VSCode extension offers a debugging facility. As part of that, when an exception occurs it queries the current call stack. Internally in the Debug Server, I've monkey patched the compiler so I can trap the exception and then query the available Puppet Stack. As per my original ticket title, because the PuppetStack is popped BEFORE the exception is handled I couldn't get access to the Puppet call stack. This behaviour is different to a regular Ruby Stack, where the call stack is not modified. Now I know that my use case is far from normal, and that I'm using monkey patches and private APIs, so any breakages aren't really a Puppet problem. The missing tracing information in the stacktrace as all I could think of from a regular user point of view. Given this nested manifest
class nest1 {
fail('somethinng')
}
class nest2 {
include nest1
}
include nest2
And some basic puts debugging STACK PUSH - An object is pushed onto the PuppetStack STACK CALLING - PuppetStack is calling the actual code. STACK POP - An object is popped onto the PuppetStack So you can see the stack calling the evaluator, then the include function twice, and finally the fail function
Jira (PUP-10150) Puppet Stack Trace is cleared before exception handlers can query it
Title: Message Title
Glenn Sarti created an issue
Puppet / PUP-10150
Puppet Stack Trace is cleared before exception handlers can query it
Issue Type:
Bug
Assignee:
Unassigned
Created:
2019/11/21 6:01 AM
Priority:
Normal
Reporter:
Glenn Sarti
Puppet Version: 6.11.1 Puppet Server Version: N/A OS Name/Version: Windows 10 As part of https://github.com/puppetlabs/puppet/pull/7754 the Puppet Stack Trace feature was modified to use an independent stack trace storing mechanism, however this may have introduced an unforseen behaviour change. Previously users would be able to trace how Puppet has traversed the invocations within a Manifest file. For example int the given manifest
class nest1 {
fail('somethinng')
}
class nest2 {
include nest1
Jira (PUP-9509) Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Change By: Glenn Sarti Release Notes Summary: Legacy Ruby Functions, also known as Version 3 Functions, will now be available from the cached lib directory. Previously only Version functions were available. Note that functions that exist in both Version 3 and Version 4, will still use the Version 4 implementation. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.297090.1550826509000.12019.1572405000379%40Atlassian.JIRA.
Jira (PUP-9509) Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader
Title: Message Title Glenn Sarti commented on PUP-9509 Re: Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Josh Cooper Added. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.297090.1550826509000.12020.1572405000383%40Atlassian.JIRA.
Jira (PUP-10110) SE_Linux Core Module says its supports non-SE Linux operating systems
Title: Message Title Glenn Sarti commented on PUP-10110 Re: SE_Linux Core Module says its supports non-SE Linux operating systems Nagios may have the same issue - https://github.com/puppetlabs/puppetlabs-nagios_core/blob/master/metadata.json#L50-L56 ssh_keys - https://github.com/puppetlabs/puppetlabs-sshkeys_core/blob/master/metadata.json#L75-L81 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.331918.1571886718000.5268.1571886900111%40Atlassian.JIRA.
Jira (PUP-10110) SE_Linux Core Module says its supports non-SE Linux operating systems
Title: Message Title Glenn Sarti created an issue Puppet / PUP-10110 SE_Linux Core Module says its supports non-SE Linux operating systems Issue Type: Bug Assignee: Unassigned Created: 2019/10/23 8:11 PM Environment: N/A Priority: Minor Reporter: Glenn Sarti The metadata.json for the SELinux core module states it supports OSes like Windows and Darwin. This seems like a bug. Surely the SE Linux module only supports SE Linux https://github.com/puppetlabs/puppetlabs-selinux_core/blob/master/metadata.json#L12-L81 Add Comment
Jira (PDOC-294) Improve Type Alias Docs - Parameter Support
Title: Message Title
Glenn Sarti updated an issue
Puppet Strings / PDOC-294
Improve Type Alias Docs - Parameter Support
Change By:
Glenn Sarti
*As a* Module Developer *I want* to be able to document my type alias struct parameters *So that* my module consumers can understand the purpose of the struct and each parameter within it.Possibly related to PDOC-226 & PDOC-215[~ Glenn Sarti glenn.sarti ] asked me to C/P our slack discussion so that there would be context of the desired feature capability. (see Below). [bstopp|https://app.slack.com/team/U7C8ALC4T] [10:07 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846078031300]I was thinking that the {{alias}} could/should be replaced if i provide any {{@param}} directives. And maybe then pdk can raise a warning about not having any custom param descriptions for {{type => structs}} and an error if one param description is provided but not _all_ are defined? WDYT?[10:09 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846151033100]the alias is informational but not very useful to consumers - module developers should be providing meaningful docs on the params in the structs [Glenn Sarti|https://app.slack.com/team/U1154M24W] [10:09 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846155033200]firstly, I think I understand your concern...what I'm thinking is, that _technically_ those are data type aliases. So I'm trying to figure out what the ramifications are[10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846206033900]I wonder if Yard even cares ... [bstopp|https://app.slack.com/team/U7C8ALC4T] [10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846210034000]maybe i’m abusing the type aliases !https://a.slack-edge.com/production-standard-emoji-assets/10.2/apple-medium/1f...@2x.png! [Glenn Sarti|https://app.slack.com/team/U1154M24W] [10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846217034300]Nah... you're not[10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846223034500]as in what you're doing is legit[10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846227034700]!https://a.slack-edge.com/production-standard-emoji-assets/10.2/apple-large/1f...@2x.png![bstopp|https://app.slack.com/team/U7C8ALC4T] [10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846235035200]!https://a.slack-edge.com/production-standard-emoji-assets/10.2/apple-large/1f...@2x.png! [Glenn Sarti|https://app.slack.com/team/U1154M24W] [10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846241035500]it's that this isn't the only case[10:10 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846252036000]Struct, Object and I think another one will have the same problem[10:11 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846271036800]but parsing that it going to be a major pain in the bum (edited) [10:11 PM|https://puppetcommunity.slack.com/archives/C11LCKKQ9/p1570846282037300]e.g. what if you had nested
Jira (BOLT-1357) Reduce install size of bolt
Title: Message Title Glenn Sarti commented on BOLT-1357 Re: Reduce install size of bolt Cross reference : https://github.com/puppetlabs/bolt/issues/1177 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.310851.1559272757000.76035.1566962940154%40Atlassian.JIRA.
Jira (BOLT-1429) Inconsistent behavior in Boltspec::Run.run_command on Windows
Title: Message Title Glenn Sarti commented on BOLT-1429 Re: Inconsistent behavior in Boltspec::Run.run_command on Windows Yasmin Rajabi I feel it's still important. Having a different shell between local and remote commands is annoying (at best) and confusing. Also adding "powershell.exe -noprofile -NoLogo -ExecutionPolicy Bypass -Command" as a workaround is far from a great UX. Also using -Command has known peculiarities with regards to exit codes, double quoting, multiline commands etc. etc. Using the PowerShell Process sharing gem (which powers the IIS, DSC, DSC_Lite and PowerShell Puppet module) is a much much better idea. Note that while it "shares" the same process, each execution is in it's own sandbox (PowerShell Runspace to be exact) So I think this addresses Alex Dreyer's concern about "state" being left around. As for Alex's comment about "Would that be implemented for winrm too?" I don't understand the question. WinRM is a transport not a shell. What state in WinRM are you worried about? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.314131.1561529132000.76013.1566961560266%40Atlassian.JIRA.
Jira (PDOC-285) Infer missing docs types from arguments
Title: Message Title Glenn Sarti commented on PDOC-285 Re: Infer missing docs types from arguments PR is at https://github.com/puppetlabs/puppet-strings/pull/209 In the example above, it was missing a comma in the interface spec. This PR will fix that issue. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.318762.1564488282000.35882.1564492800083%40Atlassian.JIRA.
Jira (PDOC-285) Infer missing docs types from arguments
Title: Message Title
Glenn Sarti created an issue
Puppet Strings / PDOC-285
Infer missing docs types from arguments
Issue Type:
Improvement
Assignee:
Unassigned
Created:
2019/07/30 5:04 AM
Priority:
Normal
Reporter:
Glenn Sarti
Given a manifest of
# A Puppet Data Type in Ruby.
#
# @param arg1 [String] String A message parameter.
# @param arg2 An Optional Numeric parameter.
Puppet::DataTypes.create_type('ValidModuleDataType') do
interface <<-PUPPET
attributes => {
Jira (BOLT-1156) Bolt's r10k should use %LOCALAPPDATA% for Windows cachedir
Title: Message Title Glenn Sarti commented on BOLT-1156 Re: Bolt's r10k should use %LOCALAPPDATA% for Windows cachedir As an addendum APPDATA will roam with the user (log into different PCs). Also APPDATA honors folder redirection (which is much preferred than the "old" HOMEDRIVE/HOMEPATH env vars) LOCALAPPDATA will NOT roam and is specific to the machine the user is on. As a rule, you should not be constructing the paths, but use the special folders API and/or environment variables (APPDATA, LOCALAPPDATA) for this information Desktop, My Documents etc. can all be redirected and is actually preferred than setting HOMEDRIVE etc. Other note is dot folders (e.g. .r10k) are not hidden on Windows. A common refrain from windows people is stop polluting my profile with dot folders. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.298054.1551469817000.33849.1564401000144%40Atlassian.JIRA.
Jira (FACT-1934) Add OpenSSH host keys to core facts for Windows
Title: Message Title Glenn Sarti updated an issue Facter / FACT-1934 Add OpenSSH host keys to core facts for Windows Change By: Glenn Sarti Acceptance Criteria: * When OpenSSH Server is installed on Windows Desktop (typically 10 ) and Serve Windows Server (e.g. 2019 ) , the host SSH public keys should appear in the core facts Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316044.1562825377000.11983.1562826780170%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1934) Add OpenSSH host keys to core facts for Windows
Title: Message Title Glenn Sarti commented on FACT-1934 Re: Add OpenSSH host keys to core facts for Windows Done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316044.1562825377000.11984.1562826780176%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1934) Add OpenSSH host keys to core facts for Windows
Title: Message Title Glenn Sarti created an issue Facter / FACT-1934 Add OpenSSH host keys to core facts for Windows Issue Type: Improvement Assignee: Unassigned Created: 2019/07/10 11:09 PM Environment: Windows 10/Server 2019 Labels: windows Priority: Normal Reporter: Glenn Sarti The Microsoft port of OpenSSH is now part of the Windows operating system for Windows Server 2019 and Windows 10 https://docs.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse The core facts for ssh should now also look in the default Windows location for the host keys %ALLUSERSPROFILE%\ssh\... and populate the facts. Recommendation from puppet-users https://groups.google.com/forum/?utm_medium=email_source=footer#!msg/puppet-users/-irkkbzrUZw/wPR9o8QHDAAJ Add Comment
Jira (PDOC-283) Yard gem 0.9.20 causes name spaced puppet functions to render wrong
Title: Message Title Glenn Sarti commented on PDOC-283 Re: Yard gem 0.9.20 causes name spaced puppet functions to render wrong PR is ready for merge. https://github.com/puppetlabs/puppet-strings/pull/205 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.314689.1561754673000.1505.1561945560118%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-283) Yard gem 0.9.20 causes name spaced puppet functions to render wrong
Title: Message Title Glenn Sarti commented on PDOC-283 Re: Yard gem 0.9.20 causes name spaced puppet functions to render wrong WIP PR https://github.com/puppetlabs/puppet-strings/pull/205 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.314689.1561754673000.1406.156179776%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-283) Yard gem 0.9.20 causes name spaced puppet functions to render wrong
Title: Message Title Glenn Sarti commented on PDOC-283 Re: Yard gem 0.9.20 causes name spaced puppet functions to render wrong Commit that caused the issue - https://github.com/lsegal/yard/commit/225ded9ef38c6d2be5a3b0fc7effbc7d6644768d Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.314689.1561754673000.1404.1561796940079%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-1357) Reduce install size of bolt
Title: Message Title Glenn Sarti created an issue Puppet Task Runner / BOLT-1357 Reduce install size of bolt Issue Type: Improvement Assignee: Unassigned Created: 2019/05/30 8:19 PM Environment: Windows 10 1903 Priority: Normal Reporter: Glenn Sarti I've noticed that bolt is getting longer to install on Windows due to the sheer number of files it lays down on disk. We've come across this in the PDK packaging and Tim Sharpe added a gem-prune script to remove files like spec, test etc. from the vendored gems to help remove the bloat. Because bolt is just a runtime, so there's no need for these files which are never actually used Add Comment
Jira (PUP-9509) Puppet 3 API functions should be loaded from thepluginsync location as part of the cache system loader
Title: Message Title
Glenn Sarti updated an issue
Puppet / PUP-9509
Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader
Change By:
Glenn Sarti
*Puppet Version:* 6.3.0*Puppet Server Version:* N/A*OS Name/Version:* Windows 10 - 1803 Ruby 2.5Describe your issue in as much detail as possible...Describe steps to reproduce...*Desired Behavior:*Puppet 3 API functions that are plugin sync'd should be loaded from the cache libdir*Actual Behavior:*Puppet 3 API functions are missingPreviously in PUP-6964 (https://github.com/puppetlabs/puppet/pull/7019) the system loader was modified to to be able to load Puppet 3 API functions;of note - https://github.com/puppetlabs/puppet/pull/7019/files#diff-83a8daf215ff39828e0e3758c2e5a866R34See how the system loader has loadables of { { [:func_4x, :func_3x, :datatype]} } However when the system cache loader was introduced in PUP-9035 (https://github.com/puppetlabs/puppet/commit/7404ee14745c78bd4a3173c79cac198809faea74 ) the loadables specified did not include the Puppet 3 API functions.of note - https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R30See how the cache loader has loadables of { { [:func_4x, :datatype]} } The comment at https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R22 says they should be the same but is clear they are not.Also note that the acceptance tests do not test for this;https://github.com/puppetlabs/puppet/pull/6963/files#diff-d3791ca879b2c6c0586dd8974a7bec0eR25That is just a Puppet 4 API location
Add Comment
Jira (PUP-9509) {brief summary of issue}
Title: Message Title
Glenn Sarti created an issue
Puppet / PUP-9509
{brief summary of issue}
Issue Type:
Bug
Assignee:
Unassigned
Created:
2019/02/22 1:08 AM
Environment:
Windows 10 - 1803 Ruby 2.5.1 Puppet from github at 293b87447ff955bb4c866b5b0eda3a23e5901ff2
Priority:
Normal
Reporter:
Glenn Sarti
Puppet Version: 6.3.0 Puppet Server Version: N/A OS Name/Version: Windows 10 - 1803 Ruby 2.5 Describe your issue in as much detail as possible... Describe steps to reproduce... Desired Behavior: Puppet 3 API functions that are plugin sync'd should be loaded from the cache libdir Actual Behavior: Puppet 3 API functions are missing Previously in PUP-6964 (https://github.com/puppetlabs/puppet/pull/7019) the system loader was modified to to be able to load Puppet 3 API functions; of note - https://github.com/puppetlabs/puppet/pull/7019/files#diff-83a8daf215ff39828e0e3758c2e5a866R34 See how the system loader has loadables of {[:func_4x, :func_3x, :datatype]} However when the system cache loader was introduced in PUP-9035 (https://github.com/puppetlabs/puppet/commit/7404ee14745c78bd4a3173c79cac198809faea74 ) the loadables specified did not include the Puppet 3 API functions. of note - https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R30 See how the cache loader has loadables of {[:func_4x, :datatype]} The comment at https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R22 says they should be the same but is clear they are not. Also note that the acceptance tests do not test for this; https://github.com/puppetlabs/puppet/pull/6963/files#diff-d3791ca879b2c6c0586dd8974a7bec0eR25 That is just a Puppet 4 API location
Jira (PUP-9509) Puppet 3 API functions should be loaded from thepluginsync location as part of the cache system loader
Title: Message Title
Glenn Sarti updated an issue
Puppet / PUP-9509
Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader
Change By:
Glenn Sarti
Summary:
{brief summary Puppet 3 API functions should be loaded from the pluginsync location as part of issue} the cache system loader
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9370) Could not evaluate: ADSI connection error: failed to parse display name
Title: Message Title Glenn Sarti commented on PUP-9370 Re: Could not evaluate: ADSI connection error: failed to parse display name Ahh Ok...so you want to CREATE a new user, AND assign to Admins Group, but the username just happens to be the same as a domain account too. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9370) Could not evaluate: ADSI connection error: failed to parse display name
Title: Message Title Glenn Sarti commented on PUP-9370 Re: Could not evaluate: ADSI connection error: failed to parse display name Also you can use SIDs Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9370) Could not evaluate: ADSI connection error: failed to parse display name
Title: Message Title Glenn Sarti commented on PUP-9370 Re: Could not evaluate: ADSI connection error: failed to parse display name Paul H Have you tried prefixing the name with the domain name? e.g. 'DOMAIN\windows_eng' Otherwise ADSI Doesn't know in which domain the user exists e.g. multi forest or local. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1898) Provide core facts or supported module with common Windows paths
Title: Message Title Glenn Sarti commented on FACT-1898 Re: Provide core facts or supported module with common Windows paths Is this solved by FACT-1346 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry Merged into 5.5.x at; https://github.com/puppetlabs/puppet/commit/2b27922b79df7e4f93126d5b301ff18c72918105 Passed CI at; 15fbb8f465bd283a3f0028c5323a49d398fd9467 includes these changes Last known good build of puppet-agent on 5.5.x: Built at: 4 Dec 2018 9:52:59 PUPPET_AGENT_VERSION: 5.5.8.79.g239dafa PUPPET_AGENT_COMMIT: 239dafac020ca6a697bf2c5ac1fb4e548e9b06a4 PUPPET_AGENT_SHORT_COMMIT: 239dafac0 FACTER_COMMIT: 79c5167a0f50a6a837c84d054f373075eab41ea8 PUPPET_COMMIT: 15fbb8f465bd283a3f0028c5323a49d398fd9467 HIERA_COMMIT: 932e32a6730ccb49f800d9c4d7c7b581b30b6680 PXPAGENT_COMMIT: b1fd8b3ac8ef6583a7cb4156c5c4f1e19738f118
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti assigned an issue to Glenn Sarti Puppet / PUP-9312 puppet package provider fails when reading from registry Change By: Glenn Sarti Assignee: Ethan Brown Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti assigned an issue to Unassigned Puppet / PUP-9312 puppet package provider fails when reading from registry Change By: Glenn Sarti Assignee: Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry Ethan Brown Looks good and prefer it to my workaround. It doesn't address the root cause, but I get the impression this is far more edge case and that PR would suffice. i.e. we don't need to deal with being unable to unencode bad UTF16-LE reg data in REG_SZ Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-459) Reboot a target and wait for it to become available.
Title: Message Title Glenn Sarti commented on BOLT-459 Re: Reboot a target and wait for it to become available. Michael Smith Lucy Wyman Alex Dreyer Is this ticket resolved? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry Got a PR up to workaround this for the package provider... Not sure it's the right way though. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9312 puppet package provider fails when reading from registry Change By: Glenn Sarti Story Points: 1 Team: Platform OS Windows Sprint: Windows PupperCon 2018-11-16 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti assigned an issue to Glenn Sarti Puppet / PUP-9312 puppet package provider fails when reading from registry Change By: Glenn Sarti Assignee: Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry Hrmm...so ClaySys AppForms is a .Net app. Looks like IIS and .Net DB classes https://appforms.claysys.com/content/documentation/UnKnownErrorwhenaccessingClaySys.html https://appforms.claysys.com/content/documentation/ClaySysAppFormsEnterpriseVersio1.html So it looks like there's some sort of encryption going on. This makes me think even more that this is series of bytes stored as string Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry An interesting idea, If reading from the registry cannot be encoded from Byte Array -> UTF16 -> UTF8 , should we just assume ASCII-8BIT (aka a bunch-o-bytes) ? Ethan Brown Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title
Glenn Sarti commented on PUP-9312
Re: puppet package provider fails when reading from registry
I saved a text file with string and got the following results; () C:\source\puppet\test.rb SAVED as UTF16-LE (CRLF)
x = '댸歺믶氘㡋ꪡꦖご䈉ﰠ௵㻀샢䗚顉棂툀ꈪ犲꽗刵�둭の�䃜ꅊ쎆�焩떊茰䫈궫곊Չﰌ훩䋧挌䴞厛蒦㭣政霱뤜㾪䃟벻驳锘㳽뉄쒍ⶓ瞫尿ꆛഇ댼헍砀囓册㿑㙧뚙븾־䉓䤈躣�妢ﲵ줄랊�솖㷽ꣴ돤ﲼ�휈ꪉ佂뚬제톎ႀ﹑ༀ꾙땂嗻䪋⸧'
puts x.encoding
puts x
[22] pry(#)> puts File.read('C:\source\puppet\test.rb') x = 'δî╕µ¡║δ»╢ὃµ░ÿπíïΩ¬íΩªûπüöΣêë∩░áα»╡π╗Ç∞âóΣùÜΘíëµúéφêÇεá▒Ωê¬τè▓Ω╜ùσê╡∩┐╜δæ¡πü«∩┐╜Σâ£Ωàè∞Äå∩┐╜τä⌐ε╢ûδûèΦî░Σ½êΩ╢½Ω│è╒ë∩░îφ¢⌐ε╜üαª╡Σïºß᥵îîΣ┤₧σÄ¢εóâΦƪπ¡ú∩ûçµö┐Θ£▒δñ£π╛¬Σâƒδ▓╗Θ⌐│Θöÿπ│╜δëäεªÑ∞ÆìΓ╢ôτ₧½∩ª╜Ωå¢εü╖α┤çδî╝φùìτáÇσ¢ôσåîπ┐æπÖºδÜÖδ╕╛╓╛ΣëôΣñêΦ║ú∩┐╜σªó∩ì¼∩▓╡∞ñäδ₧è∩┐╜∞åûπ╖╜Ωú┤δÅñ∩▓╝∩┐╜∩âåφ£êΩ¬ëΣ╜éδܼ∞á£φåÄßéÇ∩╣æα╝ÇΩ╛Öδòéσù╗Σ¬ïε░£Γ╕º' puts x.encoding puts x => nil [28] pry(#)> puts File.read('C:\source\puppet\test.rb', :encoding => 'UTF-8') ��x = ' 8�zk��� ↑lK8T0 B ��♂�>���EI��h �1�*��rW�5R��m�n0���@J���)q�튵0��J��ʬI♣♀���A� �B↔↑♀c▲M�S�覄c;��?e1�∟��?�@��s�↑�� <��� x�V�Q�?g6��>��♣SI���ݢYl��♦Ɋ�`ٖ��=�䳼�b���BO��∟Ȏр►Q� ☼��B��U�J∟�'.' p u t s x . e n c o d i n g p u t s x => nil [30] pry(#)> puts File.read('C:\source\puppet\test.rb', :encoding => 'UTF-16LE') ArgumentError: ASCII incompatible encoding needs binmode from (pry):30:in `read' Caused by Encoding::InvalidByteSequenceError: "\xB8\xDD" on UTF-16LE from C:/Source/puppet/lib/puppet/util/windows/api_types.rb:59:in `encode' [31] pry(#)>
PowerShell works ok too
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title
Glenn Sarti commented on PUP-9312
Re: puppet package provider fails when reading from registry
Prying into the code.
From: C:/Source/puppet/lib/puppet/util/windows/api_types.rb @ line 62 FFI::Pointer#read_wide_string:
56: def read_wide_string(char_length, dst_encoding = Encoding::UTF_8, encode_options = {})
57: # char_length is number of wide chars (typically excluding NULLs), *not* bytes
58: str = get_bytes(0, char_length * 2).force_encoding('UTF-16LE')
59: str.encode(dst_encoding, str.encoding, encode_options)
60: rescue Exception => e
61: require 'pry'; binding.pry
=> 62: Puppet.debug "Unable to convert value #{str.dump} to encoding #{dst_encoding} due to #{e.inspect}"
63: raise
64: end
[1] pry(#)> x = get_bytes(0, char_length * 2)
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti commented on PUP-9312 Re: puppet package provider fails when reading from registry Repro Windows Server 2012r2 Puppet 5.5.2 (puppet-agent 5.5.3) Ruby 2.4 Extract the registry export 32509_export.reg Ensure that the saved file is UTF16-LE with CRLF line endings Run `puppet agent resource package` Actual Output Error: Could not run: "\xB8\xDD" on UTF-16LE Interestingly, if you delete the registry key, save the file as UTF8 and import, there isn't the same error Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this
Jira (PUP-9312) puppet package provider fails when reading from registry
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9312 puppet package provider fails when reading from registry Change By: Glenn Sarti Attachment: 32509_export.reg Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Glenn Sarti Story Points: 1 Team: Platform OS Windows Sprint: Windows PupperCon 2018-11-16 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Raised PR - https://github.com/puppetlabs/puppet/pull/7243 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9297) Audit and fix locations where set_mode is called with inappropriate permissions on Windows
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9297 Audit and fix locations where set_mode is called with inappropriate permissions on Windows Change By: Glenn Sarti Story Points: 1 Team: Windows Sprint: Windows Grooming Method Found: Needs Assessment Manual Test Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti commented on PUP-9238 Re: pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes As the work Ethan Brown mentioned is out of scope for this particular ticket. I've raised PUP-9297 to track this. This ticket can be closed. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9297) Audit and fix locations where set_mode is called with inappropriate permissions on Windows
Title: Message Title Glenn Sarti created an issue Puppet / PUP-9297 Audit and fix locations where set_mode is called with inappropriate permissions on Windows Issue Type: Bug Assignee: Unassigned Created: 2018/11/01 12:58 AM Environment: Windows 10 - 1803 Puppet 5.5.x gem Ruby 2.4 Priority: Normal Reporter: Glenn Sarti PUP-9216 was merged earlier, which sets System ACE entries to full control. This triggers a failure in pxp-agent's tasks.run_puppet.rb test, specifically here based on the stack trace. Representative job link: https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/Acceptance%20Suites/view/5.5.x/view/Suite/job/platform_puppet-agent_puppet-agent-integration-suite_daily-5.5.x/232/RMM_COMPONENT_TO_TEST_NAME=pxp_agent,SLAVE_LABEL=beaker,TEST_TARGET=windows10ent-64a/ Representative failure output: Successful task expected to have no output on stderr. --- expected +++ actual @@ -1 +1,2 @@ -nil +"\e[1;33mWarning: An attempt to set mode 416 on item C:/ProgramData/PuppetLabs/puppet/cache/reports/xln2koezj7avuqx.delivery.puppetlabs.net/201810110803.yaml would result in the group, SYSTEM, to have less than Full Control rights. This attempt has been corrected to Full Control\e[0m +" — Pull Request https://github.com/puppetlabs/puppet/pull/7167 was raised to fix one place where set_mode was used, however some other testing exposed there are other places where set_mode is
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9238 pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Change By: Glenn Sarti Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil This will probably affect all the way back to 4.10.x Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Example stack trace Failed to apply catalog: undefined method `dump' for nil:NilClass C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/api_types.rb:61:in `rescue in read_wide_string' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/api_types.rb:56:in `read_wide_string' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:213:in `block in read' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:255:in `block (3 levels) in query_value_ex' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:244:in `initialize'
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti created an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Issue Type: Bug Assignee: Unassigned Created: 2018/10/30 3:27 PM Priority: Normal Reporter: Glenn Sarti Puppet Version: Unknown Puppet Server Version: N/A OS Name/Version: Windows As part of https://puppetlabs.zendesk.com/agent/tickets/32364 it was found that there was a bug in the error handler in the read_wide_string method (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/api_types.rb#L56-L63) Where if str is nil then an error is raised during the debug statement and raises the wrong error. Instead the Puppet.debug statement should never error and raise the real error Add Comment
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti commented on PUP-9263 Re: Modulepath should not be case sensitive on case insensitive file systems Jacob Helwig ^^ Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti assigned an issue to Glenn Sarti Puppet / PUP-9263 Modulepath should not be case sensitive on case insensitive file systems Change By: Glenn Sarti Assignee: Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti assigned an issue to Unassigned Puppet / PUP-9263 Modulepath should not be case sensitive on case insensitive file systems Change By: Glenn Sarti Assignee: Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti commented on PUP-9263 Re: Modulepath should not be case sensitive on case insensitive file systems Nope...Not parsing. C:\Source> puppet config print modulepath C:/ProgramData/PuppetLabs/code/environments/workstation_production/modules;C:/ProgramData/PuppetLabs/code/modules C:\Source> puppet config print modulepath --modulepath C:\Source\tmp\jess C:/Source/tmp/jess C:\Source> puppet config print modulepath --modulepath C:\Source\Tmp\jess C:/Source/Tmp/jess C:\Source> Add Comment
Jira (PUP-9237) Unable to use Rake on Windows due to bug in packaging gem
Title: Message Title Glenn Sarti commented on PUP-9237 Re: Unable to use Rake on Windows due to bug in packaging gem Ran repro...no longer an issue C:\Source\tmp\puppet [5.5.x ≡]> be rake -T Skipping platform_data collection, but don't worry about it. rake benchmark:all:profile # Profile all of... rake benchmark:all:run # Run all of the... rake benchmark:catalog_memory # Benchmark scen... rake benchmark:catalog_memory:heap_dump# Generate a hea... rake benchmark:catalog_memory:memory_profile # Print a memory... rake benchmark:catalog_memory:profile[warm_up_runs]# Profile a sing... rake benchmark:catalog_memory:run # Run the catalo... rake benchmark:defined_types # Benchmark scen... rake benchmark:defined_types:heap_dump # Generate a hea... rake
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9263 Modulepath should not be case sensitive on case insensitive file systems Change By: Glenn Sarti Acceptance Criteria: * When passing in paths to Puppet, they should honor the case sensitivity of the underlying operating file system Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti created an issue Puppet / PUP-9263 Modulepath should not be case sensitive on case insensitive file systems Issue Type: Bug Affects Versions: PUP 6.0.2 Assignee: Unassigned Created: 2018/10/23 11:24 PM Environment: Windows 10 - 1803 ruby 2.5.1p57 (2018-03-29 revision 63029) [x64-mingw32] Priority: Normal Reporter: Glenn Sarti Puppet Version: 6.0.2 Puppet Server Version: N/A OS Name/Version: Windows 10 - 1803 It's not correct behaviour for the filesystem and the error generated by Puppet does not indicate that the path is wrong. Desired Behavior: When specifying modulepath on the puppet commandline, the path should not be case sensitive on case insensitive file systems e.g. NTFS Actual Behavior: Puppet fails to find modules if Repro: Windows VM Create a module (This example uses C:\Source\tmp\jess\test) Create a simple function # module_name/lib/puppet/functions/winquote.rb
Jira (PUP-9263) Modulepath should not be case sensitive on case insensitive file systems
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9263 Modulepath should not be case sensitive on case insensitive file systems Change By: Glenn Sarti Affects Version/s: PUP 5.5.2 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title
Glenn Sarti commented on PUP-9090
Re: Puppet apply causes a Stack Level too deep on Windows (include function)
May also be related to OS/PowerShell version This is on a fresh Server 2012R2 VM
PS C:\source> bundle exec puppet --version
6.0.2
PS C:\source> bundle exec puppet apply -e "`$var = split('12','1')"
Notice: Compiled catalog for win-hbiod5i9gso.localdomain in environment production in 0.03 seconds
Notice: Applied catalog in 0.02 seconds
PS C:\source> cd C:\Source
PS C:\Source> bundle exec puppet apply -e "`$var = split('12','1')"
Notice: Compiled catalog for win-hbiod5i9gso.localdomain in environment production in 0.03 seconds
Notice: Applied catalog in 0.03 seconds
PS C:\Source> $PSVersionTable
Name Value
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti commented on PUP-9090 Re: Puppet apply causes a Stack Level too deep on Windows (include function) Notes that Puppet Agent 6.0.2 doesn't have the issue. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title
Glenn Sarti commented on PUP-9090
Re: Puppet apply causes a Stack Level too deep on Windows (include function)
Also note that function loading seems to be broken too; Note the backtick "`" is the PowerShell escape character.
C:\Source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> be puppet apply -e "`$var = split('12','1')"
Notice: Compiled catalog for glenns.gallifrey.local in environment production in 0.04 seconds
Notice: Applied catalog in 0.03 seconds
C:\Source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> cd \source
C:\source> cd .\puppet-editor-services\
C:\source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> be puppet apply -e "`$var = split('12','1')"
Error: Evaluation Error: Error while evaluating a Function Call, split() can only be called using the 4.x function API. See Scope#call_function (line: 1, column: 8) on node glenns.gallifrey.local
C:\source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]>
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti commented on PUP-9090 Re: Puppet apply causes a Stack Level too deep on Windows (include function) cmd.exe doesn't seem to have the same problem because it looks like it uses the real on-disk name, not the one you give it. This is same computer as the ConEmu session above but using cmd.exe instead. C:\Source\puppet-editor-services>be puppet --version 6.0.2 C:\Source\puppet-editor-services>be puppet apply .\spec\debugserver\fixtures\environments\testfixtures\manifests\kitchen_sink.pp --noop --trace --verbose Notice: Scope(Class[main]): The start Alert: Scope(Class[Nestedclass]): This is an alert message Notice: Scope(Class[main]): The end! Notice: Compiled catalog for glenns.gallifrey.local in environment production in 0.10 seconds Info: Applying configuration version '1540284486' Notice: /Stage[main]/Nestedclass/Notify[nested_notify]/message: current_value 'absent', should be 'nested_notify' (noop) Notice: /Stage[main]/Nestedclass/Notify[routers]/message: current_value 'absent', should be 'routers' (noop)
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti commented on PUP-9090 Re: Puppet apply causes a Stack Level too deep on Windows (include function) Confirmed it's the working directory being case sensitive; Same ConEmu session, same puppet version. This is using the Puppet 6 Gem. Note the C:\Source and C:\source C:\source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> be puppet apply .\spec\debugserver\fixtures\envi ronments\testfixtures\manifests\kitchen_sink.pp --noop --trace --verbose Notice: Scope(Class[main]): The start Error: Could not run: stack level too deep C:\source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> cd \ C:\> cd Source C:\Source> cd .\puppet-editor-services\ C:\Source\puppet-editor-services [fix-debug-server-pup6 +1 ~4 -3 !]> be puppet apply .\spec\debugserver\fixtures\envi ronments\testfixtures\manifests\kitchen_sink.pp --noop --trace --verbose Notice: Scope(Class[main]): The start Alert: Scope(Class[Nestedclass]): This is an alert message
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9090 Puppet apply causes a Stack Level too deep on Windows (include function) Change By: Glenn Sarti Affects Version/s: PUP 6.0.2 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9090) Puppet apply causes a Stack Level too deep on Windows (include function)
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9090 Puppet apply causes a Stack Level too deep on Windows (include function) Change By: Glenn Sarti Affects Version/s: PUP 5.5.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9106) Windows file system ACLs should always write SYSTEM: (F)
Title: Message Title Glenn Sarti commented on PUP-9106 Re: Windows file system ACLs should always write SYSTEM: (F) Geoff Nichols I haven't added release notes in a long time. I've added what I think is correct but would prefer a once-over by someone else if possible (Ethan Brown or Josh Cooper) Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9106) Windows file system ACLs should always write SYSTEM: (F)
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9106 Windows file system ACLs should always write SYSTEM: (F) Change By: Glenn Sarti Release Notes Summary: It was possible to create files and directories on Windows computers which restricted access to the Local System account. Now Puppet will detect when this happens and automatically grant Local System full rights. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9106) Windows file system ACLs should always write SYSTEM: (F)
Title: Message Title Glenn Sarti commented on PUP-9106 Re: Windows file system ACLs should always write SYSTEM: (F) Additional PR merged into 5.5.x at; https://github.com/puppetlabs/puppet/commit/3bf8d22a79b556f0534400bf31965adc073438f9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti assigned an issue to Ethan Brown Puppet / PUP-9238 pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Change By: Glenn Sarti Assignee: Glenn Sarti Ethan Brown Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9175) Allowing specifying rake version from the environment
Title: Message Title Glenn Sarti commented on PUP-9175 Re: Allowing specifying rake version from the environment Thanks Josh Cooper!! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9238 pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Change By: Glenn Sarti Story Points: 1 Team: Direct Change Windows Sprint: Windows 2018-10-17 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti assigned an issue to Glenn Sarti Puppet / PUP-9238 pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Change By: Glenn Sarti Assignee: Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Glenn Sarti commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 As long as FACT-1881 is scheduled (it's currently blocked), +1 from me! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9175) Allowing specifying rake version from the environment
Title: Message Title Glenn Sarti commented on PUP-9175 Re: Allowing specifying rake version from the environment This fixes PUP-9327 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9175) Allowing specifying rake version from the environment
Title: Message Title Glenn Sarti commented on PUP-9175 Re: Allowing specifying rake version from the environment Raise PR https://github.com/puppetlabs/puppet/pull/7168 for this. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9106) Windows file system ACLs should always write SYSTEM: (F)
Title: Message Title Glenn Sarti commented on PUP-9106 Re: Windows file system ACLs should always write SYSTEM: (F) Blocking this on PUP-9328 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti commented on PUP-9238 Re: pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Raised PR https://github.com/puppetlabs/puppet/pull/7167 for this. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9238) pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes
Title: Message Title Glenn Sarti moved an issue Puppet / PUP-9238 pxp-agent's tests/task.run_puppet.rb test fails on Windows with PUP-9106 changes Change By: Glenn Sarti Key: PCP PUP - 859 9238 Project: Puppet Communications Protocol Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
