[issue14367] try/except block in ismethoddescriptor() in inspect.py, so that pydoc works with pygame in Python 3.2

2014-02-24 Thread Yury Selivanov

Yury Selivanov added the comment:

Is this still an issue?

--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14367
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20763] old sys.path_hooks importer does not work with Python 3.4.0rc1

2014-02-24 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20763
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20763] old sys.path_hooks importer does not work with Python 3.4.0rc1

2014-02-24 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20763
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20765] Pathlib docs fail to mention with_name, with_suffix

2014-02-24 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-02-26 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +larry, ncoghlan, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-02-26 Thread Yury Selivanov

Yury Selivanov added the comment:

Larry, I think the problem is that

 property.__delete__.__text_signature__
'(instance, /)'

but should be something like '($self, instance, /)'.

What do you think?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-02-26 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
priority: normal - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20791] copy.copy(bytes) is slow

2014-02-27 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20791
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-02-28 Thread Yury Selivanov

Yury Selivanov added the comment:

Larry, Nick, what do you think?
I'd like this to be fixed in 3.4.0...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20807] 3.4 cherry pick: 82ec02db7fe6 ec42ab5e0cb3 Windows installer fixes

2014-02-28 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20807
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20810] literal re fails to match

2014-02-28 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20810
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20817] inspect.getcallargs() raises the wrong error if 3+ arguments are missing

2014-03-01 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
assignee:  - yselivanov
nosy: +larry, ncoghlan, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20817
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20816] inspect.getcallargs() attempts to iterate over None

2014-03-01 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
assignee:  - yselivanov
nosy: +ncoghlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20816
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20828] inspect.getargspec() returns wrong answer with datetime.today.__call__()

2014-03-02 Thread Yury Selivanov

Yury Selivanov added the comment:

Why are you trying to get signature of 'datetime.datetime.today.__call__'?

__call__ in this case is a generic python object -- method-wrapper. It is used 
to make a classmethod. And the signature that getargspec is returning for it is 
correct.

--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20828
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20828] inspect.getargspec() returns wrong answer with datetime.today.__call__()

2014-03-02 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +ncoghlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20828
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-03-02 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20829] 3.4 cherry pick: c9861ec8754c Fix signatures for dict.__delitem__ and property.__delete__

2014-03-02 Thread Yury Selivanov

New submission from Yury Selivanov:

http://hg.python.org/cpython/rev/c9861ec8754c
changeset:   89461:c9861ec8754c
user:Yury Selivanov yseliva...@sprymix.com
date:Sun Mar 02 12:25:27 2014 -0500
summary:
  Issue #20786: Fix signatures for dict.__delitem__ and property.__delete__

--
assignee: larry
keywords: 3.4regression
messages: 212565
nosy: larry, yselivanov
priority: release blocker
severity: normal
status: open
title: 3.4 cherry pick: c9861ec8754c Fix signatures for dict.__delitem__ and 
property.__delete__
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20829
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20786] inspect.getargspec() returns wrong answer with property.__delete__()

2014-03-02 Thread Yury Selivanov

Yury Selivanov added the comment:

Mike, this is now fixed. I've created an issue for tracking of getting this fix 
in 3.4.0: #20829.

Thanks for finding this bug!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20786
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20828] inspect.getargspec() returns wrong answer with datetime.today.__call__()

2014-03-02 Thread Yury Selivanov

Yury Selivanov added the comment:

OK, I see.

I'd recommend you to take a look how inspect.signature is implemented in 3.3 or 
3.4 (and maybe backport it to python 2 and use the new API).

To quickly fix your code, I'd suggest the following modifications:

_WrapperDescriptor = type(type.__call__)
_MethodWrapper = type(all.__call__)
_ClassMethodWrapper = type(int.__dict__['from_bytes'])

def get_callable_argspec(fn):
if inspect.isfunction(fn) or inspect.ismethod(fn):
inspectable = fn
elif inspect.isclass(fn):
inspectable = fn.__init__
elif hasattr(fn, '__call__'):
inspectable = fn.__call__
else:
inspectable = fn
   
if isinstance(fn, (_WrapperDescriptor, _MethodWrapper, 
_ClassMethodWrapper)):
raise ValueError('unsupported callable {!r}'.format(fn))

try:
return inspect.getargspec(inspectable)
except TypeError:
raise


I'm closing this issue, as there is no real bug or regression in getargspec.

--
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20828
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20847] asyncio docs should call out that network logging is a no-no

2014-03-03 Thread Yury Selivanov

Yury Selivanov added the comment:

Can we instead re-engineer asyncio logging to have logger calls in a separate 
thread?

I.e. `logger` is a proxy object, that puts logging calls in a queue, and there 
would be another thread to block on the queue and do the actual logging. This 
way it won't really matter how logging is configured.

--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20847
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20847] asyncio docs should call out that network logging is a no-no

2014-03-03 Thread Yury Selivanov

Yury Selivanov added the comment:

 If you really need network logging you should be able to configure a handler 
 that puts things in a queue whose other end is serviced by an asyncio task. 
 There should be no need to mess with the type of the logger object.

It's something that is easy to misconfigure. Having [logger+queue+logging 
thread] combination mitigates the risk a bit, but yeah, at the cost of 
increased complexity...

 Anyway, in 3.4 it is what it is. :-)

Right.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20847
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20855] RFE: change bool(0.0) to evaluate as True

2014-03-05 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20855
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13936] RFE: change bool(datetime.time(0, 0, 0)) to evaluate as True

2014-03-05 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13936
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20829] 3.4 cherry pick: c9861ec8754c Fix signatures for dict.__delitem__ and property.__delete__

2014-03-06 Thread Yury Selivanov

Yury Selivanov added the comment:

Larry, so do you think we can have this one cherry-picked?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20829
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20894] COMSPEC with multiple paths breaks subprocess.call

2014-03-12 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20894
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20918] LogRecord.__init__ should handle exception if % operation fails

2014-03-13 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +vinay.sajip, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20918
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18931] new selectors module should support devpoll on Solaris

2014-03-15 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18931] new selectors module should support devpoll on Solaris

2014-03-18 Thread Yury Selivanov

Yury Selivanov added the comment:

Why there is no 'review' link for the new patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18931] new selectors module should support devpoll on Solaris

2014-03-19 Thread Yury Selivanov

Yury Selivanov added the comment:

Still no review link. Somehow you managed to upload the first patch correctly. 
Does the new one apply cleanly on the default branch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20739] PEP 463 (except expression) implementation

2014-03-27 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy:  -yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20739
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20334] make inspect Signature hashable

2014-03-27 Thread Yury Selivanov

Yury Selivanov added the comment:

If nobody has any objections on this, I'm going to commit this in 3.5 soon.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20334
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20668] Remove dependency on tests.txt when running test_asyncio suite

2014-03-27 Thread Yury Selivanov

Yury Selivanov added the comment:

Guido, good idea. Committed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20668
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20816] inspect.getcallargs() attempts to iterate over None

2014-03-27 Thread Yury Selivanov

Yury Selivanov added the comment:

Fixed for 3.4.1 and 3.5.
Thank you Jeremiah!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20816
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20817] inspect.getcallargs() raises the wrong error if 3+ arguments are missing

2014-03-27 Thread Yury Selivanov

Yury Selivanov added the comment:

Fixed for 3.4.1 and 3.5.
Thanks for the contribution!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20817
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20691] inspect.signature: Consider exposing 'follow_wrapper_chains' option in public API

2014-03-27 Thread Yury Selivanov

Yury Selivanov added the comment:

So... should we expose two keyword only parameters for 
Signature.from_callable() and signature():

- 'follow_wrapped=True' to follow __wrapped__ chains;
- 'keep_bound_arg=False' to skip/include first bound arg?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20691
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect: PartialSignature and PartialParameter classes

2014-03-31 Thread Yury Selivanov

New submission from Yury Selivanov:

There is a small detail in the current Signature class implementation, in 
regards to how partial signatures are treated. Consider the following example:

   def foo(a, b): pass
   foo_partial = functools.partial(foo, 'spam')

Now, the signature of 'foo_partial' is '(a=spam, b)', which (strictly 
speaking) is not a valid python function signature. For cases like that, we 
have a private Parameter._partial_kwarg attribute. When this attribute is set 
to True, it means, that this parameter's default came from partial (or alike) 
function. Parameter instances with '_partial_kwarg=True' are treated a bit 
differently during signature validation and binding.

A small and nasty detail: Parameter.__eq__ ignores value of '_partial_kwarg'. 
Because, for the following code:

   def bar(a, b=10): pass
   def baz(a, b): pass
   baz2 = functools.partial(baz, b=10)

signature of 'bar' is equal to 'baz2'.

In light of making signatures hashable, the obvious question was raised: should 
__hash__ account for '_partial_kwarg' value or not.  I think it should.  But in 
this case, it should be really obvious, if parameter was modified by partial or 
not.

Hence, I propose to add two more classes:

- PartialSignature(Signature)
- PartialParameter(Parameter)

Results of signature(functools.partial(..)) and Signature.bind_partial(..) will 
be instances of PartialSignature. It will be OK if some PartialSignature is 
equal to Signature, but they will have different __hash__es.

What do you think?

--
assignee: yselivanov
components: Library (Lib)
messages: 215265
nosy: brett.cannon, larry, ncoghlan, yselivanov
priority: normal
severity: normal
status: open
title: inspect: PartialSignature and PartialParameter classes
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect: PartialSignature and PartialParameter classes

2014-03-31 Thread Yury Selivanov

Yury Selivanov added the comment:

@Nick:

 Oops: already bound positional-*only* arguments should be hidden.
Hm, good catch. I'm not sure we currently do this. I'll check if this needs to 
be fixed (in 3.4.1 too).

 I'm +0 on new types to clean that up if necessary, but would prefer it if
we could just improve the translation to ordinary signature objects instead.

I'm not sure I understand what you mean by translation to ordinary signature 
objects. Could you please elaborate on this?


@R. David:
 I believe it is a python invariant that a == b implies hash(a) == hash(b).  

I think that 'hash(a) == hash(b)' means that 'a == b' (strongly). But not 
reverse.  Or am I wrong?

 I don't see why the two signatures should be equal. I'm not even sure why the 
 bound argument shows up in the signature of the partial.

Well, why shouldn't they be equal? They have same parameters, same default 
values. Quoting pep 362: ...two signatures are equal only when their 
corresponding parameters are equal and have the exact same names 
Moreover, this behaviour is implemented since 3.3.
 
But their hashes shouldn't be equal, that's something I can agree on.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect: PartialSignature and PartialParameter classes

2014-03-31 Thread Yury Selivanov

Yury Selivanov added the comment:

@Nick:

Agreed on positional-only stuff.

 If arguments bound by position disappear from the signature, and those
 bound by keyword are mapped to keyword-only parameters with a default, we
 should get a valid and accurate signature.

But what about my example from the first message:

   def foo(a, b): pass
   foo_partial = functools.partial(foo, 'spam')

'foo_partial' now has the following signature: (a='spam', b); where 'a' is a 
positional_or_keyword parameter, i.e. you can still do 'foo_partial(10, 20)', 
or 'foo_partial(b=20, a=10)'.

(a='spam',  b) is not a valid python pure function signature, but is a 
perfectly valid signature of partial function. And since its arguments aren't 
positional-only, we shouldn't hide anything.

That's why I have this private '_partial_kwarg' attribute, which I don't like 
and want to remove by adding a PartialParameter subclass. Otherwise, we have 
something that is hidden and non-documented, but affects Parameter.__hash__ and 
some other logic.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect: PartialSignature and PartialParameter classes

2014-03-31 Thread Yury Selivanov

Yury Selivanov added the comment:

@Nick: oh, it took me some time to realize that your suggestion to transform 
positional-or-keyword to keyword-only parameters is correct. If we do this, we 
no longer need '_partial_kwarg' hack. I'll work on the patch. Thank you.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-01 Thread Yury Selivanov

Yury Selivanov added the comment:

@Nick:

Ouch... I'm halfway through the implementation, and it seems like your idea 
isn't going to work.

Example (from unittest):

def foo(a=1, b=2, c=3): pass
_foo = partial(foo, a=10, c=13)

Now, the signature for _foo, with your logic applied, will be:

(b=2, *, a=10, c=13)

If, however, you try to do the following call:

_foo(11)

It will fail with a TypeError got multiple values for argument 'a', because 
'partial' will actually do this call:

foo(11, a=10, c=13)

I now remember this obstacle, that's why I have '_partial_kwarg'. So 
unfortunately, why I really like your idea, I don't think we can make it work.

Now, I still want to get rid the '_partial_kwarg' attribute. Are you guys OK, 
if I introduce PartialParameter  PartialSignature classes?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-01 Thread Yury Selivanov

Yury Selivanov added the comment:

@R. David:

Yes, thank you, David. Too bad I haven't seen your last messages before I 
started working on the patch...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-01 Thread Yury Selivanov

Yury Selivanov added the comment:

 First, I think this is a bug in partial, so I think we need to decide what, 
 if anything, to do about that first, before we decide if signature needs to 
 compensate for it or not.

Agree. Although, it looks like it's not something that partial is doing, it 
seems like this call logic is implemented somewhere way deeper.

 The other comment is about ==/__hash__ [...]
Agree.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-01 Thread Yury Selivanov

Yury Selivanov added the comment:

 Although, it looks like it's not something that partial is doing, it seems 
 like this call logic is implemented somewhere way deeper.

Forget about what I said.

Yes, it's a bug in partial. Fixing it, will require having the code from 
Signature.bind reflected to C -- IOW you need to introspect the callable, get 
information about its parameters, and then compute the actual args  kwargs. 
Which will make functools.partial much much slower.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-01 Thread Yury Selivanov

Yury Selivanov added the comment:

 Oh, wait, it *does* have a usable signature. It's just that all the 
 *subsequent* positional-or-keyword parameters also have to be marked as 
 keyword-only.

Interesting idea. I'll incorporate this logic into the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-02 Thread Yury Selivanov

Yury Selivanov added the comment:

Please review the attached patch.

Here's the new partial signature semantics:

   foo(a, b, /, c, d, *args, e)

   partial(foo, 10) - (b, /, c, d, *args, e)
   partial(foo, 10, c=11) - (b, /, *, c=11, d, e)
   partial(foo, 10, 20, 30) - (d, *args, e)
   partial(foo, 10, 20, 30, 40, 50) - (*args, e)
   partial(foo, 10, 20, c=20) - (*, c=20, d, e)

Good news: 

1. no more special attributes and other hidden hacks.

2. only with this patch we properly support functools.partial. So this is 
definitely something we can classify as a bug fix and push in 3.4.1.

--
keywords: +patch
Added file: http://bugs.python.org/file34706/signature_partial_fix_01.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-04 Thread Yury Selivanov

Yury Selivanov added the comment:

Any comments on the patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21117] inspect.signature: inaccuracies for partial functions

2014-04-08 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20334] make inspect Signature hashable

2014-04-08 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20334
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-13 Thread Yury Selivanov

Yury Selivanov added the comment:

Hm... Can we also commit this to 3.3?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Yury Selivanov added the comment:

 3.3 is in security-fix only mode.

Yeah, but this is a core language bug. I believe some people may be stuck on 
3.3 with broken 'yield from' for whatever reason, which will cause hard to find 
bugs in 3.3 compatible libraries (like asyncio/tulip).  I think we can lift the 
security-only restriction for this specific patch, no?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Yury Selivanov added the comment:

Guido: please take a look at the patch corowrapper_01.patch.

--
Added file: http://bugs.python.org/file34832/corowrapper_01.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
resolution: fixed - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2014-04-14 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Yury Selivanov added the comment:

Please see the corowrapper_02.patch. I've removed the version check, now it's 
much simpler.

--
Added file: http://bugs.python.org/file34850/corowrapper_02.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-14 Thread Yury Selivanov

Yury Selivanov added the comment:

I don't like this idea. inspect module is about introspection, and not about 
interpreting its results. I'd keep this function in pydoc and document it if 
there is noticeable demand for it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Yury Selivanov added the comment:

 [...] CoroWrapper.send() signature is different from a real generator's 
 send() method, but I think that send() to a coroutine is an internal detail 
 anyway [...]

Yeah, and since it's used in debug mode only, I think we should be safe.

 When you commit, can you do upstgream (Tulip) first?

Sure, this patch was for tulip code.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-14 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

Guido, I'm feeling a bit uncomfortable with the patch I pushed. I think we 
should adjust the solution, to avoid having arguments to 'gen.send' packed in 
two nested tuples. Please take a look at the new patch (corowrapper_03.patch). 
It adds some amount of ugliness, but with it in place, I'd be more sure that we 
don't brake anything.

--
Added file: http://bugs.python.org/file34870/corowrapper_03.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21235] importlib's spec module create algorithm is not exposed

2014-04-15 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21235
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20438] inspect: Deprecate getfullargspec?

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

How about we deprecate with a warning getfullargspec(); deprecate getargspec() 
in docs only (in 3.6 we'll fully deprecate all function parameters API except 
Signature)?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20438
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21209] q.put(some_tuple) fails when PYTHONASYNCIODEBUG=1

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

 I should check, but I think that Python create a tuple for you if you don't 
 pass directly a tuple, so it's not very different.

That's what I thought, but still, better to have the code clearly expressing 
what it does, than relying on obscure implementation/protocol details.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20438] inspect: Deprecate getfullargspec?

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

I'd +1 for:

1. Deprecating getfullargsspec in docs;
2. Deprecating getargspec in docs and code (since it's an ancient and outdated 
API)

Brett?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20438
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

Apart from one nit, the patch is looking good.

Also, could you please sign the contributor agreement, as described here: 
https://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1764286] inspect.getsource does not work with decorated functions

2014-04-15 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
assignee:  - yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1764286
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

Claudiu: I'll take a look at your patch, thanks!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

David:

 The precedent has already been set by the 'cleandoc' function, I think.  This 
 one seems to go right along with that one.

What do you think if we keep the function in pydoc module, but document it and 
make it public?  I agree, that there is a precedent of having non-introspection 
APIs in inspect, but I'd still like to keep it minimal.  Having this function 
in pydoc also makes sense, as it's more about python docstring convention, than 
introspection (cleandoc() is used by getdoc(), which is why it is in inspect 
after all)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21245] Logging Logger.exception documentation

2014-04-15 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +vinay.sajip, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21245
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20438] inspect: Deprecate getfullargspec?

2014-04-15 Thread Yury Selivanov

Yury Selivanov added the comment:

Nick, good catch. OK, let's just deprecate it in the docs for 3.5, so people 
(hopefully) will not write new code with it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20438
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21252] Lib/asyncio/events.py has tons of docstrings which are just XXX

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

I had plans to copy some documentation from python docs to asyncio docstrings. 
I'll try to do this sometime this week. Thanks for reminding us about the issue!

--
assignee:  - yselivanov
nosy: +gvanrossum, haypo, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21252
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21252] Lib/asyncio/events.py has tons of docstrings which are just XXX

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

 My bad. But I think docstrings should NOT be just copies of the separate
docs.

I agree. I didn't want to blindly copy them, but rather use existing 
documentation as guidance  baseline.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21252
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

OK, since it's two-and-a-half votes against one, let's do this. I'll do the 
final review of the patch and commit it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

The current patch proposes to add inspect.splitdoc(obj), instead of 
pydoc.splitdoc(doc).  The former takes an object, extracts documentation out of 
it, and returns a tuple.  The latter, just splits the passed doc string.

If you want this function in inspect, we need to find a better name for it, or 
don't make it to receive an object.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

 In the inspect module, I think all the functions take a object and not a 
string, it's the reason why I included the code of pydoc.getdoc() into 
inspect.splitdoc().

I understand. But you also do inspect.getdoc or inspect.getcomments, which I 
don't really like.  What's the point of having getcomments there?  Are comments 
considered docstrings?  If not, then why is the method called splitdocs?

Don't get me wrong, I'm not trying to pushback on the idea (since everybody is 
agreeing to have it), I just want the naming and behaviour be consistent.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

 Are you agree with that, or there is a good way for this kind of 
improvement?

Having a unittest to check if a deprecated functionality is removed in the 
future versions was Brett's idea, and I like it. So I think it's good to do the 
same here.  Your way of doing this is fine.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov

Yury Selivanov added the comment:

I'd keep the name (splitdoc), and let it receive a string.  But let's hear 
what Eric  David think about it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21288] hashlib.pbkdf2_hmac Hash Constructor

2014-04-17 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21288
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21288] hashlib.pbkdf2_hmac Hash Constructor

2014-04-17 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +christian.heimes, gregory.p.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21288
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21288] hashlib.pbkdf2_hmac Hash Constructor

2014-04-17 Thread Yury Selivanov

Yury Selivanov added the comment:

On 2014-04-17, 5:02 PM, Christian Heimes wrote:
 Christian Heimes added the comment:

 A callable wouldn't work for the OpenSSL back end of PBKDF2. The function 
 takes a digest pointer. I have to think about a solution...

 Sorry for the brevity, I still don't have proper internet at home.


We can accept only hashlib functions, and continue passing their names 
to the OpenSSL backend. A bit ugly and limited solution (no user-defined 
hash functions) for a better looking API.

Yury

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21288
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21288] hashlib.pbkdf2_hmac Hash Constructor

2014-04-17 Thread Yury Selivanov

Yury Selivanov added the comment:

Armin, FWIW, I don't think it's possible to push this API change in 3.4.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21288
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21294] len wrong help

2014-04-17 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +ncoghlan, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21294
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21302] time.sleep (floatsleep()) should use clock_nanosleep() on Linux

2014-04-18 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +haypo, yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21302
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21314] Bizarre help

2014-04-20 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17552] socket.sendfile()

2014-04-23 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17552
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21399] inspect and class methods

2014-04-30 Thread Yury Selivanov

Yury Selivanov added the comment:

 In Python2.7, the cls parameter shows up in pydoc:

frombuf(cls, buf) from __builtin__.type
Construct a TarInfo object from a 512 byte string buffer.


 In 3.5, it doesn't:

frombuf(buf, encoding, errors) from builtins.type
Construct a TarInfo object from a 512 byte bytes object.

Yes, that's a correct behaviour in 3.4 and 3.5. See #20710 for details.

  signature(TarInfo.create_gnu_header)
 Signature at 0x7f50cf110cf0 (self, info, encoding, errors)
  signature(TarInfo.frombuf)
 Signature at 0x7f50cf11cc88 (buf, encoding, errors)

There is no bug here. `TarInfo.create_gnu_header` is an unbound method, that 
indeed requires first argument 'self'.  `TarInfo.frombuf` is a classmethod, so 
it doesn't need a 'cls' arg.  Signature, by default and by design, only shows 
arguments that need to be passed to correctly execute the given callable.

 How about the C docstrings? Can we get $cls for classmethods?

Yes, I think it should work.

--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21399
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21399] inspect and class methods

2014-05-01 Thread Yury Selivanov

Yury Selivanov added the comment:

Yeah, I'm closing this issue.

--
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21399
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1218234] inspect.getsource doesn't update when a module is reloaded

2014-05-06 Thread Yury Selivanov

Yury Selivanov added the comment:

Thanks, I'll take a look at the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1218234
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21326] asyncio: request clearer error message when event loop closed

2014-06-03 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21326
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21723] Float maxsize is treated as infinity in asyncio.Queue

2014-06-11 Thread Yury Selivanov

Yury Selivanov added the comment:

FWIW, this can also be resolved by fixing Queue.full to do self.qsize() = 
self._maxsize instead of self.qsize() == self._maxsize.

I generally don't like implicit casts as they break duck typing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21723
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21801] inspect.signature doesn't always return a signature

2014-06-20 Thread Yury Selivanov

Yury Selivanov added the comment:

This behaviour is indeed a bug. However, I think that the solution you propose 
is wrong.

If we ignore invalid contents of __signature__ we are masking a bug or 
incorrect behaviour. In this case, you should have checked the requested 
attribute name in '__getattr__', and return something other than _Method, if it 
is a '__signature__'.

Please find attached a patch, that checks if __signature__ is an instance of 
Signature class, and raises a TypeError if it isn't.

--
nosy: +larry, ncoghlan
Added file: http://bugs.python.org/file35710/issue21801.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21684] inspect.signature bind doesn't include defaults or empty tuple/dicts

2014-06-20 Thread Yury Selivanov

Yury Selivanov added the comment:

That's the intended and documented behaviour, see 
https://docs.python.org/3/library/inspect.html#inspect.BoundArguments.arguments.

You can easily implement the functionality you need by iterating through 
Signature.parameters and copying defaults to the BoundArguments.arguments 
mapping. There is no need to complicate the API with a dedicated method for 
that (if anything, in 3.5 you can subclass Signature and use from_callable to 
have any functionality you want).

Closing this one as 'not a bug'.

--
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17424] help() should use the class signature

2014-06-20 Thread Yury Selivanov

Yury Selivanov added the comment:

Since 3.4, help() uses signature.
Closing this one.

--
nosy: +yselivanov
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17424
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21801] inspect.signature doesn't always return a signature

2014-06-20 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
assignee:  - yselivanov
keywords: +needs review
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21684] inspect.signature bind doesn't include defaults or empty tuple/dicts

2014-06-23 Thread Yury Selivanov

Yury Selivanov added the comment:

Ryan,
Can you explain the use case for it? What's the problem you're trying to solve?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21801] inspect.signature doesn't always return a signature

2014-06-23 Thread Yury Selivanov

Yury Selivanov added the comment:

Fixed in 3.4 and 3.5.
Thanks for the bug report!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21163] asyncio doesn't warn if a task is destroyed during its execution

2014-06-23 Thread Yury Selivanov

Yury Selivanov added the comment:

@Guido, @Yury: What do you think of log_destroyed_pending_task.patch? Does it 
sound correct?

Premature task garbage collection is indeed hard to debug. But at least, with 
your patch, one gets an exception and has a chance to track the bug down. So 
I'm +1 for the patch.

As for having strong references to tasks: it may have its own downsides, such 
as hard to debug memory leaks. I'd rather prefer my program to crash and/or 
having your patch report me the problem, than to search for an obscure code 
that eats all server memory once a week. I think we need to collect more 
evidence that the problem is common  annoying, before making any decisions on 
this topic, as that's something that will be hard to revert. Hence I'm -1 for 
strong references.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21163
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21684] inspect.signature bind doesn't include defaults or empty tuple/dicts

2014-06-25 Thread Yury Selivanov

Yury Selivanov added the comment:

 But I can't think of any use case when it would be undesirable to include the 
 extra parameters

One use case is that you are actually loosing information what arguments 
Signature.bind() was called with, when defaults are included. In some cases 
this information is important.

 hence the possibility of a separate method

Since it's relatively easy to add mix defaults in, I'd prefer to be 
conservative here, and wait for a stronger community interest before adding a 
new method to API.

But thanks for the bug report. If you find any other use cases for a separate 
method, please feel free to update this issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20334] make inspect Signature hashable

2014-08-15 Thread Yury Selivanov

Yury Selivanov added the comment:

Thanks, Antony, this is a good catch. Your suggestion seems like a good idea. 
I'll look into this more closely soon.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20334
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22203] inspect.getargspec() returns wrong spec for builtins

2014-08-25 Thread Yury Selivanov

Changes by Yury Selivanov yselivanov...@gmail.com:


--
nosy: +yselivanov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22203
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20334] make inspect Signature hashable

2014-09-12 Thread Yury Selivanov

Yury Selivanov added the comment:

Antonie, I'm attaching a patch (issue20334-2.01.patch) to this issue which 
should fix the problem. Please review.

--
Added file: http://bugs.python.org/file36607/issue20334-2.01.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20334
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20334] make inspect Signature hashable

2014-09-12 Thread Yury Selivanov

Yury Selivanov added the comment:

Antony, I've tweaked the patch a bit and it's now in default branch. Thank you!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20334
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



<    1   2   3   4   5   6   7   8   9   10   >