Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread David Hildenbrand 
On 11.08.2017 19:18, Richard Henderson wrote:
> It's not all kvm related, so I'd prefer the more general name.

Thomas suggested to have both, internal.h and kvm_s390x.h

All KVM stuff goes into kvm_s390x.h. I even moved the stubs to
kvm-stubs.c (that's the way e.g. x86 handles it).

End result looks pretty clean, will send it out shortly.

Thanks!

> 
> r~
> 
> On August 11, 2017 9:19:52 AM CDT, Thomas Huth  wrote:
> 
> On 11.08.2017 09:46, David Hildenbrand wrote:
> 
> Let's move everything into internal.h
> 
> 
> Or kvm_s390x.h ? ;-)
> 
>  Thomas
> 
> 
> -- 
> Sent from my Android device with K-9 Mail. Please excuse my brevity.


-- 

Thanks,

David

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread Richard Henderson 
It's not all kvm related, so I'd prefer the more general name.

r~

On August 11, 2017 9:19:52 AM CDT, Thomas Huth  wrote:
>On 11.08.2017 09:46, David Hildenbrand wrote:
>> Let's move everything into internal.h
>
>Or kvm_s390x.h ? ;-)
>
> Thomas

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread David Hildenbrand 
On 11.08.2017 16:19, Thomas Huth wrote:
> On 11.08.2017 09:46, David Hildenbrand wrote:
>> Let's move everything into internal.h
> 
> Or kvm_s390x.h ? ;-)

And even kvm-stubs.c!

> 
>  Thomas
> 
> 


-- 

Thanks,

David

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread Thomas Huth 
On 11.08.2017 09:46, David Hildenbrand wrote:
> Let's move everything into internal.h

Or kvm_s390x.h ? ;-)

 Thomas

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread Richard Henderson 
On 08/11/2017 12:46 AM, David Hildenbrand wrote:
> Let's move everything into internal.h
> 
> Signed-off-by: David Hildenbrand 
> ---
>  target/s390x/cpu.h  | 62 
> -
>  target/s390x/internal.h | 52 +
>  2 files changed, 52 insertions(+), 62 deletions(-)

Reviewed-by: Richard Henderson 


r~