Re: Cleartool missing + Svn access issue ?
Filled http://code.google.com/p/reviewboard/issues/detail?id=1062 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review : Review a single existing file in repository
Hi Nicholas, post-review is indeed the right tool to use for most things. You can review existing files by passing the filenames to post-review, OR you can specify a revision range. It doesn't support both (though we'd accept patches for this, which probably would be easy -- just modify SVNClient.diff_between_revisions to append the value of args to the do_diff argument list). If your goal to start with is to put whole existing files up for review, you'd want to use a revision range of 0 to the latest version. Short of modifying post-review for this, you could use svn diff for the purpose and then upload through the web UI. If you're comfortable with Python, though, I'd recommend modifying post-review and giving that a try. If it works, we'll commit it upstream. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Sun, Apr 19, 2009 at 8:53 PM, Nicholas yue.nicho...@gmail.com wrote: Hi, I am attempting to introduce ReviewBoard to a group of junior developers who have been committing code to their existing SVN server for over one year. As this is their initial code review, there are files for which I'd like to review as a whole, not just the recent few diffs/commits Is post-review the tool to use? For example, there is a header file called utility.h which have been worked on for about 1 year with hundreds of revisions. I'd like to code review the whole header file. What flags should I use? The plan is that over time, we can start diffing specific section of the file for review but it's the initial review that I need to plan for. Regards --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Djblets in source tree
On Mon, Apr 20, 2009 at 2:43 PM, Eric Huss erich...@gmail.com wrote: r1917 made a change to setup.py to require Djblets 0.5beta2.dev_20090420. The downloads URL only seems to have an egg for 2.4. If you run setup.py install, it will complain since it can't find (in my case) a 2.5 egg. Looks like the build broke for 2.5 only last night, hence the lack of eggs. I'll get this fixed for tonight's build. 1. Are you planning to publish eggs for 2.4 and 2.5 in the future? Yep, definitely. We'll be continuing to distribute 2.4 and 2.5 eggs for the forseeable future (and 2.6 eventually, once I get another buildbot instance going somewhere). 2. Is there some way to tell setup.py to use the version that gets checked out by the svn externals link? If you're using setup.py in one, you should use it in the other, and not rely on svn:externals. To build your own nightly, you can run: sudo python setup.py install nightly This will tag the version with the date stamp. 3. I'm curious, in the course of development, do you use setup.py develop to get reviewboard into your path? How do you get djblets into your python path? Or do you set PYTHONPATH manually? I actually use Git-SVN for development and use a symlink to a checked out Djblets, rather than svn:externals. But the prinicipal is the same. I don't rely on installing eggs unless there's something I explicitly need to test. I guess what I'm asking is why djblets and django_evolution are svn externals, but the setuptools method of installation doesn't jive with that. Djblets won't be an svn:external much longer, nor will django_evolution. Now that people aren't running directly out of an SVN checkout anymore (or shouldn't be) there's little reason to continue with this route. I would say for developers, either just develop out of the tree, use devserver.sh for testing, and use symlinks/svn:externals for the dependencies, -or- use eggs and install with the install nightly alias or develop (not sure if you need to do develop nightly -- I honestly don't use develop for this). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1062 in reviewboard: Post-review fails to detect svn repository
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1062 by vesterbaek: Post-review fails to detect svn repository http://code.google.com/p/reviewboard/issues/detail?id=1062 What steps will reproduce the problem? 1. Make changes to a local svn checkout using an svn client newer than your default command line client. I installed a new version of tortoise svn without upgrading my command line client. 2. Run post-review. The script fails, complaining it cannot cleartool (because it fails to get svn reposity info) 3. I figured out this was due to my svn client being too old. C:\temp\reviewboard-read-only\reviewboardsvn info . svn: This client is too old to work with working copy '.'. You need to get a newer Subversion client, or to downgrade this working copy. See http://subversion.tigris.org/faq.html#working-copy-format-change for details. What is the expected output? What do you see instead? post-review should detect a too old svn client What operating system are you using? What browser? windows xp, RBTools-0.2beta1-py2.5.egg See http://groups.google.com/group/reviewboard/browse_thread/thread/a438d3fb071 78147# for the full story. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 755 in reviewboard: rb_site dependency checks
Updates: Status: Fixed Owner: chipx86 Comment #2 on issue 755 by chipx86: rb_site dependency checks http://code.google.com/p/reviewboard/issues/detail?id=755 Fixed in r1916. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 756 in reviewboard: rb_site mysql database check missing
Updates: Status: Fixed Owner: chipx86 Comment #2 on issue 756 by chipx86: rb_site mysql database check missing http://code.google.com/p/reviewboard/issues/detail?id=756 Fixed in r1916. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 406 in reviewboard: http://reviewboard/dashboard/?sort=-time_added sorts by Last Updated
Updates: Status: Fixed Owner: chipx86 Comment #8 on issue 406 by chipx86: http://reviewboard/dashboard/?sort=-time_added sorts by Last Updated http://code.google.com/p/reviewboard/issues/detail?id=406 Should be fixed now in r1917. We actually use real database fields now for the column and sorting appears to work correctly. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 618 in reviewboard: Return a sane response for API calls when Review Board is not set up properly.
Updates: Labels: -Priority-High -Milestone-Release1.0 Priority-Low Milestone-Release1.5 Comment #4 on issue 618 by chipx86: Return a sane response for API calls when Review Board is not set up properly. http://code.google.com/p/reviewboard/issues/detail?id=618 Yeah, less important for now. Pushing it back. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1050 in reviewboard: Screenshot Comment location issue with Chrome
Comment #3 on issue 1050 by chipx86: Screenshot Comment location issue with Chrome http://code.google.com/p/reviewboard/issues/detail?id=1050 We'll take the fix if jQuery 1.3.3 comes out before our 1.0, and doesn't cause any serious regressions like 1.3.2 did. We may end up postponing this to a 1.0.x release, if we need to. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)
Comment #1 on issue 1066 by vesterbaek: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 Type should be changed from Defect to Enhancement -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1063 in reviewboard: post-review perforce HTTP Error 500: Internal Server Error
Updates: Status: NeedInfo Comment #2 on issue 1063 by chipx86: post-review perforce HTTP Error 500: Internal Server Error http://code.google.com/p/reviewboard/issues/detail?id=1063 How did you install PySVN? You need to use the same version of Python for both PySVN and Review Board. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 520 in reviewboard: Sorting reviews by last update sorts alphabetically(!)
Updates: Status: Fixed Labels: Milestone-Release1.0 Comment #3 on issue 520 by chipx86: Sorting reviews by last update sorts alphabetically(!) http://code.google.com/p/reviewboard/issues/detail?id=520 Fixed in r1917. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1066 by vesterbaek: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 It would be useful to to show a status in front of the files in the diff screen. Added src\file.cpp Modified src\file2.cpp Moved src\file3.cpp (moved from src\file4.cpp) Copiedsrc\file5.cpp (copied from src\file6.cpp) Deleted src\file7.cpp The changeset overview in track does this, and it is very helpful to get a quick understanding of what the changes are. The same information could be included with the filenames in the side-by-side diff. Since it seems post-review is just uploading a diff file, this would probably require either adding some extra meta information to the diff file or creating a separate diff-metadata file? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1063 in reviewboard: post-review perforce HTTP Error 500: Internal Server Error
Comment #3 on issue 1063 by madhav.bnk: post-review perforce HTTP Error 500: Internal Server Error http://code.google.com/p/reviewboard/issues/detail?id=1063 Hello chipx86, the python version which I have is 2.4. Can you suggest me the pysvn which is compatible with python2.4? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1050 in reviewboard: Screenshot Comment location issue with Chrome
Comment #4 on issue 1050 by anverc: Screenshot Comment location issue with Chrome http://code.google.com/p/reviewboard/issues/detail?id=1050 Yea, i spoke too soon - the change I linked to fixes something else (i tested it later last night). If I get time later this week I'll look into making a patch for jquery as well as for RB's jquery1.3.2mini -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1068 in reviewboard: Use a Mail Transfer Agent (MTA) to send mail instead of a mail server listening at a TCP/IP port
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1068 by dfrankow: Use a Mail Transfer Agent (MTA) to send mail instead of a mail server listening at a TCP/IP port http://code.google.com/p/reviewboard/issues/detail?id=1068 We have a Debian Linux system with no mail server listening for incoming mail, but with a mail transfer agent (e.g., ssmtp). Most programs we use (e.g., svn's mailer.py) will use the mail transfer agent (MTA) program directly, and not require either an open relay, or putting a user's password in a config file. It would be great if Reviewboard would do the same. Perhaps it could use some Python package to do so? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 984 in reviewboard: Review with no summary can't be selected in administrator mode
Comment #2 on issue 984 by anverc: Review with no summary can't be selected in administrator mode http://code.google.com/p/reviewboard/issues/detail?id=984 It's being created by creating a new review, and discarding it without saving/submitting it. This removes it from your view, however you can still see it in all my requests as well as in the administrator mode. In all my requests it shows up as [Draft] No Summary, in the administrator page it's blank and you have to move your mouse around to find the very small hyperlinked spot where perhaps a space or no text exists. In addition to this, allowing people to delete permanently discarded reviews would be nice. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1068 in reviewboard: Use a Mail Transfer Agent (MTA) to send mail instead of a mail server listening at a TCP/IP port
Comment #1 on issue 1068 by dfrankow: Use a Mail Transfer Agent (MTA) to send mail instead of a mail server listening at a TCP/IP port http://code.google.com/p/reviewboard/issues/detail?id=1068 Note: a more popular example of an MTA is sendmail or qmail. ssmtp emulates sendmail, but is much much simpler in functionality and config. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1069 in reviewboard: semicolon appended to url
Comment #1 on issue 1069 by cordahi: semicolon appended to url http://code.google.com/p/reviewboard/issues/detail?id=1069 Further testing shows it displays correctly in line comments. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1070 in reviewboard: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1070 by ciaomary: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page http://code.google.com/p/reviewboard/issues/detail?id=1070 What's the URL of the page containing the problem? Main review page (ie https://reviewboard/r/3043/) What steps will reproduce the problem? 1. Post a review and publish 2. Click on the 'View diff' page 3. Enter a line number comment and publish 4. Enter another line number comment on the same line number and publish 5. Now click on the 'View Reviews' page Notice that each line number comment is given its own seperate review - whereas we would like the second review to be associated with the first comment. (Often subsequent comments on the same line are in response to the first comment and we'd like to see them as replies both in the GUI and the emails that go out.) Without this functionality, the View Reviews page can be very difficult to follow. Especially when there are many line-by-line reviews going on across multiple users. Please provide any additional information below. We're on RB Beta2. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1070 in reviewboard: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page
Updates: Status: Confirmed Labels: -Type-Defect Type-Enhancement ExtensionIdea Milestone-Release2.0 Component-Reviews Comment #1 on issue 1070 by chipx86: Multiple comments made on View diff page and same line of code are treated as seperate reviews on View Reviews page http://code.google.com/p/reviewboard/issues/detail?id=1070 This is intentional. What you want is another way of viewing reviews, and we won't have that for a while. It would probably be added as an extension. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
