Re: Reviewing diffs of large merges
Review Board can deal with large diffs, but I don't think there's really much in the way of helping reviewers deal with it. The only "help" I can think of is that it will split it across pages in order to avoid having giant web pages to look at (by default 20 files to a page). If there are specific things that you think would be helpful when reviewing very large changes, we'd love to hear about them. -David On Tue, Mar 15, 2011 at 9:00 AM, Bobman wrote: > At my company we have a recurring issue (we use CVS) when we merge a > branch back to the trunk, where (if it has been several months) the > changes and conflicts need to be reviewed by many people. > > Ideally, we would run a diff between the two branches and publish that > for others to review, but a 50,000-line diff is hard to digest without > context. > > Does Review Board work well in this scenario? Does anyone here have > experience with scenarios like this and/or have any suggestions for > how to handle this? > > Thanks. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP and Non Ascii Characters
Could be a browser configuration issue too. Did you ask the person to try from
a different browser?
Eric
On Mar 14, 2011, at 4:45 AM, "daniel.j.la...@googlemail.com"
wrote:
> I am using LDAP to authenticate users in Review board - this obviously
> means I have little control over what people choose as their
> passwords.
>
> Recently one of the users could not log in, after enabling debug we
> saw the following message:
> WARNING - An error while LDAP-authenticating:
> UnicodeEncodeError('ascii', u'BuffySlayer_3\xa3', 13, 14, 'ordinal not
> in range(128)'
>
> It appears the user had a £ sign in their password and this is causing
> authentication issues. Is this a known problem? I had a look and cant
> find anything that indicates that certain characters cannot be used?
>
> I am happy to raise it as a bug if that helps keep a track of this
> issue?
>
> Many thanks
> Dan
>
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-review from windows fails
Hi Ruben,
Are you behind a proxy server? If so, it's possible that post-review is
picking up the proxy settings on Windows, and it's preventing it from
accessing the site correctly.
With 0.3.2, can you run with --debug and provide the output?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Mar 15, 2011 at 2:22 AM, rstm wrote:
> Hello,
>
> Until now I used post-review (RBTools 0.2) from my mac and I can push
> diffs without any trouble to a ReviewBoard 1.5.2. Now I started using
> a Windows client and get strange errors when trying to push a diff.
>
> RBTools 0.3.2:
> I cannot push a diff, I just get the following error message.
> "Unable to access the root /api/ URL on the server."
>
> Surfing to the /api/ folder of my server brings up the expected xml-
> tree. Everything seems fine.
>
> RBTools 0.2:
> Using RBTools 0.2 I get the behavior described in the following post.
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/e9173d6c45648366/aeb8404f789b6de0#aeb8404f789b6de0
>
> Post-Review keeps asking a second time for credentials to the "Web
> API". See the typed command:
> C:\Users\rstein>post-review --submit-as=rstein --diff-
> filename=rbDiff_File --repository-url="https://subversion/dev
> " --server=http://reviewboard.lan --username=cmdlineusr --
> password=DummyPasswd
> ==> Review Board Login Required
> Enter username and password for Review Board at
> http://reviewboard.fme.lan/
> ==> HTTP Authentication Required
> Enter username and password for "Web API" at reviewboard.fme.lan
> Username:
>
> After supplying also the credentials for the Web-API, post-review
> generates a huge error message and dies in recursion like described
> here:
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/c8c20bda63270613/8e8bd93e0ea9dbf9?#8e8bd93e0ea9dbf9
>
> The error message is the following. The part from "line 297 in open"
> repeats all the time:
> Username: Exception RuntimeError: 'maximum recursion depth exceeded in
> __subclasscheck__' in ignored
> Traceback (most recent call last):
> File "C:\Python26\Scripts\post-review-script.py", line 8, in
>
>load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
> ()
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 2857, in main
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 346, in login
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 648, in api_post
> File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
> \postreview.py", line 628, in http_post
> File "C:\Python26\lib\urllib2.py", line 126, in urlopen
>return _opener.open(url, data, timeout)
> ...
>
> File "C:\Python26\lib\urllib2.py", line 397, in open
> response = meth(req, response)
> File "C:\Python26\lib\urllib2.py", line 510, in http_response
> 'http', request, response, code, msg, hdrs)
> File "C:\Python26\lib\urllib2.py", line 429, in error
> result = self._call_chain(*args)
> File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
> result = func(*args)
> File "C:\Python26\lib\urllib2.py", line 855, in http_error_401
> url, req, headers)
> File "C:\Python26\lib\urllib2.py", line 833, in http_error_auth_reqed
> return self.retry_http_basic_auth(host, req, realm)
> File "C:\Python26\lib\urllib2.py", line 843, in retry_http_basic_auth
> return self.parent.open(req, timeout=req.timeout)
> ...
>
> File "C:\Python26\lib\urllib2.py", line 391, in open
>response = self._open(req, data)
> File "C:\Python26\lib\urllib2.py", line 409, in _open
>'_open', req)
> File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
>result = func(*args)
> File "C:\Python26\lib\urllib2.py", line 1161, in http_open
>return self.do_open(httplib.HTTPConnection, req)
> File "C:\Python26\lib\urllib2.py", line 1133, in do_open
>h.request(req.get_method(), req.get_selector(), req.data, headers)
> File "C:\Python26\lib\httplib.py", line 910, in request
>self._send_request(method, url, body, headers)
> File "C:\Python26\lib\httplib.py", line 947, in _send_request
>self.endheaders()
> File "C:\Python26\lib\httplib.py", line 904, in endheaders
>self._send_output()
> File "C:\Python26\lib\httplib.py", line 776, in _send_output
>self.send(msg)
> File "C:\Python26\lib\httplib.py", line 735, in send
>self.connect()
> File "C:\Python26\lib\httplib.py", line 716, in connect
>self.timeout)
> File "C:\Python26\lib\socket.py", line 504, in create_connection
>sock = socket(af, socktype, proto)
> RuntimeError: maximum recursion depth exceeded
>
> The person in this thread speaks of a solution which is not described.
> Christian Hammond also speaks of a mod_wsgi module setting in the
> apache configuration. This is not applicable in my case, since I use
> fastcgi. The mod_wsg
post-review from windows fails
Hello,
Until now I used post-review (RBTools 0.2) from my mac and I can push
diffs without any trouble to a ReviewBoard 1.5.2. Now I started using
a Windows client and get strange errors when trying to push a diff.
RBTools 0.3.2:
I cannot push a diff, I just get the following error message.
"Unable to access the root /api/ URL on the server."
Surfing to the /api/ folder of my server brings up the expected xml-
tree. Everything seems fine.
RBTools 0.2:
Using RBTools 0.2 I get the behavior described in the following post.
http://groups.google.com/group/reviewboard/browse_thread/thread/e9173d6c45648366/aeb8404f789b6de0#aeb8404f789b6de0
Post-Review keeps asking a second time for credentials to the "Web
API". See the typed command:
C:\Users\rstein>post-review --submit-as=rstein --diff-
filename=rbDiff_File --repository-url="https://subversion/dev
" --server=http://reviewboard.lan --username=cmdlineusr --
password=DummyPasswd
==> Review Board Login Required
Enter username and password for Review Board at http://reviewboard.fme.lan/
==> HTTP Authentication Required
Enter username and password for "Web API" at reviewboard.fme.lan
Username:
After supplying also the credentials for the Web-API, post-review
generates a huge error message and dies in recursion like described
here:
http://groups.google.com/group/reviewboard/browse_thread/thread/c8c20bda63270613/8e8bd93e0ea9dbf9?#8e8bd93e0ea9dbf9
The error message is the following. The part from "line 297 in open"
repeats all the time:
Username: Exception RuntimeError: 'maximum recursion depth exceeded in
__subclasscheck__' in ignored
Traceback (most recent call last):
File "C:\Python26\Scripts\post-review-script.py", line 8, in
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
()
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 2857, in main
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 346, in login
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 648, in api_post
File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools
\postreview.py", line 628, in http_post
File "C:\Python26\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
...
File "C:\Python26\lib\urllib2.py", line 397, in open
response = meth(req, response)
File "C:\Python26\lib\urllib2.py", line 510, in http_response
'http', request, response, code, msg, hdrs)
File "C:\Python26\lib\urllib2.py", line 429, in error
result = self._call_chain(*args)
File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
result = func(*args)
File "C:\Python26\lib\urllib2.py", line 855, in http_error_401
url, req, headers)
File "C:\Python26\lib\urllib2.py", line 833, in http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File "C:\Python26\lib\urllib2.py", line 843, in retry_http_basic_auth
return self.parent.open(req, timeout=req.timeout)
...
File "C:\Python26\lib\urllib2.py", line 391, in open
response = self._open(req, data)
File "C:\Python26\lib\urllib2.py", line 409, in _open
'_open', req)
File "C:\Python26\lib\urllib2.py", line 369, in _call_chain
result = func(*args)
File "C:\Python26\lib\urllib2.py", line 1161, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "C:\Python26\lib\urllib2.py", line 1133, in do_open
h.request(req.get_method(), req.get_selector(), req.data, headers)
File "C:\Python26\lib\httplib.py", line 910, in request
self._send_request(method, url, body, headers)
File "C:\Python26\lib\httplib.py", line 947, in _send_request
self.endheaders()
File "C:\Python26\lib\httplib.py", line 904, in endheaders
self._send_output()
File "C:\Python26\lib\httplib.py", line 776, in _send_output
self.send(msg)
File "C:\Python26\lib\httplib.py", line 735, in send
self.connect()
File "C:\Python26\lib\httplib.py", line 716, in connect
self.timeout)
File "C:\Python26\lib\socket.py", line 504, in create_connection
sock = socket(af, socktype, proto)
RuntimeError: maximum recursion depth exceeded
The person in this thread speaks of a solution which is not described.
Christian Hammond also speaks of a mod_wsgi module setting in the
apache configuration. This is not applicable in my case, since I use
fastcgi. The mod_wsgi is not enabled on the server, as I understand
it.
After this I updated my Site to ReviewBoard 1.5.4, which does not
solve any of the described problems. I am confused, as the same
command on my osx machine passes without any problems.
Regards, Ruben
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Reviewing diffs of large merges
At my company we have a recurring issue (we use CVS) when we merge a branch back to the trunk, where (if it has been several months) the changes and conflicts need to be reviewed by many people. Ideally, we would run a diff between the two branches and publish that for others to review, but a 50,000-line diff is hard to digest without context. Does Review Board work well in this scenario? Does anyone here have experience with scenarios like this and/or have any suggestions for how to handle this? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
