What's the mean of ship it!?

2012-02-14 Thread 深圳手机(王)
What's the mean of ship it!? I am puzzled for this question for some time.
 Remind the people don't forget to review the code? or the reviewer accept the 
result?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: What's the mean of ship it!?

2012-02-14 Thread Stein, Ruben
Hi,

as far as I know it is the latter. Since the default workflow design for 
ReviewBoard is to review the code before it is committed, clicking on ship 
it! means to tell the author: Yes, I agree to your changes: Ship it! At 
this, to ship has the meaning of sending or committing the suggested changes 
to the VCS.

Regards, Ruben

From: 深圳手机 (王) 825772...@qq.commailto:825772...@qq.com
Reply-To: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Date: Tue, 14 Feb 2012 17:33:18 +0800
To: reviewboard 
reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Subject: What's the mean of ship it!?

What's the mean of ship it!? I am puzzled for this question for some time.
Remind the people don't forget to review the code? or the reviewer accept the 
result?


--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.commailto:reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Help please -- Installing P4 binding issue

2012-02-14 Thread Christian Hammond
The last error is actually okay. It's just due to how we handle the
installation.

The problem looks to be that Subversion isn't installed. You'll need to
install this first, as that's part of easy_install's installation process
for fetching P4PythonInstaller.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Feb 13, 2012 at 11:18 AM, TaoSun tao.sunr...@gmail.com wrote:

 I am running into trouble on CentOS when I run the command
 easy_install P4PythonInstaller

 [root@reviewboard2 tmp]# easy_install
 P4PythonInstaller
 Searching for P4PythonInstaller
 Reading http://pypi.python.org/simple/P4PythonInstaller/
 Reading http://www.review-board.org/
 Best match: P4PythonInstaller 0.2
 Downloading
 http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller#egg=P4PythonInstaller-0.2
 Doing subversion checkout from
 http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller
 to /tmp/easy_install-zczuPy/P4PythonInstaller
 sh: svn: command not found
 Processing P4PythonInstaller
 error: Couldn't find a setup script in /tmp/easy_install-zczuPy/
 P4PythonInstaller

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: New BitNami Review Board Stack

2012-02-14 Thread ferna...@bitrock.com
Thanks Sridhar, looking forward to your feedback!

Fernando Ruiz

On Feb 13, 11:12 pm, Sridhar Srigiriraju ssridh...@gmail.com wrote:
 Fernando,

 I really appreciate the effort you have taken up. I recently finished
 installing review board on our Linux server and was thoroughly frustrated
 because of all the underlying dependencies. It took me several iterations
 to figure out on how to just get it up and running.

 I will will definitely check this out and let you know feedback, if any

 Thanks
 Sridhar







 On Mon, Feb 13, 2012 at 7:51 AM, Fernando Ruiz ferna...@bitrock.com wrote:
  Hi,

  I am one of the BitNami project developers. We package popular
  opensource web applications and make them
  available as freely available installers, virtual machines and Amazon
  Machine images. I am writing because I wanted to
  let you know that we are working on an installer that greatly
  simplifies the installation of Review Board and runtime dependencies.
  It includes ready-to-run versions of Apache (with mod_wsgi), MySQL,
  Python and Memcached. It also includes integration with Subversion,
  Git and Mercurial out of the box.

  You can download it here:

 http://clients.bitrock.com/**files/reviewboard/20120210/**
  bitnami-reviewboard-1.6.3-0-**linux-installer.runhttp://clients.bitrock.com/files/reviewboard/20120210/bitnami-reviewb...
   md5: 50b1e9f212f09fb13bb988839d2df8**85

 http://clients.bitrock.com/**files/reviewboard/20120210/**
  bitnami-reviewboard-1.6.3-0-**linux-x64-installer.runhttp://clients.bitrock.com/files/reviewboard/20120210/bitnami-reviewb...
   md5: 359dcd6dcee3ea67d263c04aaeee3a**59

  If you have a few minutes, we would appreciate if you can check the
  stack and provide your feedback and suggestions. We plan to release
  the native installers (for Linux), pre-configured virtual machines and
  Amazon Images soon but we would really like to have your feedback
  first, to make sure we
  are not making any dumb mistakes and to learn about any improvement
  suggestions you may have.

  Please let us know if this is not the right place to ask for this kind
  of feedback

  Best regards,

  Fernando Ruiz

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
  Happy user? Let us know 
  athttp://www.reviewboard.org/**users/http://www.reviewboard.org/users/
  -~--~~~~--**~~--~--~---
  To unsubscribe from this group, send email to reviewboard+unsubscribe@**
  googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
  For more options, visit this group athttp://groups.google.com/**
  group/reviewboard?hl=en http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: rb-site install failed - ImportError: Entry point ('console_scripts', 'rb-site') not found

2012-02-14 Thread James
Nelson,

May I ask what version of Django you were on, and what version you upgraded 
to? I'm getting the same error on CentOS 5 with EPEL, using ReviewBoard 
from yum.

Thanks,

- James

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard 1.6.3 and Subversion 1.7.x Compatibility

2012-02-14 Thread phoke
We upgraded to SVN 1.7 when it came out late last year. Unfortunately,
we realized later that ReviewBoard does not have all of the proper
support for SVN 1.7.  There are several other people encountering
similar issues/challenges with SVN 1.7 and ReviewBoard compatibility.
The main issue is due to the fact that the diff output that SVN 1.7
produces contains some new property entries in the diffi file that
ReviewBoard or RB Tools does not seem to understand.

Related thread:
http://code.google.com/p/reviewboard/issues/detail?id=2359

Is there any progress being made on SVN 1.7 compatibility support with
ReviewBoard? This issue seems to have been around for several months
now, but I have not seen any messages that indicate any progress or
when a fix might be be available in a new RB release.

Please let me know if you have any information on this topic.

Thanks for your help!
Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: ReviewBoard 1.6.3 and Subversion 1.7.x Compatibility

2012-02-14 Thread David Trowbridge
The critical issue is that pysvn does not yet support SVN 1.7, and generates
broken results. If someone can find a workaround we're happy to integrate
it,
but otherwise I think we're going to wait for pysvn to update.

-David


On Tue, Feb 14, 2012 at 1:19 PM, phoke paul.w.h...@gmail.com wrote:

 We upgraded to SVN 1.7 when it came out late last year. Unfortunately,
 we realized later that ReviewBoard does not have all of the proper
 support for SVN 1.7.  There are several other people encountering
 similar issues/challenges with SVN 1.7 and ReviewBoard compatibility.
 The main issue is due to the fact that the diff output that SVN 1.7
 produces contains some new property entries in the diffi file that
 ReviewBoard or RB Tools does not seem to understand.

 Related thread:
 http://code.google.com/p/reviewboard/issues/detail?id=2359

 Is there any progress being made on SVN 1.7 compatibility support with
 ReviewBoard? This issue seems to have been around for several months
 now, but I have not seen any messages that indicate any progress or
 when a fix might be be available in a new RB release.

 Please let me know if you have any information on this topic.

 Thanks for your help!
 Paul

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

回复: What's the mean of ship it!?

2012-02-14 Thread 深圳手机(王)
OK.
 thank you very much !
   -- 原始邮件 --
  发件人: Stein, Rubenruben.st...@mevis.fraunhofer.de;
 发送时间: 2012年2月14日(星期二) 下午5:42
 收件人: reviewboard@googlegroups.comreviewboard@googlegroups.com; 
 
 主题: Re: What's the mean of ship it!?

  
 Hi,
 

 as far as I know it is the latter. Since the default workflow design for 
ReviewBoard is to review the code before it is committed, clicking on ship 
it! means to tell the author: Yes, I agree to your changes: Ship it! At 
this, to ship has the meaning of sending or committing the suggested changes 
to the VCS.
 

 Regards, Ruben
 

 From: 深圳手机 (王) 825772...@qq.com
Reply-To: reviewboard@googlegroups.com
Date: Tue, 14 Feb 2012 17:33:18 +0800
To: reviewboard reviewboard@googlegroups.com
Subject: What's the mean of ship it!?

 

  What's the mean of ship it!? I am puzzled for this question for some time.
 Remind the people don't forget to review the code? or the reviewer accept the 
result?
  
 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en 
/:includetail

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Issue 2486 in reviewboard: Comment textarea does not appear after clicking Add comment [Chrome only]

2012-02-14 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2486 by conrad.d...@gmail.com: Comment textarea does not appear  
after clicking Add comment [Chrome only]

http://code.google.com/p/reviewboard/issues/detail?id=2486

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running? 1.6.1


What's the URL of the page containing the problem?

reviewboard.eng.vmware.com (not public)

What steps will reproduce the problem?
1. Go to a review.
2. Click Add comment in one of the reviews at the bottom.
3.

What is the expected output? What do you see instead?

Expect to see a textarea to type my comment into. Instead, nothing.  
The Add comment link goes away.


What operating system are you using? What browser?

Mac OSX 10.6.8. Google Chrome 17.0.963.46.

Please provide any additional information below.

Works fine in Safari and Firefox. Screenshots enclosed showing before and  
after clicking Add comment.


Attachments:
Screen shot 2012-02-14 at 2.16.00 PM.png  17.6 KB
Screen shot 2012-02-14 at 2.16.15 PM.png  19.2 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2486 in reviewboard: Comment textarea does not appear after clicking Add comment [Chrome only]

2012-02-14 Thread reviewboard

Updates:
Status: ThirdParty

Comment #1 on issue 2486 by trowb...@gmail.com: Comment textarea does not  
appear after clicking Add comment [Chrome only]

http://code.google.com/p/reviewboard/issues/detail?id=2486

This is due to an adblock bug. If you go to your adblock preferences and  
force an update of the definitions, it should fix it.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2487 in reviewboard: Cannot update diff on another user's review

2012-02-14 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2487 by bill...@gmail.com: Cannot update diff on another user's  
review

http://code.google.com/p/reviewboard/issues/detail?id=2487

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.6.3

What's the URL of the page containing the problem?

http://billdesktop2/reviewboard/r/NNN/

What steps will reproduce the problem?
1. User A publishes a review request
2. User B clicks Update Diff and uploads a diff

What is the expected output? What do you see instead?

I expect that User B would now see the updated diff and be able to publish  
it.  Instead, only User A can see it, so User B must ask User A to publish  
the change.


What operating system are you using? What browser?

Server: Ubuntu 11.10
Client: Windows 7, Chrome 16

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2264 in reviewboard: Updating a diff when not owner causes problems

2012-02-14 Thread reviewboard


Comment #1 on issue 2264 by trowb...@gmail.com: Updating a diff when not  
owner causes problems

http://code.google.com/p/reviewboard/issues/detail?id=2264

Issue 2487 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2464 in reviewboard: diff view hangs

2012-02-14 Thread reviewboard


Comment #3 on issue 2464 by w.sitni...@gmail.com: diff view hangs
http://code.google.com/p/reviewboard/issues/detail?id=2464

This is because of obsolete Chrome 14.0.785.0 installed on my CentOS, in  
Firefox everything is ok. Can be closed


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.