Re: Failed upgrade from 1.6.4.1 to 1.6.8 (evolution failed)
Hi, I got the same or similar problem when upgrading reviewboard site ( rb-site upgrade ) from 1.6.7.1 to 1.6.9. easy_install worked OK, but it was rb-site upgrade that failed: # easy_install -U ReviewBoard Searching for ReviewBoard Reading http://pypi.python.org/simple/ReviewBoard/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.5/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ReviewBoard/1.0/ Reading http://downloads.review-board.org/releases/ Best match: ReviewBoard 1.6.9 Downloading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ReviewBoard-1.6.9-py2.7.egg Processing ReviewBoard-1.6.9-py2.7.egg creating /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.9-py2.7.egg Extracting ReviewBoard-1.6.9-py2.7.egg to /usr/local/lib/python2.7/dist-packages Removing ReviewBoard 1.6.7.1 from easy-install.pth file Adding ReviewBoard 1.6.9 to easy-install.pth file Installing rb-site script to /usr/local/bin Installing rbssh script to /usr/local/bin Installed /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.9-py2.7.egg Reading http://downloads.reviewboard.org/mirror/ Processing dependencies for ReviewBoard Searching for Djblets==0.6.19 Reading http://pypi.python.org/simple/Djblets/ Reading http://www.review-board.org/wiki/Djblets Reading http://downloads.review-board.org/releases/Djblets/0.6/ Reading http://www.reviewboard.org/wiki/Djblets Reading http://downloads.review-board.org/releases/Djblets/0.5/ Best match: Djblets 0.6.19 Downloading http://downloads.reviewboard.org/releases/Djblets/0.6/Djblets-0.6.19-py2.7.egg Processing Djblets-0.6.19-py2.7.egg creating /usr/local/lib/python2.7/dist-packages/Djblets-0.6.19-py2.7.egg Extracting Djblets-0.6.19-py2.7.egg to /usr/local/lib/python2.7/dist-packages Removing Djblets 0.6.18 from easy-install.pth file Adding Djblets 0.6.19 to easy-install.pth file # rb-site upgrade /var/www/reviews.aas.priv/ Rebuilding directory structure Updating database. This may take a while. Creating tables ... Upgrading Review Board from 1.6.7.1 to 1.6.9 Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: Field 'extra_data' has been added Field 'hosting_account' has been added Error: Your models contain changes that Django Evolution cannot resolve automatically. Thus for now, I have not restarted apache or memcached, and the reviewboard website still says 1.6.7.1 One thing that happened before the upgrade of reviewboard ( before easy_install -U ReviewBoard ) was that mysql was updated via apt-get: From /var/log/apt/history.log: Start-Date: 2012-06-15 14:44:20 Commandline: apt-get upgrade -V Upgrade: mysql-server:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), libapparmor-perl:amd64 (2.7.0~beta1+bzr1774-1ubuntu2, 2.7.0~beta1+bzr1774-1ubuntu2.1), libmysqlclient-dev:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-server-core-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), libmysqlclient16:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client-core-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), linux-tools-common:amd64 (3.0.0-20.34, 3.0.0-21.35), linux-libc-dev:amd64 (3.0.0-20.34, 3.0.0-21.35), mysql-common:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-server-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1) End-Date: 2012-06-15 14:45:11 Regards, John On Tuesday, 12 June 2012 18:14:46 UTC+10, Antti Paajoki wrote: Hi, We've been happily running reviewboard for some time and now tried to upgrade from 1.6.4.1 to 1.6.8. Unfortunately, it was not a immediate success. Reviewboard upgrade with easy_install goes without errors, but the site upgrade fails during Django Evolution. [start of log] $ rb-site upgrade /path/to/reviewboard Rebuilding directory structure Updating database. This may take a while. /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/db/__init__.py:60: DeprecationWarning: Short names for ENGINE in database configurations are deprecated. Prepend default.ENGINE with 'django.db.backends.' DeprecationWarning Creating tables ... Creating table hostingsvcs_hostingserviceaccount Upgrading Review Board from 1.6.4.1 to 1.6.8 There are unapplied evolutions for scmtools. Adding baseline version for new models Project signature has changed - an evolution is required Installing
Do we support MDaemon for Authentication to RB server
Hi All, This is VERY URGENT !! Please let me know if RB support MDaemon for authentication, if yes then how to configure on RB server, if not then how to use MDaemon with RB server. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Do we support MDaemon for Authentication to RB server
Review Board does not have specific support. In fact, I've never heard of MDaemon before. It looks like it's a mail server, which means that I have no idea what it would mean to use MDaemon for authentication -David On Jun 15, 2012, at 12:30 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, This is VERY URGENT !! Please let me know if RB support MDaemon for authentication, if yes then how to configure on RB server, if not then how to use MDaemon with RB server. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Failed upgrade from 1.6.4.1 to 1.6.8 (evolution failed)
Can you tell me what version of django-evolution is installed? What version of RB did you start with? Christian On Jun 14, 2012, at 22:20, jms jesus.m.sa...@gmail.com wrote: Hi, I got the same or similar problem when upgrading reviewboard site ( rb-site upgrade ) from 1.6.7.1 to 1.6.9. easy_install worked OK, but it was rb-site upgrade that failed: # easy_install -U ReviewBoard Searching for ReviewBoard Reading http://pypi.python.org/simple/ReviewBoard/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.5/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ReviewBoard/1.0/ Reading http://downloads.review-board.org/releases/ Best match: ReviewBoard 1.6.9 Downloading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ReviewBoard-1.6.9-py2.7.egg Processing ReviewBoard-1.6.9-py2.7.egg creating /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.9-py2.7.egg Extracting ReviewBoard-1.6.9-py2.7.egg to /usr/local/lib/python2.7/dist-packages Removing ReviewBoard 1.6.7.1 from easy-install.pth file Adding ReviewBoard 1.6.9 to easy-install.pth file Installing rb-site script to /usr/local/bin Installing rbssh script to /usr/local/bin Installed /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.9-py2.7.egg Reading http://downloads.reviewboard.org/mirror/ Processing dependencies for ReviewBoard Searching for Djblets==0.6.19 Reading http://pypi.python.org/simple/Djblets/ Reading http://www.review-board.org/wiki/Djblets Reading http://downloads.review-board.org/releases/Djblets/0.6/ Reading http://www.reviewboard.org/wiki/Djblets Reading http://downloads.review-board.org/releases/Djblets/0.5/ Best match: Djblets 0.6.19 Downloading http://downloads.reviewboard.org/releases/Djblets/0.6/Djblets-0.6.19-py2.7.egg Processing Djblets-0.6.19-py2.7.egg creating /usr/local/lib/python2.7/dist-packages/Djblets-0.6.19-py2.7.egg Extracting Djblets-0.6.19-py2.7.egg to /usr/local/lib/python2.7/dist-packages Removing Djblets 0.6.18 from easy-install.pth file Adding Djblets 0.6.19 to easy-install.pth file # rb-site upgrade /var/www/reviews.aas.priv/ Rebuilding directory structure Updating database. This may take a while. Creating tables ... Upgrading Review Board from 1.6.7.1 to 1.6.9 Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: Field 'extra_data' has been added Field 'hosting_account' has been added Error: Your models contain changes that Django Evolution cannot resolve automatically. Thus for now, I have not restarted apache or memcached, and the reviewboard website still says 1.6.7.1 One thing that happened before the upgrade of reviewboard ( before easy_install -U ReviewBoard ) was that mysql was updated via apt-get: From /var/log/apt/history.log: Start-Date: 2012-06-15 14:44:20 Commandline: apt-get upgrade -V Upgrade: mysql-server:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), libapparmor-perl:amd64 (2.7.0~beta1+bzr1774-1ubuntu2, 2.7.0~beta1+bzr1774-1ubuntu2.1), libmysqlclient-dev:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-server-core-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), libmysqlclient16:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client-core-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), linux-tools-common:amd64 (3.0.0-20.34, 3.0.0-21.35), linux-libc-dev:amd64 (3.0.0-20.34, 3.0.0-21.35), mysql-common:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-server-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1), mysql-client-5.1:amd64 (5.1.62-0ubuntu0.11.10.1, 5.1.63-0ubuntu0.11.10.1) End-Date: 2012-06-15 14:45:11 Regards, John On Tuesday, 12 June 2012 18:14:46 UTC+10, Antti Paajoki wrote: Hi, We've been happily running reviewboard for some time and now tried to upgrade from 1.6.4.1 to 1.6.8. Unfortunately, it was not a immediate success. Reviewboard upgrade with easy_install goes without errors, but the site upgrade fails during Django Evolution. [start of log] $ rb-site upgrade /path/to/reviewboard Rebuilding directory structure Updating database. This may take a while. /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/db/__init__.py:60: DeprecationWarning: Short names for ENGINE in database configurations are deprecated. Prepend default.ENGINE with 'django.db.backends.' DeprecationWarning
Re: Do we support MDaemon for Authentication to RB server
If we are do have support, then how to help end user with this type of authentication in there organization. http://www.altn.com/Products/MDaemon-Email-Server-Windows/ On Fri, Jun 15, 2012 at 1:11 PM, David Trowbridge trowb...@gmail.comwrote: Review Board does not have specific support. In fact, I've never heard of MDaemon before. It looks like it's a mail server, which means that I have no idea what it would mean to use MDaemon for authentication -David On Jun 15, 2012, at 12:30 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, This is VERY URGENT !! Please let me know if RB support MDaemon for authentication, if yes then how to configure on RB server, if not then how to use MDaemon with RB server. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
HOW to avoiding publishing a review request if no user present in people/group
Hi All, Can you provide me rule which will avoid publishing review request if the people/group list is empty. Regards, Nilesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: HOW to avoiding publishing a review request if no user present in people/group
If there are no assigned people or groups, it already will prevent publishing (at least through the web UI; I'm not sure about post-review -p). -David On Fri, Jun 15, 2012 at 6:39 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, Can you provide me rule which will avoid publishing review request if the people/group list is empty. Regards, Nilesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Do we support MDaemon for Authentication to RB server
I don't think you read my email at all. Please do so before responding again. -David On Fri, Jun 15, 2012 at 1:53 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: If we are do have support, then how to help end user with this type of authentication in there organization. http://www.altn.com/Products/MDaemon-Email-Server-Windows/ On Fri, Jun 15, 2012 at 1:11 PM, David Trowbridge trowb...@gmail.com wrote: Review Board does not have specific support. In fact, I've never heard of MDaemon before. It looks like it's a mail server, which means that I have no idea what it would mean to use MDaemon for authentication -David On Jun 15, 2012, at 12:30 AM, Nilesh Jaiswal nileshj...@gmail.com wrote: Hi All, This is VERY URGENT !! Please let me know if RB support MDaemon for authentication, if yes then how to configure on RB server, if not then how to use MDaemon with RB server. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
post review for a specific mercurial changeset
Hi, We're using hg postreview extension with RB. How do we submit a review for a specific changeset if we've multiple outgoing changesets? For example, if we have local changesets 1, 2, 3 and I want to submit a review for 2. Running hg postreview 2 would include all three changesets. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Hi, Deleted that column, and a few more that came up, then got stuck at this one: Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1091, Can't DROP 'name'; check that column/key exists) Regarding exactly what I did, cant say exactly, but I just followed the usual upgrade procedures, it worked fine when I did 1.5 to 1.5.5. The difference with this one is that I had just done an 'do-release-upgrade' on the underlying OS, this then broke reviewboard as it wanted me to then upgrade which I did, then these issues came up. This is getting urgent now so if I cant recolve it today I may have to just wipe it and start again. Thanks for your help. Gav... On Sunday, June 10, 2012 1:26:38 PM UTC+9:30, Christian Hammond wrote: No, that should never have been reached. That shows you're in some half-modified database state, which shouldn't have happened, given that database transactions are used during the evolution and the earlier error should have prevented the other modifications. At this point, I really wish you had a database upgrade, because things are kind of messed up. Make one now, just in case. Once you have a full backup (SQL dump is best), try deleting that column. You might get a few more like this. Can you tel me exactly what you did, every step of the way, prior to and after the initial rb-site upgrade? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 8:47 PM, Gav... ipv6g...@gmail.com wrote: On Sunday, June 10, 2012 1:04:30 PM UTC+9:30, Christian Hammond wrote: Your upgrade apparently also upgraded to Review Board 1.6.7, which has many significant changes. And that upgrade failed, because of the django_session issue. I've seen that django_session error before. Not sure what the cause is, but basically, that's a database index that was created, and Django is trying to re-create it now. You can try dropping it and see if that helps. You'll need to connect to your MySQL database and do: drop index django_session_c25c2c28 on django_session; Then re-run the rb-site upgrade command on your site. Hopefully this will work. Christian Thanks for the reply, done that, now I get: Error: Error applying evolution: (1060, Duplicate column name 'is_private') Drop that too? from where? Thanks Gav... -- On Sat, Jun 9, 2012 at 7:43 PM, Gav... ipv6g...@gmail.com wrote: Hi, I was on RB 1.5.5 , then an upgrade of the Ubuntu OS to 12.04 LTS then broke reviewboard (so it wanted to upgrade) so I ran an upgrade which has not been successful. (Note I believe Python was upgraded from 2.6 to 2.7) It seems to work until you go to the /admin/ areas. Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1061, Duplicate key name 'django_session_c25c2c28') Tried this with the latest version 1.6.7.1 I also get emails with: OperationalError: (1054, Unknown column 'scmtools_repository.extra_**data' in 'field list') Any clues as to what to try next.? As I was not expecting an OS upgrade to interfere with reviewboard, there is no pre-upgrade db dump, and a rb-site manage . dbdump now fails with : _mysql_exceptions.**OperationalError: (1054, Unknown column 'scmtools_repository.extra_**data' in 'field list') Thanks Gav... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscribe@* *googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at
Re: How to add comments at each diff section
Hi, Hmm, either I'm misunderstanding, or you guys aren't using commenting properly. You should be able to click and drag line numbers in the diff viewer to select a comment range. You'll get a comment box where you can type your comment. When you've added every comment you need, publish the review. You shouldn't have to write your comments on the review page. Christian On Jun 15, 2012, at 14:50, Kunjal kunjal.par...@gmail.com wrote: Chris, Hello, and how are you? We are using RB for large scale development and mostly for each review we have number of diffs to review. The way the comments addition works, there is no way to add comment right at the diff so we the reviewer know which lines of code needs attention. The comment section is entirely different from view diff section so one has to remember all the diff comments and come back to comments page and input all the comments. Do you plan solution to this issue in one of the next releases? Thanks Kunjal Broadcom Inc. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to add comments at each diff section
Thanks... You solved my problem On Friday, June 15, 2012 5:25:52 PM UTC-7, Christian Hammond wrote: Hi, Hmm, either I'm misunderstanding, or you guys aren't using commenting properly. You should be able to click and drag line numbers in the diff viewer to select a comment range. You'll get a comment box where you can type your comment. When you've added every comment you need, publish the review. You shouldn't have to write your comments on the review page. Christian On Jun 15, 2012, at 14:50, Kunjal kunjal.par...@gmail.com wrote: Chris, Hello, and how are you? We are using RB for large scale development and mostly for each review we have number of diffs to review. The way the comments addition works, there is no way to add comment right at the diff so we the reviewer know which lines of code needs attention. The comment section is entirely different from view diff section so one has to remember all the diff comments and come back to comments page and input all the comments. Do you plan solution to this issue in one of the next releases? Thanks Kunjal Broadcom Inc. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 2637 in reviewboard: Test button for email
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2637 by bay.jame...@gmail.com: Test button for email http://code.google.com/p/reviewboard/issues/detail?id=2637 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.6 What's the URL of the page this enhancement relates to, if any? /reviews/admin/settings/email/ Describe the enhancement and the motivation for it. A test button would help confirm that email is working, and facilitate troubleshooting. What operating system are you using? What browser? Red Hat Linux, Firefox Please provide any additional information below. My Review Board system is all set up. I created a review invitation and sent it out to our team. But no one got an email notification. I can't tell if, since this is my first experience with the software, that perhaps I did the whole review invitation thing wrong and no mail should have gone out, of if my email configuration setting is wrong, and needs to be fixed. Sending a test message (and returning status?) would be very helpful during set-up and troubleshooting. Jim -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text or clicking hyperlinks
Comment #10 on issue 1893 by trowb...@gmail.com: Fields shouldn't become editable when selecting text or clicking hyperlinks http://code.google.com/p/reviewboard/issues/detail?id=1893 Issue 2636 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2636 in reviewboard: Text selection in editable fields is broken
Updates: Status: Duplicate Mergedinto: 1893 Comment #2 on issue 2636 by trowb...@gmail.com: Text selection in editable fields is broken http://code.google.com/p/reviewboard/issues/detail?id=2636 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2638 in reviewboard: Linked or grouped reviews as a feature-review-group
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2638 by carl.van...@gmail.com: Linked or grouped reviews as a feature-review-group http://code.google.com/p/reviewboard/issues/detail?id=2638 What version are you running? 1.6.3 What's the URL of the page this enhancement relates to, if any? Dashboard, Geneneral Describe the enhancement and the motivation for it. We often make modifications to multiple repositories in the course of implementing a 'feature' which need to be atomically merged into our mainline branches. Reviewboard handles multiple repos etc just fine, but it would be really great if we could have a concept of 'feature' which links together multiple reviews, with the 'feature' having its own status 'Ship-it', 'Partial-Shipit', 'unreviewed', etc. This would make tracking the status of a feature much simpler for us and let us see from a high level the features status. In the dashboard, grouping all the reviews for a feature together would be nice as well, possibly with the ability to expand/collapse the group. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
