Re: Git repository setting
Hi Christian, I noticed this issue was discovered last year. Have you solved the bitbucket git integration issue? Thank you! Yang. On Sunday, July 1, 2012 11:16:03 PM UTC-7, Christian Hammond wrote: You'd need to upload the private key to Review Board. Review Board needs a key it can use to authenticate with other services, and a public key is no more useful to it than it would be for you if you were to try to SSH into another box. It's important to know that BitBucket's Git support in their API is broken, and useless to us. Unfortunately, until they fix that, it's impossible to use a third-party service to integrate with BitBucket to fetch files with the revision information contained in a diff. I've been in contact with BitBucket, and they're aware of the problem, but there's no ETA on it, unfortunately. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jul 1, 2012 at 11:12 PM, Michael Fang airfa...@gmail.comjavascript: wrote: Hey Chris, Thanks for replying. I understand now (at least we have a last resort). Our code is also hosted on Bitbucket using git, but I noticed that RB doesn't support git for Bitbucket (the dropdown menu has only mercurial), so I also tried to set it up manually: Hosting service: None Repository type: Git Path: ssh://g...@bitbucket.org/USERNAME/PROJECT.git Mirror Path: g...@bitbucket.org:USERNAME/PROJECT.git Raw file URL mask: https://api.bitbucket.org/1.0/repositories/USERNAME/PROJECT/raw/ revision/filename When I click save, RB asks me to either upload a ssh key or generate one, I tried upload a public key that worked for me but RB says Error uploading SSH key: this SSH key is not a valid RSA or DSS key. If I use the generated one, when I click save RB would say Unable to authenticate against this repository using one of the supported authentication types (publickey) Is there anything thing wrong with my settings? On Sunday, July 1, 2012 11:57:49 AM UTC-7, Christian Hammond wrote: Hi Michael, RB doesn't manage the clone at all. You'd need a script to keep it up-to-date. What we strongly recommend is to use something like cgit/gitweb on the server with the Git repository, and use that for access. Sounds like that's a problem with Heroku though? Can you go into more detail about that? Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jul 1, 2012 at 4:02 AM, Michael Fang airfa...@gmail.comjavascript: wrote: Hi RB devs, thanks for such a cool tool. I am trying to set up a custom git repo (since my app was hosted on Heroku, it doesn't seem to have web access for remote files). I guess my only bet is to use the local clone approach described here? http://www.reviewboard.**org/docs/manual/dev/admin/** configuration/repositories/#**local-clonehttp://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/#local-clone If I understand the doc correctly, am I responsible for keeping the local clone on the RB server in sync, or RB will automatically pull the latest version of the files via mirror path whenever a review request is posted? Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard...@** googlegroups.com javascript: For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Git repository setting
Unfortunately not. We've repeatedly asked BitBucket if they can implement the relatively trivial API that ReviewBoard needs, and as of yet they haven't. -David On Sun, May 19, 2013 at 11:07 PM, Yang Fan bunnyc1...@gmail.com wrote: Hi Christian, I noticed this issue was discovered last year. Have you solved the bitbucket git integration issue? Thank you! Yang. On Sunday, July 1, 2012 11:16:03 PM UTC-7, Christian Hammond wrote: You'd need to upload the private key to Review Board. Review Board needs a key it can use to authenticate with other services, and a public key is no more useful to it than it would be for you if you were to try to SSH into another box. It's important to know that BitBucket's Git support in their API is broken, and useless to us. Unfortunately, until they fix that, it's impossible to use a third-party service to integrate with BitBucket to fetch files with the revision information contained in a diff. I've been in contact with BitBucket, and they're aware of the problem, but there's no ETA on it, unfortunately. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jul 1, 2012 at 11:12 PM, Michael Fang airfa...@gmail.com wrote: Hey Chris, Thanks for replying. I understand now (at least we have a last resort). Our code is also hosted on Bitbucket using git, but I noticed that RB doesn't support git for Bitbucket (the dropdown menu has only mercurial), so I also tried to set it up manually: Hosting service: None Repository type: Git Path: ssh://g...@bitbucket.org/**USERNAME/PROJECT.githttp://g...@bitbucket.org/USERNAME/PROJECT.git Mirror Path: g...@bitbucket.org:USERNA**ME/PROJECT.git Raw file URL mask: https://api.bitbucket.** org/1.0/repositories/USERNAME/**PROJECT/raw/https://api.bitbucket.org/1.0/repositories/USERNAME/PROJECT/raw/ revision/**filename When I click save, RB asks me to either upload a ssh key or generate one, I tried upload a public key that worked for me but RB says Error uploading SSH key: this SSH key is not a valid RSA or DSS key. If I use the generated one, when I click save RB would say Unable to authenticate against this repository using one of the supported authentication types (publickey) Is there anything thing wrong with my settings? On Sunday, July 1, 2012 11:57:49 AM UTC-7, Christian Hammond wrote: Hi Michael, RB doesn't manage the clone at all. You'd need a script to keep it up-to-date. What we strongly recommend is to use something like cgit/gitweb on the server with the Git repository, and use that for access. Sounds like that's a problem with Heroku though? Can you go into more detail about that? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jul 1, 2012 at 4:02 AM, Michael Fang airfa...@gmail.comwrote: Hi RB devs, thanks for such a cool tool. I am trying to set up a custom git repo (since my app was hosted on Heroku, it doesn't seem to have web access for remote files). I guess my only bet is to use the local clone approach described here? http://www.reviewboard.**o**rg/docs/manual/dev/admin/**confi** guration/repositories/#**local-**clonehttp://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/#local-clone If I understand the doc correctly, am I responsible for keeping the local clone on the RB server in sync, or RB will automatically pull the latest version of the files via mirror path whenever a review request is posted? Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**don**ate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**use**rs/http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@**google* *groups.com For more options, visit this group at http://groups.google.com/**group **/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard...@** googlegroups.com For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For
Re: Error: Error applying evolution: (1051, Unknown table 'auth_message'). Occurred from upgrading from 1.6.13 to 1.7.7.1
Dear Christian, Version of Django Evolution is 0.6.9. Michael On Mon, May 20, 2013 at 3:07 AM, Christian Hammond chip...@gmail.comwrote: Hi Michael, Can you check what version of Django Evolution you have installed? You should try to upgrade that if it's below 0.6.9. Christian On May 19, 2013, at 5:47, Michael Zhu boot2li...@gmail.com wrote: Dear all, # rb-site upgrade path/to/reviewboard Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for accounts. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Error: Error applying evolution: (1051, Unknown table 'auth_message') If I force to start server, error message is reported on some review requests. Error log is below: Traceback (most recent call last): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.7/site-packages/ReviewBoard-1.7.7.1-py2.7.egg/reviewboard/accounts/decorators.py, line 22, in _check return view_func(*args, **kwargs) File /usr/lib/python2.7/site-packages/ReviewBoard-1.7.7.1-py2.7.egg/reviewboard/reviews/views.py, line 538, in review_detail objs = list(q) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/query.py, line 87, in __len__ self._result_cache.extend(self._iter) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/query.py, line 291, in iterator for row in compiler.results_iter(): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/sql/compiler.py, line 763, in results_iter for rows in self.execute_sql(MULTI): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/sql/compiler.py, line 818, in execute_sql cursor.execute(sql, params) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/backends/mysql/base.py, line 114, in execute return self.cursor.execute(query, args) File /usr/lib/python2.7/site-packages/MySQLdb/cursors.py, line 174, in execute self.errorhandler(self, exc, value) File /usr/lib/python2.7/site-packages/MySQLdb/connections.py, line 36, in defaulterrorhandler raise errorclass, errorvalue DatabaseError: (1054, Unknown column 'reviews_fileattachmentcomment.extra_data' in 'field list') Michael -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Error: Error applying evolution: (1051, Unknown table 'auth_message'). Occurred from upgrading from 1.6.13 to 1.7.7.1
Hi Michael, Can you run the following for me and show me the output: $ rb-site manage /path/to/site list-evolutions It sounds like it's trying to apply an evolution due to thinking your database has something (based on a previous evolution-stored signature showing you had it), but it's not actually in the database. The auth_message table is something that was in prior versions of Django, and isn't now. The evolution we had erases it. A workaround might be to manually create a dummy auth_message table in the database. At any point, did you do anything manual with the database? Do you know what version of Django you were using with RB 1.6.13? Also, what prior versions of Review Board do you remember using? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On May 20, 2013, at 12:36 AM, Michael Zhu boot2li...@gmail.com wrote: Dear Christian, Version of Django Evolution is 0.6.9. Michael On Mon, May 20, 2013 at 3:07 AM, Christian Hammond chip...@gmail.com wrote: Hi Michael, Can you check what version of Django Evolution you have installed? You should try to upgrade that if it's below 0.6.9. Christian On May 19, 2013, at 5:47, Michael Zhu boot2li...@gmail.com wrote: Dear all, # rb-site upgrade path/to/reviewboard Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for accounts. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Error: Error applying evolution: (1051, Unknown table 'auth_message') If I force to start server, error message is reported on some review requests. Error log is below: Traceback (most recent call last): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.7/site-packages/ReviewBoard-1.7.7.1-py2.7.egg/reviewboard/accounts/decorators.py, line 22, in _check return view_func(*args, **kwargs) File /usr/lib/python2.7/site-packages/ReviewBoard-1.7.7.1-py2.7.egg/reviewboard/reviews/views.py, line 538, in review_detail objs = list(q) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/query.py, line 87, in __len__ self._result_cache.extend(self._iter) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/query.py, line 291, in iterator for row in compiler.results_iter(): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/sql/compiler.py, line 763, in results_iter for rows in self.execute_sql(MULTI): File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/models/sql/compiler.py, line 818, in execute_sql cursor.execute(sql, params) File /usr/lib/python2.7/site-packages/Django-1.4.5-py2.7.egg/django/db/backends/mysql/base.py, line 114, in execute return self.cursor.execute(query, args) File /usr/lib/python2.7/site-packages/MySQLdb/cursors.py, line 174, in execute self.errorhandler(self, exc, value) File /usr/lib/python2.7/site-packages/MySQLdb/connections.py, line 36, in defaulterrorhandler raise errorclass, errorvalue DatabaseError: (1054, Unknown column 'reviews_fileattachmentcomment.extra_data' in 'field list') Michael -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you
Re: Instant Messaging (XMPP) extension
Hi,
I just tried installing this (easy_install) and ran into some problems
after configuration:
1. I noticed it added a new (broken) link to the dashboard which (when
clicked) gives a traceback ending with
TemplateDoesNotExist: rbxmppnotification/dashboard.html
Is this link supposed to exist?
2. With regards the actual sending of Jabber messages, I get some nasty
tracebacks in the reviewboard log
Traceback (most recent call last):
File
/usr/local/lib/python2.7/dist-packages/RBXmppNotification-0.2-py2.7.egg/rbxmppnotification/xmpp.py,
line 239, in send_xmpp_message
client.run()
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/client.py,
line 216, in run
self.main_loop.loop(timeout)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/mainloop/base.py,
line 86, in loop
self.loop_iteration(interval)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/mainloop/poll.py,
line 140, in loop_iteration
self._handlers[fileno].handle_read()
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/transport.py,
line 717, in handle_read
self._feed_reader(data)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/transport.py,
line 810, in _feed_reader
self._reader.feed(data)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppparser.py,
line 212, in feed
self.parser.feed(data)
File /usr/lib/python2.7/xml/etree/ElementTree.py, line 1641, in feed
self._parser.Parse(data, 0)
File /usr/lib/python2.7/xml/etree/ElementTree.py, line 1550, in _end
return self.target.end(self._fixname(tag))
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppparser.py,
line 158, in end
self._handler.stream_element(element)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/streambase.py,
line 367, in stream_element
self._process_element(element)
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/streambase.py,
line 510, in _process_element
logger.debug(Got features element: {0}.format(serialize(element)))
File
/usr/local/lib/python2.7/dist-packages/pyxmpp2-2.0alpha2-py2.7.egg/pyxmpp2/xmppserializer.py,
line 365, in serialize
if _THREAD.serializer is None:
AttributeError: 'thread._local' object has no attribute 'serializer'
The alpha2 status of pyxmpp2 worried me, so I checked out the page on
PyPi for other versions, and it seems to have been alpha2 since 2011-07-10!
My Google-fu didn't lead me to finding any fixes for this issue, so I
hacked around it (the serialize() was only used in logging.debug
statements, which I commented out. Was this working for you?
With this change, it seems to now be working for me (and spamming my
colleagues :D)
Adam
On 18 May 2013 17:36, Horatiu Eugen VLAD horatiu.v...@gmail.com wrote:
Hi,
I have open-sourced a some time ago an Instant Messaging (XMPP) extension
for Review board. The feature set is basic at it just a mirroring the email
notification behavior.
Code can be downloaded from:
https://github.com/iconoeugen/rb-xmpp-notification
For installation follow the next steps:
using pip:
sudo pip install RBXmppNotification
using easy_install:
sudo easy_install RBXmppNotification
from source:
git clone https://github.com/iconoeugen/rb-xmpp-notification
cd RBXmppNotification
sudo python setup.py build install
Restart your web server running review board
Login in to review board as administrator
Go to Admin panel - Extensions
In the 'MANAGE EXTENSIONS' page, enable 'RBXmppNotification'
Configure 'RBXmppNotification' with the XMPP server and sender details.
Click on 'Save'
Any feedback is welcomed,
H
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this
Creating a review with Python API
Hi,
I've been trying to following the documentation here:
http://www.reviewboard.org/docs/rbtools/0.5/api/tutorial/
To create a review for a existing review request, and then add a comment to
the review. Unfortunately I'm not getting far.
I've tried the following:
root = client.get_root()
repos = root.get_repositories()
if repos.num_items 1:
raise Exception('No valid repositories.')
repository = repos[0].id
review_request = root.get_review_requests().get_self(id='15583',
repository=repository)
review = review_request.get_reviews().create()
filediff_id = review.get_diffs()[0].get_files()[0].id
review.get_diff_comments().create(
filediff_id=1,
first_line=131,
num_lines=2,
text='This is a diff comment!')
review.update(body_top='Test Review Comment - please ignore', public=True)
I get the error: AttributeError: 'ResourceList' object has no attribute
'get_reviews'
So it looks like root.get_review_requests().get_self(id='15583',
repository=repository) isn't the right request to return an existing review
request ?
Any help would be much appreciated.
Cheers
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Creating a review with Python API
Hi,
'root.get_review_requests().get_self(id='15583', repository=repository)'
will result in a
GET http://.../api/review_requests/?id=15583repository=id
What you're looking for is 'root.get_review_requests().get_item(15583)', or
alternatively 'root.get_review_request(review_request_id=15583). The former
traverses the tree of resources, while the latter uses the root resource's
uri-template for 'review-request'.
Additionally, retrieving the id of the repository is unnecessary to find
the review request with the ID you are looking for.
On Mon, May 20, 2013 at 8:50 AM, Dave Johnston dave.johns...@me.com wrote:
Hi,
I've been trying to following the documentation here:
http://www.reviewboard.org/docs/rbtools/0.5/api/tutorial/
To create a review for a existing review request, and then add a comment
to the review. Unfortunately I'm not getting far.
I've tried the following:
root = client.get_root()
repos = root.get_repositories()
if repos.num_items 1:
raise Exception('No valid repositories.')
repository = repos[0].id
review_request = root.get_review_requests().get_self(id='15583',
repository=repository)
review = review_request.get_reviews().create()
filediff_id = review.get_diffs()[0].get_files()[0].id
review.get_diff_comments().create(
filediff_id=1,
first_line=131,
num_lines=2,
text='This is a diff comment!')
review.update(body_top='Test Review Comment - please ignore', public=True)
I get the error: AttributeError: 'ResourceList' object has no attribute
'get_reviews'
So it looks like root.get_review_requests().get_self(id='15583',
repository=repository) isn't the right request to return an existing review
request ?
Any help would be much appreciated.
Cheers
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Issue 2981 in reviewboard: Delete a draft from submitted review.
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2981 by philippe...@gmail.com: Delete a draft from submitted review. http://code.google.com/p/reviewboard/issues/detail?id=2981 What version are you running? 1.7.7.1 What's the URL of the page this enhancement relates to, if any? http://rb.freedroid.org/r/1192/ Describe the enhancement and the motivation for it. Currently, you can make a draft for a submitted review, but you can't delete it without reopen it. A little annoying. What operating system are you using? What browser? Chrome Version 26.0.1410.64 m -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2982 in reviewboard: Allow reviewer to drop issue from summary view
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2982 by rad...@gmail.com: Allow reviewer to drop issue from summary view http://code.google.com/p/reviewboard/issues/detail?id=2982 What version are you running? Review Board 1.7.7.1 What's the URL of the page this enhancement relates to, if any? https://reviewboard-openlmi.rhcloud.com/r/344/ Describe the enhancement and the motivation for it. I've added an issue to the review and then figured out that the issue is wrong. But there is no way to drop the issue from summary (or how is it called) view. I have to open diff, click on affected line and drop the issue there. It's very unintuitive. What operating system are you using? What browser? Fedora 18 x86_64, Firefox 21.0 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Comment #7 on issue 1874 by fr...@thefoundry.co.uk: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 kognate's patch fixes my issues (exactly as described by Jordan) when trying to commit each atomic commit on a branch to reviewboard in git-svn land. applied over a8f4db54db3fe1058423c7280c5b825016edeeff (after tag release-0.5) Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
