Re: Unicode and Subversion
Here you go, David. 2014-04-29 10:12:58,425 - DEBUG - - DiffParser.parse: Beginning parse of diff, size = 429 2014-04-29 10:12:58,442 - DEBUG - - DiffParser.parse: Finished parsing diff. 2014-04-29 10:12:58,445 - ERROR - None - stbohne - /api/review-requests/2194/diffs/ - Error uploading new diff: 'ascii' codec can't decode byte 0xc3 in position 20: ordinal not in range(128) Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/webapi/resources.py, line 2115, in create request.FILES.get('parent_diff_path')) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/forms.py, line 309, in create history) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/forms.py, line 67, in create request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py, line 82, in create_from_upload save=save) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py, line 103, in create_from_data check_existence=(not parent_diff_file_contents))) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/diffviewer/managers.py, line 213, in _process_files request=request))): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/models.py, line 211, in get_file_exists base_commit_id, request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/models.py, line 333, in _get_file_exists_uncached exists = self.get_scmtool().file_exists(path, revision) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/core.py, line 80, in file_exists self.get_file(path, revision) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py, line 191, in get_file return self._do_on_path(get_file_data, path, revision) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py, line 145, in _do_on_path normpath = self.__normalize_path(path) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/scmtools/svn.py, line 318, in __normalize_path if path.startswith(self.repopath): UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 20: ordinal not in range(128) Am Sonntag, 4. Mai 2014 05:56:22 UTC+2 schrieb David Trowbridge: Stefan, This has improved significantly in the 2.0 RCs, but we should probably still try to fix it in the 1.7.x series. Can you see if you can get a traceback for the UnicodeDecodeError? -David On Wed, Apr 30, 2014 at 2:52 AM, Stefan Bohne stefan...@sentec-elektronik.de javascript: wrote: Review Board 1.7.21 Am Dienstag, 29. April 2014 22:02:37 UTC+2 schrieb David Trowbridge: What version of Review Board are you using? -David On Tue, Apr 29, 2014 at 3:22 AM, Stefan Bohne stefan...@sentec- elektronik.de wrote: Thanks, David. That fixed it. But now reviewboard itself seems to stumble over unicode paths. $ rbt post --repository-url=http://svn/svn/main/ --username=stbohne --password=XXX -d --server=http://reviews/ 8792 RBTools 0.6 Python 2.7.5+ (default, Feb 27 2014, 19:39:55) [GCC 4.8.1] Running on Linux-3.11.0-18-generic-i686-with-Ubuntu-13.10-saucy Home = /home/stbohne Current directory = /home/stbohne Checking for a Subversion repository... Running: svn info http://svn/svn/main/ --non-interactive Running: diff --version repository info: Path: http://svn/svn/main, Base path: /, Supports changesets: False Making HTTP GET request to http://reviews/api/ Making HTTP GET request to http://reviews/api/info/ Running: svn log -r 8792 -l 1 --xml http://svn/svn/main/ Running: svn info http://svn/svn/main/ --non-interactive Running: diff --version repository info: Path: http://svn/svn/main, Base path: /, Supports changesets: False Running: svn status --ignore-externals Running: svn diff --diff-cmd=diff --notice-ancestry http://svn/svn/main/@8791 http://svn/svn/main/@8792 Making HTTP GET request to http://reviews/api/review-requests/ Making HTTP POST request to http://reviews/api/review-requests/ Making HTTP GET request to http://reviews/api/review- requests/2194/diffs/ Making HTTP POST request to http://reviews/api/review- requests/2194/diffs/ Got API Error 105 (HTTP code 400): One or more fields had errors Error data: {u'fields': {u'path': [u'ascii' codec can't decode byte 0xc3 in position 20: ordinal not in range(128)]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Traceback (most recent call last): File /usr/local/bin/rbt, line 9, in module
Re: Where to find post-review command?
Hi David, thank you for your answer. I provided the server to rbt post, but it is still not working. There seems something wrong with the diff created. I get the same error as when I try to upload a manually created diff when creating a new review request: ERROR: Error uploading diff One or more fields had errors (HTTP 400, API Error 105) path: fatal: Not a git repository: 'None' Your review request still exists, but the diff is not attached. The debug output of the post command looks like this: $ rbt post --server http://localhost -d RBTools 0.6 Python 2.7.3 (default, Feb 27 2014, 19:58:35) [GCC 4.6.3] Running on Linux-3.11.0-20-generic-x86_64-with-Ubuntu-12.04-precise Home = /home/mgrimm Current directory = /home/mgrimm/adnymics/adnymics Checking for a Subversion repository... Unable to execute svn help: skipping SVN Checking for a Git repository... Running: git rev-parse --git-dir Running: git config core.bare Running: git rev-parse --show-toplevel Running: git symbolic-ref -q HEAD Running: git config --get branch.futures/newfeature.merge Command exited with rc 1: ['git', 'config', '--get', 'branch.futures/newfeature.merge'] --- Running: git config --get branch.futures/newfeature.remote Command exited with rc 1: ['git', 'config', '--get', 'branch.futures/newfeature.remote'] --- Running: git config --get remote.origin.url repository info: Path: git@localhost:~/adnymics.git, Base path: , Supports changesets: False Making HTTP GET request to http://localhost/api/ Making HTTP GET request to http://localhost/api/info/ Running: git rev-parse refs/heads/futures/newfeature Running: git merge-base 0fd9066346303da749de9f4818490c290ad40128 origin/master Running: git rev-parse ebd82d38a40a51e6c78260a5ec06d86412b99281 Running: git status --porcelain --untracked-files=no Running: git diff --no-color --full-index --ignore-submodules --no-renames ebd82d38a40a51e6c78260a5ec06d86412b99281..0fd9066346303da749de9f4818490c290ad40128 -M Running: git log --reverse --pretty=format:%s%n%n%b ^ebd82d38a40a51e6c78260a5ec06d86412b99281 0fd9066346303da749de9f4818490c290ad40128 Making HTTP GET request to http://localhost/api/review-requests/ Making HTTP POST request to http://localhost/api/review-requests/ Making HTTP GET request to http://localhost/api/review-requests/3/diffs/ Making HTTP POST request to http://localhost/api/review-requests/3/diffs/ Got API Error 105 (HTTP code 400): One or more fields had errors Error data: {u'fields': {u'path': [ufatal: Not a git repository: 'None'\n]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Traceback (most recent call last): File /usr/local/bin/rbt, line 9, in module load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py, line 134, in main command.run_from_argv([RB_MAIN, command_name] + args) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py, line 422, in run_from_argv exit_code = self.main(*args) or 0 File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py, line 769, in main submit_as=self.options.submit_as) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py, line 545, in post_request raise CommandError('\n'.join(error_msg)) rbtools.commands.CommandError: Error uploading diff One or more fields had errors (HTTP 400, API Error 105) path: fatal: Not a git repository: 'None' Your review request still exists, but the diff is not attached. Can anyone tell me what's missing here? Any help would be appreciated. Am Sonntag, 4. Mai 2014 07:03:39 UTC+2 schrieb David Trowbridge: The 'post-review' command has been deprecated in favor of 'rbt post' for quite some time. As of RBTools 0.6, it has been removed. In order to use rbt post (or even post-review with older versions of rbtools), you'll need to create a .reviewboardrc file that lists your server name. -David On Fri, May 2, 2014 at 7:56 AM, Markus Grimm m.g...@adnymics.comjavascript: wrote: Hi all, I have installed Review-Board V1.7.25 and the RBTools. But I cannot find any post-review command on my machine as mentioned in the documentation of Version 1.7 (the rbt command is there, though). In the latest (dev) documentation, it says, one should use the command rbt post. But when I run it in my repository directory, the only output is: Unable to find a Review Board server for this source code tree. Now I am confused. Which command can be used in which version of Review-Board? Best Regards, Markus -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message
What is the format of the REVIEWBOARD_URL server in the .reviewboardrc?
Hi all, I just tried to specify a server for the rbt post command. I installed Review Board at my local machine, so the command rbt post --server http://localhost does find the server. Also entering the lines [reviewboard] url = http://localhost in the git config works fine. But when I create the .reviewboardrc with the line REVIEWBOARD_URL = http://localhost I get the error Syntax error in config file: /home/mgrimm/adnymics/adnymics/.reviewboardrc Line 1 offset 23 Offset 23 points to the colon or to the first slash - depending on where you start counting. I also tried REVIEWBOARD_URL = localhost as content for .reviewboardrc, but that throws the following error: Traceback (most recent call last): File /usr/local/bin/rbt, line 9, in module load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py, line 134, in main command.run_from_argv([RB_MAIN, command_name] + args) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py, line 398, in run_from_argv self.config = load_config() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/utils/filesystem.py, line 166, in load_config config.update(parse_config_file(filename)) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/utils/filesystem.py, line 146, in parse_config_file execfile(filename, config) File /home/mgrimm/adnymics/adnymics/.reviewboardrc, line 1, in module REVIEWBOARD_URL = localhost NameError: name 'localhost' is not defined So what is the correct format for the server in the .reviewboardrc? I could not find anything about that in the documentation. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: What is the format of the REVIEWBOARD_URL server in the .reviewboardrc?
You got pretty close: REVIEWBOARD_URL = http://localhost; On Mon, May 5, 2014 at 3:19 AM, Markus Grimm m.gr...@adnymics.com wrote: Hi all, I just tried to specify a server for the rbt post command. I installed Review Board at my local machine, so the command rbt post --server http://localhost does find the server. Also entering the lines [reviewboard] url = http://localhost in the git config works fine. But when I create the .reviewboardrc with the line REVIEWBOARD_URL = http://localhost I get the error Syntax error in config file: /home/mgrimm/adnymics/adnymics/.reviewboardrc Line 1 offset 23 Offset 23 points to the colon or to the first slash - depending on where you start counting. I also tried REVIEWBOARD_URL = localhost as content for .reviewboardrc, but that throws the following error: Traceback (most recent call last): File /usr/local/bin/rbt, line 9, in module load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py, line 134, in main command.run_from_argv([RB_MAIN, command_name] + args) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py, line 398, in run_from_argv self.config = load_config() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/utils/filesystem.py, line 166, in load_config config.update(parse_config_file(filename)) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/utils/filesystem.py, line 146, in parse_config_file execfile(filename, config) File /home/mgrimm/adnymics/adnymics/.reviewboardrc, line 1, in module REVIEWBOARD_URL = localhost NameError: name 'localhost' is not defined So what is the correct format for the server in the .reviewboardrc? I could not find anything about that in the documentation. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: gitlab integration
Hi, You need to select GitLab under Hosting Service, provide the URL to the root of your GitLab server, provide authentication details, and your repository information. Christian On Monday, May 5, 2014, ming ho mingcharle...@gmail.com wrote: Hi Christian, attached is the screenshot. thanks, -Ming. On Friday, May 2, 2014 12:31:14 PM UTC-7, Christian Hammond wrote: Hi, Can you show the configuration you're using for the repositories in Review Board? Christian On Friday, May 2, 2014, ming ho mingch...@gmail.com wrote: Hi, i am having trouble adding gitlab repositories to RB. our gitlab has repositories such as http://servername/mho/gin.git. I can clone it with either uid/pwd or ssh key. but, when i supply the URL and user information, RB always complain about not being able to find the repository. I am running 1.7.25. any pointer on how to configure RB for gitlab repository? also, I have created a couple of repositories added to RB. They are all public git repo in gitlab which don't require authentication. I can see them properly via UI. but, when I try to access them though api, i always get Object does not exist. has anybody run into this? -M. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.comjavascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com'); . For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Where to find post-review command?
This looks like an issue with your Git configuration on RB. Git doesn't support remote file access, so if you're not using something like GitHub or GitLab, you'll need to read our docs on setting up cgit/gitweb for access, through the repository entry's Raw File URL Mask field. Christian On Monday, May 5, 2014, Markus Grimm m.gr...@adnymics.com wrote: Hi David, thank you for your answer. I provided the server to rbt post, but it is still not working. There seems something wrong with the diff created. I get the same error as when I try to upload a manually created diff when creating a new review request: ERROR: Error uploading diff One or more fields had errors (HTTP 400, API Error 105) path: fatal: Not a git repository: 'None' Your review request still exists, but the diff is not attached. The debug output of the post command looks like this: $ rbt post --server http://localhost -d RBTools 0.6 Python 2.7.3 (default, Feb 27 2014, 19:58:35) [GCC 4.6.3] Running on Linux-3.11.0-20-generic-x86_64-with-Ubuntu-12.04-precise Home = /home/mgrimm Current directory = /home/mgrimm/adnymics/adnymics Checking for a Subversion repository... Unable to execute svn help: skipping SVN Checking for a Git repository... Running: git rev-parse --git-dir Running: git config core.bare Running: git rev-parse --show-toplevel Running: git symbolic-ref -q HEAD Running: git config --get branch.futures/newfeature.merge Command exited with rc 1: ['git', 'config', '--get', 'branch.futures/newfeature.merge'] --- Running: git config --get branch.futures/newfeature.remote Command exited with rc 1: ['git', 'config', '--get', 'branch.futures/newfeature.remote'] --- Running: git config --get remote.origin.url repository info: Path: git@localhost:~/adnymics.git, Base path: , Supports changesets: False Making HTTP GET request to http://localhost/api/ Making HTTP GET request to http://localhost/api/info/ Running: git rev-parse refs/heads/futures/newfeature Running: git merge-base 0fd9066346303da749de9f4818490c290ad40128 origin/master Running: git rev-parse ebd82d38a40a51e6c78260a5ec06d86412b99281 Running: git status --porcelain --untracked-files=no Running: git diff --no-color --full-index --ignore-submodules --no-renames ebd82d38a40a51e6c78260a5ec06d86412b99281..0fd9066346303da749de9f4818490c290ad40128 -M Running: git log --reverse --pretty=format:%s%n%n%b ^ebd82d38a40a51e6c78260a5ec06d86412b99281 0fd9066346303da749de9f4818490c290ad40128 Making HTTP GET request to http://localhost/api/review-requests/ Making HTTP POST request to http://localhost/api/review-requests/ Making HTTP GET request to http://localhost/api/review-requests/3/diffs/ Making HTTP POST request to http://localhost/api/review-requests/3/diffs/ Got API Error 105 (HTTP code 400): One or more fields had errors Error data: {u'fields': {u'path': [ufatal: Not a git repository: 'None'\n]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Traceback (most recent call last): File /usr/local/bin/rbt, line 9, in module load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')() File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/main.py, line 134, in main command.run_from_argv([RB_MAIN, command_name] + args) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/__init__.py, line 422, in run_from_argv exit_code = self.main(*args) or 0 File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py, line 769, in main submit_as=self.options.submit_as) File /usr/local/lib/python2.7/dist-packages/RBTools-0.6-py2.7.egg/rbtools/commands/post.py, line 545, in post_request raise CommandError('\n'.join(error_msg)) rbtools.commands.CommandError: Error uploading diff One or more fields had errors (HTTP 400, API Error 105) path: fatal: Not a git repository: 'None' Your review request still exists, but the diff is not attached. Can anyone tell me what's missing here? Any help would be appreciated. Am Sonntag, 4. Mai 2014 07:03:39 UTC+2 schrieb David Trowbridge: The 'post-review' command has been deprecated in favor of 'rbt post' for quite some time. As of RBTools 0.6, it has been removed. In order to use rbt post (or even post-review with older versions of rbtools), you'll need to create a .reviewboardrc file that lists your server name. -David On Fri, May 2, 2014 at 7:56 AM, Markus Grimm m.g...@adnymics.com wrote: Hi all, I have installed Review-Board V1.7.25 and the RBTools. But I cannot find any post-review command on my machine as mentioned in the documentation of Version 1.7 (the rbt command is there, though). In the latest (dev) documentation, it says, one should use the command rbt post. But when I run it in my repository directory, the only output is: Unable to find a Review Board
Re: gitlab integration
that worked. Thanks. Sent from my iPhone On May 5, 2014, at 3:24 PM, Christian Hammond chip...@chipx86.com wrote: Hi, You need to select GitLab under Hosting Service, provide the URL to the root of your GitLab server, provide authentication details, and your repository information. Christian On Monday, May 5, 2014, ming ho mingcharle...@gmail.com wrote: Hi Christian, attached is the screenshot. thanks, -Ming. On Friday, May 2, 2014 12:31:14 PM UTC-7, Christian Hammond wrote: Hi, Can you show the configuration you're using for the repositories in Review Board? Christian On Friday, May 2, 2014, ming ho mingch...@gmail.com wrote: Hi, i am having trouble adding gitlab repositories to RB. our gitlab has repositories such as http://servername/mho/gin.git. I can clone it with either uid/pwd or ssh key. but, when i supply the URL and user information, RB always complain about not being able to find the repository. I am running 1.7.25. any pointer on how to configure RB for gitlab repository? also, I have created a couple of repositories added to RB. They are all public git repo in gitlab which don't require authentication. I can see them properly via UI. but, when I try to access them though api, i always get Object does not exist. has anybody run into this? -M. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/uH-jadSzR04/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3326 in reviewboard: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3326 by trivi...@gmail.com: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails http://code.google.com/p/reviewboard/issues/detail?id=3326 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? RBTools0.4.3 What's the URL of the page containing the problem? What steps will reproduce the problem? 1.Create a P4 change with move/delete files. 2.Post a review with the change number generated in step 1. 3.P4 submit the change, you will get a new Change Number. 4.Update the review created in step 2 with the new change number. 5.Post review fails: Unable to get necessary fstat information on //demo.py What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3326 in reviewboard: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails
Comment #1 on issue 3326 by trowb...@gmail.com: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails http://code.google.com/p/reviewboard/issues/detail?id=3326 What version of review board? How are you updating the change number? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3306 in reviewboard: server Erro page when click Ship it! behind proxy reverse
Comment #4 on issue 3306 by f...@esss.com.br: server Erro page when click Ship it! behind proxy reverse http://code.google.com/p/reviewboard/issues/detail?id=3306 B) none relevant in reviewboard.log (nothing during Ship it!) C) accessing from eden.esss.com.br/reviewboard and clicking in Ship it! 10.0.0.1 - - [05/May/2014:10:26:55 +] GET /reviewboard/ HTTP/1.1 302 - - Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:26:55 +] GET /reviewboard/dashboard/ HTTP/1.1 200 3039 - Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:26:59 +] GET /reviewboard/r/ HTTP/1.1 200 5846 https://eden.esss.com.br/reviewboard/dashboard/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:27:07 +] GET /reviewboard/r/40781/ HTTP/1.1 200 4676 https://eden.esss.com.br/reviewboard/r/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:27:07 +] GET /reviewboard/static/rb/images/review_box_top_bg.png HTTP/1.1 200 134 https://eden.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:27:07 +] GET /reviewboard/static/rb/images/review_box_bottom_bg.png HTTP/1.1 200 126 https://eden.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.1 - - [05/May/2014:10:27:20 +] GET /reviewboard/api/review-requests/40781/?api_format=json HTTP/1.1 200 606 https://eden.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:27:20 +] GET /reviewboard/api/review-requests/40781/reviews/draft/?api_format=json HTTP/1.1 401 70 - Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 C) accessing from internal 10.0.0.118 - - [05/May/2014:10:28:42 +] GET /reviewboard/ HTTP/1.1 302 - - Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:28:42 +] GET /reviewboard/dashboard/ HTTP/1.1 200 3039 - Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:28:59 +] GET /reviewboard/r/ HTTP/1.1 200 5846 http://flinsvm012.fln.esss.com.br/reviewboard/dashboard/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:29:06 +] GET /reviewboard/r/40781/ HTTP/1.1 304 - http://flinsvm012.fln.esss.com.br/reviewboard/r/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:29:22 +] GET /reviewboard/api/review-requests/40781/?api_format=json HTTP/1.1 200 606 http://flinsvm012.fln.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:29:22 +] GET /reviewboard/api/review-requests/40781/reviews/draft/?api_format=json HTTP/1.1 404 70 http://flinsvm012.fln.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:29:22 +] POST /reviewboard/api/review-requests/40781/reviews/ HTTP/1.1 201 344 http://flinsvm012.fln.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 10.0.0.118 - - [05/May/2014:10:29:23 +] GET /reviewboard/r/40781/ HTTP/1.1 200 4741 http://flinsvm012.fln.esss.com.br/reviewboard/r/40781/; Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.132 Safari/537.36 D) Last info in Network console from Chorme, before Ship it! from external ?api_format=json /reviewboard/api/review-requests/40781 GET 200 OK application/vnd.reviewboard.org.review-request+json jquery-1.8.2.min.js:2 Script 1.1 KB 2.1 KB 50 ms 49 ms 49 ms ?api_format=json flinsvm012.fln.esss.com.br/reviewboard/api/review-requests/40781/reviews/draft GET (canceled) jquery-1.8.2.min.js:2 Script 0 B 0 B 21 ms - -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed
Re: Issue 3325 in reviewboard: 500 internal server error and UnicodeEncodeError exception happens with non-ASCII summary when access to database page of admin.
Updates: Status: Fixed Comment #2 on issue 3325 by trowb...@gmail.com: 500 internal server error and UnicodeEncodeError exception happens with non-ASCII summary when access to database page of admin. http://code.google.com/p/reviewboard/issues/detail?id=3325 Fixed in release-2.0.x (7d70d46). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3327 in reviewboard: When composing a review, comment text is not properly synchronized between the inline editor and the full-window editor
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3327 by buck.a...@gmail.com: When composing a review, comment text is not properly synchronized between the inline editor and the full-window editor http://code.google.com/p/reviewboard/issues/detail?id=3327 What version are you running? 1.7.6. This issue also reproduces with the 2.0 RC2 instance deployed on http://reviews.reviewboard.org/ What's the URL of the page containing the problem? https://reviews.mysite.com/r/#/diff/ What steps will reproduce the problem? 1. Add a new comment with the inline editor and press Save. 2. Open the full-screen editor by clicking Edit Review in the green bar at the top of the page. See that the comment is there. 3. Edit the text for the comment. 4. Click Save in the full-screen editor. 5. Hover over the green icon on the line where you previously added the comment. Observe that the content shown in the tooltip is stale. 6. Click on the green icon on the line where you previously added the comment. Observe that the content of the inline editor is also stale. What is the expected output? What do you see instead? I expected to see my modified comment content. Instead, I saw stale comment text. It wasn't synchronized between the two editors properly. What operating system are you using? What browser? Linux (Debian). Tested with both Firefox 27.0 and Firefox 25.0. Please provide any additional information below. Note that the text synchronization is only broken in one direction (i.e., edits made in the inline editor will always be properly reflected in the full-screen editor). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3244 in reviewboard: Text does not get escaped in the Bugs field while adding a new review
Comment #3 on issue 3244 by vlyu...@gmail.com: Text does not get escaped in the Bugs field while adding a new review http://code.google.com/p/reviewboard/issues/detail?id=3244 I (Vlad via UCOSP) will take this as my intro bug (I'll probably take other ones as well, as this appears to be a one-liner). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3326 in reviewboard: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails
Comment #3 on issue 3326 by trivi...@gmail.com: PostReview: movedFile field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails http://code.google.com/p/reviewboard/issues/detail?id=3326 The version of Review Board is 1.7.7.1 I am updating change number by the below command: post-review -r review_id new_change_no -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.