rbt post command not working
Hi All, I am new to this ReviewBoard tool. We are integrated ReviewBoard with SVN. So I need to learn about this. Please provide some information which can be help full. And I am working on Linux machine Actually I am expecting more into Command line interface with RBT is better to do if possible. For that I have tried some thing like this: 1. I checked out code from svn branch 2. rbt setup-repo : it was asking Review Board Server URL. I gave as expected. 3. .reviewboardrc file got generated in the same directory 4. I tried rbt post command Here rbt post command is not working. I am getting exception like: CRITICAL: 'Working Copy Root Path' what was issue I am not able to find out. Is this write way which I am doing? Please suggest me on this. your help will be highly appreciated. Thanks In Advance Panikera -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbt post command not working
Hi, Can you run `rbt post --debug` and send the output here? Thanks, -David On Sat Jan 31 2015 at 7:13:13 AM Panikera Raj panikera.raj...@gmail.com wrote: Hi All, I am new to this ReviewBoard tool. We are integrated ReviewBoard with SVN. So I need to learn about this. Please provide some information which can be help full. And I am working on Linux machine Actually I am expecting more into Command line interface with RBT is better to do if possible. For that I have tried some thing like this: 1. I checked out code from svn branch 2. rbt setup-repo : it was asking Review Board Server URL. I gave as expected. 3. .reviewboardrc file got generated in the same directory 4. I tried rbt post command Here rbt post command is not working. I am getting exception like: CRITICAL: 'Working Copy Root Path' what was issue I am not able to find out. Is this write way which I am doing? Please suggest me on this. your help will be highly appreciated. Thanks In Advance Panikera -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3747 in reviewboard: Review images is broken
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3747 by justw...@gmail.com: Review images is broken https://code.google.com/p/reviewboard/issues/detail?id=3747 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? Master 1dbdc63 What's the URL of the page containing the problem? Any image file attachment where there are one or more comments on the image. What steps will reproduce the problem? 1. Upload an image 2. Comment on the image 3. View the image again What is the expected output? What do you see instead? Image should be displayed with the comment, but the image was not displayed and console showed a JS error. What operating system are you using? What browser? Mac 10.9.5, Firefox Please provide any additional information below. 9a1466fd4ea096506e7ff91ca3f01984275ec25b is the first bad commit from git bisect -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3714 in reviewboard: Add a warning to contrib/internal/prepare-dev.py if you kill it about needing to blow away the database.
Comment #3 on issue 3714 by nhv...@gmail.com: Add a warning to contrib/internal/prepare-dev.py if you kill it about needing to blow away the database. https://code.google.com/p/reviewboard/issues/detail?id=3714 Link for review https://reviews.reviewboard.org/r/6845/. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
Hi, Can you tell us what version of Review Board you're using? Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If the latter is sensitive, let us know and we can figure something out). -David On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivova...@gmail.com wrote: I'm trying to upload hive patch for review I'm using hive-git both web ui and rbt post return - list index out of range I even tried to upload old hive patches which I successfully uploaded for review before - still same error - list index out of range -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3714 in reviewboard: Add a warning to contrib/internal/prepare-dev.py if you kill it about needing to blow away the database.
Comment #2 on issue 3714 by t...@lytmus.io: Add a warning to contrib/internal/prepare-dev.py if you kill it about needing to blow away the database. https://code.google.com/p/reviewboard/issues/detail?id=3714 I'm working on it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3580 in reviewboard: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading
Comment #2 on issue 3580 by imcmy...@gmail.com: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading https://code.google.com/p/reviewboard/issues/detail?id=3580 Currently working with this. Mingyi -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #3 on issue 3654 by cmur...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 I'm looking in to this! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #2 on issue 3654 by cmur...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 I'm looking in to this! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3651 in reviewboard: rb-site manage get-siteconfig and set-siteconfig cannot handle null values
Updates: Status: Duplicate Mergedinto: 3743 Comment #1 on issue 3651 by trowb...@gmail.com: rb-site manage get-siteconfig and set-siteconfig cannot handle null values https://code.google.com/p/reviewboard/issues/detail?id=3651 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3743 in reviewboard: rb-site manage get-siteconfig and set-siteconfig don't correctly handle int, bool or null values
Comment #1 on issue 3743 by trowb...@gmail.com: rb-site manage get-siteconfig and set-siteconfig don't correctly handle int, bool or null values https://code.google.com/p/reviewboard/issues/detail?id=3743 Issue 3651 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBtools 0.7 - issue posting a review
Hi Daniel,
Do you think you could add some code to print out the contents of 'log'
inside _convert_symbolic_revision before we try to construct the etree?
Thanks,
-David
On Fri Jan 30 2015 at 4:48:37 AM Daniel Laird daniel.j.la...@googlemail.com
wrote:
We have a shared Debian server and we have updated RBtools to 0.7.
When we try to post a review we get the following:
SERVER_NAME rbt post -d NUM
RBTools 0.7
Python 2.7.3 (default, Mar 13 2014, 11:03:55)
[GCC 4.7.2]
Running on Linux-3.2.0-4-amd64-x86_64-with-debian-7.8
Home = /v/home/rad/USERNAME
Current directory = /v/space/SERVER_NAME/USERNAME/wc/memory_corruption
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: https://SVN_SERVER/svn-restricted/PROJNAME,
Base path: /branches/users/bob/memory_corruption, Supports changesets:
False
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
HTTP GET request to http://REVIEWBOARD_SERVER/api/ cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/?max-results=25start=25
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/?max-results=25start=25 cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/1/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/1/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/2/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/2/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/3/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/3/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/4/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/4/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/5/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/5/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/6/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/6/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/7/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/7/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/8/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/8/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/9/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/9/info/
cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/10/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/10/info/ cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/11/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/11/info/ cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/12/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/12/info/ cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/13/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/13/info/ cannot be cached
Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/14/info/
HTTP GET request to http://REVIEWBOARD_SERVER/api/
repositories/14/info/ cannot be cached
repository info: Path: https://SVN_SERVER/svn-restricted/PROJNAME,
Base path: /branches/users/bob/memory_corruption, Supports changesets:
False
Running: svn log -r REVNUM -l 1 --xml
Traceback (most recent call last):
File /v/home/rad/USERNAME/.local/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7', 'console_scripts', 'rbt')()
File /v/home/rad/USERNAME/.local/lib/python2.7/site-packages/
RBTools-0.7-py2.7.egg/rbtools/commands/main.py, line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /v/home/rad/USERNAME/.local/lib/python2.7/site-packages/
RBTools-0.7-py2.7.egg/rbtools/commands/__init__.py, line 538, in
run_from_argv
exit_code = self.main(*args) or 0
File /v/home/rad/USERNAME/.local/lib/python2.7/site-packages/
RBTools-0.7-py2.7.egg/rbtools/commands/post.py, line 618, in main
self.revisions = get_revisions(self.tool, self.cmd_args)
File /v/home/rad/USERNAME/.local/lib/python2.7/site-packages/
RBTools-0.7-py2.7.egg/rbtools/utils/review_request.py, line 73, in
get_revisions
revisions = tool.parse_revision_spec(cmd_args)
File
Re: Issue 3744 in reviewboard: Unicode in the Ship It' comments isn't viewable in the review page
Comment #5 on issue 3744 by trowb...@gmail.com: Unicode in the Ship It' comments isn't viewable in the review page https://code.google.com/p/reviewboard/issues/detail?id=3744 If you just put the text in the text box that you get in the Review dialog, it's part of the review, not in a comment (comments are when you add a comment to the diff) select * from reviews_review where review_request_id=4371; -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3727 in reviewboard: Are you sure popup if textbox is open.
Comment #3 on issue 3727 by yyou...@gmail.com: Are you sure popup if textbox is open. https://code.google.com/p/reviewboard/issues/detail?id=3727 I solved another easyfix, and will stop working on it. It is intermittent bug, and it doesn't always happen. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
$ rbt diff
diff --git jdbc/pom.xml jdbc/pom.xml
index
8071e87a5da5efca973502bf21926549f887c9d6..6ae8c3c90fe9b71eed717614c81d9b2b36466b39
100644
--- jdbc/pom.xml
+++ jdbc/pom.xml
@@ -139,6 +139,11 @@
build
sourceDirectory${basedir}/src/java/sourceDirectory
+resources
+ resource
+directory${basedir}/src/resources/directory
+ /resource
+/resources
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
diff --git jdbc/src/resources/META-INF/services/java.sql.Driver
jdbc/src/resources/META-INF/services/java.sql.Driver
new file mode 100644
index
..ec764c2249aaf2edb5d88a88d02133aaddbea254
--- /dev/null
+++ jdbc/src/resources/META-INF/services/java.sql.Driver
@@ -0,0 +1 @@
+org.apache.hive.jdbc.HiveDriver
On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge wrote:
Hi,
Can you tell us what version of Review Board you're using?
Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If
the latter is sensitive, let us know and we can figure something out).
-David
On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivo...@gmail.com
javascript: wrote:
I'm trying to upload hive patch for review
I'm using hive-git
both web ui and rbt post return - list index out of range
I even tried to upload old hive patches which I successfully uploaded for
review before - still same error - list index out of range
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/d/optout.
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Upgrading from 1.0.6 to 2.0.x - suggestions and recommendations?
Hi, I tried switching to ReviewBoard 1.7.6 again (easy_install -U ReviewBoard==1.7.6) and then tried rb-site upgrade. This time, I get even more failures: # rb-site upgrade /path/to/site Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Upgrading Review Board from 1.0.6 to 1.7.6 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Adding baseline version for new models Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic.PlasticTool) in database The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model reviews.DefaultReviewer: In field 'repository': Property 'null' has changed In model reviews.ReviewRequest: In field 'repository': Property 'null' has changed Meta property 'unique_together' has changed In model reviews.Group: Meta property 'unique_together' has changed In model scmtools.Repository: Meta property 'unique_together' has changed In model accounts.ReviewRequestVisit: Meta property 'unique_together' has changed Error: Your models contain changes that Django Evolution cannot resolve automatically. Unfortunately, I'm not able to recall how I managed to setup RB 1.7.6 last year. Has anyone else successfully jumped from 1.0.x over to 2.0.x? Any hints as to how I can go about resolving these errors? Even hints / tips on how to debug the issue would be very helpful. Regards, Srinidhi. On Thu, Jan 29, 2015 at 10:39 PM, Srinidhi B S srinidhi...@gmail.com wrote: Hello Everyone, I'm (finally!) preparing to upgrade our very old ReviewBoard instance from 1.0.6 to 2.0.12. I've been worried / concerned about the upgrade path. Around this time last year, I did attempt an upgrade from 1.0.6 directly to 1.7.6 and things seemed to have worked out fine. But I couldn't find any way of verifying the upgrade other than accessing the dashboards. When searching in this list, I found the following post where Christian says that theoretically, you can upgrade from 1.0 straight to 2.0: https://groups.google.com/d/msg/reviewboard/jJMHfZRW7CM/F8ZcuL-SqRQJ But this is failing for me. Here are the steps followed: 1. Run mysqldump -p --opt --quote-names --default-character-set=utf8 database reviewboard.sql on old server running ReviewBoard 1.0.6 2. Edit reviewboard.sql and change all instances of MyISAM to InnoDB 3. Transfer reviewboard.sql to new machine running ReviewBoard 2.0.12 4. Run mysql --default-character-set=utf-8 database reviewboard.sql 5. Run rb-site upgrade /path/to/site Here's the output: --- % --- Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... Creating table extensions_registeredextension Creating table accounts_localsiteprofile Creating table attachments_fileattachment Creating table diffviewer_filediffdata Creating table hostingsvcs_hostingserviceaccount Creating table reviews_fileattachmentcomment Creating table site_localsite_users Creating table site_localsite_admins Creating table site_localsite Upgrading Review Board from 1.0.6 to 2.0.12 There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for hostingsvcs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for site. Adding baseline version for new models Evolutions in attachments baseline: file_attachment_orig_filename, file_attachment_file_max_length_512, file_attachment_repo_info, file_attachment_repo_path_no_index, file_attachment_repo_revision_max_length_64 Evolutions in hostingsvcs baseline: account_hosting_url, account_hosting_url_max_length_255, account_unique_together_baseline Evolutions in site baseline: localsite_public Project
list index out of range
Can not upload diff Error: list index out of range rbt post gives the same error - list index out of range -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
https://lh4.googleusercontent.com/-bxWmJiJIh9U/VM02XsPEQaI/axM/WQ2LUPgVDT4/s1600/rb-web-error.png https://lh4.googleusercontent.com/-bxWmJiJIh9U/VM02XsPEQaI/axM/WQ2LUPgVDT4/s1600/rb-web-error.png Try web UI On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge wrote: Hi, Can you tell us what version of Review Board you're using? Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If the latter is sensitive, let us know and we can figure something out). -David On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivo...@gmail.com javascript: wrote: I'm trying to upload hive patch for review I'm using hive-git both web ui and rbt post return - list index out of range I even tried to upload old hive patches which I successfully uploaded for review before - still same error - list index out of range -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
$ rbt --version RBTools 0.6.3 On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge wrote: Hi, Can you tell us what version of Review Board you're using? Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If the latter is sensitive, let us know and we can figure something out). -David On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivo...@gmail.com javascript: wrote: I'm trying to upload hive patch for review I'm using hive-git both web ui and rbt post return - list index out of range I even tried to upload old hive patches which I successfully uploaded for review before - still same error - list index out of range -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: list index out of range
https://lh3.googleusercontent.com/-qr-iOA9PLWE/VM1C3YoUQ6I/axc/TWrHXZ-HR6o/s1600/rb-web-error.png
https://lh3.googleusercontent.com/-qr-iOA9PLWE/VM1C3YoUQ6I/axc/TWrHXZ-HR6o/s1600/rb-web-error.png
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov --password
pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path: ,
Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
-M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b
^af6632a53e81139e0f771f800931a7ac569fdf1e
a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to
https://reviews.apache.org/api/users/apivovarov/
Making HTTP GET request to https://reviews.apache.org/api/repositories/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/?status=pendingexpand=draftrepository=20from-user=apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not require
class specification'? [Yes/No]: Yes
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Making HTTP POST request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/__init__.py,
line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: list index out of range
Your review request still exists, but the diff is not attached.
https://reviews.apache.org/r/30476/
$ rbt diff
diff --git jdbc/pom.xml jdbc/pom.xml
index
8071e87a5da5efca973502bf21926549f887c9d6..6ae8c3c90fe9b71eed717614c81d9b2b36466b39
100644
--- jdbc/pom.xml
+++ jdbc/pom.xml
@@ -139,6 +139,11 @@
build
sourceDirectory${basedir}/src/java/sourceDirectory
+resources
+ resource
+directory${basedir}/src/resources/directory
+ /resource
+/resources
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
diff --git jdbc/src/resources/META-INF/services/java.sql.Driver
jdbc/src/resources/META-INF/services/java.sql.Driver
new file mode 100644
index
..ec764c2249aaf2edb5d88a88d02133aaddbea254
--- /dev/null
+++ jdbc/src/resources/META-INF/services/java.sql.Driver
@@ -0,0 +1 @@
+org.apache.hive.jdbc.HiveDriver
On Saturday, January 31, 2015 at 12:06:32 PM UTC-8, Alexander Pivovarov
wrote:
Can not upload diff
Error: list index out of range
rbt post gives the same error - list index out of range
--
Supercharge your Review Board with Power Pack:
Re: can not upload diff - list index out of range
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov --password
pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path: ,
Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
-M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b
^af6632a53e81139e0f771f800931a7ac569fdf1e
a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to
https://reviews.apache.org/api/users/apivovarov/
Making HTTP GET request to https://reviews.apache.org/api/repositories/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/?status=pendingexpand=draftrepository=20from-user=apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not require
class specification'? [Yes/No]: Yes
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Making HTTP POST request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/__init__.py,
line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: list index out of range
Your review request still exists, but the diff is not attached.
https://reviews.apache.org/r/30476/
On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge wrote:
Hi,
Can you tell us what version of Review Board you're using?
Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If
the latter is sensitive, let us know and we can figure something out).
-David
On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivo...@gmail.com
javascript: wrote:
I'm trying to upload hive patch for review
I'm using hive-git
both web ui and rbt post return - list index out of range
I even tried to upload old hive patches which I successfully uploaded for
review before - still same error - list index out of range
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/d/optout.
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host
Re: can not upload diff - list index out of range
Can you tell me what's in your .gitconfig?
-David
On Sat Jan 31 2015 at 1:01:34 PM Alexander Pivovarov apivova...@gmail.com
wrote:
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov --password
pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path: ,
Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
-M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b
^af6632a53e81139e0f771f800931a7ac569fdf1e
a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to
https://reviews.apache.org/api/users/apivovarov/
Making HTTP GET request to
https://reviews.apache.org/api/repositories/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/?status=pendingexpand=draftrepository=20from-user=apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not
require class specification'? [Yes/No]: Yes
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/
Making HTTP GET request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Making HTTP POST request to
https://reviews.apache.org/api/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/__init__.py,
line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: list index out of range
Your review request still exists, but the diff is not attached.
https://reviews.apache.org/r/30476/
On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge wrote:
Hi,
Can you tell us what version of Review Board you're using?
Also, can you attach the output of 'rbt post --debug' and 'rbt diff'? (If
the latter is sensitive, let us know and we can figure something out).
-David
On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov apivo...@gmail.com
wrote:
I'm trying to upload hive patch for review
I'm using hive-git
both web ui and rbt post return - list index out of range
I even tried to upload old hive patches which I successfully uploaded
for review before - still same error - list index out of range
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com.
For more options,
Re: Issue 3630 in reviewboard: UTF-8 filenames are mangled in rbcommons UI
Comment #5 on issue 3630 by trowb...@gmail.com: UTF-8 filenames are mangled in rbcommons UI https://code.google.com/p/reviewboard/issues/detail?id=3630 One part of this is fixed in rbtools release-0.6.x (ac0aa18). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3747 in reviewboard: Review images is broken
Updates: Status: Fixed Comment #2 on issue 3747 by trowb...@gmail.com: Review images is broken https://code.google.com/p/reviewboard/issues/detail?id=3747 Fixed in master (51c20e1). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
We don't run reviews.apache.org. It's possible that they upgraded the
server and something regressed.
-David
On Sat Jan 31 2015 at 6:17:22 PM Alexander Pivovarov apivova...@gmail.com
wrote:
Thank you for solving the issue. rbt post -u is working now for me
Hive dev guide requires to use git diff --no-prefix to generate patch
file.
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CreatingaPatch
So, if I need to upload my patch to Review Board via web UI should I
generate another patch file without --no-prefix option?
BTW, Review Board web UI allowed to upload not prefixed patches 10 days
ago. e.g. https://reviews.apache.org/r/30003/
Did you guys fix smth last week?
On Saturday, January 31, 2015 at 2:27:19 PM UTC-8, David Trowbridge wrote:
OK, the issue is the noprefix line. I'll get a fix in for rbtools but in
the meantime, if you remove that line from your config, it should work.
-David
On Sat Jan 31 2015 at 2:14:56 PM Alexander Pivovarov apivo...@gmail.com
wrote:
$ cat .gitconfig
[user]
name = Alexander Pivovarov
email = apivo...@lendingclub.com
[branch]
autosetuprebase = always
[push]
default = simple
[pull]
rebase = true
[diff]
noprefix = true
On Saturday, January 31, 2015 at 1:05:27 PM UTC-8, David Trowbridge
wrote:
Can you tell me what's in your .gitconfig?
-David
On Sat Jan 31 2015 at 1:01:34 PM Alexander Pivovarov apivo...@gmail.com
wrote:
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov
--password pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-
Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path:
, Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..a9b2f4b79c6b543dca
bed15752a0280d4f2dbccf -M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b ^
af6632a53e81139e0f771f800931a7ac569fdf1e
a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to https://reviews.apache.org/api
/users/apivovarov/
Making HTTP GET request to https://reviews.apache.org/api
/repositories/
Making HTTP GET request to https://reviews.apache.org/api
/review-requests/?status=pendingexpand=draftrepository=20from-user=
apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not
require class specification'? [Yes/No]: Yes
Making HTTP GET request to https://reviews.apache.org/api
/review-requests/30476/
Making HTTP GET request to https://reviews.apache.org/api
/review-requests/30476/diffs/
Making HTTP POST request to https://reviews.apache.org/api
/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/
rbtools/commands/__init__.py, line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #4 on issue 3654 by rmeringe...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 Tried to Reproduce error in release-2.0.x branch and wasn't able to reproduce bug. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
Thank you for solving the issue. rbt post -u is working now for me
Hive dev guide requires to use git diff --no-prefix to generate patch
file.
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CreatingaPatch
So, if I need to upload my patch to Review Board via web UI should I
generate another patch file without --no-prefix option?
BTW, Review Board web UI allowed to upload not prefixed patches 10 days
ago. e.g. https://reviews.apache.org/r/30003/
Did you guys fix smth last week?
On Saturday, January 31, 2015 at 2:27:19 PM UTC-8, David Trowbridge wrote:
OK, the issue is the noprefix line. I'll get a fix in for rbtools but in
the meantime, if you remove that line from your config, it should work.
-David
On Sat Jan 31 2015 at 2:14:56 PM Alexander Pivovarov apivo...@gmail.com
javascript: wrote:
$ cat .gitconfig
[user]
name = Alexander Pivovarov
email = apivo...@lendingclub.com javascript:
[branch]
autosetuprebase = always
[push]
default = simple
[pull]
rebase = true
[diff]
noprefix = true
On Saturday, January 31, 2015 at 1:05:27 PM UTC-8, David Trowbridge wrote:
Can you tell me what's in your .gitconfig?
-David
On Sat Jan 31 2015 at 1:01:34 PM Alexander Pivovarov apivo...@gmail.com
wrote:
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov --password
pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-
Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path:
, Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..
a9b2f4b79c6b543dcabed15752a0280d4f2dbccf -M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b ^
af6632a53e81139e0f771f800931a7ac569fdf1e a9b2f4b79c6b543dcabed15752a028
0d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to https://reviews.apache.org/
api/users/apivovarov/
Making HTTP GET request to https://reviews.apache.org/
api/repositories/
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/?status=pendingexpand=draft
repository=20from-user=apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not
require class specification'? [Yes/No]: Yes
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/30476/
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/30476/diffs/
Making HTTP POST request to https://reviews.apache.org/
api/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.
egg/rbtools/commands/__init__.py, line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: list index out of range
Your review request
Re: Issue 3678 in reviewboard: Unable to add new files to review requests
Updates: Status: Fixed Comment #5 on issue 3678 by trowb...@gmail.com: Unable to add new files to review requests https://code.google.com/p/reviewboard/issues/detail?id=3678 Fixed in djblets release-0.8.x (a4d3728). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: can not upload diff - list index out of range
OK, the issue is the noprefix line. I'll get a fix in for rbtools but in
the meantime, if you remove that line from your config, it should work.
-David
On Sat Jan 31 2015 at 2:14:56 PM Alexander Pivovarov apivova...@gmail.com
wrote:
$ cat .gitconfig
[user]
name = Alexander Pivovarov
email = apivova...@lendingclub.com
[branch]
autosetuprebase = always
[push]
default = simple
[pull]
rebase = true
[diff]
noprefix = true
On Saturday, January 31, 2015 at 1:05:27 PM UTC-8, David Trowbridge wrote:
Can you tell me what's in your .gitconfig?
-David
On Sat Jan 31 2015 at 1:01:34 PM Alexander Pivovarov apivo...@gmail.com
wrote:
[apivovarov@c11 hive]$ rbt post -u -d --username apivovarov --password
pwd -g yes
RBTools 0.6.3
Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
Running on Linux-2.6.32-504.3.3.el6.x86_64-x86_64-with-centos-6.6-
Final
Home = /home/alex
Current directory = /home/alex/workhive/hive
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.HIVE-7998.merge
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.merge']
---
Running: git config --get branch.HIVE-7998.remote
Command exited with rc 1: ['git', 'config', '--get',
'branch.HIVE-7998.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:apache/hive.git, Base path: ,
Supports changesets: False
Making HTTP GET request to https://reviews.apache.org/api/
Running: git rev-parse refs/heads/HIVE-7998
Running: git merge-base a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
origin/trunk
Running: git rev-parse af6632a53e81139e0f771f800931a7ac569fdf1e
Running: git status --porcelain --untracked-files=no
Running: git diff --no-color --full-index --ignore-submodules
af6632a53e81139e0f771f800931a7ac569fdf1e..a9b2f4b79c6b543dcabed15752a0280d4f2dbccf
-M --no-ext-diff
Running: git log --reverse --pretty=format:%s%n%n%b ^
af6632a53e81139e0f771f800931a7ac569fdf1e a9b2f4b79c6b543dcabed15752a028
0d4f2dbccf
Making HTTP GET request to https://reviews.apache.org/api/session/
Making HTTP GET request to https://reviews.apache.org/
api/users/apivovarov/
Making HTTP GET request to https://reviews.apache.org/
api/repositories/
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/?status=pendingexpand=draft
repository=20from-user=apivovarov
Update Review Request #30476: 'HIVE-7998 Enhance JDBC Driver to not
require class specification'? [Yes/No]: Yes
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/30476/
Making HTTP GET request to https://reviews.apache.org/
api/review-requests/30476/diffs/
Making HTTP POST request to https://reviews.apache.org/
api/review-requests/30476/diffs/
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [u'list index out of range']},
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
Traceback (most recent call last):
File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.
egg/rbtools/commands/__init__.py, line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 791, in main
submit_as=self.options.submit_as)
File
/usr/lib/python2.6/site-packages/RBTools-0.6.3-py2.6.egg/rbtools/commands/post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: list index out of range
Your review request still exists, but the diff is not attached.
https://reviews.apache.org/r/30476/
On Saturday, January 31, 2015 at 9:35:25 AM UTC-8, David Trowbridge
wrote:
Hi,
Can you tell us what version of Review Board you're using?
Also, can you attach the output of 'rbt post --debug' and 'rbt diff'?
(If the latter is sensitive, let us know and we can figure something out).
-David
On Fri Jan 30 2015 at 6:16:36 PM Alexander Pivovarov
apivo...@gmail.com wrote:
I'm trying to upload hive patch for review
I'm using hive-git
both web ui and rbt post return - list index out of range
I even tried to upload old hive patches which I
Issue 3748 in reviewboard: Unable to isolate individual lines for review if first line already has a multi-line review
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3748 by sunxper...@gmail.com: Unable to isolate individual lines for review if first line already has a multi-line review https://code.google.com/p/reviewboard/issues/detail?id=3748 What version are you running? 2.0.13 alpha 0 What's the URL of the page containing the problem? https://reviews.reviewboard.org/r/6806/diff/4/?file=66249# What steps will reproduce the problem? From the URL of the page: 1. Select line 21 and comment for review. 2. Edit your review. To reproduce from scratch: 1. Select multiple lines on code for any review and publish. 2. Select it again, but this time attempt to select just the first line, and comment. 3. Edit your review. What is the expected output? What do you see instead? Users should be able to review and comment on a single line of the code. The same multi-line review comment was selected instead. What operating system are you using? What browser? OS X 10.10.1, Chrome 40.0.2214.93 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3749 in reviewboard: rbt diff/post for Subversion is badly broken in 0.7.0 due to changes making diffs relative to the checkout root
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3749 by griffin@gmail.com: rbt diff/post for Subversion is
badly broken in 0.7.0 due to changes making diffs relative to the checkout
root
https://code.google.com/p/reviewboard/issues/detail?id=3749
What version are you running?
RBTools 0.7.0
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
1. See below
What is the expected output? What do you see instead?
Seeing multiple types of crashes.
What operating system are you using? What browser?
CentOS 7, Python 2.7.5
Please provide any additional information below.
I believe the changes in 31aabc4 have introduced some serious regressions
for SVN. For reference from the commit message:
SVN and CVS no longer create diffs relative to current working directory.
CVS and SVN now change to the root directory of the repository for
performing diffs (before changing back).
Furthermore, when discussing this change in the RBTools 0.7.0 release
notes, it is noted that:
The old behavior can be used with the command rbt post -I .
I cannot comment on what implications these changes may have for CVS, but
for SVN I've observed at least two different types of crashes, both of
which can be traced to attempting to perform an rbt diff/post operation
from *anywhere* other than the root of the working copy.
**Directory Structure**
Assume an svn working copy at /home/gmyers/wc, with a single file (b.txt)
with local modifications.
[gmyers@centos7-vm wc]$ tree /home/gmyers/wc
/home/gmyers/wc
├── branches
├── tags
└── trunk
├── a.txt
└── dir1
└── b.txt
[gmyers@centos7-vm wc]$ svn status
M trunk/dir1/b.txt
**Crash #1**
Execute 'rbt diff' from the trunk directory. Conceptually this should
generate a diff from the working copy root (/home/gmyers/wc) and b.txt
should be the only file present in the diff. Crash below occurs because
svn info is being executed on '/home/gmyers/wc/trunk/trunk/dir1/b.txt'
(Note: trunk is duplicated in the path). Following the changes in 31aabc4,
we start in the /home/gmyers/wc/trunk directory but immediately change to
the working copy root in /home/gmyers/wc. We generate the diff here which
causes the diff to be relative to wc/ and thus the filestring within the
diff looks like 'trunk/dir1/b.txt'. Next we change back to
/home/gmyers/wc/trunk and then we attempt to operate on the filestring from
within the diff relative to this cwd. Since we are in the trunk directory
and already have trunk/ in the filestring in the diff, we get duplicate
trunk/ fields when assembling the full path.
[gmyers@centos7-vm trunk]$ rbt diff -d
RBTools 0.7
Python 2.7.5 (default, Jun 17 2014, 18:11:42)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-16)]
Running on
Linux-3.10.0-123.13.2.el7.x86_64-x86_64-with-centos-7.0.1406-Core
Home = /home/gmyers
Current directory = /home/gmyers/wc/trunk
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: file:///home/gmyers/svn_repo/myrepo, Base path:
/trunk, Supports changesets: False
Making HTTP GET request to http://localhost:8080/api/
Cached response for HTTP GET http://localhost:8080/api/ expired and was
modified
Running: svn info --non-interactive
Running: diff --version
repository info: Path: file:///home/gmyers/svn_repo/myrepo, Base path:
/trunk, Supports changesets: False
Running: svn status --ignore-externals
Running: svn info .
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
Running: svn info trunk/dir1/b.txt
Command exited with rc 1: ['svn', 'info', u'trunk/dir1/b.txt']
[svn: warning: W155010: The node '/home/gmyers/wc/trunk/trunk/dir1/b.txt'
was not found.\n, '\n', svn: E29: Could not display info for all
targets because some targets don't exist\n]---
Traceback (most recent call last):
File /home/gmyers/envs/rbt_0.7.0/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7', 'console_scripts', 'rbt')()
File /home/gmyers/envs/rbt_0.7.0/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/main.py,
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /home/gmyers/envs/rbt_0.7.0/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/__init__.py,
line 538, in run_from_argv
exit_code = self.main(*args) or 0
File /home/gmyers/envs/rbt_0.7.0/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/diff.py,
line 68, in main
extra_args=extra_args)
File /home/gmyers/envs/rbt_0.7.0/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/clients/svn.py,
line 305, in diff
diff = self.handle_renames(diff)
File /home/gmyers/envs/rbt_0.7.0/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/clients/svn.py,
line 424, in handle_renames
copied_from = self.find_copyfrom(to_file)
File
Re: Issue 3747 in reviewboard: Review images is broken
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #1 on issue 3747 by trowb...@gmail.com: Review images is broken https://code.google.com/p/reviewboard/issues/detail?id=3747 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3698 in reviewboard: Condensediff warning in 2.0.11
Comment #3 on issue 3698 by rmeringe...@gmail.com: Condensediff warning in 2.0.11 https://code.google.com/p/reviewboard/issues/detail?id=3698 Fixed bug 3698 by converting string to bytestring. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #5 on issue 3654 by griffin@gmail.com: HTML anchors in File
Index not working for copied files
https://code.google.com/p/reviewboard/issues/detail?id=3654
I can absolutely reproduce this in master with the built in development
webserver.
The issue appears to be on line 80 of
reviewboard/templates/diffviewer/diff_file_fragment.html. Adding a
name={{file.index}} class=file-anchor here, similar to how it appears
on line 78, fixes the problem. However, I don't understand the surrounding
code well enough to know if this is a sufficient solution. Particularly,
it seems like the code in the prior if block (lines 77-79), which does set
an anchor name, may be intended to work in conjunction with line 80 and
that is why 80 omits the anchor name.
Please let me know if you need me to provide additional details to
replicate this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
