Re: The specified diff file could not be parsed.
It sounds like this is a documentation issue then. I don't believe that, in the process of setting up our reviewboard, there was an indication that the repository needed to be hosted locally. In fact, the repository settings in the UI suggested otherwise. I'll give this a try and update back here. On Saturday, February 14, 2015 at 12:26:28 AM UTC-8, Christian Hammond wrote: Unfortunately, that configuration can't work, unless there's also a raw file URL field that's filled out. Git's protocol has no ability to fetch the kind of information we need remotely, including individual files. For Git, it's a requirement to either host the repository on the Review Board server (or through something like an NFS mount), or to use a service like GitWeb. GitWeb is the recommended route right now (though we're working on a service to help make all this easier). If the other changes were successfully posting, my guess is that they were introducing new files, which doesn't require communication with the repository. Otherwise, there's no way that the file verification could have worked with a remote Git path. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Liam Reimers liam.r...@gmail.com javascript: Reply: Liam Reimers liam.r...@gmail.com javascript: Date: February 13, 2015 at 3:40:54 PM To: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Cc: liam.r...@gmail.com javascript: liam.r...@gmail.com javascript:, chri...@beanbaginc.com javascript: chri...@beanbaginc.com javascript: Subject: Re: The specified diff file could not be parsed. Ah, I just saw part of your error: Not a git repository: 'None.' How is your repository configured in Review Board? Name - Repository Hosting - None (custom) Type - Git Path - git@server:path/repo.git However, note that the client can post a review request using one invocation (with HEAD~) and not the other, so it would seem that the repo is configured correctly? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: The specified diff file could not be parsed.
Now that I know what was wrong with my configuration, I was able to find the appropriate documentation. Not sure whether I should have seen this going through the first time and just missed it. https://www.reviewboard.org/docs/manual/1.5/admin/management/repositories/#local-clone On Monday, February 16, 2015 at 10:31:14 AM UTC-8, Jonathan Anderson wrote: It's occurring to me that right now, I have a bare repository and intend to keep it that way if I can. If I were to have the reviewboard instance accessing git directly through the file system, would it need a working directory in order to function? Is there a way I could set up a git repo on the reviewboard server, tracking our remote, and simply have it fetch when it needs to verify any files? On Monday, February 16, 2015 at 9:45:27 AM UTC-8, Jonathan Anderson wrote: It sounds like this is a documentation issue then. I don't believe that, in the process of setting up our reviewboard, there was an indication that the repository needed to be hosted locally. In fact, the repository settings in the UI suggested otherwise. I'll give this a try and update back here. On Saturday, February 14, 2015 at 12:26:28 AM UTC-8, Christian Hammond wrote: Unfortunately, that configuration can't work, unless there's also a raw file URL field that's filled out. Git's protocol has no ability to fetch the kind of information we need remotely, including individual files. For Git, it's a requirement to either host the repository on the Review Board server (or through something like an NFS mount), or to use a service like GitWeb. GitWeb is the recommended route right now (though we're working on a service to help make all this easier). If the other changes were successfully posting, my guess is that they were introducing new files, which doesn't require communication with the repository. Otherwise, there's no way that the file verification could have worked with a remote Git path. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Liam Reimers liam.r...@gmail.com Reply: Liam Reimers liam.r...@gmail.com Date: February 13, 2015 at 3:40:54 PM To: revie...@googlegroups.com revie...@googlegroups.com Cc: liam.r...@gmail.com liam.r...@gmail.com, chri...@beanbaginc.com chri...@beanbaginc.com Subject: Re: The specified diff file could not be parsed. Ah, I just saw part of your error: Not a git repository: 'None.' How is your repository configured in Review Board? Name - Repository Hosting - None (custom) Type - Git Path - git@server:path/repo.git However, note that the client can post a review request using one invocation (with HEAD~) and not the other, so it would seem that the repo is configured correctly? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3739 in reviewboard: Include commented-on line numbers in text e-mails for reviews
Updates: Status: Fixed Comment #2 on issue 3739 by trowb...@gmail.com: Include commented-on line numbers in text e-mails for reviews https://code.google.com/p/reviewboard/issues/detail?id=3739 Fixed in release-2.0.x (c396156). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Directory Permissions CodeReview Fedora Fresh Install
Fixed it. I turned of SELinux. And restarted httpd as not root. On Sunday, February 15, 2015 at 5:12:26 PM UTC-8, Yarone Greif wrote: Just installed CodeReview on a Fedora AWS instance. And I'm getting the permissions problem issue splash page (The data directory must be writable by the web server. On Linux/Unix/Mac, you can fix this by typing:). But I think the permissions are set correctly. eg [fedora@ip-172-31-20-148 ~]$ sudo chown -R apache /var/www/ reviews.example.com/data [fedora@ip-172-31-20-148 ~]$ ls -lh /var/www/reviews.example.com/data total 336K -rw-r--r--. 1 apache root 333K Feb 15 23:15 reviewboard.db [fedora@ip-172-31-20-148 ~]$ sudo service httpd restart Redirecting to /bin/systemctl restart httpd.service But the splash page isn't fixed. What else am I supposed to run? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: The specified diff file could not be parsed.
It's occurring to me that right now, I have a bare repository and intend to keep it that way if I can. If I were to have the reviewboard instance accessing git directly through the file system, would it need a working directory in order to function? Is there a way I could set up a git repo on the reviewboard server, tracking our remote, and simply have it fetch when it needs to verify any files? On Monday, February 16, 2015 at 9:45:27 AM UTC-8, Jonathan Anderson wrote: It sounds like this is a documentation issue then. I don't believe that, in the process of setting up our reviewboard, there was an indication that the repository needed to be hosted locally. In fact, the repository settings in the UI suggested otherwise. I'll give this a try and update back here. On Saturday, February 14, 2015 at 12:26:28 AM UTC-8, Christian Hammond wrote: Unfortunately, that configuration can't work, unless there's also a raw file URL field that's filled out. Git's protocol has no ability to fetch the kind of information we need remotely, including individual files. For Git, it's a requirement to either host the repository on the Review Board server (or through something like an NFS mount), or to use a service like GitWeb. GitWeb is the recommended route right now (though we're working on a service to help make all this easier). If the other changes were successfully posting, my guess is that they were introducing new files, which doesn't require communication with the repository. Otherwise, there's no way that the file verification could have worked with a remote Git path. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Liam Reimers liam.r...@gmail.com Reply: Liam Reimers liam.r...@gmail.com Date: February 13, 2015 at 3:40:54 PM To: revie...@googlegroups.com revie...@googlegroups.com Cc: liam.r...@gmail.com liam.r...@gmail.com, chri...@beanbaginc.com chri...@beanbaginc.com Subject: Re: The specified diff file could not be parsed. Ah, I just saw part of your error: Not a git repository: 'None.' How is your repository configured in Review Board? Name - Repository Hosting - None (custom) Type - Git Path - git@server:path/repo.git However, note that the client can post a review request using one invocation (with HEAD~) and not the other, so it would seem that the repo is configured correctly? -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Support for PlasticSCM sub-repositories
Hi Recently in PlasticSCM support for sub-repositories was added (it means that repo righ now can be names e.g. RepoX/SubRepoY). It looks that regular expression used in plastic.py module is not working correctly with such sub-repos. Are there any plans to add such support? I have experimented a bit with regexp in plastic.py and can provide results of such experiments if anobody is interested. Best regards PM -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Support for PlasticSCM sub-repositories
Piotr, The Plastic SCM support in Review Board was a contribution from Codice (the makers of Plastic). I'd suggest raising this issue with them and asking them to provide a patch for us. -David On Mon Feb 16 2015 at 1:00:09 PM Piotr Mis mis...@mis.krakow.pl wrote: Hi Recently in PlasticSCM support for sub-repositories was added (it means that repo righ now can be names e.g. RepoX/SubRepoY). It looks that regular expression used in plastic.py module is not working correctly with such sub-repos. Are there any plans to add such support? I have experimented a bit with regexp in plastic.py and can provide results of such experiments if anobody is interested. Best regards PM -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Authentication failed while adding svn repository
Hello Jeffrey, The fix was to use PySVN which is the default in 2.0.5. Upgrading to 2.0.5 fixed it. I am sure you can download the latest version of Reviewboard and it would work https://www.reviewboard.org/downloads/. At the time, I was also using the Bitnami installer for Reviewboard: https://bitnami.com/stack/reviewboard Alexis On Sun, Feb 15, 2015 at 9:30 PM, Jeffrey Javier jepoi...@gmail.com wrote: Good day Alexis! Do you mind sharing the fix for this issue? You just downloaded version 2.0.5 and it worked? please do share the link thanks :) On Thursday, July 31, 2014 at 8:36:41 AM UTC+8, Alexis wrote: Hi Christian, It worked! No hitch. No need to install the patch. Thanks, Alexis On Wed, Jul 30, 2014 at 6:09 PM, Christian Hammond chri...@beanbaginc.com wrote: Hi Alexis, So, Review Board 2.0.2 is busted with SVN. That's the primary cause of your problems. You need 2.0.3 or higher to have a working setup with a self-signed cert. (You should install 2.0.5 though.) When trying to verify the issue, though, I hit some other problems with accepting a certificate. I've attached a patch that should smooth out another rough edge (though I don't believe it's required for this case, but may help if you hit any errors with a newer release.) Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 30, 2014 at 3:09:37 PM, Alexis Denis (alexi...@gmail.com) wrote: Hi Christian, It is the original save: it fails even before asking to accept the SSL certificate (as mine is not signed by an authority, I have to accept it). Alexis On Wed, Jul 30, 2014 at 4:42 PM, Christian Hammond chri...@beanbaginc.com wrote: Hi Alexis, From the code I'm seeing, it does look like we're passing in the credentials. I am, however, seeing that we don't pass in credentials when confirming an HTTPS certificate. Is that the point where things go wrong, or is it on the initial save? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 30, 2014 at 2:34:26 PM, Alexis Denis (alexi...@gmail.com) wrote: Christian: Personally, I am running ReviewBoard 2.0.2 and I believe I am using the default which is PySVN. I still think it's the wrapper tools trying to access the repository without a username or password at first. The setup is simple and easy to reproduce: VisualSVN server with no public access and a user. Holger: I am glad I am not the only one with this issue. I was starting to feel a little lonely. Glad to see you found your own workaround. Alexis On Wed, Jul 30, 2014 at 1:10 PM, Christian Hammond chi...@chipx86.com wrote: Hi, What version of Review Board? Are you using PySVN or Subvertpy? Christian On Wednesday, July 30, 2014, Holger hkr...@gmail.com wrote: My Workaround: I have the same problem but found a workaround inspired by Alexis' debug information: Add the new repository with Show this repository option unchecked. Afterwards got directly to the database and change the visible flag for the repository in the table scmtools_repository to 1. On Tuesday, July 8, 2014 11:25:40 AM UTC+2, shravanthi s wrote: Hi, I have installed Review Board 2.0.2 on RHEL 6.5 machine. I installed subversion 1.6.11 and pysvn version 1.7.8. However when i tried to add a repository, even though my login credentials are correct, am unable to add it. It gives an error 'Authentication failed' . So currently review board is unusable. The reviewboard log shows error as below ERROR - - SVN: Failed to get repository information for https://test.com/svn/myfolder/Phoenix: callback_get_login required Am not sure what is going wrong here. Anything to do with my pysvn version? -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/ topic/reviewboard/r3Z_w3nJbkU/unsubscribe. To
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #8 on issue 2980 by pekka.t@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 This seems to be fixed in 2.0.13? Briefly tested - looking good now. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
