Review Board 2.5 is here!

[Christian Hammond]

Hey everyone,

In case you're not on our announcements mailing list 
, we released Review Board 2.5 
early this morning.

We've been working on 2.5 for a long time, focusing on improving the 
usability of the product, helping to increase productivity and removing 
hurdles for things like replacing and reviewing file attachments, making it 
easier to integrate with other services, and more.

We've added mobile support, improved navigation on review requests, added 
image diffs, revisioned file attachments, webhooks, Live HD Thumbnails, and 
that's just a few of the new additions you'll find in 2.5.

Check out our official announcement  for all the 
details, and for a video showing off what's new in this release.

We're hoping to get the word out, so if you're active on Twitter or 
Facebook and wouldn't mind sharing some information on the release, we'd 
appreciate it!

Thanks to everyone who contributed to and beta tested 2.5, and of course, 
to all of you for continuing to use Review Board :)

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

expand and collapse at file level

[Sam]

When looking at the diffs I would like to be able to expand or collapse all 
changes for a single file.  The only options available now are 
expand/collapse all files or expand/collapse individual sections.  
Generally files can be large, and there is no "skip to next change" button 
(which is actually something else which would be nice) so expanding all 
isn't the great, and some files have too many piecemeal changes so 
expanding each section one at a time is too taxing. 

Note, expand/collapse at the file level would also be helpful when the 
reviewer doesn't care about some files (maybe its a data file for a 
testcase, or maybe the file will be reviewed by someone else). 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: expand and collapse at file level

[Barret Rennie]

Hi Sam,

With regards to your second point (skipping to the next change) we have 
keyboard shortcuts for that. “A” will move to the previous change and “D” will 
move to the next change.

With regards to your first point, would you mind filing a enhancement proposal 
for it on https://hellosplat.com/s/beanbag/reviewboard/ 
 ?

Thanks!

Barret Rennie
> On Oct 29, 2015, at 12:53 PM, Sam  wrote:
> 
> When looking at the diffs I would like to be able to expand or collapse all 
> changes for a single file.  The only options available now are 
> expand/collapse all files or expand/collapse individual sections.  Generally 
> files can be large, and there is no "skip to next change" button (which is 
> actually something else which would be nice) so expanding all isn't the 
> great, and some files have too many piecemeal changes so expanding each 
> section one at a time is too taxing.
> 
> Note, expand/collapse at the file level would also be helpful when the 
> reviewer doesn't care about some files (maybe its a data file for a testcase, 
> or maybe the file will be reviewed by someone else).
> 
> 
> 
> -- 
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/ 
> 
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/ 
> Happy user? Let us know! https://www.reviewboard.org/users/ 
> 
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: expand and collapse at file level

[David Trowbridge]

This is already tracked in https://hellosplat.com/s/beanbag/tickets/3987/

-David

On Thu, Oct 29, 2015 at 11:55 AM, Barret Rennie 
wrote:

> Hi Sam,
>
> With regards to your second point (skipping to the next change) we have
> keyboard shortcuts for that. “A” will move to the previous change and “D”
> will move to the next change.
>
> With regards to your first point, would you mind filing a enhancement
> proposal for it on https://hellosplat.com/s/beanbag/reviewboard/ ?
>
> Thanks!
>
> Barret Rennie
>
> On Oct 29, 2015, at 12:53 PM, Sam  wrote:
>
> When looking at the diffs I would like to be able to expand or collapse
> all changes for a single file.  The only options available now are
> expand/collapse all files or expand/collapse individual sections.
> Generally files can be large, and there is no "skip to next change" button
> (which is actually something else which would be nice) so expanding all
> isn't the great, and some files have too many piecemeal changes so
> expanding each section one at a time is too taxing.
>
> Note, expand/collapse at the file level would also be helpful when the
> reviewer doesn't care about some files (maybe its a data file for a
> testcase, or maybe the file will be reviewed by someone else).
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

HTTP 400, API Error 207 when trying to update a review

[Sam]

Branch name:temp_x_main_rbtool
ERROR: Error uploading diff


The file was not found in the repository. (HTTP 400, API Error 207)

Your review request still exists, but the diff is not attached.

Here is the section of the trace, it seems it is failing on one of the 
files, it can though update the others. If I do Cleartool desc on this 
version of file thought it is fine.

>>> Got API Error 207 (HTTP code 400): The file was not found in the 
repository.
>>> Error data: {u'stat': u'fail', u'file': 
u'/vbs/vob/comp/filename.C@@/main/130', u'err': {u'msg': u'The file was not 
found in the repository.', u'code': 207}, u'revision': u'/main/130'}
Traceback (most recent call last):
  File "/wsdb/oemtools/linux/bin/db2rbt", line 9, in 
load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
  File 
"/t/devinst/wsdb2/oemtools/linux/bin/rbt0.74/bin/RBTools-0.7.4-py2.6.egg/rbtools/commands/main.py",
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
"/t/devinst/wsdb2/oemtools/linux/bin/rbt0.74/bin/RBTools-0.7.4-py2.6.egg/rbtools/commands/__init__.py",
 
line 612, in run_from_argv
exit_code = self.main(*args) or 0
  File 
"/t/devinst/wsdb2/oemtools/linux/bin/rbt0.74/bin/RBTools-0.7.4-py2.6.egg/rbtools/commands/post.py",
 
line 797, in main
base_dir=base_dir)
  File 
"/t/devinst/wsdb2/oemtools/linux/bin/rbt0.74/bin/RBTools-0.7.4-py2.6.egg/rbtools/commands/post.py",
 
line 479, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff


The file was not found in the repository. (HTTP 400, API Error 207)

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can we setup optional notification?

[Sam]

Seems Reviewboard 2.5 is out. Is there any documentation on how to upgrade 
from 2.4 to 2.5?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 80769: ordinal not in range(128)

[Eric Johnson]

When I posted before, I surmised that the problem might be on the server.
To check that, have you tried browsing around in the web UI, fetching the
diffs from previous reviews? For a proper test, you may need to restart
memcached.

I figured out that the problem I was seeing is a problem with moving the
ReviewBoard instance from one machine to another, and not keeping the
secret key.

Eric.


On Wed, Oct 28, 2015 at 10:25 PM, Sam  wrote:

> I have over 400 files to review. When I run the cleartool diff on the last
> file in the trace I dont see any error but seems when rbt tries it fails.
>
> >>> Running: diff -uN /vbs/e/nq/file1.C@@/main/310 /vbs/e/nq/file1.C@
> @/main/br1_main_int/13
> Traceback (most recent call last):
>   File "/home/sam/bin/rbt", line 9, in 
> load_entry_point('RBTools==0.7.5', 'console_scripts', 'rbt')()
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/commands/main.py",
> line 133, in main
> command.run_from_argv([RB_MAIN, command_name] + args)
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/commands/__init__.py",
> line 622, in run_from_argv
> exit_code = self.main(*args) or 0
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/commands/post.py",
> line 691, in main
> extra_args=extra_args)
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 751, in diff
> return self._do_diff(changeset)
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 882, in _do_diff
> dl = self._diff_files(old_file, new_file)
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 793, in _diff_files
> translate_newlines=False)
>   File
> "/home/hotellnx117/sam/bin/RBTools-0.7.5-py2.6.egg/rbtools/utils/process.py",
> line 180, in execute
> % (rc, command, data))
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position
> 81162: ordinal not in range(128)
>
>
> extra_args=extra_args)
>   File
> "/home/hotellnx117/mojgans/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 751, in diff
> return self._do_diff(changeset)
>   File
> "/home/hotellnx117/mojgans/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 882, in _do_diff
> dl = self._diff_files(old_file, new_file)
>   File
> "/home/hotellnx117/mojgans/bin/RBTools-0.7.5-py2.6.egg/rbtools/clients/clearcase.py",
> line 793, in _diff_files
> translate_newlines=False)
>   File
> "/home/hotellnx117/mojgans/bin/RBTools-0.7.5-py2.6.egg/rbtools/utils/process.py",
> line 180, in execute
> % (rc, command, data))
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position
> 81162: ordinal not in range(128)
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard/Q2LwgQsAfO4/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Difference between -r and -u option in RBTools

[Sam]

Hello,

1- What is the difference between -r and -u option, seems with both you can 
update the review?

2- It seems for both you need to pass --summary --description? It seems 
that it can replace these in addition to updating the source code changes? 
Is that correct?

3- What if we want to append to the Summary or description?

4- Also seems that Testing-done cannot be updated from command line?

5- What about comments, can these be updated from command line?

6- Can we get the attributes of the review from command line ( ie. reviewer 
lists, review status...)?


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.