log files

2016-03-02 Thread eran meiri 
Hello,is it possible to do an automatic rollback of the log file?

after a while it becomes rather large for one file.

I can stop the server and do the roll back on my own but I wanted to check 
if there is an automatic solution for that

many thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

PDF Review on demo site

2016-03-02 Thread Keith Moyer 
On demo.reviewboard.org, there is a review request purportedly showing how 
PDF document review works (/r/4/).  However, for the life of me, I can't 
see how to open up the PDF to make comments in it.  Is Power Pack not 
enabled on the demo server?

We are considering making changes to our document review process and moving 
our document review to Review Board is an option.  I realize Power Pack 
comes with a trial, but the demo site would be way easier for the initial 
"just sanity check it looks like it's worth looking into further" stage.

I was part of the beta back before PDF document review was released, but I 
imagine it's come a long way since then and we don't have that Review Board 
installation any more to show other people anyway.

Thanks!

- Keith

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: diffviewer_diffset.name isn't in GROUP BY

2016-03-02 Thread Jason Woodrich 
Ah, found that in sql_mode from my.cnf.  Removing it resolved the issue. 
 Thanks for your help Christian!

On Tuesday, March 1, 2016 at 11:41:11 AM UTC-7, Christian Hammond wrote:
>
> Looks like your MySQL is configured to be very strict, in a way that isn't 
> compatible with Django's queries.
>
> You'll need to figure out where ONLY_FULL_GROUP_BY is enabled in your 
> configuration, and turn that off.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Mar 1, 2016 at 9:44 AM, Jason Woodrich  > wrote:
>
>> Sure, output is:
>>
>> SHOW VARIABLES LIKE 'sql_mode';
>>
>> +---+-+
>> | Variable_name | Value   
>> 
>> |
>>
>> +---+-+
>> | sql_mode  | 
>> ONLY_FULL_GROUP_BY,NO_AUTO_VALUE_ON_ZERO,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
>>  
>> |
>>
>> +---+-+
>> 1 row in set (0.00 sec)
>>
>> mysql> SELECT @@GLOBAL.sql_mode;
>>
>> +-+
>> | @@GLOBAL.sql_mode   
>> 
>> |
>>
>> +-+
>> | 
>> ONLY_FULL_GROUP_BY,NO_AUTO_VALUE_ON_ZERO,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
>>  
>> |
>>
>> +-+
>> 1 row in set (0.00 sec)
>>
>> mysql> SELECT @@SESSION.sql_mode;
>>
>> +-+
>> | @@SESSION.sql_mode 
>> 
>>  |
>>
>> +-+
>> | 
>> ONLY_FULL_GROUP_BY,NO_AUTO_VALUE_ON_ZERO,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
>>  
>> |
>>
>> +-+
>>
>>
>> On Friday, February 26, 2016 at 3:27:09 PM UTC-7, Christian Hammond wrote:
>>>
>>> Hi Jason,
>>>
>>> Python version shouldn't make a difference here (though we require 
>>> 1.6/1.7), and those versions look good now.
>>>
>>> I checked again, and I may have been looking at the wrong query before. 
>>> Looking at our production instance of 2.5.x, we have the exact same query 
>>> you have, and aren't hitting this problem with MySQL.
>>>
>>> Please run this and send me the output:
>>>
>>> $ rb-site manage /path/to/site dbshell
>>> SHOW VARIABLES LIKE 'sql_mode';
>>> SELECT @@GLOBAL.sql_mode;
>>> SELECT @@SESSION.sql_mode;
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Fri, Feb 26, 2016 at 1:26 PM, Jason Woodrich  
>>> wrote:
>>>
 Django is 1.6.11 and MySQL-python was 1.2.3, but I upgraded to 1.2.5 
 and removed 1.2.3.  I'm still getting the same error though.  Is there a 
 requirement for the python version?  

 Thanks
 Jason


 On Wednesday, February 17, 2016 at 2:49:02 PM UTC-7, Christian Hammond 
 wrote:
>
> Hi Jason,
>
> I looked into this here, and the query that's being generated on my 
> end is complete, containing all the GROUP BY terms.
>
> Can you verify the version of Django on your end?
>
> You might also want to try upgrading to MySQLdb-Python 1.2.5.
>
>

Re: Power Pack 1.2 is released: TFS support, flexible licensing, and free for up to 2 users

2016-03-02 Thread Cormick Nugent 
Hi again David.

Well my company have finally upgraded to TFS 2015 (but not Update 1 yet), 
so this is what I've done:

   - Upgraded ReviewBoard to version 2.5.3
   - Upgraded Review Board Power Pack to version 1.4
   - Obtained a new trial licence and activated PowerPack
   - Successfully added my new "Team foundation Server" repository (this is 
   where I was stopped the last time)


But now what?
When I go to create a new review, and select my TFS repository it is asking 
me to upload a file?  The documentation does not help here on what this 
file is and how do I get/create it.
Is this file a TFS Shelveset or some kind of diff/patch file? What is the 
process for creating the file etc.? What tools, if any, are required to 
create it etc.?

Any guidance and/or examples greatly appreciated.

Regards.

Cormick.


On Thursday, 21 May 2015 14:26:47 UTC+1, Cormick Nugent wrote:
>
> Wow, thank you David. Appreciate sorting the license.
>
> Cormick.
>
> On Wednesday, 20 May 2015 19:49:13 UTC+1, David Trowbridge wrote:
>>
>> Cormick,
>>
>> That's definitely an oversight, and I'll be fixing up the documentation 
>> ASAP. In the meantime I'll clear your existing license out of the system so 
>> you can request a new trial when you do upgrade to 2013.
>>
>> -David
>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard 2.5.3 - SVN - Unexpected error when validating the diff: list index out of range (HTTP 400, API Error 224)

2016-03-02 Thread Markus Fischbacher 
Hi Christian,

sure, I'll file the bug and attach the diff.

Thanks for your response :)

Markus

Am Mittwoch, 2. März 2016 11:09:42 UTC+1 schrieb Christian Hammond:
>
> Hi Markus,
>
> While our diff parser should be handling the property changes, it's 
> possible there's a bug there.
>
> Can you file a bug on 
> https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and 
> attach a copy of that diff, so we can track this and inspect the raw 
> contents of the diff?
>
> Thanks,
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard 2.5.3 - SVN - Unexpected error when validating the diff: list index out of range (HTTP 400, API Error 224)

2016-03-02 Thread Christian Hammond 
Hi Markus,

While our diff parser should be handling the property changes, it's
possible there's a bug there.

Can you file a bug on
https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and
attach a copy of that diff, so we can track this and inspect the raw
contents of the diff?

Thanks,

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Mar 2, 2016 at 1:34 AM, Markus Fischbacher <
markus.fischbac...@live.at> wrote:

> Hi Christian,
>
> thank you for your fast response.
>
> This is the log from Review Board:
>
> 2016-03-02 09:28:11,966 - DEBUG - None - AnonymousUser - /api/ -
> Attempting authentication on API: username=sst, password=
> 2016-03-02 09:28:11,972 - DEBUG -  - Attempting to authenticate as CN=sst
> sst,OU=Systemaccounts,OU=euro,DC=euro,DC=com
> 2016-03-02 09:28:13,733 - DEBUG -  - DiffParser.parse: Beginning parse of
> diff, size = 925
> 2016-03-02 09:28:13,733 - ERROR -  - Unexpected error when validating diff.
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/webapi/resources/validate_diff.py",
> line 156, in create
> save=False)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 417, in create_from_upload
> save=save)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 441, in create_from_data
> check_existence=(not parent_diff_file_contents)))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 557, in _process_files
> for f in parser.parse():
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 59, in parse
> next_linenum, new_file = self.parse_change_header(i)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 100, in parse_change_header
> linenum = self.parse_special_header(linenum, info)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/__init__.py",
> line 526, in parse_special_header
> linenum, info)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 162, in parse_special_header
> info['index'] = self.lines[linenum].split(None, 1)[1]
> IndexError: list index out of range
> 2016-03-02 09:28:14,081 - DEBUG -  - Calculated issue counts for review
> request ID 744 across 1 review(s): Resulting counts = {u'R': 0, u'D': 0,
> u'O': 0}; DB values = [{u'screenshot_comments__issue_status': None,
> u'file_attachment_comments__pk': None,
> u'screenshot_comments__issue_opened': None, u'comments__pk': None,
> u'comments__issue_opened': None, u'file_attachment_comments__issue_opened':
> None, u'screenshot_comments__pk': None, u'comments__issue_status': None,
> u'file_attachment_comments__issue_status': None}]; Field IDs =
> {u'screenshot_comments': set([]), u'comments': set([]),
> u'file_attachment_comments': set([])}
>
> That's the diff:
>
> D:\DEV\test-repo>rbt diff
> Index: /trunk/ordner1/text1.txt
> ===
> --- /trunk/ordner1/text1.txt(revision 30)
> +++ /trunk/ordner1/text1.txt(working copy)
> @@ -3,4 +3,5 @@
>  test
>
>  test
> -bla bla
> \ No newline at end of file
> +bla bla
> +test
> \ No newline at end of file
> Index: /trunk
> ===
> --- /trunk  (revision 1)
> +++ /trunk  (working copy)
>
> Property changes on: trunk
> ___
> Added: reviewboard:url
> ## -0,0 +1 ##
> +http://review.efu.com
> \ No newline at end of property
> Index:
> ===
> --- (revision 0)
> +++ (working copy)
>
> Property changes on: .
> ___
> Added: reviewboard:url
> ## -0,0 +1 ##
> +http://review.efu.com
> \ No newline at end of property
>
>
> Kind regards,
> Markus
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpac

Re: ReviewBoard 2.5.3 - SVN - Unexpected error when validating the diff: list index out of range (HTTP 400, API Error 224)

2016-03-02 Thread Markus Fischbacher 
Hi Christian,

thank you for your fast response.

This is the log from Review Board:

2016-03-02 09:28:11,966 - DEBUG - None - AnonymousUser - /api/ - Attempting 
authentication on API: username=sst, password=
2016-03-02 09:28:11,972 - DEBUG -  - Attempting to authenticate as CN=sst 
sst,OU=Systemaccounts,OU=euro,DC=euro,DC=com
2016-03-02 09:28:13,733 - DEBUG -  - DiffParser.parse: Beginning parse of 
diff, size = 925
2016-03-02 09:28:13,733 - ERROR -  - Unexpected error when validating diff.
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/webapi/resources/validate_diff.py",
 
line 156, in create
save=False)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
 
line 417, in create_from_upload
save=save)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
 
line 441, in create_from_data
check_existence=(not parent_diff_file_contents)))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
 
line 557, in _process_files
for f in parser.parse():
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
 
line 59, in parse
next_linenum, new_file = self.parse_change_header(i)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
 
line 100, in parse_change_header
linenum = self.parse_special_header(linenum, info)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/__init__.py",
 
line 526, in parse_special_header
linenum, info)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
 
line 162, in parse_special_header
info['index'] = self.lines[linenum].split(None, 1)[1]
IndexError: list index out of range
2016-03-02 09:28:14,081 - DEBUG -  - Calculated issue counts for review 
request ID 744 across 1 review(s): Resulting counts = {u'R': 0, u'D': 0, 
u'O': 0}; DB values = [{u'screenshot_comments__issue_status': None, 
u'file_attachment_comments__pk': None, 
u'screenshot_comments__issue_opened': None, u'comments__pk': None, 
u'comments__issue_opened': None, u'file_attachment_comments__issue_opened': 
None, u'screenshot_comments__pk': None, u'comments__issue_status': None, 
u'file_attachment_comments__issue_status': None}]; Field IDs = 
{u'screenshot_comments': set([]), u'comments': set([]), 
u'file_attachment_comments': set([])}

That's the diff:

D:\DEV\test-repo>rbt diff
Index: /trunk/ordner1/text1.txt
===
--- /trunk/ordner1/text1.txt(revision 30)
+++ /trunk/ordner1/text1.txt(working copy)
@@ -3,4 +3,5 @@
 test

 test
-bla bla
\ No newline at end of file
+bla bla
+test
\ No newline at end of file
Index: /trunk
===
--- /trunk  (revision 1)
+++ /trunk  (working copy)

Property changes on: trunk
___
Added: reviewboard:url
## -0,0 +1 ##
+http://review.efu.com
\ No newline at end of property
Index:
===
--- (revision 0)
+++ (working copy)

Property changes on: .
___
Added: reviewboard:url
## -0,0 +1 ##
+http://review.efu.com
\ No newline at end of property


Kind regards,
Markus

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.