error with a patch (patch xxx failed to apply cleanly)

2017-08-14 Thread Adrien Rochereau
here is the patch in question attached,

the issue showed on ubuntu 12.04.5
Reviewboard 2.5.4 then 2.5.15
python 2.7.3

here is the complete log:

Traceback (most recent call last):
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 300, in get
response = renderer.render_to_response(request)
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 298, in cache_memoize
compress_large_data))
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 252, in cache_memoize_iter
items = items_or_callable()
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in 
lambda: [lookup_callable()],
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 669, in populate_diff_chunks
chunks = list(generator.get_chunks())
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 786, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 298, in cache_memoize
compress_large_data))
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 252, in cache_memoize_iter
items = items_or_callable()
File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in 
lambda: [lookup_callable()],
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 793, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch
'output': stderr,
Exception: The patch to 
'jhoang/Rel_22.0.1123_Bundle3_v4/WebApps/CommPilot/ServiceProvider/DefaultConfig/Nested/CustomTags/body.jsp'
 
didn't apply cleanly. The temporary files have been left in 
'/tmp/reviewboard.OMLo8e' for debugging purposes.
`patch` returned:

As mentionned it happend on both 2.5.4 and 2.5.15 as the diff is really 
small I guess it might be some syntax that it does not like, I tried a 
couple times, changed some blank space  just in case, did not help.
first time seeing this error in over 13k reviews

-- 

http://www.broadsoftconnections.com 

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

Ce message confidentiel  et les éventuelles pièces jointes sont à l’usage 
exclusif de son ou de sa destinataire. Il est interdit, pour toute autre 
personne, de le distribuer, d’en dévoiler le contenu ou de le reproduire. 
Si vous avez reçu cette communication par erreur, veuillez en informer 
immédiatement l’expéditeur par courrier électronique et détruire l’original 
de ce message ainsi que toute copie.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To 

Re: Review Board 2.0.3, and the new Package Store!

2014-07-16 Thread Adrien Rochereau
thanks, looking great and the fix for the long string is welcome :)


-- 

See why you should attend BroadSoft Connections 2014 
http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: scroll issue on some file

2014-06-02 Thread Adrien Rochereau
I indeed have a couple long html strings in that file, I will wrap and see 
if it happens again  (long being a couple 300ish lines and one 500ish line)
I'll update you if it happens on files with shorter lines, in the mean time 
I will assume that this is the source of the problem (and should be fixed 
in my file in fact)

Thanks

On Thursday, May 29, 2014 6:22:18 PM UTC-4, Christian Hammond wrote:

 Hi Adrien,

 Somewhere in that file, I imagine you have a very long line that the 
 browser is unable to wrap.

 We rely on the browser to handle wrapping, since we have very little 
 control of that. Some browsers work differently than other browsers in this 
 regard. If you have a line that the browser considers one long unwrappable 
 string, then it's going to cause this sort of problem.

 Can you check to see if that's the case?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 29, 2014 at 12:46 PM, Adrien Rochereau aroch...@broadsoft.com 
 javascript: wrote:

 this one is a weird bug, on 2.0.1 it does not detect properly when to 
 wrap the lines and it makes it impossible to review a file, see screenshot.
 please note that this is one file out of more than 50, so definitely not 
 a common bug but still annoying:


 https://lh5.googleusercontent.com/-ThIEqGdw0fM/U4eNQN3lVXI/AFo/JE0lZonGryo/s1600/scrolling+bug.png

 as you can see the right side is being cut, let me know if you need more 
 information. scrolling down to other files, the other files were correct.

  
 See why you should attend BroadSoft Connections 2014 
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is 
 addressed and may contain confidential and/or privileged information. If 
 you are not the intended recipient and have received this email in error, 
 please notify BroadSoft, Inc. immediately by replying to this message, and 
 destroy all copies of this message, along with any attachment, prior to 
 reading, distributing or copying it.
  
 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-06-02 Thread Adrien Rochereau
getting the same logs using tortoisesvn as well

On Tuesday, May 27, 2014 11:10:31 PM UTC-4, MoonWalker wrote:

 No, we are using tortoisesvn to generate an unified diffs. We are using 
 SVN only

 On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.c...@gmail.com 
 wrote:

 I renable Debug mode, because we are experiencing some strange behavior 
 on some reviews, when we try to update some reviews. Seems like when the 
 developers submit publish the nothing happens and the new review does not 
 get published. 

 I have the following warring and this may or may not explain such 
 behavior or any other potential issue.

  23:00:49WARNING 

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING 

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only 
 change that I made is enable DEBUG = True on settings_local.py

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Multiple Warnings and strange behaviour on RB2.0

2014-06-02 Thread Adrien Rochereau
publishing actually works fine, so not related as you said.
These are actual warnings not errors anyway


On Mon, Jun 2, 2014 at 3:31 PM, Christian Hammond christ...@beanbaginc.com
wrote:

 Nothing in those logs are related, so I don't actually have anything to go
 on. Those are just harmless warnings that everybody will see.

 While TortoiseSVN should be compatible, it's not actively tested. Still,
 it should *never* cause an issue with publishing.

 Adrien, are you also unable to publish? What does the browser's JavaScript
 console and HTTP response in the Network tab for the publish request show?

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Mon, Jun 2, 2014 at 11:58 AM, Adrien Rochereau 
 arocher...@broadsoft.com wrote:

 getting the same logs using tortoisesvn as well


 On Tuesday, May 27, 2014 11:10:31 PM UTC-4, MoonWalker wrote:

 No, we are using tortoisesvn to generate an unified diffs. We are using
 SVN only

 On Wednesday, May 28, 2014 12:21:18 PM UTC+10, Christian Hammond wrote:

 Hi,

 Those are completely harmless and unrelated.

 Are you using any extensions? ReviewBot perhaps?

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, May 27, 2014 at 7:19 PM, MoonWalker daniel.c...@gmail.com
 wrote:

 I renable Debug mode, because we are experiencing some strange
 behavior on some reviews, when we try to update some reviews. Seems like
 when the developers submit publish the nothing happens and the new review
 does not get published.

 I have the following warring and this may or may not explain such
 behavior or any other potential issue.

  23:00:49WARNING

  - Cache data for key 
 codereview.local:/:diffviewer/diff_file_fragment.html-3-1-3809-collapsed-highlighting-en-1401231630
  (length 1706544) may be too big for the cache.

  01:45:59WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848:
  RuntimeWarning: DateTimeField User.last_login received a naive datetime 
 (2014-05-21 00:00:00) while time zone support is active.
   RuntimeWarning)

  1:46:00WARNING

  - 
 /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327:
  DeprecationWarning: Using mimetype keyword argument is deprecated, use 
 content_type instead
   super(HttpResponse, self).__init__(*args, **kwargs)


 Is there any way to increase the level of verbosity, so far the only
 change that I made is enable DEBUG = True on settings_local.py

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 See why you should attend BroadSoft Connections 2014
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is
 addressed and may contain confidential and/or privileged information. If
 you are not the intended recipient and have received this email in error,
 please notify BroadSoft, Inc. immediately by replying to this message, and
 destroy all copies of this message, along with any attachment, prior to
 reading, distributing or copying it.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/M_xRSmgWRQo/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain

Re: css issue with text fields (review/test) in google chrome (fine in firefox)

2014-05-29 Thread Adrien Rochereau
Hi Christian,

this seems to happen with some reviews and not with the new one,
running most current chrome with no extensions, I also tried clearing the 
cache
I suspect something regarding the length of the longest string?
it also happens in a private browsing window


On Wednesday, May 28, 2014 3:27:05 PM UTC-4, Christian Hammond wrote:

 Hi Adrien,

 Very, very strange. I run Chrome primarily and haven't hit this at all, 
 and we've had this new text area format for some time now.

 Just as a sanity check, can you try clearing cache?

 Also, are there any customizations (extensions, custom CSS, patches of any 
 sort) to your build?

 Can you also verify what build of Chrome you're running?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Wed, May 28, 2014 at 7:04 AM, Adrien Rochereau 
 aroch...@broadsoft.comjavascript:
  wrote:

 somehow the text fields are overlapping the information fields on the 
 right side of the window, like shown in the attachent
 this is using the latest version of chrome, RB 2.0.1 on ubuntu 12.0.4 
 with all the latest updates
 as I said it looks perfectly fine on firefox.


 https://lh4.googleusercontent.com/-zJhVilKuZ-c/U4Xsp1rHQwI/AFU/LW60yVudEzc/s1600/RB2.0.1+overlap.png

 other than that I did not see any CSS issues elsewhere or any rendering 
 that would be different between both navigators


 See why you should attend BroadSoft Connections 
 2014http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is 
 addressed and may contain confidential and/or privileged information. If 
 you are not the intended recipient and have received this email in error, 
 please notify BroadSoft, Inc. immediately by replying to this message, and 
 destroy all copies of this message, along with any attachment, prior to 
 reading, distributing or copying it.
  
 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


scroll issue on some file

2014-05-29 Thread Adrien Rochereau
this one is a weird bug, on 2.0.1 it does not detect properly when to wrap 
the lines and it makes it impossible to review a file, see screenshot.
please note that this is one file out of more than 50, so definitely not a 
common bug but still annoying:

https://lh5.googleusercontent.com/-ThIEqGdw0fM/U4eNQN3lVXI/AFo/JE0lZonGryo/s1600/scrolling+bug.png

as you can see the right side is being cut, let me know if you need more 
information. scrolling down to other files, the other files were correct.


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: css issue with text fields (review/test) in google chrome (fine in firefox)

2014-05-29 Thread Adrien Rochereau
I will check for both and report on the longest strings,
but it sounds like a good start indeed, I should be able to reduce it,

thanks!


On Thu, May 29, 2014 at 6:23 PM, Christian Hammond chip...@chipx86.com
wrote:

 If you have a very long unwrappable string, just like the other e-mail I
 replied to, you may hit this problem.

 I can see about ways to limit this, but we may be limited in what we can
 do here.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Thu, May 29, 2014 at 12:38 PM, Adrien Rochereau 
 arocher...@broadsoft.com wrote:

 Hi Christian,

 this seems to happen with some reviews and not with the new one,
 running most current chrome with no extensions, I also tried clearing the
 cache
 I suspect something regarding the length of the longest string?
 it also happens in a private browsing window


 On Wednesday, May 28, 2014 3:27:05 PM UTC-4, Christian Hammond wrote:

 Hi Adrien,

 Very, very strange. I run Chrome primarily and haven't hit this at all,
 and we've had this new text area format for some time now.

 Just as a sanity check, can you try clearing cache?

 Also, are there any customizations (extensions, custom CSS, patches of
 any sort) to your build?

 Can you also verify what build of Chrome you're running?

 Christian

 --
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Wed, May 28, 2014 at 7:04 AM, Adrien Rochereau 
 aroch...@broadsoft.com wrote:

  somehow the text fields are overlapping the information fields on the
 right side of the window, like shown in the attachent
 this is using the latest version of chrome, RB 2.0.1 on ubuntu 12.0.4
 with all the latest updates
 as I said it looks perfectly fine on firefox.


 https://lh4.googleusercontent.com/-zJhVilKuZ-c/U4Xsp1rHQwI/AFU/LW60yVudEzc/s1600/RB2.0.1+overlap.png

 other than that I did not see any CSS issues elsewhere or any rendering
 that would be different between both navigators


 See why you should attend BroadSoft Connections 2014
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is
 addressed and may contain confidential and/or privileged information. If
 you are not the intended recipient and have received this email in error,
 please notify BroadSoft, Inc. immediately by replying to this message, and
 destroy all copies of this message, along with any attachment, prior to
 reading, distributing or copying it.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.

 For more options, visit https://groups.google.com/d/optout.



 See why you should attend BroadSoft Connections 2014
 http://broadsoftconnections.com/

 This email is intended solely for the person or entity to which it is
 addressed and may contain confidential and/or privileged information. If
 you are not the intended recipient and have received this email in error,
 please notify BroadSoft, Inc. immediately by replying to this message, and
 destroy all copies of this message, along with any attachment, prior to
 reading, distributing or copying it.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups reviewboard group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/reviewboard/rjRXgALCaDk/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient

css issue with text fields (review/test) in google chrome (fine in firefox)

2014-05-28 Thread Adrien Rochereau
somehow the text fields are overlapping the information fields on the right 
side of the window, like shown in the attachent
this is using the latest version of chrome, RB 2.0.1 on ubuntu 12.0.4 with 
all the latest updates
as I said it looks perfectly fine on firefox.

https://lh4.googleusercontent.com/-zJhVilKuZ-c/U4Xsp1rHQwI/AFU/LW60yVudEzc/s1600/RB2.0.1+overlap.png

other than that I did not see any CSS issues elsewhere or any rendering 
that would be different between both navigators


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: How to configure the search properly

2014-05-28 Thread Adrien Rochereau
Same issue here, except I did not rebuild the index but I get the no 
results thing (side note, as with 1.7.21 the instant search still works 
just fine)

On Tuesday, May 27, 2014 9:26:54 PM UTC-4, Christian Wuerdig wrote:

 Hi,

 We always had trouble with the search largely due to this bug: 
 https://code.google.com/p/reviewboard/issues/detail?id=2544

 Now with 2.0 I tried the search again and it worked a little bit better - 
 instead of coming up with an error 500 I always got No results

 So I figured maybe I need to rebuild the index which I did with sudo 
 rb-site manage /var/www/codereview/ rebuild_index

 It warned me that it will delete all indices and then claimed Indexing 1 
 review request - hm, we have about 11,000+ review requests in the system 
 so that is a bit weird
 Also the search is now broken - I'm getting a server error 500 again and 
 the stack trace points to:

 IOError: The path to your Whoosh index '/var/www/codereview/index' is not 
 writable for the current user/group.

 Typing something into the search box will yield perfectly good results 
 after a little while in the drop down (as long as what I'm looking for is 
 part of the Summary) just hitting enter on the search box won't work 
 properly.

 So my questions are:

 1. How do I properly configure the search - mainly which user should own 
 the index? Apparently not root because that's what it is now and that's not 
 working.

 2. How can I track down the indexing problem (in the sense that it claims 
 it can only index 1 request)?


 Cheers
 Christian


-- 

See why you should attend BroadSoft Connections 
2014http://broadsoftconnections.com/

This email is intended solely for the person or entity to which it is 
addressed and may contain confidential and/or privileged information. If 
you are not the intended recipient and have received this email in error, 
please notify BroadSoft, Inc. immediately by replying to this message, and 
destroy all copies of this message, along with any attachment, prior to 
reading, distributing or copying it.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: epel 5.4 missing reviewboard package

2013-11-12 Thread Adrien Rochereau
Thanks guys,

well we moved to a recent ubuntu instead and installed it..
not our standard work environment though, but it was less trouble like that.


On Tuesday, November 12, 2013 8:35:55 AM UTC-5, Stephen Gallagher wrote:

 On 11/11/2013 07:21 AM, Dan Porter wrote: 
  For those wanting to run RBTools under EL5 (which is unfortunately our 
  main production environment still), attached is an unofficial package we 
  use at our company.  It's built from standard sources and contains a 
  minor patch.  No post 0.5.2 updates/patches have been applied. 
  
  Link to Gist if you wish to build this 
  yourself: https://gist.github.com/Stealthii/7412376 
  
  On reviewboard itself I can confirm there are issues running this on 
  RHEL5.  Strongly recommend 6.2+. 
  
  On Monday, November 4, 2013 11:35:43 PM UTC, Stephen Gallagher wrote: 
  
  On 11/04/2013 01:28 PM, Adrien Rochereau wrote: 
   Hi, I did an install two weeks ago on a centos 5.4 without any 
  issues, 
   This week, trying to do the same thing on RHEL 5.4 and yum kept 
   returining not found, if you go to the package browser on fedora's 
   website, you cannot find RB anymore under 5/i386. 
   Is this because of an update or are you pulling the support of 
 EPEL5? 
   
  
  
  Yes, I sent out an announcement quite a while ago. RHEL/CentOS 4 is 
 too 
  old and cannot support ReviewBoard any longer without significant 
  effort 
  in porting all of its dependencies to the python26 toolchain in 
 EPEL. 
  Given that RHEL 5 is very old and in maintenance mode, I reasoned 
 that 
  people would generally accept running a RHEL 6 VM to power 
 ReviewBoard 
  if they wanted to. 

 Oops! Thanks for pointing this out to me. I thought I had released an 
 RBTools 0.5.2 package for EPEL 5, but it looks like I must have 
 forgotten to. It's now built and on the way to the EPEL 5 
 updates-testing repository. 

 I retired the Review Board server from EPEL 5, but it makes sense to 
 maintain the client. 

 I've created the package now: 
 https://admin.fedoraproject.org/updates/RBTools-0.5.2-1.el5 

 It should get into the epel-testing repo within 48 hours. You can also 
 download the RPM directly from the link above. 

 Dan: I don't understand the point of the patch in your gist. It looks 
 like a variant of an old one I had created, but it's no longer 
 necessary. I got a better version upstreamed so that it will try to use 
 the system copy before it resorts to ez_setup. Your patch doesn't really 
 hurt anything, but it's unnecessary. 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


epel 5.4 missing reviewboard package

2013-11-04 Thread Adrien Rochereau
Hi, I did an install two weeks ago on a centos 5.4 without any issues,
This week, trying to do the same thing on RHEL 5.4 and yum kept returining 
not found, if you go to the package browser on fedora's website, you cannot 
find RB anymore under 5/i386.
Is this because of an update or are you pulling the support of EPEL5?

Thanks

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.