Re: need help to integrate post-review with Perforce

[David Ball]

You may find cycgwin is a bit OTT if you just want a compliant diff
utiltiy on Windows. I found diff-utils from GnuWin32 worked fine.  See
the link below for how I prepared a client package to share with
developers using ReviewBoard with Perforce on windows. (Skip to bullet
10 for the GnuWin32 bit):
http://waveydavey.wordpress.com/home/computing/installing-review-board-10-alpha-2-on-windows-for-perforce/#InstallingReviewBoardonWindowsforPerforce-Windows

David

On Thu, Jun 11, 2009 at 5:28 PM, Raghu wrote:
>
> You need to have a diff.exe that supports unified output format in
> your path. If you don't have it, you can get it by installing Cygwin
> (http://www.cygwin.com/).
>
> -Raghu
>
> On Jun 11, 3:34 pm, Amit  wrote:
>> Tanks a lot for response. I could intergate with p4win.
>> Now problem i am facing is
>> Traceback (most recent call last):
>>   File "post-review", line 2313, in ?
>>     main(sys.argv[1:])
>>   File "post-review", line 2284, in main
>>     diff, parent_diff = tool.diff(args)
>>   File "post-review", line 1446, in diff
>>     dl = execute(diff_cmd, extra_ignore_errors=(1,2)).splitlines(True)
>>   File "post-review", line 1889, in execute
>>     env=env)
>>   File "C:\Python24\lib\subprocess.py", line 554, in __init__
>>     errread, errwrite)
>>   File "C:\Python24\lib\subprocess.py", line 718, in _execute_child
>>     startupinfo)
>> WindowsError: [Errno 2] The system cannot find the file specified
>>
>> What might be cause for it.What should i do to get rid of it.
>>
>> -Amit
>>
>> On Jun 11, 1:03 am, Paul Scott  wrote:
>>
>> > Well, everyone who uses p4 will probably rather use post-review. ;)
>>
>> > The tool in the rbtools/contrib should probably be renamed something with 
>> > "p4win" in it, as it is an extension for p4win, and a lot of people use 
>> > p4v now since p4win has been deprecated for a few years. I keep starting 
>> > to make a similar extension ("custom tool") for p4v but their "terminal" 
>> > isn't a real terminal and can't handle the method post-review uses to 
>> > collect your password if you need to authenticate. That's certainly 
>> > something that can be handled pretty easily... post-review, or a wrapper 
>> > (or preferably a rbapi library) probably needs a way of finding out if you 
>> > are authenticated or not that doesn't go directly to asking you for your 
>> > password.
>>
>> > -- Paul
>> > 
>> > From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On 
>> > Behalf Of Joshua Slominski [hoohaa8...@gmail.com]
>> > Sent: Wednesday, June 10, 2009 9:44 AM
>> > To: reviewboard@googlegroups.com
>> > Subject: Re: need help to integrate post-review with Perforce
>>
>> > There is a P4 tool located in rbtools/ contrib.  If you set that up there 
>> > is no need to run post-review from the command line.
>>
>> > On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond 
>> > mailto:chip...@chipx86.com>> wrote:
>> > There's a lot of documentation on this 
>> > athttp://www.review-board.org/docs/manual/dev/users/tools/post-review/
>>
>> > Christian
>>
>> > --
>> > Christian Hammond - chip...@chipx86.com
>> > Review Board -http://www.review-board.org
>> > VMware, Inc. -http://www.vmware.com
>>
>> > On Tue, Jun 9, 2009 at 1:34 AM, Amit 
>> > mailto:agrawalamit2...@gmail.com>> wrote:
>>
>> > Hi,
>>
>> > I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed
>> > for integrating post-review into Perforce.
>> > Any help will be highly appreciated.
>>
>> > -Amit
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Rolling out Review Board

[David Ball]

Raghu,

I can't help with bulk user loading, but on item 1

Once you have a working installation of post-review, you can use the
py2exe to create a windows executable which can be distributed to
staff (I'm assuming your users are working under windows).

I couldn't find a detailed explanation in the ReviewBoard archive, so
here's a step-by-step of how I did it (Windows XP Pro SP3, Python
2.5.4, Review Board 1.0 alpha 2)

1) Take as your starting point a working post-review.py script on a
Windows machine.

2) Download the py2exe package "py2exe-0.6.9.win32-py2.5.exe" from
http://sourceforge.net/project/showfiles.php?group_id=15583 and
install.  (I assume you can use easy_install instead, but I can't make
it work with our web proxy)

3) Make sure there are no ".egg" files in the Python site-packages
folder (C:\Python25\Lib\site-packages). These are zipped and py2exe
can't handle them. They must be unzipped into folders of the same
name. If there are do the following:
3a) Rename by adding a ".zip" extension after the ".egg" extension.
3b) Unzip the extension to a folder with the same name as the
original ".egg" file.

4) In the same folder as post-review.py create a setup.py script
containing exactly the lines below. This will use py2exe to generate
the executable:

from distutils.core import setup
import py2exe

setup(
options = {'py2exe': {'bundle_files': 1}},
console = ['post-review.py'],
zipfile = None,
)

5) Run the setup.py script:
prompt> python setup.py py2exe

6) The distributable package (comprising two exes and a DLL) can be
found in the new dist/ subdirectory.
The dist folder contents can be copied to client PCs. The
post-review.exe program works in exactly the same way as the original
python script it was generated from.

7) post-review requires GNU diff (at least it does when you're using
Perforce as I am). Download the GnuWin32 package
"diffutils-2.8.7-1.exe" from
http://gnuwin32.sourceforge.net/packages/diffutils.htm

8) Run the diffutils installer. Accept the default options except
where prompted for documentation, which should be deselected as not
required.

9) Copy the following files from C:\Program Files\GnuWin32\bin to the
post-review dist/ subdirectory:
diff.exe
libiconv2.dll
libintl3.dll

10) Rename the dist/ folder to something descriptive, then ZIP it up
and distribute to users - alternatively, I was able to build a simple
Windows installer at no cost using NSIS and HM NIS Edit.

David


On Thu, Apr 16, 2009 at 2:57 PM, Raghu Kaippully  wrote:
>
> Hi,
>
> I have been evaluating review board to see if we can use it within our 
> organization for code reviews. The initial reaction was very good and we are 
> nearing the end of a pilot phase where we'll roll this out to a large number 
> of users. I had a couple of questions:
>
> 1. Our development/build environment is perl based and nobody has python 
> installed in their machines. This is going to make it hard for installing 
> post-review. Has somebody thought about creating an installer that  bundles 
> python, setuptools, all required modules, and post-review into one package? I 
> tried creating a Windows installer using NSIS and found it quite simple. Can 
> I conribute that to review board?
>
> 2. Is there a way to bulk-load all users and groups into the database? If we 
> do not do that a requester will not be able to add a reviewer in the review 
> request till the reviewer has logged in at least once.
>
> Thanks in advance for the help,
> Raghu
>
> >

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Windows installation methods?

[David Ball]

Yep. No plans to move or remove it.  It would be good to see the info
incorporated into the Review Board documentation - especially if people
who know better than me can correct or improve on some the the things I
could have done better.  

Christian Hammond said the following on 05/03/2009 09:04:
Nice! Thanks for doing that :) Do you plan to keep this
page up long-term? I'd like to take the notes and include them all in
the official docs, and I can link to you and your page in a credits
section.
  
Christian
  
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
  
  
  On Wed, Mar 4, 2009 at 3:53 AM, David B 
wrote:
  
I had a quick go at memcached this morning and it seems to have
worked. I've added the details here :
http://waveydavey.wordpress.com/home/computing/installing-review-board-10-alpha-2-on-windows-for-perforce/#InstallingReviewBoardonWindowsforPerforce-ImprovingReviewBoardPerformanceWithmemcached





  
  
  
  
  


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups "reviewboard" group.  To post to this group, send email to reviewboard@googlegroups.com  To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com  For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: How to create a pre-commit review with ReviewBoard and Perforce?

[David Ball]

Hi Pierre,

You'll need to move your open files from the default changelist to a
numbered pending changelist. You can continue to edit them and they won't be
checked in.

At the command line you can do this with:

p4 change

Which will open your text editor so you can describe your new changelist and
select which files it is to include. By default all of the opened files on
your default changelist will be included. Just delete the ones you don't
want.

In P4Win (and I expect P4V too, but I'm behind the times and don't use it
yet) right click on your opened file(s) and select "Move to another
changelist...", or right click on the default changelist itself and select
"New changelist..."

Once you have done this, run the post-review script and provide the number
of your newly created (but not submitted) changelist.

Obviously you need to run post-review on the same machine/login where you
are editing the files.

Cheers
David


On Fri, Feb 20, 2009 at 7:24 PM, Pierre Rouleau wrote:

>
> Hi all,
>
> First: many thanks for this great application!!
>
> This might be a newbie question, and I apologize if this is.  I have
> been looking to find an answer to that question but failed so far...
>
> My question is:
>
> With ReviewBoard Alpha 4 and Perforce VCS, is it possible to create
> pre-commit review (and how)?
>
> I tried using the post-commit script but it seems to require a
> changeset number.
>
> Thanks in advance!
>
> Pierre
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---