Re: Reversed (or previously applied) patch detected! when view diff after git push
Hi, I also got this same problem (reversed patch detected after I push my changes to the central repository, so I can't view the diff anymore). I am using mercurial instead of git, on Review Board 1.6.3. Traceback (most recent call last): File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/views.py, line 151, in view_diff interdiffset, highlighting, True) File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py, line 1071, in get_diff_files large_data=True) File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py, line 552, in get_chunks new = get_patched_file(old, filediff) File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py, line 374, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /opt/reviewboard_virtualenv/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py, line 242, in patch (filename, tempdir, patch_output)) Exception: The patch to '3rd_Party/PacsRuntime/3rdPartyRpms.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.IkSvOF' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.IkSvOF/tmpahHYOO Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.IkSvOF/tmpahHYOO-new.rej I was using `post-review --guess-summary --guess-description` to post my review and subsequenly using `post-review -r review_id` to update the existing review. One work-around I've found is to immediately re-post the review again after I've push my changes to the central repository using `post-review -r review_id --revision-range tip`. This work-around is highly annoying. Did I do something wrong when posting and updating the review? How can I avoid this work-around? How can I debug this problem? Thanks, Long -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
post-review --guess-summary not working with --revision-range
Hi,
When trying to post a review using --revision-range with --guess-
summary, I get the following error
Error data: {u'fields': {u'summary': [u'Summary cannot contain
newlines']}
because in my mercurial description field is multi-line.
However if I do not use --revision-range, this error doesn't occur and
the review request is created successfully.
Is this by design or a bug?
Long
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
How to systematically track all committed/pushed changeset for review status?
Hi, We use Mercurial as our source control. We have a central repository that everyone pushes to when their feature / bug fix is complete. We want to systematically track if all the pushed changeset has been reviewed on Review Board or not. Wonder if there's a suggested way to achieve that. Thanks, Long -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Summary and Description lost in discarded reviews (RB 1.5.6)
Right ! This problem only happened for not published reviews. On Nov 10, 4:17 pm, Christian Hammond chip...@chipx86.com wrote: The review request needs to be published first. Otherwise it's in draft form, and not persisted. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Nov 10, 2011 at 7:38 AM, Long VU t.long...@gmail.com wrote: We have Review Board 1.5.6. When a review is discarded, its summary and description fields are deleted. Only the diff is kept. This situation prevents us from reopening the review later because we have a hard time figuring out what the review was in the first place. If this situation has been fixed, let us know which version has the fix. Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board, Git and patch-series
+1 vote for patch-series feature. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to create a review containing multiple diffs (changesets) separately?
We use mercurial. In order to have a meaningful and concise description for each changeset, we usually split a bug fix or a feature implementation in multiple changesets. This workflow helps the reviewer as it is clear what the developer wants to do at each step. Using post-review to create a review of all outgoing changesets, it folds all changesets into one gigantic diff which makes it hard for the reviewer to understand the sequence of steps toward the solution, reducing the chance to discover a step is incorrect. For a new developer, it is harder to learn from a gigantic diff than from a series of concise diff with a clear description. So my question is how do we create one single review, listing each changeset separately with its respective description and also allow separate commenting for each changeset? We still want to have all those changesets part of once single review because they are related to the same bug/feature. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem with WSGI on fresh install
@Christian, @jonkeinan, Thanks, both your work-arounds worked and we need both of them together. On Nov 8, 5:20 am, יונתן קינן jonkei...@gmail.com wrote: You will also need to change the SITE_ROOT variable located in: /var/www/reviewboard/conf/settings_local.py(in my installation at least) You need to change SITE_ROOT from '/' to '/review/'(depends on the chosen sub directory) 2011/11/8 Christian Hammond chip...@chipx86.com 1.6.2 will ship with a fix for this. Try changing your WSGIScriptAlias to: WSGIScriptAlias /subdir /path/to/site/htdocs/reviewboard.wsgi/subdir Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Nov 7, 2011 at 1:59 PM, Long VU t.long...@gmail.com wrote: I also faced this problem and also would like to know if there's any workaround to have RB configured with a different root path than / ? Long On Sep 12, 10:47 am, Nicolas VINOT ae...@imirhil.fr wrote: Hi, I investigate more on this problem, and it sounds RB is totally unusable on subdirectory installation («http://forge/reviews/»in my case). « WSGIScriptAlias » parameter must not finish with a « / », otherwise WSGI concatenate URL-path part to the WSGI script path (leading to « Target WSGI script not found or unable to stat: /opt/reviewboard/htdocs/reviewboard.wsgiaccount » for « /account » URL). But in same time, « SITE_ROOT » and « FORCE_SCRIPT_NAME » are just a bunch of random behaviours. – SITE_ROOT = '/reviews/' + FORCE_SCRIPT_NAME = '' leads to RB-404-page, but with correct link on it («http://forge/reviews/account/register/»for example) – SITE_ROOT = '/' + FORCE_SCRIPT_NAME = '/reviews/' seems working, buthttp://forge/reviews/generatea 301-moved-permanently, and redirect to little wrong URL (double-slashed «http://forge/reviews//dashboard/»), itself generating a 302-found, redirecting to very wrong « unrooted » URLhttp://forge/account/login/?next_page=/reviews//dashboard/ And if I tricks to login, RB seems working correcly (200-found and correct links), but not logout and few other links (http://forge/account/login/ ) – SITE_ROOT = '/reviews/' + FORCE_SCRIPT_NAME = '/reviews/' doesn't work, home page is a 404-RB-error-page and all URL are wrong, with double subdir (http://forge/reviews/reviews/account/register/) So, at this moment, seems RB cannot be setup on a subdirectory, and only on a root directory of the web server. Is there any possible workaround ? -- Nicolas VINOT signature.asc 1KViewDownload -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Unable to start ReviewBoard
@Christian, @jonkeinan Both of your work-arounds worked and we do need both work-arounds together. Thanks !!! On Nov 8, 5:22 am, יונתן קינן jonkei...@gmail.com wrote: You also need to change the SITE_ROOT variable located in /var/www/reviewboard/conf/settings_local.py(in my installation at least) You need to change SITE_ROOT from '/' to '/review/'(depends on the chosen sub directory) 2011/11/8 Christian Hammond chip...@chipx86.com I just replied to someone else about the WSGI configuration. Basically, I think you can do: WSGIScriptAlias /reviews /path/to/site/htdocs/reviewboard.wsgi/reviews (No trailing slashes.) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Nov 7, 2011 at 2:09 PM, Long VU t.long...@gmail.com wrote: Further searching the archive, I found a work-around for my problem herehttp://groups.google.com/group/reviewboard/msg/d1f96ee0496ccd11. I have to use '/' for my root path. @Christian Below is my original /etc/httpd/conf.d/reviewboard-wsgi.conf. Changing the WSGIScriptAlias /reviews/ to WSGIScriptAlias / got RB working but now I am stuck with RB taking the default root which effectively hide all other services running on the same apache server. This is very annoying. VirtualHost *:80 ServerName localhost DocumentRoot /var/www/reviewboard/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html WSGIPassAuthorization On WSGIScriptAlias /reviews/ /var/www/reviewboard/htdocs/ reviewboard.wsgi Directory /var/www/reviewboard/htdocs AllowOverride All /Directory # Alias static media requests to filesystem Alias /reviews/media /var/www/reviewboard/htdocs/media Alias /reviews/errordocs /var/www/reviewboard/htdocs/ errordocs /VirtualHost On Nov 7, 4:51 pm, Long VU t.long...@gmail.com wrote: This is a better description of my problem. http://groups.google.com/group/reviewboard/msg/78437349407acea9 On Nov 7, 4:40 pm, Long VU t.long...@gmail.com wrote: Ok I fixed the issue by uninstalling and reinstalling everything. My server now can start but I get 404 Page Does Not Exist when going tohttp://localhost/reviews/(IhaveWSGIScriptAlias /reviews/ /var/ www/reviewboard/htdocs/reviewboard.wsgi). Then when I click on Log In I get this error in httpd/error_log [Mon Nov 07 16:37:36 2011] [error] [client ::1] Target WSGI script not found or unable to stat: /var/www/reviewboard/htdocs/ reviewboard.wsgiaccount, referer:http://localhost/reviews/;. Notice WSGI script requested is reviewboard.wsgiaccount (wrong suffix, should not have account there). Don't know why account is appended to reviewboard.wsgi. Anyone have any ideas? Thanks, Long On Nov 7, 4:22 pm, Long VU t.long...@gmail.com wrote: Hi, I am on RHEL 6 and this is what I have in my httpd/error_log. I am mew to python so I am not sure how to debug this. [Mon Nov 07 13:14:40 2011] [error] [client ::1] mod_wsgi (pid=5005): Exception occurred processing WSGI script '/var/www/reviewboard/htdocs/ reviewboard.wsgi'. [Mon Nov 07 13:14:40 2011] [error] [client ::1] Traceback (most recent call last): [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/django/core/handlers/wsgi.py, line 250, in __call__ [Mon Nov 07 13:14:40 2011] [error] [client ::1] self.load_middleware() [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/django/core/handlers/base.py, line 45, in load_middleware [Mon Nov 07 13:14:40 2011] [error] [client ::1] mod = import_module(mw_module) [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/django/utils/importlib.py, line 35, in import_module [Mon Nov 07 13:14:40 2011] [error] [client ::1] __import__(name) [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/reviewboard/admin/middleware.py, line 22, in module [Mon Nov 07 13:14:40 2011] [error] [client ::1] from reviewboard.admin.views import manual_updates_required [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/reviewboard/admin/views.py, line 16, in module [Mon Nov 07 13:14:40 2011] [error] [client ::1] from reviewboard.admin.forms import SSHSettingsForm [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib/ python2.6/site-packages/reviewboard/admin/forms.py, line 48, in module [Mon Nov 07 13:14:40 2011] [error] [client ::1] from reviewboard.scmtools import sshutils [Mon Nov 07 13:14:40 2011] [error] [client ::1] File /usr/lib
