Re: Does reviewboard support new review notifications other than email?
Thanks for the update. I guess I'll look into the code to see how I can apply the hooks I need. Tino On Jan 28, 10:50 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tino, WebHooks are going to go into the 1.6 release. We're hoping for this to be a quick release after 1.5 (a few months or so). For the time-being, you can maintain a clone of our Git repository and have a branch tracking master and write some code for this integration. It'll need to be updated when 1.6 comes out, though, and it will mean you'll have to package your own binaries. There's a page in our Code Base Documentation on reviewboard.orgthat describes how to maintain this. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 6:52 AM, Tino Breddin tino.bred...@googlemail.comwrote: Hi all, I'm interested in notifying external system about new review requests where email isn't a good option. I've read in the roadmap that generic hooks are planed for version 2.0, but is there anything similar in place now which could be used for this purpose? Cheers, Tino -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Does reviewboard support new review notifications other than email?
Hi all, I'm interested in notifying external system about new review requests where email isn't a good option. I've read in the roadmap that generic hooks are planed for version 2.0, but is there anything similar in place now which could be used for this purpose? Cheers, Tino -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problems with making post-review not load the system's proxy settings
Thanks, I'll give Python 2.6 a try. The documentation looks promising. Cheers, Tino On Fri, Jan 16, 2009 at 1:51 AM, Florian Föbel arenaweb...@googlemail.comwrote: Hi Tino, I got exactly the same problem and solved it with a rather lazy attempt. What I did is to unset the proxy environment variable directly in post-review using the following line of code added right at the beginning of the script: os.environ['http_proxy'] = '' According to the following documentation the problem should also be fixed with Python 2.6: http://docs.python.org/library/urllib.html Regards, Florian --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Problems with making post-review not load the system's proxy settings
Hi, We use Review Board within our group on a local server. Do get outside of the network we need to pass a proxy. That's why everybody usually has set http_proxy and no_proxy environment variables. Unfortunately the Python library urllib, which post-review uses to get the proxy settings of the system, does not check the no_proxy variable. This leads to 500 errors when I try to access the reviewboard server. A quick workaround is to surround the post-review call with 'unset http_proxy' and 'set http_proxy'. This works fine for most team members except for those with Macs. When running on a Mac urllib even checks the systems internet configuration, which is not that easy to alter. I tried to add a no_proxy switch to the post-review script (diff attached), but with this the script won't be able to authenticate anymore. Does anybody have an idea how to make that work properly? Thanks, Tino --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- add_no_proxy_support_to_postreview.diff Description: Binary data
creating multiple review requests for changes in one file
Hi, I am wondering how you handle changes in the same file which don't really fit into the same review request. So you would have a change for which you create a review request. Then you change other things in the same file and would like to create a review request for these changes only. Is it necessary to create branches for each of the changes, wait until the review is complete, commit changes and then merge branches into trunk? Thank, Tino --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
authentication problems when using the post-review script
Hi, I am new to review board. Fortunately I was able to setup a installation without major problems. Now I wanted to try the post- review script from the tools folder but without success. The login attempt fails with the following message: {stat: fail, err: {msg: The username or password was not correct, code: 104}} Unable to log in: The username or password was not correct (104) The credentials I entered are definitely right, since they work on the website. I also created another account for testing purposes and experienced the same problem. Further testing with curl ended up with the same error. Did I miss a important step during the installation? Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---