Default tab configuration
Hi, We use RB since year 2009 and several reviewers requested default tab configuration. When reviewer opens review request first time, View Diff tab should be opened. Another case is tha when author/reviewer received email with review and click on link, View Reviews tab should be opened. To implement it, I can't use extensions and will be obliged to hack RB. What do you think about such feature? Could you please advise how it implement correctly? Thank you in advance, Michael. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Default tab configuration
Hi Michael, Each page has its own URL. Flipping what /r/123/ and /r/123/diff/ points to doesn't really make any sense. The e-mails have a link to the review request, so users can always click on those. No need to change the View Diff link. Unless I'm missing something, there's nothing you really need to do differently here except click a different link. For the dashboard, you'd have to rewrite part of the code to change what the review request summary it links to. It's not something we'd accept upstream. That would be in reviewboard/reviews/datagrids.py. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 10:25 AM, Michael Zhilin miz...@gmail.com wrote: Hi, We use RB since year 2009 and several reviewers requested default tab configuration. When reviewer opens review request first time, View Diff tab should be opened. Another case is tha when author/reviewer received email with review and click on link, View Reviews tab should be opened. To implement it, I can't use extensions and will be obliged to hack RB. What do you think about such feature? Could you please advise how it implement correctly? Thank you in advance, Michael. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Default tab configuration
Hi Christian, Thank you for quick reply and consultation. I think that my explanation might be misleading. Here is my quick simple draft of review process what we use: http://www.diagram.ly/?share=#5QAsM6HeuLnSY1gW2OXvb5lpTvOm4yaiBG2gGlOEQ7wAq0nnG0 My idea is to make link to request to be configurable in several cases. Administrator will be able to change default tabs in admin interface. This feature will minimize clicks / review time and make review process more direct. I'll try to implement it and share results with you. Best regards, Michael On Tuesday, October 2, 2012 12:40:25 AM UTC+4, Christian Hammond wrote: Hi Michael, Each page has its own URL. Flipping what /r/123/ and /r/123/diff/ points to doesn't really make any sense. The e-mails have a link to the review request, so users can always click on those. No need to change the View Diff link. Unless I'm missing something, there's nothing you really need to do differently here except click a different link. For the dashboard, you'd have to rewrite part of the code to change what the review request summary it links to. It's not something we'd accept upstream. That would be in reviewboard/reviews/datagrids.py. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 10:25 AM, Michael Zhilin miz...@gmail.comjavascript: wrote: Hi, We use RB since year 2009 and several reviewers requested default tab configuration. When reviewer opens review request first time, View Diff tab should be opened. Another case is tha when author/reviewer received email with review and click on link, View Reviews tab should be opened. To implement it, I can't use extensions and will be obliged to hack RB. What do you think about such feature? Could you please advise how it implement correctly? Thank you in advance, Michael. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Default tab configuration
Hi Michael, Unfortunately, I can't seem to view anything when clicking that link. I get an empty document. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 2:55 PM, Michael Zhilin miz...@gmail.com wrote: Hi Christian, Thank you for quick reply and consultation. I think that my explanation might be misleading. Here is my quick simple draft of review process what we use: http://www.diagram.ly/?share=#5QAsM6HeuLnSY1gW2OXvb5lpTvOm4yaiBG2gGlOEQ7wAq0nnG0 My idea is to make link to request to be configurable in several cases. Administrator will be able to change default tabs in admin interface. This feature will minimize clicks / review time and make review process more direct. I'll try to implement it and share results with you. Best regards, Michael On Tuesday, October 2, 2012 12:40:25 AM UTC+4, Christian Hammond wrote: Hi Michael, Each page has its own URL. Flipping what /r/123/ and /r/123/diff/ points to doesn't really make any sense. The e-mails have a link to the review request, so users can always click on those. No need to change the View Diff link. Unless I'm missing something, there's nothing you really need to do differently here except click a different link. For the dashboard, you'd have to rewrite part of the code to change what the review request summary it links to. It's not something we'd accept upstream. That would be in reviewboard/reviews/datagrids.**py. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 10:25 AM, Michael Zhilin miz...@gmail.com wrote: Hi, We use RB since year 2009 and several reviewers requested default tab configuration. When reviewer opens review request first time, View Diff tab should be opened. Another case is tha when author/reviewer received email with review and click on link, View Reviews tab should be opened. To implement it, I can't use extensions and will be obliged to hack RB. What do you think about such feature? Could you please advise how it implement correctly? Thank you in advance, Michael. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard...@** googlegroups.com For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Default tab configuration
Christian, Sorry for broken link. Please find attached picture file. Thank you, Michael On Tuesday, October 2, 2012 4:28:23 AM UTC+4, Christian Hammond wrote: Hi Michael, Unfortunately, I can't seem to view anything when clicking that link. I get an empty document. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 2:55 PM, Michael Zhilin miz...@gmail.comjavascript: wrote: Hi Christian, Thank you for quick reply and consultation. I think that my explanation might be misleading. Here is my quick simple draft of review process what we use: http://www.diagram.ly/?share=#5QAsM6HeuLnSY1gW2OXvb5lpTvOm4yaiBG2gGlOEQ7wAq0nnG0 My idea is to make link to request to be configurable in several cases. Administrator will be able to change default tabs in admin interface. This feature will minimize clicks / review time and make review process more direct. I'll try to implement it and share results with you. Best regards, Michael On Tuesday, October 2, 2012 12:40:25 AM UTC+4, Christian Hammond wrote: Hi Michael, Each page has its own URL. Flipping what /r/123/ and /r/123/diff/ points to doesn't really make any sense. The e-mails have a link to the review request, so users can always click on those. No need to change the View Diff link. Unless I'm missing something, there's nothing you really need to do differently here except click a different link. For the dashboard, you'd have to rewrite part of the code to change what the review request summary it links to. It's not something we'd accept upstream. That would be in reviewboard/reviews/datagrids.**py. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 1, 2012 at 10:25 AM, Michael Zhilin miz...@gmail.comwrote: Hi, We use RB since year 2009 and several reviewers requested default tab configuration. When reviewer opens review request first time, View Diff tab should be opened. Another case is tha when author/reviewer received email with review and click on link, View Reviews tab should be opened. To implement it, I can't use extensions and will be obliged to hack RB. What do you think about such feature? Could you please advise how it implement correctly? Thank you in advance, Michael. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard...@** googlegroups.com For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=enattachment: Post Review.png
