Re: Triggers
Scott, Would it be possible to share this code? Thanks, Brendan On Aug 20, 9:55 am, Scott Quesnelle scott.quesne...@gmail.com wrote: I modified the base code for reviewboard. Its one small change in the webapi code to trigger a generate_summary call when the close-submitted action is done. Then a new file which contains the generate_summary code and its appropriate template. The email code was used as the inspiration, and subtle modifications were made to suit the layout I thought best for the summary. This file is then written to the local disk and I have separate automation which pushes it into our bugtracking system. Scott On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote: Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog:http://arrizza.blogspot.com/ web:http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
Scott, Very nice, thanks for the tip! John On Fri, Aug 20, 2010 at 6:55 AM, Scott Quesnelle scott.quesne...@gmail.comwrote: I modified the base code for reviewboard. Its one small change in the webapi code to trigger a generate_summary call when the close-submitted action is done. Then a new file which contains the generate_summary code and its appropriate template. The email code was used as the inspiration, and subtle modifications were made to suit the layout I thought best for the summary. This file is then written to the local disk and I have separate automation which pushes it into our bugtracking system. Scott On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote: Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
I modified the base code for reviewboard. Its one small change in the webapi code to trigger a generate_summary call when the close-submitted action is done. Then a new file which contains the generate_summary code and its appropriate template. The email code was used as the inspiration, and subtle modifications were made to suit the layout I thought best for the summary. This file is then written to the local disk and I have separate automation which pushes it into our bugtracking system. Scott On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote: Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.comwrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
Christian, Sorry for taking so long to back to you as well... This is a great idea, should make a lot of things easier to connect up. John On Wed, Aug 18, 2010 at 12:25 PM, Christian Hammond chip...@chipx86.comwrote: Hi John, This support is coming in 1.6 in the form of WebHooks. On various operations, Review Board will perform an HTTP POST to a pre-specified URL, along with a payload of the changes. That script can then do whatever it wants, including turning around and posting on defect tracking systems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
Hi John, This support is coming in 1.6 in the form of WebHooks. On various operations, Review Board will perform an HTTP POST to a pre-specified URL, along with a payload of the changes. That script can then do whatever it wants, including turning around and posting on defect tracking systems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Aug 18, 2010 at 11:01 AM, JohnA cppge...@gmail.com wrote: Searched the doc and these forums but there doesn't seem to be any mention of triggers. Specifically I'd like to have ReviewBoard call a script when a review is closed. I'm going to use that trigger to add a note to the defect tracking system saying the reviews are done for that SCR. Is there a pre-existing trigger capability in Reviewboard (and I missed it)? John -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott On Wed, Aug 18, 2010 at 3:25 PM, Christian Hammond chip...@chipx86.comwrote: Hi John, This support is coming in 1.6 in the form of WebHooks. On various operations, Review Board will perform an HTTP POST to a pre-specified URL, along with a payload of the changes. That script can then do whatever it wants, including turning around and posting on defect tracking systems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Aug 18, 2010 at 11:01 AM, JohnA cppge...@gmail.com wrote: Searched the doc and these forums but there doesn't seem to be any mention of triggers. Specifically I'd like to have ReviewBoard call a script when a review is closed. I'm going to use that trigger to add a note to the defect tracking system saying the reviews are done for that SCR. Is there a pre-existing trigger capability in Reviewboard (and I missed it)? John -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
