Re: git trailing slash issue with post-review
It has been for years. We use it for Review Board itself. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 2, 2011 at 12:19 PM, Nirmam wrote: > The other question I had was is post-review working with git now ? > > > On Fri, Sep 2, 2011 at 11:45 AM, Christian Hammond wrote: > >> No, it's just a configuration in the .reviewboardrc in your git >> repository. >> >> post-review by default will look up the repository on Review Board using >> the origin remote path. If you instead have a .reviewboardrc at the root of >> the repository with: >> >> >> REPOSITORY = "name" >> >> Where "name" is the name given to that repository on Review Board, then it >> will look it up via that name instead, and ignore differences in the paths >> (like the trailing slash). >> >> Christian >> >> >> -- >> Christian Hammond - chip...@chipx86.com >> Review Board - http://www.reviewboard.org >> VMware, Inc. - http://www.vmware.com >> >> >> On Fri, Sep 2, 2011 at 11:32 AM, Nirmam wrote: >> >>> Yup it cannot find it bcoz there is slash at the end like "abc/". >>> >>> Changing config file in git ? Is that what you mean ? >>> >>> So while creating clones we will have to change the config file ? Correct >>> ? >>> >>> On Fri, Sep 2, 2011 at 11:25 AM, Christian Hammond >>> wrote: >>> What's the complaint? That it can't find the repository? If you can move your configuration to named repositories (see the post-review docs) that would solve that problem. Christian On Friday, September 2, 2011, Nirmam Sandesara wrote: > Hi, > I had a question where lets say when you try to do a > "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, > will the post review figure out the correct path ? > > Because we are hitting issues where post-review complains about the > trailing slash and fails. > > Are there workaround except changing the config file ? > > Thanks for your inputs. > > Nirmam > > -- > Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en >>> >>> >> > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
The other question I had was is post-review working with git now ? On Fri, Sep 2, 2011 at 11:45 AM, Christian Hammond wrote: > No, it's just a configuration in the .reviewboardrc in your git repository. > > post-review by default will look up the repository on Review Board using > the origin remote path. If you instead have a .reviewboardrc at the root of > the repository with: > > > REPOSITORY = "name" > > Where "name" is the name given to that repository on Review Board, then it > will look it up via that name instead, and ignore differences in the paths > (like the trailing slash). > > Christian > > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Fri, Sep 2, 2011 at 11:32 AM, Nirmam wrote: > >> Yup it cannot find it bcoz there is slash at the end like "abc/". >> >> Changing config file in git ? Is that what you mean ? >> >> So while creating clones we will have to change the config file ? Correct >> ? >> >> On Fri, Sep 2, 2011 at 11:25 AM, Christian Hammond >> wrote: >> >>> What's the complaint? That it can't find the repository? >>> >>> If you can move your configuration to named repositories (see the >>> post-review docs) that would solve that problem. >>> >>> Christian >>> >>> >>> >>> On Friday, September 2, 2011, Nirmam Sandesara >>> wrote: >>> > Hi, >>> > I had a question where lets say when you try to do a >>> > "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, >>> > will the post review figure out the correct path ? >>> > >>> > Because we are hitting issues where post-review complains about the >>> > trailing slash and fails. >>> > >>> > Are there workaround except changing the config file ? >>> > >>> > Thanks for your inputs. >>> > >>> > Nirmam >>> > >>> > -- >>> > Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> > Happy user? Let us know at http://www.reviewboard.org/users/ >>> > -~--~~~~--~~--~--~--- >>> > To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> > For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >>> >>> -- >>> -- >>> Christian Hammond - chip...@chipx86.com >>> Review Board - http://www.reviewboard.org >>> VMware, Inc. - http://www.vmware.com >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~--~~~~--~~--~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >>> >> >> > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
No, it's just a configuration in the .reviewboardrc in your git repository. post-review by default will look up the repository on Review Board using the origin remote path. If you instead have a .reviewboardrc at the root of the repository with: REPOSITORY = "name" Where "name" is the name given to that repository on Review Board, then it will look it up via that name instead, and ignore differences in the paths (like the trailing slash). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 2, 2011 at 11:32 AM, Nirmam wrote: > Yup it cannot find it bcoz there is slash at the end like "abc/". > > Changing config file in git ? Is that what you mean ? > > So while creating clones we will have to change the config file ? Correct ? > > On Fri, Sep 2, 2011 at 11:25 AM, Christian Hammond wrote: > >> What's the complaint? That it can't find the repository? >> >> If you can move your configuration to named repositories (see the >> post-review docs) that would solve that problem. >> >> Christian >> >> >> >> On Friday, September 2, 2011, Nirmam Sandesara >> wrote: >> > Hi, >> > I had a question where lets say when you try to do a >> > "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, >> > will the post review figure out the correct path ? >> > >> > Because we are hitting issues where post-review complains about the >> > trailing slash and fails. >> > >> > Are there workaround except changing the config file ? >> > >> > Thanks for your inputs. >> > >> > Nirmam >> > >> > -- >> > Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> > Happy user? Let us know at http://www.reviewboard.org/users/ >> > -~--~~~~--~~--~--~--- >> > To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> > For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> -- >> -- >> Christian Hammond - chip...@chipx86.com >> Review Board - http://www.reviewboard.org >> VMware, Inc. - http://www.vmware.com >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
Yup it cannot find it bcoz there is slash at the end like "abc/". Changing config file in git ? Is that what you mean ? So while creating clones we will have to change the config file ? Correct ? On Fri, Sep 2, 2011 at 11:25 AM, Christian Hammond wrote: > What's the complaint? That it can't find the repository? > > If you can move your configuration to named repositories (see the > post-review docs) that would solve that problem. > > Christian > > > > On Friday, September 2, 2011, Nirmam Sandesara wrote: > > Hi, > > I had a question where lets say when you try to do a > > "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, > > will the post review figure out the correct path ? > > > > Because we are hitting issues where post-review complains about the > > trailing slash and fails. > > > > Are there workaround except changing the config file ? > > > > Thanks for your inputs. > > > > Nirmam > > > > -- > > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > -- > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
What's the complaint? That it can't find the repository? If you can move your configuration to named repositories (see the post-review docs) that would solve that problem. Christian On Friday, September 2, 2011, Nirmam Sandesara wrote: > Hi, > I had a question where lets say when you try to do a > "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, > will the post review figure out the correct path ? > > Because we are hitting issues where post-review complains about the > trailing slash and fails. > > Are there workaround except changing the config file ? > > Thanks for your inputs. > > Nirmam > > -- > Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
git trailing slash issue with post-review
Hi, I had a question where lets say when you try to do a "git clone http:/xyz.com/abc/ and have a "trailing" slash at the end, will the post review figure out the correct path ? Because we are hitting issues where post-review complains about the trailing slash and fails. Are there workaround except changing the config file ? Thanks for your inputs. Nirmam -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
