Re: post-review not working with SVN post-commit hook

2010-06-09 Thread Petrus
Had the same problem with this, could run the hooks fine as my www-
data user but whenever a commit happens the hook would fail due to not
being able to create the .post-review-cookies.txt file. Ended up
adding cd /path/to/home/directory in the post-commit hook.

On May 18, 11:48 pm, Ryan Booz ry...@energycap.com wrote:
 I'm about at my whits end for what I thought would be a very simple
 task.  I have a Subversion server which can post to the ReviewBoard
 server with post-review just fine when run from the command line - as
 either root or apache (since SVN is accessed via Apache, post-commit
 is run as Apache).

 However, whenever I run it through the post-commit script it never
 posts any reviews.  When I log the output from the call to post-
 review, this is what I get:

  svn info file:///var/svn/general
  diff --version
  repository info: Path: file:///var/svn/general, Base path: /, Supports 
  changesets: False
  Looking for 'review.energycap.com /' cookie in .post-review-cookies.txt
  Couldn't load cookie file: [Errno 2] No such file or directory: 
  '.post-review-cookies.txt'

 == Review Board Login Required
 Enter username and password for Review Board athttp://review.energycap.com/

  Logging in with username ldapuser
  HTTP POSTing 
  tohttp://review.energycap.com/api/json/accounts/login/:{'username': 
  'ldapuser', 'password': '**'}

 There appears to be something in the environment that is not allowing
 this user to finish the login process - but I just can't figure it
 out.  It appears that the script, when run this way, doesn't get the
 Apache environment because it's looking for the cookie file in the
 current directory - wherever the heck that is.  When I run it from the
 command line, it tries to find that file in Apache (or roots) home
 directory as expected.

 That aside, it always stops at the POSTing... line.  So, either
 something isn't available to this user when called or I'm totally
 missing something obvious.

 Anyone have any hints?  BTW - this post-commit hook is also calling a
 Trac commit hook at the same time and works just fine.

 I'd really appreciate the help.
 Ryan

 --
 Want to help the Review Board project? Donate today 
 athttp://www.reviewboard.org/donate/
 Happy user? Let us know athttp://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group 
 athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Every patch failing on new RB install w/Mercurial

2010-06-09 Thread Gordon Morehouse
I've upgraded from 1.0.8 to 1.5b2 and this is still happening.  This
is on a server running Ubuntu 10.04; I'm wondering if it has to do
with something on the server and if anybody else is seeing (or not
seeing) similar issues on Ubuntu 10.04.  Again, I've examined the .rej
file and the .diff file dumped into /tmp and this does not appear to
be a case of line-ending issues.

I'm kind of at a loss at this point for how to continue to
troubleshoot this issue. 'patch' is failing on an incredibly simple
patch:

/tmp/reviewboard.9HV3Hs# cat install.py.diff
diff -r a5dc3a9027ca -r b039ee5a3c25 install.py
--- a/install.pyWed Jun 09 10:19:15 2010 -0700
+++ b/install.pyWed Jun 09 10:39:57 2010 -0700
@@ -1,3 +1,5 @@
+# install.py
+
 order = 99
 install_data = (
 ('install/workgroup', None),


Here's the reject file:

/tmp/reviewboard.9HV3Hs# cat tmpYvMLPF-new.rej
--- install.py  Wed Jun 09 10:19:15 2010 -0700
+++ install.py  Wed Jun 09 10:39:57 2010 -0700
@@ -1,3 +1,5 @@
+# install.py
+
 order = 99
 install_data = (
 ('install/workgroup', None),

And the error message and traceback:

Traceback (most recent call last):
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset, highlighting, True)
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
diffutils.py, line 881, in get_diff_files
large_data=True)
  File /usr/local/lib/python2.6/dist-packages/djblets/util/misc.py,
line 166, in cache_memoize
data = lookup_callable()
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
diffutils.py, line 880, in lambda
enable_syntax_highlighting)),
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
diffutils.py, line 531, in get_chunks
new = get_patched_file(old, filediff)
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
diffutils.py, line 356, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
  File /usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/
diffutils.py, line 224, in patch
(filename, tempdir, patch_output))
Exception: The patch to 'install.py' didn't apply cleanly. The
temporary files have been left in '/tmp/reviewboard.9HV3Hs' for
debugging purposes.
`patch` returned: patching file /tmp/reviewboard.9HV3Hs/tmpYvMLPF
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.
9HV3Hs/tmpYvMLPF-new.rej

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


CVS and ext - any success?

2010-06-09 Thread Matt Brown
Hi, I am trying to set up reviewboard to connect to a CVS repository
using the ext (ssh) method. This is the only connection method that my
repository allows.

I've been getting a number of error messages when I attempt to upload
a review with post-review around Host key verification failed.

I figured that this might have something to do with the Apache user
not being able to connect via ssh to the repository. I created a .ssh
directory in the user's home directory (/var/www) and made sure it was
owned by the Apache user and read/writable by only that user. However,
I still get the same error message

 HTTP POSTing to 
 http://localhost/reviewboard/api/json/reviewrequests/20/diff/new/: {}
 Got API Error 105 (HTTP code 200): One or more fields had errors
 Error data: {u'fields': {u'path': [u'Host key verification failed.\r\ncvs 
 [checkout aborted]: end of file from server (consult above messages if 
 any)\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had 
 errors', u'code': 105}}


Searching this discussion group, it sounds like there were some
reports of users unable to get cvs and ext to work with reviewboard
from July 2008, and then a few messages about provisional support
being added in later versions.

I'm just curious, is anyone today using ReviewBoard 1.5 (or any other
recent version) with CVS and ext/ssh?

Thanks
Matt

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


post-review not working with ClearCase - RB1.5B2 on Windows

2010-06-09 Thread Martelo
What I've Done:

win #01 (RB server)
1 - Set up a new dynamic view (just one vob mounted) in Z:/ drive
2 - Create a new Repository as follows: Name: RepoCC Path: Z:/

win #02 (Client)

1 - Install python 2.5 + SetupTools + DiffUtills + FindUtiils + sed +
RBTools
2 - Set up a new dynamic view (same one vob mounted) in Z:/ drive
3 - Checkout one file. Change and save it
4 - Create a new file .reviewboardrc in the users appdata pointing to
RB server
5 - Run cleartool lsco -cview -me -recurse -short | sed s//\//g
| xargs post-review  --
username=user --password=12345

The error is:
--
There was an error creating this review request.

The repository path /view/reviewboard.diffview/vobs/ is not in the
list of known repositories on the server.
--

How do I set what repository should be used???
What I've done wrong or missed?

Thanks,
Martelo.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Issue 1644 in reviewboard: ClearCase malformed diff after patching Python difflib

2010-06-09 Thread reviewboard


Comment #1 on issue 1644 by Jan.Koprowski: ClearCase malformed diff after  
patching Python difflib

http://code.google.com/p/reviewboard/issues/detail?id=1644

I have one line which looks like:
int abc ;^M  // some variable

and I get malformed diff for revision where this line was add. How I can  
avoid problem with this line?




--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 242 in reviewboard: OpenID authentication support

2010-06-09 Thread reviewboard


Comment #9 on issue 242 by mitch...@kde.org: OpenID authentication support
http://code.google.com/p/reviewboard/issues/detail?id=242

Philippe,

I'm really interested in this too -- has you, or anyone you know,  
successfully added this to ReviewBoard using the above plugin?


I know you can use the Custom backend, but I'm only just looking at  
ReviewBoard so I'm not sure how easy it is to define it to use the  
necessary views and all that are required for the OpenID authentication.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 775 in reviewboard: Issues when using Review Board with the It's All Text Firefox Extension

2010-06-09 Thread reviewboard


Comment #9 on issue 775 by jrodman: Issues when using Review Board with  
the It's All Text Firefox Extension

http://code.google.com/p/reviewboard/issues/detail?id=775

Having this problem with It's All Text 1.3.1.
Perhaps our Reviewboard version is stale? I am not seeing any way to derive  
the reviewboard installation version from the UI.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.