How to submit review for merging branch to trunk?
(Using Subversion...) I have some code checked in on a branch. Before merging back to trunk I would like to create a review request for the merge. It's not clear at all to me how I would do that with post-review (or even using the form on the website). In post-review --help output I see mention of a --branch=BRANCH option, but there's no example to suggest the form BRANCH is supposed to take. In the past I've just updated my trunk sandbox from the branch and used post-review there. Is that the correct approach? Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to submit review for merging branch to trunk?
On Tue, Oct 19, 2010 at 18:55, wrote: > (Using Subversion...) > > I have some code checked in on a branch. Before merging back to trunk I > would like to create a review request for the merge. It's not clear at all > to me how I would do that with post-review (or even using the form on the > website). In post-review --help output I see mention of a --branch=BRANCH > option, but there's no example to suggest the form BRANCH is supposed to > take. In the past I've just updated my trunk sandbox from the branch and > used post-review there. Is that the correct approach? Yep, I'd merge to your working copy of trunk and submit the review from there before committing. --branch=BRANCH is just for documentation purposes and will show up in the review request. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Reviewboard with Dreamhost
Hi guys do you have any tips on how to install it on dreamhost.com ? Regards, Diego Garcia -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Hi,
I seem to be having the same problem as is described in this post:
http://groups.google.com/group/reviewboard/browse_thread/thread/96cc585e78b71033/904fb717a35f9f2c
On the client (post-review) side I see this:
---
Enter username and password for "Please Enter Your [DOMAIN] LDAP
Credentials" at reviewboard.domain.net
Username: user
Password:
>>> HTTP GETting /api/json/repositories/1/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended
>>> information for this repository.
>>> Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
>>> u'err': {u'msg': u'There was an error fetching extended information for
>>> this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/4/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended
>>> information for this repository.
>>> Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
>>> u'err': {u'msg': u'There was an error fetching extended information for
>>> this repository.', u'code': 210}}
>>> Attempting to create review request on
>>> http://svn.domain.net/svn/repositories/repo for None
>>> HTTP POSTing to http://reviewboard.domain.net/api/json/reviewrequests/new/:
>>> {'repository_path': 'http://svn.domain.net/svn/repositories/repo'}
>>> Review request created
>>> Uploading diff, size: 18990
>>> HTTP POSTing to
>>> http://reviewboard.domain.net/api/json/reviewrequests/31/diff/new/:
>>> {'basedir': '/dir1/trunk'}
>>> Got API Error 105 (HTTP code 200): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u"URL
>>> 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is
>>> malformed or the scheme or host or path is missing"]}, u'stat': u'fail',
>>> u'err': {u'msg': u'One or more fields had errors', u'code': 105},
>>> u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
---
On the server side i see this:
---
2010-10-19 19:07:20,764 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 18990
2010-10-19 19:07:20,766 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-10-19 19:07:20,767 - ERROR - Error uploading new diff: URL
'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'
is malformed or the scheme or host or path is missing
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/webapi/json.py", line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/reviews/forms.py", line 249, in create
history)
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py", line 62, in create
files = list(self._process_files(
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py", line 144, in _process_files
if (revision != PRE_CREATION and
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/core.py", line 68, in file_exists
self.get_file(path, revision)
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/svn.py", line 144, in get_file
raise SCMError(e)
SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/
dir2/file.xml' is malformed or the scheme or host or path is missing
---
I didn't find much after googling around for a while. Most of the
other people who encountered this error had spaces in their URLs or
something weird like that. My URLs look correct/normal, so I don't
know what's causing this error. Also, if I do svn info on that exact
URL (or open it in my browser), it works fine. I did get one review
to actually post correctly (with an almost identical URL), so it has
worked at least once. Does anyone have any ideas what might be wrong?
Thanks,
James
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Hi James,
That is indeed strange. Without seeing the URL, it's hard to say. Is this
indeed a fully-qualified domain?
Just as a sanity check, would you feel comfortable e-mailing me privately
the full path?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Oct 19, 2010 at 4:26 PM, James wrote:
> Hi,
>
> I seem to be having the same problem as is described in this post:
>
> http://groups.google.com/group/reviewboard/browse_thread/thread/96cc585e78b71033/904fb717a35f9f2c
>
> On the client (post-review) side I see this:
>
> ---
>
> Enter username and password for "Please Enter Your [DOMAIN] LDAP
> Credentials" at reviewboard.domain.net
> Username: user
> Password:
> >>> HTTP GETting /api/json/repositories/1/info/
> >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> information for this repository.
> >>> Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
> u'err': {u'msg': u'There was an error fetching extended information for this
> repository.', u'code': 210}}
> >>> HTTP GETting /api/json/repositories/4/info/
> >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> information for this repository.
> >>> Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
> u'err': {u'msg': u'There was an error fetching extended information for this
> repository.', u'code': 210}}
> >>> Attempting to create review request on
> http://svn.domain.net/svn/repositories/repo for None
> >>> HTTP POSTing to
> http://reviewboard.domain.net/api/json/reviewrequests/new/:
> {'repository_path': 'http://svn.domain.net/svn/repositories/repo'}
> >>> Review request created
> >>> Uploading diff, size: 18990
> >>> HTTP POSTing to
> http://reviewboard.domain.net/api/json/reviewrequests/31/diff/new/:
> {'basedir': '/dir1/trunk'}
> >>> Got API Error 105 (HTTP code 200): One or more fields had errors
> >>> Error data: {u'fields': {u'path': [u"URL '
> http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is
> malformed or the scheme or host or path is missing"]}, u'stat': u'fail',
> u'err': {u'msg': u'One or more fields had errors', u'code': 105},
> u'deprecated': {u'in_version': u'1.5'}}
>
> Error uploading diff
>
> The generated diff file was empty. This usually means no files were
> modified in this change.
>
> ---
>
> On the server side i see this:
>
> ---
>
> 2010-10-19 19:07:20,764 - DEBUG - DiffParser.parse: Beginning parse of
> diff, size = 18990
> 2010-10-19 19:07:20,766 - DEBUG - DiffParser.parse: Finished parsing
> diff.
> 2010-10-19 19:07:20,767 - ERROR - Error uploading new diff: URL
> 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'
> is malformed or the scheme or host or path is missing
> Traceback (most recent call last):
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/webapi/json.py", line 1169, in new_diff
>request.FILES.get('parent_diff_path'))
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/reviews/forms.py", line 249, in create
>history)
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/diffviewer/forms.py", line 62, in create
>files = list(self._process_files(
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/diffviewer/forms.py", line 144, in _process_files
>if (revision != PRE_CREATION and
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/scmtools/core.py", line 68, in file_exists
>self.get_file(path, revision)
> File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
> reviewboard/scmtools/svn.py", line 144, in get_file
>raise SCMError(e)
> SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/
> dir2/file.xml'
> is malformed or the scheme or host or path is missing
>
> ---
>
> I didn't find much after googling around for a while. Most of the
> other people who encountered this error had spaces in their URLs or
> something weird like that. My URLs look correct/normal, so I don't
> know what's causing this error. Also, if I do svn info on that exact
> URL (or open it in my browser), it works fine. I did get one review
> to actually post correctly (with an almost identical URL), so it has
> worked at least once. Does anyone have any ideas what might be wrong?
>
> Thanks,
> James
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/g
