Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #5 on issue 1348 by premek.paska: Expanding hidden lines broken by
the 1.0.3 update
http://code.google.com/p/reviewboard/issues/detail?id=1348
There are no JS errors reported by Firebug.
The strange thing is that all Expand links within one file use the same
HTTP request:
javascript:expandChunk('file1', '1147', '1', null, '12', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
javascript:expandChunk('file1', '1147', '1', null, '19', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
The next file:
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
etc.
And consequently, all responses for different links within the file are the
same:
One of them starts with this html code:
tbody id=chunk0.1
tr line=26
th26/th
tdprespan class=p{/span/pre/td
th26/th
tdprespan class=p{/span/pre/td
/tr
tr line=27
th27/th
...
I compared the responses and realized that they always return the first
five lines of
the file that are already displayed (first lines of the file's diff). So
never the
correct lines.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #17 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 hi chipx86, How to work around the issue HTTPS Subversion repositories don't work with Review Board? I'm a little confused with your explanation, so could you please explain it in detail? thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1352 in reviewboard: Uncaught TypeError when entering multiple lengthy bug #s for a review request
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1352 by th...@ginkel.com: Uncaught TypeError when entering multiple lengthy bug #s for a review request http://code.google.com/p/reviewboard/issues/detail?id=1352 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.4 What's the URL of the page containing the problem? https://reviewboard.domain/api/json/reviewrequests/#/publish/ What steps will reproduce the problem? 1. Post a review for a repository that has an issue tracker assigned 2. Enter two lengthy numerical bug IDs, such as 012006153200030304432009, 012006153200030304432010 3. Publish What is the expected output? What do you see instead? Sorting the bug #s fails with a TypeError, which is not anticipated by the code: Request Method: POST Request URL: https://reviewboard.domain/api/json/reviewrequests/#/publish/ Exception Type: TypeError Exception Value: comparison function must return int Exception Location: [...]\reviewboard\reviews\models.py in get_bug_list, line 550 549 : try: 550 : bugs.sort(cmp=lambda x,y: int(x) - int(y)) 551 : except ValueError: 552 : bugs.sort() -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #6 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Sounds like this would be the cause, though it's still not happening here. I'll try to repro it some more. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #18 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 There are two options: 1) Upgrade to the 1.1 development branch (which, being in-development, may be unstable and probably isn't suitable for development use). 2) Figure out what the home directory is for Apache (I don't know on Windows, but you may be able to figure it out by turning on logging and temporarily modifying, say, reviewboard/__init__.py to add: logging.info(Home directory = %s % os.path.expanduser(~)) to the very end of the file. Then restart Apache, go to a URL, and check the log file. Once you have this, create a .subversion directory inside that directory. Then, using command line tools, do an svn checkout of the URL you need. It should verify your certificate or user information. You'll then need to take your own ~/.subversion directory and copy all the contents into the .subversion directory you created for Apache, and make sure the .subversion directory and everything inside of it is writable by the web server. Note that I have not done this on Windows, so you may have to play around with this a bit. The problem should go away, though, in 1.1. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
