Issue 2085 in reviewboard: Server error when deleting comments on the same line

2011-04-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2085 by joncarb...@gmail.com: Server error when deleting comments  
on the same line

http://code.google.com/p/reviewboard/issues/detail?id=2085

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.5

What's the URL of the page containing the problem?
/reviewboard/api/json/reviewrequests/6/diff/1/file/145/line/740/comments/

What steps will reproduce the problem?
1. Make a comment in a review
2. Make another comment that is larger (encompasses more lines) than the  
first one, but starts on the same line. i.e. Make a comment on line 3 of a  
file, then another comment on lines 3-5 of a file.
3. Select the larger comment that encompasses the smaller comment and  
delete it.

4. Select the remaining smaller comment and delete it.

What is the expected output? What do you see instead?
The expected output is that the smaller comment is deleted. Instead, the  
smaller comment is not deleted and A server error occurred. is displayed  
at the top of the page.


What operating system are you using? What browser?
Windows 7 64-bit. Server is running Fedora 7. Browser is Firefox 4.0.

Please provide any additional information below.
Occurs most of the time when the steps above are followed. Unable to  
determine what causes it to work sometimes. This is the output when Show  
Details is clicked (the Response Data didn't appear to have any useful  
information in it):


Error Code: 404
Error Text: Not Found
Request URL:  
/reviewboard/api/json/reviewrequests/6/diff/1/file/144/line/302/comments/

Request Data: action=deletenum_lines=1



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2086 in reviewboard: postreview unhandled exception

2011-04-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2086 by matt.neumayr: postreview unhandled exception
http://code.google.com/p/reviewboard/issues/detail?id=2086

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
RBTools 0.3.2
Review Board 1.5.4

What steps will reproduce the problem?
1. edited some minor changes in  
https://github.com/bb-generation/gobby/blob/gobby-infinote/code/core/preferences.cpp  
and the corresponding header file in a new branch
2. tried to create a new review-request using post-review  
--parent=oldbranch


What is the expected output? What do you see instead?
review request XX posted

Instead:
Traceback (most recent call last):
  File /usr/bin/post-review, line 9, in module
load_entry_point('RBTools==0.3.2', 'console_scripts', 'post-review')()
  File /usr/lib/python2.7/site-packages/rbtools/postreview.py, line 3795,  
in main

submit_as=options.submit_as)
  File /usr/lib/python2.7/site-packages/rbtools/postreview.py, line 3461,  
in tempt_fate

parent_diff_content)
  File /usr/lib/python2.7/site-packages/rbtools/postreview.py, line 769,  
in upload_diff

fields, files)
  File /usr/lib/python2.7/site-packages/rbtools/postreview.py, line 983,  
in api_post

return self.process_json(self.http_post(path, fields, files))
  File /usr/lib/python2.7/site-packages/rbtools/postreview.py, line 904,  
in http_post

data = urllib2.urlopen(r).read()
  File /usr/lib/python2.7/urllib2.py, line 126, in urlopen
return _opener.open(url, data, timeout)
  File /usr/lib/python2.7/urllib2.py, line 392, in open
response = self._open(req, data)
  File /usr/lib/python2.7/urllib2.py, line 410, in _open
'_open', req)
  File /usr/lib/python2.7/urllib2.py, line 370, in _call_chain
result = func(*args)
  File /usr/lib/python2.7/urllib2.py, line 1197, in http_open
return self.do_open(httplib.HTTPConnection, req)
  File /usr/lib/python2.7/urllib2.py, line 1166, in do_open
h.request(req.get_method(), req.get_selector(), req.data, headers)
  File /usr/lib/python2.7/httplib.py, line 941, in request
self._send_request(method, url, body, headers)
  File /usr/lib/python2.7/httplib.py, line 975, in _send_request
self.endheaders(body)
  File /usr/lib/python2.7/httplib.py, line 937, in endheaders
self._send_output(message_body)
  File /usr/lib/python2.7/httplib.py, line 795, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 787:  
ordinal not in range(128)



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2088 in reviewboard: Bad error when creating a review with an invalid change number.

2011-04-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2088 by matt.mul...@gmail.com: Bad error when creating a review  
with an invalid change number.

http://code.google.com/p/reviewboard/issues/detail?id=2088

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
Review Board 1.5.5

What's the URL of the page containing the problem?
/r/new

What steps will reproduce the problem?
1. From the dashboard click New Review Request
2. Select a (Perforce?) repository and enter a bogus change number and  
click Create

3. See the Something Broke! page and wait for the admin email

What is the expected output? What do you see instead?
I expect to see some error about an invalid changelist number and to not  
get an email to the admin.


Instead I see the Something Broke! page and get an email with a traceback  
ending in:
 File .../ReviewBoard-1.5.5-py2.6.egg/reviewboard/reviews/forms.py, line  
144, in create

raise ChangeSetError()

TypeError: __init__() takes exactly 2 arguments (1 given)

What operating system are you using? What browser?
The Review Board server is running on Red Hat EL 5.5.
The browser is Chrome 11 beta on Windows 7.

Please provide any additional information below.

I love Review Board, it has been tremendously useful at our company. Keep  
up the great work!



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2087 in reviewboard: Adding inline comments isn't working...

2011-04-27 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 831

Comment #1 on issue 2087 by trowb...@gmail.com: Adding inline comments  
isn't working...

http://code.google.com/p/reviewboard/issues/detail?id=2087

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-04-27 Thread reviewboard


Comment #23 on issue 831 by trowb...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 2087 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1242 in reviewboard: Export as CSV feature

2011-04-27 Thread reviewboard


Comment #6 on issue 1242 by deepapar...@gmail.com: Export as CSV feature
http://code.google.com/p/reviewboard/issues/detail?id=1242

Is there any patch that can be applied to get this functionality. I am  
using 1.0 version


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.